rm5248 commented on code in PR #6815: URL: https://github.com/apache/incubator-nuttx/pull/6815#discussion_r943051992
########## arch/mips/src/pic32mx/pic32mx_lowinit.c: ########## @@ -192,6 +247,12 @@ void pic32mx_lowinit(void) up_earlyserialinit(); #endif +#if CONFIG_PIC32MX_JTAG_ENABLE Review Comment: I've configured it to disable JTAG by default. Conditionally enabling the functions in terms of code space doesn't make sense(as any level of optimization will cause uncalled methods to not emit any code), but it might make sense to conditionally compile functions in or out to suppress compiler warnings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
