rm5248 commented on code in PR #6815: URL: https://github.com/apache/incubator-nuttx/pull/6815#discussion_r941913025
########## arch/mips/src/pic32mx/pic32mx_lowinit.c: ########## @@ -192,6 +247,12 @@ void pic32mx_lowinit(void) up_earlyserialinit(); #endif +#if CONFIG_PIC32MX_JTAG_ENABLE Review Comment: The PIC32MX defaults to enabling JTAG, so by default calling `pic32mx_enable_jtag` should be a no-op. I did it explicitly since otherwise it was more difficult to follow the logic(double negation). The option `PIC32MX_JTAG_ENABLE` was chosen since there is already a `PIC32MZ_JTAG_ENABLE`, but if there is a better name for it that would be good to know. I'll fix those compiler errors in a bit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
