acassis commented on code in PR #6815:
URL: https://github.com/apache/incubator-nuttx/pull/6815#discussion_r941427112


##########
arch/mips/src/pic32mx/pic32mx_lowinit.c:
##########
@@ -192,6 +247,12 @@ void pic32mx_lowinit(void)
   up_earlyserialinit();
 #endif
 
+#if CONFIG_PIC32MX_JTAG_ENABLE

Review Comment:
   > What is the HW default? Why not do this as compile time option?.
   
   I'm also confuse, could you please explain @davids5 ? He created an Kconfig 
option to disable JTAG, same config exist for STM32, and others.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to