davids5 commented on code in PR #6815: URL: https://github.com/apache/incubator-nuttx/pull/6815#discussion_r942304646
########## arch/mips/src/pic32mx/pic32mx_lowinit.c: ########## @@ -192,6 +247,12 @@ void pic32mx_lowinit(void) up_earlyserialinit(); #endif +#if CONFIG_PIC32MX_JTAG_ENABLE Review Comment: This may be considered a security issue. It is also a minor waste of code space. It would be better to have a compile time setting to Disable in the first code after reset, that is if it can not be disabled by a fuse setting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
