abdessalems commented on PR #11727: URL: https://github.com/apache/seatunnel/pull/11727#issuecomment-5646715055
@davidzollo @DanielLeens @SEZ9 — now that #11757 is closed in favour of #12238, worth settling how that interacts with this PR before either merges. #11727 carries three commits cherry-picked from #11757 (588314d9c, 1fed68145, 912e8bd4c) plus the later work on top. #12238 solves the same problem a different way — re-keying the futures by TaskGroupContext rather than the OwnedFuture tagging here. If both land we'd have two ownership models in the same methods. This PR's original scope was just the unconditional startedLatch release for #11679; the ownership model was cherry-picked here in August at @DanielLeens's and @davidzollo's suggestion, before #12238 existed. So: would you prefer #12238 lands first and I strip this back to the latch fix for #11679? Or this merges first and #12238 rebases? Either works for me — I'd rather ask than have the two conflict. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
