abdessalems commented on PR #11727: URL: https://github.com/apache/seatunnel/pull/11727#issuecomment-5644359192
@SEZ9 per-finding status on the current head: F1 — deferred. The publish/rollback race in deployLocalTask() is tracked in #12164; not addressed here. F3 — addressed. The Javadoc now describes what is actually guaranteed: deployTask(TaskGroupImmutableInformation) opens synchronized (this) at line 528 and the deployLocalTask(...) call at line 550 sits inside it, so that entry point is covered; a caller reaching deployLocalTask directly is not, and the text says so and points at #12164. F2 — addressed. BlockingWorker resolves its context and class loader from the tracker's ownedContext, not the shared executionContexts map. F4 — addressed. The stale path cancels the old generation's async-function and timer-flush entries. They carry the owning context (OwnedFuture wrapper), so cancelOwnedAsyncFunctionsInPlace / cancelOwnedTimerFlushTasksInPlace touch only this generation's entries and leave a newer generation's untouched. F5 — deferred with F1 to #12164 (same plain-put install path). F6 — addressed. The TaskExecutionService.this monitor now covers only the ownership check and the map/future bookkeeping; recycleClassLoader and all cancellations run after it is released. F8 — addressed. The redundant get is gone: finishExecutionContext goes straight to executionContexts.remove(taskGroupLocation, ownedContext) at line 1724. The stale path deliberately does not move ownedContext into finishedExecutionContexts, and there is now a comment there saying why — TaskGroupLocation is reused across generations, so filing it under a key a newer generation owns would make later lookups resolve the wrong context. F7 — noted in the PR description as deferred. On CI: @DanielLeens was right about the cause. I've merged the latest dev into the branch — RocketMqIT now has the waitForTopicRoute() calls that close the broker-route race, which this branch was missing. Rerunning CI on the new head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
