DanielLeens opened a new issue, #12655:
URL: https://github.com/apache/seatunnel/issues/12655
Follow-up requested in review of #11545.
**Problem.** `seatunnel-connectors-v2/connector-lance/pom.xml` configures
its own maven-surefire-plugin with `<argLine>${surefire.jvm.args}</argLine>`
and sets `surefire.jvm.args` itself (with a JDK-activated profile that adds
`--add-opens=java.base/java.nio=ALL-UNNAMED`). That module therefore bypasses
the root pom's `<argLine>${surefire.jvm.args}
${surefire.module.args}</argLine>` and never receives the shared JDK 9+ module
flags.
**Observed effect.** When the CI unit-test step stopped repeating the module
flags in `SUREFIRE_JVM_ARGS`, `-Dsurefire.jvm.args` on the command line also
replaced the module's own profile value, and the `connector-lance` unit tests
failed on JDK 17 (ubuntu and windows) with `InaccessibleObjectException: Unable
to make field long java.nio.Buffer.address accessible: module java.base does
not "opens java.nio"` (Arrow `MemoryUtil`). `LanceSinkTest`, `LanceCatalogTest`
and `FragmentConverterTest` were affected (fork run 37317968844). The flags
were restored in the CI unit-test step in #11545 as a workaround.
**Why it matters.** The workaround means the unit-test lane repeats the
module flags and no longer proves that `surefire.module.args` is sufficient by
itself, and anyone who later removes the repetition as redundant will break
`connector-lance` again.
**Suggested change.** Make `connector-lance` inherit the root argLine (drop
its own `<argLine>`/`surefire.jvm.args` override, or append
`${surefire.module.args}` to it), keep the Mac `os.arch`/`os.name` overrides it
needs, and then remove the repeated flags from `SUREFIRE_JVM_ARGS` in
`.github/workflows/backend.yml`. This is a `pom.xml` change and should be
reviewed on its own.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
