DanielLeens commented on issue #12655:
URL: https://github.com/apache/seatunnel/issues/12655#issuecomment-6096349316
Classification: F / Connector-V2 Lance Surefire-argLine inheritance.
The prerequisite has now landed: #11545 was merged into `dev` on 2026-10-09,
and current `dev` defines the root Surefire/Failsafe argLine as
`${surefire.jvm.args} ${surefire.module.args}`. I rechecked the current module
POM as well: `connector-lance` still overrides the argLine, so the original
inheritance problem remains unresolved.
Please keep this to **one** implementation. #12662 is already the open
POM-only PR for this issue; do not open a second replacement PR. @Rangsh and
@SwatiKumari250, please coordinate on that existing PR, rebase it onto current
`dev`, and make its final scope precise:
1. Remove the connector-level Surefire `<argLine>` and the JDK-specific
`--add-opens` override so the module inherits the root module flags. The
retained macOS ARM profiles must contain only the required `os.arch` /
`os.name` overrides, not a second copy of the module flags.
2. Keep the diff limited to that POM behavior; restore the unrelated
ASF-header whitespace changes. The workflow `SUREFIRE_JVM_ARGS` cleanup remains
a later, separate PR after this POM change is merged.
3. Enable the fork workflow (the current #12662 Build is `ACTION_REQUIRED`)
and provide a JDK 17 `connector-lance` test result with `-Dsurefire.jvm.args`
deliberately excluding the `--add-opens` values. That demonstrates the flags
actually arrive through the new root `${surefire.module.args}` path.
4. Include the local-override scan in the later workflow PR, rather than
broadening this POM PR.
This keeps the fix compatible for JDK 8/11/17, avoids duplicate ownership,
and gives CI a final, rebased configuration to verify.
No label or assignment change in this pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
