Rangsh commented on issue #12655:
URL: https://github.com/apache/seatunnel/issues/12655#issuecomment-6031469991
Hi @SEZ9, thanks for the detailed feedback! Fully agreed:
1. I'll wait for #11545 to merge (or rebase once it does) so CI exercises
the final root argLine.
2. I'll keep the `pom.xml` change and the `backend.yml` cleanup as separate
PRs, and verify the `connector-lance` unit tests on JDK 17 with a
`-Dsurefire.jvm.args` that does **not** include the `--add-opens` flags before
removing them from `SUREFIRE_JVM_ARGS`.
3. I'll also scan other modules for local `<argLine>`/`surefire.jvm.args`
overrides so the cleanup doesn't break anything else.
@SwatiKumari250 thanks for the PR (#12662)! Just to sync up: I'm already
committed to this issue with the plan above, and as @SEZ9 pointed out, the fix
relies on inheriting the root `<argLine>${surefire.jvm.args}
${surefire.module.args}</argLine>` from #11545 — `surefire.module.args` doesn't
exist on the current `dev` branch yet, so the inheritance can't be verified
there. Could you close #12662 for now to avoid duplicated effort? I'll take
this forward once #11545 lands, and your review and suggestions on my PRs would
definitely be welcome. Thanks! cc @SEZ9 @DanielLeens
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
