SEZ9 commented on issue #12655:
URL: https://github.com/apache/seatunnel/issues/12655#issuecomment-6029910346
Thanks @Rangsh, the plan sounds right to me. Dropping the module-level
`<argLine>`/`surefire.jvm.args` override in `connector-lance/pom.xml` (and the
profile that adds `--add-opens`) while keeping only the Mac `os.arch`/`os.name`
overrides should let the module inherit the root `${surefire.jvm.args}
${surefire.module.args}` argLine; if a lance-specific flag turns out to be
needed, appending `${surefire.module.args}` to the module argLine is the
alternative.
Two suggestions:
1. Please keep the `pom.xml` change and the `.github/workflows/backend.yml`
cleanup as separate steps so the pom change can be reviewed on its own, and
verify the `connector-lance` unit tests on JDK 17 with `-Dsurefire.jvm.args`
set to a value that does not include the `--add-opens` flags before removing
the repetition from `SUREFIRE_JVM_ARGS`.
2. It would be worth checking whether any other connector module overrides
`<argLine>` or `surefire.jvm.args` the same way, so the workflow cleanup does
not break another module.
On basing the PR: since the pom change depends on the root argLine from
#11545, I'd suggest waiting for that to merge (or rebasing once it does) so CI
exercises the final configuration.
<!-- streview-comment:1573 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
