On 10/5/16 12:32 PM, Stephen Colebourne wrote:
On 5 October 2016 at 17:07, Jonathan Bluett-Duncan
<jbluettdun...@gmail.com> wrote:
Stephen, thank you for getting back about DateTimeFormatter. It's not clear
to me what should be done with
TCKDateTimeFormatter::test_resolverFields_listOfOneNull in this case. Do I
delete it; or do I change it to test that a null TemporalField param causes
a NullPointerException to be thrown; or do I do something else? May I have
your continued thoughts on this?

I think you should perform no change to DateTimeFormatter (other than
a comment) as part of this changeset. The behaviour of that
DateTimeFormatter method is subtle, and I now suspect that what we
have there might be the best option.

I had recommended removing the comment from DateTimeFormatter, but if Stephen wants the comment in, that's fine with me. In fact I'll defer to what Stephen (and Roger Riggs) want with this code, since they're the maintainers.

s'marks

Reply via email to