Hi Stuart, > It appears that the changes to remove the links to > Collections.unmodifiableList() was dropped from webrev.01 to webrev.02. I've > restored them, along with a couple other changes that were also dropped. I > also updated the ModuleFinder.java comment per a request from Alan Bateman. > The revised webrev is here: > > http://cr.openjdk.java.net/~smarks/reviews/8134373/webrev.03/
looks good. Thanks! Best regards, Andrej Golovnin > > In any case, yes, the specifications of the ResourceBundle.Control fields > should be changed to remove the links to Collections.unmodifiableList(). > It's unclear whether having a link this way implies that it's part of the > specification that these fields must be instances returned from that method. > Removing the link makes it clear that saying the List is unmodifiable is > merely a description of the required behavior. > > I spoke with Joe Darcy (our compatibility guru) and we agreed that out of an > abundance of caution it would be wise to file a request to make this change. > (This is the "CCC" - basically an internal change control process for Java > SE specifications.) Doing this is mainly for tracking purposes, as we > believe this to be a compatible change. > > I've also included in this request a mention of the change to > CookieManager.get() which we had discussed previously. Even though we > believe this is also a compatible change, it's also a change that should be > tracked. > > I'll follow up when this bit of process is finished. > > s'marks
