On Tue, 24 Mar 2026 11:45:24 GMT, Alan Bateman <[email protected]> wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Change "the empty string" to "an empty string"
>
> src/java.base/share/classes/java/util/zip/ZipOutputStream.java line 146:
>
>> 144: *
>> 145: * @param comment the comment string. Passing {@code null} or
>> an empty string
>> 146: * will result in the output having no ZIP file
>> comment
>
> It might be better to add to the method description, e.g. "If {@code comment}
> is the empty string or {@code null} then ..." so that the comment parameter
> has single sentence, e.g. "the comment string, or an empty string or null for
> no comment".
Thanks, I think it makes sense to lift this note into the method description
and just leave the abosulute minimum, for-reference note in the parameter
decription. See a891743.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30338#discussion_r2981060656
