On Mon, 23 Mar 2026 19:53:50 GMT, Eirik Bjørsnøs <[email protected]> wrote:
>> Please review this PR which updates the specification of
>> `ZipOutputStream.setComment(String)` to match the long-standing behavior of
>> throwing `IllegalArgumentException` when a comment contains characters which
>> are unmappable using the `Charset` passed in the constructor.
>>
>> A new tests is added to reproduce calling setComment with unmappable
>> characters and verify that it throws IAE.
>>
>> A CSR has been drafted. Its specification section will be updated after an
>> initial round of review of the specification text in this PR.
>
> Eirik Bjørsnøs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Change "the empty string" to "an empty string"
src/java.base/share/classes/java/util/zip/ZipOutputStream.java line 146:
> 144: *
> 145: * @param comment the comment string. Passing {@code null} or an
> empty string
> 146: * will result in the output having no ZIP file
> comment
It might be better to add to the method description, e.g. "If {@code comment}
is the empty string or {@code null} then ..." so that the comment parameter has
single sentence, e.g. "the comment string, or an empty string or null for no
comment".
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30338#discussion_r2980942040
