+1 nice and clean
On Apr 30, 2013, at 2:36 PM, Michael Brooks <mich...@michaelbrooks.ca> wrote:

> +1 cordova.js with version as a header comment
> 
> 
> On Tue, Apr 30, 2013 at 11:31 AM, Filip Maj <f...@adobe.com> wrote:
> 
>> If I recall correctly the original reason was because putting the version
>> in after the lib name in the JS filename was what "other libraries did"
>> aka jQuery.
>> 
>> +1 from me.
>> 
>> On 4/30/13 11:24 AM, "tommy-carlos Williams" <to...@devgeeks.org> wrote:
>> 
>>> +1
>>> 
>>> Wouldn't this make mobile spec easier too?
>>> 
>>> On 01/05/2013, at 4:20, Andrew Grieve <agri...@chromium.org> wrote:
>>> 
>>>> This has been brought up a few times, but I'm not sure there's been a
>>>> decisive answer here yet...
>>>> 
>>>> iOS now uses "cordova.ios.js"
>>>> Android uses "cordova.android.js", but renames it in a build step to
>>>> add in
>>>> the version number.
>>>> CLI normalizes to "cordova.js"
>>>> 
>>>> The version number is now stamped at the top of the file in a code
>>>> comment,
>>>> and I feel that having it in the file name just makes work for us and
>>>> our
>>>> users. I'd like to change all repos to just use "cordova.js".
>>>> 
>>>> Any objections?
>>>> 
>>>> Andrew
>> 
>> 

Reply via email to