+1 Cleaner. Thanks Andrew! -James Jong
On Apr 30, 2013, at 3:31 PM, Lorin Beer <[email protected]> wrote: > +1 > duplicated information is a good redundancy to remove > > > On Tue, Apr 30, 2013 at 11:41 AM, Brian LeRoux <[email protected]> wrote: > >> Sounds good. FTR we did it for issue tracking not arbitrarily. Having >> a stamp at the top of the file fulfills the same end. >> >> On Tue, Apr 30, 2013 at 11:31 AM, Filip Maj <[email protected]> wrote: >>> If I recall correctly the original reason was because putting the version >>> in after the lib name in the JS filename was what "other libraries did" >>> aka jQuery. >>> >>> +1 from me. >>> >>> On 4/30/13 11:24 AM, "tommy-carlos Williams" <[email protected]> wrote: >>> >>>> +1 >>>> >>>> Wouldn't this make mobile spec easier too? >>>> >>>> On 01/05/2013, at 4:20, Andrew Grieve <[email protected]> wrote: >>>> >>>>> This has been brought up a few times, but I'm not sure there's been a >>>>> decisive answer here yet... >>>>> >>>>> iOS now uses "cordova.ios.js" >>>>> Android uses "cordova.android.js", but renames it in a build step to >>>>> add in >>>>> the version number. >>>>> CLI normalizes to "cordova.js" >>>>> >>>>> The version number is now stamped at the top of the file in a code >>>>> comment, >>>>> and I feel that having it in the file name just makes work for us and >>>>> our >>>>> users. I'd like to change all repos to just use "cordova.js". >>>>> >>>>> Any objections? >>>>> >>>>> Andrew >>> >>
