[EMAIL PROTECTED] wrote:
stas 2003/02/25 15:33:55
Modified: server Tag: APACHE_2_0_BRANCH connection.c . Tag: APACHE_2_0_BRANCH CHANGES Log: check the return value of ap_run_pre_connection(). So if the pre_connection phase fails (without setting c->aborted) ap_run_process_connection is not executed. Reviewed by: trawick, jim
I don't recall a vote for merging it into the stable branch.
I figured, since it's a segfault bug fix (httpd was segfaulting when run_process_connection was run, when pre_connection has failed) it's an obvious 'must go into the stable branch' (making it more stable). My patch hasn't introduced a new API or broken anything, other than doing something that should have been done in first place: checking the return value of the call.
So if absolutely anything added to the dev branch must have a vote for before merging back to the stable branch, I stand corrected and will make sure that this won't happen again in the future. I thought that the common sense should be applied when judging what can be backported without the vote.
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
