Should probably note somewhere that mod_logio won't log meaningful results for h2 connections (based on how it tracks at connection level)
On Mon, Jun 22, 2015 at 8:48 AM, Stefan Eissing <stefan.eiss...@greenbytes.de> wrote: > Eric, thanks for the help! When enabling mod_logio it became immediately > clear that mod_h2 wrongly prevented some pre_connection hooks to run. > mod_logio however expects its allocated module config to be there when a > request gets cleaned up... So, with v0.7.2 all pre_conn hooks are run again > and it is part of my test setup now. > > Which adds the issue about proper handling of module configurations in pseudo > connections. There seem to be two approaches: > a) treat pseudo connections like real ones -> run all connection hooks > b) treat them as "shadows" of the real connection -> copy module configs > > While a) is the least dangerous, it misses gives a false impression about the > properties of a connection. For example, mod_h2 currently copies over the > mod_ssl config, so that SSL variables are available during request processing > on pseudo connections. On the other hand, code is not really prepared for b) > since this means that many threads may operate on the same module config. > > So, mod_h2 now follow a) for now (with the exception of mod_ssl). A future > proposal for pseudo connections will need to reevaluate this. > > Cheers, > Stefan > >> Am 22.06.2015 um 14:23 schrieb Eric Covener <cove...@gmail.com>: >> >> On Mon, Jun 22, 2015 at 7:38 AM, Stefan Eissing >> <stefan.eiss...@greenbytes.de> wrote: >>> Thanks, now I see what you mean. What I do not understand: >>> - why is this EOR processed too early? >> >> Usually it is at the end of a brigade and doesn't get cleaned up until >> all of the data is written. But the copy and delete causes the cleanup >> to run while you're iterating over the brigade to copy it in advance >> of writing. >> >>> - what is causing the SegFault in the ap_run_log_transaction() >> >> I don't know. I would have guessed running it early would only impact >> something later. >> >>> - and why am I seeing no errors on my system. Is this a configuration issue >>> with logging? >> >> Looks like you figured this out -- must have mod_logio plus its %B or >> whatever in your LogFormat. > > <green/>bytes GmbH > Hafenweg 16, 48155 Münster, Germany > Phone: +49 251 2807760. Amtsgericht Münster: HRB5782 > > > -- Eric Covener cove...@gmail.com
