PRs have been merged. Many thanks for review to Nikita Amelchev and Aleksei Zinoviev
пт, 25 авг. 2023 г. в 17:05, Nikita Amelchev <namelc...@apache.org>: > +1 for moving to extensions > > This module is good as an extension: > - does not depend on the internal Ignite API, > - the released module will be compatible with any required version of > Ignite using the provided dependency scope. > > Ivan, I have reviewed your patch, LGTM. > > чт, 17 авг. 2023 г. в 17:06, Dmitry Pavlov <dpav...@apache.org>: > > > > +1 for Apache Way in decision making (it states there should not be time > pressure for the decision making). > > > > 0 for removal > > 0 for moving to extensions > > > > but since Aleksei is an expert here, it makes sense to me to wait for > him. > > > > Sincerely, > > Dmitriy Pavlov > > > > On 2023/08/16 17:32:55 Aleksei Zinovev wrote: > > > Hi, I have objection for fast merging, (not for moving) as a module > > > maintainer. > > > > > > I never used ignite extension, need a time to be familiar with it and > test > > > the pr. > > > > > > Please postpone it till 10 september. > > > > > > I don't understand reasons to do it so fast. I suppose it's ok to wait > > > 15-20 days with PR > > > > > > Thanks for collaboration and doing this work. > > > > > > > -- > Best wishes, > Amelchev Nikita > -- Sincerely yours, Ivan Daschinskiy
