[ https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158835#comment-16158835 ]
ASF GitHub Bot commented on LUCENE-7951: ---------------------------------------- Github user dsmiley commented on a diff in the pull request: https://github.com/apache/lucene-solr/pull/246#discussion_r137824698 --- Diff: lucene/spatial3d/src/test/org/apache/lucene/spatial3d/geom/RandomGeo3dShapeGenerator.java --- @@ -149,6 +150,26 @@ public PlanetModel randomPlanetModel() { } /** + * Method that returns a random generated Planet model as string from the supported --- End diff -- I don't think you need this method. I think you are using it only for init(map) when the test using it could instead simply do randomBoolean() to directly set the planet model on the factory. > New wrapper classes for Geo3d > ----------------------------- > > Key: LUCENE-7951 > URL: https://issues.apache.org/jira/browse/LUCENE-7951 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial-extras > Reporter: Ignacio Vera > Assignee: David Smiley > Priority: Minor > Attachments: LUCENE_7951_build.patch, LUCENE_7951_build.patch, > LUCENE-7951.patch, LUCENE-7951.patch > > > Hi, > After the latest developments in the Geo3d library, in particular: > [https://issues.apache.org/jira/browse/LUCENE-7906] : Spatial relationships > between GeoShapes > [https://issues.apache.org/jira/browse/LUCENE-7936]: Serialization of > GeoShapes. > I propose a new set of wrapper classes which can be for example linked to > Solr as they implement their own SpatialContextFactory. It provides the > capability of indexing shapes with > spherical geometry. > Thanks! -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org