[
https://issues.apache.org/jira/browse/LUCENE-7951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16158834#comment-16158834
]
ASF GitHub Bot commented on LUCENE-7951:
----------------------------------------
Github user dsmiley commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/246#discussion_r137825324
--- Diff:
lucene/spatial-extras/src/test/org/apache/lucene/spatial/spatial4j/Geo3dAreaRptTest.java
---
@@ -40,10 +41,10 @@
SpatialContext ctx;
Geo3dSpatialContextFactory factory;
- RandomGeoShapeGenerator shapeGenerator = new RandomGeoShapeGenerator();
+ RandomGeo3dShapeGenerator shapeGenerator = new
RandomGeo3dShapeGenerator();
private void setupGeohashGrid() {
- String planetModel = shapeGenerator.randomPlanetModel();
+ String planetModel = shapeGenerator.randomStringPlanetModel();
factory = new Geo3dSpatialContextFactory();
Map<String, String> args = new HashMap<>();
args.put("planetModel", planetModel);
--- End diff --
I suggest not calling init(); just set the factory.planetModel directly
> New wrapper classes for Geo3d
> -----------------------------
>
> Key: LUCENE-7951
> URL: https://issues.apache.org/jira/browse/LUCENE-7951
> Project: Lucene - Core
> Issue Type: Improvement
> Components: modules/spatial-extras
> Reporter: Ignacio Vera
> Assignee: David Smiley
> Priority: Minor
> Attachments: LUCENE_7951_build.patch, LUCENE_7951_build.patch,
> LUCENE-7951.patch, LUCENE-7951.patch
>
>
> Hi,
> After the latest developments in the Geo3d library, in particular:
> [https://issues.apache.org/jira/browse/LUCENE-7906] : Spatial relationships
> between GeoShapes
> [https://issues.apache.org/jira/browse/LUCENE-7936]: Serialization of
> GeoShapes.
> I propose a new set of wrapper classes which can be for example linked to
> Solr as they implement their own SpatialContextFactory. It provides the
> capability of indexing shapes with
> spherical geometry.
> Thanks!
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
