[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454268#comment-16454268 ]
Roger Whitcomb commented on PIVOT-1032: --------------------------------------- Fixed these UnusedImports errors in the "wtk" classes: Sending wtk/src/org/apache/pivot/wtk/Accordion.java Sending wtk/src/org/apache/pivot/wtk/Bounds.java Sending wtk/src/org/apache/pivot/wtk/Component.java Sending wtk/src/org/apache/pivot/wtk/Container.java Sending wtk/src/org/apache/pivot/wtk/CornerRadii.java Sending wtk/src/org/apache/pivot/wtk/Dialog.java Sending wtk/src/org/apache/pivot/wtk/Dimensions.java Sending wtk/src/org/apache/pivot/wtk/Form.java Sending wtk/src/org/apache/pivot/wtk/Insets.java Sending wtk/src/org/apache/pivot/wtk/Limits.java Sending wtk/src/org/apache/pivot/wtk/LocalManifest.java Sending wtk/src/org/apache/pivot/wtk/Point.java Sending wtk/src/org/apache/pivot/wtk/Sheet.java Sending wtk/src/org/apache/pivot/wtk/Span.java Sending wtk/src/org/apache/pivot/wtk/TextInput.java Sending wtk/src/org/apache/pivot/wtk/TextPane.java Sending wtk/src/org/apache/pivot/wtk/TreeView.java Sending wtk/src/org/apache/pivot/wtk/Viewport.java Sending wtk/src/org/apache/pivot/wtk/Window.java Transmitting file data ...................done Committing transaction... Committed revision 1830229. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --------------------------------------------------------------------------------------- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement > Reporter: Roger Whitcomb > Assignee: Roger Whitcomb > Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian JIRA (v7.6.3#76005)