[
https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454288#comment-16454288
]
Roger Whitcomb commented on PIVOT-1032:
---------------------------------------
Fixed the UnusedImports in all the sub-packages of "wtk":
Sending wtk/src/org/apache/pivot/wtk/content/ListViewItemRenderer.java
Sending wtk/src/org/apache/pivot/wtk/content/SpinnerItemRenderer.java
Sending wtk/src/org/apache/pivot/wtk/content/TableViewCellRenderer.java
Sending
wtk/src/org/apache/pivot/wtk/content/TableViewTextAreaCellRenderer.java
Sending wtk/src/org/apache/pivot/wtk/effects/BaselineDecorator.java
Sending wtk/src/org/apache/pivot/wtk/effects/BlurDecorator.java
Sending wtk/src/org/apache/pivot/wtk/effects/ClipDecorator.java
Sending wtk/src/org/apache/pivot/wtk/effects/DropShadowDecorator.java
Sending wtk/src/org/apache/pivot/wtk/effects/FadeDecorator.java
Sending wtk/src/org/apache/pivot/wtk/effects/GrayscaleDecorator.java
Sending wtk/src/org/apache/pivot/wtk/effects/OverlayDecorator.java
Sending wtk/src/org/apache/pivot/wtk/effects/SaturationDecorator.java
Sending wtk/src/org/apache/pivot/wtk/effects/ScaleDecorator.java
Sending wtk/src/org/apache/pivot/wtk/effects/ShadeDecorator.java
Sending wtk/src/org/apache/pivot/wtk/effects/TagDecorator.java
Sending wtk/src/org/apache/pivot/wtk/effects/WatermarkDecorator.java
Sending wtk/src/org/apache/pivot/wtk/media/Drawing.java
Sending wtk/src/org/apache/pivot/wtk/media/Image.java
Sending wtk/src/org/apache/pivot/wtk/skin/BorderSkin.java
Sending wtk/src/org/apache/pivot/wtk/skin/CalendarButtonSkin.java
Sending wtk/src/org/apache/pivot/wtk/skin/CheckboxSkin.java
Sending wtk/src/org/apache/pivot/wtk/skin/ColorChooserButtonSkin.java
Sending wtk/src/org/apache/pivot/wtk/skin/ComponentSkin.java
Sending wtk/src/org/apache/pivot/wtk/skin/ListButtonSkin.java
Sending wtk/src/org/apache/pivot/wtk/skin/MenuBarItemSkin.java
Sending wtk/src/org/apache/pivot/wtk/skin/MenuButtonSkin.java
Sending wtk/src/org/apache/pivot/wtk/skin/PushButtonSkin.java
Sending wtk/src/org/apache/pivot/wtk/skin/RadioButtonSkin.java
Sending wtk/src/org/apache/pivot/wtk/skin/RulerSkin.java
Sending wtk/src/org/apache/pivot/wtk/skin/ScrollPaneSkin.java
Sending wtk/src/org/apache/pivot/wtk/skin/SeparatorSkin.java
Sending wtk/src/org/apache/pivot/wtk/skin/TablePaneSkin.java
Sending wtk/src/org/apache/pivot/wtk/skin/TextPaneSkin.java
Sending wtk/src/org/apache/pivot/wtk/skin/TextPaneSkinNodeView.java
Sending wtk/src/org/apache/pivot/wtk/skin/TextPaneSkinTextNodeView.java
Sending wtk/src/org/apache/pivot/wtk/text/Element.java
Sending wtk/src/org/apache/pivot/wtk/validation/RegexTextValidator.java
Transmitting file data .....................................done
Committing transaction...
Committed revision 1830230.
> Implement "checkstyle" for builds and make changes to bring code into better
> compliance
> ---------------------------------------------------------------------------------------
>
> Key: PIVOT-1032
> URL: https://issues.apache.org/jira/browse/PIVOT-1032
> Project: Pivot
> Issue Type: Improvement
> Reporter: Roger Whitcomb
> Assignee: Roger Whitcomb
> Priority: Minor
> Attachments: 1032.diffs.txt
>
>
> I thought it would be interesting, in addition to the "trim-whitespace" task
> already implemented, to do some sort of "checkstyle" processing to evaluate
> all the code to see where there might be changes to make the code more robust
> and a better example of "canonical" Java style.
> I hesitate to expect that we could address everything (or indeed whether we
> *should*), but there might be things that would make the code better and
> easier to read and maintain, and wouldn't take much effort.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
