[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16455571#comment-16455571 ]
Roger Whitcomb commented on PIVOT-1032: --------------------------------------- More check style errors fixed: Sending core/src/org/apache/pivot/collections/adapter/ListAdapter.java Sending core/src/org/apache/pivot/functional/monad/Failure.java Sending core/src/org/apache/pivot/functional/monad/Monad.java Sending core/src/org/apache/pivot/functional/monad/Option.java Sending core/src/org/apache/pivot/functional/monad/Some.java Sending core/src/org/apache/pivot/functional/monad/Success.java Sending core/src/org/apache/pivot/functional/monad/Try.java Sending core/src/org/apache/pivot/functional/monad/TryCompanion.java Sending core/test/org/apache/pivot/functional/monad/test/OptionTest.java Sending core/test/org/apache/pivot/functional/monad/test/TryTest.java Sending core/test/org/apache/pivot/util/test/BooleanResultTest.java Sending demos/src/org/apache/pivot/demos/million/LargeData.java Sending tests/src/org/apache/pivot/tests/CardPaneTest.java Sending tests/src/org/apache/pivot/tests/JavascriptConsoleTest.java Sending tests/src/org/apache/pivot/tests/issues/Pivot686.java Sending tests/src/org/apache/pivot/tests/issues/pivot964/Pivot964Pivot.java Sending tests/src/org/apache/pivot/tests/issues/pivot964/Pivot964Swing.java Sending tutorials/src/org/apache/pivot/tutorials/bxmlexplorer/BXMLExplorerDocument.java Sending tutorials/src/org/apache/pivot/tutorials/text/TextInputs.java Sending wtk/src/org/apache/pivot/wtk/ApplicationContext.java Sending wtk/src/org/apache/pivot/wtk/Checkbox.java Sending wtk/src/org/apache/pivot/wtk/CornerRadii.java Sending wtk/src/org/apache/pivot/wtk/DesktopApplicationContext.java Sending wtk/src/org/apache/pivot/wtk/Gauge.java Sending wtk/src/org/apache/pivot/wtk/GraphicsUtilities.java Sending wtk/src/org/apache/pivot/wtk/Insets.java Sending wtk/src/org/apache/pivot/wtk/ListView.java Sending wtk/src/org/apache/pivot/wtk/Meter.java Sending wtk/src/org/apache/pivot/wtk/RadioButtonGroup.java Sending wtk/src/org/apache/pivot/wtk/Span.java Sending wtk/src/org/apache/pivot/wtk/TableView.java Sending wtk/src/org/apache/pivot/wtk/skin/BorderSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/ComponentSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/LabelSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/NumberRulerSkin.java Sending wtk/src/org/apache/pivot/wtk/validation/RegexTextValidator.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraAlertSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraCheckboxSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraFileBrowserSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListViewSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraPaletteSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraPromptSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTableViewSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTreeViewSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraVFSBrowserSkin.java Transmitting file data .............................................done Committing transaction... Committed revision 1830285. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --------------------------------------------------------------------------------------- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement > Reporter: Roger Whitcomb > Assignee: Roger Whitcomb > Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian JIRA (v7.6.3#76005)