chrisdutz commented on code in PR #818:
URL: https://github.com/apache/plc4x/pull/818#discussion_r1115292722
##########
plc4j/tools/connection-cache/src/main/java/org/apache/plc4x/java/utils/cache/LeasedPlcConnection.java:
##########
@@ -66,7 +76,7 @@ public void connect() throws PlcConnectionException {
@Override
public boolean isConnected() {
if(connection == null) {
- throw new PlcRuntimeException("Error using leased connection after
returning it to the cache.");
+ return false;
Review Comment:
I still don't quite understand the problem with this ... if you returned the
connection to the pool, you should not do anything with it ... that's sort of
the contract on using the pool. If there's some logic calling "isConnected()"
after it has been returned, that's just a flaw in the program using it. I still
think we should continue to throw an exception here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
