chrisdutz commented on code in PR #818:
URL: https://github.com/apache/plc4x/pull/818#discussion_r1115297104
##########
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/messages/DefaultPlcWriteRequest.java:
##########
@@ -194,6 +196,9 @@ public PlcWriteRequest build() {
PlcTag tag = tagValues.getLeft().get();
Object[] value = tagValues.getRight();
PlcValue plcValue = valueHandler.newPlcValue(tag, value);
+ if (tag.getPlcValueType() == PlcValueType.NULL && value!=null)
{
+ tag.setPlcValueType(plcValue.getPlcValueType());
+ }
Review Comment:
I still don't think we should have this in here ... if the tag says it's one
type, but the PlcValue says it's something else, we shouldn't update this (I
guess this is the reason you needed to add the "setPlcValue"). We should fire
an exception, because in this case the user is doing something incorrectly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
