chrisdutz commented on code in PR #818:
URL: https://github.com/apache/plc4x/pull/818#discussion_r1115294277
##########
plc4j/api/src/main/java/org/apache/plc4x/java/api/model/PlcTag.java:
##########
@@ -63,6 +63,10 @@ default PlcValueType getPlcValueType() {
return PlcValueType.NULL;
}
+ @JsonIgnore
+ default void setPlcValueType(PlcValueType plcValueType){
+ }
Review Comment:
Hmm ... this adds a default implementation, which doesn't really do
anything. Also do we usually implement all of the types in the API module, to
create immutable types. Is there any reason for this addition?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
