chrisdutz commented on code in PR #818:
URL: https://github.com/apache/plc4x/pull/818#discussion_r1115310805
##########
plc4j/tools/connection-cache/src/main/java/org/apache/plc4x/java/utils/cache/LeasedPlcConnection.java:
##########
@@ -51,13 +51,23 @@ public void run() {
@Override
public synchronized void close() {
- // Make the connection unusable.
- connection = null;
-
+ if(connectionContainer == null) {
+ return;
+ }
Review Comment:
Why should the connectionContainer ever be null? The way I understand it,
the only way this could happen, would be that a program got a lease ...
executed a request, that had an issue and therefore it automatically closed the
connection and destroy() called close from the inside and then the using
application calls close regularly ... not too happy with this workflow in
general ... we should really discuss things on the list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
