spnettec commented on code in PR #818:
URL: https://github.com/apache/plc4x/pull/818#discussion_r1115427998
##########
plc4j/spi/src/main/java/org/apache/plc4x/java/spi/messages/DefaultPlcWriteRequest.java:
##########
@@ -194,6 +196,9 @@ public PlcWriteRequest build() {
PlcTag tag = tagValues.getLeft().get();
Object[] value = tagValues.getRight();
PlcValue plcValue = valueHandler.newPlcValue(tag, value);
+ if (tag.getPlcValueType() == PlcValueType.NULL && value!=null)
{
+ tag.setPlcValueType(plcValue.getPlcValueType());
+ }
Review Comment:
It can remove tag formate that depends on other driver's label formats.
I can remove this change. Next PR. I want to fix plc4x driver and server
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
