chrisdutz commented on code in PR #818:
URL: https://github.com/apache/plc4x/pull/818#discussion_r1115301187
##########
plc4j/tools/connection-cache/src/main/java/org/apache/plc4x/java/utils/cache/ConnectionContainer.java:
##########
@@ -28,12 +28,20 @@
import java.util.concurrent.Future;
class ConnectionContainer {
- private final PlcConnection connection;
+ private PlcConnection connection;
+ private boolean closed = false;
private final Duration maxLeaseTime;
private final Queue<CompletableFuture<PlcConnection>> queue;
private LeasedPlcConnection leasedConnection;
+ public boolean isClosed() {
+ return closed;
+ }
+ public PlcConnection getRawConnection() {
Review Comment:
In contrast to your comment, this does actually return the Plc4x connection
and not the Netty connection ... we shouldn't expose this, as this allows
"stealing" the connection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
