chrisdutz commented on code in PR #818:
URL: https://github.com/apache/plc4x/pull/818#discussion_r1115313507
##########
plc4j/api/src/main/java/org/apache/plc4x/java/api/model/PlcTag.java:
##########
@@ -63,6 +63,10 @@ default PlcValueType getPlcValueType() {
return PlcValueType.NULL;
}
+ @JsonIgnore
+ default void setPlcValueType(PlcValueType plcValueType){
+ }
Review Comment:
This seems to be related to the change in DefaultPlcWrite request, were the
plc value type can be updated ... as I don't really like that change, I think
we should also remove this change ... as both actually don't have anything to
do with what we would like to address with this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@plc4x.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
