BTW, how can I sort changes for the metadata store? Best, tison.
tison <wander4...@gmail.com> 于2022年8月19日周五 17:44写道： > To proposal a workable solution, I suggest: > > replace > > * pkg > * tool > * deploy > * ci > * workflow > * build > > with > > * ci - CI workflow changes or debugging. > * build - all things related to the build system, including tools, > deployment logic, maven changes, packaging logics, docker image, build > scripts. > > Best, > tison. > > > tison <wander4...@gmail.com> 于2022年8月19日周五 17:41写道： > >> > I intended to mean changes to "process / standard / guide" [2] rather >> than "CI workflow", but it still causes confusion. >> >> How can a PR be relevant to these things? I think the result should be >> either CI workflow changes or document updates. We don't need a dedicated >> "workflow" in such situations. >> >> > build system or external dependencies. >> >> So, it overlaps with deps. While I can regard it as Maven/Docker/Build >> script related changes, we may not have "pkg", "tool", "deploy" that can >> overlap with this. >> >> Best, >> tison. >> >> >> tison <wander4...@gmail.com> 于2022年8月19日周五 17:38写道： >> >>> As for the type candidates: >>> >>> LGTM. No comment here. >>> >>> As for the scope candidates: >>> >>> +1 for dep -> deps >>> +1 for fcn -> fn >>> Among most communities and language conventions, the abbr of function >>> is fn (Rust), fun (Erlang), or func (Golang). No fcn IIRC. I'd prefer the >>> short one, fn. >>> +1 for ts -> offloader >>> If I get it right, tiered storage is offloader. We can save one word >>> while keeping semantic. >>> >>> I don't know clearly what is: >>> * pkg >>> * tool >>> * deploy >>> * ci >>> * workflow >>> * build >>> They look quite similar or overlapping. >>> >>> Rest LGTM. >>> >>> As for the remaining issues: >>> >>> - Submit breaking changes >>> [feat][broker]! Support xx >>> >>> This is fine. Since we don't verify what follows the [type][scope] >>> section, it doesn't block the proposal. >>> >>> - Submit PIP changes >>> [feat][broker] PIP-198: Support xx >>> >>> The same as before. Contributors can name whatever they like. We don't >>> set too complex rules. >>> >>> - Cherry pick changes [4] >>> Choice A: [fix][broker][branch-2.9] xxx >>> Choice B: [fix][broker] xxx. And add "cherry pick xxx to branch-2.9" in >>> the >>> PR description. >>> >>> I'd prefer [fix][broker][BP-2.9] to save some letters. This is how the >>> Flink community does. BP means backport. But yes, it's not a requirement >>> but a suggestion. >>> >>> >>> Best, >>> tison. >>> >>
