Hello, All.
This is patch for ticket #272.
I guided by next considerations:
-- in most cases links to a dirs or files must be passed to program "as is";
-- also, if dir icon selected in efm2 then we need pass this name to a
program too.
So, I removed some superfluous checks from fuction _e_fwin_desktop_run.
I tested this code on combinations of links/files for open with:
-- Konquerror;
-- KView;
-- Gimp.
And specified in ticket #272 errors are gone.
I don't observe any side effects.
e_fwin.c | 13 +------------
1 file changed, 1 insertion(+), 12 deletions(-)
Index: e/src/modules/fileman/e_fwin.c
===================================================================
--- e/src/modules/fileman/e_fwin.c (revision 39905)
+++ e/src/modules/fileman/e_fwin.c (working copy)
@@ -1108,18 +1108,7 @@
if (ext == E_FWIN_EXEC_NONE)
{
if (!((ici->link) && (ici->mount)))
- {
- if (ici->link)
- {
- if (!S_ISDIR(ici->statinfo.st_mode))
- snprintf(buf, sizeof(buf), "%s", ici->file);
- }
- else
- {
- if (!S_ISDIR(ici->statinfo.st_mode))
- snprintf(buf, sizeof(buf), "%s", ici->file);
- }
- }
+ snprintf(buf, sizeof(buf), "%s", ici->file);
}
else
_e_fwin_file_exec(fwin, ici, ext);
Sincerely yours, Sergey.
--
Jabber/XMPP: sergey.semer...@gmail.com
Cellular: +7-909-206-5992
Index: e/src/modules/fileman/e_fwin.c
===================================================================
--- e/src/modules/fileman/e_fwin.c (revision 39905)
+++ e/src/modules/fileman/e_fwin.c (working copy)
@@ -1108,18 +1108,7 @@
if (ext == E_FWIN_EXEC_NONE)
{
if (!((ici->link) && (ici->mount)))
- {
- if (ici->link)
- {
- if (!S_ISDIR(ici->statinfo.st_mode))
- snprintf(buf, sizeof(buf), "%s", ici->file);
- }
- else
- {
- if (!S_ISDIR(ici->statinfo.st_mode))
- snprintf(buf, sizeof(buf), "%s", ici->file);
- }
- }
+ snprintf(buf, sizeof(buf), "%s", ici->file);
}
else
_e_fwin_file_exec(fwin, ici, ext);
------------------------------------------------------------------------------
This SF.net email is sponsored by:
High Quality Requirements in a Collaborative Environment.
Download a free trial of Rational Requirements Composer Now!
http://p.sf.net/sfu/www-ibm-com
_______________________________________________
enlightenment-devel mailing list
enlightenment-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/enlightenment-devel
