On 4 Jun 2009, at 21:08, sebb wrote:
On 04/06/2009, Paul Lindner <lind...@inuus.com> wrote:
I don't see these as release blockers... I'd like to see us get
the 1.0
release out the door and then immediately work to apply the release
process
to 1.1 snapshots. This was a frequent request from multiple people
at
Google I/O.
On Thu, Jun 4, 2009 at 10:17 AM, Ian Boston <i...@tfd.co.uk> wrote:
-- snip --
These are probably not supposed to be in the source archive, they
must have
slipped trough during the build process, which does have filters
in place to
exclude them, but thats obviously not working. I will file a bug.
The maven-clean-plugin config lists the file names without any path
info, so will only delete files in the working directory.
They are generated by JPA when it build the tests giving the default
database schema for the samples project.
It would be better if the test files were generated in a directory
which is exclusively used for temporary test items, e.g. a work
directory under target/. There would then be no need to remove the
files later.
Good point, I will fix.
-- snip --
IYO, are any of these release blockers ?
The source archive is supposed to be derivable from SVN, which is why
I asked where the extra files came from. I suppose this is true here.
It's not ideal to leave test output in the source archive; but it is
probably not a release blocker.
However, if I were the RM, I would create another release candidate.
Your call.
In light of Paul's comment and the amount of time we (I) have taken
over getting this release out, I would like to leave the release as
is, and fix all the problems identified so far in this release, in the
1.1 release asap.
Thanks
Ian
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org
