timsaucer commented on code in PR #18813:
URL: https://github.com/apache/datafusion/pull/18813#discussion_r2541783957
##########
datafusion/proto/src/physical_plan/to_proto.rs:
##########
@@ -50,20 +50,20 @@ use crate::protobuf::{
PhysicalSortExprNodeCollection,
};
-use super::PhysicalExtensionCodec;
+use super::PhysicalSerializer;
#[expect(clippy::needless_pass_by_value)]
-pub fn serialize_physical_aggr_expr(
+pub fn serialize_physical_aggr_expr<S: PhysicalSerializer>(
aggr_expr: Arc<AggregateFunctionExpr>,
- codec: &dyn PhysicalExtensionCodec,
+ parser: &mut S,
Review Comment:
Easily done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
