timsaucer commented on code in PR #18813:
URL: https://github.com/apache/datafusion/pull/18813#discussion_r2541787184
##########
datafusion/ffi/src/udaf/accumulator_args.rs:
##########
@@ -63,11 +63,11 @@ impl TryFrom<AccumulatorArgs<'_>> for FFI_AccumulatorArgs {
WrappedSchema(FFI_ArrowSchema::try_from(args.return_field.as_ref())?);
let schema = WrappedSchema(FFI_ArrowSchema::try_from(args.schema)?);
- let codec = DefaultPhysicalExtensionCodec {};
+ let mut codec = DefaultPhysicalExtensionCodec {};
Review Comment:
Yes, that is my ultimate goal. I don't want to merge any PR until I've got
at least a hacked together demo of it with FFI and used in df-python.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
