timsaucer commented on code in PR #18813:
URL: https://github.com/apache/datafusion/pull/18813#discussion_r2541837705
##########
datafusion/proto/src/physical_plan/mod.rs:
##########
@@ -3303,6 +3067,169 @@ pub trait PhysicalExtensionCodec: Debug + Send + Sync {
}
}
+pub trait PhysicalDeserializer {
+ fn try_decode_execution_plan(
+ &mut self,
+ buf: &[u8],
+ inputs: &[Arc<dyn ExecutionPlan>],
+ ) -> Result<Arc<dyn ExecutionPlan>>;
Review Comment:
If we were to combine the two traits I could imagine calling it
`PhysicalCodec` or `PhysicalSerde`. The problem with `PhysicalCodec` is the
name is so close to `PhysicalExtensionCodec` *and* the methods are so similar I
suspect it will cause more confusion than good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
