adriangb commented on code in PR #18813:
URL: https://github.com/apache/datafusion/pull/18813#discussion_r2541943137
##########
datafusion/proto/src/physical_plan/from_proto.rs:
##########
@@ -73,14 +72,13 @@ impl From<&protobuf::PhysicalColumn> for Column {
/// * `input_schema` - The Arrow schema for the input, used for determining
expression data types
/// when performing type coercion.
/// * `codec` - An extension codec used to decode custom UDFs.
-pub fn parse_physical_sort_expr(
+pub fn parse_physical_sort_expr<D: PhysicalDeserializer>(
proto: &protobuf::PhysicalSortExprNode,
- ctx: &TaskContext,
+ parser: &mut D,
Review Comment:
Agreed I think `deserializer` is a better parameter name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
