timsaucer commented on code in PR #18813:
URL: https://github.com/apache/datafusion/pull/18813#discussion_r2541802937
##########
datafusion/proto/src/physical_plan/mod.rs:
##########
@@ -3303,6 +3067,169 @@ pub trait PhysicalExtensionCodec: Debug + Send + Sync {
}
}
+pub trait PhysicalDeserializer {
+ fn try_decode_execution_plan(
+ &mut self,
+ buf: &[u8],
+ inputs: &[Arc<dyn ExecutionPlan>],
+ ) -> Result<Arc<dyn ExecutionPlan>>;
Review Comment:
I don't know if there is a good use case for having two separate traits -
`PhysicalDeserializer` and `PhysicalSerializer`. Almost all of the methods so
closely mirror the `PhysicalExtensionCodec`. Maybe we make one trait with a
better name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
