milenkovicm commented on code in PR #18813:
URL: https://github.com/apache/datafusion/pull/18813#discussion_r2542485897
##########
datafusion/proto/src/physical_plan/from_proto.rs:
##########
@@ -100,15 +98,14 @@ pub fn parse_physical_sort_expr(
/// * `input_schema` - The Arrow schema for the input, used for determining
expression data types
/// when performing type coercion.
/// * `codec` - An extension codec used to decode custom UDFs.
-pub fn parse_physical_sort_exprs(
+pub fn parse_physical_sort_exprs<D: PhysicalDeserializer>(
proto: &[protobuf::PhysicalSortExprNode],
- ctx: &TaskContext,
+ parser: &mut D,
input_schema: &Schema,
- codec: &dyn PhysicalExtensionCodec,
) -> Result<Vec<PhysicalSortExpr>> {
proto
.iter()
- .map(|sort_expr| parse_physical_sort_expr(sort_expr, ctx,
input_schema, codec))
+ .map(|sort_expr| parse_physical_sort_expr(sort_expr, parser,
input_schema))
.collect()
}
Review Comment:
Makes sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
