adriangb commented on code in PR #18813:
URL: https://github.com/apache/datafusion/pull/18813#discussion_r2541947334
##########
datafusion/proto/src/physical_plan/from_proto.rs:
##########
@@ -385,54 +367,49 @@ pub fn parse_physical_expr(
like_expr.case_insensitive,
parse_required_physical_expr(
like_expr.expr.as_deref(),
- ctx,
+ parser,
"expr",
input_schema,
- codec,
)?,
parse_required_physical_expr(
like_expr.pattern.as_deref(),
- ctx,
+ parser,
"pattern",
input_schema,
- codec,
)?,
)),
ExprType::Extension(extension) => {
let inputs: Vec<Arc<dyn PhysicalExpr>> = extension
.inputs
.iter()
- .map(|e| parse_physical_expr(e, ctx, input_schema, codec))
+ .map(|e| parse_physical_expr(e, parser, input_schema))
.collect::<Result<_>>()?;
- (codec.try_decode_expr(extension.expr.as_slice(), &inputs)?) as _
+ parser.try_decode_expr(extension.expr.as_slice(), &inputs)? as _
Review Comment:
It seems that this is missing some key points of
https://github.com/apache/datafusion/issues/18477:
- It only operates on `Extension` variants
- It doesn't allow pre/post/fork control of serde
From #18477:
> design goals were:
> - More flexible pre/post processing. The current Codec system only
operates as a "fallback" and doesn't support hooking into the moment before
trying to deserialize or the moment after a successful deserialization. I have
a lot of example use cases for this that I can share.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
