stevenzwu commented on code in PR #14101:
URL: https://github.com/apache/iceberg/pull/14101#discussion_r2830882385
##########
api/src/main/java/org/apache/iceberg/expressions/Expressions.java:
##########
@@ -202,6 +204,24 @@ public static UnboundPredicate<String>
notStartsWith(UnboundTerm<String> expr, S
return new UnboundPredicate<>(Expression.Operation.NOT_STARTS_WITH, expr,
value);
}
+ public static UnboundPredicate<ByteBuffer> stIntersects(String name,
BoundingBox value) {
Review Comment:
`GeospatialBound` also have additionally optional dimensions `z` and `m`.
Hence, I thought `BoundingBox(GeospatialBound min, GeospatialBound max)` is
probably good here.
If we want to provide some convenient constructor, should we do it in
`BoundingBox`?
```
public static BoundingBox from(xmin, xmax, ymin, ymax)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
