Kontinuation commented on code in PR #14101:
URL: https://github.com/apache/iceberg/pull/14101#discussion_r2831376534
##########
api/src/main/java/org/apache/iceberg/expressions/ExpressionVisitors.java:
##########
@@ -166,6 +178,12 @@ public <T> R predicate(BoundPredicate<T> pred) {
return startsWith((BoundReference<T>) pred.term(),
literalPred.literal());
case NOT_STARTS_WITH:
return notStartsWith((BoundReference<T>) pred.term(),
literalPred.literal());
+ case ST_INTERSECTS:
+ return stIntersects(
+ (BoundReference<T>) pred.term(), (Literal<ByteBuffer>)
literalPred.literal());
Review Comment:
I think we still need to do an unchecked cast to cast `literalPred.literal`
from `Literal<T>` to `Literal<BoundingBox>`, even if we define
`BoundingBoxLiteral implements Literal<BoundingBox>`. Is this cast acceptable
and look less problematic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
