Kontinuation commented on code in PR #14101:
URL: https://github.com/apache/iceberg/pull/14101#discussion_r2831361210
##########
api/src/main/java/org/apache/iceberg/expressions/Literals.java:
##########
@@ -719,4 +723,71 @@ public String toString() {
return "X'" + BaseEncoding.base16().encode(bytes) + "'";
}
}
+
+ static class BoundingBoxLiteral implements Literal<ByteBuffer> {
Review Comment:
Implementing `Literal<ByteBuffer>` was for not breaking the type constraint
of `List<Literal<T>> literals` in `UnboundPredicate<ByteBuffer>` and
`Literal<T> literal` of `BoundLiteralPredicate<ByteBuffer>`. Do you suggest
that we break the constraint for spatial predicates involving bounding box
literals, or do a major refactoring by implementing new variants of predicates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
