[ 
https://issues.apache.org/jira/browse/SOLR-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17636317#comment-17636317
 ] 

Ishan Chattopadhyaya edited comment on SOLR-16531 at 11/20/22 4:58 PM:
-----------------------------------------------------------------------

I re-ran the tests to report more granular time (startup and shutdown times) 
than just "restart time". The graph is here: 
http://mostly.cool/cluster-test.json.html (as before). This has the patch for 
the parallel stream bugfix backported to earlier commits.

The average startup time (that consists of node starting up and waiting until 
all replicas on it have become active) has degraded from 38 seconds to 51 
seconds. *So, node startup is about 33% slower.* The total time in restarting 7 
nodes (2 at a time), similar to as reported earlier, degraded from 313 seconds 
to 372 seconds. *So, the series of node restarts is about 19% slower*.

bq.  A minor perf regression
In my opinion, this is not minor regression, but a significant one.


was (Author: ichattopadhyaya):
I re-ran the tests to report more granular time (startup and shutdown times) 
than just "restart time". The graph is here: 
http://mostly.cool/cluster-test.json.html (as before). This has the patch for 
the parallel stream bugfix backported to earlier commits.

The average startup time (that consists of node starting up and waiting until 
all replicas on it have become active) has degraded from 38 seconds to 51 
seconds. *This is about 33% slowdown.* The total time in restarting 7 nodes (2 
at a time), similar to as reported earlier, degraded from 313 seconds to 372 
seconds. This is about 19% slowdown.

bq.  A minor perf regression
In my opinion, this is not minor regression, but a significant one.

> Performance degradation due to introduction of JAX-RS
> -----------------------------------------------------
>
>                 Key: SOLR-16531
>                 URL: https://issues.apache.org/jira/browse/SOLR-16531
>             Project: Solr
>          Issue Type: Bug
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Ishan Chattopadhyaya
>            Priority: Blocker
>             Fix For: 9.2
>
>         Attachments: Screenshot from 2022-11-09 11-20-44.png, 
> results-with-patch.tar.gz
>
>
> During performance benchmarking on branch_9x, I observed a slowdown in 
> restart performance since commits in SOLR-16347. See attached screenshot.
> CC [~gerlowskija].
> http://mostly.cool/cluster-test-with-patch.html
> The benchmark is here: 
> https://github.com/fullstorydev/solr-bench/blob/ishan/repeatable-jenkins/suites/cluster-test.json.
>  This suite was run after retro-actively applying the parallelStream patch 
> from SOLR-16414: 
> https://github.com/apache/solr/commit/b33161d0cdd976fc0c3dc78c4afafceb4db671cf.diff
>  
> Effort to automate these benchmarks is WIP and tracked here: SOLR-16525.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to