The PR does not include any explanation as to why the changes to pyproject.toml are necessary, nor does it provide any guidance on how to test them. I used the standard configure process (now also with the system-site-packages switch) followed by make, both with and without these changes, and observed no visible differences. Could you please clarify how to observe the impact of the 'numpy >=1.22.4' constraint? Additionally, the comment preceding it is quite confusing, especially since this file <https://github.com/scipy/scipy/blob/maintenance/1.13.x/pyproject.toml> actually lists "numpy>=2.0.0rc1,<2.3".
If the only apparent effect of these constraints is related to the system-site-package feature, I would appreciate feedback from the developers working on this feature (Dima?, Michael?) regarding how to specify these constraints now that sage-lib defines its own constraints in pyproject.toml. To avoid further delaying the package upgrades in this PR, I am okay with reverting the changes to pyproject.toml for now and revisiting them once the discussion is concluded. On Friday, September 6, 2024 at 7:58:58 PM UTC+2 Matthias Koeppe wrote: > On Friday, September 6, 2024 at 1:43:32 AM UTC-7 tobia...@gmx.de wrote: > > > I've set the PR back to needs work since the version constraints in > pyproject.toml for cython and numpy are not needed in my testing, > definitely not for sage-the-lib but apparently not even for sage-the-distro > (at least I didn't get any build errors without them). > > > The only place where these version constraints are used in > sage-the-distribution is in the experimental "configure > --enable-system-site-packages" mode. > You don't say what you tested, and in any case such vague indications are > not sufficient basis for holding up an upgrade PR. > > > -- You received this message because you are subscribed to the Google Groups "sage-devel" group. To unsubscribe from this group and stop receiving emails from it, send an email to sage-devel+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sage-devel/420e5387-9862-4bbd-af46-3b09bee10a6cn%40googlegroups.com.
