Alex Ghitza wrote:
On Thu, 11 Mar 2010 18:42:00 +1100, Minh Nguyen <nguyenmi...@gmail.com> wrote:
Third, in many cases, one can open a new ticket to improve the changes
introduced by a patch from an existing ticket. In such cases, I think
one can suggest this option to the patch author and leave it to them
to either incorporate the changes in the current patch, or to open a
new ticket to implement the change.
To add a small epsilon to Minh's comments: it is fairly common for a
reviewer to add a small reviewer patch fixing docstrings or adding some
examples, etc. This could be a good alternative to getting frustrated
with the author for not making these changes himself. I have often
added such a patch, often as a sign of appreciation for the time and
effort the author made already; this is especially important when the
person has indicated that he doesn't have time to pursue the ticket any
further.
Best,
Alex
I believe however that authors should not expect this. I recently had someone
give me a positive review subject to some trivial grammar and spelling errors. I
have no problem with that. Why should the reviewer correct my grammar or spelling?
One obvious exception would be if the grammar of someone is poor, as English is
not their first language. Then it is much more helpful for the reviewer to make
a reviewer patch.
I think we need to avoid the situation where someone presents sub-standard work,
then expects the reviewer to correct it.
--
To post to this group, send an email to sage-devel@googlegroups.com
To unsubscribe from this group, send an email to
sage-devel+unsubscr...@googlegroups.com
For more options, visit this group at http://groups.google.com/group/sage-devel
URL: http://www.sagemath.org
