[webkit-changes] [123998] trunk/Source
Title: [123998] trunk/Source Revision 123998 Author commit-qu...@webkit.org Date 2012-07-29 23:09:55 -0700 (Sun, 29 Jul 2012) Log Message [WK2][EFL] TILED_BACKING_STORE support on Efl WebKit2 https://bugs.webkit.org/show_bug.cgi?id=91582 Patch by YoungTaeck Song youngtaeck.s...@samsung.com on 2012-07-29 Reviewed by Noam Rosenthal. Source/WebCore: This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation. This patch adds TILED_BACKING_STORE related files to CMakeLists.txt and PlatformEfl.cmake * CMakeLists.txt: * PlatformEfl.cmake: Source/WebKit/efl: Add a dummy function for fixing building error when enabling TILED_BACKING_STORE. * WebCoreSupport/ChromeClientEfl.cpp: (WebCore): (WebCore::ChromeClientEfl::delegatedScrollRequested): * WebCoreSupport/ChromeClientEfl.h: (ChromeClientEfl): Source/WebKit2: This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation. Add a dummy function for fixing building error when enabling TILED_BACKING_STORE. * UIProcess/API/efl/PageClientImpl.cpp: (WebKit): (WebKit::PageClientImpl::pageDidRequestScroll): * UIProcess/API/efl/PageClientImpl.h: (PageClientImpl): * WebProcess/WebCoreSupport/WebChromeClient.cpp: (WebKit::WebChromeClient::contentsSizeChanged): Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PlatformEfl.cmake trunk/Source/WebKit/efl/ChangeLog trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp trunk/Source/WebKit/efl/WebCoreSupport/ChromeClientEfl.h trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/efl/PageClientImpl.cpp trunk/Source/WebKit2/UIProcess/API/efl/PageClientImpl.h trunk/Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp Diff Modified: trunk/Source/WebCore/CMakeLists.txt (123997 => 123998) --- trunk/Source/WebCore/CMakeLists.txt 2012-07-30 05:49:29 UTC (rev 123997) +++ trunk/Source/WebCore/CMakeLists.txt 2012-07-30 06:09:55 UTC (rev 123998) @@ -1812,6 +1812,7 @@ platform/graphics/SurrogatePairAwareTextIterator.cpp platform/graphics/SVGGlyph.cpp platform/graphics/TextRun.cpp +platform/graphics/TiledBackingStore.cpp platform/graphics/WidthIterator.cpp platform/graphics/filters/CustomFilterGlobalContext.cpp Modified: trunk/Source/WebCore/ChangeLog (123997 => 123998) --- trunk/Source/WebCore/ChangeLog 2012-07-30 05:49:29 UTC (rev 123997) +++ trunk/Source/WebCore/ChangeLog 2012-07-30 06:09:55 UTC (rev 123998) @@ -1,3 +1,16 @@ +2012-07-29 YoungTaeck Song youngtaeck.s...@samsung.com + +[WK2][EFL] TILED_BACKING_STORE support on Efl WebKit2 +https://bugs.webkit.org/show_bug.cgi?id=91582 + +Reviewed by Noam Rosenthal. + +This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation. +This patch adds TILED_BACKING_STORE related files to CMakeLists.txt and PlatformEfl.cmake + +* CMakeLists.txt: +* PlatformEfl.cmake: + 2012-07-29 Keishi Hattori kei...@webkit.org Fix removing invalid values from color input suggestions Modified: trunk/Source/WebCore/PlatformEfl.cmake (123997 => 123998) --- trunk/Source/WebCore/PlatformEfl.cmake 2012-07-30 05:49:29 UTC (rev 123997) +++ trunk/Source/WebCore/PlatformEfl.cmake 2012-07-30 06:09:55 UTC (rev 123998) @@ -135,6 +135,7 @@ platform/graphics/cairo/GraphicsContextCairo.cpp platform/graphics/cairo/ImageBufferCairo.cpp platform/graphics/cairo/ImageCairo.cpp +platform/graphics/cairo/IntRectCairo.cpp platform/graphics/cairo/NativeImageCairo.cpp platform/graphics/cairo/OwnPtrCairo.cpp platform/graphics/cairo/PathCairo.cpp @@ -142,6 +143,8 @@ platform/graphics/cairo/PlatformContextCairo.cpp platform/graphics/cairo/PlatformPathCairo.cpp platform/graphics/cairo/RefPtrCairo.cpp +platform/graphics/cairo/TileCairo.cpp +platform/graphics/cairo/TiledBackingStoreBackendCairo.cpp platform/graphics/cairo/TransformationMatrixCairo.cpp platform/image-decoders/cairo/ImageDecoderCairo.cpp Modified: trunk/Source/WebKit/efl/ChangeLog (123997 => 123998) --- trunk/Source/WebKit/efl/ChangeLog 2012-07-30 05:49:29 UTC (rev 123997) +++ trunk/Source/WebKit/efl/ChangeLog 2012-07-30 06:09:55 UTC (rev 123998) @@ -1,3 +1,18 @@ +2012-07-29 YoungTaeck Song youngtaeck.s...@samsung.com + +[WK2][EFL] TILED_BACKING_STORE support on Efl WebKit2 +https://bugs.webkit.org/show_bug.cgi?id=91582 + +Reviewed by Noam Rosenthal. + +Add a dummy function for fixing building error when enabling TILED_BACKING_STORE. + +* WebCoreSupport/ChromeClientEfl.cpp: +(WebCore): +(WebCore::ChromeClientEfl::delegatedScrollRequested): +* WebCoreSupport/ChromeClientEfl.h: +(ChromeClientEfl): + 2012-07-27 Christophe Dumez christophe.du...@intel.com [EFL] Regression(r123858): Default navigation policy decision was switched to reject Modified:
[webkit-changes] [123999] trunk/Source/WebCore
Title: [123999] trunk/Source/WebCore Revision 123999 Author commit-qu...@webkit.org Date 2012-07-29 23:25:19 -0700 (Sun, 29 Jul 2012) Log Message [WK2][EFL] Accelerated compositing support using TextureMapper on Efl WebKit2 https://bugs.webkit.org/show_bug.cgi?id=91583 Patch by YoungTaeck Song youngtaeck.s...@samsung.com on 2012-07-29 Reviewed by Noam Rosenthal. This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation. This patch adds Texture Mapper related files to PlatformEfl.cmake. And wrapped TextureMapperLayer and TextureMapperBackingStore with USE(ACCELERATED_COMPOSITING) for fixing building error when disable ACCELERATED_COMPOSITING. * CMakeLists.txt: * PlatformEfl.cmake: * platform/graphics/GraphicsLayer.cpp: (WebCore): * platform/graphics/GraphicsLayer.h: (GraphicsLayer): * platform/graphics/GraphicsLayerAnimation.cpp: * platform/graphics/GraphicsLayerAnimation.h: * platform/graphics/PlatformLayer.h: (WebCore): * platform/graphics/texmap/TextureMapperBackingStore.cpp: * platform/graphics/texmap/TextureMapperBackingStore.h: * platform/graphics/texmap/TextureMapperLayer.h: Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/PlatformEfl.cmake trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp trunk/Source/WebCore/platform/graphics/GraphicsLayer.h trunk/Source/WebCore/platform/graphics/GraphicsLayerAnimation.cpp trunk/Source/WebCore/platform/graphics/GraphicsLayerAnimation.h trunk/Source/WebCore/platform/graphics/PlatformLayer.h trunk/Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.cpp trunk/Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.h trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h Diff Modified: trunk/Source/WebCore/CMakeLists.txt (123998 => 123999) --- trunk/Source/WebCore/CMakeLists.txt 2012-07-30 06:09:55 UTC (rev 123998) +++ trunk/Source/WebCore/CMakeLists.txt 2012-07-30 06:25:19 UTC (rev 123999) @@ -1794,6 +1794,8 @@ platform/graphics/Gradient.cpp platform/graphics/GraphicsContext.cpp platform/graphics/GraphicsLayer.cpp +platform/graphics/GraphicsLayerAnimation.cpp +platform/graphics/GraphicsLayerTransform.cpp platform/graphics/GraphicsTypes.cpp platform/graphics/Image.cpp platform/graphics/ImageBuffer.cpp @@ -1854,6 +1856,11 @@ platform/graphics/filters/arm/FELightingNEON.cpp platform/graphics/filters/arm/FELightingNEON.h +platform/graphics/texmap/TextureMapper.cpp +platform/graphics/texmap/TextureMapperBackingStore.cpp +platform/graphics/texmap/TextureMapperImageBuffer.cpp +platform/graphics/texmap/TextureMapperLayer.cpp + platform/graphics/transforms/AffineTransform.cpp platform/graphics/transforms/Matrix3DTransformOperation.cpp platform/graphics/transforms/MatrixTransformOperation.cpp Modified: trunk/Source/WebCore/ChangeLog (123998 => 123999) --- trunk/Source/WebCore/ChangeLog 2012-07-30 06:09:55 UTC (rev 123998) +++ trunk/Source/WebCore/ChangeLog 2012-07-30 06:25:19 UTC (rev 123999) @@ -1,5 +1,30 @@ 2012-07-29 YoungTaeck Song youngtaeck.s...@samsung.com +[WK2][EFL] Accelerated compositing support using TextureMapper on Efl WebKit2 +https://bugs.webkit.org/show_bug.cgi?id=91583 + +Reviewed by Noam Rosenthal. + +This patch is a subset of Efl's UI_SIDE_COMPOSITING implementation. +This patch adds Texture Mapper related files to PlatformEfl.cmake. +And wrapped TextureMapperLayer and TextureMapperBackingStore with USE(ACCELERATED_COMPOSITING) for fixing building error when disable ACCELERATED_COMPOSITING. + +* CMakeLists.txt: +* PlatformEfl.cmake: +* platform/graphics/GraphicsLayer.cpp: +(WebCore): +* platform/graphics/GraphicsLayer.h: +(GraphicsLayer): +* platform/graphics/GraphicsLayerAnimation.cpp: +* platform/graphics/GraphicsLayerAnimation.h: +* platform/graphics/PlatformLayer.h: +(WebCore): +* platform/graphics/texmap/TextureMapperBackingStore.cpp: +* platform/graphics/texmap/TextureMapperBackingStore.h: +* platform/graphics/texmap/TextureMapperLayer.h: + +2012-07-29 YoungTaeck Song youngtaeck.s...@samsung.com + [WK2][EFL] TILED_BACKING_STORE support on Efl WebKit2 https://bugs.webkit.org/show_bug.cgi?id=91582 Modified: trunk/Source/WebCore/PlatformEfl.cmake (123998 => 123999) --- trunk/Source/WebCore/PlatformEfl.cmake 2012-07-30 06:09:55 UTC (rev 123998) +++ trunk/Source/WebCore/PlatformEfl.cmake 2012-07-30 06:25:19 UTC (rev 123999) @@ -65,7 +65,6 @@ platform/efl/TemporaryLinkStubs.cpp platform/efl/WidgetEfl.cpp platform/graphics/ImageSource.cpp - platform/graphics/efl/GraphicsLayerEfl.cpp platform/graphics/efl/IconEfl.cpp platform/graphics/efl/ImageEfl.cpp platform/graphics/efl/IntPointEfl.cpp @@ -204,6 +203,16 @@ ) ENDIF () +IF (WTF_USE_TEXTURE_MAPPER)
[webkit-changes] [124001] trunk/Tools
Title: [124001] trunk/Tools Revision 124001 Author commit-qu...@webkit.org Date 2012-07-30 00:58:25 -0700 (Mon, 30 Jul 2012) Log Message [EFL][WTR] Enforce SHIFT modifier to upper case keys in event sender. https://bugs.webkit.org/show_bug.cgi?id=92366 Patch by Mikhail Pozdnyakov mikhail.pozdnya...@intel.com on 2012-07-30 Reviewed by Antonio Gomes. Add SHIFT modifier for capital letters as VK_ codes do not distinguish between lows and caps and also to be consistent with other ports which send caps as lowercase letters with the shift key down. * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: (WTR::EventSenderProxy::keyDown): Modified Paths trunk/Tools/ChangeLog trunk/Tools/WebKitTestRunner/efl/EventSenderProxyEfl.cpp Diff Modified: trunk/Tools/ChangeLog (124000 => 124001) --- trunk/Tools/ChangeLog 2012-07-30 07:54:54 UTC (rev 124000) +++ trunk/Tools/ChangeLog 2012-07-30 07:58:25 UTC (rev 124001) @@ -1,3 +1,17 @@ +2012-07-30 Mikhail Pozdnyakov mikhail.pozdnya...@intel.com + +[EFL][WTR] Enforce SHIFT modifier to upper case keys in event sender. +https://bugs.webkit.org/show_bug.cgi?id=92366 + +Reviewed by Antonio Gomes. + +Add SHIFT modifier for capital letters as VK_ +codes do not distinguish between lows and caps and also to be consistent +with other ports which send caps as lowercase letters with the shift key down. + +* WebKitTestRunner/efl/EventSenderProxyEfl.cpp: +(WTR::EventSenderProxy::keyDown): + 2012-07-29 Raphael Kubo da Costa rak...@webkit.org [EFL][jhbuild] Make run-with-jhbuild become the jhbuild process itself. Modified: trunk/Tools/WebKitTestRunner/efl/EventSenderProxyEfl.cpp (124000 => 124001) --- trunk/Tools/WebKitTestRunner/efl/EventSenderProxyEfl.cpp 2012-07-30 07:54:54 UTC (rev 124000) +++ trunk/Tools/WebKitTestRunner/efl/EventSenderProxyEfl.cpp 2012-07-30 07:58:25 UTC (rev 124001) @@ -401,6 +401,10 @@ const char* keyName = keyEventInfo-keyName.data(); const char* keyString = keyEventInfo-keyString.data(); +// Enforce 'Shift' modifier for caps. +if ((strlen(keyName) == 1) (keyName[0] = 'A' keyName[0] = 'Z')) +wkModifiers |= kWKEventModifiersShiftKey; + Evas* evas = ecore_evas_get(m_testController-mainWebView()-platformWindow()); setEvasModifiers(evas, wkModifiers); evas_event_feed_key_down(evas, keyName, keyName, keyString, 0, 0, 0); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124002] trunk/Source/WebKit
Title: [124002] trunk/Source/WebKit
Revision 124002
Author hausm...@webkit.org
Date 2012-07-30 01:18:07 -0700 (Mon, 30 Jul 2012)
Log Message
Unreviewed Qt/Mac build fix: Use libWebKitSystemInterfaceMountainLion.a
on Mountain Lion.
* WebKit1.pri:
Modified Paths
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit1.pri
Diff
Modified: trunk/Source/WebKit/ChangeLog (124001 => 124002)
--- trunk/Source/WebKit/ChangeLog 2012-07-30 07:58:25 UTC (rev 124001)
+++ trunk/Source/WebKit/ChangeLog 2012-07-30 08:18:07 UTC (rev 124002)
@@ -1,3 +1,10 @@
+2012-07-30 Simon Hausmann simon.hausm...@nokia.com
+
+Unreviewed Qt/Mac build fix: Use libWebKitSystemInterfaceMountainLion.a
+on Mountain Lion.
+
+* WebKit1.pri:
+
2012-07-27 Thiago Marcos P. Santos thiago.san...@intel.com
[EFL] WebKit API unit tests needs a timeout
Modified: trunk/Source/WebKit/WebKit1.pri (124001 => 124002)
--- trunk/Source/WebKit/WebKit1.pri 2012-07-30 07:58:25 UTC (rev 124001)
+++ trunk/Source/WebKit/WebKit1.pri 2012-07-30 08:18:07 UTC (rev 124002)
@@ -18,7 +18,9 @@
# We can know the Mac OS version by using the Darwin major version
DARWIN_VERSION = $$split(QMAKE_HOST.version, .)
DARWIN_MAJOR_VERSION = $$first(DARWIN_VERSION)
-equals(DARWIN_MAJOR_VERSION, 11) {
+equals(DARWIN_MAJOR_VERSION, 12) {
+LIBS += $${ROOT_WEBKIT_DIR}/WebKitLibraries/libWebKitSystemInterfaceMountainLion.a
+} else:equals(DARWIN_MAJOR_VERSION, 11) {
LIBS += $${ROOT_WEBKIT_DIR}/WebKitLibraries/libWebKitSystemInterfaceLion.a
} else:equals(DARWIN_MAJOR_VERSION, 10) {
LIBS += $${ROOT_WEBKIT_DIR}/WebKitLibraries/libWebKitSystemInterfaceSnowLeopard.a
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124003] trunk
Title: [124003] trunk Revision 124003 Author ma...@webkit.org Date 2012-07-30 01:28:07 -0700 (Mon, 30 Jul 2012) Log Message REGRESSION (r123767): platform/gtk/accessibility/object-with-title.html failing on GTK https://bugs.webkit.org/show_bug.cgi?id=92477 Reviewed by Chris Fleizach. Source/WebCore: Consider title and accessibilityDescription together with helpText to decide whether an object should be exposed in the accessibility tree. * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): LayoutTests: Remove passing test from TestExpectations. * platform/gtk/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/gtk/TestExpectations trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp Diff Modified: trunk/LayoutTests/ChangeLog (124002 => 124003) --- trunk/LayoutTests/ChangeLog 2012-07-30 08:18:07 UTC (rev 124002) +++ trunk/LayoutTests/ChangeLog 2012-07-30 08:28:07 UTC (rev 124003) @@ -1,3 +1,14 @@ +2012-07-30 Mario Sanchez Prada msanc...@igalia.com + +REGRESSION (r123767): platform/gtk/accessibility/object-with-title.html failing on GTK +https://bugs.webkit.org/show_bug.cgi?id=92477 + +Reviewed by Chris Fleizach. + +Remove passing test from TestExpectations. + +* platform/gtk/TestExpectations: + 2012-07-29 Vsevolod Vlasov vse...@chromium.org Web Inspector: Resource agent's reference to cached resources should be weak. Modified: trunk/LayoutTests/platform/gtk/TestExpectations (124002 => 124003) --- trunk/LayoutTests/platform/gtk/TestExpectations 2012-07-30 08:18:07 UTC (rev 124002) +++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-07-30 08:28:07 UTC (rev 124003) @@ -1261,7 +1261,6 @@ // This test depends on subpixel layout. BUGWK92352 : css3/flexbox/flex-rounding.html = TEXT -BUGWK92477 : platform/gtk/accessibility/object-with-title.html = TEXT // // End of Tests failing Modified: trunk/Source/WebCore/ChangeLog (124002 => 124003) --- trunk/Source/WebCore/ChangeLog 2012-07-30 08:18:07 UTC (rev 124002) +++ trunk/Source/WebCore/ChangeLog 2012-07-30 08:28:07 UTC (rev 124003) @@ -1,3 +1,16 @@ +2012-07-30 Mario Sanchez Prada msanc...@igalia.com + +REGRESSION (r123767): platform/gtk/accessibility/object-with-title.html failing on GTK +https://bugs.webkit.org/show_bug.cgi?id=92477 + +Reviewed by Chris Fleizach. + +Consider title and accessibilityDescription together with helpText to +decide whether an object should be exposed in the accessibility tree. + +* accessibility/AccessibilityRenderObject.cpp: +(WebCore::AccessibilityRenderObject::accessibilityIsIgnored): + 2012-07-29 Vsevolod Vlasov vse...@chromium.org Web Inspector: Resource agent's reference to cached resources should be weak. Modified: trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp (124002 => 124003) --- trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2012-07-30 08:18:07 UTC (rev 124002) +++ trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp 2012-07-30 08:28:07 UTC (rev 124003) @@ -1996,9 +1996,11 @@ if (isWebArea() || m_renderer-isListMarker()) return false; -// Using the help text to decide an element's visibility is not as definitive -// as previous checks, so this should remain as one of the last. -if (!helpText().isEmpty()) +// Using the help text, title or accessibility description (so we +// check if there's some kind of accessible name for the element) +// to decide an element's visibility is not as definitive as +// previous checks, so this should remain as one of the last. +if (!helpText().isEmpty() || !title().isEmpty() || !accessibilityDescription().isEmpty()) return false; // By default, objects should be ignored so that the AX hierarchy is not ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124005] trunk/Source/WebCore
Title: [124005] trunk/Source/WebCore
Revision 124005
Author pfeld...@chromium.org
Date 2012-07-30 01:57:44 -0700 (Mon, 30 Jul 2012)
Log Message
Web Inspector: workers inspector is broken in the remote debugging mode
https://bugs.webkit.org/show_bug.cgi?id=92540
Reviewed by Yury Semikhatsky.
The problem was that worker manager re-used complete url with query parameters
for spin-off worker front-ends. As a result, in case of remote debugging, newly
created front-ends were connecting to the same web socket (because of the ws parameter).
* inspector/front-end/WorkerManager.js:
(WebInspector.WorkerManager.isDedicatedWorkerFrontend):
* inspector/front-end/inspector.js:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/WorkerManager.js
trunk/Source/WebCore/inspector/front-end/inspector.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (124004 => 124005)
--- trunk/Source/WebCore/ChangeLog 2012-07-30 08:33:24 UTC (rev 124004)
+++ trunk/Source/WebCore/ChangeLog 2012-07-30 08:57:44 UTC (rev 124005)
@@ -1,3 +1,18 @@
+2012-07-30 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: workers inspector is broken in the remote debugging mode
+https://bugs.webkit.org/show_bug.cgi?id=92540
+
+Reviewed by Yury Semikhatsky.
+
+The problem was that worker manager re-used complete url with query parameters
+for spin-off worker front-ends. As a result, in case of remote debugging, newly
+created front-ends were connecting to the same web socket (because of the ws parameter).
+
+* inspector/front-end/WorkerManager.js:
+(WebInspector.WorkerManager.isDedicatedWorkerFrontend):
+* inspector/front-end/inspector.js:
+
2012-07-30 Keishi Hattori kei...@webkit.org
Implement datalist UI for input type color for Chromium
Modified: trunk/Source/WebCore/inspector/front-end/WorkerManager.js (124004 => 124005)
--- trunk/Source/WebCore/inspector/front-end/WorkerManager.js 2012-07-30 08:33:24 UTC (rev 124004)
+++ trunk/Source/WebCore/inspector/front-end/WorkerManager.js 2012-07-30 08:57:44 UTC (rev 124005)
@@ -44,6 +44,11 @@
!!WebInspector.queryParamsObject[isSharedWorker];
}
+WebInspector.WorkerManager.isDedicatedWorkerFrontend = function()
+{
+return !!WebInspector.queryParamsObject[dedicatedWorkerId];
+}
+
WebInspector.WorkerManager.loaded = function()
{
var workerId = WebInspector.queryParamsObject[dedicatedWorkerId];
Modified: trunk/Source/WebCore/inspector/front-end/inspector.js (124004 => 124005)
--- trunk/Source/WebCore/inspector/front-end/inspector.js 2012-07-30 08:33:24 UTC (rev 124004)
+++ trunk/Source/WebCore/inspector/front-end/inspector.js 2012-07-30 08:57:44 UTC (rev 124005)
@@ -389,6 +389,12 @@
{
InspectorBackend.loadFromJSONIfNeeded();
+if (WebInspector.WorkerManager.isDedicatedWorkerFrontend()) {
+// Do not create socket for the worker front-end.
+WebInspector.doLoadedDone();
+return;
+}
+
var ws;
if (ws in WebInspector.queryParamsObject)
ws = ws:// + WebInspector.queryParamsObject.ws;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124006] trunk/Source
Title: [124006] trunk/Source
Revision 124006
Author yu...@chromium.org
Date 2012-07-30 02:05:11 -0700 (Mon, 30 Jul 2012)
Log Message
Web Inspector: move StringImpl size calculation to StringImpl
https://bugs.webkit.org/show_bug.cgi?id=92359
Reviewed by Pavel Feldman.
Moved stringSize(StringImpl*) implementation from InspectorMemoryAgent to
StringImpl::sizeInBytes();
Source/WebCore:
* inspector/InspectorMemoryAgent.cpp:
(WebCore):
Source/WTF:
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::sizeInBytes):
(WTF):
* wtf/text/StringImpl.h:
(StringImpl):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/text/StringImpl.cpp
trunk/Source/WTF/wtf/text/StringImpl.h
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (124005 => 124006)
--- trunk/Source/WTF/ChangeLog 2012-07-30 08:57:44 UTC (rev 124005)
+++ trunk/Source/WTF/ChangeLog 2012-07-30 09:05:11 UTC (rev 124006)
@@ -1,3 +1,19 @@
+2012-07-26 Yury Semikhatsky yu...@chromium.org
+
+Web Inspector: move StringImpl size calculation to StringImpl
+https://bugs.webkit.org/show_bug.cgi?id=92359
+
+Reviewed by Pavel Feldman.
+
+Moved stringSize(StringImpl*) implementation from InspectorMemoryAgent to
+StringImpl::sizeInBytes();
+
+* wtf/text/StringImpl.cpp:
+(WTF::StringImpl::sizeInBytes):
+(WTF):
+* wtf/text/StringImpl.h:
+(StringImpl):
+
2012-07-28 Patrick Gansterer par...@webkit.org
[WIN] Add missing export macro to friend decleration.
Modified: trunk/Source/WTF/wtf/text/StringImpl.cpp (124005 => 124006)
--- trunk/Source/WTF/wtf/text/StringImpl.cpp 2012-07-30 08:57:44 UTC (rev 124005)
+++ trunk/Source/WTF/wtf/text/StringImpl.cpp 2012-07-30 09:05:11 UTC (rev 124006)
@@ -1693,4 +1693,19 @@
return terminatedString.release();
}
+size_t StringImpl::sizeInBytes() const
+{
+// FIXME: support substrings
+size_t size = length();
+if (is8Bit()) {
+if (has16BitShadow()) {
+size += 2 * size;
+if (hasTerminatingNullCharacter())
+size += 2;
+}
+} else
+size *= 2;
+return size + sizeof(*this);
+}
+
} // namespace WTF
Modified: trunk/Source/WTF/wtf/text/StringImpl.h (124005 => 124006)
--- trunk/Source/WTF/wtf/text/StringImpl.h 2012-07-30 08:57:44 UTC (rev 124005)
+++ trunk/Source/WTF/wtf/text/StringImpl.h 2012-07-30 09:05:11 UTC (rev 124006)
@@ -385,6 +385,8 @@
return m_length;
}
+WTF_EXPORT_PRIVATE size_t sizeInBytes() const;
+
bool has16BitShadow() const { return m_hashAndFlags s_hashFlagHas16BitShadow; }
WTF_EXPORT_PRIVATE void upconvertCharacters(unsigned, unsigned) const;
bool isIdentifier() const { return m_hashAndFlags s_hashFlagIsIdentifier; }
Modified: trunk/Source/WebCore/ChangeLog (124005 => 124006)
--- trunk/Source/WebCore/ChangeLog 2012-07-30 08:57:44 UTC (rev 124005)
+++ trunk/Source/WebCore/ChangeLog 2012-07-30 09:05:11 UTC (rev 124006)
@@ -1,3 +1,16 @@
+2012-07-26 Yury Semikhatsky yu...@chromium.org
+
+Web Inspector: move StringImpl size calculation to StringImpl
+https://bugs.webkit.org/show_bug.cgi?id=92359
+
+Reviewed by Pavel Feldman.
+
+Moved stringSize(StringImpl*) implementation from InspectorMemoryAgent to
+StringImpl::sizeInBytes();
+
+* inspector/InspectorMemoryAgent.cpp:
+(WebCore):
+
2012-07-30 Pavel Feldman pfeld...@chromium.org
Web Inspector: workers inspector is broken in the remote debugging mode
Modified: trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp (124005 => 124006)
--- trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp 2012-07-30 08:57:44 UTC (rev 124005)
+++ trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp 2012-07-30 09:05:11 UTC (rev 124006)
@@ -110,21 +110,6 @@
return node-nodeName().lower();
}
-size_t stringSize(StringImpl* string)
-{
-// FIXME: support substrings
-size_t size = string-length();
-if (string-is8Bit()) {
-if (string-has16BitShadow()) {
-size += 2 * size;
-if (string-hasTerminatingNullCharacter())
-size += 2;
-}
-} else
-size *= 2;
-return size + sizeof(*string);
-}
-
typedef HashSetStringImpl*, PtrHashStringImpl* StringImplIdentitySet;
class CharacterDataStatistics {
@@ -143,7 +128,7 @@
return;
m_domStringImplSet.add(dataImpl);
-m_characterDataSize += stringSize(dataImpl);
+m_characterDataSize += dataImpl-sizeInBytes();
}
bool contains(StringImpl* s) { return m_domStringImplSet.contains(s); }
@@ -288,7 +273,7 @@
virtual void visitJSExternalString(StringImpl* string)
{
-int size = stringSize(string);
+int size = string-sizeInBytes();
m_jsExternalStringSize += size;
if
[webkit-changes] [124007] trunk/Source/WebCore
Title: [124007] trunk/Source/WebCore
Revision 124007
Author pfeld...@chromium.org
Date 2012-07-30 02:25:21 -0700 (Mon, 30 Jul 2012)
Log Message
Web Inspector: element tag disappears after editing
https://bugs.webkit.org/show_bug.cgi?id=92385
Reviewed by Vsevolod Vlasov.
This has regressed when we started hiding elements panel upon
batch updates. Narrowing hiding cases, updating selection
in on-screen mode only.
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype.updateSelection):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (124006 => 124007)
--- trunk/Source/WebCore/ChangeLog 2012-07-30 09:05:11 UTC (rev 124006)
+++ trunk/Source/WebCore/ChangeLog 2012-07-30 09:25:21 UTC (rev 124007)
@@ -1,3 +1,17 @@
+2012-07-30 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: element tag disappears after editing
+https://bugs.webkit.org/show_bug.cgi?id=92385
+
+Reviewed by Vsevolod Vlasov.
+
+This has regressed when we started hiding elements panel upon
+batch updates. Narrowing hiding cases, updating selection
+in on-screen mode only.
+
+* inspector/front-end/ElementsTreeOutline.js:
+(WebInspector.ElementsTreeElement.prototype.updateSelection):
+
2012-07-26 Yury Semikhatsky yu...@chromium.org
Web Inspector: move StringImpl size calculation to StringImpl
Modified: trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js (124006 => 124007)
--- trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js 2012-07-30 09:05:11 UTC (rev 124006)
+++ trunk/Source/WebCore/inspector/front-end/ElementsTreeOutline.js 2012-07-30 09:25:21 UTC (rev 124007)
@@ -2037,10 +2037,14 @@
}
var updatedParentTreeElements = [];
-var treeOutlineContainerElement = this._treeOutline.element.parentNode;
-var originalScrollTop = treeOutlineContainerElement ? treeOutlineContainerElement.scrollTop : 0;
-this._treeOutline.element.addStyleClass(hidden);
+var hidePanelWhileUpdating = this._recentlyModifiedNodes.length 10;
+if (hidePanelWhileUpdating) {
+var treeOutlineContainerElement = this._treeOutline.element.parentNode;
+this._treeOutline.element.addStyleClass(hidden);
+var originalScrollTop = treeOutlineContainerElement ? treeOutlineContainerElement.scrollTop : 0;
+}
+
for (var i = 0; i this._recentlyModifiedNodes.length; ++i) {
var parent = this._recentlyModifiedNodes[i].parent;
@@ -2074,9 +2078,12 @@
for (var i = 0; i updatedParentTreeElements.length; ++i)
delete updatedParentTreeElements[i].alreadyUpdatedChildren;
-this._treeOutline.element.removeStyleClass(hidden);
-if (originalScrollTop)
-treeOutlineContainerElement.scrollTop = originalScrollTop;
+if (hidePanelWhileUpdating) {
+this._treeOutline.element.removeStyleClass(hidden);
+if (originalScrollTop)
+treeOutlineContainerElement.scrollTop = originalScrollTop;
+this._treeOutline.updateSelection();
+}
this._recentlyModifiedNodes = [];
},
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124009] trunk/Source/WebCore
Title: [124009] trunk/Source/WebCore Revision 124009 Author hay...@chromium.org Date 2012-07-30 02:45:47 -0700 (Mon, 30 Jul 2012) Log Message Remove unnecessary code which set event's target from EventDispatcher::dispatchEvent. https://bugs.webkit.org/show_bug.cgi?id=92613 Reviewed by Hajime Morita. EventContext::handleLocalEvents does all required jobs so we don't need to set target in EventDispacher::dispatchEvent() for TARGET phase. No new tests, no behavior change. * dom/EventDispatcher.cpp: (WebCore::EventDispatcher::dispatchEvent): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/EventDispatcher.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (124008 => 124009) --- trunk/Source/WebCore/ChangeLog 2012-07-30 09:29:45 UTC (rev 124008) +++ trunk/Source/WebCore/ChangeLog 2012-07-30 09:45:47 UTC (rev 124009) @@ -1,3 +1,18 @@ +2012-07-30 Hayato Ito hay...@chromium.org + +Remove unnecessary code which set event's target from EventDispatcher::dispatchEvent. +https://bugs.webkit.org/show_bug.cgi?id=92613 + +Reviewed by Hajime Morita. + +EventContext::handleLocalEvents does all required jobs so we don't +need to set target in EventDispacher::dispatchEvent() for TARGET phase. + +No new tests, no behavior change. + +* dom/EventDispatcher.cpp: +(WebCore::EventDispatcher::dispatchEvent): + 2012-07-30 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r124004. Modified: trunk/Source/WebCore/dom/EventDispatcher.cpp (124008 => 124009) --- trunk/Source/WebCore/dom/EventDispatcher.cpp 2012-07-30 09:29:45 UTC (rev 124008) +++ trunk/Source/WebCore/dom/EventDispatcher.cpp 2012-07-30 09:45:47 UTC (rev 124009) @@ -277,8 +277,6 @@ } event-setEventPhase(Event::AT_TARGET); -event-setTarget(originalTarget.get()); -event-setCurrentTarget(eventTargetRespectingSVGTargetRules(m_node.get())); m_ancestors[0].handleLocalEvents(event.get()); if (event-propagationStopped()) goto doneDispatching; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124010] trunk
Title: [124010] trunk Revision 124010 Author par...@webkit.org Date 2012-07-30 03:25:41 -0700 (Mon, 30 Jul 2012) Log Message Replace UnicodeWinCE with UnicodeWchar https://bugs.webkit.org/show_bug.cgi?id=92539 Reviewed by Ryosuke Niwa. UnicodeWinCE never contained WinCE specific code. UnicodeWchar is a replacement for it, which is mainly based on the functions from wchar.h. It is ment as a minimal Unicode backend, which can be used very easy and has no external dependencies. .: * Source/cmake/OptionsWinCE.cmake: Source/WebCore: * platform/text/TextEncoding.cpp: (WebCore::TextEncoding::encode): * platform/text/TextEncodingRegistry.cpp: (WebCore::extendTextCodecMaps): Source/WebKit/blackberry: * WebCoreSupport/AboutDataUseFeatures.in: Source/WTF: * WTF.gyp/WTF.gyp: * WTF.gypi: * wtf/Platform.h: * wtf/PlatformWinCE.cmake: * wtf/unicode/Unicode.h: * wtf/unicode/wchar/UnicodeWchar.cpp: Added. (Unicode): (WTF::Unicode::category): (WTF::Unicode::combiningClass): (WTF::Unicode::direction): (WTF::Unicode::decompositionType): (WTF::Unicode::hasLineBreakingPropertyComplexContext): (WTF::Unicode::mirroredChar): (WTF::Unicode::convertWithFunction): (WTF::Unicode::foldCase): (WTF::Unicode::toLower): (WTF::Unicode::toUpper): * wtf/unicode/wchar/UnicodeWchar.h: Added. (Unicode): (WTF::Unicode::isAlphanumeric): (WTF::Unicode::isDigit): (WTF::Unicode::isLetter): (WTF::Unicode::isLower): (WTF::Unicode::isPrintableChar): (WTF::Unicode::isPunct): (WTF::Unicode::isSpace): (WTF::Unicode::isUpper): (WTF::Unicode::isArabicChar): (WTF::Unicode::isSeparatorSpace): (WTF::Unicode::foldCase): (WTF::Unicode::toLower): (WTF::Unicode::toUpper): (WTF::Unicode::toTitleCase): (WTF::Unicode::umemcasecmp): * wtf/unicode/wince/UnicodeWinCE.cpp: Removed. * wtf/unicode/wince/UnicodeWinCE.h: Removed. Modified Paths trunk/ChangeLog trunk/Source/WTF/ChangeLog trunk/Source/WTF/WTF.gyp/WTF.gyp trunk/Source/WTF/WTF.gypi trunk/Source/WTF/wtf/Platform.h trunk/Source/WTF/wtf/PlatformWinCE.cmake trunk/Source/WTF/wtf/unicode/Unicode.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/text/TextEncoding.cpp trunk/Source/WebCore/platform/text/TextEncodingRegistry.cpp trunk/Source/WebKit/blackberry/ChangeLog trunk/Source/WebKit/blackberry/WebCoreSupport/AboutDataUseFeatures.in trunk/Source/cmake/OptionsWinCE.cmake Added Paths trunk/Source/WTF/wtf/unicode/wchar/ trunk/Source/WTF/wtf/unicode/wchar/UnicodeWchar.cpp trunk/Source/WTF/wtf/unicode/wchar/UnicodeWchar.h Removed Paths trunk/Source/WTF/wtf/unicode/wince/UnicodeWinCE.cpp trunk/Source/WTF/wtf/unicode/wince/UnicodeWinCE.h Diff Modified: trunk/ChangeLog (124009 => 124010) --- trunk/ChangeLog 2012-07-30 09:45:47 UTC (rev 124009) +++ trunk/ChangeLog 2012-07-30 10:25:41 UTC (rev 124010) @@ -1,3 +1,17 @@ +2012-07-30 Patrick Gansterer par...@webkit.org + +Replace UnicodeWinCE with UnicodeWchar +https://bugs.webkit.org/show_bug.cgi?id=92539 + +Reviewed by Ryosuke Niwa. + +UnicodeWinCE never contained WinCE specific code. UnicodeWchar +is a replacement for it, which is mainly based on the functions +from wchar.h. It is ment as a minimal Unicode backend, which +can be used very easy and has no external dependencies. + +* Source/cmake/OptionsWinCE.cmake: + 2012-07-29 Vsevolod Vlasov vse...@chromium.org Web Inspector: Resource agent's reference to cached resources should be weak. Modified: trunk/Source/WTF/ChangeLog (124009 => 124010) --- trunk/Source/WTF/ChangeLog 2012-07-30 09:45:47 UTC (rev 124009) +++ trunk/Source/WTF/ChangeLog 2012-07-30 10:25:41 UTC (rev 124010) @@ -1,3 +1,52 @@ +2012-07-30 Patrick Gansterer par...@webkit.org + +Replace UnicodeWinCE with UnicodeWchar +https://bugs.webkit.org/show_bug.cgi?id=92539 + +Reviewed by Ryosuke Niwa. + +UnicodeWinCE never contained WinCE specific code. UnicodeWchar +is a replacement for it, which is mainly based on the functions +from wchar.h. It is ment as a minimal Unicode backend, which +can be used very easy and has no external dependencies. + +* WTF.gyp/WTF.gyp: +* WTF.gypi: +* wtf/Platform.h: +* wtf/PlatformWinCE.cmake: +* wtf/unicode/Unicode.h: +* wtf/unicode/wchar/UnicodeWchar.cpp: Added. +(Unicode): +(WTF::Unicode::category): +(WTF::Unicode::combiningClass): +(WTF::Unicode::direction): +(WTF::Unicode::decompositionType): +(WTF::Unicode::hasLineBreakingPropertyComplexContext): +(WTF::Unicode::mirroredChar): +(WTF::Unicode::convertWithFunction): +(WTF::Unicode::foldCase): +(WTF::Unicode::toLower): +(WTF::Unicode::toUpper): +* wtf/unicode/wchar/UnicodeWchar.h: Added. +(Unicode): +(WTF::Unicode::isAlphanumeric): +(WTF::Unicode::isDigit): +(WTF::Unicode::isLetter): +(WTF::Unicode::isLower): +
[webkit-changes] [124012] trunk/Source
Title: [124012] trunk/Source
Revision 124012
Author jocelyn.turco...@nokia.com
Date 2012-07-30 04:31:27 -0700 (Mon, 30 Jul 2012)
Log Message
[Qt] Fix issues remaining with fixed positioned layers
https://bugs.webkit.org/show_bug.cgi?id=92528
Reviewed by Noam Rosenthal.
Source/WebCore:
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::syncCompositingStateSelf):
Make sure that the delta is used when syncCompositingStateSelf is called afterward.
(WebCore::TextureMapperLayer::setScrollPositionDeltaIfNeeded):
* platform/graphics/texmap/TextureMapperLayer.h:
Use a FloatSize instead of an IntPoint for the delta.
(TextureMapperLayer):
(WebCore::TextureMapperLayer::adjustedPosition):
Source/WebKit2:
This partially fixes jittering of fixed layers when zoomed in and the
blurriness of rendered tiles of the non-composited contents layer.
* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::boundedScrollPosition):
(WebKit::WebLayerTreeRenderer::paintToCurrentGLContext):
Remove the adjustment on the root layer. This cancels setPixelAligned and causes the blurriness.
(WebKit::WebLayerTreeRenderer::adjustPositionForFixedLayers):
Use m_accurateVisibleContentsPosition to calculate the delta.
(WebKit::WebLayerTreeRenderer::didChangeScrollPosition):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (124011 => 124012)
--- trunk/Source/WebCore/ChangeLog 2012-07-30 10:33:43 UTC (rev 124011)
+++ trunk/Source/WebCore/ChangeLog 2012-07-30 11:31:27 UTC (rev 124012)
@@ -1,3 +1,19 @@
+2012-07-27 Jocelyn Turcotte jocelyn.turco...@nokia.com
+
+[Qt] Fix issues remaining with fixed positioned layers
+https://bugs.webkit.org/show_bug.cgi?id=92528
+
+Reviewed by Noam Rosenthal.
+
+* platform/graphics/texmap/TextureMapperLayer.cpp:
+(WebCore::TextureMapperLayer::syncCompositingStateSelf):
+Make sure that the delta is used when syncCompositingStateSelf is called afterward.
+(WebCore::TextureMapperLayer::setScrollPositionDeltaIfNeeded):
+* platform/graphics/texmap/TextureMapperLayer.h:
+Use a FloatSize instead of an IntPoint for the delta.
+(TextureMapperLayer):
+(WebCore::TextureMapperLayer::adjustedPosition):
+
2012-07-30 Patrick Gansterer par...@webkit.org
Replace UnicodeWinCE with UnicodeWchar
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp (124011 => 124012)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp 2012-07-30 10:33:43 UTC (rev 124011)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp 2012-07-30 11:31:27 UTC (rev 124012)
@@ -487,7 +487,7 @@
m_state.needsDisplayRect.unite(graphicsLayer-needsDisplayRect());
m_contentsLayer = graphicsLayer-contentsLayer();
-m_transform.setPosition(m_state.pos);
+m_transform.setPosition(adjustedPosition());
m_transform.setAnchorPoint(m_state.anchorPoint);
m_transform.setSize(m_state.size);
m_transform.setFlattening(!m_state.preserves3D);
@@ -567,17 +567,17 @@
return false;
}
-void TextureMapperLayer::setScrollPositionDeltaIfNeeded(const IntPoint delta)
+void TextureMapperLayer::setScrollPositionDeltaIfNeeded(const FloatSize delta)
{
// delta is the difference between the scroll offset in the ui process and the scroll offset
// in the web process. We add this delta to the position of fixed layers, to make
// sure that they do not move while scrolling. We need to reset this delta to fixed layers
// that have an ancestor which is also a fixed layer, because the delta will be added to the ancestor.
if (isAncestorFixedToViewport())
-m_scrollPositionDelta = IntPoint();
+m_scrollPositionDelta = FloatSize();
else
m_scrollPositionDelta = delta;
-m_transform.setPosition(m_state.pos + m_scrollPositionDelta);
+m_transform.setPosition(adjustedPosition());
}
void TextureMapperLayer::setDebugBorder(const Color color, float width)
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h (124011 => 124012)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h 2012-07-30 10:33:43 UTC (rev 124011)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h 2012-07-30 11:31:27 UTC (rev 124012)
@@ -128,7 +128,7 @@
PassRefPtrTextureMapperBackingStore backingStore() { return m_backingStore; }
void clearBackingStoresRecursive();
-void setScrollPositionDeltaIfNeeded(const IntPoint);
+void setScrollPositionDeltaIfNeeded(const FloatSize);
void setDebugBorder(const Color, float width);
@@ -149,6 +149,7 @@
static void
[webkit-changes] [124013] trunk/Source/WebKit2
Title: [124013] trunk/Source/WebKit2 Revision 124013 Author jocelyn.turco...@nokia.com Date 2012-07-30 04:33:41 -0700 (Mon, 30 Jul 2012) Log Message [Qt] Remove accurateVisibleContentsPosition and use a FloatRect for visibleContentsRect instead https://bugs.webkit.org/show_bug.cgi?id=92536 Reviewed by Noam Rosenthal. AccurateVisibleContentsPosition carries the same information as visibleContentsRect.location() and is needed for fixed layer position updates. This patch instead uses a FloatRect for the visible contents rect from the web view down to the LayerCoordinatorProxy, and converts it to an IntRect at this moment, before sending it to the web process. This also moves the check to prevent sending the same rect to the moment of the conversion in LayerTreeCoordinatorProxy to fix a bug where the fixed layer deltas wouldn't be updated unless the integer part of position components changed. * UIProcess/API/qt/qquickwebview.cpp: (QQuickWebViewLegacyPrivate::updateViewportSize): * UIProcess/DrawingAreaProxy.h: (WebKit::DrawingAreaProxy::setVisibleContentsRect): * UIProcess/DrawingAreaProxyImpl.cpp: (WebKit::DrawingAreaProxyImpl::setVisibleContentsRect): * UIProcess/DrawingAreaProxyImpl.h: (DrawingAreaProxyImpl): * UIProcess/LayerTreeCoordinatorProxy.cpp: (WebKit::LayerTreeCoordinatorProxy::LayerTreeCoordinatorProxy): (WebKit::LayerTreeCoordinatorProxy::setVisibleContentsRect): * UIProcess/LayerTreeCoordinatorProxy.h: (LayerTreeCoordinatorProxy): * UIProcess/WebLayerTreeRenderer.cpp: (WebKit::WebLayerTreeRenderer::WebLayerTreeRenderer): (WebKit::WebLayerTreeRenderer::setVisibleContentsRect): (WebKit::WebLayerTreeRenderer::adjustPositionForFixedLayers): * UIProcess/WebLayerTreeRenderer.h: (WebLayerTreeRenderer): * UIProcess/qt/QtViewportHandler.cpp: (WebKit::QtViewportHandler::visibleContentsRect): (WebKit::QtViewportHandler::informVisibleContentChange): * UIProcess/qt/QtViewportHandler.h: (QtViewportHandler): Modified Paths trunk/Source/WebKit2/ChangeLog trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp trunk/Source/WebKit2/UIProcess/DrawingAreaProxy.h trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.cpp trunk/Source/WebKit2/UIProcess/DrawingAreaProxyImpl.h trunk/Source/WebKit2/UIProcess/LayerTreeCoordinatorProxy.cpp trunk/Source/WebKit2/UIProcess/LayerTreeCoordinatorProxy.h trunk/Source/WebKit2/UIProcess/WebLayerTreeRenderer.cpp trunk/Source/WebKit2/UIProcess/WebLayerTreeRenderer.h trunk/Source/WebKit2/UIProcess/qt/QtViewportHandler.cpp trunk/Source/WebKit2/UIProcess/qt/QtViewportHandler.h Diff Modified: trunk/Source/WebKit2/ChangeLog (124012 => 124013) --- trunk/Source/WebKit2/ChangeLog 2012-07-30 11:31:27 UTC (rev 124012) +++ trunk/Source/WebKit2/ChangeLog 2012-07-30 11:33:41 UTC (rev 124013) @@ -1,5 +1,46 @@ 2012-07-27 Jocelyn Turcotte jocelyn.turco...@nokia.com +[Qt] Remove accurateVisibleContentsPosition and use a FloatRect for visibleContentsRect instead +https://bugs.webkit.org/show_bug.cgi?id=92536 + +Reviewed by Noam Rosenthal. + +AccurateVisibleContentsPosition carries the same information as visibleContentsRect.location() and +is needed for fixed layer position updates. +This patch instead uses a FloatRect for the visible contents rect from the web view down to the +LayerCoordinatorProxy, and converts it to an IntRect at this moment, before sending it to the +web process. +This also moves the check to prevent sending the same rect to the moment of the conversion +in LayerTreeCoordinatorProxy to fix a bug where the fixed layer deltas wouldn't be updated +unless the integer part of position components changed. + +* UIProcess/API/qt/qquickwebview.cpp: +(QQuickWebViewLegacyPrivate::updateViewportSize): +* UIProcess/DrawingAreaProxy.h: +(WebKit::DrawingAreaProxy::setVisibleContentsRect): +* UIProcess/DrawingAreaProxyImpl.cpp: +(WebKit::DrawingAreaProxyImpl::setVisibleContentsRect): +* UIProcess/DrawingAreaProxyImpl.h: +(DrawingAreaProxyImpl): +* UIProcess/LayerTreeCoordinatorProxy.cpp: +(WebKit::LayerTreeCoordinatorProxy::LayerTreeCoordinatorProxy): +(WebKit::LayerTreeCoordinatorProxy::setVisibleContentsRect): +* UIProcess/LayerTreeCoordinatorProxy.h: +(LayerTreeCoordinatorProxy): +* UIProcess/WebLayerTreeRenderer.cpp: +(WebKit::WebLayerTreeRenderer::WebLayerTreeRenderer): +(WebKit::WebLayerTreeRenderer::setVisibleContentsRect): +(WebKit::WebLayerTreeRenderer::adjustPositionForFixedLayers): +* UIProcess/WebLayerTreeRenderer.h: +(WebLayerTreeRenderer): +* UIProcess/qt/QtViewportHandler.cpp: +(WebKit::QtViewportHandler::visibleContentsRect): +(WebKit::QtViewportHandler::informVisibleContentChange): +* UIProcess/qt/QtViewportHandler.h: +(QtViewportHandler): + +2012-07-27 Jocelyn Turcotte
[webkit-changes] [124014] trunk/Source/WebCore
Title: [124014] trunk/Source/WebCore Revision 124014 Author hay...@chromium.org Date 2012-07-30 04:38:33 -0700 (Mon, 30 Jul 2012) Log Message Remove an unused member variable, m_originalTarget, from EventDispatcher. https://bugs.webkit.org/show_bug.cgi?id=92614 Reviewed by Andreas Kling. No one uses EventDispatcher::m_originalTarget. No new tests, no behavior change. * dom/EventDispatcher.h: (EventDispatcher): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/dom/EventDispatcher.h Diff Modified: trunk/Source/WebCore/ChangeLog (124013 => 124014) --- trunk/Source/WebCore/ChangeLog 2012-07-30 11:33:41 UTC (rev 124013) +++ trunk/Source/WebCore/ChangeLog 2012-07-30 11:38:33 UTC (rev 124014) @@ -1,3 +1,17 @@ +2012-07-30 Hayato Ito hay...@chromium.org + +Remove an unused member variable, m_originalTarget, from EventDispatcher. +https://bugs.webkit.org/show_bug.cgi?id=92614 + +Reviewed by Andreas Kling. + +No one uses EventDispatcher::m_originalTarget. + +No new tests, no behavior change. + +* dom/EventDispatcher.h: +(EventDispatcher): + 2012-07-27 Jocelyn Turcotte jocelyn.turco...@nokia.com [Qt] Fix issues remaining with fixed positioned layers Modified: trunk/Source/WebCore/dom/EventDispatcher.h (124013 => 124014) --- trunk/Source/WebCore/dom/EventDispatcher.h 2012-07-30 11:33:41 UTC (rev 124013) +++ trunk/Source/WebCore/dom/EventDispatcher.h 2012-07-30 11:38:33 UTC (rev 124014) @@ -82,7 +82,6 @@ VectorEventContext m_ancestors; RefPtrNode m_node; -RefPtrEventTarget m_originalTarget; RefPtrFrameView m_view; bool m_ancestorsInitialized; bool m_shouldPreventDispatch; ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124016] trunk/Source/WebCore
Title: [124016] trunk/Source/WebCore Revision 124016 Author apav...@chromium.org Date 2012-07-30 05:51:04 -0700 (Mon, 30 Jul 2012) Log Message Web Inspector: [Styles] No color swatch for the SVG fill and stroke property values https://bugs.webkit.org/show_bug.cgi?id=92638 Reviewed by Vsevolod Vlasov. Added the fill and stroke properties to the list of color-aware properties. * inspector/front-end/CSSKeywordCompletions.js: Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/front-end/CSSKeywordCompletions.js Diff Modified: trunk/Source/WebCore/ChangeLog (124015 => 124016) --- trunk/Source/WebCore/ChangeLog 2012-07-30 12:21:00 UTC (rev 124015) +++ trunk/Source/WebCore/ChangeLog 2012-07-30 12:51:04 UTC (rev 124016) @@ -1,3 +1,14 @@ +2012-07-30 Alexander Pavlov apav...@chromium.org + +Web Inspector: [Styles] No color swatch for the SVG fill and stroke property values +https://bugs.webkit.org/show_bug.cgi?id=92638 + +Reviewed by Vsevolod Vlasov. + +Added the fill and stroke properties to the list of color-aware properties. + +* inspector/front-end/CSSKeywordCompletions.js: + 2012-07-30 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r124000. Modified: trunk/Source/WebCore/inspector/front-end/CSSKeywordCompletions.js (124015 => 124016) --- trunk/Source/WebCore/inspector/front-end/CSSKeywordCompletions.js 2012-07-30 12:21:00 UTC (rev 124015) +++ trunk/Source/WebCore/inspector/front-end/CSSKeywordCompletions.js 2012-07-30 12:51:04 UTC (rev 124016) @@ -87,7 +87,7 @@ WebInspector.CSSKeywordCompletions._colorAwareProperties = [ background, background-color, background-image, border, border-color, border-top, border-right, border-bottom, border-left, border-top-color, border-right-color, border-bottom-color, border-left-color, box-shadow, color, -outline, outline-color, text-line-through, text-line-through-color, text-overline, text-overline-color, +fill, outline, outline-color, stroke, text-line-through, text-line-through-color, text-overline, text-overline-color, text-shadow, text-underline, text-underline-color, -webkit-box-shadow, -webkit-text-emphasis, -webkit-text-emphasis-color ].keySet(); ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124017] trunk/Source/WebCore
Title: [124017] trunk/Source/WebCore Revision 124017 Author yu...@chromium.org Date 2012-07-30 05:59:12 -0700 (Mon, 30 Jul 2012) Log Message Web Inspector: make MemoryInstrumentation methods private https://bugs.webkit.org/show_bug.cgi?id=92379 Reviewed by Vsevolod Vlasov. MemoryInstrumentation was refactored. - All reporting methods on MemoryInstrumentation except add*Object are private to enforce MemoryClassInfo usage. - MemoryInstrumentation::Add*Member methods renamed to Add*Object - String reporting is implemented directly in the MemoryInstrumentation, not in its descendants. * CMakeLists.txt: * GNUmakefile.list.am: * WebCore.gypi: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * bindings/v8/ScriptProfiler.cpp: (WebCore::ScriptProfiler::collectBindingMemoryInfo): * dom/MemoryInstrumentation.cpp: Added. (WebCore): (WebCore::MemoryInstrumentation::addString): * dom/MemoryInstrumentation.h: (WebCore::MemoryInstrumentation::addInstrumentedObject): (WebCore::MemoryInstrumentation::addObject): (MemoryInstrumentation): (InstrumentedPointerBase): (WebCore::MemoryInstrumentation::InstrumentedPointerBase::~InstrumentedPointerBase): (InstrumentedPointer): (WebCore::MemoryInstrumentation::InstrumentedPointer::InstrumentedPointer): (WebCore::MemoryInstrumentation::OwningTraits::addInstrumentedObject): (WebCore::MemoryInstrumentation::OwningTraits::addObject): (WebCore::MemoryInstrumentation::addInstrumentedObjectImpl): (WebCore::MemoryClassInfo::addInstrumentedMember): (WebCore::MemoryClassInfo::addMember): (WebCore): (WebCore::MemoryInstrumentation::addObjectImpl): (WebCore::MemoryInstrumentation::addInstrumentedCollection): (WebCore::MemoryInstrumentation::calculateContainerSize): * inspector/InspectorMemoryAgent.cpp: (WebCore): Modified Paths trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/Target.pri trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/bindings/v8/ScriptProfiler.cpp trunk/Source/WebCore/dom/MemoryInstrumentation.h trunk/Source/WebCore/inspector/InspectorMemoryAgent.cpp Added Paths trunk/Source/WebCore/dom/MemoryInstrumentation.cpp Diff Modified: trunk/Source/WebCore/CMakeLists.txt (124016 => 124017) --- trunk/Source/WebCore/CMakeLists.txt 2012-07-30 12:51:04 UTC (rev 124016) +++ trunk/Source/WebCore/CMakeLists.txt 2012-07-30 12:59:12 UTC (rev 124017) @@ -1105,6 +1105,7 @@ dom/IdTargetObserver.cpp dom/IdTargetObserverRegistry.cpp dom/KeyboardEvent.cpp +dom/MemoryInstrumentation.cpp dom/MessageChannel.cpp dom/MessageEvent.cpp dom/MessagePortChannel.cpp Modified: trunk/Source/WebCore/ChangeLog (124016 => 124017) --- trunk/Source/WebCore/ChangeLog 2012-07-30 12:51:04 UTC (rev 124016) +++ trunk/Source/WebCore/ChangeLog 2012-07-30 12:59:12 UTC (rev 124017) @@ -1,3 +1,47 @@ +2012-07-26 Yury Semikhatsky yu...@chromium.org + +Web Inspector: make MemoryInstrumentation methods private +https://bugs.webkit.org/show_bug.cgi?id=92379 + +Reviewed by Vsevolod Vlasov. + +MemoryInstrumentation was refactored. +- All reporting methods on MemoryInstrumentation except add*Object are + private to enforce MemoryClassInfo usage. +- MemoryInstrumentation::Add*Member methods renamed to Add*Object +- String reporting is implemented directly in the MemoryInstrumentation, + not in its descendants. + +* CMakeLists.txt: +* GNUmakefile.list.am: +* WebCore.gypi: +* WebCore.vcproj/WebCore.vcproj: +* WebCore.xcodeproj/project.pbxproj: +* bindings/v8/ScriptProfiler.cpp: +(WebCore::ScriptProfiler::collectBindingMemoryInfo): +* dom/MemoryInstrumentation.cpp: Added. +(WebCore): +(WebCore::MemoryInstrumentation::addString): +* dom/MemoryInstrumentation.h: +(WebCore::MemoryInstrumentation::addInstrumentedObject): +(WebCore::MemoryInstrumentation::addObject): +(MemoryInstrumentation): +(InstrumentedPointerBase): +(WebCore::MemoryInstrumentation::InstrumentedPointerBase::~InstrumentedPointerBase): +(InstrumentedPointer): +(WebCore::MemoryInstrumentation::InstrumentedPointer::InstrumentedPointer): +(WebCore::MemoryInstrumentation::OwningTraits::addInstrumentedObject): +(WebCore::MemoryInstrumentation::OwningTraits::addObject): +(WebCore::MemoryInstrumentation::addInstrumentedObjectImpl): +(WebCore::MemoryClassInfo::addInstrumentedMember): +(WebCore::MemoryClassInfo::addMember): +(WebCore): +(WebCore::MemoryInstrumentation::addObjectImpl): +(WebCore::MemoryInstrumentation::addInstrumentedCollection): +(WebCore::MemoryInstrumentation::calculateContainerSize): +*
[webkit-changes] [124018] trunk/LayoutTests
Title: [124018] trunk/LayoutTests Revision 124018 Author o...@webkit.org Date 2012-07-30 06:17:13 -0700 (Mon, 30 Jul 2012) Log Message [Qt][WK1] Gardening after r123988. It made fast/writing-mode/flipped-blocks-hit-test-line-edges.html fail https://bugs.webkit.org/show_bug.cgi?id=92636 Patch by János Badics jbad...@inf.u-szeged.hu on 2012-07-30 Reviewed by Csaba Osztrogonác. * platform/qt-4.8/Skipped: * platform/qt-5.0-wk1/Skipped: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-4.8/Skipped trunk/LayoutTests/platform/qt-5.0-wk1/Skipped Diff Modified: trunk/LayoutTests/ChangeLog (124017 => 124018) --- trunk/LayoutTests/ChangeLog 2012-07-30 12:59:12 UTC (rev 124017) +++ trunk/LayoutTests/ChangeLog 2012-07-30 13:17:13 UTC (rev 124018) @@ -1,3 +1,13 @@ +2012-07-30 János Badics jbad...@inf.u-szeged.hu + +[Qt][WK1] Gardening after r123988. It made fast/writing-mode/flipped-blocks-hit-test-line-edges.html fail +https://bugs.webkit.org/show_bug.cgi?id=92636 + +Reviewed by Csaba Osztrogonác. + +* platform/qt-4.8/Skipped: +* platform/qt-5.0-wk1/Skipped: + 2012-07-30 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r124000. Modified: trunk/LayoutTests/platform/qt-4.8/Skipped (124017 => 124018) --- trunk/LayoutTests/platform/qt-4.8/Skipped 2012-07-30 12:59:12 UTC (rev 124017) +++ trunk/LayoutTests/platform/qt-4.8/Skipped 2012-07-30 13:17:13 UTC (rev 124018) @@ -176,6 +176,10 @@ # https://bugs.webkit.org/show_bug.cgi?id=89426 fast/text/line-breaks-after-ideographic-comma-or-full-stop.html +# [Qt][WK1] REGRESSION(r123988) It made fast/writing-mode/flipped-blocks-hit-test-line-edges.html fail +# https://bugs.webkit.org/show_bug.cgi?id=92636 +fast/writing-mode/flipped-blocks-hit-test-line-edges.html + # [Qt] The test fonts used for Qt tests changed to the Liberation font family, # due to this we are skipping tons of tests. They will be unskipped in batches ASAP. # https://bugs.webkit.org/show_bug.cgi?id=85203 Modified: trunk/LayoutTests/platform/qt-5.0-wk1/Skipped (124017 => 124018) --- trunk/LayoutTests/platform/qt-5.0-wk1/Skipped 2012-07-30 12:59:12 UTC (rev 124017) +++ trunk/LayoutTests/platform/qt-5.0-wk1/Skipped 2012-07-30 13:17:13 UTC (rev 124018) @@ -139,3 +139,7 @@ svg/custom/glyph-selection-lang-attribute.svg svg/dom/css-transforms.xhtml touchadjustment/event-triggered-widgets.html + +# [Qt][WK1] REGRESSION(r123988) It made fast/writing-mode/flipped-blocks-hit-test-line-edges.html fail +# https://bugs.webkit.org/show_bug.cgi?id=92636 +fast/writing-mode/flipped-blocks-hit-test-line-edges.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124019] trunk/Source/WebCore
Title: [124019] trunk/Source/WebCore
Revision 124019
Author hay...@chromium.org
Date 2012-07-30 06:20:59 -0700 (Mon, 30 Jul 2012)
Log Message
Remove an useless member variable, m_shouldPreventDispatch, from EventDispatcher.
https://bugs.webkit.org/show_bug.cgi?id=92625
Reviewed by Hajime Morita.
EventDispatcher::m_shouldPreventDispatch does not have any effects. We can remove that.
No new tests, no behavior change.
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::EventDispatcher):
(WebCore::EventDispatcher::dispatchEvent):
* dom/EventDispatcher.h:
(EventDispatcher):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/dom/EventDispatcher.cpp
trunk/Source/WebCore/dom/EventDispatcher.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (124018 => 124019)
--- trunk/Source/WebCore/ChangeLog 2012-07-30 13:17:13 UTC (rev 124018)
+++ trunk/Source/WebCore/ChangeLog 2012-07-30 13:20:59 UTC (rev 124019)
@@ -1,3 +1,20 @@
+2012-07-30 Hayato Ito hay...@chromium.org
+
+Remove an useless member variable, m_shouldPreventDispatch, from EventDispatcher.
+https://bugs.webkit.org/show_bug.cgi?id=92625
+
+Reviewed by Hajime Morita.
+
+EventDispatcher::m_shouldPreventDispatch does not have any effects. We can remove that.
+
+No new tests, no behavior change.
+
+* dom/EventDispatcher.cpp:
+(WebCore::EventDispatcher::EventDispatcher):
+(WebCore::EventDispatcher::dispatchEvent):
+* dom/EventDispatcher.h:
+(EventDispatcher):
+
2012-07-26 Yury Semikhatsky yu...@chromium.org
Web Inspector: make MemoryInstrumentation methods private
Modified: trunk/Source/WebCore/dom/EventDispatcher.cpp (124018 => 124019)
--- trunk/Source/WebCore/dom/EventDispatcher.cpp 2012-07-30 13:17:13 UTC (rev 124018)
+++ trunk/Source/WebCore/dom/EventDispatcher.cpp 2012-07-30 13:20:59 UTC (rev 124019)
@@ -201,7 +201,6 @@
EventDispatcher::EventDispatcher(Node* node)
: m_node(node)
, m_ancestorsInitialized(false)
-, m_shouldPreventDispatch(false)
{
ASSERT(node);
m_view = node-document()-view();
@@ -254,7 +253,7 @@
// Give the target node a chance to do some work before DOM event handlers get a crack.
void* data = ""
-if (m_ancestors.isEmpty() || m_shouldPreventDispatch || event-propagationStopped())
+if (m_ancestors.isEmpty() || event-propagationStopped())
goto doneDispatching;
// Trigger capturing event handlers, starting at the top and working our way down.
Modified: trunk/Source/WebCore/dom/EventDispatcher.h (124018 => 124019)
--- trunk/Source/WebCore/dom/EventDispatcher.h 2012-07-30 13:17:13 UTC (rev 124018)
+++ trunk/Source/WebCore/dom/EventDispatcher.h 2012-07-30 13:20:59 UTC (rev 124019)
@@ -84,7 +84,6 @@
RefPtrNode m_node;
RefPtrFrameView m_view;
bool m_ancestorsInitialized;
-bool m_shouldPreventDispatch;
};
inline Node* EventDispatcher::node() const
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124020] trunk/Tools
Title: [124020] trunk/Tools Revision 124020 Author o...@webkit.org Date 2012-07-30 06:21:24 -0700 (Mon, 30 Jul 2012) Log Message [Qt][NRWT] REGRESSION(123729): Forcing pixel tests with -p doesn't work https://bugs.webkit.org/show_bug.cgi?id=92627 Patch by Balazs Kelemen kbal...@webkit.org on 2012-07-30 Reviewed by Noam Rosenthal. Remove the default behavior I added in r123729 so that we run all tests as pixel test with -p. It was intentional but it seems like we don't have consensus on that we want it. * Scripts/webkitpy/layout_tests/port/qt.py: (QtPort._supports_switching_pixel_tests_per_test): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py Diff Modified: trunk/Tools/ChangeLog (124019 => 124020) --- trunk/Tools/ChangeLog 2012-07-30 13:20:59 UTC (rev 124019) +++ trunk/Tools/ChangeLog 2012-07-30 13:21:24 UTC (rev 124020) @@ -1,3 +1,17 @@ +2012-07-30 Balazs Kelemen kbal...@webkit.org + +[Qt][NRWT] REGRESSION(123729): Forcing pixel tests with -p doesn't work +https://bugs.webkit.org/show_bug.cgi?id=92627 + +Reviewed by Noam Rosenthal. + +Remove the default behavior I added in r123729 so that we run all tests as pixel +test with -p. It was intentional but it seems like we don't have consensus on +that we want it. + +* Scripts/webkitpy/layout_tests/port/qt.py: +(QtPort._supports_switching_pixel_tests_per_test): + 2012-07-30 Mikhail Pozdnyakov mikhail.pozdnya...@intel.com [EFL][WTR] Enforce SHIFT modifier to upper case keys in event sender. Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py (124019 => 124020) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py 2012-07-30 13:20:59 UTC (rev 124019) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/qt.py 2012-07-30 13:21:24 UTC (rev 124020) @@ -187,10 +187,3 @@ def _supports_switching_pixel_tests_per_test(self): return True -def _should_run_as_pixel_test(self, test_input): -return any(test_input.test_name.startswith(directory) - for directory in QtPort._default_pixel_test_directories()) - -@staticmethod -def _default_pixel_test_directories(): -return ['compositing'] ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124021] trunk
Title: [124021] trunk Revision 124021 Author vse...@chromium.org Date 2012-07-30 06:29:41 -0700 (Mon, 30 Jul 2012) Log Message Web Inspector: Content size variables in NetworkResourcesData should have size_t type instead of int. https://bugs.webkit.org/show_bug.cgi?id=92618 Reviewed by Yury Semikhatsky. Source/WebCore: Changed content size variables type in NetworkResourcesData from int to size_t. Drive-by: Switched String length calculation to recently added StringImpl's sizeInBytes. * inspector/NetworkResourcesData.cpp: (WebCore::NetworkResourcesData::ResourceData::removeContent): (WebCore::NetworkResourcesData::ResourceData::dataLength): (WebCore::NetworkResourcesData::ResourceData::appendData): (WebCore::NetworkResourcesData::ResourceData::decodeDataToContent): (WebCore::NetworkResourcesData::setResourceContent): (WebCore::NetworkResourcesData::maybeAddResourceData): (WebCore::NetworkResourcesData::maybeDecodeDataToContent): (WebCore::NetworkResourcesData::setResourcesDataSizeLimits): (WebCore::NetworkResourcesData::ensureFreeSpace): * inspector/NetworkResourcesData.h: (ResourceData): (NetworkResourcesData): LayoutTests: * http/tests/inspector/network/network-content-replacement-embed-expected.txt: * http/tests/inspector/network/network-content-replacement-embed.html: * http/tests/inspector/network/network-content-replacement-xhr-expected.txt: * http/tests/inspector/network/network-content-replacement-xhr.html: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/http/tests/inspector/network/network-content-replacement-embed-expected.txt trunk/LayoutTests/http/tests/inspector/network/network-content-replacement-embed.html trunk/LayoutTests/http/tests/inspector/network/network-content-replacement-xhr-expected.txt trunk/LayoutTests/http/tests/inspector/network/network-content-replacement-xhr.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/inspector/NetworkResourcesData.cpp trunk/Source/WebCore/inspector/NetworkResourcesData.h Diff Modified: trunk/LayoutTests/ChangeLog (124020 => 124021) --- trunk/LayoutTests/ChangeLog 2012-07-30 13:21:24 UTC (rev 124020) +++ trunk/LayoutTests/ChangeLog 2012-07-30 13:29:41 UTC (rev 124021) @@ -1,3 +1,15 @@ +2012-07-30 Vsevolod Vlasov vse...@chromium.org + +Web Inspector: Content size variables in NetworkResourcesData should have size_t type instead of int. +https://bugs.webkit.org/show_bug.cgi?id=92618 + +Reviewed by Yury Semikhatsky. + +* http/tests/inspector/network/network-content-replacement-embed-expected.txt: +* http/tests/inspector/network/network-content-replacement-embed.html: +* http/tests/inspector/network/network-content-replacement-xhr-expected.txt: +* http/tests/inspector/network/network-content-replacement-xhr.html: + 2012-07-30 János Badics jbad...@inf.u-szeged.hu [Qt][WK1] Gardening after r123988. It made fast/writing-mode/flipped-blocks-hit-test-line-edges.html fail Modified: trunk/LayoutTests/http/tests/inspector/network/network-content-replacement-embed-expected.txt (124020 => 124021) --- trunk/LayoutTests/http/tests/inspector/network/network-content-replacement-embed-expected.txt 2012-07-30 13:21:24 UTC (rev 124020) +++ trunk/LayoutTests/http/tests/inspector/network/network-content-replacement-embed-expected.txt 2012-07-30 13:29:41 UTC (rev 124021) @@ -1,4 +1,4 @@ -CONSOLE MESSAGE: line 60: Done. +CONSOLE MESSAGE: line 58: Done. Tests NetworkResourcesData logic for embed content replacement. Modified: trunk/LayoutTests/http/tests/inspector/network/network-content-replacement-embed.html (124020 => 124021) --- trunk/LayoutTests/http/tests/inspector/network/network-content-replacement-embed.html 2012-07-30 13:21:24 UTC (rev 124020) +++ trunk/LayoutTests/http/tests/inspector/network/network-content-replacement-embed.html 2012-07-30 13:29:41 UTC (rev 124021) @@ -29,9 +29,7 @@ console.log(This test can not be run as window.internals is not available.); return; } -// Each '*' symbol in original data will use two bytes in String object -// after decoding, hence multiplying by two. -internals.settings.setInspectorResourcesDataSizeLimits(2*300, 2*200); +internals.settings.setInspectorResourcesDataSizeLimits(300, 200); // Here we test replacement logic. We save first two resources content, // discard third resource content once we see its size exceeds limit, Modified: trunk/LayoutTests/http/tests/inspector/network/network-content-replacement-xhr-expected.txt (124020 => 124021) --- trunk/LayoutTests/http/tests/inspector/network/network-content-replacement-xhr-expected.txt 2012-07-30 13:21:24 UTC (rev 124020) +++ trunk/LayoutTests/http/tests/inspector/network/network-content-replacement-xhr-expected.txt 2012-07-30 13:29:41 UTC (rev 124021) @@ -1,4 +1,4 @@ -CONSOLE MESSAGE: line 39: Done. +CONSOLE MESSAGE: line 38: Done. Tests NetworkResourcesData logic for XHR content replacement.
[webkit-changes] [124023] trunk
Title: [124023] trunk Revision 124023 Author allan.jen...@nokia.com Date 2012-07-30 07:11:32 -0700 (Mon, 30 Jul 2012) Log Message Source/WebCore: There is no way to tell whether an element can be activated or not https://bugs.webkit.org/show_bug.cgi?id=92093 Reviewed by Antonio Gomes. This patch adds the willRespondToMouseClickEvents and willRespondToMouseMoveEvents functions, named after similar functions in the iOS fork of WebKit. Touch-adjustment will now use these two functions, which improves accuracy when targeting shadow-dom elements, and also means touch adjustment will prefer enabled form-elements over disabled ones. Test: touchadjustment/disabled-formelements.html * dom/Node.cpp: (WebCore::Node::willRespondToMouseMoveEvents): (WebCore::Node::willRespondToMouseClickEvents): * dom/Node.h: (Node): * editing/DeleteButton.h: * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::willRespondToMouseClickEvents): * html/HTMLAnchorElement.h: (HTMLAnchorElement): * html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::willRespondToMouseClickEvents): * html/HTMLButtonElement.h: (HTMLButtonElement): * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::willRespondToMouseClickEvents): * html/HTMLInputElement.h: (HTMLInputElement): * html/HTMLLabelElement.cpp: (WebCore::HTMLLabelElement::willRespondToMouseClickEvents): * html/HTMLLabelElement.h: (HTMLLabelElement): * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::willRespondToMouseClickEvents): * html/HTMLMediaElement.h: * html/HTMLSummaryElement.cpp: (WebCore::HTMLSummaryElement::willRespondToMouseClickEvents): * html/HTMLSummaryElement.h: (HTMLSummaryElement): * html/shadow/CalendarPickerElement.cpp: (WebCore::CalendarPickerElement::willRespondToMouseClickEvents): * html/shadow/CalendarPickerElement.h: (CalendarPickerElement): * html/shadow/MediaControlElements.cpp: (WebCore::MediaControlTimelineElement::willRespondToMouseClickEvents): (WebCore::MediaControlTimelineElement::setPosition): (WebCore::MediaControlVolumeSliderElement::willRespondToMouseMoveEvents): (WebCore::MediaControlVolumeSliderElement::willRespondToMouseClickEvents): * html/shadow/MediaControlElements.h: (MediaControlTimelineElement): (MediaControlVolumeSliderElement): * html/shadow/MediaControlRootElement.h: * html/shadow/SliderThumbElement.cpp: (WebCore::SliderThumbElement::willRespondToMouseMoveEvents): (WebCore::SliderThumbElement::willRespondToMouseClickEvents): * html/shadow/SliderThumbElement.h: (SliderThumbElement): * html/shadow/TextControlInnerElements.cpp: (WebCore::SearchFieldResultsButtonElement::willRespondToMouseClickEvents): (WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents): (WebCore::SpinButtonElement::willRespondToMouseMoveEvents): (WebCore::SpinButtonElement::willRespondToMouseClickEvents): (WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents): * html/shadow/TextControlInnerElements.h: (SearchFieldResultsButtonElement): (SearchFieldCancelButtonElement): (SpinButtonElement): * html/shadow/TextFieldDecorationElement.cpp: (WebCore::TextFieldDecorationElement::willRespondToMouseClickEvents): * html/shadow/TextFieldDecorationElement.h: (TextFieldDecorationElement): * page/TouchAdjustment.cpp: (WebCore::TouchAdjustment::nodeRespondsToTapGesture): Source/WebKit/gtk: [Gtk] Add WK1 API for snapshot retrieval https://bugs.webkit.org/show_bug.cgi?id=92261 Reviewed by Martin Robinson. Add API to WebKitWebView to retrieve a snapshot of its visible contents as a cairo_surface_t. * docs/webkitgtk-sections.txt: Add new symbols. * webkit/webkitwebview.cpp: (webkit_web_view_get_snapshot): New method to paint a webview snapshot. * webkit/webkitwebview.h: Ditto. LayoutTests: There is no way to tell whether an element can be activated or not https://bugs.webkit.org/show_bug.cgi?id=92093 Reviewed by Antonio Gomes. Tests that enabled formelements are now preferred over disabled formelements. * touchadjustment/disabled-formelements-expected.txt: Added. * touchadjustment/disabled-formelements.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/ChangeLog trunk/Source/WebKit/gtk/ChangeLog trunk/Source/WebKit/gtk/docs/webkitgtk-sections.txt trunk/Source/WebKit/gtk/webkit/webkitwebview.cpp trunk/Source/WebKit/gtk/webkit/webkitwebview.h Diff Modified: trunk/LayoutTests/ChangeLog (124022 => 124023) --- trunk/LayoutTests/ChangeLog 2012-07-30 13:33:14 UTC (rev 124022) +++ trunk/LayoutTests/ChangeLog 2012-07-30 14:11:32 UTC (rev 124023) @@ -32,6 +32,16 @@ * platform/qt-4.8/Skipped: * platform/qt-5.0-wk1/Skipped: +2012-07-30 János Badics jbad...@inf.u-szeged.hu + +[Qt][WK1] Gardening after r123988. It made fast/writing-mode/flipped-blocks-hit-test-line-edges.html fail +https://bugs.webkit.org/show_bug.cgi?id=92636 + +Reviewed by Csaba Osztrogonác. + +* platform/qt-4.8/Skipped: +* platform/qt-5.0-wk1/Skipped: + 2012-07-30 Sheriff
[webkit-changes] [124024] trunk/Source/WebCore
Title: [124024] trunk/Source/WebCore
Revision 124024
Author allan.jen...@nokia.com
Date 2012-07-30 07:23:13 -0700 (Mon, 30 Jul 2012)
Log Message
Wheel events on a page with frames are not handled in fixed layout
https://bugs.webkit.org/show_bug.cgi?id=90550
Reviewed by Antonio Gomes.
Based on patch by Andras Becsi.
Frame-rect size is not the right value to check against to see if the document
can be contained within the full visible content rect, since it does not handle
fixedVisibleContentRect. Instead visibleContentRect(true) should be used which
returns the full visible content rect disregarding scrollbars, and which is
the same a frame-rect size when fixedVisibleContentRect is not set.
* platform/ScrollView.cpp:
(WebCore::ScrollView::updateScrollbars):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/ScrollView.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (124023 => 124024)
--- trunk/Source/WebCore/ChangeLog 2012-07-30 14:11:32 UTC (rev 124023)
+++ trunk/Source/WebCore/ChangeLog 2012-07-30 14:23:13 UTC (rev 124024)
@@ -1,5 +1,23 @@
2012-07-30 Allan Sandfeld Jensen allan.jen...@nokia.com
+Wheel events on a page with frames are not handled in fixed layout
+https://bugs.webkit.org/show_bug.cgi?id=90550
+
+Reviewed by Antonio Gomes.
+
+Based on patch by Andras Becsi.
+
+Frame-rect size is not the right value to check against to see if the document
+can be contained within the full visible content rect, since it does not handle
+fixedVisibleContentRect. Instead visibleContentRect(true) should be used which
+returns the full visible content rect disregarding scrollbars, and which is
+the same a frame-rect size when fixedVisibleContentRect is not set.
+
+* platform/ScrollView.cpp:
+(WebCore::ScrollView::updateScrollbars):
+
+2012-07-30 Allan Sandfeld Jensen allan.jen...@nokia.com
+
There is no way to tell whether an element can be activated or not
https://bugs.webkit.org/show_bug.cgi?id=92093
Modified: trunk/Source/WebCore/platform/ScrollView.cpp (124023 => 124024)
--- trunk/Source/WebCore/platform/ScrollView.cpp 2012-07-30 14:11:32 UTC (rev 124023)
+++ trunk/Source/WebCore/platform/ScrollView.cpp 2012-07-30 14:23:13 UTC (rev 124024)
@@ -501,16 +501,16 @@
bool sendContentResizedNotification = false;
IntSize docSize = contentsSize();
-IntSize frameSize = frameRect().size();
+IntSize fullVisibleSize = visibleContentRect(true /*includeScrollbars*/).size();
if (hScroll == ScrollbarAuto) {
newHasHorizontalScrollbar = docSize.width() visibleWidth();
-if (newHasHorizontalScrollbar !m_updateScrollbarsPass docSize.width() = frameSize.width() docSize.height() = frameSize.height())
+if (newHasHorizontalScrollbar !m_updateScrollbarsPass docSize.width() = fullVisibleSize.width() docSize.height() = fullVisibleSize.height())
newHasHorizontalScrollbar = false;
}
if (vScroll == ScrollbarAuto) {
newHasVerticalScrollbar = docSize.height() visibleHeight();
-if (newHasVerticalScrollbar !m_updateScrollbarsPass docSize.width() = frameSize.width() docSize.height() = frameSize.height())
+if (newHasVerticalScrollbar !m_updateScrollbarsPass docSize.width() = fullVisibleSize.width() docSize.height() = fullVisibleSize.height())
newHasVerticalScrollbar = false;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124026] trunk/Source/WebCore
Title: [124026] trunk/Source/WebCore
Revision 124026
Author pfeld...@chromium.org
Date 2012-07-30 08:12:23 -0700 (Mon, 30 Jul 2012)
Log Message
Web Inspector: support --line-numbers mapping for SASS
https://bugs.webkit.org/show_bug.cgi?id=92400
Reviewed by Vsevolod Vlasov.
There is --debug-info and --line-numbers ways of referencing the source scss file, adding support for --line-numbers here.
* inspector/front-end/SASSSourceMapping.js:
(WebInspector.SASSSourceMapping.prototype._resourceAdded.didRequestContent):
(WebInspector.SASSSourceMapping.prototype._resourceAdded):
(_bindUISourceCode):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/inspector/front-end/SASSSourceMapping.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (124025 => 124026)
--- trunk/Source/WebCore/ChangeLog 2012-07-30 14:32:16 UTC (rev 124025)
+++ trunk/Source/WebCore/ChangeLog 2012-07-30 15:12:23 UTC (rev 124026)
@@ -1,3 +1,17 @@
+2012-07-30 Pavel Feldman pfeld...@chromium.org
+
+Web Inspector: support --line-numbers mapping for SASS
+https://bugs.webkit.org/show_bug.cgi?id=92400
+
+Reviewed by Vsevolod Vlasov.
+
+There is --debug-info and --line-numbers ways of referencing the source scss file, adding support for --line-numbers here.
+
+* inspector/front-end/SASSSourceMapping.js:
+(WebInspector.SASSSourceMapping.prototype._resourceAdded.didRequestContent):
+(WebInspector.SASSSourceMapping.prototype._resourceAdded):
+(_bindUISourceCode):
+
2012-07-30 Keishi Hattori kei...@webkit.org
Implement datalist UI for input type color for Chromium
Modified: trunk/Source/WebCore/inspector/front-end/SASSSourceMapping.js (124025 => 124026)
--- trunk/Source/WebCore/inspector/front-end/SASSSourceMapping.js 2012-07-30 14:32:16 UTC (rev 124025)
+++ trunk/Source/WebCore/inspector/front-end/SASSSourceMapping.js 2012-07-30 15:12:23 UTC (rev 124026)
@@ -80,29 +80,54 @@
if (!content)
return;
var lines = content.split(/\r?\n/);
-var regex = /@media\s\-sass\-debug\-info{filename{font-family:([^}]+)}line{font-family:\\[0]+([^}]*)}}/i;
+var debugInfoRegex = /@media\s\-sass\-debug\-info{filename{font-family:([^}]+)}line{font-family:\\[0]+([^}]*)}}/i;
+var lineNumbersRegex = /\/\*\s+line\s+([0-9]+),\s+([^*\/]+)/;
for (var lineNumber = 0; lineNumber lines.length; ++lineNumber) {
-var match = regex.exec(lines[lineNumber]);
-if (!match)
+var match = debugInfoRegex.exec(lines[lineNumber]);
+if (match) {
+var url = "" $1);
+var line = parseInt(decodeURI(match[2].replace(/(..)/g, %$1)), 10);
+this._bindUISourceCode(url, line, resource.url, lineNumber);
continue;
-var url = "" $1);
-var uiSourceCode = this._uiSourceCodeForURL[url];
-if (!uiSourceCode) {
-uiSourceCode = new WebInspector.SASSSource(url);
-this._uiSourceCodeForURL[url] = uiSourceCode;
-this._uiSourceCodes.push(uiSourceCode);
-this.dispatchEventToListeners(WebInspector.UISourceCodeProvider.Events.UISourceCodeAdded, uiSourceCode);
-WebInspector.cssModel.setSourceMapping(resource.url, this);
}
-var line = parseInt(decodeURI(match[2].replace(/(..)/g, %$1)), 10) - 1;
-var rawLocationString = resource.url + : + (lineNumber + 1);
-this._uiLocations[rawLocationString] = new WebInspector.UILocation(uiSourceCode, line, 0);
+match = lineNumbersRegex.exec(lines[lineNumber]);
+if (match) {
+var fileName = match[2].trim();
+var line = parseInt(match[1], 10);
+var url = ""
+if (url.endsWith(/ + resource.parsedURL.lastPathComponent))
+url = "" url.length - resource.parsedURL.lastPathComponent.length) + fileName;
+else
+url = ""
+this._bindUISourceCode(url, line, resource.url, lineNumber);
+continue;
+}
}
}
resource.requestContent(didRequestContent.bind(this));
},
/**
+ * @param {string} url
+ * @param {number} line
+ * @param {string} rawURL
+ * @param {number} rawLine
+ */
+_bindUISourceCode: function(url, line, rawURL, rawLine)
+{
+var uiSourceCode = this._uiSourceCodeForURL[url];
+if (!uiSourceCode) {
+uiSourceCode = new WebInspector.SASSSource(url);
+this._uiSourceCodeForURL[url] = uiSourceCode;
+this._uiSourceCodes.push(uiSourceCode);
+
[webkit-changes] [124027] trunk
Title: [124027] trunk Revision 124027 Author shin...@chromium.org Date 2012-07-30 08:16:24 -0700 (Mon, 30 Jul 2012) Log Message Prohibit having AuthorShadowDOM of input or textarea element for a while and having a flag to enable it in Internals. https://bugs.webkit.org/show_bug.cgi?id=92611 Reviewed by Hajime Morita. .: * Source/autotools/symbols.filter: Source/WebCore: Prohibit having AuthorShadowDOM of input elemnet unless a flag in RuntimeEnabledFeatures is not enabled. The flag can be enabled in Internals. The elements in UserAgentShadowDOM of input element assume that they have a renderer when the input element has a renderer. However, this does not hold when AuthorShadowDOM is added to input element. So until we fix the issue, we should disable to have AuthorShadowDOM for input element, because it may cause crashes and security problems. Tests: fast/dom/shadow/input-with-validation-without-shadow.html fast/dom/shadow/input-with-validation.html fast/dom/shadow/shadow-disable.html * bindings/generic/RuntimeEnabledFeatures.cpp: (WebCore): * bindings/generic/RuntimeEnabledFeatures.h: (RuntimeEnabledFeatures): (WebCore::RuntimeEnabledFeatures::authorShadowDOMForAnyElementEnabled): (WebCore::RuntimeEnabledFeatures::setAuthorShadowDOMForAnyElementEnabled): * dom/ShadowRoot.cpp: (WebCore::allowsAuthorShadowRoot): The input element or textarea element does not allow to have a ShadowDOM unless is a flag in RuntimeEnabledFeatures is not enabled. * html/HTMLInputElement.h: (WebCore::isHTMLInputElement): (WebCore): * html/HTMLTextAreaElement.h: (WebCore::isHTMLTextAreaElement): (WebCore): * testing/Internals.cpp: (WebCore::Internals::setAuthorShadowDOMForAnyElementEnabled): (WebCore): * testing/Internals.h: (Internals): * testing/Internals.idl: LayoutTests: * fast/dom/shadow/input-with-validation-without-shadow.html: Make the test runs even if new WebKitShadowRoot() throws an exception. * fast/dom/shadow/input-with-validation.html: Sets a flag to make AuthorShadowDOM available. * fast/dom/shadow/shadow-disable-expected.txt: * fast/dom/shadow/shadow-disable.html: Makes it unavailable for input and textarea to have an AuthorShadowDOM. Modified Paths trunk/ChangeLog trunk/LayoutTests/ChangeLog trunk/LayoutTests/fast/dom/shadow/input-with-validation-without-shadow.html trunk/LayoutTests/fast/dom/shadow/input-with-validation.html trunk/LayoutTests/fast/dom/shadow/shadow-disable-expected.txt trunk/LayoutTests/fast/dom/shadow/shadow-disable.html trunk/LayoutTests/fast/dom/shadow/shadowdom-for-form-associated-element-useragent-expected.txt trunk/LayoutTests/fast/dom/shadow/shadowdom-for-form-associated-element-useragent.html trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h trunk/Source/WebCore/dom/ShadowRoot.cpp trunk/Source/WebCore/html/HTMLInputElement.h trunk/Source/WebCore/html/HTMLTextAreaElement.h trunk/Source/WebCore/testing/Internals.cpp trunk/Source/WebCore/testing/Internals.h trunk/Source/WebCore/testing/Internals.idl trunk/Source/autotools/symbols.filter Diff Modified: trunk/ChangeLog (124026 => 124027) --- trunk/ChangeLog 2012-07-30 15:12:23 UTC (rev 124026) +++ trunk/ChangeLog 2012-07-30 15:16:24 UTC (rev 124027) @@ -1,3 +1,12 @@ +2012-07-30 Shinya Kawanaka shin...@chromium.org + +Prohibit having AuthorShadowDOM of input or textarea element for a while and having a flag to enable it in Internals. +https://bugs.webkit.org/show_bug.cgi?id=92611 + +Reviewed by Hajime Morita. + +* Source/autotools/symbols.filter: + 2012-07-30 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r124000. Modified: trunk/LayoutTests/ChangeLog (124026 => 124027) --- trunk/LayoutTests/ChangeLog 2012-07-30 15:12:23 UTC (rev 124026) +++ trunk/LayoutTests/ChangeLog 2012-07-30 15:16:24 UTC (rev 124027) @@ -1,3 +1,16 @@ +2012-07-30 Shinya Kawanaka shin...@chromium.org + +Prohibit having AuthorShadowDOM of input or textarea element for a while and having a flag to enable it in Internals. +https://bugs.webkit.org/show_bug.cgi?id=92611 + +Reviewed by Hajime Morita. + +* fast/dom/shadow/input-with-validation-without-shadow.html: Make the test runs even if +new WebKitShadowRoot() throws an exception. +* fast/dom/shadow/input-with-validation.html: Sets a flag to make AuthorShadowDOM available. +* fast/dom/shadow/shadow-disable-expected.txt: +* fast/dom/shadow/shadow-disable.html: Makes it unavailable for input and textarea to have an AuthorShadowDOM. + 2012-07-30 Keishi Hattori kei...@webkit.org Implement datalist UI for input type color for Chromium Modified: trunk/LayoutTests/fast/dom/shadow/input-with-validation-without-shadow.html (124026 => 124027) --- trunk/LayoutTests/fast/dom/shadow/input-with-validation-without-shadow.html 2012-07-30 15:12:23
[webkit-changes] [124028] trunk/LayoutTests
Title: [124028] trunk/LayoutTests Revision 124028 Author commit-qu...@webkit.org Date 2012-07-30 08:39:04 -0700 (Mon, 30 Jul 2012) Log Message [EFL] Skip new compositing tests for EFL port https://bugs.webkit.org/show_bug.cgi?id=92633 Unreviewed EFL gardening. Skip new compositing layout tests until accelerated compositing is enabled. Patch by Alexander Shalamov alexander.shala...@intel.com on 2012-07-30 * platform/efl/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (124027 => 124028) --- trunk/LayoutTests/ChangeLog 2012-07-30 15:16:24 UTC (rev 124027) +++ trunk/LayoutTests/ChangeLog 2012-07-30 15:39:04 UTC (rev 124028) @@ -1,3 +1,14 @@ +2012-07-30 Alexander Shalamov alexander.shala...@intel.com + +[EFL] Skip new compositing tests for EFL port +https://bugs.webkit.org/show_bug.cgi?id=92633 + +Unreviewed EFL gardening. + +Skip new compositing layout tests until accelerated compositing is enabled. + +* platform/efl/TestExpectations: + 2012-07-30 Shinya Kawanaka shin...@chromium.org Prohibit having AuthorShadowDOM of input or textarea element for a while and having a flag to enable it in Internals. Modified: trunk/LayoutTests/platform/efl/TestExpectations (124027 => 124028) --- trunk/LayoutTests/platform/efl/TestExpectations 2012-07-30 15:16:24 UTC (rev 124027) +++ trunk/LayoutTests/platform/efl/TestExpectations 2012-07-30 15:39:04 UTC (rev 124028) @@ -477,6 +477,10 @@ BUGWK82294 : compositing/visibility/visibility-image-layers-dynamic.html = TEXT BUGWK82294 : compositing/layer-creation/no-compositing-for-preserve-3d.html = TEXT BUGWK82294 : compositing/columns/composited-in-paginated.html = TEXT +BUGWK82294 : compositing/geometry/bounds-ignores-hidden-composited-descendant.html +BUGWK82294 : compositing/geometry/bounds-ignores-hidden-dynamic-negzindex.html +BUGWK82294 : compositing/geometry/bounds-ignores-hidden-dynamic.html +BUGWK82294 : compositing/geometry/bounds-ignores-hidden.html // EFL's LayoutTestController does not implement displayInvalidatedRegion BUGWK86727 : compositing/plugins/invalidate_rect.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124029] trunk/LayoutTests
Title: [124029] trunk/LayoutTests Revision 124029 Author o...@webkit.org Date 2012-07-30 08:43:02 -0700 (Mon, 30 Jul 2012) Log Message [Qt] Default sizes for input-text and text-area are different when running DRT/WTR https://bugs.webkit.org/show_bug.cgi?id=91990 Unreviewed gardening. * platform/qt-5.0-wk2/Skipped: Skip tests. * platform/qt-5.0/Skipped: Unskip accidentally skipped tests. * platform/qt.5-0/fast/text/whitespace/028-expected.png: Remove accidentally committed file. * platform/qt.5-0/fast/text/whitespace/028-expected.txt: Remove accidentally committed file. * platform/qt/Skipped: Unskip non-existing tests. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped trunk/LayoutTests/platform/qt-5.0/Skipped trunk/LayoutTests/platform/qt-5.0-wk2/Skipped Removed Paths trunk/LayoutTests/platform/qt.5-0/fast/text/whitespace/028-expected.png trunk/LayoutTests/platform/qt.5-0/fast/text/whitespace/028-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (124028 => 124029) --- trunk/LayoutTests/ChangeLog 2012-07-30 15:39:04 UTC (rev 124028) +++ trunk/LayoutTests/ChangeLog 2012-07-30 15:43:02 UTC (rev 124029) @@ -1,3 +1,16 @@ +2012-07-30 Csaba Osztrogonác o...@webkit.org + +[Qt] Default sizes for input-text and text-area are different when running DRT/WTR +https://bugs.webkit.org/show_bug.cgi?id=91990 + +Unreviewed gardening. + +* platform/qt-5.0-wk2/Skipped: Skip tests. +* platform/qt-5.0/Skipped: Unskip accidentally skipped tests. +* platform/qt.5-0/fast/text/whitespace/028-expected.png: Remove accidentally committed file. +* platform/qt.5-0/fast/text/whitespace/028-expected.txt: Remove accidentally committed file. +* platform/qt/Skipped: Unskip non-existing tests. + 2012-07-30 Alexander Shalamov alexander.shala...@intel.com [EFL] Skip new compositing tests for EFL port Modified: trunk/LayoutTests/platform/qt/Skipped (124028 => 124029) --- trunk/LayoutTests/platform/qt/Skipped 2012-07-30 15:39:04 UTC (rev 124028) +++ trunk/LayoutTests/platform/qt/Skipped 2012-07-30 15:43:02 UTC (rev 124029) @@ -281,7 +281,6 @@ # CSS Exclusions support not yet enabled. http://webkit.org/b/57311 fast/exclusions -inspector/styles/protocol-getNamedFlowCollection-command.html # USE(V8) @@ -741,8 +740,6 @@ # https://bugs.webkit.org/show_bug.cgi?id=91218 http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist_in_object.html http/tests/w3c/webperf/approved/navigation-timing/html/test_timing_xserver_redirect.html -http/tests/w3c/webperf/approved/navigation-timing/html5/test_performance_attributes_exist_in_object.html -http/tests/w3c/webperf/approved/navigation-timing/html5/test_timing_xserver_redirect.html # === # # Failing xmlhttprequest tests # Modified: trunk/LayoutTests/platform/qt-5.0/Skipped (124028 => 124029) --- trunk/LayoutTests/platform/qt-5.0/Skipped 2012-07-30 15:39:04 UTC (rev 124028) +++ trunk/LayoutTests/platform/qt-5.0/Skipped 2012-07-30 15:43:02 UTC (rev 124029) @@ -1,4 +1,4 @@ -Fede# Still failing tests after refactored Qt5 and after WEBKIT_TESTFONTS fix. +# Still failing tests after refactored Qt5 and after WEBKIT_TESTFONTS fix. fast/dom/Window/Plug-ins.html fast/frames/sandboxed-iframe-about-blank.html fast/frames/sandboxed-iframe-navigation-allowed.html @@ -84,9 +84,6 @@ fast/replaced/object-with-embed-url-param.html http/tests/inspector/network/network-content-replacement-embed.html http/tests/inspector/network/network-embed.html -http/tests/security/contentSecurityPolicy/object-src-no-url-blocked.html -http/tests/security/contentSecurityPolicy/object-src-none-allowed.html -http/tests/security/contentSecurityPolicy/object-src-none-blocked.html http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html # [Qt] New fast/text/line-breaks-after-ideographic-comma-or-full-stop-2.html introduced in r120624 fails on ICU platforms Modified: trunk/LayoutTests/platform/qt-5.0-wk2/Skipped (124028 => 124029) --- trunk/LayoutTests/platform/qt-5.0-wk2/Skipped 2012-07-30 15:39:04 UTC (rev 124028) +++ trunk/LayoutTests/platform/qt-5.0-wk2/Skipped 2012-07-30 15:43:02 UTC (rev 124029) @@ -524,8 +524,23 @@ fast/text/textIteratorNilRenderer.html tables/mozilla_expected_failures/bugs/bug92647-1.html svg/hixie/mixed/003.xml +tables/mozilla/bugs/bug1188.html +tables/mozilla/bugs/bug18359.html +tables/mozilla/bugs/bug24200.html +tables/mozilla/bugs/bug2479-3.html +tables/mozilla/bugs/bug28928.html +tables/mozilla/bugs/bug30559.html +tables/mozilla/bugs/bug4382.html +tables/mozilla/bugs/bug4527.html +tables/mozilla/bugs/bug46368-1.html +tables/mozilla/bugs/bug46368-2.html +tables/mozilla/bugs/bug51037.html +tables/mozilla/bugs/bug55545.html +tables/mozilla/bugs/bug59354.html +tables/mozilla/bugs/bug96334.html
[webkit-changes] [124030] trunk/LayoutTests
Title: [124030] trunk/LayoutTests Revision 124030 Author o...@webkit.org Date 2012-07-30 08:47:33 -0700 (Mon, 30 Jul 2012) Log Message [Qt] Gardening. Skip failing tests and add a Qt specific expected file. Patch by Zoltan Arvai zar...@inf.u-szeged.hu on 2012-07-30 Reviewed by Csaba Osztrogonác. * platform/qt-4.8/Skipped: Skip svg/custom/svg-features.html. * platform/qt/Skipped: Skip http/tests/security/contentSecurityPolicy/object-src-none-blocked.html. * platform/qt/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt: Added because of a whitespace difference. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt/Skipped trunk/LayoutTests/platform/qt-4.8/Skipped Added Paths trunk/LayoutTests/platform/qt/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (124029 => 124030) --- trunk/LayoutTests/ChangeLog 2012-07-30 15:43:02 UTC (rev 124029) +++ trunk/LayoutTests/ChangeLog 2012-07-30 15:47:33 UTC (rev 124030) @@ -1,3 +1,13 @@ +2012-07-30 Zoltan Arvai zar...@inf.u-szeged.hu + +[Qt] Gardening. Skip failing tests and add a Qt specific expected file. + +Reviewed by Csaba Osztrogonác. + +* platform/qt-4.8/Skipped: Skip svg/custom/svg-features.html. +* platform/qt/Skipped: Skip http/tests/security/contentSecurityPolicy/object-src-none-blocked.html. +* platform/qt/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt: Added because of a whitespace difference. + 2012-07-30 Csaba Osztrogonác o...@webkit.org [Qt] Default sizes for input-text and text-area are different when running DRT/WTR Modified: trunk/LayoutTests/platform/qt/Skipped (124029 => 124030) --- trunk/LayoutTests/platform/qt/Skipped 2012-07-30 15:43:02 UTC (rev 124029) +++ trunk/LayoutTests/platform/qt/Skipped 2012-07-30 15:47:33 UTC (rev 124030) @@ -2675,3 +2675,7 @@ # This test depends on subpixel layout. # https://bugs.webkit.org/show_bug.cgi?id=92352 css3/flexbox/flex-rounding.html + +# [Qt] REGRESSION http/tests/security/contentSecurityPolicy/object-src-none-blocked.html fails after r123978 +# https://bugs.webkit.org/show_bug.cgi?id=92649 +http/tests/security/contentSecurityPolicy/object-src-none-blocked.html Added: trunk/LayoutTests/platform/qt/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt (0 => 124030) --- trunk/LayoutTests/platform/qt/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt (rev 0) +++ trunk/LayoutTests/platform/qt/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt 2012-07-30 15:47:33 UTC (rev 124030) @@ -0,0 +1,3 @@ +CONSOLE MESSAGE: Unsafe _javascript_ attempt to access frame with URL http://localhost:8080/security/resources/innocent-victim.html from frame with URL about:blank. Domains, protocols and ports must match. + +This test passes if it doesn't alert the contents of innocent-victim.html. Modified: trunk/LayoutTests/platform/qt-4.8/Skipped (124029 => 124030) --- trunk/LayoutTests/platform/qt-4.8/Skipped 2012-07-30 15:43:02 UTC (rev 124029) +++ trunk/LayoutTests/platform/qt-4.8/Skipped 2012-07-30 15:47:33 UTC (rev 124030) @@ -595,3 +595,7 @@ http/tests/misc/acid3.html fast/css/tab-size.html fast/text/international/bdi-dir-default-to-auto.html + +# [Qt] svg/custom/svg-features.html fails on Qt 4.8 +# https://bugs.webkit.org/show_bug.cgi?id=92645 +svg/custom/svg-features.html ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124034] trunk/Source/WebCore
Title: [124034] trunk/Source/WebCore
Revision 124034
Author commit-qu...@webkit.org
Date 2012-07-30 09:32:57 -0700 (Mon, 30 Jul 2012)
Log Message
https://bugs.webkit.org/show_bug.cgi?id=92642
[Bindings]Remove custom JS/V8 bindings for WebSocket::close() using [Clamp]
Patch by Vineet Chaudhary rgf...@motorola.com on 2012-07-30
Reviewed by Kentaro Hara.
With support of [Clamp] as extended attribute we can replace custom bindings from WebSocket::close().
Spec for WebSocket::close() : http://www.whatwg.org/specs/web-apps/current-work/multipage/network.html#websocket
No new tests. There should be no behavioural changes
Existing tests under http/websocket/tests/hybi/ should cover this.
* Modules/websockets/WebSocket.h:
(WebCore::WebSocket::close):
* Modules/websockets/WebSocket.idl: Used [Clamp].
* bindings/js/JSWebSocketCustom.cpp: Removed custom call close().
(WebCore):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionClassMethodWithClamp):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::classMethodWithClampCallback):
* bindings/v8/custom/V8WebSocketCustom.cpp: Removed custom call close().
(WebCore):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/websockets/WebSocket.h
trunk/Source/WebCore/Modules/websockets/WebSocket.idl
trunk/Source/WebCore/bindings/js/JSWebSocketCustom.cpp
trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm
trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm
trunk/Source/WebCore/bindings/scripts/test/JS/JSTestObj.cpp
trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp
trunk/Source/WebCore/bindings/v8/custom/V8WebSocketCustom.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (124033 => 124034)
--- trunk/Source/WebCore/ChangeLog 2012-07-30 16:19:48 UTC (rev 124033)
+++ trunk/Source/WebCore/ChangeLog 2012-07-30 16:32:57 UTC (rev 124034)
@@ -1,3 +1,32 @@
+2012-07-30 Vineet Chaudhary rgf...@motorola.com
+
+https://bugs.webkit.org/show_bug.cgi?id=92642
+[Bindings]Remove custom JS/V8 bindings for WebSocket::close() using [Clamp]
+
+Reviewed by Kentaro Hara.
+
+With support of [Clamp] as extended attribute we can replace custom bindings from WebSocket::close().
+Spec for WebSocket::close() : http://www.whatwg.org/specs/web-apps/current-work/multipage/network.html#websocket
+
+No new tests. There should be no behavioural changes
+Existing tests under http/websocket/tests/hybi/ should cover this.
+
+* Modules/websockets/WebSocket.h:
+(WebCore::WebSocket::close):
+* Modules/websockets/WebSocket.idl: Used [Clamp].
+* bindings/js/JSWebSocketCustom.cpp: Removed custom call close().
+(WebCore):
+* bindings/scripts/CodeGeneratorJS.pm:
+(GenerateParametersCheck):
+* bindings/scripts/CodeGeneratorV8.pm:
+(GenerateParametersCheck):
+* bindings/scripts/test/JS/JSTestObj.cpp:
+(WebCore::jsTestObjPrototypeFunctionClassMethodWithClamp):
+* bindings/scripts/test/V8/V8TestObj.cpp:
+(WebCore::TestObjV8Internal::classMethodWithClampCallback):
+* bindings/v8/custom/V8WebSocketCustom.cpp: Removed custom call close().
+(WebCore):
+
2012-07-29 Vsevolod Vlasov vse...@chromium.org
Web Inspector: Resource agent's reference to cached resources should be weak.
Modified: trunk/Source/WebCore/Modules/websockets/WebSocket.h (124033 => 124034)
--- trunk/Source/WebCore/Modules/websockets/WebSocket.h 2012-07-30 16:19:48 UTC (rev 124033)
+++ trunk/Source/WebCore/Modules/websockets/WebSocket.h 2012-07-30 16:32:57 UTC (rev 124034)
@@ -38,6 +38,7 @@
#include EventNames.h
#include EventTarget.h
#include KURL.h
+#include WebSocketChannel.h
#include WebSocketChannelClient.h
#include wtf/Forward.h
#include wtf/OwnPtr.h
@@ -73,6 +74,8 @@
bool send(Blob*, ExceptionCode);
void close(int code, const String reason, ExceptionCode);
+void close(ExceptionCode ec) { close(WebSocketChannel::CloseEventCodeNotSpecified, String(), ec); }
+void close(int code, ExceptionCode ec) { close(code, String(), ec); }
const KURL url() const;
State readyState() const;
Modified: trunk/Source/WebCore/Modules/websockets/WebSocket.idl (124033 => 124034)
--- trunk/Source/WebCore/Modules/websockets/WebSocket.idl 2012-07-30 16:19:48 UTC (rev 124033)
+++ trunk/Source/WebCore/Modules/websockets/WebSocket.idl 2012-07-30 16:32:57 UTC (rev 124034)
@@ -73,8 +73,7 @@
// boolean send(in DOMString data) raises(DOMException);
[Custom] boolean send(in DOMString data) raises(DOMException);
-// FIXME: Implement and apply [Clamp] attribute instead of [Custom].
-[Custom] void close(in [Optional] unsigned short code, in [Optional] DOMString reason) raises(DOMException);
[webkit-changes] [124039] trunk/Tools
Title: [124039] trunk/Tools Revision 124039 Author mrobin...@webkit.org Date 2012-07-30 10:17:36 -0700 (Mon, 30 Jul 2012) Log Message [GTK] Add a non-subprocess jhbuild environment and use it for run-gtk-tests https://bugs.webkit.org/show_bug.cgi?id=92626 Reviewed by Gustavo Noronha Silva. Instead of always shelling out to enter a jhbuild environment, add a Python hook for entering a jhbuild environment directly. This avoids requiring a script to be wrapped in jhbuild. * GNUmakefile.am: Remove gtk/run-api-tests from the distribution list. * Scripts/run-gtk-tests: Move most of the logic from run-api-tests here with additional code for entering a jhbuild environment directly. * gtk/run-api-tests: Removed. * jhbuild/jhbuild-wrapper: Use the new helper methods defined in jhbuildutils.py. * jhbuild/jhbuildutils.py: Add some new helper methods here including a method which can transform the current environment into a jhbuild-ified one. Modified Paths trunk/Tools/ChangeLog trunk/Tools/GNUmakefile.am trunk/Tools/Scripts/run-gtk-tests trunk/Tools/jhbuild/jhbuild-wrapper Added Paths trunk/Tools/jhbuild/jhbuildutils.py Removed Paths trunk/Tools/gtk/run-api-tests Diff Modified: trunk/Tools/ChangeLog (124038 => 124039) --- trunk/Tools/ChangeLog 2012-07-30 17:12:36 UTC (rev 124038) +++ trunk/Tools/ChangeLog 2012-07-30 17:17:36 UTC (rev 124039) @@ -1,3 +1,22 @@ +2012-07-30 Martin Robinson mrobin...@igalia.com + +[GTK] Add a non-subprocess jhbuild environment and use it for run-gtk-tests +https://bugs.webkit.org/show_bug.cgi?id=92626 + +Reviewed by Gustavo Noronha Silva. + +Instead of always shelling out to enter a jhbuild environment, add a Python +hook for entering a jhbuild environment directly. This avoids requiring a +script to be wrapped in jhbuild. + +* GNUmakefile.am: Remove gtk/run-api-tests from the distribution list. +* Scripts/run-gtk-tests: Move most of the logic from run-api-tests here +with additional code for entering a jhbuild environment directly. +* gtk/run-api-tests: Removed. +* jhbuild/jhbuild-wrapper: Use the new helper methods defined in jhbuildutils.py. +* jhbuild/jhbuildutils.py: Add some new helper methods here including +a method which can transform the current environment into a jhbuild-ified one. + 2012-07-30 Alexander Pavlov apav...@chromium.org Unreviewed, upgrade apavlov to reviewer. Modified: trunk/Tools/GNUmakefile.am (124038 => 124039) --- trunk/Tools/GNUmakefile.am 2012-07-30 17:12:36 UTC (rev 124038) +++ trunk/Tools/GNUmakefile.am 2012-07-30 17:17:36 UTC (rev 124039) @@ -255,7 +255,6 @@ Tools/gtk/common.py \ Tools/gtk/generate-gtkdoc \ Tools/gtk/gtkdoc.py \ - Tools/gtk/run-api-tests \ Tools/Scripts/VCSUtils.pm \ Tools/Scripts/run-gtk-tests \ Tools/Scripts/webkit-build-directory \ Modified: trunk/Tools/Scripts/run-gtk-tests (124038 => 124039) --- trunk/Tools/Scripts/run-gtk-tests 2012-07-30 17:12:36 UTC (rev 124038) +++ trunk/Tools/Scripts/run-gtk-tests 2012-07-30 17:17:36 UTC (rev 124039) @@ -1,6 +1,6 @@ #!/usr/bin/env python # -# Copyright (C) 2012 Igalia S.L. +# Copyright (C) 2011, 2012 Igalia S.L. # # This library is free software; you can redistribute it and/or # modify it under the terms of the GNU Library General Public @@ -20,18 +20,320 @@ import subprocess import os import sys +import optparse +import re +from signal import alarm, signal, SIGALRM, SIGKILL +from gi.repository import Gio, GLib -api_tests_command = [] - top_level_directory = os.path.normpath(os.path.join(os.path.dirname(__file__), .., ..)) -run_api_tests_path = os.path.join(top_level_directory, 'Tools', 'gtk', 'run-api-tests') +sys.path.append(os.path.join(top_level_directory, Tools, jhbuild)) +sys.path.append(os.path.join(top_level_directory, Tools, gtk)) +import common +import jhbuildutils -if os.path.exists(os.path.join(top_level_directory, 'WebKitBuild', 'Dependencies')): -jhbuild_wrapper_path = os.path.join(top_level_directory, 'Tools', 'jhbuild', 'jhbuild-wrapper') -api_tests_command = [jhbuild_wrapper_path, '--gtk', 'run', run_api_tests_path] -else: -api_tests_command = [run_api_tests_path] +class SkippedTest: +ENTIRE_SUITE = None -api_tests_command.extend(sys.argv[1:]) -sys.exit(subprocess.Popen(api_tests_command).wait()) +def __init__(self, test, test_case, reason, bug=None): +self.test = test +self.test_case = test_case +self.reason = reason +self.bug = bug +def __str__(self): +skipped_test_str = %s % self.test + +if not(self.skip_entire_suite()): +skipped_test_str += [%s] % self.test_case + +skipped_test_str += : %s % self.reason +if self.bug is not None: +skipped_test_str += (https://bugs.webkit.org/show_bug.cgi?id=%d) % self.bug +return skipped_test_str + +def skip_entire_suite(self): +
[webkit-changes] [124040] branches/safari-536.26-branch/Source/WebCore
Title: [124040] branches/safari-536.26-branch/Source/WebCore
Revision 124040
Author lforsch...@apple.com
Date 2012-07-30 10:18:00 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r116642. rdar://problem/11942097
Modified Paths
branches/safari-536.26-branch/Source/WebCore/ChangeLog
branches/safari-536.26-branch/Source/WebCore/html/HTMLFormControlElement.cpp
branches/safari-536.26-branch/Source/WebCore/html/HTMLFormControlElement.h
Diff
Modified: branches/safari-536.26-branch/Source/WebCore/ChangeLog (124039 => 124040)
--- branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 17:17:36 UTC (rev 124039)
+++ branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 17:18:00 UTC (rev 124040)
@@ -1,5 +1,33 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 116642
+
+2012-05-10 Keishi Hattori kei...@webkit.org
+
+Crash in HTMLFormControlElement::m_fieldSetAncestor
+https://bugs.webkit.org/show_bug.cgi?id=86070
+
+Reviewed by Kent Tamura.
+
+No new tests.
+
+The previous patch r115990 didn't completely resolve the crash (Bug 85453)
+We don't have a reproducible test case, so we are reverting to the old code for setting m_fieldSetAncestor.
+
+* html/HTMLFormControlElement.cpp:
+(WebCore::HTMLFormControlElement::HTMLFormControlElement):
+(WebCore::HTMLFormControlElement::updateFieldSetAndLegendAncestor):
+(WebCore::HTMLFormControlElement::insertedInto): Set m_dataListAncestorState to Unknown because ancestor has changed. Call setNeedsWillValidateCheck because style might need to be updated.
+(WebCore::HTMLFormControlElement::removedFrom):
+(WebCore::HTMLFormControlElement::disabled):
+(WebCore::HTMLFormControlElement::recalcWillValidate):
+(WebCore::HTMLFormControlElement::willValidate):
+(WebCore::HTMLFormControlElement::setNeedsWillValidateCheck):
+* html/HTMLFormControlElement.h:
+(HTMLFormControlElement): Added m_dataListAncestorState.
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 116551
2012-05-09 Ken Buchanan ke...@chromium.org
Modified: branches/safari-536.26-branch/Source/WebCore/html/HTMLFormControlElement.cpp (124039 => 124040)
--- branches/safari-536.26-branch/Source/WebCore/html/HTMLFormControlElement.cpp 2012-07-30 17:17:36 UTC (rev 124039)
+++ branches/safari-536.26-branch/Source/WebCore/html/HTMLFormControlElement.cpp 2012-07-30 17:18:00 UTC (rev 124040)
@@ -50,17 +50,17 @@
: LabelableElement(tagName, document)
, m_fieldSetAncestor(0)
, m_legendAncestor(0)
-, m_ancestorsValid(false)
+, m_fieldSetAncestorValid(false)
, m_disabled(false)
, m_readOnly(false)
, m_required(false)
, m_valueMatchesRenderer(false)
+, m_dataListAncestorState(Unknown)
, m_willValidateInitialized(false)
, m_willValidate(true)
, m_isValid(true)
, m_wasChangedSinceLastFormControlChangeEvent(false)
, m_hasAutofocused(false)
-, m_hasDataListAncestor(false)
{
setForm(form ? form : findFormAncestor());
setHasCustomWillOrDidRecalcStyle();
@@ -101,22 +101,19 @@
return fastHasAttribute(formnovalidateAttr);
}
-void HTMLFormControlElement::updateAncestors() const
+void HTMLFormControlElement::updateFieldSetAndLegendAncestor() const
{
m_fieldSetAncestor = 0;
m_legendAncestor = 0;
-m_hasDataListAncestor = false;
for (ContainerNode* ancestor = parentNode(); ancestor; ancestor = ancestor-parentNode()) {
if (!m_legendAncestor ancestor-hasTagName(legendTag))
m_legendAncestor = static_castHTMLLegendElement*(ancestor);
-if (!m_fieldSetAncestor ancestor-hasTagName(fieldsetTag))
+if (ancestor-hasTagName(fieldsetTag)) {
m_fieldSetAncestor = static_castHTMLFieldSetElement*(ancestor);
-if (!m_hasDataListAncestor ancestor-hasTagName(datalistTag))
-m_hasDataListAncestor = true;
-if (m_hasDataListAncestor m_fieldSetAncestor)
break;
+}
}
-m_ancestorsValid = true;
+m_fieldSetAncestorValid = true;
}
void HTMLFormControlElement::parseAttribute(Attribute* attr)
@@ -227,18 +224,19 @@
Node::InsertionNotificationRequest HTMLFormControlElement::insertedInto(Node* insertionPoint)
{
+m_dataListAncestorState = Unknown;
+setNeedsWillValidateCheck();
HTMLElement::insertedInto(insertionPoint);
FormAssociatedElement::insertedInto(insertionPoint);
-m_ancestorsValid = false;
-setNeedsWillValidateCheck();
return InsertionDone;
}
void HTMLFormControlElement::removedFrom(Node* insertionPoint)
{
+m_fieldSetAncestorValid = false;
+m_dataListAncestorState = Unknown;
HTMLElement::removedFrom(insertionPoint);
FormAssociatedElement::removedFrom(insertionPoint);
-m_ancestorsValid = false;
}
const
[webkit-changes] [124041] trunk/LayoutTests
Title: [124041] trunk/LayoutTests Revision 124041 Author commit-qu...@webkit.org Date 2012-07-30 10:19:18 -0700 (Mon, 30 Jul 2012) Log Message [EFL][DRT] fast/text/font-variant-ligatures.html fails with missing rendering output https://bugs.webkit.org/show_bug.cgi?id=85606 Unreviewed, EFL gardening. Unskip test that's passing after r123864 due to complex font support. Patch by Dominik Röttsches dominik.rottsc...@intel.com on 2012-07-30 * platform/efl/TestExpectations: font-variant-ligatures.html unskipped. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (124040 => 124041) --- trunk/LayoutTests/ChangeLog 2012-07-30 17:18:00 UTC (rev 124040) +++ trunk/LayoutTests/ChangeLog 2012-07-30 17:19:18 UTC (rev 124041) @@ -1,3 +1,14 @@ +2012-07-30 Dominik Röttsches dominik.rottsc...@intel.com + +[EFL][DRT] fast/text/font-variant-ligatures.html fails with missing rendering output +https://bugs.webkit.org/show_bug.cgi?id=85606 + +Unreviewed, EFL gardening. + +Unskip test that's passing after r123864 due to complex font support. + +* platform/efl/TestExpectations: font-variant-ligatures.html unskipped. + 2012-07-30 Csaba Osztrogonác o...@webkit.org [Qt] Unreviewed gardening. Unkskip more passing tests after bug85203. Modified: trunk/LayoutTests/platform/efl/TestExpectations (124040 => 124041) --- trunk/LayoutTests/platform/efl/TestExpectations 2012-07-30 17:18:00 UTC (rev 124040) +++ trunk/LayoutTests/platform/efl/TestExpectations 2012-07-30 17:19:18 UTC (rev 124041) @@ -603,9 +603,6 @@ BUGWK84678 : fast/spatial-navigation/snav-fully-aligned-horizontally.html = TEXT BUGWK84678 : fast/spatial-navigation/snav-iframe-no-scrollable-content.html = TEXT -// Ligatures rendering issue. -BUGWK85606 : fast/text/font-variant-ligatures.html = IMAGE - // Off-by-few-pixels issue for this selection reftest, fails on GTK as well. BUGWK84701 : fast/block/line-layout/selection-highlight-overlap.html = TEXT IMAGE IMAGE+TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124042] trunk
Title: [124042] trunk
Revision 124042
Author senorbla...@chromium.org
Date 2012-07-30 10:22:35 -0700 (Mon, 30 Jul 2012)
Log Message
[chromium] Refactor the computation of resampled bitmap size in
drawImage and drawPattern.
https://bugs.webkit.org/show_bug.cgi?id=92408
Reviewed by Adrienne Walker.
Source/WebCore:
We used to have a special-purpose function called TransformDimensions()
which did pretty much the same thing as SkRect::mapRect() does. This
change unifies the drawPattern code to use mapRect() in the same way
that drawImage() does.
Covered by existing tests, e.g., fast/backgrounds/size/*.
* platform/graphics/skia/ImageSkia.cpp:
(WebCore):
(WebCore::Image::drawPattern):
Note: we're now doing using the original (float) source rect, and
converting to int only after applying the matrix transform. This
might result in different decisions about resampling mode, but it's
more correct anyway.
LayoutTests:
Mark a test as expected to fail (will need rebaseline).
* platform/chromium/TestExpectations:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/chromium/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/skia/ImageSkia.cpp
Diff
Modified: trunk/LayoutTests/ChangeLog (124041 => 124042)
--- trunk/LayoutTests/ChangeLog 2012-07-30 17:19:18 UTC (rev 124041)
+++ trunk/LayoutTests/ChangeLog 2012-07-30 17:22:35 UTC (rev 124042)
@@ -1,3 +1,15 @@
+2012-07-26 Stephen White senorbla...@chromium.org
+
+[chromium] Refactor the computation of resampled bitmap size in
+drawImage and drawPattern.
+https://bugs.webkit.org/show_bug.cgi?id=92408
+
+Reviewed by Adrienne Walker.
+
+Mark a test as expected to fail (will need rebaseline).
+
+* platform/chromium/TestExpectations:
+
2012-07-30 Dominik Röttsches dominik.rottsc...@intel.com
[EFL][DRT] fast/text/font-variant-ligatures.html fails with missing rendering output
Modified: trunk/LayoutTests/platform/chromium/TestExpectations (124041 => 124042)
--- trunk/LayoutTests/platform/chromium/TestExpectations 2012-07-30 17:19:18 UTC (rev 124041)
+++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-07-30 17:22:35 UTC (rev 124042)
@@ -3045,6 +3045,9 @@
BUGWK81145 LION : fast/writing-mode/broken-ideographic-font.html = CRASH
BUGWK81145 LION : fast/writing-mode/japanese-rl-text-with-broken-font.html = CRASH
+// Needs rebaseline.
+BUGWK92059 : fast/gradients/background-clipped.html = IMAGE
+
BUGYANGGUO MAC : fast/repaint/moving-shadow-on-container.html = TEXT
BUGWK81537 : fast/events/touch/gesture/pad-gesture-fling.html = TEXT PASS
Modified: trunk/Source/WebCore/ChangeLog (124041 => 124042)
--- trunk/Source/WebCore/ChangeLog 2012-07-30 17:19:18 UTC (rev 124041)
+++ trunk/Source/WebCore/ChangeLog 2012-07-30 17:22:35 UTC (rev 124042)
@@ -1,3 +1,26 @@
+2012-07-26 Stephen White senorbla...@chromium.org
+
+[chromium] Refactor the computation of resampled bitmap size in
+drawImage and drawPattern.
+https://bugs.webkit.org/show_bug.cgi?id=92408
+
+Reviewed by Adrienne Walker.
+
+We used to have a special-purpose function called TransformDimensions()
+which did pretty much the same thing as SkRect::mapRect() does. This
+change unifies the drawPattern code to use mapRect() in the same way
+that drawImage() does.
+
+Covered by existing tests, e.g., fast/backgrounds/size/*.
+
+* platform/graphics/skia/ImageSkia.cpp:
+(WebCore):
+(WebCore::Image::drawPattern):
+Note: we're now doing using the original (float) source rect, and
+converting to int only after applying the matrix transform. This
+might result in different decisions about resampling mode, but it's
+more correct anyway.
+
2012-07-30 Vineet Chaudhary rgf...@motorola.com
https://bugs.webkit.org/show_bug.cgi?id=92642
Modified: trunk/Source/WebCore/platform/graphics/skia/ImageSkia.cpp (124041 => 124042)
--- trunk/Source/WebCore/platform/graphics/skia/ImageSkia.cpp 2012-07-30 17:19:18 UTC (rev 124041)
+++ trunk/Source/WebCore/platform/graphics/skia/ImageSkia.cpp 2012-07-30 17:22:35 UTC (rev 124042)
@@ -274,25 +274,6 @@
platformContext-didDrawRect(destRect, paint, bitmap.bitmap());
}
-// Transforms the given dimensions with the given matrix. Used to see how big
-// images will be once transformed.
-static void TransformDimensions(const SkMatrix matrix, float srcWidth, float srcHeight, float* destWidth, float* destHeight)
-{
-// Transform 3 points to see how long each side of the bitmap will be.
-SkPoint srcPoints[3]; // (0, 0), (width, 0), (0, height).
-srcPoints[0].set(0, 0);
-srcPoints[1].set(SkFloatToScalar(srcWidth), 0);
-srcPoints[2].set(0, SkFloatToScalar(srcHeight));
-
-// Now measure the length of the two transformed vectors relative to the
-// transformed origin to see how big the
[webkit-changes] [124043] branches/safari-536.26-branch
Title: [124043] branches/safari-536.26-branch
Revision 124043
Author lforsch...@apple.com
Date 2012-07-30 10:24:07 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r116647. rdar://problem/11942030
Modified Paths
branches/safari-536.26-branch/ChangeLog
branches/safari-536.26-branch/Source/WebCore/ChangeLog
branches/safari-536.26-branch/Source/WebCore/svg/SVGFilterElement.cpp
branches/safari-536.26-branch/Source/WebCore/svg/SVGFilterElement.h
branches/safari-536.26-branch/Source/WebCore/svg/SVGFilterPrimitiveStandardAttributes.h
Added Paths
branches/safari-536.26-branch/ManualTests/bugzilla-83979.svg
Diff
Modified: branches/safari-536.26-branch/ChangeLog (124042 => 124043)
--- branches/safari-536.26-branch/ChangeLog 2012-07-30 17:22:35 UTC (rev 124042)
+++ branches/safari-536.26-branch/ChangeLog 2012-07-30 17:24:07 UTC (rev 124043)
@@ -1,3 +1,18 @@
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
+Merge 116647
+
+2012-05-09 Stephen Chenney schen...@chromium.org
+
+SVG Filters allow invalid elements as children
+https://bugs.webkit.org/show_bug.cgi?id=83979
+
+Reviewed by Nikolas Zimmermann.
+
+This test will crash upon load in Chromium, unless the associated fix is in.
+
+* ManualTests/bugzilla-83979.svg: Added.
+
2012-05-31 Tim Horton timothy_hor...@apple.com
Add feature defines for web-facing parts of CSS Regions and Exclusions
Copied: branches/safari-536.26-branch/ManualTests/bugzilla-83979.svg (from rev 116647, trunk/ManualTests/bugzilla-83979.svg) (0 => 124043)
--- branches/safari-536.26-branch/ManualTests/bugzilla-83979.svg (rev 0)
+++ branches/safari-536.26-branch/ManualTests/bugzilla-83979.svg 2012-07-30 17:24:07 UTC (rev 124043)
@@ -0,0 +1,16 @@
+svg xmlns=http://www.w3.org/2000/svg xmlns:xlink=http://www.w3.org/1999/xlink
+ defs
+filter id=ds2
+ feGaussianBlur id=blur result=blur/
+/filter
+ /defs
+ text x=50 y=50This test passes if it does not crash after load in Debug builds./text
+ image id=image xlink:href="" xmlns='http://www.w3.org/2000/svg'%3E%3Crect/%3E%3C/svg%3E width=50 height=50 filter=url(#ds2)/
+script![CDATA[
+for (var i = 0; i 1; i++) {
+}
+document.getElementById(blur).appendChild(document.getElementById(image).cloneNode());
+for (var i = 0; i 1; i++) {
+}
+]]/script
+/svg
Modified: branches/safari-536.26-branch/Source/WebCore/ChangeLog (124042 => 124043)
--- branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 17:22:35 UTC (rev 124042)
+++ branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 17:24:07 UTC (rev 124043)
@@ -1,5 +1,34 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 116647
+
+2012-05-10 Stephen Chenney schen...@chromium.org
+
+SVG Filters allow invalid elements as children
+https://bugs.webkit.org/show_bug.cgi?id=83979
+
+Reviewed by Nikolas Zimmermann.
+
+According to the SVG spec, there are numerous restrictions on the
+content of nodes (that is, their children). Specific to this problem,
+SVGFilter elements may only contain SVGFilterPrimitive elements, and
+those may only contain animation related elements. This patch enforces
+the restriction on filters in the render tree, thus preventing us from
+having (for instance) content that is inside a filter yet filtered by
+the filter.
+
+Manual test: ManualTests/bugzilla-83979.svg
+
+* svg/SVGFilterElement.cpp:
+(WebCore::SVGFilterElement::childShouldCreateRenderer): Added to only allow renderers for fe* children
+(WebCore):
+* svg/SVGFilterElement.h:
+(SVGFilterElement):
+* svg/SVGFilterPrimitiveStandardAttributes.h: Do not allow any children at all for fe* elements.
+(SVGFilterPrimitiveStandardAttributes):
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 116642
2012-05-10 Keishi Hattori kei...@webkit.org
Modified: branches/safari-536.26-branch/Source/WebCore/svg/SVGFilterElement.cpp (124042 => 124043)
--- branches/safari-536.26-branch/Source/WebCore/svg/SVGFilterElement.cpp 2012-07-30 17:22:35 UTC (rev 124042)
+++ branches/safari-536.26-branch/Source/WebCore/svg/SVGFilterElement.cpp 2012-07-30 17:24:07 UTC (rev 124043)
@@ -27,6 +27,7 @@
#include SVGFilterElement.h
#include Attr.h
+#include NodeRenderingContext.h
#include RenderSVGResourceFilter.h
#include SVGElementInstance.h
#include SVGFilterBuilder.h
@@ -193,6 +194,45 @@
return new (arena) RenderSVGResourceFilter(this);
}
+bool SVGFilterElement::childShouldCreateRenderer(const NodeRenderingContext childContext) const
+{
+if (!childContext.node()-isSVGElement())
+return false;
+
+Element* element = static_castElement*(childContext.node());
+
+DEFINE_STATIC_LOCAL(HashSetQualifiedName,
[webkit-changes] [124044] trunk
Title: [124044] trunk
Revision 124044
Author jchaffr...@webkit.org
Date 2012-07-30 10:24:14 -0700 (Mon, 30 Jul 2012)
Log Message
ASSERTION FAILED: !rect.isEmpty() : void WebCore::GraphicsContext::drawRect(const WebCore::IntRect )
https://bugs.webkit.org/show_bug.cgi?id=92187
Reviewed by Simon Fraser.
Source/WebCore:
The border painting logic (RenderBoxModelObject::paintOneBorderSide) would pass a rect with a 0px length
to RenderObject::drawLineForBoxSide. We do check the width (thickness) but not the length so we would pass
the rect to GraphicsContext and hit the ASSERT. This change adds a check for the length too as it is the safest
way, it means that we may still do unneeded operations before bailing out but that's an existing problem in the code.
Tests: fast/borders/0px-borders-no-line-height.html
fast/borders/double-1px-border-assert.html
* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
Added a 0px length check. While renaming confusing variables and re-using others,
I also found a potential empty border that I fixed (tested by the 2nd case above).
LayoutTests:
* fast/borders/0px-borders-no-line-height-expected.html: Added.
* fast/borders/0px-borders-no-line-height.html: Added.
* fast/borders/double-1px-border-assert-expected.html: Added.
* fast/borders/double-1px-border-assert.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderObject.cpp
Added Paths
trunk/LayoutTests/fast/borders/0px-borders-no-line-height-expected.html
trunk/LayoutTests/fast/borders/0px-borders-no-line-height.html
trunk/LayoutTests/fast/borders/double-1px-border-assert-expected.html
trunk/LayoutTests/fast/borders/double-1px-border-assert.html
Diff
Modified: trunk/LayoutTests/ChangeLog (124043 => 124044)
--- trunk/LayoutTests/ChangeLog 2012-07-30 17:24:07 UTC (rev 124043)
+++ trunk/LayoutTests/ChangeLog 2012-07-30 17:24:14 UTC (rev 124044)
@@ -1,3 +1,15 @@
+2012-07-30 Julien Chaffraix jchaffr...@webkit.org
+
+ASSERTION FAILED: !rect.isEmpty() : void WebCore::GraphicsContext::drawRect(const WebCore::IntRect )
+https://bugs.webkit.org/show_bug.cgi?id=92187
+
+Reviewed by Simon Fraser.
+
+* fast/borders/0px-borders-no-line-height-expected.html: Added.
+* fast/borders/0px-borders-no-line-height.html: Added.
+* fast/borders/double-1px-border-assert-expected.html: Added.
+* fast/borders/double-1px-border-assert.html: Added.
+
2012-07-26 Stephen White senorbla...@chromium.org
[chromium] Refactor the computation of resampled bitmap size in
Added: trunk/LayoutTests/fast/borders/0px-borders-no-line-height-expected.html (0 => 124044)
--- trunk/LayoutTests/fast/borders/0px-borders-no-line-height-expected.html (rev 0)
+++ trunk/LayoutTests/fast/borders/0px-borders-no-line-height-expected.html 2012-07-30 17:24:14 UTC (rev 124044)
@@ -0,0 +1,17 @@
+!DOCTYPE html
+html
+head
+style
+.border {
+border-right: 1px solid black;
+border-left: 1px solid black;
+line-height: 0;
+}
+/style
+/head
+body
+pTest for a href="" ASSERTION FAILED: !rect.isEmpty() : void WebCore::GraphicsContext::drawRect(const WebCore::IntRect )/p
+pThis test passes if it doesn't ASSERT./p
+div class=bordernsbp;/div
+/body
+/html
Property changes on: trunk/LayoutTests/fast/borders/0px-borders-no-line-height-expected.html
___
Added: svn:executable
Added: trunk/LayoutTests/fast/borders/0px-borders-no-line-height.html (0 => 124044)
--- trunk/LayoutTests/fast/borders/0px-borders-no-line-height.html (rev 0)
+++ trunk/LayoutTests/fast/borders/0px-borders-no-line-height.html 2012-07-30 17:24:14 UTC (rev 124044)
@@ -0,0 +1,17 @@
+!DOCTYPE html
+html
+head
+style
+.border {
+border-style: solid;
+border-width: 0 1px 0 1px;
+line-height: 0;
+}
+/style
+/head
+body
+pTest for a href="" ASSERTION FAILED: !rect.isEmpty() : void WebCore::GraphicsContext::drawRect(const WebCore::IntRect )/p
+pThis test passes if it doesn't ASSERT./p
+div class=bordernsbp;/div
+/body
+/html
Property changes on: trunk/LayoutTests/fast/borders/0px-borders-no-line-height.html
___
Added: svn:executable
Added: trunk/LayoutTests/fast/borders/double-1px-border-assert-expected.html (0 => 124044)
--- trunk/LayoutTests/fast/borders/double-1px-border-assert-expected.html (rev 0)
+++ trunk/LayoutTests/fast/borders/double-1px-border-assert-expected.html 2012-07-30 17:24:14 UTC (rev 124044)
@@ -0,0 +1,16 @@
+!DOCTYPE html
+html
+body
+style
+.test {
+width: 1px;
+height: 1px;
+border-style: double;
+border-width: 0px 3px 0px 3px;
+}
+/style
+pTest for a href="" ASSERTION FAILED: !rect.isEmpty() : void WebCore::GraphicsContext::drawRect(const WebCore::IntRect )/p
+pThis test
[webkit-changes] [124046] trunk/Tools
Title: [124046] trunk/Tools
Revision 124046
Author senorbla...@chromium.org
Date 2012-07-30 10:40:49 -0700 (Mon, 30 Jul 2012)
Log Message
Added a SkiaGraphics definition to the watchlist file; cc'ed myself
to that group. Unreviewed.
* Scripts/webkitpy/common/config/watchlist:
Modified Paths
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/common/config/watchlist
Diff
Modified: trunk/Tools/ChangeLog (124045 => 124046)
--- trunk/Tools/ChangeLog 2012-07-30 17:27:03 UTC (rev 124045)
+++ trunk/Tools/ChangeLog 2012-07-30 17:40:49 UTC (rev 124046)
@@ -1,3 +1,10 @@
+2012-07-30 Stephen White senorbla...@chromium.org
+
+Added a SkiaGraphics definition to the watchlist file; cc'ed myself
+to that group. Unreviewed.
+
+* Scripts/webkitpy/common/config/watchlist:
+
2012-07-30 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r123966 and r123967.
Modified: trunk/Tools/Scripts/webkitpy/common/config/watchlist (124045 => 124046)
--- trunk/Tools/Scripts/webkitpy/common/config/watchlist 2012-07-30 17:27:03 UTC (rev 124045)
+++ trunk/Tools/Scripts/webkitpy/common/config/watchlist 2012-07-30 17:40:49 UTC (rev 124046)
@@ -69,6 +69,10 @@
less: r[Ss]ecurityOrigin(?!\.(h|cpp)),
filename: rXSS|[Ss]ecurity,
},
+SkiaGraphics: {
+filename: rSource/WebCore/platform/graphics/skia/
+r|Source/WebCore/platform/graphics/filters/skia/,
+},
V8Bindings: {
filename: rSource/WebCore/bindings/v8/,
},
@@ -241,6 +245,7 @@
Media: [ feature-media-revi...@chromium.org, eric.carl...@apple.com ],
NetworkInfo: [ gyuyoung@samsung.com ],
OpenGL : [ noam.rosent...@nokia.com ],
+SkiaGraphics: [ senorbla...@chromium.org ],
QtBuildSystem : [ ves...@webkit.org, ],
QtGraphics : [ noam.rosent...@nokia.com ],
QtWebKit2PlatformSpecific: [ alexis.men...@openbossa.org, zol...@webkit.org, cmarc...@webkit.org ],
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124047] trunk/LayoutTests
Title: [124047] trunk/LayoutTests
Revision 124047
Author commit-qu...@webkit.org
Date 2012-07-30 10:41:47 -0700 (Mon, 30 Jul 2012)
Log Message
REGRESSION: Focused TR element draws its focus outline in the wrong place
https://bugs.webkit.org/show_bug.cgi?id=85348
Patch by Pravin D pravind@gmail.com on 2012-07-30
Reviewed by Julien Chaffraix.
The focus ring used to be drawn around the first row of the table section irrespective of the row in focus.
The issue was fixed by the bug http://www.webkit.org/b/92389 .
Adding a regression test case.
* fast/table/table-row-focus-ring-paint-expected.txt: Added.
* fast/table/table-row-focus-ring-paint.html: Added.
* platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png: Added.
* platform/qt-4.8/fast/table/table-row-focus-ring-paint-expected.png: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/fast/table/table-row-focus-ring-paint-expected.txt
trunk/LayoutTests/fast/table/table-row-focus-ring-paint.html
trunk/LayoutTests/platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png
trunk/LayoutTests/platform/qt-4.8/fast/table/table-row-focus-ring-paint-expected.png
Diff
Modified: trunk/LayoutTests/ChangeLog (124046 => 124047)
--- trunk/LayoutTests/ChangeLog 2012-07-30 17:40:49 UTC (rev 124046)
+++ trunk/LayoutTests/ChangeLog 2012-07-30 17:41:47 UTC (rev 124047)
@@ -1,3 +1,19 @@
+2012-07-30 Pravin D pravind@gmail.com
+
+REGRESSION: Focused TR element draws its focus outline in the wrong place
+https://bugs.webkit.org/show_bug.cgi?id=85348
+
+Reviewed by Julien Chaffraix.
+
+The focus ring used to be drawn around the first row of the table section irrespective of the row in focus.
+The issue was fixed by the bug http://www.webkit.org/b/92389 .
+Adding a regression test case.
+
+* fast/table/table-row-focus-ring-paint-expected.txt: Added.
+* fast/table/table-row-focus-ring-paint.html: Added.
+* platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png: Added.
+* platform/qt-4.8/fast/table/table-row-focus-ring-paint-expected.png: Added.
+
2012-07-30 Julien Chaffraix jchaffr...@webkit.org
ASSERTION FAILED: !rect.isEmpty() : void WebCore::GraphicsContext::drawRect(const WebCore::IntRect )
Added: trunk/LayoutTests/fast/table/table-row-focus-ring-paint-expected.txt (0 => 124047)
--- trunk/LayoutTests/fast/table/table-row-focus-ring-paint-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/table/table-row-focus-ring-paint-expected.txt 2012-07-30 17:41:47 UTC (rev 124047)
@@ -0,0 +1 @@
+
Added: trunk/LayoutTests/fast/table/table-row-focus-ring-paint.html (0 => 124047)
--- trunk/LayoutTests/fast/table/table-row-focus-ring-paint.html (rev 0)
+++ trunk/LayoutTests/fast/table/table-row-focus-ring-paint.html 2012-07-30 17:41:47 UTC (rev 124047)
@@ -0,0 +1,39 @@
+!DOCTYPE html
+html
+head
+title Testcase for bug https://bugs.webkit.org/show_bug.cgi?id=85348 /title
+!--
+Issue: The focus ring used be drawn around the first row irrespective of the current focused row. The issue was fixed by the bug
+ http://www.webkit.org/b/92389 .
+Description: The test case checks if the focus ring is drawn around currently focused table row.
+Expectation: Focus ring must be drawn around the green box and not around the yellow boxes.
+ --
+script
+if(window.testRunner)
+testRunner.dumpAsText(true);
+/script
+/head
+body
+style
+td {
+width: 50px;
+height: 50px;
+background:yellow;
+ }
+/style
+table
+ tr
+td/td
+ /tr
+ tr id=row2 tabindex=0
+td style=background:green/td
+ /tr
+ tr tabindex=0
+td/td
+ /tr
+/table
+script
+ document.getElementById('row2').focus();
+/script
+/body
+/html
Added: trunk/LayoutTests/platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png (0 => 124047)
--- trunk/LayoutTests/platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png (rev 0)
+++ trunk/LayoutTests/platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png 2012-07-30 17:41:47 UTC (rev 124047)
@@ -0,0 +1,7 @@
+\x89PNG
+
+
+IHDR X ' )tEXtchecksum e1d161da93b04cd8216f865f58169454\xCFd gIDATx\x9C\xED\xDC1N\xDB` \x86a\E\xCAP\x89\x84kй\xE9\x95z j\xB8X\xC3 \xD7 \xC8\xE6\xC9\xDD\xDA\xD1+\xA1\xE7\xED\xF8\xC6W\xAC \xF3_ \xD0\xF9r\xEE \x9F\x8D\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\xD8\xEA\xB5\xC3+N\xE4?\xE8\x80\x8F\xC8
[webkit-changes] [124048] trunk/LayoutTests
Title: [124048] trunk/LayoutTests
Revision 124048
Author zandober...@gmail.com
Date 2012-07-30 10:44:36 -0700 (Mon, 30 Jul 2012)
Log Message
Unreviewed GTK gardening.
Skipping a test that utilizes unsupported isolated worlds and updating
one baseline after r123988.
* platform/gtk/TestExpectations:
* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (124047 => 124048)
--- trunk/LayoutTests/ChangeLog 2012-07-30 17:41:47 UTC (rev 124047)
+++ trunk/LayoutTests/ChangeLog 2012-07-30 17:44:36 UTC (rev 124048)
@@ -1,3 +1,13 @@
+2012-07-30 Zan Dobersek zandober...@gmail.com
+
+Unreviewed GTK gardening.
+
+Skipping a test that utilizes unsupported isolated worlds and updating
+one baseline after r123988.
+
+* platform/gtk/TestExpectations:
+* platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
+
2012-07-30 Pravin D pravind@gmail.com
REGRESSION: Focused TR element draws its focus outline in the wrong place
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (124047 => 124048)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2012-07-30 17:41:47 UTC (rev 124047)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2012-07-30 17:44:36 UTC (rev 124048)
@@ -365,6 +365,7 @@
// New test infrastructure required -- need isolated worlds
BUGWK31508 SKIP : http/tests/security/isolatedWorld = TEXT
BUGWK31508 BUGWK61540 SKIP : http/tests/security/isolatedWorld/cross-origin-xhr.html = TEXT
+BUGWK31508 SKIP : plugins/npruntime/overrides-all-properties.html = TEXT
BUGWK31508 SKIP : storage/websql/open-database-creation-callback-isolated-world.html = TEXT
BUGWK31508 SKIP : storage/websql/statement-error-callback-isolated-world.html = TEXT
BUGWK31508 SKIP : storage/websql/statement-success-callback-isolated-world.html = TEXT
Modified: trunk/LayoutTests/platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt (124047 => 124048)
--- trunk/LayoutTests/platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt 2012-07-30 17:41:47 UTC (rev 124047)
+++ trunk/LayoutTests/platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt 2012-07-30 17:44:36 UTC (rev 124048)
@@ -14,5 +14,4 @@
RenderBlock (anonymous) at (0,164) size 784x0
RenderText {#text} at (0,0) size 0x0
RenderBlock {PRE} at (0,177) size 784x0
-selection start: position 5 of child 0 {#text} of child 1 {P} of child 3 {DIV} of body
-selection end: position 13 of child 0 {#text} of child 1 {P} of child 3 {DIV} of body
+caret: position 13 of child 0 {#text} of child 1 {P} of child 3 {DIV} of body
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124050] trunk/Source/WebKit/blackberry
Title: [124050] trunk/Source/WebKit/blackberry
Revision 124050
Author mifen...@rim.com
Date 2012-07-30 10:48:34 -0700 (Mon, 30 Jul 2012)
Log Message
[BlackBerry] Optimize the generation of selection details generation.
https://bugs.webkit.org/show_bug.cgi?id=92522
Reviewed by Antonio Gomes.
PR 179264.
Reduce the number of times we generate selection details notifications.
This removes several notifications that are handled by the standard
notification path and makes skipping duplicate notifications the default
so that only those that must generate a response do.
Reviewed Internally by Gen Mak.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::notifyTransformedContentsSizeChanged):
(BlackBerry::WebKit::WebPagePrivate::updateDelegatedOverlays):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::setElementUnfocused):
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::setCaretPosition):
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
(BlackBerry::WebKit::SelectionHandler::setSelection):
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
* WebKitSupport/SelectionHandler.h:
(SelectionHandler):
Modified Paths
trunk/Source/WebKit/blackberry/Api/WebPage.cpp
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp
trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp
trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.h
Diff
Modified: trunk/Source/WebKit/blackberry/Api/WebPage.cpp (124049 => 124050)
--- trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-07-30 17:46:47 UTC (rev 124049)
+++ trunk/Source/WebKit/blackberry/Api/WebPage.cpp 2012-07-30 17:48:34 UTC (rev 124050)
@@ -2085,7 +2085,6 @@
const IntSize size = transformedContentsSize();
m_backingStore-d-contentsSizeChanged(size);
m_client-contentsSizeChanged(size);
-m_selectionHandler-selectionPositionChanged();
}
void WebPagePrivate::notifyTransformedScrollChanged()
@@ -3392,7 +3391,7 @@
if (Platform::webKitThreadMessageClient()-isCurrentThread()) {
// Must be called on the WebKit thread.
if (m_selectionHandler-isSelectionActive())
-m_selectionHandler-selectionPositionChanged(true /* visualChangeOnly */);
+m_selectionHandler-selectionPositionChanged();
if (m_inspectorOverlay)
m_inspectorOverlay-update();
Modified: trunk/Source/WebKit/blackberry/ChangeLog (124049 => 124050)
--- trunk/Source/WebKit/blackberry/ChangeLog 2012-07-30 17:46:47 UTC (rev 124049)
+++ trunk/Source/WebKit/blackberry/ChangeLog 2012-07-30 17:48:34 UTC (rev 124050)
@@ -1,3 +1,33 @@
+2012-07-30 Mike Fenton mifen...@rim.com
+
+[BlackBerry] Optimize the generation of selection details generation.
+https://bugs.webkit.org/show_bug.cgi?id=92522
+
+Reviewed by Antonio Gomes.
+
+PR 179264.
+
+Reduce the number of times we generate selection details notifications.
+
+This removes several notifications that are handled by the standard
+notification path and makes skipping duplicate notifications the default
+so that only those that must generate a response do.
+
+Reviewed Internally by Gen Mak.
+
+* Api/WebPage.cpp:
+(BlackBerry::WebKit::WebPagePrivate::notifyTransformedContentsSizeChanged):
+(BlackBerry::WebKit::WebPagePrivate::updateDelegatedOverlays):
+* WebKitSupport/InputHandler.cpp:
+(BlackBerry::WebKit::InputHandler::setElementUnfocused):
+* WebKitSupport/SelectionHandler.cpp:
+(BlackBerry::WebKit::SelectionHandler::setCaretPosition):
+(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
+(BlackBerry::WebKit::SelectionHandler::setSelection):
+(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
+* WebKitSupport/SelectionHandler.h:
+(SelectionHandler):
+
2012-07-30 Robin Cao robin@torchmobile.com.cn
[BlackBerry] Adapt to changes in the SharedArray platform API
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp (124049 => 124050)
--- trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-07-30 17:46:47 UTC (rev 124049)
+++ trunk/Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp 2012-07-30 17:48:34 UTC (rev 124050)
@@ -659,7 +659,6 @@
notifyClientOfKeyboardVisibilityChange(false);
m_webPage-m_client-inputFocusLost();
-m_webPage-m_selectionHandler-selectionPositionChanged();
// If the frame selection isn't focused, focus it.
if (!m_currentFocusElement-document()-frame()-selection()-isFocused())
Modified: trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp (124049 => 124050)
--- trunk/Source/WebKit/blackberry/WebKitSupport/SelectionHandler.cpp 2012-07-30 17:46:47 UTC (rev 124049)
+++
[webkit-changes] [124051] trunk/LayoutTests
Title: [124051] trunk/LayoutTests Revision 124051 Author senorbla...@chromium.org Date 2012-07-30 10:56:38 -0700 (Mon, 30 Jul 2012) Log Message [chromium] Unreviewed gardening. Marking two accelerated painting tests as crashing intermittently. https://bugs.webkit.org/show_bug.cgi?id=92660 * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (124050 => 124051) --- trunk/LayoutTests/ChangeLog 2012-07-30 17:48:34 UTC (rev 124050) +++ trunk/LayoutTests/ChangeLog 2012-07-30 17:56:38 UTC (rev 124051) @@ -1,3 +1,11 @@ +2012-07-30 Stephen White senorbla...@chromium.org + +[chromium] Unreviewed gardening. Marking two accelerated painting +tests as crashing intermittently. +https://bugs.webkit.org/show_bug.cgi?id=92660 + +* platform/chromium/TestExpectations: + 2012-07-30 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r124025. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (124050 => 124051) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-07-30 17:48:34 UTC (rev 124050) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-07-30 17:56:38 UTC (rev 124051) @@ -2890,6 +2890,10 @@ BUGWK73514 WIN : platform/chromium/compositing/lost-compositor-context-permanently.html = PASS TIMEOUT +Flaky/crashing +BUGWK92660 : platform/chromium/compositing/accelerated-drawing/svg-filters.html = CRASH PASS +BUGWK92660 : platform/chromium/compositing/accelerated-drawing/alpha.html = CRASH PASS + // Flaky BUGWK73692 : media/event-attributes.html = CRASH TEXT PASS BUGWK73692 : media/video-playbackrate.html = CRASH PASS ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124052] trunk/Source/WebCore
Title: [124052] trunk/Source/WebCore Revision 124052 Author e...@google.com Date 2012-07-30 11:00:29 -0700 (Mon, 30 Jul 2012) Log Message [chromium] Turn back on ScrollbarLayerChromium for Windows https://bugs.webkit.org/show_bug.cgi?id=92409 Reviewed by James Robinson. This reverts r122791. As GDI issues were addressed in Chromium via http://src.chromium.org/viewvc/chrome?view=revrevision=148215, scrollbar parts can now be composited on the thread. * page/scrolling/chromium/ScrollingCoordinatorChromium.cpp: (WebCore::createScrollbarLayer): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp Diff Modified: trunk/Source/WebCore/ChangeLog (124051 => 124052) --- trunk/Source/WebCore/ChangeLog 2012-07-30 17:56:38 UTC (rev 124051) +++ trunk/Source/WebCore/ChangeLog 2012-07-30 18:00:29 UTC (rev 124052) @@ -1,3 +1,17 @@ +2012-07-30 Adrienne Walker e...@google.com + +[chromium] Turn back on ScrollbarLayerChromium for Windows +https://bugs.webkit.org/show_bug.cgi?id=92409 + +Reviewed by James Robinson. + +This reverts r122791. As GDI issues were addressed in Chromium via +http://src.chromium.org/viewvc/chrome?view=revrevision=148215, +scrollbar parts can now be composited on the thread. + +* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp: +(WebCore::createScrollbarLayer): + 2012-07-30 Sheriff Bot webkit.review@gmail.com Unreviewed, rolling out r124025. Modified: trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp (124051 => 124052) --- trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp 2012-07-30 17:56:38 UTC (rev 124051) +++ trunk/Source/WebCore/page/scrolling/chromium/ScrollingCoordinatorChromium.cpp 2012-07-30 18:00:29 UTC (rev 124052) @@ -126,11 +126,8 @@ scrollbarGraphicsLayer-setContentsOpaque(isOpaqueRootScrollbar); // FIXME: Mac scrollbar themes are not thread-safe to paint. -// FIXME: Win scrollbars on XP Classic themes do not paint valid alpha -// values due to GDI. This needs to be fixed in theme code before it -// can be turned on here. bool platformSupported = true; -#if OS(DARWIN) || OS(WINDOWS) +#if OS(DARWIN) platformSupported = false; #endif ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124053] trunk/LayoutTests
Title: [124053] trunk/LayoutTests
Revision 124053
Author zandober...@gmail.com
Date 2012-07-30 11:01:07 -0700 (Mon, 30 Jul 2012)
Log Message
Unreviewed GTK gardening.
Adding platform-specific baselines that are required after r123793, r123912 and r123914.
* platform/gtk/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
* platform/gtk/fast/hidpi/gradient-with-scaled-ancestor-expected.txt: Added.
* platform/gtk/fast/table/table-row-outline-paint-expected.png: Added.
* platform/gtk/fast/table/table-row-outline-paint-expected.txt: Added.
* platform/gtk/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.png: Added.
* platform/gtk/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.txt: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
Added Paths
trunk/LayoutTests/platform/gtk/fast/hidpi/gradient-with-scaled-ancestor-expected.png
trunk/LayoutTests/platform/gtk/fast/hidpi/gradient-with-scaled-ancestor-expected.txt
trunk/LayoutTests/platform/gtk/fast/table/table-row-outline-paint-expected.png
trunk/LayoutTests/platform/gtk/fast/table/table-row-outline-paint-expected.txt
trunk/LayoutTests/platform/gtk/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.png
trunk/LayoutTests/platform/gtk/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.txt
Diff
Modified: trunk/LayoutTests/ChangeLog (124052 => 124053)
--- trunk/LayoutTests/ChangeLog 2012-07-30 18:00:29 UTC (rev 124052)
+++ trunk/LayoutTests/ChangeLog 2012-07-30 18:01:07 UTC (rev 124053)
@@ -1,3 +1,16 @@
+2012-07-30 Zan Dobersek zandober...@gmail.com
+
+Unreviewed GTK gardening.
+
+Adding platform-specific baselines that are required after r123793, r123912 and r123914.
+
+* platform/gtk/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
+* platform/gtk/fast/hidpi/gradient-with-scaled-ancestor-expected.txt: Added.
+* platform/gtk/fast/table/table-row-outline-paint-expected.png: Added.
+* platform/gtk/fast/table/table-row-outline-paint-expected.txt: Added.
+* platform/gtk/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.png: Added.
+* platform/gtk/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.txt: Added.
+
2012-07-30 Stephen White senorbla...@chromium.org
[chromium] Unreviewed gardening. Marking two accelerated painting
Added: trunk/LayoutTests/platform/gtk/fast/hidpi/gradient-with-scaled-ancestor-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/gtk/fast/hidpi/gradient-with-scaled-ancestor-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/gtk/fast/hidpi/gradient-with-scaled-ancestor-expected.txt (0 => 124053)
--- trunk/LayoutTests/platform/gtk/fast/hidpi/gradient-with-scaled-ancestor-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/fast/hidpi/gradient-with-scaled-ancestor-expected.txt 2012-07-30 18:01:07 UTC (rev 124053)
@@ -0,0 +1,8 @@
+layer at (0,0) size 1184x585
+ RenderView at (0,0) size 800x585
+layer at (0,0) size 800x585
+ RenderBlock {HTML} at (0,0) size 800x585
+RenderBody {BODY} at (8,8) size 784x569
+layer at (8,8) size 784x302
+ RenderBlock {DIV} at (0,0) size 784x302
+RenderBlock {DIV} at (0,0) size 302x302 [border: (1px solid #00)]
Added: trunk/LayoutTests/platform/gtk/fast/table/table-row-outline-paint-expected.png
(Binary files differ)
Property changes on: trunk/LayoutTests/platform/gtk/fast/table/table-row-outline-paint-expected.png
___
Added: svn:mime-type
Added: trunk/LayoutTests/platform/gtk/fast/table/table-row-outline-paint-expected.txt (0 => 124053)
--- trunk/LayoutTests/platform/gtk/fast/table/table-row-outline-paint-expected.txt (rev 0)
+++ trunk/LayoutTests/platform/gtk/fast/table/table-row-outline-paint-expected.txt 2012-07-30 18:01:07 UTC (rev 124053)
@@ -0,0 +1,13 @@
+layer at (0,0) size 800x600
+ RenderView at (0,0) size 800x600
+layer at (0,0) size 800x600
+ RenderBlock {HTML} at (0,0) size 800x600
+RenderBody {BODY} at (8,8) size 784x584
+ RenderTable {TABLE} at (0,0) size 114x106
+RenderTableSection {TBODY} at (0,0) size 114x106
+ RenderTableRow {TR} at (0,2) size 114x50
+RenderTableCell {TD} at (2,25) size 54x4 [border: (1px solid #00)] [r=0 c=0 rs=1 cs=1]
+RenderTableCell {TD} at (58,25) size 54x4 [border: (1px solid #00)] [r=0 c=1 rs=1 cs=1]
+ RenderTableRow {TR} at (0,54) size 114x50
+RenderTableCell {TD} at (2,77) size 54x4 [border: (1px solid #00)] [r=1 c=0 rs=1 cs=1]
+RenderTableCell {TD} at (58,77) size 54x4 [border: (1px solid #00)] [r=1 c=1 rs=1 cs=1]
Added:
[webkit-changes] [124054] branches/safari-536.26-branch
Title: [124054] branches/safari-536.26-branch
Revision 124054
Author lforsch...@apple.com
Date 2012-07-30 11:15:38 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r116669. rdar://problem/11942055
Modified Paths
branches/safari-536.26-branch/LayoutTests/ChangeLog
branches/safari-536.26-branch/Source/WebCore/ChangeLog
branches/safari-536.26-branch/Source/WebCore/editing/ApplyStyleCommand.cpp
Added Paths
branches/safari-536.26-branch/LayoutTests/editing/style/apply-style-join-child-text-nodes-crash-expected.txt
branches/safari-536.26-branch/LayoutTests/editing/style/apply-style-join-child-text-nodes-crash.html
Diff
Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (124053 => 124054)
--- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 18:01:07 UTC (rev 124053)
+++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 18:15:38 UTC (rev 124054)
@@ -1,5 +1,19 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 116669
+
+2012-05-10 Abhishek Arya infe...@chromium.org
+
+Crash in ApplyStyleCommand::joinChildTextNodes.
+https://bugs.webkit.org/show_bug.cgi?id=85939
+
+Reviewed by Ryosuke Niwa.
+
+* editing/style/apply-style-join-child-text-nodes-crash-expected.txt: Added.
+* editing/style/apply-style-join-child-text-nodes-crash.html: Added.
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 116551
2012-05-09 Ken Buchanan ke...@chromium.org
Copied: branches/safari-536.26-branch/LayoutTests/editing/style/apply-style-join-child-text-nodes-crash-expected.txt (from rev 116669, trunk/LayoutTests/editing/style/apply-style-join-child-text-nodes-crash-expected.txt) (0 => 124054)
--- branches/safari-536.26-branch/LayoutTests/editing/style/apply-style-join-child-text-nodes-crash-expected.txt (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/editing/style/apply-style-join-child-text-nodes-crash-expected.txt 2012-07-30 18:15:38 UTC (rev 124054)
@@ -0,0 +1,4 @@
+PASS successfullyParsed is true
+
+TEST COMPLETE
+PASS. WebKit didn't crash.
Copied: branches/safari-536.26-branch/LayoutTests/editing/style/apply-style-join-child-text-nodes-crash.html (from rev 116669, trunk/LayoutTests/editing/style/apply-style-join-child-text-nodes-crash.html) (0 => 124054)
--- branches/safari-536.26-branch/LayoutTests/editing/style/apply-style-join-child-text-nodes-crash.html (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/editing/style/apply-style-join-child-text-nodes-crash.html 2012-07-30 18:15:38 UTC (rev 124054)
@@ -0,0 +1,28 @@
+!DOCTYPE html
+html
+body
+script src=""
+script id=script1
+document.addEventListener(DOMCharacterDataModified,function(){
+document.body.innerHTML = PASS. WebKit didn't crash.;
+gc();
+finishJSTest();
+},true);
+/script
+script
+window.jsTestIsAsync = true;
+
+if (window.layoutTestController)
+layoutTestController.waitUntilDone();
+
+var scriptElement = document.getElementById('script1');
+scriptElement.parentNode.appendChild(scriptElement.firstChild);
+scriptElement.parentNode.removeChild(scriptElement);
+document.designMode = on;
+document.execCommand(SelectAll);
+document.execCommand(FontSizeDelta, false, 3);
+/script
+script src=""
+/body
+/html
+
Modified: branches/safari-536.26-branch/Source/WebCore/ChangeLog (124053 => 124054)
--- branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 18:01:07 UTC (rev 124053)
+++ branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 18:15:38 UTC (rev 124054)
@@ -1,5 +1,29 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 116669
+
+2012-05-10 Abhishek Arya infe...@chromium.org
+
+Crash in ApplyStyleCommand::joinChildTextNodes.
+https://bugs.webkit.org/show_bug.cgi?id=85939
+
+Reviewed by Ryosuke Niwa.
+
+Test: editing/style/apply-style-join-child-text-nodes-crash.html
+
+* editing/ApplyStyleCommand.cpp:
+(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): add conditions
+to bail out if our start and end position nodes are removed due to
+mutation events in joinChildTextNodes.
+(WebCore::ApplyStyleCommand::applyInlineStyle): this executes after
+applyRelativeFontStyleChange in ApplyStyleCommand::doApply. So, need
+to bail out if our start and end position nodes are removed due to
+mutation events.
+(WebCore::ApplyStyleCommand::joinChildTextNodes): hold all the children
+in a ref vector to prevent them from getting destroyed due to mutation events.
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 116647
2012-05-10 Stephen Chenney schen...@chromium.org
Modified: branches/safari-536.26-branch/Source/WebCore/editing/ApplyStyleCommand.cpp (124053 => 124054)
---
[webkit-changes] [124055] branches/safari-536.26-branch
Title: [124055] branches/safari-536.26-branch
Revision 124055
Author lforsch...@apple.com
Date 2012-07-30 11:17:55 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r116683. rdar://problem/11942090
Modified Paths
branches/safari-536.26-branch/LayoutTests/ChangeLog
branches/safari-536.26-branch/Source/WebCore/ChangeLog
branches/safari-536.26-branch/Source/WebCore/rendering/RenderObject.cpp
branches/safari-536.26-branch/Source/WebCore/rendering/RenderObjectChildList.cpp
Added Paths
branches/safari-536.26-branch/LayoutTests/fast/block/float/float-not-removed-from-first-letter-expected.txt
branches/safari-536.26-branch/LayoutTests/fast/block/float/float-not-removed-from-first-letter.html
Diff
Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (124054 => 124055)
--- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 18:15:38 UTC (rev 124054)
+++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 18:17:55 UTC (rev 124055)
@@ -1,5 +1,19 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 116683
+
+2012-05-10 Abhishek Arya infe...@chromium.org
+
+Crash due to floats not removed from first-letter element.
+https://bugs.webkit.org/show_bug.cgi?id=86019
+
+Reviewed by Julien Chaffraix.
+
+* fast/block/float/float-not-removed-from-first-letter-expected.txt: Added.
+* fast/block/float/float-not-removed-from-first-letter.html: Added.
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 116669
2012-05-10 Abhishek Arya infe...@chromium.org
Copied: branches/safari-536.26-branch/LayoutTests/fast/block/float/float-not-removed-from-first-letter-expected.txt (from rev 116683, trunk/LayoutTests/fast/block/float/float-not-removed-from-first-letter-expected.txt) (0 => 124055)
--- branches/safari-536.26-branch/LayoutTests/fast/block/float/float-not-removed-from-first-letter-expected.txt (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/fast/block/float/float-not-removed-from-first-letter-expected.txt 2012-07-30 18:17:55 UTC (rev 124055)
@@ -0,0 +1,3 @@
+Webkit Bug 86019 - Crash due to floats not removed from first-letter element.
+
+PASS. WebKit didn't crash.
Copied: branches/safari-536.26-branch/LayoutTests/fast/block/float/float-not-removed-from-first-letter.html (from rev 116683, trunk/LayoutTests/fast/block/float/float-not-removed-from-first-letter.html) (0 => 124055)
--- branches/safari-536.26-branch/LayoutTests/fast/block/float/float-not-removed-from-first-letter.html (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/fast/block/float/float-not-removed-from-first-letter.html 2012-07-30 18:17:55 UTC (rev 124055)
@@ -0,0 +1,27 @@
+!DOCTYPE html
+html
+Webkit Bug 86019 - Crash due to floats not removed from first-letter element.
+style
+.li2 { width: 0px; }
+.li2:first-letter { float: left; content: counter(section); }
+.li2:first-of-type { display: -webkit-inline-flexbox; }
+/style
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+function crash() {
+li1 = document.createElement('li');
+document.documentElement.appendChild(li1);
+keygen1 = document.createElement('keygen');
+keygen1.setAttribute('autofocus', 'autofocus');
+document.documentElement.appendChild(keygen1);
+li2 = document.createElement('li');
+li2.setAttribute('class', 'li2');
+document.documentElement.appendChild(li2);
+text1 = document.createTextNode(PASS. WebKit didn't crash.);
+li2.appendChild(text1);
+}
+window._onload_ = crash;
+/script
+/html
Modified: branches/safari-536.26-branch/Source/WebCore/ChangeLog (124054 => 124055)
--- branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 18:15:38 UTC (rev 124054)
+++ branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 18:17:55 UTC (rev 124055)
@@ -1,5 +1,28 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 116683
+
+2012-05-10 Abhishek Arya infe...@chromium.org
+
+Crash due to floats not removed from first-letter element.
+https://bugs.webkit.org/show_bug.cgi?id=86019
+
+Reviewed by Julien Chaffraix.
+
+Move clearing logic of a floating/positioned object from removeChild
+to removeChildNode. There are lot of places which use removeChildNode
+directly and hence the object is not removed from the floating or
+positioned objects list.
+
+Test: fast/block/float/float-not-removed-from-first-letter.html
+
+* rendering/RenderObject.cpp:
+(WebCore::RenderObject::removeChild):
+* rendering/RenderObjectChildList.cpp:
+(WebCore::RenderObjectChildList::removeChildNode):
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 116669
2012-05-10 Abhishek Arya infe...@chromium.org
Modified:
[webkit-changes] [124056] trunk/LayoutTests
Title: [124056] trunk/LayoutTests Revision 124056 Author senorbla...@chromium.org Date 2012-07-30 11:20:02 -0700 (Mon, 30 Jul 2012) Log Message [chromium] Unreviewed gardening. Add new mac baselines for tests affected by r124042. Fix a typo in TestExpectations. * platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: * platform/chromium-mac-snowleopard/fast/borders/border-image-rotate-transform-expected.png: * platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: * platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png: * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/borders/border-image-rotate-transform-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (124055 => 124056) --- trunk/LayoutTests/ChangeLog 2012-07-30 18:17:55 UTC (rev 124055) +++ trunk/LayoutTests/ChangeLog 2012-07-30 18:20:02 UTC (rev 124056) @@ -1,3 +1,14 @@ +2012-07-30 Stephen White senorbla...@chromium.org + +[chromium] Unreviewed gardening. Add new mac baselines for tests +affected by r124042. Fix a typo in TestExpectations. + +* platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: +* platform/chromium-mac-snowleopard/fast/borders/border-image-rotate-transform-expected.png: +* platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: +* platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png: +* platform/chromium/TestExpectations: + 2012-07-30 Zan Dobersek zandober...@gmail.com Unreviewed GTK gardening. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (124055 => 124056) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-07-30 18:17:55 UTC (rev 124055) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-07-30 18:20:02 UTC (rev 124056) @@ -2890,7 +2890,7 @@ BUGWK73514 WIN : platform/chromium/compositing/lost-compositor-context-permanently.html = PASS TIMEOUT -Flaky/crashing +// Flaky/crashing BUGWK92660 : platform/chromium/compositing/accelerated-drawing/svg-filters.html = CRASH PASS BUGWK92660 : platform/chromium/compositing/accelerated-drawing/alpha.html = CRASH PASS Modified: trunk/LayoutTests/platform/chromium-mac/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac/fast/borders/border-image-rotate-transform-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/borders/border-image-rotate-transform-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124057] branches/safari-536.26-branch
Title: [124057] branches/safari-536.26-branch
Revision 124057
Author lforsch...@apple.com
Date 2012-07-30 11:22:29 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r116698. rdar://problem/11942088
Modified Paths
branches/safari-536.26-branch/LayoutTests/ChangeLog
branches/safari-536.26-branch/Source/WebCore/ChangeLog
branches/safari-536.26-branch/Source/WebCore/platform/graphics/FontDescription.h
Added Paths
branches/safari-536.26-branch/LayoutTests/fast/css/large-font-size-crash-expected.txt
branches/safari-536.26-branch/LayoutTests/fast/css/large-font-size-crash.html
Diff
Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (124056 => 124057)
--- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 18:20:02 UTC (rev 124056)
+++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 18:22:29 UTC (rev 124057)
@@ -1,5 +1,19 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 116698
+
+2012-05-10 Abhishek Arya infe...@chromium.org
+
+Crash in FontCache::releaseFontData due to infinite float size.
+https://bugs.webkit.org/show_bug.cgi?id=86110
+
+Reviewed by Andreas Kling.
+
+* fast/css/large-font-size-crash-expected.txt: Added.
+* fast/css/large-font-size-crash.html: Added.
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 116683
2012-05-10 Abhishek Arya infe...@chromium.org
Copied: branches/safari-536.26-branch/LayoutTests/fast/css/large-font-size-crash-expected.txt (from rev 116698, trunk/LayoutTests/fast/css/large-font-size-crash-expected.txt) (0 => 124057)
--- branches/safari-536.26-branch/LayoutTests/fast/css/large-font-size-crash-expected.txt (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/fast/css/large-font-size-crash-expected.txt 2012-07-30 18:22:29 UTC (rev 124057)
@@ -0,0 +1 @@
+PASS. WebKit didn't crash.
Copied: branches/safari-536.26-branch/LayoutTests/fast/css/large-font-size-crash.html (from rev 116698, trunk/LayoutTests/fast/css/large-font-size-crash.html) (0 => 124057)
--- branches/safari-536.26-branch/LayoutTests/fast/css/large-font-size-crash.html (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/fast/css/large-font-size-crash.html 2012-07-30 18:22:29 UTC (rev 124057)
@@ -0,0 +1,10 @@
+!DOCTYPE html
+html
+body style='font: 99in Ahem;'
+PASS. WebKit didn't crash.
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+/script
+/body
+/html
Modified: branches/safari-536.26-branch/Source/WebCore/ChangeLog (124056 => 124057)
--- branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 18:20:02 UTC (rev 124056)
+++ branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 18:22:29 UTC (rev 124057)
@@ -1,5 +1,26 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 116698
+
+2012-05-10 Abhishek Arya infe...@chromium.org
+
+Crash in FontCache::releaseFontData due to infinite float size.
+https://bugs.webkit.org/show_bug.cgi?id=86110
+
+Reviewed by Andreas Kling.
+
+New callers always forget to clamp the font size, which overflows
+to infinity on multiplication. It is best to clamp it at the end
+to avoid getting greater than std::numeric_limitsfloat::max().
+
+Test: fast/css/large-font-size-crash.html
+
+* platform/graphics/FontDescription.h:
+(WebCore::FontDescription::setComputedSize):
+(WebCore::FontDescription::setSpecifiedSize):
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 116683
2012-05-10 Abhishek Arya infe...@chromium.org
Modified: branches/safari-536.26-branch/Source/WebCore/platform/graphics/FontDescription.h (124056 => 124057)
--- branches/safari-536.26-branch/Source/WebCore/platform/graphics/FontDescription.h 2012-07-30 18:20:02 UTC (rev 124056)
+++ branches/safari-536.26-branch/Source/WebCore/platform/graphics/FontDescription.h 2012-07-30 18:22:29 UTC (rev 124057)
@@ -138,8 +138,8 @@
FontDescription makeNormalFeatureSettings() const;
void setFamily(const FontFamily family) { m_familyList = family; }
-void setComputedSize(float s) { ASSERT(isfinite(s)); m_computedSize = s; }
-void setSpecifiedSize(float s) { ASSERT(isfinite(s)); m_specifiedSize = s; }
+void setComputedSize(float s) { m_computedSize = clampToFloat(s); }
+void setSpecifiedSize(float s) { m_specifiedSize = clampToFloat(s); }
void setItalic(FontItalic i) { m_italic = i; }
void setItalic(bool i) { setItalic(i ? FontItalicOn : FontItalicOff); }
void setSmallCaps(FontSmallCaps c) { m_smallCaps = c; }
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
[webkit-changes] [124058] branches/safari-536.26-branch/Source/WebCore
Title: [124058] branches/safari-536.26-branch/Source/WebCore
Revision 124058
Author lforsch...@apple.com
Date 2012-07-30 11:24:48 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r116717. rdar://problem/11942052
Modified Paths
branches/safari-536.26-branch/Source/WebCore/ChangeLog
branches/safari-536.26-branch/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp
Diff
Modified: branches/safari-536.26-branch/Source/WebCore/ChangeLog (124057 => 124058)
--- branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 18:22:29 UTC (rev 124057)
+++ branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 18:24:48 UTC (rev 124058)
@@ -1,5 +1,24 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 116717
+
+2012-05-10 Abhishek Arya infe...@chromium.org
+
+Crash in swapInNodePreservingAttributesAndChildren.
+https://bugs.webkit.org/show_bug.cgi?id=85197
+
+Reviewed by Ryosuke Niwa.
+
+Keep the children in a ref vector before adding them to newNode.
+They can get destroyed due to mutation events.
+
+No new tests because we don't have a reduction.
+
+* editing/ReplaceNodeWithSpanCommand.cpp:
+(WebCore::swapInNodePreservingAttributesAndChildren):
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 116698
2012-05-10 Abhishek Arya infe...@chromium.org
Modified: branches/safari-536.26-branch/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp (124057 => 124058)
--- branches/safari-536.26-branch/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp 2012-07-30 18:22:29 UTC (rev 124057)
+++ branches/safari-536.26-branch/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp 2012-07-30 18:24:48 UTC (rev 124058)
@@ -56,10 +56,10 @@
parentNode-insertBefore(newNode, nodeToReplace, ec);
ASSERT(!ec);
-RefPtrNode nextChild;
-for (Node* child = nodeToReplace-firstChild(); child; child = nextChild.get()) {
-nextChild = child-nextSibling();
-newNode-appendChild(child, ec);
+NodeVector children;
+getChildNodes(nodeToReplace, children);
+for (size_t i = 0; i children.size(); ++i) {
+newNode-appendChild(children[i], ec);
ASSERT(!ec);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124059] branches/safari-536.26-branch
Title: [124059] branches/safari-536.26-branch
Revision 124059
Author lforsch...@apple.com
Date 2012-07-30 11:27:43 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r116827. rdar://problem/11961140
Modified Paths
branches/safari-536.26-branch/LayoutTests/ChangeLog
branches/safari-536.26-branch/Source/WebCore/ChangeLog
branches/safari-536.26-branch/Source/WebCore/rendering/mathml/RenderMathMLFenced.cpp
branches/safari-536.26-branch/Source/WebCore/rendering/mathml/RenderMathMLFenced.h
Added Paths
branches/safari-536.26-branch/LayoutTests/mathml/presentation/mfenced-add-child1-expected.html
branches/safari-536.26-branch/LayoutTests/mathml/presentation/mfenced-add-child1.html
branches/safari-536.26-branch/LayoutTests/mathml/presentation/mfenced-add-child2-expected.html
branches/safari-536.26-branch/LayoutTests/mathml/presentation/mfenced-add-child2.html
Diff
Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (124058 => 124059)
--- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 18:24:48 UTC (rev 124058)
+++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 18:27:43 UTC (rev 124059)
@@ -1,5 +1,21 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 116827
+
+2012-05-11 David Barton dbar...@mathscribe.com
+
+use after free in WebCore::RenderObject::document
+https://bugs.webkit.org/show_bug.cgi?id=84891
+
+Reviewed by Julien Chaffraix.
+
+* mathml/presentation/mfenced-add-child1-expected.html: Added.
+* mathml/presentation/mfenced-add-child1.html: Added.
+* mathml/presentation/mfenced-add-child2-expected.html: Added.
+* mathml/presentation/mfenced-add-child2.html: Added.
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 116698
2012-05-10 Abhishek Arya infe...@chromium.org
Copied: branches/safari-536.26-branch/LayoutTests/mathml/presentation/mfenced-add-child1-expected.html (from rev 116827, trunk/LayoutTests/mathml/presentation/mfenced-add-child1-expected.html) (0 => 124059)
--- branches/safari-536.26-branch/LayoutTests/mathml/presentation/mfenced-add-child1-expected.html (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/mathml/presentation/mfenced-add-child1-expected.html 2012-07-30 18:27:43 UTC (rev 124059)
@@ -0,0 +1,9 @@
+html
+body
+pFor a href="" 84891/a -
+mfenced add/remove child confusion./p
+
+pThis test passes if the mfenced is completely removed from the render tree,
+so e.g. no parentheses or commas are showing after this paragraph./p
+/body
+/html
Copied: branches/safari-536.26-branch/LayoutTests/mathml/presentation/mfenced-add-child1.html (from rev 116827, trunk/LayoutTests/mathml/presentation/mfenced-add-child1.html) (0 => 124059)
--- branches/safari-536.26-branch/LayoutTests/mathml/presentation/mfenced-add-child1.html (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/mathml/presentation/mfenced-add-child1.html 2012-07-30 18:27:43 UTC (rev 124059)
@@ -0,0 +1,30 @@
+html
+body
+pFor a href="" 84891/a -
+mfenced add/remove child confusion./p
+
+pThis test passes if the mfenced is completely removed from the render tree,
+so e.g. no parentheses or commas are showing after this paragraph./p
+
+math
+ mfenced id=mfenced
+mi id=mi1b/mi
+mi id=mi2c/mi
+ /mfenced
+/math
+/body
+
+script
+var mfenced = document.getElementById(mfenced);
+
+document.getElementById(mi1).appendChild(document.createElement(div));
+mfenced.appendChild(document.createElement(span));
+
+var head = document.getElementsByTagName(head)[0];
+var style = document.createElement(style);
+style.appendChild(document.createTextNode(script{}));
+head.appendChild(style);
+
+mfenced.parentNode.removeChild(mfenced);
+/script
+/html
Copied: branches/safari-536.26-branch/LayoutTests/mathml/presentation/mfenced-add-child2-expected.html (from rev 116827, trunk/LayoutTests/mathml/presentation/mfenced-add-child2-expected.html) (0 => 124059)
--- branches/safari-536.26-branch/LayoutTests/mathml/presentation/mfenced-add-child2-expected.html (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/mathml/presentation/mfenced-add-child2-expected.html 2012-07-30 18:27:43 UTC (rev 124059)
@@ -0,0 +1,16 @@
+!DOCTYPE html
+html
+body
+pFor a href="" 84891/a -
+mfenced add/remove child confusion./p
+
+pThis test passes if the math element is changed to (x1y)./p
+
+math
+ mfenced id=mfenced separators=1
+mi id=mi1x/mi
+mi id=mi2y/mi
+ /mfenced
+/math
+/body
+/html
Copied: branches/safari-536.26-branch/LayoutTests/mathml/presentation/mfenced-add-child2.html (from rev 116827, trunk/LayoutTests/mathml/presentation/mfenced-add-child2.html) (0 => 124059)
--- branches/safari-536.26-branch/LayoutTests/mathml/presentation/mfenced-add-child2.html (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/mathml/presentation/mfenced-add-child2.html 2012-07-30
[webkit-changes] [124060] branches/safari-536.26-branch
Title: [124060] branches/safari-536.26-branch
Revision 124060
Author lforsch...@apple.com
Date 2012-07-30 11:30:09 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r116860. rdar://problem/11942084
Modified Paths
branches/safari-536.26-branch/LayoutTests/ChangeLog
branches/safari-536.26-branch/Source/WebCore/ChangeLog
branches/safari-536.26-branch/Source/WebCore/svg/animation/SVGSMILElement.cpp
Added Paths
branches/safari-536.26-branch/LayoutTests/svg/animations/dynamic-modify-attributename-crash-expected.txt
branches/safari-536.26-branch/LayoutTests/svg/animations/dynamic-modify-attributename-crash.svg
Diff
Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (124059 => 124060)
--- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 18:27:43 UTC (rev 124059)
+++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 18:30:09 UTC (rev 124060)
@@ -1,5 +1,19 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 116860
+
+2012-05-12 Philip Rogers p...@google.com
+
+Cleanup before changing attributeName in SVG animate
+https://bugs.webkit.org/show_bug.cgi?id=86100
+
+Reviewed by Nikolas Zimmermann.
+
+* svg/animations/dynamic-modify-attributename-crash-expected.txt: Added.
+* svg/animations/dynamic-modify-attributename-crash.svg: Added.
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 116827
2012-05-11 David Barton dbar...@mathscribe.com
Copied: branches/safari-536.26-branch/LayoutTests/svg/animations/dynamic-modify-attributename-crash-expected.txt (from rev 116860, trunk/LayoutTests/svg/animations/dynamic-modify-attributename-crash-expected.txt) (0 => 124060)
--- branches/safari-536.26-branch/LayoutTests/svg/animations/dynamic-modify-attributename-crash-expected.txt (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/svg/animations/dynamic-modify-attributename-crash-expected.txt 2012-07-30 18:30:09 UTC (rev 124060)
@@ -0,0 +1 @@
+PASS
Copied: branches/safari-536.26-branch/LayoutTests/svg/animations/dynamic-modify-attributename-crash.svg (from rev 116860, trunk/LayoutTests/svg/animations/dynamic-modify-attributename-crash.svg) (0 => 124060)
--- branches/safari-536.26-branch/LayoutTests/svg/animations/dynamic-modify-attributename-crash.svg (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/svg/animations/dynamic-modify-attributename-crash.svg 2012-07-30 18:30:09 UTC (rev 124060)
@@ -0,0 +1,24 @@
+svg xmlns=http://www.w3.org/2000/svg
+ !-- Test for WK86100 - passes if there is no crash --
+ animate id=animate attributeName=x dur=9s/
+ text id=log/
+ script
+ ![CDATA[
+if (window.layoutTestController) {
+ layoutTestController.waitUntilDone();
+ layoutTestController.dumpAsText();
+}
+
+window.setTimeout(function() {
+ var elem = document.getElementById(animate);
+ elem.setAttribute(attributeName, transform);
+}, 10);
+
+window.setTimeout(function() {
+ document.getElementById(log).appendChild(document.createTextNode(PASS));
+ if (window.layoutTestController)
+layoutTestController.notifyDone();
+}, 100);
+ ]]
+ /script
+/svg
Modified: branches/safari-536.26-branch/Source/WebCore/ChangeLog (124059 => 124060)
--- branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 18:27:43 UTC (rev 124059)
+++ branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 18:30:09 UTC (rev 124060)
@@ -1,5 +1,24 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 116860
+
+2012-05-12 Philip Rogers p...@google.com
+
+Cleanup before changing attributeName in SVG animate
+https://bugs.webkit.org/show_bug.cgi?id=86100
+
+Reviewed by Nikolas Zimmermann.
+
+Changing attributeName caused a crash because references were not removed from the old target.
+This change simply cleans up before changing attributeName in SVG animation elements.
+
+Test: svg/animations/dynamic-modify-attributename-crash.svg
+
+* svg/animation/SVGSMILElement.cpp:
+(WebCore::SVGSMILElement::svgAttributeChanged):
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 116827
2012-05-11 David Barton dbar...@mathscribe.com
Modified: branches/safari-536.26-branch/Source/WebCore/svg/animation/SVGSMILElement.cpp (124059 => 124060)
--- branches/safari-536.26-branch/Source/WebCore/svg/animation/SVGSMILElement.cpp 2012-07-30 18:27:43 UTC (rev 124059)
+++ branches/safari-536.26-branch/Source/WebCore/svg/animation/SVGSMILElement.cpp 2012-07-30 18:30:09 UTC (rev 124060)
@@ -462,9 +462,13 @@
beginListChanged(elapsed());
else if (attrName == SVGNames::endAttr)
endListChanged(elapsed());
-else if (attrName == SVGNames::attributeNameAttr)
+else if (attrName == SVGNames::attributeNameAttr) {
[webkit-changes] [124061] trunk/LayoutTests
Title: [124061] trunk/LayoutTests Revision 124061 Author pkast...@chromium.org Date 2012-07-30 11:33:28 -0700 (Mon, 30 Jul 2012) Log Message [Chromium] New baselines and test expectations update. https://bugs.webkit.org/show_bug.cgi?id=88939 https://bugs.webkit.org/show_bug.cgi?id=91485 http://crbug.com/139162 Unreviewed, test expectations update. * platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-example-01-b-expected.png: Added. * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations Added Paths trunk/LayoutTests/platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-example-01-b-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (124060 => 124061) --- trunk/LayoutTests/ChangeLog 2012-07-30 18:30:09 UTC (rev 124060) +++ trunk/LayoutTests/ChangeLog 2012-07-30 18:33:28 UTC (rev 124061) @@ -1,3 +1,15 @@ +2012-07-30 Peter Kasting pkast...@google.com + +[Chromium] New baselines and test expectations update. +https://bugs.webkit.org/show_bug.cgi?id=88939 +https://bugs.webkit.org/show_bug.cgi?id=91485 +http://crbug.com/139162 + +Unreviewed, test expectations update. + +* platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-example-01-b-expected.png: Added. +* platform/chromium/TestExpectations: + 2012-07-30 Stephen White senorbla...@chromium.org [chromium] Unreviewed gardening. Add new mac baselines for tests Modified: trunk/LayoutTests/platform/chromium/TestExpectations (124060 => 124061) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-07-30 18:30:09 UTC (rev 124060) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-07-30 18:33:28 UTC (rev 124061) @@ -3453,7 +3453,6 @@ BUGWK90860 : fast/dom/shadow/shadowdom-for-object-only-shadow.html = IMAGE BUGWK90860 : fast/dom/shadow/shadowdom-for-object-without-shadow.html = IMAGE BUGWK91485 : fast/dom/shadow/shadowdom-for-textarea-complex-shadow.html = IMAGE -BUGWK91485 : fast/dom/shadow/shadowdom-for-textarea-only-shadow.html = IMAGE BUGWK91485 : fast/dom/shadow/shadowdom-for-textarea-without-shadow.html = IMAGE BUGWK91486 : fast/dom/shadow/shadowdom-for-button-complex-shadow.html = IMAGE BUGWK91486 : fast/dom/shadow/shadowdom-for-button-only-shadow.html = IMAGE @@ -3516,7 +3515,7 @@ BUGWK88900 MAC : http/tests/misc/embed-image-load-outlives-gc-without-crashing.html = TEXT -BUGWK88939 DEBUG : fast/events/before-unload-adopt-subframe-to-outside.html = TEXT +BUGWK88939 DEBUG : fast/events/before-unload-adopt-subframe-to-outside.html = TEXT PASS BUGCR131187 : canvas/philip/tests/2d.gradient.radial.cone.cylinder.html = TEXT BUGCR131187 : fast/canvas/canvas-currentColor.html = TEXT Added: trunk/LayoutTests/platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-example-01-b-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-linux-x86/svg/W3C-SVG-1.1/filters-example-01-b-expected.png ___ Added: svn:mime-type ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124062] branches/safari-536.26-branch
Title: [124062] branches/safari-536.26-branch
Revision 124062
Author lforsch...@apple.com
Date 2012-07-30 11:35:00 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r117007. rdar://problem/11942085
Modified Paths
branches/safari-536.26-branch/LayoutTests/ChangeLog
branches/safari-536.26-branch/Source/WebCore/ChangeLog
branches/safari-536.26-branch/Source/WebCore/rendering/RenderObject.cpp
branches/safari-536.26-branch/Source/WebCore/rendering/RenderObject.h
branches/safari-536.26-branch/Source/WebCore/rendering/RenderScrollbarPart.cpp
branches/safari-536.26-branch/Source/WebCore/rendering/RenderScrollbarPart.h
Added Paths
branches/safari-536.26-branch/LayoutTests/scrollbars/scrollbar-percent-padding-crash-expected.txt
branches/safari-536.26-branch/LayoutTests/scrollbars/scrollbar-percent-padding-crash.html
branches/safari-536.26-branch/LayoutTests/scrollbars/scrollbar-scrollbarparts-repaint-crash-expected.txt
branches/safari-536.26-branch/LayoutTests/scrollbars/scrollbar-scrollbarparts-repaint-crash.html
Diff
Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (124061 => 124062)
--- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 18:33:28 UTC (rev 124061)
+++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 18:35:00 UTC (rev 124062)
@@ -1,5 +1,21 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 117007
+
+2012-05-14 Takashi Sakamoto ta...@google.com
+
+Crash in WebCore::RenderObject::repaint
+https://bugs.webkit.org/show_bug.cgi?id=86162
+
+Reviewed by Abhishek Arya.
+
+* scrollbars/scrollbar-scrollbarparts-repaint-crash-expected.txt: Added.
+* scrollbars/scrollbar-scrollbarparts-repaint-crash.html: Added.
+* scrollbars/scrollbar-percent-padding-crash-expected.txt: Added.
+* scrollbars/scrollbar-percent-padding-crash.html: Added.
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 116860
2012-05-12 Philip Rogers p...@google.com
Copied: branches/safari-536.26-branch/LayoutTests/scrollbars/scrollbar-percent-padding-crash-expected.txt (from rev 117007, trunk/LayoutTests/scrollbars/scrollbar-percent-padding-crash-expected.txt) (0 => 124062)
--- branches/safari-536.26-branch/LayoutTests/scrollbars/scrollbar-percent-padding-crash-expected.txt (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/scrollbars/scrollbar-percent-padding-crash-expected.txt 2012-07-30 18:35:00 UTC (rev 124062)
@@ -0,0 +1,3 @@
+Test for bug 86162: This tests that there is no crash when using percentage value for scrollbar's padding property. On success you should see a frame with scrollbars and one PASS message in it.
+
+
Copied: branches/safari-536.26-branch/LayoutTests/scrollbars/scrollbar-percent-padding-crash.html (from rev 117007, trunk/LayoutTests/scrollbars/scrollbar-percent-padding-crash.html) (0 => 124062)
--- branches/safari-536.26-branch/LayoutTests/scrollbars/scrollbar-percent-padding-crash.html (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/scrollbars/scrollbar-percent-padding-crash.html 2012-07-30 18:35:00 UTC (rev 124062)
@@ -0,0 +1,24 @@
+!DOCTYPE html
+html
+head
+style
+::-webkit-scrollbar {
+ -webkit-padding-start: 1%; background: #666 -webkit-gradient(linear, left top, right top, from(rgba(255,255,255,0.5)), color-stop(0.5, rgba(255,255,255,0.1)), color-stop(0.5, rgba(0,0,0,0)), to(rgba(0,0,0,0.01)));
+}
+/style
+script
+function runTest() {
+if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+document.body.offsetTop;
+layoutTestController.display();
+}
+};
+/script
+/head
+body _onload_=runTest()
+pTest for a href="" 86162/a:
+This tests that there is no crash when using percentage value for scrollbar's padding property. On success you should see a frame with scrollbars and one PASS message in it.
+div style=height: 1000px;/div
+/body
+/html
Copied: branches/safari-536.26-branch/LayoutTests/scrollbars/scrollbar-scrollbarparts-repaint-crash-expected.txt (from rev 117007, trunk/LayoutTests/scrollbars/scrollbar-scrollbarparts-repaint-crash-expected.txt) (0 => 124062)
--- branches/safari-536.26-branch/LayoutTests/scrollbars/scrollbar-scrollbarparts-repaint-crash-expected.txt (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/scrollbars/scrollbar-scrollbarparts-repaint-crash-expected.txt 2012-07-30 18:35:00 UTC (rev 124062)
@@ -0,0 +1 @@
+Test for bug 86162: This test passes if there is no crash when scrollbar's style changes.
Copied: branches/safari-536.26-branch/LayoutTests/scrollbars/scrollbar-scrollbarparts-repaint-crash.html (from rev 117007, trunk/LayoutTests/scrollbars/scrollbar-scrollbarparts-repaint-crash.html) (0 => 124062)
--- branches/safari-536.26-branch/LayoutTests/scrollbars/scrollbar-scrollbarparts-repaint-crash.html (rev 0)
+++
[webkit-changes] [124063] branches/safari-536.26-branch
Title: [124063] branches/safari-536.26-branch
Revision 124063
Author lforsch...@apple.com
Date 2012-07-30 11:37:18 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r117161. rdar://problem/11942062
Modified Paths
branches/safari-536.26-branch/LayoutTests/ChangeLog
branches/safari-536.26-branch/Source/WebCore/ChangeLog
branches/safari-536.26-branch/Source/WebCore/svg/SVGElement.cpp
Added Paths
branches/safari-536.26-branch/LayoutTests/svg/foreignObject/viewport-foreignobject-crash-expected.html
branches/safari-536.26-branch/LayoutTests/svg/foreignObject/viewport-foreignobject-crash.html
Diff
Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (124062 => 124063)
--- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 18:35:00 UTC (rev 124062)
+++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 18:37:18 UTC (rev 124063)
@@ -1,5 +1,19 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 117161
+
+2012-05-15 Abhishek Arya infe...@chromium.org
+
+Crash due shadow tree parent confusion in SVG.
+https://bugs.webkit.org/show_bug.cgi?id=84248
+
+Reviewed by Nikolas Zimmermann.
+
+* svg/foreignObject/viewport-foreignobject-crash-expected.html: Added.
+* svg/foreignObject/viewport-foreignobject-crash.html: Added.
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 117007
2012-05-14 Takashi Sakamoto ta...@google.com
Copied: branches/safari-536.26-branch/LayoutTests/svg/foreignObject/viewport-foreignobject-crash-expected.html (from rev 117161, trunk/LayoutTests/svg/foreignObject/viewport-foreignobject-crash-expected.html) (0 => 124063)
--- branches/safari-536.26-branch/LayoutTests/svg/foreignObject/viewport-foreignobject-crash-expected.html (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/svg/foreignObject/viewport-foreignobject-crash-expected.html 2012-07-30 18:37:18 UTC (rev 124063)
@@ -0,0 +1 @@
+PASS
Copied: branches/safari-536.26-branch/LayoutTests/svg/foreignObject/viewport-foreignobject-crash.html (from rev 117161, trunk/LayoutTests/svg/foreignObject/viewport-foreignobject-crash.html) (0 => 124063)
--- branches/safari-536.26-branch/LayoutTests/svg/foreignObject/viewport-foreignobject-crash.html (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/svg/foreignObject/viewport-foreignobject-crash.html 2012-07-30 18:37:18 UTC (rev 124063)
@@ -0,0 +1,35 @@
+html
+body
+script
+var script = document.getElementsByTagName(script)[0];
+script.parentNode.removeChild(script);
+
+var count = 0;
+function crash() {
+var element = event.srcElement;
+document.adoptNode(element);
+if (!document.body.innerHTML)
+return;
+document.execCommand('InsertHTML', false, document.body.innerHTML);
+if (count == 1) {
+document.removeEventListener(DOMNodeInserted, crash, false);
+document.body.innerHTML = PASS;
+return;
+}
+document.body.appendChild(element);
+element.insertAdjacentHTML('beforeend', 'svgforeignObjectA/foreignObject/svg');
+element.focus();
+count += 1;
+}
+
+document.addEventListener(DOMNodeInserted, crash, false);
+document.addEventListener(DOMContentLoaded, function () {
+document.execCommand(SelectAll, false, false);
+var range = window.getSelection().getRangeAt(0);
+var docFragment = range.extractContents();
+document.documentElement.firstChild.appendChild(docFragment);
+}, false);
+/script
+input/
+/body
+/html
Modified: branches/safari-536.26-branch/Source/WebCore/ChangeLog (124062 => 124063)
--- branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 18:35:00 UTC (rev 124062)
+++ branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 18:37:18 UTC (rev 124063)
@@ -1,5 +1,26 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 117161
+
+2012-05-15 Abhishek Arya infe...@chromium.org
+
+Crash due shadow tree parent confusion in SVG.
+https://bugs.webkit.org/show_bug.cgi?id=84248
+
+Reviewed by Nikolas Zimmermann.
+
+Test: svg/foreignObject/viewport-foreignobject-crash.html
+
+When we try to make a decision on whether we need an outer
+SVGRoot container, we detect if we are in shadow tree or not.
+We also need to make sure that our parentOrHostElement is also
+an svg element.
+
+* svg/SVGElement.cpp:
+(WebCore::SVGElement::isOutermostSVGSVGElement):
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 117007
2012-05-14 Takashi Sakamoto ta...@google.com
Modified: branches/safari-536.26-branch/Source/WebCore/svg/SVGElement.cpp (124062 => 124063)
--- branches/safari-536.26-branch/Source/WebCore/svg/SVGElement.cpp 2012-07-30 18:35:00 UTC (rev 124062)
+++ branches/safari-536.26-branch/Source/WebCore/svg/SVGElement.cpp 2012-07-30 18:37:18 UTC
[webkit-changes] [124064] trunk
Title: [124064] trunk
Revision 124064
Author t...@chromium.org
Date 2012-07-30 11:39:53 -0700 (Mon, 30 Jul 2012)
Log Message
new flexbox should ignore float set on flexitems
https://bugs.webkit.org/show_bug.cgi?id=70792
Reviewed by Ojan Vafai.
Source/WebCore:
Force flex items to not float.
Test: css3/flexbox/floated-flexitem.html
* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle): Force NoFloat on flex items.
LayoutTests:
Make an example in the spec into a ref test. Add some styles to make it a bit more clear what's happening.
* css3/flexbox/floated-flexitem-expected.html: Added.
* css3/flexbox/floated-flexitem.html: Added.
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleResolver.cpp
Added Paths
trunk/LayoutTests/css3/flexbox/floated-flexitem-expected.html
trunk/LayoutTests/css3/flexbox/floated-flexitem.html
Diff
Modified: trunk/LayoutTests/ChangeLog (124063 => 124064)
--- trunk/LayoutTests/ChangeLog 2012-07-30 18:37:18 UTC (rev 124063)
+++ trunk/LayoutTests/ChangeLog 2012-07-30 18:39:53 UTC (rev 124064)
@@ -1,3 +1,15 @@
+2012-07-30 Tony Chang t...@chromium.org
+
+new flexbox should ignore float set on flexitems
+https://bugs.webkit.org/show_bug.cgi?id=70792
+
+Reviewed by Ojan Vafai.
+
+Make an example in the spec into a ref test. Add some styles to make it a bit more clear what's happening.
+
+* css3/flexbox/floated-flexitem-expected.html: Added.
+* css3/flexbox/floated-flexitem.html: Added.
+
2012-07-30 Peter Kasting pkast...@google.com
[Chromium] New baselines and test expectations update.
Added: trunk/LayoutTests/css3/flexbox/floated-flexitem-expected.html (0 => 124064)
--- trunk/LayoutTests/css3/flexbox/floated-flexitem-expected.html (rev 0)
+++ trunk/LayoutTests/css3/flexbox/floated-flexitem-expected.html 2012-07-30 18:39:53 UTC (rev 124064)
@@ -0,0 +1,28 @@
+!DOCTYPE html
+html
+style
+#flexbox {
+ background-color: lightgrey;
+}
+#flexbox * {
+ border: 1px solid green;
+ vertical-align: top;
+}
+/style
+body
+p
+This example is from the spec. There should be four flex items. Anonymous item 3 shouldn't have
+a green border because the anonymous block is the flex item.
+/p
+div id=flexbox
+div style=display: inline-blockblock/divdiv
+ style=display: inline-blockfloat/divdiv
+ style=display: inline-block; border: 0anonymous item 3/divdiv
+ style=display: inline-block
+item 4br
+item 4br
+item 4
+/div
+/div
+/body
+/html
Added: trunk/LayoutTests/css3/flexbox/floated-flexitem.html (0 => 124064)
--- trunk/LayoutTests/css3/flexbox/floated-flexitem.html (rev 0)
+++ trunk/LayoutTests/css3/flexbox/floated-flexitem.html 2012-07-30 18:39:53 UTC (rev 124064)
@@ -0,0 +1,37 @@
+!DOCTYPE html
+html
+style
+#flexbox {
+ background-color: lightgrey;
+ -webkit-align-items: flex-start;
+}
+#flexbox * {
+ border: 1px solid green;
+}
+/style
+body
+p
+This example is from the spec. There should be four flex items. Anonymous item 3 shouldn't have
+a green border because the anonymous block is the flex item.
+/p
+div id=flexbox style=display: -webkit-flex
+
+!-- flex item: block child --
+div id=item1block/div
+
+!-- flex item: floated element; floating is ignored --
+div id=item2 style=float: left;float/div
+
+!-- flex item: anonymous block box around inline content --
+anonymous item 3
+
+!-- flex item: inline child --
+span
+item 4
+!-- flex items do not split around blocks --
+div id=not-an-itemitem 4/div
+item 4
+/span
+/div
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (124063 => 124064)
--- trunk/Source/WebCore/ChangeLog 2012-07-30 18:37:18 UTC (rev 124063)
+++ trunk/Source/WebCore/ChangeLog 2012-07-30 18:39:53 UTC (rev 124064)
@@ -1,3 +1,17 @@
+2012-07-30 Tony Chang t...@chromium.org
+
+new flexbox should ignore float set on flexitems
+https://bugs.webkit.org/show_bug.cgi?id=70792
+
+Reviewed by Ojan Vafai.
+
+Force flex items to not float.
+
+Test: css3/flexbox/floated-flexitem.html
+
+* css/StyleResolver.cpp:
+(WebCore::StyleResolver::adjustRenderStyle): Force NoFloat on flex items.
+
2012-07-30 Adrienne Walker e...@google.com
[chromium] Turn back on ScrollbarLayerChromium for Windows
Modified: trunk/Source/WebCore/css/StyleResolver.cpp (124063 => 124064)
--- trunk/Source/WebCore/css/StyleResolver.cpp 2012-07-30 18:37:18 UTC (rev 124063)
+++ trunk/Source/WebCore/css/StyleResolver.cpp 2012-07-30 18:39:53 UTC (rev 124064)
@@ -2143,8 +2143,10 @@
if (style-writingMode() != TopToBottomWritingMode (style-display() == BOX || style-display() == INLINE_BOX))
style-setWritingMode(TopToBottomWritingMode);
-if (e e-parentNode() e-parentNode()-renderer()
[webkit-changes] [124065] branches/safari-536.26-branch
Title: [124065] branches/safari-536.26-branch
Revision 124065
Author lforsch...@apple.com
Date 2012-07-30 11:44:44 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r117289. rdar://problem/11932472
Modified Paths
branches/safari-536.26-branch/LayoutTests/ChangeLog
branches/safari-536.26-branch/Source/WebCore/ChangeLog
branches/safari-536.26-branch/Source/WebCore/svg/SVGSVGElement.cpp
Added Paths
branches/safari-536.26-branch/LayoutTests/svg/custom/intersection-list-null-expected.txt
branches/safari-536.26-branch/LayoutTests/svg/custom/intersection-list-null.svg
Diff
Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (124064 => 124065)
--- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 18:39:53 UTC (rev 124064)
+++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 18:44:44 UTC (rev 124065)
@@ -1,5 +1,22 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 117289
+
+2012-05-16 Rob Buis rb...@rim.com
+
+SVGSVGElement checkIntersection and checkEnclosure Mem corruption
+https://bugs.webkit.org/show_bug.cgi?id=67923
+
+Reviewed by Nikolas Zimmermann.
+
+Add test to check that checkIntersection/checkEnclosure do not
+crash when null is used for the element parameter.
+
+* svg/custom/intersection-list-null-expected.txt: Added.
+* svg/custom/intersection-list-null.svg: Added.
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 117161
2012-05-15 Abhishek Arya infe...@chromium.org
Copied: branches/safari-536.26-branch/LayoutTests/svg/custom/intersection-list-null-expected.txt (from rev 117289, trunk/LayoutTests/svg/custom/intersection-list-null-expected.txt) (0 => 124065)
--- branches/safari-536.26-branch/LayoutTests/svg/custom/intersection-list-null-expected.txt (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/svg/custom/intersection-list-null-expected.txt 2012-07-30 18:44:44 UTC (rev 124065)
@@ -0,0 +1 @@
+PASS
Copied: branches/safari-536.26-branch/LayoutTests/svg/custom/intersection-list-null.svg (from rev 117289, trunk/LayoutTests/svg/custom/intersection-list-null.svg) (0 => 124065)
--- branches/safari-536.26-branch/LayoutTests/svg/custom/intersection-list-null.svg (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/svg/custom/intersection-list-null.svg 2012-07-30 18:44:44 UTC (rev 124065)
@@ -0,0 +1,14 @@
+?xml version=1.0 encoding=UTF-8?
+svg id=root xmlns=http://www.w3.org/2000/svg _onload_=runTest()
+ script
+function runTest() {
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+var root = document.documentElement;
+root.checkIntersection(null, root.createSVGRect());
+root.checkEnclosure(null, root.createSVGRect());
+}
+ /script
+ !-- This test passes if it does not crash. --
+ textPASS/text
+/svg
Modified: branches/safari-536.26-branch/Source/WebCore/ChangeLog (124064 => 124065)
--- branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 18:39:53 UTC (rev 124064)
+++ branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 18:44:44 UTC (rev 124065)
@@ -1,5 +1,24 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 117289
+
+2012-05-16 Rob Buis rb...@rim.com
+
+SVGSVGElement checkIntersection and checkEnclosure Mem corruption
+https://bugs.webkit.org/show_bug.cgi?id=67923
+
+Reviewed by Nikolas Zimmermann.
+
+Only call checkIntersection/checkEnclosure when we have a valid renderer.
+
+Test: svg/custom/intersection-list-null.svg
+
+* svg/SVGSVGElement.cpp:
+(WebCore::SVGSVGElement::checkIntersection):
+(WebCore::SVGSVGElement::checkEnclosure):
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 117161
2012-05-15 Abhishek Arya infe...@chromium.org
Modified: branches/safari-536.26-branch/Source/WebCore/svg/SVGSVGElement.cpp (124064 => 124065)
--- branches/safari-536.26-branch/Source/WebCore/svg/SVGSVGElement.cpp 2012-07-30 18:39:53 UTC (rev 124064)
+++ branches/safari-536.26-branch/Source/WebCore/svg/SVGSVGElement.cpp 2012-07-30 18:44:44 UTC (rev 124065)
@@ -371,11 +371,15 @@
bool SVGSVGElement::checkIntersection(SVGElement* element, const FloatRect rect) const
{
+if (!element)
+return false;
return RenderSVGModelObject::checkIntersection(element-renderer(), rect);
}
bool SVGSVGElement::checkEnclosure(SVGElement* element, const FloatRect rect) const
{
+if (!element)
+return false;
return RenderSVGModelObject::checkEnclosure(element-renderer(), rect);
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124066] branches/safari-536.26-branch
Title: [124066] branches/safari-536.26-branch
Revision 124066
Author lforsch...@apple.com
Date 2012-07-30 11:46:58 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r117304. rdar://problem/11942070
Modified Paths
branches/safari-536.26-branch/LayoutTests/ChangeLog
branches/safari-536.26-branch/Source/WebCore/ChangeLog
branches/safari-536.26-branch/Source/WebCore/html/HTMLAppletElement.cpp
Added Paths
branches/safari-536.26-branch/LayoutTests/java/inline-applet-crash-expected.txt
branches/safari-536.26-branch/LayoutTests/java/inline-applet-crash.html
Diff
Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (124065 => 124066)
--- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 18:44:44 UTC (rev 124065)
+++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 18:46:58 UTC (rev 124066)
@@ -1,5 +1,19 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 117304
+
+2012-05-16 Abhishek Arya infe...@chromium.org
+
+Missing RenderApplet cast check in HTMLAppletElement::renderWidgetForJSBindings.
+https://bugs.webkit.org/show_bug.cgi?id=86627
+
+Reviewed by Andreas Kling.
+
+* java/inline-applet-crash-expected.txt: Added.
+* java/inline-applet-crash.html: Added.
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 117289
2012-05-16 Rob Buis rb...@rim.com
Copied: branches/safari-536.26-branch/LayoutTests/java/inline-applet-crash-expected.txt (from rev 117304, trunk/LayoutTests/java/inline-applet-crash-expected.txt) (0 => 124066)
--- branches/safari-536.26-branch/LayoutTests/java/inline-applet-crash-expected.txt (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/java/inline-applet-crash-expected.txt 2012-07-30 18:46:58 UTC (rev 124066)
@@ -0,0 +1 @@
+Test passes if it does not crash.
Copied: branches/safari-536.26-branch/LayoutTests/java/inline-applet-crash.html (from rev 117304, trunk/LayoutTests/java/inline-applet-crash.html) (0 => 124066)
--- branches/safari-536.26-branch/LayoutTests/java/inline-applet-crash.html (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/java/inline-applet-crash.html 2012-07-30 18:46:58 UTC (rev 124066)
@@ -0,0 +1,30 @@
+!DOCTYPE html
+html
+Test passes if it does not crash.
+applet code=doesnotexist.class/applet
+script
+if (window.layoutTestController) {
+layoutTestController.overridePreference(WebKitJavaEnabled, 1);
+layoutTestController.dumpAsText();
+layoutTestController.waitUntilDone();
+}
+
+function walk(arr, currentPrefix, index, domNode) {
+if (!domNode)
+return;
+
+newPrefix = currentPrefix + _ + index;
+walk(arr, currentPrefix, index + 1, domNode.nextSibling);
+walk(arr, newPrefix, 0, domNode.firstChild);
+}
+
+function crash() {
+var temp = new Array();
+walk(temp, , 0, document.documentElement);
+if (window.layoutTestController)
+layoutTestController.notifyDone();
+}
+
+setTimeout(crash();, 0);
+/script
+/html
Modified: branches/safari-536.26-branch/Source/WebCore/ChangeLog (124065 => 124066)
--- branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 18:44:44 UTC (rev 124065)
+++ branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 18:46:58 UTC (rev 124066)
@@ -1,5 +1,21 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 117304
+
+2012-05-16 Abhishek Arya infe...@chromium.org
+
+Missing RenderApplet cast check in HTMLAppletElement::renderWidgetForJSBindings.
+https://bugs.webkit.org/show_bug.cgi?id=86627
+
+Reviewed by Andreas Kling.
+
+Test: java/inline-applet-crash.html
+
+* html/HTMLAppletElement.cpp:
+(WebCore::HTMLAppletElement::renderWidgetForJSBindings):
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 117289
2012-05-16 Rob Buis rb...@rim.com
Modified: branches/safari-536.26-branch/Source/WebCore/html/HTMLAppletElement.cpp (124065 => 124066)
--- branches/safari-536.26-branch/Source/WebCore/html/HTMLAppletElement.cpp 2012-07-30 18:44:44 UTC (rev 124065)
+++ branches/safari-536.26-branch/Source/WebCore/html/HTMLAppletElement.cpp 2012-07-30 18:46:58 UTC (rev 124066)
@@ -115,10 +115,11 @@
if (!canEmbedJava())
return 0;
+if (!renderer() || !renderer()-isApplet())
+return 0;
+
RenderApplet* applet = toRenderApplet(renderer());
-if (applet)
-applet-createWidgetIfNecessary();
-
+applet-createWidgetIfNecessary();
return applet;
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124067] trunk/Source/WebCore
Title: [124067] trunk/Source/WebCore
Revision 124067
Author commit-qu...@webkit.org
Date 2012-07-30 11:49:43 -0700 (Mon, 30 Jul 2012)
Log Message
Web Inspector: Rename Databases to Web SQL
https://bugs.webkit.org/show_bug.cgi?id=92646
Patch by Paul Irish paul.ir...@gmail.com on 2012-07-30
Reviewed by Pavel Feldman.
Renamed Databases to Web SQL. Drive-by fix for EmptyView
selection.
* English.lproj/localizedStrings.js:
* inspector/front-end/EmptyView.js:
* inspector/front-end/ResourcesPanel.js:
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/English.lproj/localizedStrings.js
trunk/Source/WebCore/inspector/front-end/EmptyView.js
trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js
Diff
Modified: trunk/Source/WebCore/ChangeLog (124066 => 124067)
--- trunk/Source/WebCore/ChangeLog 2012-07-30 18:46:58 UTC (rev 124066)
+++ trunk/Source/WebCore/ChangeLog 2012-07-30 18:49:43 UTC (rev 124067)
@@ -1,3 +1,17 @@
+2012-07-30 Paul Irish paul.ir...@gmail.com
+
+Web Inspector: Rename Databases to Web SQL
+https://bugs.webkit.org/show_bug.cgi?id=92646
+
+Reviewed by Pavel Feldman.
+
+Renamed Databases to Web SQL. Drive-by fix for EmptyView
+selection.
+
+* English.lproj/localizedStrings.js:
+* inspector/front-end/EmptyView.js:
+* inspector/front-end/ResourcesPanel.js:
+
2012-07-30 Tony Chang t...@chromium.org
new flexbox should ignore float set on flexitems
Modified: trunk/Source/WebCore/English.lproj/localizedStrings.js (124066 => 124067)
--- trunk/Source/WebCore/English.lproj/localizedStrings.js 2012-07-30 18:46:58 UTC (rev 124066)
+++ trunk/Source/WebCore/English.lproj/localizedStrings.js 2012-07-30 18:49:43 UTC (rev 124067)
@@ -143,7 +143,7 @@
localizedStrings[Copy Response Headers] = Copy Response Headers;
localizedStrings[Copy XPath] = Copy XPath;
localizedStrings[Count] = Count;
-localizedStrings[Databases] = Databases;
+localizedStrings[Web SQL] = Web SQL;
localizedStrings[DNS Lookup] = DNS Lookup;
localizedStrings[DOMContent event fired] = DOMContent event fired;
localizedStrings[DOMContent event] = DOMContent event;
Modified: trunk/Source/WebCore/inspector/front-end/EmptyView.js (124066 => 124067)
--- trunk/Source/WebCore/inspector/front-end/EmptyView.js 2012-07-30 18:46:58 UTC (rev 124066)
+++ trunk/Source/WebCore/inspector/front-end/EmptyView.js 2012-07-30 18:49:43 UTC (rev 124067)
@@ -48,7 +48,7 @@
set text(text)
{
this._text = text;
-if (this.visible)
+if (this.isShowing())
this.element.textContent = this._text;
},
}
Modified: trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js (124066 => 124067)
--- trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js 2012-07-30 18:46:58 UTC (rev 124066)
+++ trunk/Source/WebCore/inspector/front-end/ResourcesPanel.js 2012-07-30 18:49:43 UTC (rev 124067)
@@ -49,7 +49,7 @@
this.resourcesListTreeElement = new WebInspector.StorageCategoryTreeElement(this, WebInspector.UIString(Frames), Frames, [frame-storage-tree-item]);
this.sidebarTree.appendChild(this.resourcesListTreeElement);
-this.databasesListTreeElement = new WebInspector.StorageCategoryTreeElement(this, WebInspector.UIString(Databases), Databases, [database-storage-tree-item]);
+this.databasesListTreeElement = new WebInspector.StorageCategoryTreeElement(this, WebInspector.UIString(Web SQL), Databases, [database-storage-tree-item]);
this.sidebarTree.appendChild(this.databasesListTreeElement);
this.indexedDBListTreeElement = new WebInspector.IndexedDBTreeElement(this);
@@ -1619,7 +1619,7 @@
if (this._view)
this._view.update(database);
-
+
this._updateTooltip();
},
@@ -1715,13 +1715,13 @@
if (this._view)
this._view.update(this._objectStore);
-
+
this._updateTooltip();
},
_updateTooltip: function()
{
-
+
var keyPathString = this._objectStore.keyPathString;
var tooltipString = keyPathString !== null ? (WebInspector.UIString(Key path: ) + keyPathString) : ;
if (this._objectStore.autoIncrement)
@@ -1793,7 +1793,7 @@
if (this._view)
this._view.update(this._index);
-
+
this._updateTooltip();
},
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124068] trunk/Source/WebKit2
Title: [124068] trunk/Source/WebKit2
Revision 124068
Author par...@webkit.org
Date 2012-07-30 11:49:49 -0700 (Mon, 30 Jul 2012)
Log Message
Unreviewed, rolling out r123983.
http://trac.webkit.org/changeset/123983
https://bugs.webkit.org/show_bug.cgi?id=92663
EFL build is broken when unit tests are enabled (Requested by
paroga on #webkit).
Patch by Sheriff Bot webkit.review@gmail.com on 2012-07-30
* CMakeLists.txt:
* PlatformEfl.cmake:
Modified Paths
trunk/Source/WebKit2/CMakeLists.txt
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/PlatformEfl.cmake
Diff
Modified: trunk/Source/WebKit2/CMakeLists.txt (124067 => 124068)
--- trunk/Source/WebKit2/CMakeLists.txt 2012-07-30 18:49:43 UTC (rev 124067)
+++ trunk/Source/WebKit2/CMakeLists.txt 2012-07-30 18:49:49 UTC (rev 124068)
@@ -98,7 +98,6 @@
${_javascript_CORE_DIR}/runtime
${WTF_DIR}
${DERIVED_SOURCES_DIR}
-${DERIVED_SOURCES_DIR}/ForwardingHeaders
${DERIVED_SOURCES_WEBCORE_DIR}
${DERIVED_SOURCES_WEBKIT2_DIR}
${DERIVED_SOURCES_WEBKIT2_DIR}/include
@@ -552,17 +551,8 @@
${WebCore_LIBRARY_NAME}
)
-SET(WebKit2_FORWARDING_HEADERS_DIRECTORIES
-Shared/API/c
-UIProcess/API/C
-UIProcess/API/cpp
-WebProcess/InjectedBundle/API/c
-)
-
WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS()
-WEBKIT_CREATE_FORWARDING_HEADERS(WebKit2 DIRECTORIES ${WebKit2_FORWARDING_HEADERS_DIRECTORIES})
-
# Create _javascript_ C++ code given an IDL input
FOREACH (_file ${WebKit2_MESSAGES_IN_FILES})
GET_FILENAME_COMPONENT (_name ${_file} NAME_WE)
@@ -582,6 +572,8 @@
ADD_LIBRARY(${WebKit2_LIBRARY_NAME} ${WebKit2_LIBRARY_TYPE} ${WebKit2_SOURCES})
ADD_DEPENDENCIES(${WebKit2_LIBRARY_NAME} ${WebCore_LIBRARY_NAME})
+ADD_DEPENDENCIES(${WebKit2_LIBRARY_NAME} ${ForwardingHeaders_NAME})
+ADD_DEPENDENCIES(${WebKit2_LIBRARY_NAME} ${ForwardingNetworkHeaders_NAME})
TARGET_LINK_LIBRARIES(${WebKit2_LIBRARY_NAME} ${WebKit2_LIBRARIES})
SET_TARGET_PROPERTIES(${WebKit2_LIBRARY_NAME} PROPERTIES FOLDER WebKit)
SET_TARGET_PROPERTIES(${WebKit2_LIBRARY_NAME} PROPERTIES LINK_INTERFACE_LIBRARIES )
Modified: trunk/Source/WebKit2/ChangeLog (124067 => 124068)
--- trunk/Source/WebKit2/ChangeLog 2012-07-30 18:49:43 UTC (rev 124067)
+++ trunk/Source/WebKit2/ChangeLog 2012-07-30 18:49:49 UTC (rev 124068)
@@ -1,5 +1,17 @@
2012-07-30 Sheriff Bot webkit.review@gmail.com
+Unreviewed, rolling out r123983.
+http://trac.webkit.org/changeset/123983
+https://bugs.webkit.org/show_bug.cgi?id=92663
+
+EFL build is broken when unit tests are enabled (Requested by
+paroga on #webkit).
+
+* CMakeLists.txt:
+* PlatformEfl.cmake:
+
+2012-07-30 Sheriff Bot webkit.review@gmail.com
+
Unreviewed, rolling out r123966 and r123967.
http://trac.webkit.org/changeset/123966
http://trac.webkit.org/changeset/123967
Modified: trunk/Source/WebKit2/PlatformEfl.cmake (124067 => 124068)
--- trunk/Source/WebKit2/PlatformEfl.cmake 2012-07-30 18:49:43 UTC (rev 124067)
+++ trunk/Source/WebKit2/PlatformEfl.cmake 2012-07-30 18:49:49 UTC (rev 124068)
@@ -156,13 +156,6 @@
${LIBSOUP24_LIBRARIES}
)
-LIST (APPEND WebKit2_FORWARDING_HEADERS_DIRECTORIES
-Shared/API/c/efl
-Shared/API/c/soup
-UIProcess/API/C/efl
-UIProcess/API/C/soup
-)
-
LIST (APPEND WebProcess_SOURCES
efl/MainEfl.cpp
)
@@ -180,6 +173,16 @@
ADD_DEFINITIONS(-DDEFAULT_THEME_PATH=\${CMAKE_INSTALL_PREFIX}/${DATA_INSTALL_DIR}/themes\)
+ADD_CUSTOM_TARGET(forwarding-headerEfl
+COMMAND ${PERL_EXECUTABLE} ${WEBKIT2_DIR}/Scripts/generate-forwarding-headers.pl ${WEBKIT2_DIR} ${DERIVED_SOURCES_WEBKIT2_DIR}/include efl
+)
+SET(ForwardingHeaders_NAME forwarding-headerEfl)
+
+ADD_CUSTOM_TARGET(forwarding-headerSoup
+COMMAND ${PERL_EXECUTABLE} ${WEBKIT2_DIR}/Scripts/generate-forwarding-headers.pl ${WEBKIT2_DIR} ${DERIVED_SOURCES_WEBKIT2_DIR}/include soup
+)
+SET(ForwardingNetworkHeaders_NAME forwarding-headerSoup)
+
CONFIGURE_FILE(efl/ewebkit2.pc.in ${CMAKE_BINARY_DIR}/WebKit2/efl/ewebkit2.pc @ONLY)
SET (EWebKit2_HEADERS
${CMAKE_CURRENT_SOURCE_DIR}/UIProcess/API/efl/EWebKit2.h
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124069] trunk/Source/WTF
Title: [124069] trunk/Source/WTF
Revision 124069
Author par...@webkit.org
Date 2012-07-30 11:53:42 -0700 (Mon, 30 Jul 2012)
Log Message
Add special export macro for string related functions
https://bugs.webkit.org/show_bug.cgi?id=92624
Reviewed by Hajime Morita.
The windows port compiles string related code into every binary for performance reasons (see r59187).
Add the WTF_EXPORT_STRING_API define to allow this behaviour with export macros too.
* wtf/ExportMacros.h:
* wtf/text/AtomicString.h:
(AtomicString):
* wtf/text/StringImpl.h:
(StringImpl):
(WTF):
* wtf/text/WTFString.h:
(WTF):
(String):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/ExportMacros.h
trunk/Source/WTF/wtf/text/AtomicString.h
trunk/Source/WTF/wtf/text/StringImpl.h
trunk/Source/WTF/wtf/text/WTFString.h
Diff
Modified: trunk/Source/WTF/ChangeLog (124068 => 124069)
--- trunk/Source/WTF/ChangeLog 2012-07-30 18:49:49 UTC (rev 124068)
+++ trunk/Source/WTF/ChangeLog 2012-07-30 18:53:42 UTC (rev 124069)
@@ -1,5 +1,25 @@
2012-07-30 Patrick Gansterer par...@webkit.org
+Add special export macro for string related functions
+https://bugs.webkit.org/show_bug.cgi?id=92624
+
+Reviewed by Hajime Morita.
+
+The windows port compiles string related code into every binary for performance reasons (see r59187).
+Add the WTF_EXPORT_STRING_API define to allow this behaviour with export macros too.
+
+* wtf/ExportMacros.h:
+* wtf/text/AtomicString.h:
+(AtomicString):
+* wtf/text/StringImpl.h:
+(StringImpl):
+(WTF):
+* wtf/text/WTFString.h:
+(WTF):
+(String):
+
+2012-07-30 Patrick Gansterer par...@webkit.org
+
Replace UnicodeWinCE with UnicodeWchar
https://bugs.webkit.org/show_bug.cgi?id=92539
Modified: trunk/Source/WTF/wtf/ExportMacros.h (124068 => 124069)
--- trunk/Source/WTF/wtf/ExportMacros.h 2012-07-30 18:49:49 UTC (rev 124068)
+++ trunk/Source/WTF/wtf/ExportMacros.h 2012-07-30 18:53:42 UTC (rev 124069)
@@ -141,6 +141,12 @@
#define WTF_EXPORT_PRIVATE_NO_RTTI WTF_EXPORT_PRIVATE
#endif
+#if PLATFORM(WIN)
+#define WTF_EXPORT_STRING_API
+#else
+#define WTF_EXPORT_STRING_API WTF_EXPORT_PRIVATE
+#endif
+
#define WTF_EXPORT_HIDDEN WTF_HIDDEN
#define HIDDEN_INLINE WTF_EXPORT_HIDDEN inline
Modified: trunk/Source/WTF/wtf/text/AtomicString.h (124068 => 124069)
--- trunk/Source/WTF/wtf/text/AtomicString.h 2012-07-30 18:49:49 UTC (rev 124068)
+++ trunk/Source/WTF/wtf/text/AtomicString.h 2012-07-30 18:53:42 UTC (rev 124069)
@@ -79,7 +79,7 @@
AtomicString(WTF::HashTableDeletedValueType) : m_string(WTF::HashTableDeletedValue) { }
bool isHashTableDeletedValue() const { return m_string.isHashTableDeletedValue(); }
-WTF_EXPORT_PRIVATE static AtomicStringImpl* find(const UChar* s, unsigned length, unsigned existingHash);
+WTF_EXPORT_STRING_API static AtomicStringImpl* find(const UChar*, unsigned length, unsigned existingHash);
operator const String() const { return m_string; }
const String string() const { return m_string; };
@@ -119,7 +119,7 @@
bool endsWith(const char (prefix)[matchLength], bool caseSensitive = true) const
{ return m_string.endsWithmatchLength(prefix, caseSensitive); }
-WTF_EXPORT_PRIVATE AtomicString lower() const;
+WTF_EXPORT_STRING_API AtomicString lower() const;
AtomicString upper() const { return AtomicString(impl()-upper()); }
int toInt(bool* ok = 0) const { return m_string.toInt(ok); }
@@ -156,22 +156,22 @@
private:
String m_string;
-WTF_EXPORT_PRIVATE static PassRefPtrStringImpl add(const LChar*);
+WTF_EXPORT_STRING_API static PassRefPtrStringImpl add(const LChar*);
ALWAYS_INLINE static PassRefPtrStringImpl add(const char* s) { return add(reinterpret_castconst LChar*(s)); };
-WTF_EXPORT_PRIVATE static PassRefPtrStringImpl add(const UChar*, unsigned length);
+WTF_EXPORT_STRING_API static PassRefPtrStringImpl add(const UChar*, unsigned length);
ALWAYS_INLINE static PassRefPtrStringImpl add(const char* s, unsigned length) { return add(reinterpret_castconst char*(s), length); };
-WTF_EXPORT_PRIVATE static PassRefPtrStringImpl add(const UChar*, unsigned length, unsigned existingHash);
-WTF_EXPORT_PRIVATE static PassRefPtrStringImpl add(const UChar*);
-WTF_EXPORT_PRIVATE static PassRefPtrStringImpl add(StringImpl*, unsigned offset, unsigned length);
+WTF_EXPORT_STRING_API static PassRefPtrStringImpl add(const UChar*, unsigned length, unsigned existingHash);
+WTF_EXPORT_STRING_API static PassRefPtrStringImpl add(const UChar*);
+WTF_EXPORT_STRING_API static PassRefPtrStringImpl add(StringImpl*, unsigned offset, unsigned length);
ALWAYS_INLINE static PassRefPtrStringImpl add(StringImpl* r)
{
if (!r || r-isAtomic())
return r;
return addSlowCase(r);
}
-WTF_EXPORT_PRIVATE static
[webkit-changes] [124070] trunk/LayoutTests
Title: [124070] trunk/LayoutTests Revision 124070 Author pkast...@chromium.org Date 2012-07-30 11:54:59 -0700 (Mon, 30 Jul 2012) Log Message [Chromium] Rebaseline tests for Skia changes. http://crbug.com/130283 http://crbug.com/131188 Unreviewed, test expectations update. * platform/chromium-linux/css3/filters/effect-combined-hw-expected.png: * platform/chromium-linux/css3/filters/effect-saturate-hw-expected.png: * platform/chromium-linux/css3/filters/effect-sepia-hw-expected.png: * platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png: * platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png: * platform/chromium-mac/css3/filters/effect-combined-hw-expected.png: * platform/chromium-mac/css3/filters/effect-grayscale-hw-expected.png: * platform/chromium-mac/css3/filters/effect-hue-rotate-hw-expected.png: * platform/chromium-mac/css3/filters/effect-saturate-hw-expected.png: * platform/chromium-mac/css3/filters/effect-sepia-hw-expected.png: * platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png: * platform/chromium-mac/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt: Removed. * platform/chromium-win/css3/filters/effect-combined-hw-expected.png: * platform/chromium-win/css3/filters/effect-grayscale-hw-expected.png: * platform/chromium-win/css3/filters/effect-hue-rotate-hw-expected.png: * platform/chromium-win/css3/filters/effect-saturate-hw-expected.png: * platform/chromium-win/css3/filters/effect-sepia-hw-expected.png: * platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png: * platform/chromium-win/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-linux/css3/filters/effect-combined-hw-expected.png trunk/LayoutTests/platform/chromium-linux/css3/filters/effect-saturate-hw-expected.png trunk/LayoutTests/platform/chromium-linux/css3/filters/effect-sepia-hw-expected.png trunk/LayoutTests/platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png trunk/LayoutTests/platform/chromium-mac/css3/filters/effect-combined-hw-expected.png trunk/LayoutTests/platform/chromium-mac/css3/filters/effect-grayscale-hw-expected.png trunk/LayoutTests/platform/chromium-mac/css3/filters/effect-hue-rotate-hw-expected.png trunk/LayoutTests/platform/chromium-mac/css3/filters/effect-saturate-hw-expected.png trunk/LayoutTests/platform/chromium-mac/css3/filters/effect-sepia-hw-expected.png trunk/LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png trunk/LayoutTests/platform/chromium-win/css3/filters/effect-combined-hw-expected.png trunk/LayoutTests/platform/chromium-win/css3/filters/effect-grayscale-hw-expected.png trunk/LayoutTests/platform/chromium-win/css3/filters/effect-hue-rotate-hw-expected.png trunk/LayoutTests/platform/chromium-win/css3/filters/effect-saturate-hw-expected.png trunk/LayoutTests/platform/chromium-win/css3/filters/effect-sepia-hw-expected.png trunk/LayoutTests/platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png trunk/LayoutTests/platform/chromium-win/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt Removed Paths trunk/LayoutTests/platform/chromium-mac/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt Diff Modified: trunk/LayoutTests/ChangeLog (124069 => 124070) --- trunk/LayoutTests/ChangeLog 2012-07-30 18:53:42 UTC (rev 124069) +++ trunk/LayoutTests/ChangeLog 2012-07-30 18:54:59 UTC (rev 124070) @@ -1,3 +1,31 @@ +2012-07-30 Peter Kasting pkast...@google.com + +[Chromium] Rebaseline tests for Skia changes. +http://crbug.com/130283 +http://crbug.com/131188 + +Unreviewed, test expectations update. + +* platform/chromium-linux/css3/filters/effect-combined-hw-expected.png: +* platform/chromium-linux/css3/filters/effect-saturate-hw-expected.png: +* platform/chromium-linux/css3/filters/effect-sepia-hw-expected.png: +* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png: +* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png: +* platform/chromium-mac/css3/filters/effect-combined-hw-expected.png: +* platform/chromium-mac/css3/filters/effect-grayscale-hw-expected.png: +* platform/chromium-mac/css3/filters/effect-hue-rotate-hw-expected.png: +* platform/chromium-mac/css3/filters/effect-saturate-hw-expected.png: +* platform/chromium-mac/css3/filters/effect-sepia-hw-expected.png: +* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/fillrect_gradient-expected.png: +
[webkit-changes] [124071] trunk/Tools
Title: [124071] trunk/Tools Revision 124071 Author dpra...@chromium.org Date 2012-07-30 11:55:10 -0700 (Mon, 30 Jul 2012) Log Message After r123895, new-run-webkit-tests can fail with TypeError when a test crashes https://bugs.webkit.org/show_bug.cgi?id=92664 Reviewed by Michael Saboff. Updated to handle crash_logs being returned as a tuple of (stderr, crash_log). * Scripts/webkitpy/layout_tests/port/mac.py: (MacPort.look_for_new_crash_logs): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py Diff Modified: trunk/Tools/ChangeLog (124070 => 124071) --- trunk/Tools/ChangeLog 2012-07-30 18:54:59 UTC (rev 124070) +++ trunk/Tools/ChangeLog 2012-07-30 18:55:10 UTC (rev 124071) @@ -1,3 +1,15 @@ +2012-07-30 Dirk Pranke dpra...@chromium.org + +After r123895, new-run-webkit-tests can fail with TypeError when a test crashes +https://bugs.webkit.org/show_bug.cgi?id=92664 + +Reviewed by Michael Saboff. + +Updated to handle crash_logs being returned as a tuple of (stderr, crash_log). + +* Scripts/webkitpy/layout_tests/port/mac.py: +(MacPort.look_for_new_crash_logs): + 2012-07-30 Stephen White senorbla...@chromium.org Added a SkiaGraphics definition to the watchlist file; cc'ed myself Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py (124070 => 124071) --- trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py 2012-07-30 18:54:59 UTC (rev 124070) +++ trunk/Tools/Scripts/webkitpy/layout_tests/port/mac.py 2012-07-30 18:55:10 UTC (rev 124071) @@ -235,7 +235,7 @@ for (test_name, process_name, pid) in crashed_processes: # Passing None for output. This is a second pass after the test finished so # if the output had any loggine we would have already collected it. -crash_log = self._get_crash_log(process_name, pid, None, None, start_time, wait_for_log=False) +crash_log = self._get_crash_log(process_name, pid, None, None, start_time, wait_for_log=False)[1] if not crash_log: continue crash_logs[test_name] = crash_log ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124072] branches/safari-536.26-branch
Title: [124072] branches/safari-536.26-branch
Revision 124072
Author lforsch...@apple.com
Date 2012-07-30 12:26:39 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r117309. rdar://problem/11942073
Modified Paths
branches/safari-536.26-branch/LayoutTests/ChangeLog
branches/safari-536.26-branch/Source/WebCore/ChangeLog
branches/safari-536.26-branch/Source/WebCore/rendering/RenderTableCell.cpp
Added Paths
branches/safari-536.26-branch/LayoutTests/fast/css-generated-content/first-letter-table-cell-format-block-crash-expected.txt
branches/safari-536.26-branch/LayoutTests/fast/css-generated-content/first-letter-table-cell-format-block-crash.html
Diff
Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (124071 => 124072)
--- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 18:55:10 UTC (rev 124071)
+++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 19:26:39 UTC (rev 124072)
@@ -1,5 +1,21 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 117309
+
+2012-05-16 Ken Buchanan ke...@chromium.org
+
+Crash due to first-letter not getting computed on RenderTableCell
+https://bugs.webkit.org/show_bug.cgi?id=86133
+
+Reviewed by Abhishek Arya.
+
+Test to exercise crashing condition in bug 86133.
+
+* fast/css-generated-content/first-letter-table-cell-format-block-crash-expected.txt: Added
+* fast/css-generated-content/first-letter-table-cell-format-block-crash.html: Added
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 117304
2012-05-16 Abhishek Arya infe...@chromium.org
Copied: branches/safari-536.26-branch/LayoutTests/fast/css-generated-content/first-letter-table-cell-format-block-crash-expected.txt (from rev 117309, trunk/LayoutTests/fast/css-generated-content/first-letter-table-cell-format-block-crash-expected.txt) (0 => 124072)
--- branches/safari-536.26-branch/LayoutTests/fast/css-generated-content/first-letter-table-cell-format-block-crash-expected.txt (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/fast/css-generated-content/first-letter-table-cell-format-block-crash-expected.txt 2012-07-30 19:26:39 UTC (rev 124072)
@@ -0,0 +1 @@
+PASS, if no crash or assert in debug build.
Copied: branches/safari-536.26-branch/LayoutTests/fast/css-generated-content/first-letter-table-cell-format-block-crash.html (from rev 117309, trunk/LayoutTests/fast/css-generated-content/first-letter-table-cell-format-block-crash.html) (0 => 124072)
--- branches/safari-536.26-branch/LayoutTests/fast/css-generated-content/first-letter-table-cell-format-block-crash.html (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/fast/css-generated-content/first-letter-table-cell-format-block-crash.html 2012-07-30 19:26:39 UTC (rev 124072)
@@ -0,0 +1,40 @@
+!DOCTYPE html
+html
+style
+#test0 {
+-webkit-column-count:2;
+display: table-cell;
+}
+#test0::first-letter {
+background-size: auto;
+}
+#test1 {
+float: right;
+}
+/style
+script
+_onload_ = function() {
+test0=document.createElement('div');
+test0.setAttribute('id', 'test0');
+document.body.appendChild(test0);
+test1=document.createElement('div');
+test1.setAttribute('id', 'test1');
+test0.appendChild(test1);
+test0.appendChild(document.createTextNode(unescape('%u3200A')));
+document.designMode = 'on';
+window.getSelection().setBaseAndExtent(test1, 0, test1, 0);
+document.execCommand('InsertLineBreak');
+document.execCommand('selectall');
+document.execCommand('strikethrough');
+document.execCommand('FormatBlock', false, ''+'pre');
+
+document.body.offsetTop;
+document.body.innerHTML = PASS, if no crash or assert in debug build.
+
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+}
+/script
+body
+/body
+/html
Modified: branches/safari-536.26-branch/Source/WebCore/ChangeLog (124071 => 124072)
--- branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 18:55:10 UTC (rev 124071)
+++ branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 19:26:39 UTC (rev 124072)
@@ -1,5 +1,30 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 117309
+
+2012-05-16 Ken Buchanan ke...@chromium.org
+
+Crash due to first-letter not getting computed on RenderTableCell
+https://bugs.webkit.org/show_bug.cgi?id=86133
+
+Reviewed by Abhishek Arya.
+
+RenderTableCell overrides RenderBlock::layout() but doesn't call
+updateFirstLetter() in it. This is normally not a problem because
+updateFirstLetter() gets called during preferred logical width
+computation, but there exist rare occasions when layout of the table
+cell happens without preferred logical widths being dirty,
[webkit-changes] [124073] branches/safari-536.26-branch/Source/WebCore
Title: [124073] branches/safari-536.26-branch/Source/WebCore
Revision 124073
Author lforsch...@apple.com
Date 2012-07-30 12:32:12 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r117376. rdar://problem/11942074
Modified Paths
branches/safari-536.26-branch/Source/WebCore/ChangeLog
branches/safari-536.26-branch/Source/WebCore/loader/cache/CachedImage.cpp
branches/safari-536.26-branch/Source/WebCore/loader/cache/CachedImage.h
Diff
Modified: branches/safari-536.26-branch/Source/WebCore/ChangeLog (124072 => 124073)
--- branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 19:26:39 UTC (rev 124072)
+++ branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 19:32:12 UTC (rev 124073)
@@ -1,5 +1,28 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 117376
+
+2012-05-16 James Robinson jam...@chromium.org
+
+CachedImage does not clear the ImageObserver pointer when dropping its Image ref
+https://bugs.webkit.org/show_bug.cgi?id=86689
+
+Reviewed by Eric Seidel.
+
+Image instances keep a weak pointer to their ImageObserver, which may be null. CachedImage is an ImageObserver
+and holds a RefPtrImage m_image. When CachedImage initializes its m_image to either an SVGImage or BitmapImage,
+it sets itself as that Image's ImageObserver. However, CachedImage never clears the ImageObserver pointer, even
+when dropping its reference to the Image. This means if other code holds a RefPtrImage there is no promise
+that calls on that Image will be valid. This patch clears the CachedImage::m_image's ImageObserver pointer
+whenever the CachedImage drops its reference. Image already has null checks for its m_imageObserver so this is
+always a safe operation.
+
+* loader/cache/CachedImage.cpp:
+(WebCore::CachedImage::~CachedImage):
+(WebCore::CachedImage::clear):
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 117309
2012-05-16 Ken Buchanan ke...@chromium.org
Modified: branches/safari-536.26-branch/Source/WebCore/loader/cache/CachedImage.cpp (124072 => 124073)
--- branches/safari-536.26-branch/Source/WebCore/loader/cache/CachedImage.cpp 2012-07-30 19:26:39 UTC (rev 124072)
+++ branches/safari-536.26-branch/Source/WebCore/loader/cache/CachedImage.cpp 2012-07-30 19:32:12 UTC (rev 124073)
@@ -75,6 +75,7 @@
CachedImage::~CachedImage()
{
+clearImage();
}
void CachedImage::decodedDataDeletionTimerFired(TimerCachedImage*)
@@ -302,7 +303,7 @@
#if ENABLE(SVG)
m_svgImageCache.clear();
#endif
-m_image = 0;
+clearImage();
setEncodedSize(0);
}
@@ -328,6 +329,15 @@
m_image = BitmapImage::create(this);
}
+inline void CachedImage::clearImage()
+{
+// If our Image has an observer, it's always us so we need to clear the back pointer
+// before dropping our reference.
+if (m_image)
+m_image-setImageObserver(0);
+m_image.clear();
+}
+
size_t CachedImage::maximumDecodedImageSize()
{
if (!m_loader || m_loader-reachedTerminalState())
Modified: branches/safari-536.26-branch/Source/WebCore/loader/cache/CachedImage.h (124072 => 124073)
--- branches/safari-536.26-branch/Source/WebCore/loader/cache/CachedImage.h 2012-07-30 19:26:39 UTC (rev 124072)
+++ branches/safari-536.26-branch/Source/WebCore/loader/cache/CachedImage.h 2012-07-30 19:32:12 UTC (rev 124073)
@@ -98,6 +98,7 @@
void clear();
void createImage();
+void clearImage();
size_t maximumDecodedImageSize();
// If not null, changeRect is the changed part of the image.
void notifyObservers(const IntRect* changeRect = 0);
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124074] branches/safari-536.26-branch
Title: [124074] branches/safari-536.26-branch Revision 124074 Author lforsch...@apple.com Date 2012-07-30 12:49:44 -0700 (Mon, 30 Jul 2012) Log Message Merged r117957. rdar://problem/11942079 Modified Paths branches/safari-536.26-branch/LayoutTests/ChangeLog branches/safari-536.26-branch/Source/WebCore/ChangeLog branches/safari-536.26-branch/Source/WebCore/dom/EventDispatcher.cpp branches/safari-536.26-branch/Source/WebCore/page/EventHandler.cpp Added Paths branches/safari-536.26-branch/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-expected.txt branches/safari-536.26-branch/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching.html Diff Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (124073 => 124074) --- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 19:32:12 UTC (rev 124073) +++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 19:49:44 UTC (rev 124074) @@ -1,5 +1,18 @@ 2012-07-30 Lucas Forschler lforsch...@apple.com +Merge 117957 + +2012-05-22 Hayato Ito hay...@chromium.org + +Fix crashes when a mouse points a svg element in shadow DOM subtree. +https://bugs.webkit.org/show_bug.cgi?id=86795 + +Reviewed by Nikolas Zimmermann. + +* fast/dom/shadow/shadow-dom-event-dispatching.html: + +2012-07-30 Lucas Forschler lforsch...@apple.com + Merge 117309 2012-05-16 Ken Buchanan ke...@chromium.org Copied: branches/safari-536.26-branch/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-expected.txt (from rev 117394, trunk/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-expected.txt) (0 => 124074) --- branches/safari-536.26-branch/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-expected.txt (rev 0) +++ branches/safari-536.26-branch/LayoutTests/fast/dom/shadow/shadow-dom-event-dispatching-expected.txt 2012-07-30 19:49:44 UTC (rev 124074) @@ -0,0 +1,264 @@ +Tests to ensure that event dispatching behaves as the Shadow DOM spec describes. + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + + + +Composed Shadow Tree will be: +DIV id=sandbox + DIV id=top + DIV id=shadow-host + DIV id=distributed-light-child + DIV id=shadow-root-child + + +Moving mouse from shadow-host to shadow-host/shadow-root-child + + mouseout + + mouseover + @shadow-root-child (target: shadow-root-child) (related: shadow-host) + @shadow-root (target: shadow-root-child) (related: shadow-host) + +Moving mouse from shadow-host/shadow-root-child to shadow-host + + mouseout + @shadow-root-child (target: shadow-root-child) (related: shadow-host) + @shadow-root (target: shadow-root-child) (related: shadow-host) + + mouseover + +Moving mouse from shadow-host to distributed-light-child + + mouseout + @shadow-host (target: shadow-host) (related: distributed-light-child) + @top (target: shadow-host) (related: distributed-light-child) + + mouseover + @distributed-light-child (target: distributed-light-child) (related: shadow-host) + @content (target: content) (related: shadow-host) + @shadow-root (target: content) (related: shadow-host) + @shadow-host (target: distributed-light-child) (related: shadow-host) + @top (target: distributed-light-child) (related: shadow-host) + +Moving mouse from distributed-light-child to shadow-host + + mouseout + @distributed-light-child (target: distributed-light-child) (related: shadow-host) + @content (target: content) (related: shadow-host) + @shadow-root (target: content) (related: shadow-host) + @shadow-host (target: distributed-light-child) (related: shadow-host) + @top (target: distributed-light-child) (related: shadow-host) + + mouseover + @shadow-host (target: shadow-host) (related: distributed-light-child) + @top (target: shadow-host) (related: distributed-light-child) + +Moving mouse from shadow-host/shadow-root-child to distributed-light-child + + mouseout + @shadow-root-child (target: shadow-root-child) (related: content) + @shadow-root (target: shadow-root-child) (related: content) + @shadow-host (target: shadow-host) (related: distributed-light-child) + @top (target: shadow-host) (related: distributed-light-child) + + mouseover + @distributed-light-child (target: distributed-light-child) (related: shadow-host) + @content (target: content) (related: shadow-root-child) + @shadow-root (target: content) (related: shadow-root-child) + @shadow-host (target: distributed-light-child) (related: shadow-host) + @top (target: distributed-light-child) (related: shadow-host) + +Moving mouse from distributed-light-child to shadow-host/shadow-root-child + + mouseout + @distributed-light-child (target: distributed-light-child) (related: shadow-host) + @content (target: content) (related: shadow-root-child) + @shadow-root (target: content) (related:
[webkit-changes] [124075] trunk/LayoutTests
Title: [124075] trunk/LayoutTests Revision 124075 Author senorbla...@chromium.org Date 2012-07-30 12:51:56 -0700 (Mon, 30 Jul 2012) Log Message [chromium] Unreviewed gardening. Rebaseline another test affected by r124042. * platform/chromium-linux-x86/fast/gradients: Removed. * platform/chromium-linux/fast/gradients/background-clipped-expected.png: * platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.png: * platform/chromium-mac/fast/gradients/background-clipped-expected.png: * platform/chromium/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium/TestExpectations trunk/LayoutTests/platform/chromium-linux/fast/gradients/background-clipped-expected.png trunk/LayoutTests/platform/chromium-mac/fast/gradients/background-clipped-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.png Removed Paths trunk/LayoutTests/platform/chromium-linux-x86/fast/gradients/ Property Changed trunk/LayoutTests/platform/chromium-mac/fast/gradients/background-clipped-expected.png trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (124074 => 124075) --- trunk/LayoutTests/ChangeLog 2012-07-30 19:49:44 UTC (rev 124074) +++ trunk/LayoutTests/ChangeLog 2012-07-30 19:51:56 UTC (rev 124075) @@ -1,3 +1,14 @@ +2012-07-30 Stephen White senorbla...@chromium.org + +[chromium] Unreviewed gardening. Rebaseline another test affected by +r124042. + +* platform/chromium-linux-x86/fast/gradients: Removed. +* platform/chromium-linux/fast/gradients/background-clipped-expected.png: +* platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.png: +* platform/chromium-mac/fast/gradients/background-clipped-expected.png: +* platform/chromium/TestExpectations: + 2012-07-30 Peter Kasting pkast...@google.com [Chromium] Rebaseline tests for Skia changes. Modified: trunk/LayoutTests/platform/chromium/TestExpectations (124074 => 124075) --- trunk/LayoutTests/platform/chromium/TestExpectations 2012-07-30 19:49:44 UTC (rev 124074) +++ trunk/LayoutTests/platform/chromium/TestExpectations 2012-07-30 19:51:56 UTC (rev 124075) @@ -3049,9 +3049,6 @@ BUGWK81145 LION : fast/writing-mode/broken-ideographic-font.html = CRASH BUGWK81145 LION : fast/writing-mode/japanese-rl-text-with-broken-font.html = CRASH -// Needs rebaseline. -BUGWK92059 : fast/gradients/background-clipped.html = IMAGE - BUGYANGGUO MAC : fast/repaint/moving-shadow-on-container.html = TEXT BUGWK81537 : fast/events/touch/gesture/pad-gesture-fling.html = TEXT PASS Modified: trunk/LayoutTests/platform/chromium-linux/fast/gradients/background-clipped-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-mac/fast/gradients/background-clipped-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac/fast/gradients/background-clipped-expected.png ___ Modified: svn:mime-type + image/png Modified: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.png (Binary files differ) Property changes on: trunk/LayoutTests/platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.png ___ Modified: svn:mime-type + image/png ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124076] branches/chromium/1180
Title: [124076] branches/chromium/1180 Revision 124076 Author schen...@chromium.org Date 2012-07-30 13:04:06 -0700 (Mon, 30 Jul 2012) Log Message Merge 123377 - Crash when setting empty class name on a new element https://bugs.webkit.org/show_bug.cgi?id=92024 Reviewed by Andreas Kling. Source/WebCore: Add a check for null attributeData() when setting the className to an empty string on a newly created element. New SVG elements have null attributeData() on baseVal upon creation. Test: svg/custom/empty-className-baseVal-crash.html * dom/StyledElement.cpp: (WebCore::StyledElement::classAttributeChanged): Add check for null attributeData() LayoutTests: Add a check for null attributeData() when setting the className to an empty string on a newly created element. * svg/custom/empty-className-baseVal-crash-expected.txt: Added. * svg/custom/empty-className-baseVal-crash.html: Added. TBR=schen...@chromium.org Review URL: https://chromiumcodereview.appspot.com/10824091 Modified Paths branches/chromium/1180/Source/WebCore/dom/StyledElement.cpp Added Paths branches/chromium/1180/LayoutTests/svg/custom/empty-className-baseVal-crash-expected.txt branches/chromium/1180/LayoutTests/svg/custom/empty-className-baseVal-crash.html Diff Copied: branches/chromium/1180/LayoutTests/svg/custom/empty-className-baseVal-crash-expected.txt (from rev 123377, trunk/LayoutTests/svg/custom/empty-className-baseVal-crash-expected.txt) (0 => 124076) --- branches/chromium/1180/LayoutTests/svg/custom/empty-className-baseVal-crash-expected.txt (rev 0) +++ branches/chromium/1180/LayoutTests/svg/custom/empty-className-baseVal-crash-expected.txt 2012-07-30 20:04:06 UTC (rev 124076) @@ -0,0 +1 @@ +PASS if no crash. Copied: branches/chromium/1180/LayoutTests/svg/custom/empty-className-baseVal-crash.html (from rev 123377, trunk/LayoutTests/svg/custom/empty-className-baseVal-crash.html) (0 => 124076) --- branches/chromium/1180/LayoutTests/svg/custom/empty-className-baseVal-crash.html (rev 0) +++ branches/chromium/1180/LayoutTests/svg/custom/empty-className-baseVal-crash.html 2012-07-30 20:04:06 UTC (rev 124076) @@ -0,0 +1,9 @@ +!DOCTYPE html +script + if (window.layoutTestController) +layoutTestController.dumpAsText(); + document.createElementNS(http://www.w3.org/2000/svg, svg).className.baseVal = ; +/script +body + PASS if no crash. +/body Modified: branches/chromium/1180/Source/WebCore/dom/StyledElement.cpp (124075 => 124076) --- branches/chromium/1180/Source/WebCore/dom/StyledElement.cpp 2012-07-30 19:51:56 UTC (rev 124075) +++ branches/chromium/1180/Source/WebCore/dom/StyledElement.cpp 2012-07-30 20:04:06 UTC (rev 124076) @@ -172,7 +172,7 @@ ensureAttributeData()-setClass(newClassString, shouldFoldCase); if (DOMTokenList* classList = optionalClassList()) static_castClassList*(classList)-reset(newClassString); -} else +} else if (attributeData()) attributeData()-clearClass(); setNeedsStyleRecalc(); } ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124077] trunk/Source/WebCore
Title: [124077] trunk/Source/WebCore Revision 124077 Author commit-qu...@webkit.org Date 2012-07-30 13:05:59 -0700 (Mon, 30 Jul 2012) Log Message [chromium] CCThreadTask should not depend on CrossThreadTask and does not need to depend on CrossThreadCopier https://bugs.webkit.org/show_bug.cgi?id=90132 Patch by James Robinson jam...@chromium.org on 2012-07-30 Reviewed by David Levin. CrossThreadTask is defined in WebCore/dom/ and depends on concepts like ScriptExecutionConcept. CCThreadTask, being in WebCore/platform/, should not depend on /dom/ or anything from that layer. CrossThreadCopier is not a layering violation per se, but it's also not at all helpful for CCThreadTask - we never use any types for which it would be useful. * platform/graphics/chromium/cc/CCThreadProxy.cpp: (WebCore::CCThreadProxy::compositeAndReadback): (WebCore::CCThreadProxy::finishAllRendering): (WebCore::CCThreadProxy::initializeContext): (WebCore::CCThreadProxy::setVisible): (WebCore::CCThreadProxy::initializeLayerRenderer): (WebCore::CCThreadProxy::recreateContext): (WebCore::CCThreadProxy::implSideRenderingStats): (WebCore::CCThreadProxy::start): (WebCore::CCThreadProxy::stop): (WebCore::CCThreadProxy::forceSerializeOnSwapBuffers): (WebCore::CCThreadProxy::beginFrame): (WebCore::CCThreadProxy::acquireLayerTextures): * platform/graphics/chromium/cc/CCThreadTask.h: (CCThreadTask1): (WebCore::CCThreadTask1::create): (WebCore::CCThreadTask1::CCThreadTask1): (CCThreadTask2): (WebCore::CCThreadTask2::create): (WebCore::CCThreadTask2::CCThreadTask2): (CCThreadTask3): (WebCore::CCThreadTask3::create): (WebCore::CCThreadTask3::CCThreadTask3): (CCThreadTask4): (WebCore::CCThreadTask4::create): (WebCore::CCThreadTask4::CCThreadTask4): (CCThreadTask5): (WebCore::CCThreadTask5::create): (WebCore::CCThreadTask5::CCThreadTask5): (WebCore::createCCThreadTask): Modified Paths trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadTask.h Diff Modified: trunk/Source/WebCore/ChangeLog (124076 => 124077) --- trunk/Source/WebCore/ChangeLog 2012-07-30 20:04:06 UTC (rev 124076) +++ trunk/Source/WebCore/ChangeLog 2012-07-30 20:05:59 UTC (rev 124077) @@ -1,3 +1,47 @@ +2012-07-30 James Robinson jam...@chromium.org + +[chromium] CCThreadTask should not depend on CrossThreadTask and does not need to depend on CrossThreadCopier +https://bugs.webkit.org/show_bug.cgi?id=90132 + +Reviewed by David Levin. + +CrossThreadTask is defined in WebCore/dom/ and depends on concepts like ScriptExecutionConcept. CCThreadTask, +being in WebCore/platform/, should not depend on /dom/ or anything from that layer. + +CrossThreadCopier is not a layering violation per se, but it's also not at all helpful for CCThreadTask - we +never use any types for which it would be useful. + +* platform/graphics/chromium/cc/CCThreadProxy.cpp: +(WebCore::CCThreadProxy::compositeAndReadback): +(WebCore::CCThreadProxy::finishAllRendering): +(WebCore::CCThreadProxy::initializeContext): +(WebCore::CCThreadProxy::setVisible): +(WebCore::CCThreadProxy::initializeLayerRenderer): +(WebCore::CCThreadProxy::recreateContext): +(WebCore::CCThreadProxy::implSideRenderingStats): +(WebCore::CCThreadProxy::start): +(WebCore::CCThreadProxy::stop): +(WebCore::CCThreadProxy::forceSerializeOnSwapBuffers): +(WebCore::CCThreadProxy::beginFrame): +(WebCore::CCThreadProxy::acquireLayerTextures): +* platform/graphics/chromium/cc/CCThreadTask.h: +(CCThreadTask1): +(WebCore::CCThreadTask1::create): +(WebCore::CCThreadTask1::CCThreadTask1): +(CCThreadTask2): +(WebCore::CCThreadTask2::create): +(WebCore::CCThreadTask2::CCThreadTask2): +(CCThreadTask3): +(WebCore::CCThreadTask3::create): +(WebCore::CCThreadTask3::CCThreadTask3): +(CCThreadTask4): +(WebCore::CCThreadTask4::create): +(WebCore::CCThreadTask4::CCThreadTask4): +(CCThreadTask5): +(WebCore::CCThreadTask5::create): +(WebCore::CCThreadTask5::CCThreadTask5): +(WebCore::createCCThreadTask): + 2012-07-30 Paul Irish paul.ir...@gmail.com Web Inspector: Rename Databases to Web SQL Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp (124076 => 124077) --- trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp 2012-07-30 20:04:06 UTC (rev 124076) +++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp 2012-07-30 20:05:59 UTC (rev 124077) @@ -26,7 +26,6 @@ #include cc/CCThreadProxy.h -#include GraphicsContext3D.h #include SharedGraphicsContext3D.h #include TraceEvent.h #include cc/CCDelayBasedTimeSource.h @@ -111,7 +110,7 @@ // Perform a synchronous commit.
[webkit-changes] [124078] branches/safari-536.26-branch
Title: [124078] branches/safari-536.26-branch
Revision 124078
Author lforsch...@apple.com
Date 2012-07-30 13:13:31 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r118005. rdar://problem/11942082
Modified Paths
branches/safari-536.26-branch/LayoutTests/ChangeLog
branches/safari-536.26-branch/Source/WebCore/ChangeLog
branches/safari-536.26-branch/Source/WebCore/rendering/RenderBlock.cpp
Added Paths
branches/safari-536.26-branch/LayoutTests/fast/block/line-layout/selection-highlight-crash-expected.txt
branches/safari-536.26-branch/LayoutTests/fast/block/line-layout/selection-highlight-crash.html
Diff
Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (124077 => 124078)
--- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 20:05:59 UTC (rev 124077)
+++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 20:13:31 UTC (rev 124078)
@@ -1,5 +1,19 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 118005
+
+2012-05-22 Abhishek Arya infe...@chromium.org
+
+Assertion failure (toRenderBox() called on a RenderInline) beneath RenderBlock::blockBeforeWithinSelectionRoot()
+https://bugs.webkit.org/show_bug.cgi?id=86500
+
+Reviewed by Ojan Vafai.
+
+* fast/block/line-layout/selection-highlight-crash-expected.txt: Added.
+* fast/block/line-layout/selection-highlight-crash.html: Added.
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 117957
2012-05-22 Hayato Ito hay...@chromium.org
Copied: branches/safari-536.26-branch/LayoutTests/fast/block/line-layout/selection-highlight-crash-expected.txt (from rev 118005, trunk/LayoutTests/fast/block/line-layout/selection-highlight-crash-expected.txt) (0 => 124078)
--- branches/safari-536.26-branch/LayoutTests/fast/block/line-layout/selection-highlight-crash-expected.txt (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/fast/block/line-layout/selection-highlight-crash-expected.txt 2012-07-30 20:13:31 UTC (rev 124078)
@@ -0,0 +1,4 @@
+Test passes if it does not crash.
+ab
+c
+d
Copied: branches/safari-536.26-branch/LayoutTests/fast/block/line-layout/selection-highlight-crash.html (from rev 118005, trunk/LayoutTests/fast/block/line-layout/selection-highlight-crash.html) (0 => 124078)
--- branches/safari-536.26-branch/LayoutTests/fast/block/line-layout/selection-highlight-crash.html (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/fast/block/line-layout/selection-highlight-crash.html 2012-07-30 20:13:31 UTC (rev 124078)
@@ -0,0 +1,14 @@
+!DOCTYPE html
+html
+body contenteditable=true
+Test passes if it does not crash.br/
+arubybrtc/rt/rubyd
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+document.execCommand(SelectAll);
+/script
+/body
+/html
+
Modified: branches/safari-536.26-branch/Source/WebCore/ChangeLog (124077 => 124078)
--- branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 20:05:59 UTC (rev 124077)
+++ branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 20:13:31 UTC (rev 124078)
@@ -1,5 +1,24 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 118005
+
+2012-05-22 Abhishek Arya infe...@chromium.org
+
+Assertion failure (toRenderBox() called on a RenderInline) beneath RenderBlock::blockBeforeWithinSelectionRoot()
+https://bugs.webkit.org/show_bug.cgi?id=86500
+
+Reviewed by Ojan Vafai.
+
+Patch by Dan Bernsteinm...@apple.com. I just added the test.
+
+Test: fast/block/line-layout/selection-highlight-crash.html
+
+* rendering/RenderBlock.cpp:
+(WebCore::RenderBlock::blockBeforeWithinSelectionRoot): Demoted the object local variable to
+RenderObject, changed use of parentBox() to parent(), and added toRenderBlock() in two places.
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 117957
2012-05-22 Hayato Ito hay...@chromium.org
Modified: branches/safari-536.26-branch/Source/WebCore/rendering/RenderBlock.cpp (124077 => 124078)
--- branches/safari-536.26-branch/Source/WebCore/rendering/RenderBlock.cpp 2012-07-30 20:05:59 UTC (rev 124077)
+++ branches/safari-536.26-branch/Source/WebCore/rendering/RenderBlock.cpp 2012-07-30 20:13:31 UTC (rev 124078)
@@ -3368,15 +3368,15 @@
if (isSelectionRoot())
return 0;
-const RenderBox* object = this;
+const RenderObject* object = this;
RenderObject* sibling;
do {
sibling = object-previousSibling();
while (sibling (!sibling-isRenderBlock() || toRenderBlock(sibling)-isSelectionRoot()))
sibling = sibling-previousSibling();
-offset -= LayoutSize(object-logicalLeft(), object-logicalTop());
-object = object-parentBox();
+offset -= LayoutSize(toRenderBlock(object)-logicalLeft(), toRenderBlock(object)-logicalTop());
+object =
[webkit-changes] [124079] trunk/LayoutTests
Title: [124079] trunk/LayoutTests Revision 124079 Author o...@webkit.org Date 2012-07-30 13:19:05 -0700 (Mon, 30 Jul 2012) Log Message [Qt] Unreviewed gardening. * platform/qt-5.0/Skipped: Unskip now passing tests. (bug85203) * platform/qt-5.0/fast/js/global-constructors-expected.txt: Added. Same as platform/qt/...expected.txt, but has more attribute because of enabled SVG_FONTS. * platform/qt/fast/js/global-constructors-expected.png: Removed, it is text only test. Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/qt-5.0/Skipped Added Paths trunk/LayoutTests/platform/qt-5.0/fast/js/ trunk/LayoutTests/platform/qt-5.0/fast/js/global-constructors-expected.txt Removed Paths trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (124078 => 124079) --- trunk/LayoutTests/ChangeLog 2012-07-30 20:13:31 UTC (rev 124078) +++ trunk/LayoutTests/ChangeLog 2012-07-30 20:19:05 UTC (rev 124079) @@ -1,3 +1,12 @@ +2012-07-30 Csaba Osztrogonác o...@webkit.org + +[Qt] Unreviewed gardening. + +* platform/qt-5.0/Skipped: Unskip now passing tests. (bug85203) +* platform/qt-5.0/fast/js/global-constructors-expected.txt: Added. Same as + platform/qt/...expected.txt, but has more attribute because of enabled SVG_FONTS. +* platform/qt/fast/js/global-constructors-expected.png: Removed, it is text only test. + 2012-07-30 Stephen White senorbla...@chromium.org [chromium] Unreviewed gardening. Rebaseline another test affected by Deleted: trunk/LayoutTests/platform/qt/fast/js/global-constructors-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/qt-5.0/Skipped (124078 => 124079) --- trunk/LayoutTests/platform/qt-5.0/Skipped 2012-07-30 20:13:31 UTC (rev 124078) +++ trunk/LayoutTests/platform/qt-5.0/Skipped 2012-07-30 20:19:05 UTC (rev 124079) @@ -1,13 +1,5 @@ -# Still failing tests after refactored Qt5 and after WEBKIT_TESTFONTS fix. -fast/dom/Window/Plug-ins.html -fast/frames/sandboxed-iframe-about-blank.html -fast/frames/sandboxed-iframe-navigation-allowed.html -fast/images/object-image.html -fast/js/global-constructors.html -fast/replaced/invalid-object-with-fallback.html -fast/text/international/arabic-justify.html -http/tests/inspector/network/network-embed.html -http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html +# [Qt] load event fires on XMLHttpRequestUpload twice with Qt5 +# https://bugs.webkit.org/show_bug.cgi?id=92669 http/tests/xmlhttprequest/upload-onprogress-event.html http/tests/xmlhttprequest/upload-progress-events.html Added: trunk/LayoutTests/platform/qt-5.0/fast/js/global-constructors-expected.txt (0 => 124079) --- trunk/LayoutTests/platform/qt-5.0/fast/js/global-constructors-expected.txt (rev 0) +++ trunk/LayoutTests/platform/qt-5.0/fast/js/global-constructors-expected.txt 2012-07-30 20:19:05 UTC (rev 124079) @@ -0,0 +1,342 @@ +This test documents our set of global constructors we expose on the window object (FF and Opera don't expose them on the window, btw). This also checks to make sure than any constructor attribute we expose has the expected constructor type. + +On success, you will see a series of PASS messages, followed by TEST COMPLETE. + + +PASS Attr.toString() is '[object AttrConstructor]' +PASS Audio.toString() is '[object AudioConstructor]' +PASS BeforeLoadEvent.toString() is '[object BeforeLoadEventConstructor]' +PASS Blob.toString() is '[object BlobConstructor]' +PASS CDATASection.toString() is '[object CDATASectionConstructor]' +PASS CSSCharsetRule.toString() is '[object CSSCharsetRuleConstructor]' +PASS CSSFontFaceRule.toString() is '[object CSSFontFaceRuleConstructor]' +PASS CSSImportRule.toString() is '[object CSSImportRuleConstructor]' +PASS CSSMediaRule.toString() is '[object CSSMediaRuleConstructor]' +PASS CSSPageRule.toString() is '[object CSSPageRuleConstructor]' +PASS CSSPrimitiveValue.toString() is '[object CSSPrimitiveValueConstructor]' +PASS CSSRule.toString() is '[object CSSRuleConstructor]' +PASS CSSRuleList.toString() is '[object CSSRuleListConstructor]' +PASS CSSStyleDeclaration.toString() is '[object CSSStyleDeclarationConstructor]' +PASS CSSStyleRule.toString() is '[object CSSStyleRuleConstructor]' +PASS CSSStyleSheet.toString() is '[object CSSStyleSheetConstructor]' +PASS CSSValue.toString() is '[object CSSValueConstructor]' +PASS CSSValueList.toString() is '[object CSSValueListConstructor]' +PASS CanvasGradient.toString() is '[object CanvasGradientConstructor]' +PASS CanvasPattern.toString() is '[object CanvasPatternConstructor]' +PASS CanvasRenderingContext2D.toString() is '[object CanvasRenderingContext2DConstructor]' +PASS CharacterData.toString() is '[object CharacterDataConstructor]' +PASS ClientRect.toString() is '[object ClientRectConstructor]' +PASS ClientRectList.toString() is '[object ClientRectListConstructor]' +PASS Clipboard.toString()
[webkit-changes] [124080] branches/safari-536.26-branch
Title: [124080] branches/safari-536.26-branch
Revision 124080
Author lforsch...@apple.com
Date 2012-07-30 13:35:53 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r116653. rdar://problem/11942038
Modified Paths
branches/safari-536.26-branch/LayoutTests/ChangeLog
branches/safari-536.26-branch/Source/WebCore/ChangeLog
branches/safari-536.26-branch/Source/WebCore/editing/DeleteSelectionCommand.cpp
branches/safari-536.26-branch/Source/WebCore/editing/IndentOutdentCommand.cpp
branches/safari-536.26-branch/Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp
branches/safari-536.26-branch/Source/WebCore/editing/htmlediting.cpp
branches/safari-536.26-branch/Source/WebCore/editing/htmlediting.h
Added Paths
branches/safari-536.26-branch/LayoutTests/editing/inserting/insert-paragraph-seperator-crash-expected.txt
branches/safari-536.26-branch/LayoutTests/editing/inserting/insert-paragraph-seperator-crash.html
Diff
Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (124079 => 124080)
--- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 20:19:05 UTC (rev 124079)
+++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 20:35:53 UTC (rev 124080)
@@ -1,5 +1,19 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 116653
+
+2012-05-10 Abhishek Arya infe...@chromium.org
+
+Crash in InsertParagraphSeparatorCommand::doApply.
+https://bugs.webkit.org/show_bug.cgi?id=84995
+
+Reviewed by Ryosuke Niwa.
+
+* editing/inserting/insert-paragraph-seperator-crash-expected.txt: Added.
+* editing/inserting/insert-paragraph-seperator-crash.html: Added.
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 118005
2012-05-22 Abhishek Arya infe...@chromium.org
Copied: branches/safari-536.26-branch/LayoutTests/editing/inserting/insert-paragraph-seperator-crash-expected.txt (from rev 116653, trunk/LayoutTests/editing/inserting/insert-paragraph-seperator-crash-expected.txt) (0 => 124080)
--- branches/safari-536.26-branch/LayoutTests/editing/inserting/insert-paragraph-seperator-crash-expected.txt (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/editing/inserting/insert-paragraph-seperator-crash-expected.txt 2012-07-30 20:35:53 UTC (rev 124080)
@@ -0,0 +1 @@
+PASS. WebKit didn't crash.
Copied: branches/safari-536.26-branch/LayoutTests/editing/inserting/insert-paragraph-seperator-crash.html (from rev 116653, trunk/LayoutTests/editing/inserting/insert-paragraph-seperator-crash.html) (0 => 124080)
--- branches/safari-536.26-branch/LayoutTests/editing/inserting/insert-paragraph-seperator-crash.html (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/editing/inserting/insert-paragraph-seperator-crash.html 2012-07-30 20:35:53 UTC (rev 124080)
@@ -0,0 +1,34 @@
+!DOCTYPE html
+html
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+function handler() {
+var element = event.srcElement;
+document.execCommand('Undo', false, false);
+element.parentNode.removeChild(element);
+var em = document.getElementById('em');
+var span = document.getElementById('span');
+em.insertBefore(element, span);
+document.execCommand('JustifyFull', false, false);
+}
+document.addEventListener(DOMCharacterDataModified, handler, true);
+
+window._onload_ = function() {
+var selection = window.getSelection();
+document.execCommand(SelectAll, false, false)
+var element = document.getElementById(ruby);
+element.innerHTML = em id='em'^x?xspan id='span'x'x;
+selection.deleteFromDocument();
+selection.deleteFromDocument();
+document.designMode = on;
+document.execCommand('JustifyRight', false, false);
+document.execCommand('InsertHorizontalRule', false, '');
+document.documentElement.innerHTML = PASS. WebKit didn't crash.;
+};
+/script
+ruby id=ruby
+aA/a
+/ruby
+/html
Modified: branches/safari-536.26-branch/Source/WebCore/ChangeLog (124079 => 124080)
--- branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 20:19:05 UTC (rev 124079)
+++ branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 20:35:53 UTC (rev 124080)
@@ -1,5 +1,35 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 116653
+
+2012-05-10 Abhishek Arya infe...@chromium.org
+
+Crash in InsertParagraphSeparatorCommand::doApply.
+https://bugs.webkit.org/show_bug.cgi?id=84995
+
+Reviewed by Ryosuke Niwa.
+
+Test: editing/inserting/insert-paragraph-seperator-crash.html
+
+* editing/DeleteSelectionCommand.cpp:
+(WebCore::DeleteSelectionCommand::mergeParagraphs): no need of static cast, since
+type of enclosingBlock returned is already Element*.
+* editing/IndentOutdentCommand.cpp:
+(WebCore::IndentOutdentCommand::tryIndentingAsListItem): no need of static cast,
[webkit-changes] [124081] branches/safari-536.26-branch/LayoutTests
Title: [124081] branches/safari-536.26-branch/LayoutTests
Revision 124081
Author lforsch...@apple.com
Date 2012-07-30 13:37:11 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r116665. rdar://problem/11942038
Modified Paths
branches/safari-536.26-branch/LayoutTests/ChangeLog
Added Paths
branches/safari-536.26-branch/LayoutTests/editing/inserting/insert-paragraph-separator-crash-expected.txt
branches/safari-536.26-branch/LayoutTests/editing/inserting/insert-paragraph-separator-crash.html
Removed Paths
branches/safari-536.26-branch/LayoutTests/editing/inserting/insert-paragraph-seperator-crash-expected.txt
branches/safari-536.26-branch/LayoutTests/editing/inserting/insert-paragraph-seperator-crash.html
Diff
Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (124080 => 124081)
--- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 20:35:53 UTC (rev 124080)
+++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 20:37:11 UTC (rev 124081)
@@ -1,5 +1,16 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 116665
+
+2012-05-10 Abhishek Arya infe...@chromium.org
+
+Unreviewed. Correct spelling in test name.
+
+* editing/inserting/insert-paragraph-separator-crash-expected.txt: Renamed from LayoutTests/editing/inserting/insert-paragraph-seperator-crash-expected.txt.
+* editing/inserting/insert-paragraph-separator-crash.html: Renamed from LayoutTests/editing/inserting/insert-paragraph-seperator-crash.html.
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 116653
2012-05-10 Abhishek Arya infe...@chromium.org
Copied: branches/safari-536.26-branch/LayoutTests/editing/inserting/insert-paragraph-separator-crash-expected.txt (from rev 116665, trunk/LayoutTests/editing/inserting/insert-paragraph-separator-crash-expected.txt) (0 => 124081)
--- branches/safari-536.26-branch/LayoutTests/editing/inserting/insert-paragraph-separator-crash-expected.txt (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/editing/inserting/insert-paragraph-separator-crash-expected.txt 2012-07-30 20:37:11 UTC (rev 124081)
@@ -0,0 +1 @@
+PASS. WebKit didn't crash.
Copied: branches/safari-536.26-branch/LayoutTests/editing/inserting/insert-paragraph-separator-crash.html (from rev 116665, trunk/LayoutTests/editing/inserting/insert-paragraph-separator-crash.html) (0 => 124081)
--- branches/safari-536.26-branch/LayoutTests/editing/inserting/insert-paragraph-separator-crash.html (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/editing/inserting/insert-paragraph-separator-crash.html 2012-07-30 20:37:11 UTC (rev 124081)
@@ -0,0 +1,34 @@
+!DOCTYPE html
+html
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+function handler() {
+var element = event.srcElement;
+document.execCommand('Undo', false, false);
+element.parentNode.removeChild(element);
+var em = document.getElementById('em');
+var span = document.getElementById('span');
+em.insertBefore(element, span);
+document.execCommand('JustifyFull', false, false);
+}
+document.addEventListener(DOMCharacterDataModified, handler, true);
+
+window._onload_ = function() {
+var selection = window.getSelection();
+document.execCommand(SelectAll, false, false)
+var element = document.getElementById(ruby);
+element.innerHTML = em id='em'^x?xspan id='span'x'x;
+selection.deleteFromDocument();
+selection.deleteFromDocument();
+document.designMode = on;
+document.execCommand('JustifyRight', false, false);
+document.execCommand('InsertHorizontalRule', false, '');
+document.documentElement.innerHTML = PASS. WebKit didn't crash.;
+};
+/script
+ruby id=ruby
+aA/a
+/ruby
+/html
Deleted: branches/safari-536.26-branch/LayoutTests/editing/inserting/insert-paragraph-seperator-crash-expected.txt (124080 => 124081)
--- branches/safari-536.26-branch/LayoutTests/editing/inserting/insert-paragraph-seperator-crash-expected.txt 2012-07-30 20:35:53 UTC (rev 124080)
+++ branches/safari-536.26-branch/LayoutTests/editing/inserting/insert-paragraph-seperator-crash-expected.txt 2012-07-30 20:37:11 UTC (rev 124081)
@@ -1 +0,0 @@
-PASS. WebKit didn't crash.
Deleted: branches/safari-536.26-branch/LayoutTests/editing/inserting/insert-paragraph-seperator-crash.html (124080 => 124081)
--- branches/safari-536.26-branch/LayoutTests/editing/inserting/insert-paragraph-seperator-crash.html 2012-07-30 20:35:53 UTC (rev 124080)
+++ branches/safari-536.26-branch/LayoutTests/editing/inserting/insert-paragraph-seperator-crash.html 2012-07-30 20:37:11 UTC (rev 124081)
@@ -1,34 +0,0 @@
-!DOCTYPE html
-html
-script
-if (window.layoutTestController)
-layoutTestController.dumpAsText();
-
-function handler() {
-var element = event.srcElement;
-document.execCommand('Undo', false, false);
-element.parentNode.removeChild(element);
-var em =
[webkit-changes] [124082] branches/safari-536.26-branch
Title: [124082] branches/safari-536.26-branch
Revision 124082
Author lforsch...@apple.com
Date 2012-07-30 13:41:41 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r117792. rdar://problem/11942076
Modified Paths
branches/safari-536.26-branch/LayoutTests/ChangeLog
branches/safari-536.26-branch/Source/WebCore/ChangeLog
branches/safari-536.26-branch/Source/WebCore/svg/properties/SVGAnimatedPropertyTearOff.h
Added Paths
branches/safari-536.26-branch/LayoutTests/svg/custom/bug86119-expected.txt
branches/safari-536.26-branch/LayoutTests/svg/custom/bug86119.html
Diff
Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (124081 => 124082)
--- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 20:37:11 UTC (rev 124081)
+++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 20:41:41 UTC (rev 124082)
@@ -1,5 +1,19 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 117792
+
+2012-05-21 Stephen Chenney schen...@chromium.org
+
+SVGAnimatedPropertyTearOff does not clear a self pointer on deletion
+https://bugs.webkit.org/show_bug.cgi?id=86119
+
+Reviewed by Nikolas Zimmermann.
+
+* svg/custom/bug86119.html: Added.
+* svg/custom/bug86119-expected.txt: Added.
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 116665
2012-05-10 Abhishek Arya infe...@chromium.org
Copied: branches/safari-536.26-branch/LayoutTests/svg/custom/bug86119-expected.txt (from rev 117792, trunk/LayoutTests/svg/custom/bug86119-expected.txt) (0 => 124082)
--- branches/safari-536.26-branch/LayoutTests/svg/custom/bug86119-expected.txt (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/svg/custom/bug86119-expected.txt 2012-07-30 20:41:41 UTC (rev 124082)
@@ -0,0 +1 @@
+Test for Bug 86119. Test passes if it does not crash.
Copied: branches/safari-536.26-branch/LayoutTests/svg/custom/bug86119.html (from rev 117792, trunk/LayoutTests/svg/custom/bug86119.html) (0 => 124082)
--- branches/safari-536.26-branch/LayoutTests/svg/custom/bug86119.html (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/svg/custom/bug86119.html 2012-07-30 20:41:41 UTC (rev 124082)
@@ -0,0 +1,47 @@
+html
+ head
+script
+ if (window.layoutTestController) {
+layoutTestController.dumpAsText();
+ }
+
+ function onload()
+ {
+window.svgRoot = document.getElementById(svgRoot);
+window.svgViewBaseVal = window.svgRoot.viewBox.baseVal;
+
+// Cause GC of window.svgRoot.viewBox
+if (window.GCController)
+ GCController.collect();
+
+// Set a value on window.svgViewBaseVal
+window.svgViewBaseVal.height = 56;
+if (window.svgRoot.viewBox.baseVal.height != 56)
+ document.body.innerHTML = FAIL;
+
+// Repeat with a non-dom-attached viewBox
+window.viewElement = parent.document.createElementNS(http://www.w3.org/2000/svg, view);
+window.viewBaseVal = window.viewElement.viewBox.baseVal;
+if (window.GCController)
+ GCController.collect();
+window.viewBaseVal.height = 12;
+if (window.viewElement.viewBox.baseVal.height != 12)
+ document.body.innerHTML = FAIL;
+else {
+ document.body.appendChild(window.viewElement);
+ window.viewBaseVal.height = 34;
+ if (window.viewElement.viewBox.baseVal.height != 34)
+document.body.innerHTML = FAIL;
+}
+ }
+/script
+ /head
+ body _onload_=onload()
+Test for Bug 86119. Test passes if it does not crash and you see a green
+rectangle above this text.
+svg id=svgRoot width=100 height=100 xmlns:svg=http://www.w3.org/2000/svg
+ rect x=10 height=80 width=80 y=10 fill=green/
+/svg
+ /body
+/html
+
Modified: branches/safari-536.26-branch/Source/WebCore/ChangeLog (124081 => 124082)
--- branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 20:37:11 UTC (rev 124081)
+++ branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 20:41:41 UTC (rev 124082)
@@ -1,5 +1,30 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 117792
+
+2012-05-21 Stephen Chenney schen...@chromium.org
+
+SVGAnimatedPropertyTearOff does not clear a self pointer on deletion
+https://bugs.webkit.org/show_bug.cgi?id=86119
+
+Reviewed by Nikolas Zimmermann.
+
+SVGAnimatedPropertyTearOff contains two SVGPropertyTearOff objects
+that have a pointer back to the SVGAnimatedPropertyTearOff. JS may
+also have a reference to these SVGPropertyTearOff objects. When the
+SVGAnimatedPropertyTearOff is deleted, the SVGPropertyTearOff objects
+may live on, but the pointer back to the deleted animated property
+tear off is left invalid. This patch clears the pointers on destruction
+of the
[webkit-changes] [124083] branches/safari-536.26-branch/LayoutTests
Title: [124083] branches/safari-536.26-branch/LayoutTests Revision 124083 Author lforsch...@apple.com Date 2012-07-30 13:42:52 -0700 (Mon, 30 Jul 2012) Log Message Merged r117801. rdar://problem/11942076 Modified Paths branches/safari-536.26-branch/LayoutTests/ChangeLog branches/safari-536.26-branch/LayoutTests/svg/custom/bug86119-expected.txt Diff Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (124082 => 124083) --- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 20:41:41 UTC (rev 124082) +++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 20:42:52 UTC (rev 124083) @@ -1,5 +1,17 @@ 2012-07-30 Lucas Forschler lforsch...@apple.com +Merge 117801 + +2012-05-21 Brady Eidson beid...@apple.com + +Checking in correct test results for https://bugs.webkit.org/show_bug.cgi?id=86119 + +Unreviewed. + +* svg/custom/bug86119-expected.txt: + +2012-07-30 Lucas Forschler lforsch...@apple.com + Merge 117792 2012-05-21 Stephen Chenney schen...@chromium.org Modified: branches/safari-536.26-branch/LayoutTests/svg/custom/bug86119-expected.txt (124082 => 124083) --- branches/safari-536.26-branch/LayoutTests/svg/custom/bug86119-expected.txt 2012-07-30 20:41:41 UTC (rev 124082) +++ branches/safari-536.26-branch/LayoutTests/svg/custom/bug86119-expected.txt 2012-07-30 20:42:52 UTC (rev 124083) @@ -1 +1 @@ -Test for Bug 86119. Test passes if it does not crash. +Test for Bug 86119. Test passes if it does not crash and you see a green rectangle above this text. ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124084] trunk/LayoutTests
Title: [124084] trunk/LayoutTests
Revision 124084
Author pkast...@chromium.org
Date 2012-07-30 13:45:47 -0700 (Mon, 30 Jul 2012)
Log Message
Force Mac editing mode on new test so other platforms will pass it.
https://bugs.webkit.org/show_bug.cgi?id=92662
Reviewed by Ryosuke Niwa.
* fast/writing-mode/flipped-blocks-hit-test-line-edges.html:
Modified Paths
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/writing-mode/flipped-blocks-hit-test-line-edges.html
Diff
Modified: trunk/LayoutTests/ChangeLog (124083 => 124084)
--- trunk/LayoutTests/ChangeLog 2012-07-30 20:42:52 UTC (rev 124083)
+++ trunk/LayoutTests/ChangeLog 2012-07-30 20:45:47 UTC (rev 124084)
@@ -1,3 +1,12 @@
+2012-07-30 Peter Kasting pkast...@google.com
+
+Force Mac editing mode on new test so other platforms will pass it.
+https://bugs.webkit.org/show_bug.cgi?id=92662
+
+Reviewed by Ryosuke Niwa.
+
+* fast/writing-mode/flipped-blocks-hit-test-line-edges.html:
+
2012-07-30 Csaba Osztrogonác o...@webkit.org
[Qt] Unreviewed gardening.
Modified: trunk/LayoutTests/fast/writing-mode/flipped-blocks-hit-test-line-edges.html (124083 => 124084)
--- trunk/LayoutTests/fast/writing-mode/flipped-blocks-hit-test-line-edges.html 2012-07-30 20:42:52 UTC (rev 124083)
+++ trunk/LayoutTests/fast/writing-mode/flipped-blocks-hit-test-line-edges.html 2012-07-30 20:45:47 UTC (rev 124084)
@@ -8,8 +8,10 @@
Lorem ipsum dolor sit amet/div
pre id=log/pre
script
-if (window.testRunner)
+if (window.testRunner window.internals) {
testRunner.dumpAsText();
+internals.settings.setEditingBehavior(mac);
+}
function log(message)
{
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124085] trunk/LayoutTests
Title: [124085] trunk/LayoutTests Revision 124085 Author senorbla...@chromium.org Date 2012-07-30 13:49:24 -0700 (Mon, 30 Jul 2012) Log Message [chromium] Unreviewed gardening. Add new baselines for tests affected by r124042. * platform/chromium-linux/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: * platform/chromium-linux/fast/borders/border-image-rotate-transform-expected.png: * platform/chromium-win-xp/fast/backgrounds/repeat: Removed. * platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: * platform/chromium-win/fast/borders/border-image-rotate-transform-expected.png: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/chromium-linux/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png trunk/LayoutTests/platform/chromium-linux/fast/borders/border-image-rotate-transform-expected.png trunk/LayoutTests/platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png trunk/LayoutTests/platform/chromium-win/fast/borders/border-image-rotate-transform-expected.png Removed Paths trunk/LayoutTests/platform/chromium-win-xp/fast/backgrounds/repeat/ Diff Modified: trunk/LayoutTests/ChangeLog (124084 => 124085) --- trunk/LayoutTests/ChangeLog 2012-07-30 20:45:47 UTC (rev 124084) +++ trunk/LayoutTests/ChangeLog 2012-07-30 20:49:24 UTC (rev 124085) @@ -1,3 +1,14 @@ +2012-07-30 Stephen White senorbla...@chromium.org + +[chromium] Unreviewed gardening. Add new baselines for tests +affected by r124042. + +* platform/chromium-linux/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: +* platform/chromium-linux/fast/borders/border-image-rotate-transform-expected.png: +* platform/chromium-win-xp/fast/backgrounds/repeat: Removed. +* platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: +* platform/chromium-win/fast/borders/border-image-rotate-transform-expected.png: + 2012-07-30 Peter Kasting pkast...@google.com Force Mac editing mode on new test so other platforms will pass it. Modified: trunk/LayoutTests/platform/chromium-linux/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-linux/fast/borders/border-image-rotate-transform-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png (Binary files differ) Modified: trunk/LayoutTests/platform/chromium-win/fast/borders/border-image-rotate-transform-expected.png (Binary files differ) ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124086] trunk/LayoutTests
Title: [124086] trunk/LayoutTests Revision 124086 Author rak...@webkit.org Date 2012-07-30 13:52:00 -0700 (Mon, 30 Jul 2012) Log Message [EFL] Unreviewed gardening. Fix r124028 by adding the missing expectations to the added lines. * platform/efl/TestExpectations: Modified Paths trunk/LayoutTests/ChangeLog trunk/LayoutTests/platform/efl/TestExpectations Diff Modified: trunk/LayoutTests/ChangeLog (124085 => 124086) --- trunk/LayoutTests/ChangeLog 2012-07-30 20:49:24 UTC (rev 124085) +++ trunk/LayoutTests/ChangeLog 2012-07-30 20:52:00 UTC (rev 124086) @@ -1,3 +1,11 @@ +2012-07-30 Raphael Kubo da Costa rak...@webkit.org + +[EFL] Unreviewed gardening. + +Fix r124028 by adding the missing expectations to the added lines. + +* platform/efl/TestExpectations: + 2012-07-30 Stephen White senorbla...@chromium.org [chromium] Unreviewed gardening. Add new baselines for tests Modified: trunk/LayoutTests/platform/efl/TestExpectations (124085 => 124086) --- trunk/LayoutTests/platform/efl/TestExpectations 2012-07-30 20:49:24 UTC (rev 124085) +++ trunk/LayoutTests/platform/efl/TestExpectations 2012-07-30 20:52:00 UTC (rev 124086) @@ -477,10 +477,10 @@ BUGWK82294 : compositing/visibility/visibility-image-layers-dynamic.html = TEXT BUGWK82294 : compositing/layer-creation/no-compositing-for-preserve-3d.html = TEXT BUGWK82294 : compositing/columns/composited-in-paginated.html = TEXT -BUGWK82294 : compositing/geometry/bounds-ignores-hidden-composited-descendant.html -BUGWK82294 : compositing/geometry/bounds-ignores-hidden-dynamic-negzindex.html -BUGWK82294 : compositing/geometry/bounds-ignores-hidden-dynamic.html -BUGWK82294 : compositing/geometry/bounds-ignores-hidden.html +BUGWK82294 : compositing/geometry/bounds-ignores-hidden-composited-descendant.html = TEXT +BUGWK82294 : compositing/geometry/bounds-ignores-hidden-dynamic-negzindex.html = TEXT +BUGWK82294 : compositing/geometry/bounds-ignores-hidden-dynamic.html = TEXT +BUGWK82294 : compositing/geometry/bounds-ignores-hidden.html = TEXT // EFL's LayoutTestController does not implement displayInvalidatedRegion BUGWK86727 : compositing/plugins/invalidate_rect.html = TEXT ___ webkit-changes mailing list webkit-changes@lists.webkit.org http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124087] trunk/Source/WebKit2
Title: [124087] trunk/Source/WebKit2
Revision 124087
Author commit-qu...@webkit.org
Date 2012-07-30 13:57:59 -0700 (Mon, 30 Jul 2012)
Log Message
[GTK] critical warning: gdk_window_get_cursor() called on a NULL window
https://bugs.webkit.org/show_bug.cgi?id=92651
Patch by Claudio Saavedra csaave...@igalia.com on 2012-07-30
Reviewed by Martin Robinson.
PageClientImpl::setCursor() might get called before the
window is realized, so safeguard against it.
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::setCursor): early return if the window is
not realized.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp
Diff
Modified: trunk/Source/WebKit2/ChangeLog (124086 => 124087)
--- trunk/Source/WebKit2/ChangeLog 2012-07-30 20:52:00 UTC (rev 124086)
+++ trunk/Source/WebKit2/ChangeLog 2012-07-30 20:57:59 UTC (rev 124087)
@@ -1,3 +1,17 @@
+2012-07-30 Claudio Saavedra csaave...@igalia.com
+
+[GTK] critical warning: gdk_window_get_cursor() called on a NULL window
+https://bugs.webkit.org/show_bug.cgi?id=92651
+
+Reviewed by Martin Robinson.
+
+PageClientImpl::setCursor() might get called before the
+window is realized, so safeguard against it.
+
+* UIProcess/API/gtk/PageClientImpl.cpp:
+(WebKit::PageClientImpl::setCursor): early return if the window is
+not realized.
+
2012-07-30 Sheriff Bot webkit.review@gmail.com
Unreviewed, rolling out r123983.
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp (124086 => 124087)
--- trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp 2012-07-30 20:52:00 UTC (rev 124086)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp 2012-07-30 20:57:59 UTC (rev 124087)
@@ -142,6 +142,9 @@
void PageClientImpl::setCursor(const Cursor cursor)
{
+if (!gtk_widget_get_realized(m_viewWidget))
+return;
+
// [GTK] Widget::setCursor() gets called frequently
// http://bugs.webkit.org/show_bug.cgi?id=16388
// Setting the cursor may be an expensive operation in some backends,
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124088] trunk/LayoutTests
Title: [124088] trunk/LayoutTests Revision 124088 Author tomhud...@google.com Date 2012-07-30 14:02:27 -0700 (Mon, 30 Jul 2012) Log Message Baselines on additional platforms for fast/table/table-row-focus-ring-paint. https://bugs.webkit.org/show_bug.cgi?id=85348 Unreviewed gardening. * platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png: Removed. * platform/chromium-mac/fast/table/table-row-focus-ring-paint-expected.png: Added. * platform/chromium-win/fast/table/table-row-focus-ring-paint-expected.png: Added. Modified Paths trunk/LayoutTests/ChangeLog Added Paths trunk/LayoutTests/platform/chromium-mac/fast/table/table-row-focus-ring-paint-expected.png trunk/LayoutTests/platform/chromium-win/fast/table/table-row-focus-ring-paint-expected.png Removed Paths trunk/LayoutTests/platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png Diff Modified: trunk/LayoutTests/ChangeLog (124087 => 124088) --- trunk/LayoutTests/ChangeLog 2012-07-30 20:57:59 UTC (rev 124087) +++ trunk/LayoutTests/ChangeLog 2012-07-30 21:02:27 UTC (rev 124088) @@ -1,3 +1,14 @@ +2012-07-30 Tom Hudson tomhud...@google.com + +Baselines on additional platforms for fast/table/table-row-focus-ring-paint. +https://bugs.webkit.org/show_bug.cgi?id=85348 + +Unreviewed gardening. + +* platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png: Removed. +* platform/chromium-mac/fast/table/table-row-focus-ring-paint-expected.png: Added. +* platform/chromium-win/fast/table/table-row-focus-ring-paint-expected.png: Added. + 2012-07-30 Raphael Kubo da Costa rak...@webkit.org [EFL] Unreviewed gardening. Deleted: trunk/LayoutTests/platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png (124087 => 124088) --- trunk/LayoutTests/platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png 2012-07-30 20:57:59 UTC (rev 124087) +++ trunk/LayoutTests/platform/chromium-linux/fast/table/table-row-focus-ring-paint-expected.png 2012-07-30 21:02:27 UTC (rev 124088) @@ -1,7 +0,0 @@ -\x89PNG - - -IHDR X ' )tEXtchecksum e1d161da93b04cd8216f865f58169454\xCFd gIDATx\x9C\xED\xDC1N\xDB` \x86a\E\xCAP\x89\x84kй\xE9\x95z j\xB8X\xC3 \xD7 \xC8\xE6\xC9\xDD\xDA\xD1+\xA1\xE7\xED\xF8\xC6W\xAC \xF3_ \xD0\xF9r\xEE \x9F\x8D\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\x98\xC0 \x88 , \x80\xD8\xEA\xB5\xC3+N\xE4?\xE8\x80\x8F\xC8 - @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @L` \xC4 @l\xF5ځy\x89 \x9Fȋ\x815=\xED\xA6\xFDn\xB9!'Yo\xB6\xEB\xAB\xED\xB9W 3\xCC\xF3\x91;\xAA\xE9iwx כ\xEFw\xF7w\xCBoz\xA3\x9B\xEF7\xD3\xFE\xFE\xF2z\xD4X \xC0\x87r\xB0\xE3\xC5\xC5|\xF9\xEDv\xB8 \x9F\xF4V\xF3\xAF\xF9\xEF\xCEso \xF8\xC7G\xEE 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X 1\x81 X \xB1\xD5ѧ\xEB\xCD\xF6\xF08 Ɵ_\xDE\xF3\x87\x87q\xDA\xEF.\xAF\xC7s xf\x98\xE7\xF9\xE8\x8B\xE9i7\xED/\xBC\xE6\xBD֛ \xEB\xAB\xED\xB9W \xF3b` p\x9A\xE3?\xFEgXbʼn\xA4! \xF0\xF9\xC8 \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB0 b \xB6z\xED\xC0\xBC\xC4 - \x80O\xC4
[webkit-changes] [124089] trunk/Source/WebCore
Title: [124089] trunk/Source/WebCore
Revision 124089
Author kl...@webkit.org
Date 2012-07-30 14:06:26 -0700 (Mon, 30 Jul 2012)
Log Message
REGRESSION(r123636): Heap-use-after-free in StyleResolver::collectMatchingRules.
http://webkit.org/b/92430
Reviewed by Antti Koivisto.
Don't hold on to a reference to StyledElement::classNames() as that may become
invalid after mutating the element's attribute data.
In this case it was happening below Element::hasAttributes() which is unfortunately
naive enough to always serialize lazy attributes. That is a minor inefficiency that
can be addressed in a separate patch.
Covered by valgrind on existing tests.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRules):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/StyleResolver.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (124088 => 124089)
--- trunk/Source/WebCore/ChangeLog 2012-07-30 21:02:27 UTC (rev 124088)
+++ trunk/Source/WebCore/ChangeLog 2012-07-30 21:06:26 UTC (rev 124089)
@@ -1,3 +1,22 @@
+2012-07-30 Andreas Kling kl...@webkit.org
+
+REGRESSION(r123636): Heap-use-after-free in StyleResolver::collectMatchingRules.
+http://webkit.org/b/92430
+
+Reviewed by Antti Koivisto.
+
+Don't hold on to a reference to StyledElement::classNames() as that may become
+invalid after mutating the element's attribute data.
+
+In this case it was happening below Element::hasAttributes() which is unfortunately
+naive enough to always serialize lazy attributes. That is a minor inefficiency that
+can be addressed in a separate patch.
+
+Covered by valgrind on existing tests.
+
+* css/StyleResolver.cpp:
+(WebCore::StyleResolver::collectMatchingRules):
+
2012-07-30 James Robinson jam...@chromium.org
[chromium] CCThreadTask should not depend on CrossThreadTask and does not need to depend on CrossThreadCopier
Modified: trunk/Source/WebCore/css/StyleResolver.cpp (124088 => 124089)
--- trunk/Source/WebCore/css/StyleResolver.cpp 2012-07-30 21:02:27 UTC (rev 124088)
+++ trunk/Source/WebCore/css/StyleResolver.cpp 2012-07-30 21:06:26 UTC (rev 124089)
@@ -886,10 +886,8 @@
collectMatchingRulesForList(rules-idRules(m_element-idForStyleResolution().impl()), firstRuleIndex, lastRuleIndex, options);
if (m_element-hasClass()) {
ASSERT(m_styledElement);
-const SpaceSplitString classNames = m_styledElement-classNames();
-size_t size = classNames.size();
-for (size_t i = 0; i size; ++i)
-collectMatchingRulesForList(rules-classRules(classNames[i].impl()), firstRuleIndex, lastRuleIndex, options);
+for (size_t i = 0; i m_styledElement-classNames().size(); ++i)
+collectMatchingRulesForList(rules-classRules(m_styledElement-classNames()[i].impl()), firstRuleIndex, lastRuleIndex, options);
}
const AtomicString pseudoId = m_element-shadowPseudoId();
if (!pseudoId.isEmpty()) {
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124090] trunk/Tools
Title: [124090] trunk/Tools Revision 124090 Author dpra...@chromium.org Date 2012-07-30 14:07:46 -0700 (Mon, 30 Jul 2012) Log Message nrwt: --verbose logging does not work right on windows https://bugs.webkit.org/show_bug.cgi?id=92673 Unreviewed, build fix. The --verbose log level is not being propagated to the worker processes on windows properly; this has been broken ever since I refactored logging into the message pool directly :(. Also, fixing this revealed that outputcapture wasn't saving and restoring log levels correctly, so I had to fix that as well. * Scripts/webkitpy/common/message_pool.py: (_MessagePool._start_workers): (_MessagePool._worker_log_level): (_Worker.__init__): (_Worker._set_up_logging): (_WorkerLogHandler.__init__): * Scripts/webkitpy/common/system/outputcapture.py: (OutputCapture.capture_output): (OutputCapture.restore_output): Modified Paths trunk/Tools/ChangeLog trunk/Tools/Scripts/webkitpy/common/message_pool.py trunk/Tools/Scripts/webkitpy/common/system/outputcapture.py Diff Modified: trunk/Tools/ChangeLog (124089 => 124090) --- trunk/Tools/ChangeLog 2012-07-30 21:06:26 UTC (rev 124089) +++ trunk/Tools/ChangeLog 2012-07-30 21:07:46 UTC (rev 124090) @@ -1,5 +1,29 @@ 2012-07-30 Dirk Pranke dpra...@chromium.org +nrwt: --verbose logging does not work right on windows +https://bugs.webkit.org/show_bug.cgi?id=92673 + +Unreviewed, build fix. + +The --verbose log level is not being propagated to the worker +processes on windows properly; this has been broken ever since I +refactored logging into the message pool directly :(. + +Also, fixing this revealed that outputcapture wasn't saving and +restoring log levels correctly, so I had to fix that as well. + +* Scripts/webkitpy/common/message_pool.py: +(_MessagePool._start_workers): +(_MessagePool._worker_log_level): +(_Worker.__init__): +(_Worker._set_up_logging): +(_WorkerLogHandler.__init__): +* Scripts/webkitpy/common/system/outputcapture.py: +(OutputCapture.capture_output): +(OutputCapture.restore_output): + +2012-07-30 Dirk Pranke dpra...@chromium.org + After r123895, new-run-webkit-tests can fail with TypeError when a test crashes https://bugs.webkit.org/show_bug.cgi?id=92664 Modified: trunk/Tools/Scripts/webkitpy/common/message_pool.py (124089 => 124090) --- trunk/Tools/Scripts/webkitpy/common/message_pool.py 2012-07-30 21:06:26 UTC (rev 124089) +++ trunk/Tools/Scripts/webkitpy/common/message_pool.py 2012-07-30 21:07:46 UTC (rev 124090) @@ -104,12 +104,22 @@ host = self._host for worker_number in xrange(self._num_workers): -worker = _Worker(host, self._messages_to_manager, self._messages_to_worker, self._worker_factory, worker_number, self._running_inline, self if self._running_inline else None) +worker = _Worker(host, self._messages_to_manager, self._messages_to_worker, self._worker_factory, worker_number, self._running_inline, self if self._running_inline else None, self._worker_log_level()) self._workers.append(worker) worker.start() if self._worker_startup_delay_secs: time.sleep(self._worker_startup_delay_secs) +def _worker_log_level(self): +log_level = logging.NOTSET +for handler in logging.root.handlers: +if handler.level != logging.NOTSET: +if log_level == logging.NOTSET: +log_level = handler.level +else: +log_level = min(log_level, handler.level) +return log_level + def wait(self): try: self._start_workers() @@ -192,12 +202,13 @@ class _Worker(multiprocessing.Process): -def __init__(self, host, messages_to_manager, messages_to_worker, worker_factory, worker_number, running_inline, manager): +def __init__(self, host, messages_to_manager, messages_to_worker, worker_factory, worker_number, running_inline, manager, log_level): super(_Worker, self).__init__() self.host = host self.worker_number = worker_number self.name = 'worker/%d' % worker_number self.log_messages = [] +self.log_level = log_level self._running_inline = running_inline self._manager = manager @@ -300,12 +311,14 @@ self._log_handler = _WorkerLogHandler(self) self._logger.addHandler(self._log_handler) +self._logger.setLevel(self.log_level) class _WorkerLogHandler(logging.Handler): def __init__(self, worker): logging.Handler.__init__(self) self._worker = worker +self.setLevel(worker.log_level) def emit(self, record): self._worker.log_messages.append(record) Modified: trunk/Tools/Scripts/webkitpy/common/system/outputcapture.py (124089 => 124090) ---
[webkit-changes] [124092] trunk/Source/WebKit2
Title: [124092] trunk/Source/WebKit2
Revision 124092
Author a...@apple.com
Date 2012-07-30 14:31:06 -0700 (Mon, 30 Jul 2012)
Log Message
[WK2] Kill the concept of secondary shared process
https://bugs.webkit.org/show_bug.cgi?id=92676
Reviewed by Sam Weinig.
* UIProcess/API/C/WKContext.cpp:
* UIProcess/API/C/WKContext.h:
* UIProcess/WebContext.cpp:
* UIProcess/WebContext.h:
Deleted shared process related code. We don't need to build the singleton into
the cross-platform C API, platform-specific API wrappers are perfectly capable
of doing that.
* UIProcess/API/efl/ewk_context.cpp: (createDefaultEwkContext):
* UIProcess/API/gtk/WebKitWebContext.cpp: (createDefaultWebContext):
Use WKContextCreate() when creating default context.
Modified Paths
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp
trunk/Source/WebKit2/UIProcess/API/C/WKContext.h
trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.cpp
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp
trunk/Source/WebKit2/UIProcess/WebContext.cpp
trunk/Source/WebKit2/UIProcess/WebContext.h
Diff
Modified: trunk/Source/WebKit2/ChangeLog (124091 => 124092)
--- trunk/Source/WebKit2/ChangeLog 2012-07-30 21:11:10 UTC (rev 124091)
+++ trunk/Source/WebKit2/ChangeLog 2012-07-30 21:31:06 UTC (rev 124092)
@@ -1,3 +1,22 @@
+2012-07-30 Alexey Proskuryakov a...@apple.com
+
+[WK2] Kill the concept of secondary shared process
+https://bugs.webkit.org/show_bug.cgi?id=92676
+
+Reviewed by Sam Weinig.
+
+* UIProcess/API/C/WKContext.cpp:
+* UIProcess/API/C/WKContext.h:
+* UIProcess/WebContext.cpp:
+* UIProcess/WebContext.h:
+Deleted shared process related code. We don't need to build the singleton into
+the cross-platform C API, platform-specific API wrappers are perfectly capable
+of doing that.
+
+* UIProcess/API/efl/ewk_context.cpp: (createDefaultEwkContext):
+* UIProcess/API/gtk/WebKitWebContext.cpp: (createDefaultWebContext):
+Use WKContextCreate() when creating default context.
+
2012-07-30 Claudio Saavedra csaave...@igalia.com
[GTK] critical warning: gdk_window_get_cursor() called on a NULL window
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp (124091 => 124092)
--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp 2012-07-30 21:11:10 UTC (rev 124091)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp 2012-07-30 21:31:06 UTC (rev 124092)
@@ -61,11 +61,6 @@
return toAPI(context.release().leakRef());
}
-WKContextRef WKContextGetSharedProcessContext()
-{
-return toAPI(WebContext::sharedProcessContext());
-}
-
WKContextRef WKContextGetSharedThreadContext()
{
return toAPI(WebContext::sharedThreadContext());
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.h (124091 => 124092)
--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.h 2012-07-30 21:11:10 UTC (rev 124091)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.h 2012-07-30 21:31:06 UTC (rev 124092)
@@ -127,7 +127,6 @@
WK_EXPORT WKContextRef WKContextCreate();
WK_EXPORT WKContextRef WKContextCreateWithInjectedBundlePath(WKStringRef path);
-WK_EXPORT WKContextRef WKContextGetSharedProcessContext();
WK_EXPORT void WKContextSetInjectedBundleClient(WKContextRef context, const WKContextInjectedBundleClient* client);
WK_EXPORT void WKContextSetHistoryClient(WKContextRef context, const WKContextHistoryClient* client);
Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.cpp (124091 => 124092)
--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.cpp 2012-07-30 21:11:10 UTC (rev 124091)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_context.cpp 2012-07-30 21:31:06 UTC (rev 124092)
@@ -189,7 +189,7 @@
static inline Ewk_Context* createDefaultEwkContext()
{
-return new Ewk_Context(WKContextGetSharedProcessContext());
+return new Ewk_Context(WKContextCreate());
}
Ewk_Context* ewk_context_default_get()
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp (124091 => 124092)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp 2012-07-30 21:11:10 UTC (rev 124091)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp 2012-07-30 21:31:06 UTC (rev 124092)
@@ -118,7 +118,7 @@
static gpointer createDefaultWebContext(gpointer)
{
static GRefPtrWebKitWebContext webContext = adoptGRef(WEBKIT_WEB_CONTEXT(g_object_new(WEBKIT_TYPE_WEB_CONTEXT, NULL)));
-webContext-priv-context = WKContextGetSharedProcessContext();
+webContext-priv-context = WKContextCreate();
webContext-priv-requestManager = WKContextGetSoupRequestManager(webContext-priv-context.get());
WKContextSetCacheModel(webContext-priv-context.get(), kWKCacheModelPrimaryWebBrowser);
attachDownloadClientToContext(webContext.get());
Modified:
[webkit-changes] [124093] trunk/Source/WebCore
Title: [124093] trunk/Source/WebCore
Revision 124093
Author jam...@google.com
Date 2012-07-30 14:33:32 -0700 (Mon, 30 Jul 2012)
Log Message
[chromium] Add miscellaneous missing includes and OVERRIDE declarations in compositor code
https://bugs.webkit.org/show_bug.cgi?id=92680
Reviewed by Adrienne Walker.
* platform/graphics/chromium/TextureCopier.h:
(AcceleratedTextureCopier):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCPrioritizedTextureManager.h:
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
* platform/graphics/chromium/cc/CCResourceProvider.h:
(WebCore):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/chromium/TextureCopier.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCPrioritizedTextureManager.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCRenderPassDrawQuad.h
trunk/Source/WebCore/platform/graphics/chromium/cc/CCResourceProvider.h
Diff
Modified: trunk/Source/WebCore/ChangeLog (124092 => 124093)
--- trunk/Source/WebCore/ChangeLog 2012-07-30 21:31:06 UTC (rev 124092)
+++ trunk/Source/WebCore/ChangeLog 2012-07-30 21:33:32 UTC (rev 124093)
@@ -1,3 +1,19 @@
+2012-07-30 James Robinson jam...@chromium.org
+
+[chromium] Add miscellaneous missing includes and OVERRIDE declarations in compositor code
+https://bugs.webkit.org/show_bug.cgi?id=92680
+
+Reviewed by Adrienne Walker.
+
+* platform/graphics/chromium/TextureCopier.h:
+(AcceleratedTextureCopier):
+* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
+(CCLayerTreeHostImpl):
+* platform/graphics/chromium/cc/CCPrioritizedTextureManager.h:
+* platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
+* platform/graphics/chromium/cc/CCResourceProvider.h:
+(WebCore):
+
2012-07-30 Adrienne Walker e...@google.com
[chromium] Remove dependency on ScrollbarTheme from the compositor
Modified: trunk/Source/WebCore/platform/graphics/chromium/TextureCopier.h (124092 => 124093)
--- trunk/Source/WebCore/platform/graphics/chromium/TextureCopier.h 2012-07-30 21:31:06 UTC (rev 124092)
+++ trunk/Source/WebCore/platform/graphics/chromium/TextureCopier.h 2012-07-30 21:33:32 UTC (rev 124093)
@@ -28,6 +28,8 @@
#include GraphicsContext3D.h
#include ProgramBinding.h
#include ShaderChromium.h
+#include wtf/OwnPtr.h
+#include wtf/PassOwnPtr.h
namespace WebKit {
class WebGraphicsContext3D;
@@ -59,8 +61,8 @@
}
virtual ~AcceleratedTextureCopier();
-virtual void copyTexture(unsigned sourceTextureId, unsigned destTextureId, const IntSize);
-virtual void flush();
+virtual void copyTexture(unsigned sourceTextureId, unsigned destTextureId, const IntSize) OVERRIDE;
+virtual void flush() OVERRIDE;
protected:
AcceleratedTextureCopier(WebKit::WebGraphicsContext3D*, bool usingBindUniforms);
Modified: trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h (124092 => 124093)
--- trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h 2012-07-30 21:31:06 UTC (rev 124092)
+++ trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h 2012-07-30 21:33:32 UTC (rev 124093)
@@ -69,17 +69,17 @@
virtual ~CCLayerTreeHostImpl();
// CCInputHandlerClient implementation
-virtual CCInputHandlerClient::ScrollStatus scrollBegin(const IntPoint, CCInputHandlerClient::ScrollInputType);
-virtual void scrollBy(const IntSize);
-virtual void scrollEnd();
-virtual void pinchGestureBegin();
-virtual void pinchGestureUpdate(float, const IntPoint);
-virtual void pinchGestureEnd();
-virtual void startPageScaleAnimation(const IntSize targetPosition, bool anchorPoint, float pageScale, double startTime, double duration);
-virtual CCActiveGestureAnimation* activeGestureAnimation() { return m_activeGestureAnimation.get(); }
+virtual CCInputHandlerClient::ScrollStatus scrollBegin(const IntPoint, CCInputHandlerClient::ScrollInputType) OVERRIDE;
+virtual void scrollBy(const IntSize) OVERRIDE;
+virtual void scrollEnd() OVERRIDE;
+virtual void pinchGestureBegin() OVERRIDE;
+virtual void pinchGestureUpdate(float, const IntPoint) OVERRIDE;
+virtual void pinchGestureEnd() OVERRIDE;
+virtual void startPageScaleAnimation(const IntSize targetPosition, bool anchorPoint, float pageScale, double startTime, double duration) OVERRIDE;
+virtual CCActiveGestureAnimation* activeGestureAnimation() OVERRIDE { return m_activeGestureAnimation.get(); }
// To clear an active animation, pass nullptr.
-virtual void setActiveGestureAnimation(PassOwnPtrCCActiveGestureAnimation);
-virtual void scheduleAnimation();
+virtual void setActiveGestureAnimation(PassOwnPtrCCActiveGestureAnimation) OVERRIDE;
+virtual void scheduleAnimation() OVERRIDE;
[webkit-changes] [124094] trunk/Tools
Title: [124094] trunk/Tools Revision 124094 Author rak...@webkit.org Date 2012-07-30 14:35:10 -0700 (Mon, 30 Jul 2012) Log Message [jhbuild] gnutls 2.12.14 does not build with glibc 2.16.0 https://bugs.webkit.org/show_bug.cgi?id=90643 Reviewed by Gustavo Noronha Silva. The 2.x series of gnutls has a version of Gnulib that is incompatible with glibc 2.16.0, which now does not define gets() by default. After talking to kov, mrobinson and philn, it looks like it makes sense to simply remove gnutls from jhbuild.modules and rely on the version installed on the system being recent enough. This means at least version 2.12.8 for PKCS11 support, or at the very least 2.11.0 (these are the minimum versions enforced by glib-networking's configure.ac). * efl/jhbuild.modules: Do not build gnutls anymore, make glib-networking depend on glib instead, and move the libgcrypt dependency to eet, which is what currently needs it. * gtk/jhbuild.modules: Do not build gnutls anymore. Modified Paths trunk/Tools/ChangeLog trunk/Tools/efl/jhbuild.modules trunk/Tools/gtk/jhbuild.modules Diff Modified: trunk/Tools/ChangeLog (124093 => 124094) --- trunk/Tools/ChangeLog 2012-07-30 21:33:32 UTC (rev 124093) +++ trunk/Tools/ChangeLog 2012-07-30 21:35:10 UTC (rev 124094) @@ -1,3 +1,27 @@ +2012-07-30 Raphael Kubo da Costa rak...@webkit.org + +[jhbuild] gnutls 2.12.14 does not build with glibc 2.16.0 +https://bugs.webkit.org/show_bug.cgi?id=90643 + +Reviewed by Gustavo Noronha Silva. + +The 2.x series of gnutls has a version of Gnulib that is +incompatible with glibc 2.16.0, which now does not define gets() +by default. + +After talking to kov, mrobinson and philn, it looks like it makes +sense to simply remove gnutls from jhbuild.modules and rely on the +version installed on the system being recent enough. + +This means at least version 2.12.8 for PKCS11 support, or at the +very least 2.11.0 (these are the minimum versions enforced by +glib-networking's configure.ac). + +* efl/jhbuild.modules: Do not build gnutls anymore, make +glib-networking depend on glib instead, and move the libgcrypt +dependency to eet, which is what currently needs it. +* gtk/jhbuild.modules: Do not build gnutls anymore. + 2012-07-30 Dirk Pranke dpra...@chromium.org nrwt: --verbose logging does not work right on windows Modified: trunk/Tools/efl/jhbuild.modules (124093 => 124094) --- trunk/Tools/efl/jhbuild.modules 2012-07-30 21:33:32 UTC (rev 124093) +++ trunk/Tools/efl/jhbuild.modules 2012-07-30 21:35:10 UTC (rev 124094) @@ -32,8 +32,6 @@ href="" repository type=git name=git.gnome.org href="" - repository type=tarball name=gnu.org - href="" repository type=tarball name=cairographics.org href="" repository type=tarball name=freedesktop.org @@ -62,7 +60,6 @@ /branch /autotools - autotools id=fonts skip-autogen=true branch module=downloads/mrobinson/webkitgtk-test-fonts/webkitgtk-test-fonts-0.0.3.tar.gz version=0.0.3 @@ -122,7 +119,7 @@ autotools id=glib-networking dependencies - dep package=gnutls/ + dep package=glib/ /dependencies branch module=/pub/GNOME/sources/glib-networking/2.33/glib-networking-2.33.2.tar.xz version=2.33.2 repo=ftp.gnome.org @@ -130,18 +127,6 @@ md5sum=5abb364f2a0babe2ec1e3a6d59f69043/ /autotools - autotools id=gnutls - autogenargs=--enable-ld-version-script --enable-cxx --without-lzo --with-libgcrypt -dependencies - dep package=libgcrypt/ - dep package=p11-kit/ -/dependencies -branch module=/gnu/gnutls/gnutls-2.12.14.tar.bz2 version=2.12.14 -repo=gnu.org -hash=sha256:5ee72ba6de7a23cf315792561954451e022dac8730149ca95f93c61e95be2ce3 -md5sum=555687a7ffefba0bd9de1e71cb61402c/ - /autotools - autotools id=libsoup autogenargs=--without-gnome --disable-introspection dependencies @@ -206,6 +191,7 @@ repo=enlightenment.org revision=73027/ dependencies + dep package=libgcrypt/ dep package=eina/ /dependencies /autotools Modified: trunk/Tools/gtk/jhbuild.modules (124093 => 124094) --- trunk/Tools/gtk/jhbuild.modules 2012-07-30 21:33:32 UTC (rev 124093) +++ trunk/Tools/gtk/jhbuild.modules 2012-07-30 21:35:10 UTC (rev 124094) @@ -32,8 +32,6 @@ href="" repository type=git name=git.gnome.org href="" - repository type=tarball name=gnu.org - href="" repository type=tarball name=cairographics.org href="" repository type=tarball name=freedesktop.org @@ -153,7 +151,6 @@ autotools id=glib-networking dependencies dep package=glib/ - dep package=gnutls/ /dependencies branch module=/pub/GNOME/sources/glib-networking/2.33/glib-networking-2.33.2.tar.xz version=2.33.2
[webkit-changes] [124095] trunk/Source/WTF
Title: [124095] trunk/Source/WTF
Revision 124095
Author par...@webkit.org
Date 2012-07-30 14:53:03 -0700 (Mon, 30 Jul 2012)
Log Message
Add function to calculate the day in year from a date
https://bugs.webkit.org/show_bug.cgi?id=92671
Reviewed by Ryosuke Niwa.
Replace monthToDayInYear() with dayInYear() which takes a whole
date for calculation and will be used for bug 92286 later.
* wtf/DateMath.cpp:
(WTF::dayInYear):
(WTF::dateToDaysFrom1970):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/DateMath.cpp
Diff
Modified: trunk/Source/WTF/ChangeLog (124094 => 124095)
--- trunk/Source/WTF/ChangeLog 2012-07-30 21:35:10 UTC (rev 124094)
+++ trunk/Source/WTF/ChangeLog 2012-07-30 21:53:03 UTC (rev 124095)
@@ -1,5 +1,19 @@
2012-07-30 Patrick Gansterer par...@webkit.org
+Add function to calculate the day in year from a date
+https://bugs.webkit.org/show_bug.cgi?id=92671
+
+Reviewed by Ryosuke Niwa.
+
+Replace monthToDayInYear() with dayInYear() which takes a whole
+date for calculation and will be used for bug 92286 later.
+
+* wtf/DateMath.cpp:
+(WTF::dayInYear):
+(WTF::dateToDaysFrom1970):
+
+2012-07-30 Patrick Gansterer par...@webkit.org
+
Add special export macro for string related functions
https://bugs.webkit.org/show_bug.cgi?id=92624
Modified: trunk/Source/WTF/wtf/DateMath.cpp (124094 => 124095)
--- trunk/Source/WTF/wtf/DateMath.cpp 2012-07-30 21:35:10 UTC (rev 124094)
+++ trunk/Source/WTF/wtf/DateMath.cpp 2012-07-30 21:53:03 UTC (rev 124095)
@@ -286,9 +286,9 @@
return d - step;
}
-static inline int monthToDayInYear(int month, bool isLeapYear)
+static inline int dayInYear(int year, int month, int day)
{
-return firstDayOfMonth[isLeapYear][month];
+return firstDayOfMonth[isLeapYear(year)][month] + day - 1;
}
double dateToDaysFrom1970(int year, int month, int day)
@@ -303,9 +303,7 @@
double yearday = floor(daysFrom1970ToYear(year));
ASSERT((year = 1970 yearday = 0) || (year 1970 yearday 0));
-int monthday = monthToDayInYear(month, isLeapYear(year));
-
-return yearday + monthday + day - 1;
+return yearday + dayInYear(year, month, day);
}
// There is a hard limit at 2038 that we currently do not have a workaround
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124096] branches/safari-536.26-branch
Title: [124096] branches/safari-536.26-branch
Revision 124096
Author lforsch...@apple.com
Date 2012-07-30 15:02:45 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r118213. rdar://problem/11942131
Modified Paths
branches/safari-536.26-branch/LayoutTests/ChangeLog
branches/safari-536.26-branch/Source/WebCore/ChangeLog
branches/safari-536.26-branch/Source/WebCore/accessibility/AccessibilityObject.h
branches/safari-536.26-branch/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
Added Paths
branches/safari-536.26-branch/LayoutTests/accessibility/content-changed-notification-causes-crash-expected.txt
branches/safari-536.26-branch/LayoutTests/accessibility/content-changed-notification-causes-crash.html
Diff
Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (124095 => 124096)
--- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 21:53:03 UTC (rev 124095)
+++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 22:02:45 UTC (rev 124096)
@@ -1,5 +1,19 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 118213
+
+2012-05-23 Chris Fleizach cfleiz...@apple.com
+
+Regression(r112694): Crash in WebCore::AXObjectCache::postNotification
+https://bugs.webkit.org/show_bug.cgi?id=86029
+
+Reviewed by Abhishek Arya.
+
+* accessibility/content-changed-notification-causes-crash-expected.txt: Added.
+* accessibility/content-changed-notification-causes-crash.html: Added.
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 117801
2012-05-21 Brady Eidson beid...@apple.com
Copied: branches/safari-536.26-branch/LayoutTests/accessibility/content-changed-notification-causes-crash-expected.txt (from rev 118213, trunk/LayoutTests/accessibility/content-changed-notification-causes-crash-expected.txt) (0 => 124096)
--- branches/safari-536.26-branch/LayoutTests/accessibility/content-changed-notification-causes-crash-expected.txt (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/accessibility/content-changed-notification-causes-crash-expected.txt 2012-07-30 22:02:45 UTC (rev 124096)
@@ -0,0 +1,11 @@
+
+Ensures that this snippet does not lead to a crash. Bug 86029.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS. WebKit did not crash.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Copied: branches/safari-536.26-branch/LayoutTests/accessibility/content-changed-notification-causes-crash.html (from rev 118213, trunk/LayoutTests/accessibility/content-changed-notification-causes-crash.html) (0 => 124096)
--- branches/safari-536.26-branch/LayoutTests/accessibility/content-changed-notification-causes-crash.html (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/accessibility/content-changed-notification-causes-crash.html 2012-07-30 22:02:45 UTC (rev 124096)
@@ -0,0 +1,38 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+script src=""
+/head
+body
+
+div id=group tabindex=0
+
+ul role=textbox style='-webkit-transition: -webkit-transform linear 1117401740208157342s; content: counters(c, ., disc); 'keygen autofocus=body style='outline-style: ridge; font: normal normal 29266em/99 Ahem, serif; '
+
+/div
+
+p id=description/p
+div id=console/div
+
+script
+description(Ensures that this snippet does not lead to a crash. Bug 86029.);
+
+function walkAccessibilityTree(accessibilityObject) {
+var count = accessibilityObject.childrenCount;
+for (var i = 0; i count; ++i)
+accessibilityObject.childAtIndex(i);
+}
+
+if (window.accessibilityController) {
+
+document.getElementById(group).focus();
+var focusedElement = accessibilityController.focusedElement;
+walkAccessibilityTree(focusedElement);
+
+document.getElementById('console').innerHTML += PASS. WebKit did not crash.br;
+}
+/script
+
+script src=""
+/body
+/html
Modified: branches/safari-536.26-branch/Source/WebCore/ChangeLog (124095 => 124096)
--- branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 21:53:03 UTC (rev 124095)
+++ branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 22:02:45 UTC (rev 124096)
@@ -1,5 +1,24 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 118213
+
+2012-05-23 Chris Fleizach cfleiz...@apple.com
+
+Regression(r112694): Crash in WebCore::AXObjectCache::postNotification
+https://bugs.webkit.org/show_bug.cgi?id=86029
+
+Reviewed by Abhishek Arya.
+
+Test: accessibility/content-changed-notification-causes-crash.html
+
+* accessibility/AccessibilityObject.h:
+(WebCore::AccessibilityObject::isDetached):
+(AccessibilityObject):
+* accessibility/AccessibilityRenderObject.cpp:
[webkit-changes] [124097] trunk/Source
Title: [124097] trunk/Source Revision 124097 Author commit-qu...@webkit.org Date 2012-07-30 15:04:00 -0700 (Mon, 30 Jul 2012) Log Message Plumb vsync-enabled flag up to compositor thread and support disable-vsync https://bugs.webkit.org/show_bug.cgi?id=92323 Patch by John Bates jba...@google.com on 2012-07-30 Reviewed by James Robinson. Source/Platform: * chromium/public/WebLayerTreeView.h: (WebKit::WebLayerTreeView::Settings::Settings): (Settings): Source/WebCore: * platform/graphics/chromium/cc/CCFrameRateController.cpp: (WebCore::CCFrameRateController::CCFrameRateController): (WebCore::CCFrameRateController::disableTimeSourceThrottling): (WebCore): (WebCore::CCFrameRateController::setActive): (WebCore::CCFrameRateController::postManualTick): (WebCore::CCFrameRateController::onTimerFired): (WebCore::CCFrameRateController::didBeginFrame): (WebCore::CCFrameRateController::didFinishFrame): * platform/graphics/chromium/cc/CCFrameRateController.h: (WebCore): (CCFrameRateController): * platform/graphics/chromium/cc/CCLayerTreeHost.h: (WebCore::CCLayerTreeSettings::CCLayerTreeSettings): (CCLayerTreeSettings): * platform/graphics/chromium/cc/CCThreadProxy.cpp: (WebCore::CCThreadProxy::CCThreadProxy): (WebCore::CCThreadProxy::initializeImplOnImplThread): * platform/graphics/chromium/cc/CCThreadProxy.h: (CCThreadProxy): Source/WebKit/chromium: * public/WebSettings.h: * tests/CCFrameRateControllerTest.cpp: * src/WebLayerTreeView.cpp: (WebKit::WebLayerTreeView::Settings::operator CCLayerTreeSettings): * src/WebSettingsImpl.cpp: (WebKit::WebSettingsImpl::WebSettingsImpl): (WebKit::WebSettingsImpl::setRenderVSyncEnabled): (WebKit): * src/WebSettingsImpl.h: (WebSettingsImpl): (WebKit::WebSettingsImpl::renderVSyncEnabled): * src/WebViewImpl.cpp: (WebKit::WebViewImpl::setIsAcceleratedCompositingActive): Modified Paths trunk/Source/Platform/ChangeLog trunk/Source/Platform/chromium/public/WebLayerTreeView.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/graphics/chromium/cc/CCFrameRateController.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCFrameRateController.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.h trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/public/WebSettings.h trunk/Source/WebKit/chromium/src/WebLayerTreeView.cpp trunk/Source/WebKit/chromium/src/WebSettingsImpl.cpp trunk/Source/WebKit/chromium/src/WebSettingsImpl.h trunk/Source/WebKit/chromium/src/WebViewImpl.cpp trunk/Source/WebKit/chromium/tests/CCFrameRateControllerTest.cpp Diff Modified: trunk/Source/Platform/ChangeLog (124096 => 124097) --- trunk/Source/Platform/ChangeLog 2012-07-30 22:02:45 UTC (rev 124096) +++ trunk/Source/Platform/ChangeLog 2012-07-30 22:04:00 UTC (rev 124097) @@ -1,3 +1,14 @@ +2012-07-30 John Bates jba...@google.com + +Plumb vsync-enabled flag up to compositor thread and support disable-vsync +https://bugs.webkit.org/show_bug.cgi?id=92323 + +Reviewed by James Robinson. + +* chromium/public/WebLayerTreeView.h: +(WebKit::WebLayerTreeView::Settings::Settings): +(Settings): + 2012-07-30 Adrienne Walker e...@google.com [chromium] Remove dependency on ScrollbarTheme from the compositor Modified: trunk/Source/Platform/chromium/public/WebLayerTreeView.h (124096 => 124097) --- trunk/Source/Platform/chromium/public/WebLayerTreeView.h 2012-07-30 22:02:45 UTC (rev 124096) +++ trunk/Source/Platform/chromium/public/WebLayerTreeView.h 2012-07-30 22:04:00 UTC (rev 124097) @@ -55,6 +55,7 @@ , showFPSCounter(false) , showPlatformLayerTree(false) , showPaintRects(false) +, renderVSyncEnabled(true) , refreshRate(0) , defaultTileSize(WebSize(256, 256)) , maxUntiledLayerSize(WebSize(512, 512)) @@ -66,6 +67,7 @@ bool showFPSCounter; bool showPlatformLayerTree; bool showPaintRects; +bool renderVSyncEnabled; double refreshRate; WebSize defaultTileSize; WebSize maxUntiledLayerSize; Modified: trunk/Source/WebCore/ChangeLog (124096 => 124097) --- trunk/Source/WebCore/ChangeLog 2012-07-30 22:02:45 UTC (rev 124096) +++ trunk/Source/WebCore/ChangeLog 2012-07-30 22:04:00 UTC (rev 124097) @@ -1,3 +1,31 @@ +2012-07-30 John Bates jba...@google.com + +Plumb vsync-enabled flag up to compositor thread and support disable-vsync +https://bugs.webkit.org/show_bug.cgi?id=92323 + +Reviewed by James Robinson. + +* platform/graphics/chromium/cc/CCFrameRateController.cpp: +(WebCore::CCFrameRateController::CCFrameRateController): +(WebCore::CCFrameRateController::disableTimeSourceThrottling): +(WebCore): +(WebCore::CCFrameRateController::setActive): +
[webkit-changes] [124098] trunk
Title: [124098] trunk Revision 124098 Author commit-qu...@webkit.org Date 2012-07-30 15:13:17 -0700 (Mon, 30 Jul 2012) Log Message Propagate gesture events to plugins. https://bugs.webkit.org/show_bug.cgi?id=92281 Patch by Sadrul Habib Chowdhury sad...@chromium.org on 2012-07-30 Reviewed by Adam Barth. Source/WebCore: Propagate gesture events to plugins. This change does not expose the gesture events to _javascript_, since there is no spec for that at the moment. Exposing gesture events to _javascript_ will be done separately, once there is a spec for it. Test: platform/chromium/plugins/gesture-events.html * CMakeLists.txt: * GNUmakefile.list.am: * Target.pri: * WebCore.gypi: * WebCore.xcodeproj/project.pbxproj: * dom/EventNames.h: (WebCore): (WebCore::EventNames::isGestureEventType): (EventNames): * dom/GestureEvent.cpp: Added. (WebCore): (WebCore::GestureEvent::create): (WebCore::GestureEvent::initGestureEvent): (WebCore::GestureEvent::interfaceName): (WebCore::GestureEvent::GestureEvent): (WebCore::GestureEventDispatchMediator::GestureEventDispatchMediator): (WebCore::GestureEventDispatchMediator::event): (WebCore::GestureEventDispatchMediator::dispatchEvent): * dom/GestureEvent.h: Added. (WebCore): (GestureEvent): (WebCore::GestureEvent::~GestureEvent): (WebCore::GestureEvent::deltaX): (WebCore::GestureEvent::deltaY): (WebCore::GestureEvent::GestureEvent): (GestureEventDispatchMediator): (WebCore::GestureEventDispatchMediator::create): * dom/Node.cpp: (WebCore): (WebCore::Node::dispatchGestureEvent): * dom/Node.h: (WebCore): (Node): * page/EventHandler.cpp: (WebCore::EventHandler::clear): (WebCore::EventHandler::handleGestureEvent): * page/EventHandler.h: Source/WebKit/chromium: Propagate gesture events to plugins. * src/WebInputEventConversion.cpp: (WebKit): (WebKit::WebGestureEventBuilder::WebGestureEventBuilder): * src/WebInputEventConversion.h: (WebCore): (WebKit): (WebGestureEventBuilder): * src/WebPluginContainerImpl.cpp: (WebKit::WebPluginContainerImpl::handleEvent): * src/WebPluginContainerImpl.h: (WebCore): (WebPluginContainerImpl): Tools: Update TestWebPlugin to receive events, and output logs for the events. * DumpRenderTree/chromium/TestWebPlugin.cpp: (TestWebPlugin::handleInputEvent): * DumpRenderTree/chromium/TestWebPlugin.h: (TestWebPlugin::acceptsInputEvents): (TestWebPlugin): LayoutTests: Added a layout test to show that the plugins receive the gesture events correctly. * platform/chromium/plugins/gesture-events-expected.txt: Added. * platform/chromium/plugins/gesture-events.html: Added. Modified Paths trunk/LayoutTests/ChangeLog trunk/Source/WebCore/CMakeLists.txt trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/GNUmakefile.list.am trunk/Source/WebCore/Target.pri trunk/Source/WebCore/WebCore.gypi trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj trunk/Source/WebCore/dom/EventNames.h trunk/Source/WebCore/dom/Node.cpp trunk/Source/WebCore/dom/Node.h trunk/Source/WebCore/page/EventHandler.cpp trunk/Source/WebCore/page/EventHandler.h trunk/Source/WebKit/chromium/ChangeLog trunk/Source/WebKit/chromium/src/WebInputEventConversion.cpp trunk/Source/WebKit/chromium/src/WebInputEventConversion.h trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.cpp trunk/Source/WebKit/chromium/src/WebPluginContainerImpl.h trunk/Tools/ChangeLog trunk/Tools/DumpRenderTree/chromium/TestWebPlugin.cpp trunk/Tools/DumpRenderTree/chromium/TestWebPlugin.h Added Paths trunk/LayoutTests/platform/chromium/plugins/gesture-events-expected.txt trunk/LayoutTests/platform/chromium/plugins/gesture-events.html trunk/Source/WebCore/dom/GestureEvent.cpp trunk/Source/WebCore/dom/GestureEvent.h Diff Modified: trunk/LayoutTests/ChangeLog (124097 => 124098) --- trunk/LayoutTests/ChangeLog 2012-07-30 22:04:00 UTC (rev 124097) +++ trunk/LayoutTests/ChangeLog 2012-07-30 22:13:17 UTC (rev 124098) @@ -1,3 +1,15 @@ +2012-07-30 Sadrul Habib Chowdhury sad...@chromium.org + +Propagate gesture events to plugins. +https://bugs.webkit.org/show_bug.cgi?id=92281 + +Reviewed by Adam Barth. + +Added a layout test to show that the plugins receive the gesture events correctly. + +* platform/chromium/plugins/gesture-events-expected.txt: Added. +* platform/chromium/plugins/gesture-events.html: Added. + 2012-07-30 Adrienne Walker e...@google.com [chromium] Remove dependency on ScrollbarTheme from the compositor Added: trunk/LayoutTests/platform/chromium/plugins/gesture-events-expected.txt (0 => 124098) --- trunk/LayoutTests/platform/chromium/plugins/gesture-events-expected.txt (rev 0) +++ trunk/LayoutTests/platform/chromium/plugins/gesture-events-expected.txt 2012-07-30 22:13:17 UTC (rev 124098) @@ -0,0 +1,10 @@ +Plugin received event: GestureTap +Plugin received event: MouseEnter +Plugin received event: MouseMove +Plugin received event: MouseDown +Plugin received event: MouseUp +Plugin received event:
[webkit-changes] [124099] trunk/Source/WebCore
Title: [124099] trunk/Source/WebCore
Revision 124099
Author alexis.men...@openbossa.org
Date 2012-07-30 15:18:20 -0700 (Mon, 30 Jul 2012)
Log Message
Build fix with newer bison 2.6.
https://bugs.webkit.org/show_bug.cgi?id=92264
Reviewed by Adam Barth.
As stated in http://www.gnu.org/software/bison/manual/html_node/Table-of-Symbols.html
YYLEX_PARAM and YYPARSE_PARAM are depecreated since version 1.875. So far all Mac OS
version I had access to as well as recent Linux runs at least version 2.3 so it's safe
to use the replacement of these deprecated macros in favor of %lex-param and %parse-param.
As announced http://lists.gnu.org/archive/html/info-gnu/2012-07/msg00011.html with the release
of version 2.6 YYLEX_PARAM and YYPARSE_PARAM are not supported anymore.
No new tests : build fix and the patch should not trigger any regressions
* css/CSSGrammar.y:
* css/CSSParser.cpp:
* xml/XPathGrammar.y: Refactored a bit to not use an intermediate PARSER define.
* xml/XPathParser.cpp: bison 2.6 declare xpathyyparse in the .h file now, i.e. XPathGrammar.h
therefore including this file within the namespace {} declarations leads to xpathyyparse being
defined part of WebCore::XPath namespaces but the actual implementation of xpathyyparse is in XPathGrammar.cpp
(generated) and not implemented within the WebCore::XPath so it lead to linking issues. Last, XPathGrammar.h needs
to be included after the other includes as it uses some XPath types. It breaks the style but CSSParser.cpp is doing the same.
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSGrammar.y
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/xml/XPathGrammar.y
trunk/Source/WebCore/xml/XPathParser.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (124098 => 124099)
--- trunk/Source/WebCore/ChangeLog 2012-07-30 22:13:17 UTC (rev 124098)
+++ trunk/Source/WebCore/ChangeLog 2012-07-30 22:18:20 UTC (rev 124099)
@@ -1,3 +1,28 @@
+2012-07-30 Alexis Menard alexis.men...@openbossa.org
+
+Build fix with newer bison 2.6.
+https://bugs.webkit.org/show_bug.cgi?id=92264
+
+Reviewed by Adam Barth.
+
+As stated in http://www.gnu.org/software/bison/manual/html_node/Table-of-Symbols.html
+YYLEX_PARAM and YYPARSE_PARAM are depecreated since version 1.875. So far all Mac OS
+version I had access to as well as recent Linux runs at least version 2.3 so it's safe
+to use the replacement of these deprecated macros in favor of %lex-param and %parse-param.
+As announced http://lists.gnu.org/archive/html/info-gnu/2012-07/msg00011.html with the release
+of version 2.6 YYLEX_PARAM and YYPARSE_PARAM are not supported anymore.
+
+No new tests : build fix and the patch should not trigger any regressions
+
+* css/CSSGrammar.y:
+* css/CSSParser.cpp:
+* xml/XPathGrammar.y: Refactored a bit to not use an intermediate PARSER define.
+* xml/XPathParser.cpp: bison 2.6 declare xpathyyparse in the .h file now, i.e. XPathGrammar.h
+therefore including this file within the namespace {} declarations leads to xpathyyparse being
+defined part of WebCore::XPath namespaces but the actual implementation of xpathyyparse is in XPathGrammar.cpp
+(generated) and not implemented within the WebCore::XPath so it lead to linking issues. Last, XPathGrammar.h needs
+to be included after the other includes as it uses some XPath types. It breaks the style but CSSParser.cpp is doing the same.
+
2012-07-30 Sadrul Habib Chowdhury sad...@chromium.org
Propagate gesture events to plugins.
Modified: trunk/Source/WebCore/css/CSSGrammar.y (124098 => 124099)
--- trunk/Source/WebCore/css/CSSGrammar.y 2012-07-30 22:13:17 UTC (rev 124098)
+++ trunk/Source/WebCore/css/CSSGrammar.y 2012-07-30 22:18:20 UTC (rev 124099)
@@ -53,14 +53,13 @@
#define YYMAXDEPTH 1
#define YYDEBUG 0
-// FIXME: Replace with %parse-param { CSSParser* parser } once we can depend on bison 2.x
-#define YYPARSE_PARAM parser
-#define YYLEX_PARAM parser
-
%}
%pure_parser
+%parse-param { CSSParser* parser }
+%lex-param { CSSParser* parser }
+
%union {
bool boolean;
char character;
@@ -89,7 +88,7 @@
%{
-static inline int cssyyerror(const char*)
+static inline int cssyyerror(void*, const char*)
{
return 1;
}
Modified: trunk/Source/WebCore/css/CSSParser.cpp (124098 => 124099)
--- trunk/Source/WebCore/css/CSSParser.cpp 2012-07-30 22:13:17 UTC (rev 124098)
+++ trunk/Source/WebCore/css/CSSParser.cpp 2012-07-30 22:18:20 UTC (rev 124099)
@@ -114,7 +114,7 @@
extern int cssyydebug;
#endif
-extern int cssyyparse(void* parser);
+extern int cssyyparse(WebCore::CSSParser*);
using namespace std;
using namespace WTF;
Modified: trunk/Source/WebCore/xml/XPathGrammar.y (124098 => 124099)
--- trunk/Source/WebCore/xml/XPathGrammar.y 2012-07-30 22:13:17 UTC (rev 124098)
+++ trunk/Source/WebCore/xml/XPathGrammar.y
[webkit-changes] [124100] branches/safari-536.26-branch
Title: [124100] branches/safari-536.26-branch
Revision 124100
Author lforsch...@apple.com
Date 2012-07-30 15:21:45 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r118248. rdar://problem/11942129
Modified Paths
branches/safari-536.26-branch/LayoutTests/ChangeLog
branches/safari-536.26-branch/Source/WebCore/ChangeLog
branches/safari-536.26-branch/Source/WebCore/rendering/RenderBlockLineLayout.cpp
Added Paths
branches/safari-536.26-branch/LayoutTests/fast/block/inline-children-root-linebox-crash-expected.txt
branches/safari-536.26-branch/LayoutTests/fast/block/inline-children-root-linebox-crash.html
Diff
Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (124099 => 124100)
--- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 22:18:20 UTC (rev 124099)
+++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 22:21:45 UTC (rev 124100)
@@ -1,5 +1,19 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 118248
+
+2012-05-23 Abhishek Arya infe...@chromium.org
+
+Crash in RenderInline::linesVisualOverflowBoundingBox.
+https://bugs.webkit.org/show_bug.cgi?id=85804
+
+Reviewed by Dave Hyatt.
+
+* fast/block/inline-children-root-linebox-crash-expected.txt: Added.
+* fast/block/inline-children-root-linebox-crash.html: Added.
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 118213
2012-05-23 Chris Fleizach cfleiz...@apple.com
Copied: branches/safari-536.26-branch/LayoutTests/fast/block/inline-children-root-linebox-crash-expected.txt (from rev 118248, trunk/LayoutTests/fast/block/inline-children-root-linebox-crash-expected.txt) (0 => 124100)
--- branches/safari-536.26-branch/LayoutTests/fast/block/inline-children-root-linebox-crash-expected.txt (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/fast/block/inline-children-root-linebox-crash-expected.txt 2012-07-30 22:21:45 UTC (rev 124100)
@@ -0,0 +1,3 @@
+WebKit Bug 85804 - Crash in RenderInline::linesVisualOverflowBoundingBox.
+Test passes if it does not crash.
+
Copied: branches/safari-536.26-branch/LayoutTests/fast/block/inline-children-root-linebox-crash.html (from rev 118248, trunk/LayoutTests/fast/block/inline-children-root-linebox-crash.html) (0 => 124100)
--- branches/safari-536.26-branch/LayoutTests/fast/block/inline-children-root-linebox-crash.html (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/fast/block/inline-children-root-linebox-crash.html 2012-07-30 22:21:45 UTC (rev 124100)
@@ -0,0 +1,17 @@
+!DOCTYPE html
+html
+WebKit Bug 85804 - Crash in RenderInline::linesVisualOverflowBoundingBox.br /
+Test passes if it does not crash.
+div style='-webkit-writing-mode: vertical-rl;'
+div style='-webkit-transform: translatey(1px) translatez(1px) rotatex(1deg);'/div
+textarea/textarea
+span style='-webkit-opacity: 0.0;'/
+input autofocus
+/div
+body dir=rtl
+/body
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+/script
+/html
Modified: branches/safari-536.26-branch/Source/WebCore/ChangeLog (124099 => 124100)
--- branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 22:18:20 UTC (rev 124099)
+++ branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 22:21:45 UTC (rev 124100)
@@ -1,5 +1,26 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 118248
+
+2012-05-23 Abhishek Arya infe...@chromium.org
+
+Crash in RenderInline::linesVisualOverflowBoundingBox.
+https://bugs.webkit.org/show_bug.cgi?id=85804
+
+Reviewed by Dave Hyatt.
+
+Defer layout of replaced elements to the next line break function.
+We shouldn't do it while we are clearing our inline chilren
+lineboxes in full layout mode.
+
+Test: fast/block/inline-children-root-linebox-crash.html
+
+* rendering/RenderBlockLineLayout.cpp:
+(WebCore::RenderBlock::layoutInlineChildren):
+(WebCore::RenderBlock::LineBreaker::nextLineBreak):
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 118213
2012-05-23 Chris Fleizach cfleiz...@apple.com
Modified: branches/safari-536.26-branch/Source/WebCore/rendering/RenderBlockLineLayout.cpp (124099 => 124100)
--- branches/safari-536.26-branch/Source/WebCore/rendering/RenderBlockLineLayout.cpp 2012-07-30 22:18:20 UTC (rev 124099)
+++ branches/safari-536.26-branch/Source/WebCore/rendering/RenderBlockLineLayout.cpp 2012-07-30 22:21:45 UTC (rev 124100)
@@ -1499,7 +1499,6 @@
else if (layoutState.isFullLayout() || o-needsLayout()) {
// Replaced elements
toRenderBox(o)-dirtyLineBoxes(layoutState.isFullLayout());
-o-layoutIfNeeded();
}
} else if (o-isText() || (o-isRenderInline() !walker.atEndOfInline())) {
if (!o-isText())
[webkit-changes] [124101] branches/safari-536.26-branch
Title: [124101] branches/safari-536.26-branch Revision 124101 Author lforsch...@apple.com Date 2012-07-30 15:26:01 -0700 (Mon, 30 Jul 2012) Log Message Merged r118316. rdar://problem/11942151 Modified Paths branches/safari-536.26-branch/LayoutTests/ChangeLog branches/safari-536.26-branch/Source/WebCore/ChangeLog branches/safari-536.26-branch/Source/WebCore/rendering/RenderTableCol.cpp Added Paths branches/safari-536.26-branch/LayoutTests/fast/table/canvas-column-in-column-group-expected.txt branches/safari-536.26-branch/LayoutTests/fast/table/canvas-column-in-column-group.html branches/safari-536.26-branch/LayoutTests/fast/table/columngroup-inside-columngroup-expected.txt branches/safari-536.26-branch/LayoutTests/fast/table/columngroup-inside-columngroup.html Diff Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (124100 => 124101) --- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 22:21:45 UTC (rev 124100) +++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 22:26:01 UTC (rev 124101) @@ -1,5 +1,21 @@ 2012-07-30 Lucas Forschler lforsch...@apple.com +Merge 118316 + +2012-05-23 Julien Chaffraix jchaffr...@webkit.org + +Crash in RenderTableCol::nextColumn +https://bugs.webkit.org/show_bug.cgi?id=87314 + +Reviewed by Abhishek Arya. + +* fast/table/canvas-column-in-column-group-expected.txt: Added. +* fast/table/canvas-column-in-column-group.html: Added. +* fast/table/columngroup-inside-columngroup-expected.txt: Added. +* fast/table/columngroup-inside-columngroup.html: Added. + +2012-07-30 Lucas Forschler lforsch...@apple.com + Merge 118248 2012-05-23 Abhishek Arya infe...@chromium.org Copied: branches/safari-536.26-branch/LayoutTests/fast/table/canvas-column-in-column-group-expected.txt (from rev 118316, trunk/LayoutTests/fast/table/canvas-column-in-column-group-expected.txt) (0 => 124101) --- branches/safari-536.26-branch/LayoutTests/fast/table/canvas-column-in-column-group-expected.txt (rev 0) +++ branches/safari-536.26-branch/LayoutTests/fast/table/canvas-column-in-column-group-expected.txt 2012-07-30 22:26:01 UTC (rev 124101) @@ -0,0 +1,3 @@ +Test for bug 87314: Crash in RenderTableCol::nextColumn + +PASSED, this test didn't crash or ASSERT. Copied: branches/safari-536.26-branch/LayoutTests/fast/table/canvas-column-in-column-group.html (from rev 118316, trunk/LayoutTests/fast/table/canvas-column-in-column-group.html) (0 => 124101) --- branches/safari-536.26-branch/LayoutTests/fast/table/canvas-column-in-column-group.html (rev 0) +++ branches/safari-536.26-branch/LayoutTests/fast/table/canvas-column-in-column-group.html 2012-07-30 22:26:01 UTC (rev 124101) @@ -0,0 +1,19 @@ +!DOCTYPE html +pTest for bug a href="" Crash in RenderTableCol::nextColumn/p +table +colgroup +/colgroup +tbody +td/td +/tbody +/table +script +if (window.layoutTestController) +layoutTestController.dumpAsText(); + +var canvas = document.createElement(canvas); +canvas.style.display = table-column; +document.getElementsByTagName(colgroup)[0].appendChild(canvas); +document.body.offsetTop; +document.body.appendChild(document.createTextNode(PASSED, this test didn't crash or ASSERT.)); +/script Copied: branches/safari-536.26-branch/LayoutTests/fast/table/columngroup-inside-columngroup-expected.txt (from rev 118316, trunk/LayoutTests/fast/table/columngroup-inside-columngroup-expected.txt) (0 => 124101) --- branches/safari-536.26-branch/LayoutTests/fast/table/columngroup-inside-columngroup-expected.txt (rev 0) +++ branches/safari-536.26-branch/LayoutTests/fast/table/columngroup-inside-columngroup-expected.txt 2012-07-30 22:26:01 UTC (rev 124101) @@ -0,0 +1,3 @@ +Test for bug 87314: Crash in RenderTableCol::nextColumn + +PASSED, this test didn't crash or ASSERT. Copied: branches/safari-536.26-branch/LayoutTests/fast/table/columngroup-inside-columngroup.html (from rev 118316, trunk/LayoutTests/fast/table/columngroup-inside-columngroup.html) (0 => 124101) --- branches/safari-536.26-branch/LayoutTests/fast/table/columngroup-inside-columngroup.html (rev 0) +++ branches/safari-536.26-branch/LayoutTests/fast/table/columngroup-inside-columngroup.html 2012-07-30 22:26:01 UTC (rev 124101) @@ -0,0 +1,18 @@ +!DOCTYPE html +pTest for bug a href="" Crash in RenderTableCol::nextColumn/p +table +colgroup +/colgroup +tbody +td/td +/tbody +/table +script +if (window.layoutTestController) +layoutTestController.dumpAsText(); + +var colgroup = document.createElement(colgroup); +document.getElementsByTagName(colgroup)[0].appendChild(colgroup); +document.body.offsetTop; +document.body.appendChild(document.createTextNode(PASSED, this test didn't crash or ASSERT.)); +/script
[webkit-changes] [124102] trunk/Source/WebCore
Title: [124102] trunk/Source/WebCore
Revision 124102
Author ander...@apple.com
Date 2012-07-30 15:27:38 -0700 (Mon, 30 Jul 2012)
Log Message
Crash in logging code if MIME type is null
https://bugs.webkit.org/show_bug.cgi?id=92683
rdar://problem/11985295
Reviewed by Dan Bernstein.
If the MIME type is null, try to figure it out from the URL extension. If this fails, return early instead of crashing
trying to insert the null string into a hash set.
* loader/SubframeLoader.cpp:
(WebCore::logPluginRequest):
Modified Paths
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/SubframeLoader.cpp
Diff
Modified: trunk/Source/WebCore/ChangeLog (124101 => 124102)
--- trunk/Source/WebCore/ChangeLog 2012-07-30 22:26:01 UTC (rev 124101)
+++ trunk/Source/WebCore/ChangeLog 2012-07-30 22:27:38 UTC (rev 124102)
@@ -1,3 +1,17 @@
+2012-07-30 Anders Carlsson ander...@apple.com
+
+Crash in logging code if MIME type is null
+https://bugs.webkit.org/show_bug.cgi?id=92683
+rdar://problem/11985295
+
+Reviewed by Dan Bernstein.
+
+If the MIME type is null, try to figure it out from the URL extension. If this fails, return early instead of crashing
+trying to insert the null string into a hash set.
+
+* loader/SubframeLoader.cpp:
+(WebCore::logPluginRequest):
+
2012-07-30 Alexis Menard alexis.men...@openbossa.org
Build fix with newer bison 2.6.
Modified: trunk/Source/WebCore/loader/SubframeLoader.cpp (124101 => 124102)
--- trunk/Source/WebCore/loader/SubframeLoader.cpp 2012-07-30 22:26:01 UTC (rev 124101)
+++ trunk/Source/WebCore/loader/SubframeLoader.cpp 2012-07-30 22:27:38 UTC (rev 124102)
@@ -134,21 +134,52 @@
return loadPlugin(ownerElement, url, mimeType, paramNames, paramValues, useFallback);
}
-static void logPluginRequest(Page* page, const String mimeType, bool success)
+static String findPluginMIMETypeFromURL(Page* page, const String url)
{
+if (!url)
+return String();
+
+size_t dotIndex = url.reverseFind('.');
+if (dotIndex == notFound)
+return String();
+
+String extension = url.substring(dotIndex + 1);
+
+PluginData* pluginData = page-pluginData();
+for (size_t i = 0; i pluginData-mimes().size(); ++i) {
+const MimeClassInfo mimeClassInfo = pluginData-mimes()[i];
+for (size_t j = 0; j mimeClassInfo.extensions.size(); ++j) {
+if (equalIgnoringCase(extension, mimeClassInfo.extensions[j]))
+return mimeClassInfo.type;
+}
+}
+
+return String();
+}
+
+static void logPluginRequest(Page* page, const String mimeType, const String url, bool success)
+{
if (!page || !page-settings()-diagnosticLoggingEnabled())
return;
-
+
+String newMIMEType = mimeType;
+if (!newMIMEType) {
+// Try to figure out the MIME type from the URL extension.
+newMIMEType = findPluginMIMETypeFromURL(page, url);
+if (!newMIMEType)
+return;
+}
+
ChromeClient* client = page-chrome()-client();
-client-logDiagnosticMessage(success ? DiagnosticLoggingKeys::pluginLoadedKey() : DiagnosticLoggingKeys::pluginLoadingFailedKey(), mimeType, DiagnosticLoggingKeys::noopKey());
+client-logDiagnosticMessage(success ? DiagnosticLoggingKeys::pluginLoadedKey() : DiagnosticLoggingKeys::pluginLoadingFailedKey(), newMIMEType, DiagnosticLoggingKeys::noopKey());
if (!page-hasSeenAnyPlugin())
client-logDiagnosticMessage(DiagnosticLoggingKeys::pageContainsAtLeastOnePluginKey(), emptyString(), DiagnosticLoggingKeys::noopKey());
-if (!page-hasSeenPlugin(mimeType))
-client-logDiagnosticMessage(DiagnosticLoggingKeys::pageContainsPluginKey(), mimeType, DiagnosticLoggingKeys::noopKey());
+if (!page-hasSeenPlugin(newMIMEType))
+client-logDiagnosticMessage(DiagnosticLoggingKeys::pageContainsPluginKey(), newMIMEType, DiagnosticLoggingKeys::noopKey());
-page-sawPlugin(mimeType);
+page-sawPlugin(newMIMEType);
}
bool SubframeLoader::requestObject(HTMLPlugInImageElement* ownerElement, const String url, const AtomicString frameName, const String mimeType, const VectorString paramNames, const VectorString paramValues)
@@ -169,7 +200,7 @@
bool useFallback;
if (shouldUsePlugin(completedURL, mimeType, ownerElement-shouldPreferPlugInsForImages(), renderer-hasFallbackContent(), useFallback)) {
bool success = requestPlugin(ownerElement, completedURL, mimeType, paramNames, paramValues, useFallback);
-logPluginRequest(document()-page(), mimeType, success);
+logPluginRequest(document()-page(), mimeType, completedURL, success);
return success;
}
@@ -253,7 +284,7 @@
if (allowPlugins(AboutToInstantiatePlugin))
widget = m_frame-loader()-client()-createJavaAppletWidget(size, element, baseURL, paramNames, paramValues);
-logPluginRequest(document()-page(), element-serviceType(), widget);
+
[webkit-changes] [124103] branches/safari-536.26-branch
Title: [124103] branches/safari-536.26-branch Revision 124103 Author lforsch...@apple.com Date 2012-07-30 15:29:39 -0700 (Mon, 30 Jul 2012) Log Message Merged r118420. rdar://problem/11961148 Modified Paths branches/safari-536.26-branch/LayoutTests/ChangeLog branches/safari-536.26-branch/Source/WebCore/ChangeLog branches/safari-536.26-branch/Source/WebCore/rendering/InlineIterator.h branches/safari-536.26-branch/Source/WebCore/rendering/RenderBlock.h branches/safari-536.26-branch/Source/WebCore/rendering/RenderBlockLineLayout.cpp Added Paths branches/safari-536.26-branch/LayoutTests/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt branches/safari-536.26-branch/LayoutTests/fast/text/international/float-as-only-child-of-isolate-crash.html Diff Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (124102 => 124103) --- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 22:27:38 UTC (rev 124102) +++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 22:29:39 UTC (rev 124103) @@ -1,5 +1,19 @@ 2012-07-30 Lucas Forschler lforsch...@apple.com +Merge 118420 + +2012-05-24 Levi Weintraub le...@chromium.org + +Avoid creating InlineBoxes for floating and positioned objects in isolates. +https://bugs.webkit.org/show_bug.cgi?id=87277 + +Reviewed by Eric Seidel. + +* fast/text/international/float-as-only-child-of-isolate-crash-expected.txt: Added. +* fast/text/international/float-as-only-child-of-isolate-crash.html: Added. + +2012-07-30 Lucas Forschler lforsch...@apple.com + Merge 118316 2012-05-23 Julien Chaffraix jchaffr...@webkit.org Copied: branches/safari-536.26-branch/LayoutTests/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt (from rev 118420, trunk/LayoutTests/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt) (0 => 124103) --- branches/safari-536.26-branch/LayoutTests/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt (rev 0) +++ branches/safari-536.26-branch/LayoutTests/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt 2012-07-30 22:29:39 UTC (rev 124103) @@ -0,0 +1 @@ +This tests that we avoid trying to lay out floats inside an inline with unicode-bidi: isolate. Test passes if we don't crash. Copied: branches/safari-536.26-branch/LayoutTests/fast/text/international/float-as-only-child-of-isolate-crash.html (from rev 118420, trunk/LayoutTests/fast/text/international/float-as-only-child-of-isolate-crash.html) (0 => 124103) --- branches/safari-536.26-branch/LayoutTests/fast/text/international/float-as-only-child-of-isolate-crash.html (rev 0) +++ branches/safari-536.26-branch/LayoutTests/fast/text/international/float-as-only-child-of-isolate-crash.html 2012-07-30 22:29:39 UTC (rev 124103) @@ -0,0 +1,10 @@ +!DOCTYPE html +html +body +This tests that we avoid trying to lay out floats inside an inline with unicode-bidi: isolate. Test passes if we don't crash. +bdidiv style='float: left; '/div/bdi +script +if (window.layoutTestController) +layoutTestController.dumpAsText(); +/script +/body \ No newline at end of file Modified: branches/safari-536.26-branch/Source/WebCore/ChangeLog (124102 => 124103) --- branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 22:27:38 UTC (rev 124102) +++ branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 22:29:39 UTC (rev 124103) @@ -1,5 +1,35 @@ 2012-07-30 Lucas Forschler lforsch...@apple.com +Merge 118420 + +2012-05-24 Levi Weintraub le...@chromium.org + +Avoid creating InlineBoxes for floating and positioned objects in isolates. +https://bugs.webkit.org/show_bug.cgi?id=87277 + +Reviewed by Eric Seidel. + +We currently will create a placeholder run for the first object we encounter inside an isolate. Then +in RenderBlockLineLayout's constructBidiRuns, we replace that run with the contents of the Isolate. +We run into problems when there are no valid contents in the Isolate. We can't simply remove the +placeholder if there's nothing to replace it with since it may be the logically last run, which we +track but can't rebuild by the time we're handling isolates (we've already shuffled the BidiRuns around). + +With this change, we avoid creating a placeholder altogether until we hit contents in the isolate +that would warrant a BidiRun in the first place. + +Test: fast/text/international/float-as-only-child-of-isolate-crash.html + +* rendering/InlineIterator.h: +(WebCore::IsolateTracker::addFakeRunIfNecessary): +* rendering/RenderBlock.h: +(RenderBlock): +(WebCore::RenderBlock::shouldSkipCreatingRunsForObject): +*
[webkit-changes] [124104] branches/safari-536.26-branch
Title: [124104] branches/safari-536.26-branch
Revision 124104
Author lforsch...@apple.com
Date 2012-07-30 15:33:50 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r118471. rdar://problem/11942141
Modified Paths
branches/safari-536.26-branch/LayoutTests/ChangeLog
branches/safari-536.26-branch/Source/WebCore/ChangeLog
branches/safari-536.26-branch/Source/WebCore/dom/CharacterData.cpp
Added Paths
branches/safari-536.26-branch/LayoutTests/fast/events/dom-character-data-modified-textarea-crash-expected.txt
branches/safari-536.26-branch/LayoutTests/fast/events/dom-character-data-modified-textarea-crash.html
Diff
Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (124103 => 124104)
--- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 22:29:39 UTC (rev 124103)
+++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 22:33:50 UTC (rev 124104)
@@ -1,5 +1,19 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 118471
+
+2012-05-24 Hayato Ito hay...@chromium.org
+
+Fix crashes caused by a DOMCharacterDataModified event on a text node.
+https://bugs.webkit.org/show_bug.cgi?id=86953
+
+Reviewed by Dimitri Glazkov.
+
+* fast/events/dom-character-data-modified-textarea-crash-expected.txt: Added.
+* fast/events/dom-character-data-modified-textarea-crash.html: Added.
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 118420
2012-05-24 Levi Weintraub le...@chromium.org
Copied: branches/safari-536.26-branch/LayoutTests/fast/events/dom-character-data-modified-textarea-crash-expected.txt (from rev 118471, trunk/LayoutTests/fast/events/dom-character-data-modified-textarea-crash-expected.txt) (0 => 124104)
--- branches/safari-536.26-branch/LayoutTests/fast/events/dom-character-data-modified-textarea-crash-expected.txt (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/fast/events/dom-character-data-modified-textarea-crash-expected.txt 2012-07-30 22:33:50 UTC (rev 124104)
@@ -0,0 +1 @@
+Test passes if a DOMCharacterModified event on the textarea does not crash.
Copied: branches/safari-536.26-branch/LayoutTests/fast/events/dom-character-data-modified-textarea-crash.html (from rev 118471, trunk/LayoutTests/fast/events/dom-character-data-modified-textarea-crash.html) (0 => 124104)
--- branches/safari-536.26-branch/LayoutTests/fast/events/dom-character-data-modified-textarea-crash.html (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/fast/events/dom-character-data-modified-textarea-crash.html 2012-07-30 22:33:50 UTC (rev 124104)
@@ -0,0 +1,21 @@
+!DOCTYPE html
+html
+head
+script
+// This test uses a weired textarea to reproduce the issue. The condition of a crash is very sensitive to HTML.
+// If we add a new-line at EOF or add other tags in body part, the crash will be unlikely to happen.
+// For example, if we move this comment to the actual HTML or try to load 'js-test-pre.js', the crash won't happen.
+// Mutation events should not be dispatched on this case. This bug is being tracked by webkit bug https://bugs.webkit.org/show_bug.cgi?id=87372
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+document.addEventListener(DOMCharacterDataModified, function() {
+document.designMode = on;
+document.execCommand(SelectAll);
+document.execCommand(Delete);
+document.body.offsetLeft;
+document.body.innerHTML = 'Test passes if a DOMCharacterModified event on the textarea does not crash.';
+});
+/script
+/head
+textarea
\ No newline at end of file
Modified: branches/safari-536.26-branch/Source/WebCore/ChangeLog (124103 => 124104)
--- branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 22:29:39 UTC (rev 124103)
+++ branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 22:33:50 UTC (rev 124104)
@@ -1,5 +1,27 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 118471
+
+2012-05-24 Hayato Ito hay...@chromium.org
+
+Fix crashes caused by a DOMCharacterDataModified event on a text node.
+https://bugs.webkit.org/show_bug.cgi?id=86953
+
+Reviewed by Dimitri Glazkov.
+
+TextNode can be released while CharacterData::setData() will dispatch a mutation event.
+So protect it.
+
+Mutation event itself should not be dispatched on the test case.
+This is being tracked by webkit bug https://bugs.webkit.org/show_bug.cgi?id=87372.
+
+Test: fast/events/dom-character-data-modified-textarea-crash.html
+
+* dom/CharacterData.cpp:
+(WebCore::CharacterData::setData):
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 118420
2012-05-24 Levi Weintraub le...@chromium.org
Modified: branches/safari-536.26-branch/Source/WebCore/dom/CharacterData.cpp (124103 => 124104)
---
[webkit-changes] [124105] trunk/Source
Title: [124105] trunk/Source Revision 124105 Author jam...@google.com Date 2012-07-30 15:37:54 -0700 (Mon, 30 Jul 2012) Log Message [chromium] Remove WebTransformationMatrix::mapPoint overrides https://bugs.webkit.org/show_bug.cgi?id=90329 Reviewed by Adrienne Walker. Source/Platform: Remove clipping-unaware mapPoint functions from the WebTransformationMatrix interface. * chromium/public/WebTransformationMatrix.h: (WebTransformationMatrix): Source/WebCore: Add more functionality for mapping points to CCMathUtil and use it in CCLayerSorter / drawTileQuad. These mappings should never clip. * platform/chromium/support/WebTransformationMatrix.cpp: * platform/graphics/chromium/LayerRendererChromium.cpp: (WebCore::LayerRendererChromium::drawTileQuad): * platform/graphics/chromium/cc/CCLayerSorter.cpp: (WebCore::CCLayerSorter::LayerShape::LayerShape): * platform/graphics/chromium/cc/CCMathUtil.cpp: (WebCore::mapHomogeneousPoint): (WebCore::CCMathUtil::mapPoint): (WebCore): * platform/graphics/chromium/cc/CCMathUtil.h: (WebCore::HomogeneousCoordinate::cartesianPoint3d): (HomogeneousCoordinate): (CCMathUtil): Modified Paths trunk/Source/Platform/ChangeLog trunk/Source/Platform/chromium/public/WebTransformationMatrix.h trunk/Source/WebCore/ChangeLog trunk/Source/WebCore/platform/chromium/support/WebTransformationMatrix.cpp trunk/Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCLayerSorter.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCMathUtil.cpp trunk/Source/WebCore/platform/graphics/chromium/cc/CCMathUtil.h Diff Modified: trunk/Source/Platform/ChangeLog (124104 => 124105) --- trunk/Source/Platform/ChangeLog 2012-07-30 22:33:50 UTC (rev 124104) +++ trunk/Source/Platform/ChangeLog 2012-07-30 22:37:54 UTC (rev 124105) @@ -1,3 +1,15 @@ +2012-06-29 James Robinson jam...@chromium.org + +[chromium] Remove WebTransformationMatrix::mapPoint overrides +https://bugs.webkit.org/show_bug.cgi?id=90329 + +Reviewed by Adrienne Walker. + +Remove clipping-unaware mapPoint functions from the WebTransformationMatrix interface. + +* chromium/public/WebTransformationMatrix.h: +(WebTransformationMatrix): + 2012-07-30 John Bates jba...@google.com Plumb vsync-enabled flag up to compositor thread and support disable-vsync Modified: trunk/Source/Platform/chromium/public/WebTransformationMatrix.h (124104 => 124105) --- trunk/Source/Platform/chromium/public/WebTransformationMatrix.h 2012-07-30 22:33:50 UTC (rev 124104) +++ trunk/Source/Platform/chromium/public/WebTransformationMatrix.h 2012-07-30 22:37:54 UTC (rev 124105) @@ -137,13 +137,6 @@ // Conversions between WebKit::WebTransformationMatrix and WebCore::TransformationMatrix explicit WebTransformationMatrix(const WebCore::TransformationMatrix); WebCore::TransformationMatrix toWebCoreTransform() const; - -// FIXME: these map functions should not exist, should be using CCMathUtil -// instead. Eventually CCMathUtil functions could be merged here, but its -// not yet the right time for that. -WebCore::FloatPoint3D mapPoint(const WebCore::FloatPoint3D) const; -WebCore::FloatPoint mapPoint(const WebCore::FloatPoint) const; -WebCore::IntPoint mapPoint(const WebCore::IntPoint) const; #endif protected: Modified: trunk/Source/WebCore/ChangeLog (124104 => 124105) --- trunk/Source/WebCore/ChangeLog 2012-07-30 22:33:50 UTC (rev 124104) +++ trunk/Source/WebCore/ChangeLog 2012-07-30 22:37:54 UTC (rev 124105) @@ -1,3 +1,27 @@ +2012-06-29 James Robinson jam...@chromium.org + +[chromium] Remove WebTransformationMatrix::mapPoint overrides +https://bugs.webkit.org/show_bug.cgi?id=90329 + +Reviewed by Adrienne Walker. + +Add more functionality for mapping points to CCMathUtil and use it in CCLayerSorter / drawTileQuad. These +mappings should never clip. + +* platform/chromium/support/WebTransformationMatrix.cpp: +* platform/graphics/chromium/LayerRendererChromium.cpp: +(WebCore::LayerRendererChromium::drawTileQuad): +* platform/graphics/chromium/cc/CCLayerSorter.cpp: +(WebCore::CCLayerSorter::LayerShape::LayerShape): +* platform/graphics/chromium/cc/CCMathUtil.cpp: +(WebCore::mapHomogeneousPoint): +(WebCore::CCMathUtil::mapPoint): +(WebCore): +* platform/graphics/chromium/cc/CCMathUtil.h: +(WebCore::HomogeneousCoordinate::cartesianPoint3d): +(HomogeneousCoordinate): +(CCMathUtil): + 2012-07-30 Anders Carlsson ander...@apple.com Crash in logging code if MIME type is null Modified: trunk/Source/WebCore/platform/chromium/support/WebTransformationMatrix.cpp (124104 => 124105) --- trunk/Source/WebCore/platform/chromium/support/WebTransformationMatrix.cpp 2012-07-30 22:33:50 UTC (rev 124104) +++
[webkit-changes] [124106] branches/safari-536.26-branch
Title: [124106] branches/safari-536.26-branch
Revision 124106
Author lforsch...@apple.com
Date 2012-07-30 15:42:55 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r118478. rdar://problem/11942156
Modified Paths
branches/safari-536.26-branch/LayoutTests/ChangeLog
branches/safari-536.26-branch/LayoutTests/accessibility/table-detection.html
branches/safari-536.26-branch/LayoutTests/platform/mac/accessibility/table-detection-expected.txt
branches/safari-536.26-branch/Source/WebCore/ChangeLog
branches/safari-536.26-branch/Source/WebCore/accessibility/AccessibilityRenderObject.cpp
branches/safari-536.26-branch/Source/WebCore/accessibility/AccessibilityTable.cpp
Added Paths
branches/safari-536.26-branch/LayoutTests/accessibility/contenteditable-table-check-causes-crash-expected.txt
branches/safari-536.26-branch/LayoutTests/accessibility/contenteditable-table-check-causes-crash.html
Diff
Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (124105 => 124106)
--- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 22:37:54 UTC (rev 124105)
+++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 22:42:55 UTC (rev 124106)
@@ -1,5 +1,19 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 118478 (required 118143)
+
+2012-05-24 Dominic Mazzoni dmazz...@google.com
+
+Crash in WebCore::AccessibilityTable::isDataTable
+https://bugs.webkit.org/show_bug.cgi?id=87409
+
+Reviewed by Abhishek Arya.
+
+* accessibility/contenteditable-table-check-causes-crash-expected.txt: Added.
+* accessibility/contenteditable-table-check-causes-crash.html: Added.
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 118471
2012-05-24 Hayato Ito hay...@chromium.org
Added: branches/safari-536.26-branch/LayoutTests/accessibility/contenteditable-table-check-causes-crash-expected.txt (0 => 124106)
--- branches/safari-536.26-branch/LayoutTests/accessibility/contenteditable-table-check-causes-crash-expected.txt (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/accessibility/contenteditable-table-check-causes-crash-expected.txt 2012-07-30 22:42:55 UTC (rev 124106)
@@ -0,0 +1,9 @@
+Ensures that this snippet does not lead to a crash in the code that detects if a table is contenteditable. Bug 87409.
+
+On success, you will see a series of PASS messages, followed by TEST COMPLETE.
+
+
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
Added: branches/safari-536.26-branch/LayoutTests/accessibility/contenteditable-table-check-causes-crash.html (0 => 124106)
--- branches/safari-536.26-branch/LayoutTests/accessibility/contenteditable-table-check-causes-crash.html (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/accessibility/contenteditable-table-check-causes-crash.html 2012-07-30 22:42:55 UTC (rev 124106)
@@ -0,0 +1,29 @@
+!DOCTYPE HTML PUBLIC -//IETF//DTD HTML//EN
+html
+head
+script src=""
+/head
+body
+
+script
+ description(Ensures that this snippet does not lead to a crash in the code that detects if a table is contenteditable. Bug 87409.);
+/script
+
+style
+.tableStyle { display: inline-table; content: counter(section);/style
+script
+function crash() {
+ var node = document.createElement('keygen');
+ node.setAttribute('autofocus', 'autofocus');
+ node.setAttribute('class', 'tableStyle');
+ document.documentElement.appendChild(node);
+}
+window._onload_ = crash;
+/script
+
+p id=description/p
+div id=console/div
+
+script src=""
+/body
+/html
Modified: branches/safari-536.26-branch/LayoutTests/accessibility/table-detection.html (124105 => 124106)
--- branches/safari-536.26-branch/LayoutTests/accessibility/table-detection.html 2012-07-30 22:37:54 UTC (rev 124105)
+++ branches/safari-536.26-branch/LayoutTests/accessibility/table-detection.html 2012-07-30 22:42:55 UTC (rev 124106)
@@ -98,6 +98,13 @@
/style
table class=nmTB cellpadding=0 cellspacing=0trtd class=nmIBD id=nmb name=nmb nm_sn=3032552 nm_suf= CM_sf=Ex CM=NewsMenuL1 pn=newsmenu ct=nm0 cn=Politicsa class=nmLBD href="" class=nmIB id=nmb name=nmb nm_sn=18970411 nm_suf= CM_sf=Ex CM=NewsMenuL1 pn=newsmenu ct=nxf cn=Decision '08a class=nmLB href="" '08/a/td/trtrtd class=nmIB id=nmb name=nmb nm_sn=18296896 nm_suf= CM_sf=Ex CM=NewsMenuL1 pn=newsmenu ct=nxf cn=The debatesa class=nmLB href="" debates/a/td/trtrtd class=nmIB id=nmb name=nmb nm_sn=21491043 nm_suf= CM_sf=Ex CM=NewsMenuL1 pn=newsmenu ct=nxf cn=The White Housea class=nmLB href="" White House/a/td/trtrtd class=nmIB id=nmb name=nmb nm_sn=21491571 nm_suf= CM_sf=Ex CM=NewsMenuL1 pn=newsmenu ct=nxf cn=Capitol Hilla class=nmLB href="" Hill/a/td/trtrtd class=nmIB id=nmb name=nmb nm_sn=14016004 nm_suf= CM_sf=Ex CM=NewsMenuL1 pn=newsmenu ct=nxf cn=National Journala class=nmLB href="" Journal/a/td/trtrtd class=nmIB id=nmb name=nmb nm_sn=19748467 nm_suf= CM_sf=Ex CM=NewsMenuL1 pn=newsmenu ct=nxf cn=New York Timesa class=nmLB
[webkit-changes] [124107] branches/safari-536.26-branch/Source/WebCore
Title: [124107] branches/safari-536.26-branch/Source/WebCore
Revision 124107
Author lforsch...@apple.com
Date 2012-07-30 15:45:21 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r118542. rdar://problem/11942034
Modified Paths
branches/safari-536.26-branch/Source/WebCore/ChangeLog
branches/safari-536.26-branch/Source/WebCore/rendering/RenderObject.cpp
Diff
Modified: branches/safari-536.26-branch/Source/WebCore/ChangeLog (124106 => 124107)
--- branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 22:42:55 UTC (rev 124106)
+++ branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 22:45:21 UTC (rev 124107)
@@ -1,5 +1,43 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 118542
+
+2012-05-25 Ken Buchanan ke...@chromium.org
+
+Layout root not getting cleared for anonymous renderers geting destroyed
+https://bugs.webkit.org/show_bug.cgi?id=84002
+
+Reviewed by Abhishek Arya.
+
+This is a follow-up to r109406, which added a check to clear layout
+roots when they point to a renderer that is being destroyed. The
+thinking was that layout roots would never be anonymous renderers,
+but there are some cases where this is not true (in particular,
+generated content containers with overflow clips can be layout roots).
+
+As in r109406, this patch has no layout test. This is because any test
+that exercises this behavior is caused by an existing layout bug where
+a child is not properly getting layout (or a renderer is getting dirtied
+out of order during layout) and will fail multiple ASSERTs:
+in particular, ASSERT(!m_layoutRoot-container() || !m_layoutRoot-
+container()-needsLayout()) in FrameView::scheduleRelayoutOfSubtree(),
+and ASSERT_NOT_REACHED() in RenderObject::clearLayoutRootIfNeeded().
+We are preventing those bugs from manifesting as security issues with
+this patch.
+
+This also removes an ASSERT from the RenderObject destructor. This is
+redundant with the condition in RenderObject::clearLayoutRootIfNeeded()
+which is always called in RenderObject::willBeDestroyed(), so the check
+is not needed. It had to be removed because it fails when I try to
+adjust the ASSERT condition by removing the !node()
+check, due to RenderWidget clearing its node() during destruction.
+
+* rendering/RenderObject.cpp:
+(WebCore::RenderObject::~RenderObject):
+(WebCore::RenderObject::willBeDestroyed):
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 118478 (required 118143)
2012-05-24 Dominic Mazzoni dmazz...@google.com
Modified: branches/safari-536.26-branch/Source/WebCore/rendering/RenderObject.cpp (124106 => 124107)
--- branches/safari-536.26-branch/Source/WebCore/rendering/RenderObject.cpp 2012-07-30 22:42:55 UTC (rev 124106)
+++ branches/safari-536.26-branch/Source/WebCore/rendering/RenderObject.cpp 2012-07-30 22:45:21 UTC (rev 124107)
@@ -223,7 +223,6 @@
RenderObject::~RenderObject()
{
-ASSERT(!node() || documentBeingDestroyed() || !frame()-view() || frame()-view()-layoutRoot() != this);
#ifndef NDEBUG
ASSERT(!m_hasAXObject);
renderObjectCounter.decrement();
@@ -2260,7 +2259,7 @@
inline void RenderObject::clearLayoutRootIfNeeded() const
{
-if (node() !documentBeingDestroyed() frame()) {
+if (!documentBeingDestroyed() frame()) {
if (FrameView* view = frame()-view()) {
if (view-layoutRoot() == this) {
ASSERT_NOT_REACHED();
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124108] branches/safari-536.26-branch
Title: [124108] branches/safari-536.26-branch
Revision 124108
Author lforsch...@apple.com
Date 2012-07-30 16:06:57 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r119184. rdar://problem/11942161
Modified Paths
branches/safari-536.26-branch/LayoutTests/ChangeLog
branches/safari-536.26-branch/Source/WebCore/ChangeLog
branches/safari-536.26-branch/Source/WebCore/html/parser/XSSAuditor.cpp
Added Paths
branches/safari-536.26-branch/LayoutTests/http/tests/security/xssAuditor/script-tag-with-trailing-comment4-expected.txt
branches/safari-536.26-branch/LayoutTests/http/tests/security/xssAuditor/script-tag-with-trailing-comment4.html
Diff
Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (124107 => 124108)
--- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 22:45:21 UTC (rev 124107)
+++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 23:06:57 UTC (rev 124108)
@@ -1,5 +1,21 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 119184
+
+2012-05-31 Tom Sepez tse...@chromium.org
+
+XSSAuditor bypass with leading /*///*/ comment
+https://bugs.webkit.org/show_bug.cgi?id=88002
+
+Reviewed by Adam Barth.
+
+Fixes issue in xssauditor's parsing of /*/.
+
+* http/tests/security/xssAuditor/script-tag-with-trailing-comment4-expected.txt: Added.
+* http/tests/security/xssAuditor/script-tag-with-trailing-comment4.html: Added.
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 118478 (required 118143)
2012-05-24 Dominic Mazzoni dmazz...@google.com
Copied: branches/safari-536.26-branch/LayoutTests/http/tests/security/xssAuditor/script-tag-with-trailing-comment4-expected.txt (from rev 119184, trunk/LayoutTests/http/tests/security/xssAuditor/script-tag-with-trailing-comment4-expected.txt) (0 => 124108)
--- branches/safari-536.26-branch/LayoutTests/http/tests/security/xssAuditor/script-tag-with-trailing-comment4-expected.txt (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/http/tests/security/xssAuditor/script-tag-with-trailing-comment4-expected.txt 2012-07-30 23:06:57 UTC (rev 124108)
@@ -0,0 +1,3 @@
+CONSOLE MESSAGE: Refused to execute a _javascript_ script. Source code of script found within request.
+
+
Copied: branches/safari-536.26-branch/LayoutTests/http/tests/security/xssAuditor/script-tag-with-trailing-comment4.html (from rev 119184, trunk/LayoutTests/http/tests/security/xssAuditor/script-tag-with-trailing-comment4.html) (0 => 124108)
--- branches/safari-536.26-branch/LayoutTests/http/tests/security/xssAuditor/script-tag-with-trailing-comment4.html (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/http/tests/security/xssAuditor/script-tag-with-trailing-comment4.html 2012-07-30 23:06:57 UTC (rev 124108)
@@ -0,0 +1,15 @@
+!DOCTYPE html
+html
+head
+script
+if (window.layoutTestController) {
+ layoutTestController.dumpAsText();
+ layoutTestController.setXSSAuditorEnabled(true);
+}
+/script
+/head
+body
+iframe src=""
+/iframe
+/body
+/html
Modified: branches/safari-536.26-branch/Source/WebCore/ChangeLog (124107 => 124108)
--- branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 22:45:21 UTC (rev 124107)
+++ branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 23:06:57 UTC (rev 124108)
@@ -1,5 +1,23 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 119184
+
+2012-05-31 Tom Sepez tse...@chromium.org
+
+XSSAuditor bypass with leading /*///*/ comment
+https://bugs.webkit.org/show_bug.cgi?id=88002
+
+Reviewed by Adam Barth.
+
+Fixes issue in xssauditor's parsing of /*/.
+
+Test: http/tests/security/xssAuditor/script-tag-with-trailing-comment4.html
+
+* html/parser/XSSAuditor.cpp:
+(WebCore::XSSAuditor::decodedSnippetForJavaScript):
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 118542
2012-05-25 Ken Buchanan ke...@chromium.org
Modified: branches/safari-536.26-branch/Source/WebCore/html/parser/XSSAuditor.cpp (124107 => 124108)
--- branches/safari-536.26-branch/Source/WebCore/html/parser/XSSAuditor.cpp 2012-07-30 22:45:21 UTC (rev 124107)
+++ branches/safari-536.26-branch/Source/WebCore/html/parser/XSSAuditor.cpp 2012-07-30 23:06:57 UTC (rev 124108)
@@ -557,7 +557,7 @@
while (startPosition endPosition !isJSNewline(string[startPosition]))
startPosition++;
} else if (startsMultiLineCommentAt(string, startPosition)) {
-if ((foundPosition = string.find(*/, startPosition)) != notFound)
+if (startPosition + 2 endPosition (foundPosition = string.find(*/, startPosition + 2)) != notFound)
startPosition = foundPosition + 2;
else
startPosition = endPosition;
___
webkit-changes
[webkit-changes] [124109] branches/safari-536.26-branch
Title: [124109] branches/safari-536.26-branch
Revision 124109
Author lforsch...@apple.com
Date 2012-07-30 16:09:49 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r119227. rdar://problem/11942165
Modified Paths
branches/safari-536.26-branch/LayoutTests/ChangeLog
branches/safari-536.26-branch/Source/WebCore/ChangeLog
branches/safari-536.26-branch/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp
branches/safari-536.26-branch/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.h
Added Paths
branches/safari-536.26-branch/LayoutTests/fast/flexbox/line-clamp-removed-dynamically-expected.html
branches/safari-536.26-branch/LayoutTests/fast/flexbox/line-clamp-removed-dynamically.html
Diff
Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (124108 => 124109)
--- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 23:06:57 UTC (rev 124108)
+++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 23:09:49 UTC (rev 124109)
@@ -1,5 +1,19 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 119227
+
+2012-06-01 Dan Bernstein m...@apple.com
+
+Layout not updated after setting -webkit-line-clamp to none
+https://bugs.webkit.org/show_bug.cgi?id=88049
+
+Reviewed by Abhishek Arya.
+
+* fast/flexbox/line-clamp-removed-dynamically-expected.html: Added.
+* fast/flexbox/line-clamp-removed-dynamically.html: Added.
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 119184
2012-05-31 Tom Sepez tse...@chromium.org
Copied: branches/safari-536.26-branch/LayoutTests/fast/flexbox/line-clamp-removed-dynamically-expected.html (from rev 119227, trunk/LayoutTests/fast/flexbox/line-clamp-removed-dynamically-expected.html) (0 => 124109)
--- branches/safari-536.26-branch/LayoutTests/fast/flexbox/line-clamp-removed-dynamically-expected.html (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/fast/flexbox/line-clamp-removed-dynamically-expected.html 2012-07-30 23:09:49 UTC (rev 124109)
@@ -0,0 +1,10 @@
+div id=target style=
+display: -webkit-box;
+-webkit-box-orient: vertical;
+overflow: hidden;
+width: 100px;
+
+div
+Unless this sentence is truncated after two lines, PASS.
+/div
+/div
Copied: branches/safari-536.26-branch/LayoutTests/fast/flexbox/line-clamp-removed-dynamically.html (from rev 119227, trunk/LayoutTests/fast/flexbox/line-clamp-removed-dynamically.html) (0 => 124109)
--- branches/safari-536.26-branch/LayoutTests/fast/flexbox/line-clamp-removed-dynamically.html (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/fast/flexbox/line-clamp-removed-dynamically.html 2012-07-30 23:09:49 UTC (rev 124109)
@@ -0,0 +1,15 @@
+div id=target style=
+display: -webkit-box;
+-webkit-box-orient: vertical;
+overflow: hidden;
+-webkit-line-clamp: 2;
+width: 100px;
+
+div
+Unless this sentence is truncated after two lines, PASS.
+/div
+/div
+script
+document.body.offsetTop;
+target.style.removeProperty(-webkit-line-clamp);
+/script
Modified: branches/safari-536.26-branch/Source/WebCore/ChangeLog (124108 => 124109)
--- branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 23:06:57 UTC (rev 124108)
+++ branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 23:09:49 UTC (rev 124109)
@@ -1,5 +1,25 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 119227
+
+2012-06-01 Dan Bernstein m...@apple.com
+
+Layout not updated after setting -webkit-line-clamp to none
+https://bugs.webkit.org/show_bug.cgi?id=88049
+
+Reviewed by Abhishek Arya.
+
+Test: fast/flexbox/line-clamp-removed-dynamically.html
+
+* rendering/RenderDeprecatedFlexibleBox.cpp:
+(WebCore::RenderDeprecatedFlexibleBox::styleWillChange): Added. Calls clearLineClamp if
+line-clamp will change to none.
+(WebCore::RenderDeprecatedFlexibleBox::clearLineClamp): Added. Marks possibly-clamped
+children for layout and clears truncation from blocks.
+* rendering/RenderDeprecatedFlexibleBox.h:
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 119184
2012-05-31 Tom Sepez tse...@chromium.org
Modified: branches/safari-536.26-branch/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp (124108 => 124109)
--- branches/safari-536.26-branch/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp 2012-07-30 23:06:57 UTC (rev 124108)
+++ branches/safari-536.26-branch/Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp 2012-07-30 23:09:49 UTC (rev 124109)
@@ -150,6 +150,15 @@
return child-isPositioned() || child-style()-visibility() == COLLAPSE;
}
+void RenderDeprecatedFlexibleBox::styleWillChange(StyleDifference diff, const RenderStyle* newStyle)
+{
+RenderStyle* oldStyle = style();
+if (oldStyle
[webkit-changes] [124110] branches/safari-536.26-branch
Title: [124110] branches/safari-536.26-branch
Revision 124110
Author lforsch...@apple.com
Date 2012-07-30 16:12:28 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r119409. rdar://problem/11942162
Modified Paths
branches/safari-536.26-branch/LayoutTests/ChangeLog
branches/safari-536.26-branch/Source/WebCore/ChangeLog
branches/safari-536.26-branch/Source/WebCore/rendering/RenderBlock.cpp
Added Paths
branches/safari-536.26-branch/LayoutTests/fast/multicol/span/empty-anonymous-block-split-crash-expected.txt
branches/safari-536.26-branch/LayoutTests/fast/multicol/span/empty-anonymous-block-split-crash.html
branches/safari-536.26-branch/LayoutTests/fast/multicol/span/positioned-objects-not-removed-crash-expected.txt
branches/safari-536.26-branch/LayoutTests/fast/multicol/span/positioned-objects-not-removed-crash.html
Diff
Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (124109 => 124110)
--- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 23:09:49 UTC (rev 124109)
+++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 23:12:28 UTC (rev 124110)
@@ -1,5 +1,21 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 119409
+
+2012-06-04 Abhishek Arya infe...@chromium.org
+
+Crash in multi-column layout.
+https://bugs.webkit.org/show_bug.cgi?id=88022
+
+Reviewed by Ojan Vafai.
+
+* fast/multicol/span/empty-anonymous-block-split-crash-expected.txt: Added.
+* fast/multicol/span/empty-anonymous-block-split-crash.html: Added.
+* fast/multicol/span/positioned-objects-not-removed-crash-expected.txt: Added.
+* fast/multicol/span/positioned-objects-not-removed-crash.html: Added.
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 119227
2012-06-01 Dan Bernstein m...@apple.com
Copied: branches/safari-536.26-branch/LayoutTests/fast/multicol/span/empty-anonymous-block-split-crash-expected.txt (from rev 119409, trunk/LayoutTests/fast/multicol/span/empty-anonymous-block-split-crash-expected.txt) (0 => 124110)
--- branches/safari-536.26-branch/LayoutTests/fast/multicol/span/empty-anonymous-block-split-crash-expected.txt (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/fast/multicol/span/empty-anonymous-block-split-crash-expected.txt 2012-07-30 23:12:28 UTC (rev 124110)
@@ -0,0 +1,2 @@
+WebKit Bug - Crash in multi-column layout.
+PASS. WebKit didn't crash.
Copied: branches/safari-536.26-branch/LayoutTests/fast/multicol/span/empty-anonymous-block-split-crash.html (from rev 119409, trunk/LayoutTests/fast/multicol/span/empty-anonymous-block-split-crash.html) (0 => 124110)
--- branches/safari-536.26-branch/LayoutTests/fast/multicol/span/empty-anonymous-block-split-crash.html (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/fast/multicol/span/empty-anonymous-block-split-crash.html 2012-07-30 23:12:28 UTC (rev 124110)
@@ -0,0 +1,35 @@
+!DOCTYPE html
+html
+head
+style
+#test0 { -webkit-column-width: 1px; }
+#test2::after { display: compact; content: ''; }
+#test3 { content: counter(c); -webkit-column-span: all; }
+/style
+script
+if (window.layoutTestController)
+layoutTestController.dumpAsText();
+
+_onload_ = function() {
+test0 = document.createElement('div');
+test0.setAttribute('id', 'test0');
+document.body.appendChild(test0);
+test1 = document.createElement('div');
+test0.appendChild(test1);
+test2 = document.createElement('div');
+test2.setAttribute('id', 'test2');
+test1.appendChild(test2);
+test3 = document.createElement('div');
+test3.setAttribute('id', 'test3');
+test2.appendChild(test3);
+test2.appendChild(document.createTextNode('A'));
+document.designMode = 'on';
+document.execCommand('selectall');
+document.body.offsetTop;
+document.body.innerHTML = WebKit Bug - Crash in multi-column layout.br /PASS. WebKit didn't crash.;
+}
+/script
+/head
+body
+/body
+/html
Copied: branches/safari-536.26-branch/LayoutTests/fast/multicol/span/positioned-objects-not-removed-crash-expected.txt (from rev 119409, trunk/LayoutTests/fast/multicol/span/positioned-objects-not-removed-crash-expected.txt) (0 => 124110)
--- branches/safari-536.26-branch/LayoutTests/fast/multicol/span/positioned-objects-not-removed-crash-expected.txt (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/fast/multicol/span/positioned-objects-not-removed-crash-expected.txt 2012-07-30 23:12:28 UTC (rev 124110)
@@ -0,0 +1,2 @@
+WebKit Bug - Crash in multi-column layout.
+PASS. WebKit didn't crash.
Copied: branches/safari-536.26-branch/LayoutTests/fast/multicol/span/positioned-objects-not-removed-crash.html (from rev 119409, trunk/LayoutTests/fast/multicol/span/positioned-objects-not-removed-crash.html) (0 => 124110)
--- branches/safari-536.26-branch/LayoutTests/fast/multicol/span/positioned-objects-not-removed-crash.html
[webkit-changes] [124111] trunk
Title: [124111] trunk
Revision 124111
Author commit-qu...@webkit.org
Date 2012-07-30 16:13:25 -0700 (Mon, 30 Jul 2012)
Log Message
Avoid Assertion Failure in HarfBuzzRun::characterIndexForXPosition
https://bugs.webkit.org/show_bug.cgi?id=92376
Patch by Dominik Röttsches dominik.rottsc...@intel.com on 2012-07-30
Reviewed by Tony Chang.
.:
Added manual test to reliably reproduce assertion failure which is solved by this patch.
* ManualTests/harfbuzz-mouse-selection-crash.html: Added.
Source/WebCore:
Previously, the if condition in offsetForPosition gating the call to
characterIndexForXPosition was comparing a different value than what was actually used
as the argument to calling it. In some cases, this can lead to a minuscule difference
when comparing the two floats - enough to trigger the assertion. To resolve this,
the accuracy of the index calculation is improved by changing the types from int
to floats and rephrasing the if condition to be exactly the same as what is checked
for in the assertion.
Manual test ManualTests/harfbuzz-mouse-selection-crash.html added
which reliably reproduces the assertion failure before this change.
* platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::HarfBuzzRun::characterIndexForXPosition): Types changed to float.
(WebCore::HarfBuzzShaper::offsetForPosition): Types changed to float, if condition rephrased.
* platform/graphics/harfbuzz/ng/HarfBuzzShaper.h:
(HarfBuzzRun):
Modified Paths
trunk/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp
trunk/Source/WebCore/platform/graphics/harfbuzz/ng/HarfBuzzShaper.h
Added Paths
trunk/ManualTests/harfbuzz-mouse-selection-crash.html
Diff
Modified: trunk/ChangeLog (124110 => 124111)
--- trunk/ChangeLog 2012-07-30 23:12:28 UTC (rev 124110)
+++ trunk/ChangeLog 2012-07-30 23:13:25 UTC (rev 124111)
@@ -1,3 +1,14 @@
+2012-07-30 Dominik Röttsches dominik.rottsc...@intel.com
+
+Avoid Assertion Failure in HarfBuzzRun::characterIndexForXPosition
+https://bugs.webkit.org/show_bug.cgi?id=92376
+
+Reviewed by Tony Chang.
+
+Added manual test to reliably reproduce assertion failure which is solved by this patch.
+
+* ManualTests/harfbuzz-mouse-selection-crash.html: Added.
+
2012-07-29 Vsevolod Vlasov vse...@chromium.org
Web Inspector: Resource agent's reference to cached resources should be weak.
Added: trunk/ManualTests/harfbuzz-mouse-selection-crash.html (0 => 124111)
--- trunk/ManualTests/harfbuzz-mouse-selection-crash.html (rev 0)
+++ trunk/ManualTests/harfbuzz-mouse-selection-crash.html 2012-07-30 23:13:25 UTC (rev 124111)
@@ -0,0 +1,54 @@
+html
+head
+meta http-equiv=Content-Type content=text/html; charset=utf-8
+style type=text/css
+#telugu {
+font-size: 2cm;
+line-height: 1.5em;
+font-family: Lohit Telugu;
+}
+/style
+script
+var ITERATIONS = 1;
+
+if (window.testRunner)
+testRunner.waitUntilDone();
+
+function mouseSelection() {
+var body = document.body;
+body.focus();
+
+xStart = 0;
+yStart = 0;
+
+if (window.eventSender) {
+eventSender.mouseMoveTo(xStart, yStart);
+eventSender.mouseDown();
+for(i=0;iITERATIONS;i++) {
+randomCoord = randomCoordinate();
+eventSender.mouseMoveTo(randomCoord.x, randomCoord.y);
+}
+}
+if (window.testRunnder)
+testRunner.notifyDone();
+}
+
+function randomCoordinate(axis) {
+return { x: Math.floor(Math.random()*window.innerWidth),
+ y: Math.floor(Math.random()* window.innerHeight) }
+}
+
+/script
+/head
+body _onload_=mouseSelection()p
+ This test fuzzes HarfBuzzShaper::offsetForPosition to trigger an assertion in the downstream function characterIndexForXPosition().
+ See https://bugs.webkit.org/show_bug.cgi?id=92376 - reason of the assertion being hit is a minuscule floating point inaccuracy
+ between an if condition that gates the call to characterIndexForXPosition and the actual argument that's then given to the function.
+ This test works on WebKit EFL, with the Ubuntu Telugu Lohit font installed to the EFL jhbuild font directory, like:/p
+ pre$ cp /usr/share/fonts/truetype/ttf-telugu-fonts/lohit_te.ttf WebKitBuild/Dependencies/Source/webkitgtk-test-fonts-0.0.3/pre
+ pRun with:/p
+ pre$ WebKitBuild/Debug/bin/DumpRenderTree ManualTests/harfbuzz-mouse-selection-crash.html/pre
+ pBefore the change, this would crash 10/10 times. Test passes if it does not crash./p
+p id=teluguచేనేత కార్మికుల సమస్యలను ప్రభుత్వం దృష్టికి తీసుకువెళ్లేందుకు సిరిసిల్లలో వైఎస్ఆర్ సిపి గౌరవాధ్యక్షురాలు విజయమ్మ చేపట్టినదీక్ష విజయవంతమైంది./p
+/body
+/html
Modified: trunk/Source/WebCore/ChangeLog (124110 => 124111)
--- trunk/Source/WebCore/ChangeLog 2012-07-30 23:12:28 UTC (rev 124110)
+++ trunk/Source/WebCore/ChangeLog 2012-07-30 23:13:25 UTC (rev 124111)
@@ -1,3 +1,27 @@
+2012-07-30 Dominik Röttsches
[webkit-changes] [124112] branches/safari-536.26-branch
Title: [124112] branches/safari-536.26-branch
Revision 124112
Author lforsch...@apple.com
Date 2012-07-30 16:16:24 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r120662. rdar://problem/11942166
Modified Paths
branches/safari-536.26-branch/LayoutTests/ChangeLog
branches/safari-536.26-branch/Source/WebCore/ChangeLog
branches/safari-536.26-branch/Source/WebCore/css/StyleResolver.cpp
Added Paths
branches/safari-536.26-branch/LayoutTests/fast/text/title-crash.html
Diff
Modified: branches/safari-536.26-branch/LayoutTests/ChangeLog (124111 => 124112)
--- branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 23:13:25 UTC (rev 124111)
+++ branches/safari-536.26-branch/LayoutTests/ChangeLog 2012-07-30 23:16:24 UTC (rev 124112)
@@ -1,5 +1,18 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 120662
+
+2012-06-18 Mike Lawther mikelawt...@chromium.org
+
+Crash when setting title dynamically
+https://bugs.webkit.org/show_bug.cgi?id=88083
+
+Reviewed by Dan Bernstein.
+
+* fast/text/title-crash.html: Added.
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 119409
2012-06-04 Abhishek Arya infe...@chromium.org
Copied: branches/safari-536.26-branch/LayoutTests/fast/text/title-crash.html (from rev 120662, trunk/LayoutTests/fast/text/title-crash.html) (0 => 124112)
--- branches/safari-536.26-branch/LayoutTests/fast/text/title-crash.html (rev 0)
+++ branches/safari-536.26-branch/LayoutTests/fast/text/title-crash.html 2012-07-30 23:16:24 UTC (rev 124112)
@@ -0,0 +1,6 @@
+style*{font-style:italic;font-size:1ex;}/style
+script
+if (window.layoutTestController)
+window.layoutTestController.dumpAsText();
+document.documentElement.innerHTML = 'titlea/titleThis test passes if it does not crash.'
+/script
\ No newline at end of file
Modified: branches/safari-536.26-branch/Source/WebCore/ChangeLog (124111 => 124112)
--- branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 23:13:25 UTC (rev 124111)
+++ branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 23:16:24 UTC (rev 124112)
@@ -1,5 +1,28 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 120662
+
+2012-06-18 Mike Lawther mikelawt...@chromium.org
+
+Crash when setting title dynamically
+https://bugs.webkit.org/show_bug.cgi?id=88083
+
+Reviewed by Dan Bernstein.
+
+Test: fast/text/title-crash.html
+
+The crashing code takes a rare branch in StyleResolver::styleForElement() where
+m_parentStyle is set to point to m_style. Consequently, while applying properties
+to m_style we end up mutating m_parentStyle.
+
+In this situation, we clone style() and point m_parentStyle at the clone. The
+clone is destroyed at the end of StyleResolver::styleForElement().
+
+* css/StyleResolver.cpp:
+(WebCore::StyleResolver::collectMatchingRulesForList):
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 119409
2012-06-04 Abhishek Arya infe...@chromium.org
Modified: branches/safari-536.26-branch/Source/WebCore/css/StyleResolver.cpp (124111 => 124112)
--- branches/safari-536.26-branch/Source/WebCore/css/StyleResolver.cpp 2012-07-30 23:13:25 UTC (rev 124111)
+++ branches/safari-536.26-branch/Source/WebCore/css/StyleResolver.cpp 2012-07-30 23:16:24 UTC (rev 124112)
@@ -1604,12 +1604,15 @@
m_style = RenderStyle::create();
+RefPtrRenderStyle cloneForParent;
+
if (m_parentStyle)
m_style-inheritFrom(m_parentStyle);
else {
-m_parentStyle = style();
// Make sure our fonts are initialized if we don't inherit them from our parent style.
m_style-font().update(0);
+cloneForParent = RenderStyle::clone(style());
+m_parentStyle = cloneForParent.get();
}
// Even if surrounding content is user-editable, shadow DOM should act as a single unit, and not necessarily be editable
@@ -1636,6 +1639,9 @@
initElement(0); // Clear out for the next resolve.
+if (cloneForParent)
+m_parentStyle = 0;
+
// Now return the style.
return m_style.release();
}
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124113] branches/safari-536.26-branch/Source/WebCore
Title: [124113] branches/safari-536.26-branch/Source/WebCore
Revision 124113
Author lforsch...@apple.com
Date 2012-07-30 16:19:40 -0700 (Mon, 30 Jul 2012)
Log Message
Merged r120954. rdar://problem/11932588
Modified Paths
branches/safari-536.26-branch/Source/WebCore/ChangeLog
branches/safari-536.26-branch/Source/WebCore/platform/RunLoop.cpp
Diff
Modified: branches/safari-536.26-branch/Source/WebCore/ChangeLog (124112 => 124113)
--- branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 23:16:24 UTC (rev 124112)
+++ branches/safari-536.26-branch/Source/WebCore/ChangeLog 2012-07-30 23:19:40 UTC (rev 124113)
@@ -1,5 +1,27 @@
2012-07-30 Lucas Forschler lforsch...@apple.com
+Merge 120954
+
+2012-06-21 Brady Eidson beid...@apple.com
+
+rdar://problem/11718988 and https://bugs.webkit.org/show_bug.cgi?id=89673
+showModalDialog fix creates risk of never returning from RunLoop::performWork, potentially blocking other event sources
+
+In case handling a function on the queue places additional functions on the queue, we should
+limit the number of functions each invocation of performWork() performs so it can return and
+other event sources have a chance to spin.
+
+The showModalDialog fix in question is http://trac.webkit.org/changeset/120879
+
+Reviewed by Darin Adler and Anders Carlson.
+
+* platform/RunLoop.cpp:
+(WebCore::RunLoop::performWork): If there are only N functions in the queue when performWork is called,
+ only handle up to N functions before returning. Any additional functions will be handled the next time
+ the runloop spins.
+
+2012-07-30 Lucas Forschler lforsch...@apple.com
+
Merge 120662
2012-06-18 Mike Lawther mikelawt...@chromium.org
Modified: branches/safari-536.26-branch/Source/WebCore/platform/RunLoop.cpp (124112 => 124113)
--- branches/safari-536.26-branch/Source/WebCore/platform/RunLoop.cpp 2012-07-30 23:16:24 UTC (rev 124112)
+++ branches/safari-536.26-branch/Source/WebCore/platform/RunLoop.cpp 2012-07-30 23:19:40 UTC (rev 124113)
@@ -57,15 +57,42 @@
void RunLoop::performWork()
{
+// It is important to handle the functions in the queue one at a time because while inside one of these
+// functions we might re-enter RunLoop::performWork() and we need to be able to pick up where we left off.
+// See http://webkit.org/b/89590 for more discussion.
+
+// One possible scenario when handling the function queue is as follows:
+// - RunLoop::performWork() is invoked with 1 function on the queue
+// - Handling that function results in 1 more function being enqueued
+// - Handling that one results in yet another being enqueued
+// - And so on
+//
+// In this situation one invocation of performWork() never returns so all other event sources are blocked.
+// By only handling up to the number of functions that were in the queue when performWork() is called
+// we guarantee to occasionally return from the run loop so other event sources will be allowed to spin.
+
Functionvoid() function;
-
-while (true) {
-// It is important to handle the functions in the queue one at a time because while inside one of these
-// functions we might re-enter RunLoop::performWork() and we need to be able to pick up where we left off.
-// See http://webkit.org/b/89590 for more discussion.
+size_t functionsToHandle = 0;
+{
+MutexLocker locker(m_functionQueueLock);
+functionsToHandle = m_functionQueue.size();
+
+if (m_functionQueue.isEmpty())
+return;
+
+function = m_functionQueue.takeFirst();
+}
+
+function();
+
+for (size_t functionsHandled = 1; functionsHandled functionsToHandle; ++functionsHandled) {
{
MutexLocker locker(m_functionQueueLock);
+
+// Even if we start off with N functions to handle and we've only handled less than N functions, the queue
+// still might be empty because those functions might have been handled in an inner RunLoop::performWork().
+// In that case we should bail here.
if (m_functionQueue.isEmpty())
break;
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
[webkit-changes] [124115] trunk/Source/WTF
Title: [124115] trunk/Source/WTF
Revision 124115
Author commit-qu...@webkit.org
Date 2012-07-30 16:53:20 -0700 (Mon, 30 Jul 2012)
Log Message
atomicDecrement() never reach 0 on Android so no deref() will be called
https://bugs.webkit.org/show_bug.cgi?id=92635
Patch by Wei James james@intel.com on 2012-07-30
Reviewed by Adam Barth.
With Android NDK 7b and later, __atomic_dec() is implemented by
__sync_fetch_and_sub(), which will result in that atomicDecrement()
returns the old value instead of new one.
* wtf/Atomics.h:
(WTF):
(WTF::atomicIncrement):
(WTF::atomicDecrement):
Modified Paths
trunk/Source/WTF/ChangeLog
trunk/Source/WTF/wtf/Atomics.h
Diff
Modified: trunk/Source/WTF/ChangeLog (124114 => 124115)
--- trunk/Source/WTF/ChangeLog 2012-07-30 23:34:20 UTC (rev 124114)
+++ trunk/Source/WTF/ChangeLog 2012-07-30 23:53:20 UTC (rev 124115)
@@ -1,3 +1,19 @@
+2012-07-30 Wei James james@intel.com
+
+atomicDecrement() never reach 0 on Android so no deref() will be called
+https://bugs.webkit.org/show_bug.cgi?id=92635
+
+Reviewed by Adam Barth.
+
+With Android NDK 7b and later, __atomic_dec() is implemented by
+__sync_fetch_and_sub(), which will result in that atomicDecrement()
+returns the old value instead of new one.
+
+* wtf/Atomics.h:
+(WTF):
+(WTF::atomicIncrement):
+(WTF::atomicDecrement):
+
2012-07-30 Patrick Gansterer par...@webkit.org
Add function to calculate the day in year from a date
Modified: trunk/Source/WTF/wtf/Atomics.h (124114 => 124115)
--- trunk/Source/WTF/wtf/Atomics.h 2012-07-30 23:34:20 UTC (rev 124114)
+++ trunk/Source/WTF/wtf/Atomics.h 2012-07-30 23:53:20 UTC (rev 124115)
@@ -108,8 +108,9 @@
#elif OS(ANDROID)
#define WTF_USE_LOCKFREE_THREADSAFEREFCOUNTED 1
-inline int atomicIncrement(int volatile* addend) { return __atomic_inc(addend); }
-inline int atomicDecrement(int volatile* addend) { return __atomic_dec(addend); }
+// Note, __atomic_{inc, dec}() return the previous value of addend's content.
+inline int atomicIncrement(int volatile* addend) { return __atomic_inc(addend) + 1; }
+inline int atomicDecrement(int volatile* addend) { return __atomic_dec(addend) - 1; }
#elif COMPILER(GCC) !CPU(SPARC64) // sizeof(_Atomic_word) != sizeof(int) on sparc64 gcc
#define WTF_USE_LOCKFREE_THREADSAFEREFCOUNTED 1
___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes
