[webkit-changes] [154753] trunk

[sergio]

Title: [154753] trunk








Revision 154753
Author ser...@webkit.org
Date 2013-08-28 09:48:53 -0700 (Wed, 28 Aug 2013)


Log Message
[CSS Grid Layout] Handle 'span' positions during layout
https://bugs.webkit.org/show_bug.cgi?id=119756

Reviewed by Andreas Kling.

>From Blink r149133 by 

Source/WebCore:

Properly handle the 'span' keyword during layout. We only had
parsing support so far but with this change we are able to
recognize these positions and act accordingly.

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::resolveGridPositionsFromStyle):
(WebCore::RenderGrid::resolveGridPositionAgainstOppositePosition):
* rendering/RenderGrid.h:
* rendering/style/GridPosition.h:
(WebCore::GridPosition::shouldBeResolvedAgainstOppositePosition):

LayoutTests:

Added some new test cases to verify that we properly resolve
'span' positions.

* fast/css-grid-layout/grid-item-negative-position-resolution-expected.txt:
* fast/css-grid-layout/grid-item-negative-position-resolution.html:
* fast/css-grid-layout/grid-item-spanning-resolution-expected.txt:
* fast/css-grid-layout/grid-item-spanning-resolution.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution.html
trunk/LayoutTests/fast/css-grid-layout/grid-item-spanning-resolution-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-item-spanning-resolution.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderGrid.cpp
trunk/Source/WebCore/rendering/RenderGrid.h
trunk/Source/WebCore/rendering/style/GridPosition.h




Diff

Modified: trunk/LayoutTests/ChangeLog (154752 => 154753)

--- trunk/LayoutTests/ChangeLog	2013-08-28 16:44:27 UTC (rev 154752)
+++ trunk/LayoutTests/ChangeLog	2013-08-28 16:48:53 UTC (rev 154753)
@@ -1,3 +1,20 @@
+2013-08-28  Sergio Villar Senin  
+
+[CSS Grid Layout] Handle 'span' positions during layout
+https://bugs.webkit.org/show_bug.cgi?id=119756
+
+Reviewed by Andreas Kling.
+
+From Blink r149133 by 
+
+Added some new test cases to verify that we properly resolve
+'span' positions.
+
+* fast/css-grid-layout/grid-item-negative-position-resolution-expected.txt:
+* fast/css-grid-layout/grid-item-negative-position-resolution.html:
+* fast/css-grid-layout/grid-item-spanning-resolution-expected.txt:
+* fast/css-grid-layout/grid-item-spanning-resolution.html:
+
 2013-08-28  Ádám Kallai  
 
 [Qt] Delete unnecessary empty directories.


Modified: trunk/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution-expected.txt (154752 => 154753)

--- trunk/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution-expected.txt	2013-08-28 16:44:27 UTC (rev 154752)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution-expected.txt	2013-08-28 16:48:53 UTC (rev 154753)
@@ -4,3 +4,7 @@
 PASS
 PASS
 PASS
+PASS
+PASS
+PASS
+PASS


Modified: trunk/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution.html (154752 => 154753)

--- trunk/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution.html	2013-08-28 16:44:27 UTC (rev 154752)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution.html	2013-08-28 16:48:53 UTC (rev 154753)
@@ -27,6 +27,26 @@
 -webkit-grid-row: -1 / auto;
 }
 
+.endSpanGrowGridInColumnDirection {
+-webkit-grid-column: -2 / span 3;
+-webkit-grid-row: 1;
+}
+
+.endSpanGrowGridInRowDirection {
+-webkit-grid-column: 1;
+-webkit-grid-row: -2 / span 3;
+}
+
+.negativeEndPositionStartSpanInColumnDirection {
+-webkit-grid-column: span / -1;
+-webkit-grid-row: 1;
+}
+
+.negativeEndPositionStartSpanInRowDirection {
+-webkit-grid-column: 1;
+-webkit-grid-row: span 5 / -1;
+}
+
 .negativeEndPositionStartNegativeInColumnDirection {
 -webkit-grid-column: -3 / -1;
 -webkit-grid-row: 1;
@@ -55,7 +75,31 @@
 
 
 
+
+
+
+
+
+
+
+
+
+
+
+
 
+
+
+
+
+
+
+
+
+
+
+
+
 
 
 


Modified: trunk/LayoutTests/fast/css-grid-layout/grid-item-spanning-resolution-expected.txt (154752 => 154753)

--- trunk/LayoutTests/fast/css-grid-layout/grid-item-spanning-resolution-expected.txt	2013-08-28 16:44:27 UTC (rev 154752)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-item-spanning-resolution-expected.txt	2013-08-28 16:48:53 UTC (rev 154753)
@@ -12,3 +12,8 @@
 PASS
 PASS
 PASS
+PASS
+PASS
+PASS
+PASS
+PASS


Modified: trunk/LayoutTests/fast/css-grid-layout/grid-item-spanning-resolution.html (154752 => 154753)

--- trunk/LayoutTests/fast/css-grid-layout/grid-item-spanning-resolution.html	2013-08-28 16:44:27 UTC (rev 154752)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-item-spanning-resolution.html	2013-08-28 16:48:53 UTC (rev 154753)
@@ -49,6 +49

[webkit-changes] [154732] trunk/Source/WebCore

[sergio]

Title: [154732] trunk/Source/WebCore








Revision 154732
Author ser...@webkit.org
Date 2013-08-28 03:30:07 -0700 (Wed, 28 Aug 2013)


Log Message
WorkerGlobalScopeWebDatabase requires ENABLE(WORKERS)
https://bugs.webkit.org/show_bug.cgi?id=120395

Reviewed by Christophe Dumez.

WorkerGlobalScopeDatabase uses the WorkerGlobalScope object which is
defined only when WORKERS are enabled. We should guard that code.

* Modules/webdatabase/WorkerGlobalScopeWebDatabase.cpp:
* Modules/webdatabase/WorkerGlobalScopeWebDatabase.h:
* Modules/webdatabase/WorkerGlobalScopeWebDatabase.idl:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/webdatabase/WorkerGlobalScopeWebDatabase.cpp
trunk/Source/WebCore/Modules/webdatabase/WorkerGlobalScopeWebDatabase.h
trunk/Source/WebCore/Modules/webdatabase/WorkerGlobalScopeWebDatabase.idl




Diff

Modified: trunk/Source/WebCore/ChangeLog (154731 => 154732)

--- trunk/Source/WebCore/ChangeLog	2013-08-28 10:26:10 UTC (rev 154731)
+++ trunk/Source/WebCore/ChangeLog	2013-08-28 10:30:07 UTC (rev 154732)
@@ -1,5 +1,19 @@
 2013-08-28  Sergio Villar Senin  
 
+WorkerGlobalScopeWebDatabase requires ENABLE(WORKERS)
+https://bugs.webkit.org/show_bug.cgi?id=120395
+
+Reviewed by Christophe Dumez.
+
+WorkerGlobalScopeDatabase uses the WorkerGlobalScope object which is
+defined only when WORKERS are enabled. We should guard that code.
+
+* Modules/webdatabase/WorkerGlobalScopeWebDatabase.cpp:
+* Modules/webdatabase/WorkerGlobalScopeWebDatabase.h:
+* Modules/webdatabase/WorkerGlobalScopeWebDatabase.idl:
+
+2013-08-28  Sergio Villar Senin  
+
 [CSS Grid Layout] Fix grid position resolution
 https://bugs.webkit.org/show_bug.cgi?id=119801
 


Modified: trunk/Source/WebCore/Modules/webdatabase/WorkerGlobalScopeWebDatabase.cpp (154731 => 154732)

--- trunk/Source/WebCore/Modules/webdatabase/WorkerGlobalScopeWebDatabase.cpp	2013-08-28 10:26:10 UTC (rev 154731)
+++ trunk/Source/WebCore/Modules/webdatabase/WorkerGlobalScopeWebDatabase.cpp	2013-08-28 10:30:07 UTC (rev 154732)
@@ -27,7 +27,7 @@
 
 #include "config.h"
 
-#if ENABLE(SQL_DATABASE)
+#if ENABLE(SQL_DATABASE) && ENABLE(WORKERS)
 
 #include "WorkerGlobalScopeWebDatabase.h"
 
@@ -73,4 +73,4 @@
 
 } // namespace WebCore
 
-#endif // ENABLE(SQL_DATABASE)
+#endif // ENABLE(SQL_DATABASE) && ENABLE(WORKERS)


Modified: trunk/Source/WebCore/Modules/webdatabase/WorkerGlobalScopeWebDatabase.h (154731 => 154732)

--- trunk/Source/WebCore/Modules/webdatabase/WorkerGlobalScopeWebDatabase.h	2013-08-28 10:26:10 UTC (rev 154731)
+++ trunk/Source/WebCore/Modules/webdatabase/WorkerGlobalScopeWebDatabase.h	2013-08-28 10:30:07 UTC (rev 154732)
@@ -27,7 +27,7 @@
 #ifndef WorkerGlobalScopeWebDatabase_h
 #define WorkerGlobalScopeWebDatabase_h
 
-#if ENABLE(SQL_DATABASE)
+#if ENABLE(SQL_DATABASE) && ENABLE(WORKERS)
 
 #include "ExceptionCode.h"
 #include 
@@ -54,6 +54,6 @@
 
 } // namespace WebCore
 
-#endif // ENABLE(SQL_DATABASE)
+#endif // ENABLE(SQL_DATABASE) && ENABLE(WORKERS)
 
 #endif // WorkerGlobalScopeWebDatabase_h


Modified: trunk/Source/WebCore/Modules/webdatabase/WorkerGlobalScopeWebDatabase.idl (154731 => 154732)

--- trunk/Source/WebCore/Modules/webdatabase/WorkerGlobalScopeWebDatabase.idl	2013-08-28 10:26:10 UTC (rev 154731)
+++ trunk/Source/WebCore/Modules/webdatabase/WorkerGlobalScopeWebDatabase.idl	2013-08-28 10:30:07 UTC (rev 154732)
@@ -25,7 +25,7 @@
  */
 
 [
-Conditional=SQL_DATABASE,
+Conditional=SQL_DATABASE&WORKERS,
 ] partial interface WorkerGlobalScope {
 [RaisesException] Database openDatabase(DOMString name, DOMString version, DOMString displayName, unsigned long estimatedSize, optional DatabaseCallback creationCallback);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [154731] trunk

[sergio]

Title: [154731] trunk








Revision 154731
Author ser...@webkit.org
Date 2013-08-28 03:26:10 -0700 (Wed, 28 Aug 2013)


Log Message
[CSS Grid Layout] Fix grid position resolution
https://bugs.webkit.org/show_bug.cgi?id=119801

Reviewed by Andreas Kling.

>From Blink r148833, r148878, r150403 by 

Source/WebCore:

Both grid-{column|row}-end and negative positions were not
properly handled in our grid position resolution code. We were
using the same code to resolve all the grid positions without
considering the edges of the grid.

Also refactored the grid size estimation in
resolveGridPositionsFromStyle() so we can use it for the grid size
estimation. The code no longer requires the grid to be filled at
that moment as the specs changed to use the "explicit grid" which
is independent of grid items (only depends on style).

Test: fast/css-grid-layout/grid-item-negative-position-resolution.html

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::maximumIndexInDirection):
(WebCore::RenderGrid::resolveGridPositionsFromStyle):
(WebCore::adjustGridPositionForSide):
(WebCore::RenderGrid::resolveGridPositionFromStyle):
* rendering/RenderGrid.h:

LayoutTests:

Added a new test to check negative position resolution. Also added
several new test cases to check that we properly resolve grid
positions in the grid edges.

* fast/css-grid-layout/grid-item-negative-position-resolution-expected.txt: Added.
* fast/css-grid-layout/grid-item-negative-position-resolution.html: Added.
* fast/css-grid-layout/grid-item-spanning-resolution-expected.txt:
* fast/css-grid-layout/grid-item-spanning-resolution.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css-grid-layout/grid-item-spanning-resolution-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-item-spanning-resolution.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderGrid.cpp
trunk/Source/WebCore/rendering/RenderGrid.h


Added Paths

trunk/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution.html




Diff

Modified: trunk/LayoutTests/ChangeLog (154730 => 154731)

--- trunk/LayoutTests/ChangeLog	2013-08-28 09:58:33 UTC (rev 154730)
+++ trunk/LayoutTests/ChangeLog	2013-08-28 10:26:10 UTC (rev 154731)
@@ -1,5 +1,23 @@
 2013-08-28  Sergio Villar Senin  
 
+[CSS Grid Layout] Fix grid position resolution
+https://bugs.webkit.org/show_bug.cgi?id=119801
+
+Reviewed by Andreas Kling.
+
+From Blink r148833, r148878, r150403 by 
+
+Added a new test to check negative position resolution. Also added
+several new test cases to check that we properly resolve grid
+positions in the grid edges.
+
+* fast/css-grid-layout/grid-item-negative-position-resolution-expected.txt: Added.
+* fast/css-grid-layout/grid-item-negative-position-resolution.html: Added.
+* fast/css-grid-layout/grid-item-spanning-resolution-expected.txt:
+* fast/css-grid-layout/grid-item-spanning-resolution.html:
+
+2013-08-28  Sergio Villar Senin  
+
 [CSS Grid Layout] infinity should be defined as a negative value
 https://bugs.webkit.org/show_bug.cgi?id=107053
 


Added: trunk/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution-expected.txt (0 => 154731)

--- trunk/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution-expected.txt	2013-08-28 10:26:10 UTC (rev 154731)
@@ -0,0 +1,6 @@
+Test that negative grid positions are correctly resolved.
+
+PASS
+PASS
+PASS
+PASS
Property changes on: trunk/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution-expected.txt
___


Added: svn:eol-style

Added: trunk/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution.html (0 => 154731)

--- trunk/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution.html	(rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-item-negative-position-resolution.html	2013-08-28 10:26:10 UTC (rev 154731)
@@ -0,0 +1,71 @@
+
+
+
+if (window.testRunner)
+testRunner.overridePreference("WebKitCSSGridLayoutEnabled", 1);
+
+
+
+.grid {
+-webkit-grid-definition-columns: 50px 100px;
+-webkit-grid-definition-rows: 50px 100px;
+/* To detect how much we extend the grid. */
+-webkit-grid-auto-columns: 200px;
+-webkit-grid-auto-rows: 200px;
+
+/* Make the grid shrink-to-fit. */
+position: absolute;
+}
+
+.negativeStartPositionGrowGridInColumnDirection {
+-webkit-grid-column: -1 / auto;
+-webkit-grid-row: 1;
+}
+
+.negativeStartPositionGrowGridInRowDirection {
+-webkit-grid-column: 1;

[webkit-changes] [154730] trunk

[sergio]

Title: [154730] trunk








Revision 154730
Author ser...@webkit.org
Date 2013-08-28 02:58:33 -0700 (Wed, 28 Aug 2013)


Log Message
[CSS Grid Layout] infinity should be defined as a negative value
https://bugs.webkit.org/show_bug.cgi?id=107053

Reviewed by Andreas Kling.

>From Blink r154805 by 

Source/WebCore:

Reject negative values for track-breadth at parse time as
mentioned in the latest versions of the spec.

Added some extra checks to the existing tests.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseGridBreadth):
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeUsedBreadthOfMaxLength):

LayoutTests:

Added some new test cases to check that track-breadth cannot be a
negative value, either it's a length, a percentage...

* fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
* fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
* fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:
* fast/css-grid-layout/resources/grid-columns-rows-get-set.js:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt
trunk/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js
trunk/LayoutTests/fast/css-grid-layout/resources/grid-columns-rows-get-set.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/rendering/RenderGrid.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (154729 => 154730)

--- trunk/LayoutTests/ChangeLog	2013-08-28 09:45:14 UTC (rev 154729)
+++ trunk/LayoutTests/ChangeLog	2013-08-28 09:58:33 UTC (rev 154730)
@@ -1,5 +1,22 @@
 2013-08-28  Sergio Villar Senin  
 
+[CSS Grid Layout] infinity should be defined as a negative value
+https://bugs.webkit.org/show_bug.cgi?id=107053
+
+Reviewed by Andreas Kling.
+
+From Blink r154805 by 
+
+Added some new test cases to check that track-breadth cannot be a
+negative value, either it's a length, a percentage...
+
+* fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
+* fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
+* fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:
+* fast/css-grid-layout/resources/grid-columns-rows-get-set.js:
+
+2013-08-28  Sergio Villar Senin  
+
 [Soup] WebTiming information not shown in the inspector
 https://bugs.webkit.org/show_bug.cgi?id=118395
 


Modified: trunk/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt (154729 => 154730)

--- trunk/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt	2013-08-28 09:45:14 UTC (rev 154729)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-expected.txt	2013-08-28 09:58:33 UTC (rev 154730)
@@ -70,6 +70,10 @@
 PASS getComputedStyle(element, '').getPropertyValue('-webkit-grid-definition-rows') is 'none'
 PASS getComputedStyle(element, '').getPropertyValue('-webkit-grid-definition-columns') is 'none'
 PASS getComputedStyle(element, '').getPropertyValue('-webkit-grid-definition-rows') is 'none'
+PASS getComputedStyle(element, '').getPropertyValue('-webkit-grid-definition-columns') is 'none'
+PASS getComputedStyle(element, '').getPropertyValue('-webkit-grid-definition-rows') is 'none'
+PASS getComputedStyle(element, '').getPropertyValue('-webkit-grid-definition-columns') is 'none'
+PASS getComputedStyle(element, '').getPropertyValue('-webkit-grid-definition-rows') is 'none'
 
 Test setting grid-definition-columns and grid-definition-rows back to 'none' through JS
 PASS getComputedStyle(element, '').getPropertyValue('-webkit-grid-definition-columns') is '18px'


Modified: trunk/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt (154729 => 154730)

--- trunk/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt	2013-08-28 09:45:14 UTC (rev 154729)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt	2013-08-28 09:58:33 UTC (rev 154730)
@@ -64,6 +64,10 @@
 PASS getComputedStyle(element, '').getPropertyValue('-webkit-grid-definition-rows') is 'none'
 PASS getComputedStyle(element, '').getPropertyValue('-webkit-grid-definition-columns') is 'none'
 PASS getComputedStyle(element, '').getPropertyValue('-webkit-grid-definition-rows') is 'none'
+PASS getComputedStyle(element, '').getPropertyValue('-webkit-grid-definition-columns') is 'none'
+PASS getCo

[webkit-changes] [154727] trunk

[sergio]

Title: [154727] trunk








Revision 154727
Author ser...@webkit.org
Date 2013-08-28 02:29:30 -0700 (Wed, 28 Aug 2013)


Log Message
[Soup] WebTiming information not shown in the inspector
https://bugs.webkit.org/show_bug.cgi?id=118395

Reviewed by Martin Robinson.

Source/WebCore:

WebTiming information was not correctly provided to WebCore
because the gotHeadersCallback was incorrectly resetting the
original ResourceResponse (which had the ResourceLoadTiming
object) instead of simply updating their contents using the
SoupMessage.

No new test required as this feature is already covered by the
existing webtiming tests. In any case this change includes a fix
for the http/tests/misc/webtiming-ssl.php test which was not
failing even if it should because it was not correct.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::gotHeadersCallback):
(WebCore::restartedCallback): restartedCallback should be
available only if WEB_TIMING is defined.
(WebCore::createSoupMessageForHandleAndRequest): Ditto.

LayoutTests:

Fixed the webiming-ssl.php test that was incorrectly considering a
FAIL as the expected result. It was probably just a legacy
decision which came from the times where DRT was responsible of
reporting WebTiming information.

Also added a new test that fails due to wkb.ug/103927. It was not
detected before because there were no timing information in the
response.

* http/tests/misc/resources/webtiming-ssl.html:
* http/tests/misc/webtiming-ssl-expected.txt:
* platform/gtk/TestExpectations: added
http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_attribute_order.html.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/http/tests/misc/resources/webtiming-ssl.html
trunk/LayoutTests/http/tests/misc/webtiming-ssl-expected.txt
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (154726 => 154727)

--- trunk/LayoutTests/ChangeLog	2013-08-28 08:32:42 UTC (rev 154726)
+++ trunk/LayoutTests/ChangeLog	2013-08-28 09:29:30 UTC (rev 154727)
@@ -1,3 +1,24 @@
+2013-08-28  Sergio Villar Senin  
+
+[Soup] WebTiming information not shown in the inspector
+https://bugs.webkit.org/show_bug.cgi?id=118395
+
+Reviewed by Martin Robinson.
+
+Fixed the webiming-ssl.php test that was incorrectly considering a
+FAIL as the expected result. It was probably just a legacy
+decision which came from the times where DRT was responsible of
+reporting WebTiming information.
+
+Also added a new test that fails due to wkb.ug/103927. It was not
+detected before because there were no timing information in the
+response.
+
+* http/tests/misc/resources/webtiming-ssl.html:
+* http/tests/misc/webtiming-ssl-expected.txt:
+* platform/gtk/TestExpectations: added
+http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_attribute_order.html.
+
 2013-08-28  Gabor Rapcsanyi  
 
 Unreviewed ARM Qt gardening.


Modified: trunk/LayoutTests/http/tests/misc/resources/webtiming-ssl.html (154726 => 154727)

--- trunk/LayoutTests/http/tests/misc/resources/webtiming-ssl.html	2013-08-28 08:32:42 UTC (rev 154726)
+++ trunk/LayoutTests/http/tests/misc/resources/webtiming-ssl.html	2013-08-28 09:29:30 UTC (rev 154727)
@@ -9,7 +9,7 @@
 
 
 

[webkit-changes] [154044] trunk

[sergio]

Title: [154044] trunk








Revision 154044
Author ser...@webkit.org
Date 2013-08-14 03:40:40 -0700 (Wed, 14 Aug 2013)


Log Message
[CSS Grid Layout] Align our grid-line handling with the updated specification
https://bugs.webkit.org/show_bug.cgi?id=113546

Reviewed by Andreas Kling.

>From Blink r148091 by 

Source/WebCore:

This change makes us match the updated specification by making
grid line numbers to always resolve against the
grid-{column|row}-start edge (the previous code would resolve
grid-{column|row}-end grid lines against the grid-{column|row}-end
edge).

To keep feature parity, negative numbers resolve against the
grid-{column|row}-end edge of the 'explicit grid'.

Test: fast/css-grid-layout/grid-item-negative-integer-explicit-grid-resolution.html

* rendering/RenderGrid.cpp:
(WebCore::estimatedGridSizeForPosition):
(WebCore::RenderGrid::explicitGridColumnCount): New utility function.
(WebCore::RenderGrid::explicitGridRowCount): Ditto.
(WebCore::RenderGrid::maximumIndexInDirection): Use explicitGridXXXCount().
(WebCore::RenderGrid::resolveGridPositionsFromStyle): Check that row-end > row-start.
(WebCore::RenderGrid::resolveGridPositionFromStyle): Clamp negative values to the first line.
* rendering/RenderGrid.h:
* rendering/style/GridPosition.h:

LayoutTests:

Added a couple of new tests to cover the cases of grid resolutions
using negative integers. Negative integers must resolve against
the grid-{column|row}-end of the explicit grid.

* fast/css-grid-layout/grid-auto-flow-resolution-expected.txt:
* fast/css-grid-layout/grid-auto-flow-resolution.html:
* fast/css-grid-layout/grid-item-negative-integer-explicit-grid-resolution-expected.txt: Added.
* fast/css-grid-layout/grid-item-negative-integer-explicit-grid-resolution.html: Added.
* fast/css-grid-layout/grid-item-spanning-resolution-expected.txt:
* fast/css-grid-layout/grid-item-spanning-resolution.html:
* fast/css-grid-layout/resources/grid.css:
(.autoLastRowAutoLastColumn):
(.autoSecondRowAutoFirstColumn):
(.firstRowBothColumn):
(.secondRowBothColumn):
(.bothRowFirstColumn):
(.bothRowSecondColumn):
(.bothRowBothColumn):

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css-grid-layout/grid-auto-flow-resolution-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-auto-flow-resolution.html
trunk/LayoutTests/fast/css-grid-layout/grid-item-spanning-resolution-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-item-spanning-resolution.html
trunk/LayoutTests/fast/css-grid-layout/resources/grid.css
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/rendering/RenderGrid.cpp
trunk/Source/WebCore/rendering/RenderGrid.h
trunk/Source/WebCore/rendering/style/GridPosition.h


Added Paths

trunk/LayoutTests/fast/css-grid-layout/grid-item-negative-integer-explicit-grid-resolution-expected.txt
trunk/LayoutTests/fast/css-grid-layout/grid-item-negative-integer-explicit-grid-resolution.html




Diff

Modified: trunk/LayoutTests/ChangeLog (154043 => 154044)

--- trunk/LayoutTests/ChangeLog	2013-08-14 10:12:38 UTC (rev 154043)
+++ trunk/LayoutTests/ChangeLog	2013-08-14 10:40:40 UTC (rev 154044)
@@ -1,3 +1,31 @@
+2013-08-13  Sergio Villar Senin  
+
+[CSS Grid Layout] Align our grid-line handling with the updated specification
+https://bugs.webkit.org/show_bug.cgi?id=113546
+
+Reviewed by Andreas Kling.
+
+From Blink r148091 by 
+
+Added a couple of new tests to cover the cases of grid resolutions
+using negative integers. Negative integers must resolve against
+the grid-{column|row}-end of the explicit grid.
+
+* fast/css-grid-layout/grid-auto-flow-resolution-expected.txt:
+* fast/css-grid-layout/grid-auto-flow-resolution.html:
+* fast/css-grid-layout/grid-item-negative-integer-explicit-grid-resolution-expected.txt: Added.
+* fast/css-grid-layout/grid-item-negative-integer-explicit-grid-resolution.html: Added.
+* fast/css-grid-layout/grid-item-spanning-resolution-expected.txt:
+* fast/css-grid-layout/grid-item-spanning-resolution.html:
+* fast/css-grid-layout/resources/grid.css:
+(.autoLastRowAutoLastColumn):
+(.autoSecondRowAutoFirstColumn):
+(.firstRowBothColumn):
+(.secondRowBothColumn):
+(.bothRowFirstColumn):
+(.bothRowSecondColumn):
+(.bothRowBothColumn):
+
 2013-08-13  Gyuyoung Kim  
 
 The length of scheme is at least five characters even when the scheme has 'web+' prefix


Modified: trunk/LayoutTests/fast/css-grid-layout/grid-auto-flow-resolution-expected.txt (154043 => 154044)

--- trunk/LayoutTests/fast/css-grid-layout/grid-auto-flow-resolution-expected.txt	2013-08-14 10:12:38 UTC (rev 154043)
+++ trunk/LayoutTests/fast/css-grid-layout/grid-auto-flow-resolution-expected.txt	2013-08-14 10:40:40 UTC (rev 154044)
@@ -49,3 +49,9 @@
 X X X
 X X X
 PASS
+X X X
+X X X

[webkit-changes] [153752] trunk

[sergio]

Title: [153752] trunk








Revision 153752
Author ser...@webkit.org
Date 2013-08-06 08:08:21 -0700 (Tue, 06 Aug 2013)


Log Message
[CSS Grid Layout] Allow defining named grid lines on the grid element
https://bugs.webkit.org/show_bug.cgi?id=118255

Reviewed by Andreas Kling.

>From Blink r149798 by 

Source/WebCore:

This change adds parsing, style resolution and getComputedStyle
support for named grid lines at the grid element level
(i.e. extends our  support). Per the specification, we
allow multiple grid lines with the same name.

To fully support resolving the grid lines to a position on our
grid, we need to add the parsing at the grid item's level (which
means extending our  support). This will be done in a
follow-up change.

Test: fast/css-grid-layout/named-grid-line-get-set.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::addValuesForNamedGridLinesAtIndex):
(WebCore::valueForGridTrackList):
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseGridTrackList):
* css/StyleResolver.cpp:
(WebCore::createGridTrackList):
(WebCore::StyleResolver::applyProperty):
* rendering/style/RenderStyle.h:
* rendering/style/StyleGridData.cpp:
(WebCore::StyleGridData::StyleGridData):
* rendering/style/StyleGridData.h:
(WebCore::StyleGridData::operator==):

LayoutTests:

* fast/css-grid-layout/named-grid-line-get-set-expected.txt: Added.
* fast/css-grid-layout/named-grid-line-get-set.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/StyleResolver.cpp
trunk/Source/WebCore/rendering/style/RenderStyle.h
trunk/Source/WebCore/rendering/style/StyleGridData.cpp
trunk/Source/WebCore/rendering/style/StyleGridData.h


Added Paths

trunk/LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt
trunk/LayoutTests/fast/css-grid-layout/named-grid-line-get-set.html




Diff

Modified: trunk/LayoutTests/ChangeLog (153751 => 153752)

--- trunk/LayoutTests/ChangeLog	2013-08-06 13:58:39 UTC (rev 153751)
+++ trunk/LayoutTests/ChangeLog	2013-08-06 15:08:21 UTC (rev 153752)
@@ -1,3 +1,15 @@
+2013-08-06  Sergio Villar Senin  
+
+[CSS Grid Layout] Allow defining named grid lines on the grid element
+https://bugs.webkit.org/show_bug.cgi?id=118255
+
+Reviewed by Andreas Kling.
+
+From Blink r149798 by 
+
+* fast/css-grid-layout/named-grid-line-get-set-expected.txt: Added.
+* fast/css-grid-layout/named-grid-line-get-set.html: Added.
+
 2013-06-26  Sergio Villar Senin  
 
 [CSS Grid Layout] Add support for parsing  that includes a 'span'


Added: trunk/LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt (0 => 153752)

--- trunk/LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css-grid-layout/named-grid-line-get-set-expected.txt	2013-08-06 15:08:21 UTC (rev 153752)
@@ -0,0 +1,52 @@
+Test that setting and getting grid-definition-columns and grid-definition-rows works as expected
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Test getting -webkit-grid-definition-columns and -webkit-grid-definition-rows set through CSS
+PASS getComputedStyle(gridElement, '').getPropertyValue('-webkit-grid-definition-columns') is "first 10px"
+PASS getComputedStyle(gridElement, '').getPropertyValue('-webkit-grid-definition-rows') is "first 15px"
+PASS getComputedStyle(gridElement, '').getPropertyValue('-webkit-grid-definition-columns') is "53% last"
+PASS getComputedStyle(gridElement, '').getPropertyValue('-webkit-grid-definition-rows') is "27% last"
+PASS getComputedStyle(gridElement, '').getPropertyValue('-webkit-grid-definition-columns') is "first auto"
+PASS getComputedStyle(gridElement, '').getPropertyValue('-webkit-grid-definition-rows') is "auto last"
+PASS getComputedStyle(gridElement, '').getPropertyValue('-webkit-grid-definition-columns') is "first minmax(10%, 15px)"
+PASS getComputedStyle(gridElement, '').getPropertyValue('-webkit-grid-definition-rows') is "minmax(20px, 50%) last"
+PASS getComputedStyle(gridElement, '').getPropertyValue('-webkit-grid-definition-columns') is "nav first 10px last"
+PASS getComputedStyle(gridElement, '').getPropertyValue('-webkit-grid-definition-rows') is "nav first 15px last"
+PASS getComputedStyle(gridElement, '').getPropertyValue('-webkit-grid-definition-columns') is "nav first 10% nav 15% last"
+PASS getComputedStyle(gridElement, ''

[webkit-changes] [152367] trunk/Source/WebKit2

[sergio]

Title: [152367] trunk/Source/WebKit2








Revision 152367
Author ser...@webkit.org
Date 2013-07-03 10:35:13 -0700 (Wed, 03 Jul 2013)


Log Message
[GTK][WK2] SIGSEV in WebKit::WebPageContextMenuClient::customContextMenuItemSelected
https://bugs.webkit.org/show_bug.cgi?id=116867

Reviewed by Anders Carlsson.

We did not reset the clients on WebPageProxy::close(), so right
clicking on a link after starting the navigation to some other
page was causing crashes because code was trying to access an
already freed m_contextMenuClient.

There were some other clients that could potentially trigger the
same issues. Reset them all to null to prevent this situation.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (152366 => 152367)

--- trunk/Source/WebKit2/ChangeLog	2013-07-03 17:28:43 UTC (rev 152366)
+++ trunk/Source/WebKit2/ChangeLog	2013-07-03 17:35:13 UTC (rev 152367)
@@ -1,3 +1,21 @@
+2013-07-03  Sergio Villar Senin  
+
+[GTK][WK2] SIGSEV in WebKit::WebPageContextMenuClient::customContextMenuItemSelected
+https://bugs.webkit.org/show_bug.cgi?id=116867
+
+Reviewed by Anders Carlsson.
+
+We did not reset the clients on WebPageProxy::close(), so right
+clicking on a link after starting the navigation to some other
+page was causing crashes because code was trying to access an
+already freed m_contextMenuClient.
+
+There were some other clients that could potentially trigger the
+same issues. Reset them all to null to prevent this situation.
+
+* UIProcess/WebPageProxy.cpp:
+(WebKit::WebPageProxy::close):
+
 2013-07-03  Simon Pena  
 
 Output arguments used in IPC calls should be returned initialised


Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (152366 => 152367)

--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2013-07-03 17:28:43 UTC (rev 152366)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2013-07-03 17:35:13 UTC (rev 152367)
@@ -629,13 +629,19 @@
 m_activePopupMenu = 0;
 
 m_estimatedProgress = 0.0;
-
+
 m_loaderClient.initialize(0);
 m_policyClient.initialize(0);
+m_formClient.initialize(0);
 m_uiClient.initialize(0);
 #if PLATFORM(EFL)
 m_uiPopupMenuClient.initialize(0);
 #endif
+m_findClient.initialize(0);
+m_findMatchesClient.initialize(0);
+#if ENABLE(CONTEXT_MENUS)
+m_contextMenuClient.initialize(0);
+#endif
 
 m_drawingArea = nullptr;
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [152354] trunk/Source/WebKit2

[sergio]

Title: [152354] trunk/Source/WebKit2








Revision 152354
Author ser...@webkit.org
Date 2013-07-03 07:52:03 -0700 (Wed, 03 Jul 2013)


Log Message
[WK2][GTK] Invalid ASSERTs in WebResources loading code
https://bugs.webkit.org/show_bug.cgi?id=118352

Reviewed by Carlos Garcia Campos.

The WebKitWebView keeps track of the resources being loaded in a
map. A couple of ASSERTs verify that every loaded resource is
stored in that map.

The map that is cleared each time a new load starts so there is a
small chance that we get notifications for resources that
correspond to previous page loads
(and thus are not stored in the map). We should remove the ASSERT
which is not valid anymore.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewGetLoadingWebResource):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (152353 => 152354)

--- trunk/Source/WebKit2/ChangeLog	2013-07-03 14:18:34 UTC (rev 152353)
+++ trunk/Source/WebKit2/ChangeLog	2013-07-03 14:52:03 UTC (rev 152354)
@@ -1,3 +1,23 @@
+2013-07-03  Sergio Villar Senin  
+
+[WK2][GTK] Invalid ASSERTs in WebResources loading code
+https://bugs.webkit.org/show_bug.cgi?id=118352
+
+Reviewed by Carlos Garcia Campos.
+
+The WebKitWebView keeps track of the resources being loaded in a
+map. A couple of ASSERTs verify that every loaded resource is
+stored in that map.
+
+The map that is cleared each time a new load starts so there is a
+small chance that we get notifications for resources that
+correspond to previous page loads
+(and thus are not stored in the map). We should remove the ASSERT
+which is not valid anymore.
+
+* UIProcess/API/gtk/WebKitWebView.cpp:
+(webkitWebViewGetLoadingWebResource):
+
 2013-07-03  Carlos Garcia Campos  
 
 [GTK] Migrate WebKitWebContext to GTask


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (152353 => 152354)

--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp	2013-07-03 14:18:34 UTC (rev 152353)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp	2013-07-03 14:52:03 UTC (rev 152354)
@@ -1622,7 +1622,6 @@
 WebKitWebResource* webkitWebViewGetLoadingWebResource(WebKitWebView* webView, uint64_t resourceIdentifier)
 {
 GRefPtr resource = webView->priv->loadingResourcesMap.get(resourceIdentifier);
-ASSERT(resource.get());
 return resource.get();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [152165] trunk/Source/WebKit2

[sergio]

Title: [152165] trunk/Source/WebKit2








Revision 152165
Author ser...@webkit.org
Date 2013-06-28 07:49:24 -0700 (Fri, 28 Jun 2013)


Log Message
[WK2][GTK] 100% CPU usage rendering a page with animations
https://bugs.webkit.org/show_bug.cgi?id=117703

Reviewed by Martin Robinson.

Unconditionally update the value of m_lastFlushTime in
::flushAndRenderLayers. By doing that we avoid a neverending
sequence of layer flushes that happened when m_lastFlushTime==0
and flushPendingLayerChanges() was false. In that situation the
value m_lastFlushTime was never updated so a new flush was always
rescheduled.

* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::flushAndRenderLayers):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (152164 => 152165)

--- trunk/Source/WebKit2/ChangeLog	2013-06-28 14:29:58 UTC (rev 152164)
+++ trunk/Source/WebKit2/ChangeLog	2013-06-28 14:49:24 UTC (rev 152165)
@@ -1,3 +1,20 @@
+2013-06-28  Sergio Villar Senin  
+
+[WK2][GTK] 100% CPU usage rendering a page with animations
+https://bugs.webkit.org/show_bug.cgi?id=117703
+
+Reviewed by Martin Robinson.
+
+Unconditionally update the value of m_lastFlushTime in
+::flushAndRenderLayers. By doing that we avoid a neverending
+sequence of layer flushes that happened when m_lastFlushTime==0
+and flushPendingLayerChanges() was false. In that situation the
+value m_lastFlushTime was never updated so a new flush was always
+rescheduled.
+
+* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
+(WebKit::LayerTreeHostGtk::flushAndRenderLayers):
+
 2013-06-28  Andres Gomez  
 
 [GTK] MiniBrowser doesn't solve the saving location when there are no XDG settings


Modified: trunk/Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp (152164 => 152165)

--- trunk/Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp	2013-06-28 14:29:58 UTC (rev 152164)
+++ trunk/Source/WebKit2/WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp	2013-06-28 14:49:24 UTC (rev 152165)
@@ -360,10 +360,10 @@
 if (!context || !context->makeContextCurrent())
 return;
 
+m_lastFlushTime = currentTime();
 if (!flushPendingLayerChanges())
 return;
 
-m_lastFlushTime = currentTime();
 // Our model is very simple. We always composite and render the tree immediately after updating it.
 compositeLayersToContext();
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151641] trunk/LayoutTests

[sergio]

Title: [151641] trunk/LayoutTests








Revision 151641
Author ser...@webkit.org
Date 2013-06-17 07:32:02 -0700 (Mon, 17 Jun 2013)


Log Message
Remove invalid checks from block-cursor-overtype-mode.html
https://bugs.webkit.org/show_bug.cgi?id=117587

Reviewed by Darin Adler.

The test uses an array of ">" "<" symbols to perform comparisons
between consecutive positions of the block cursor. Since those
checks are done for each pair of consecutive characters the total
amount of checks is lengthOfTheWord - 1. We were adding an extra
symbol that was not used at all in the test.

* editing/selection/block-cursor-overtype-mode.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/selection/block-cursor-overtype-mode.html




Diff

Modified: trunk/LayoutTests/ChangeLog (151640 => 151641)

--- trunk/LayoutTests/ChangeLog	2013-06-17 13:57:45 UTC (rev 151640)
+++ trunk/LayoutTests/ChangeLog	2013-06-17 14:32:02 UTC (rev 151641)
@@ -1,3 +1,18 @@
+2013-06-17  Sergio Villar Senin  
+
+Remove invalid checks from block-cursor-overtype-mode.html
+https://bugs.webkit.org/show_bug.cgi?id=117587
+
+Reviewed by Darin Adler.
+
+The test uses an array of ">" "<" symbols to perform comparisons
+between consecutive positions of the block cursor. Since those
+checks are done for each pair of consecutive characters the total
+amount of checks is lengthOfTheWord - 1. We were adding an extra
+symbol that was not used at all in the test.
+
+* editing/selection/block-cursor-overtype-mode.html:
+
 2013-06-17  Zoltan Arvai  
 
 [Qt] Unreviewed gardening. Correcting rebaselining after r151634.


Modified: trunk/LayoutTests/editing/selection/block-cursor-overtype-mode.html (151640 => 151641)

--- trunk/LayoutTests/editing/selection/block-cursor-overtype-mode.html	2013-06-17 13:57:45 UTC (rev 151640)
+++ trunk/LayoutTests/editing/selection/block-cursor-overtype-mode.html	2013-06-17 14:32:02 UTC (rev 151641)
@@ -57,10 +57,10 @@
 
 internals.toggleOverwriteModeEnabled(document);
 
-verifyBlockCursorLeftPositionAndWidth("ltrtext", ["<", "<", "<"]);
-verifyBlockCursorLeftPositionAndWidth("ltrtext-rtl", ["<", "<", "<"]);
-verifyBlockCursorLeftPositionAndWidth("rtltext", [">", ">", ">"]);
-verifyBlockCursorLeftPositionAndWidth("rtltext-rtl", [">", ">", ">"]);
+verifyBlockCursorLeftPositionAndWidth("ltrtext", ["<", "<"]);
+verifyBlockCursorLeftPositionAndWidth("ltrtext-rtl", ["<", "<"]);
+verifyBlockCursorLeftPositionAndWidth("rtltext", [">", ">"]);
+verifyBlockCursorLeftPositionAndWidth("rtltext-rtl", [">", ">"]);
 verifyBlockCursorLeftPositionAndWidth("mixed", [">", ">", "<", "<", "<"]);
 verifyBlockCursorLeftPositionAndWidth("mixed-rtl", [">", ">", ">", "<", "<"]);
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151510] trunk

[sergio]

Title: [151510] trunk








Revision 151510
Author ser...@webkit.org
Date 2013-06-12 10:23:31 -0700 (Wed, 12 Jun 2013)


Log Message
Skipping {}, () and [] blocks while error recovering in CSS
https://bugs.webkit.org/show_bug.cgi?id=116071

Reviewed by Darin Adler.

>From Blink r150201 and r150755 by 

Source/WebCore:

Test: fast/css/parsing-expr-error-recovery.html

The CSS parser should properly recover from invalid {}, () and []
blocks skipping them instead of discarding the whole declaration
as invalid. This merge is actually made of two different changes
from Blink, the original one that fixes the bug and another one
which refactors a bit the code making it more legible.

* css/CSSGrammar.y.in:

LayoutTests:

* fast/css/parsing-expr-error-recovery-expected.txt: Added.
* fast/css/parsing-expr-error-recovery.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSGrammar.y.in


Added Paths

trunk/LayoutTests/fast/css/parsing-expr-error-recovery-expected.txt
trunk/LayoutTests/fast/css/parsing-expr-error-recovery.html




Diff

Modified: trunk/LayoutTests/ChangeLog (151509 => 151510)

--- trunk/LayoutTests/ChangeLog	2013-06-12 17:22:57 UTC (rev 151509)
+++ trunk/LayoutTests/ChangeLog	2013-06-12 17:23:31 UTC (rev 151510)
@@ -1,5 +1,17 @@
 2013-06-12  Sergio Villar Senin  
 
+Skipping {}, () and [] blocks while error recovering in CSS
+https://bugs.webkit.org/show_bug.cgi?id=116071
+
+Reviewed by Darin Adler.
+
+From Blink r150201 and r150755 by 
+
+* fast/css/parsing-expr-error-recovery-expected.txt: Added.
+* fast/css/parsing-expr-error-recovery.html: Added.
+
+2013-06-12  Sergio Villar Senin  
+
 [css exclusions] fast/css/variables/var-inside-shape.html is failing
 https://bugs.webkit.org/show_bug.cgi?id=116059
 


Added: trunk/LayoutTests/fast/css/parsing-expr-error-recovery-expected.txt (0 => 151510)

--- trunk/LayoutTests/fast/css/parsing-expr-error-recovery-expected.txt	(rev 0)
+++ trunk/LayoutTests/fast/css/parsing-expr-error-recovery-expected.txt	2013-06-12 17:23:31 UTC (rev 151510)
@@ -0,0 +1,3 @@
+Tests that CSS parser correctly recovers after {}, () and [] invalid blocks.
+All tests passed
+


Added: trunk/LayoutTests/fast/css/parsing-expr-error-recovery.html (0 => 151510)

--- trunk/LayoutTests/fast/css/parsing-expr-error-recovery.html	(rev 0)
+++ trunk/LayoutTests/fast/css/parsing-expr-error-recovery.html	2013-06-12 17:23:31 UTC (rev 151510)
@@ -0,0 +1,33 @@
+
+
+Tests that CSS parser correctly recovers after {}, () and [] invalid blocks.
+
+
+
+if (window.testRunner)
+testRunner.dumpAsText();
+
+var BASE_EXPR = "1px,\"x\",var(y) /calc(1px + (((5px,-webkit-min(1px,2px)";
+var INVALID_BLOCKS = ["#", "{}", "()", "[]", "{(){{}{{}}[]}}", "(})", "(])", "[}]", "[)]", "{)}", "{]}", "#({})"];
+
+var tests = document.getElementById("tests");
+for (var i = 0; i <= BASE_EXPR.length; i++) {
+for (var j = 0; j < INVALID_BLOCKS.length; j++) {
+var invalidExpr = BASE_EXPR.substr(0, i) + INVALID_BLOCKS[j] + BASE_EXPR.substr(i);
+var test = document.createElement("DIV");
+test.textContent = "failed: " + invalidExpr;
+test.style.cssText = "color:" + invalidExpr + "; display: none;";
+tests.appendChild(test);
+}
+}
+
+var failed = 0;
+for (var test = tests.firstChild; test; test = test.nextSibling) {
+   if (getComputedStyle(test).display != "none")
+   failed++;
+}
+
+document.getElementById("result").textContent = failed ? "Failed " + failed + " tests" : "All tests passed";
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (151509 => 151510)

--- trunk/Source/WebCore/ChangeLog	2013-06-12 17:22:57 UTC (rev 151509)
+++ trunk/Source/WebCore/ChangeLog	2013-06-12 17:23:31 UTC (rev 151510)
@@ -1,3 +1,22 @@
+2013-06-12  Sergio Villar Senin  
+
+Skipping {}, () and [] blocks while error recovering in CSS
+https://bugs.webkit.org/show_bug.cgi?id=116071
+
+Reviewed by Darin Adler.
+
+From Blink r150201 and r150755 by 
+
+Test: fast/css/parsing-expr-error-recovery.html
+
+The CSS parser should properly recover from invalid {}, () and []
+blocks skipping them instead of discarding the whole declaration
+as invalid. This merge is actually made of two different changes
+from Blink, the original one that fixes the bug and another one
+which refactors a bit the code making it more legible.
+
+* css/CSSGrammar.y.in:
+
 2013-06-12  Alberto Garcia  
 
 [BlackBerry] Remove dead WebDOM code


Modified: trunk/Source/WebCore/css/CSSGrammar.y.in (1

[webkit-changes] [151506] trunk/LayoutTests

[sergio]

Title: [151506] trunk/LayoutTests








Revision 151506
Author ser...@webkit.org
Date 2013-06-12 10:01:00 -0700 (Wed, 12 Jun 2013)


Log Message
[css exclusions] fast/css/variables/var-inside-shape.html is failing
https://bugs.webkit.org/show_bug.cgi?id=116059

Reviewed by Alexandru Chiculita.

Some shapes were incorrectly defined, there was a "rectange"
instead of a "rectangle" and also the number of parameters and
their types was wrong. Apart from that, both the CSS exclusions
and CSS variables settings were not enabled at runtime.

Some extra text was also added to the divs in order to verify that
the CSS exclusions are working properly.

* fast/css/variables/var-inside-shape-expected.html:
* fast/css/variables/var-inside-shape.html:
* platform/efl/TestExpectations: Removed var-inside-shape.html.
* platform/gtk/TestExpectations: Ditto.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/variables/var-inside-shape-expected.html
trunk/LayoutTests/fast/css/variables/var-inside-shape.html
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (151505 => 151506)

--- trunk/LayoutTests/ChangeLog	2013-06-12 16:46:15 UTC (rev 151505)
+++ trunk/LayoutTests/ChangeLog	2013-06-12 17:01:00 UTC (rev 151506)
@@ -1,3 +1,23 @@
+2013-06-12  Sergio Villar Senin  
+
+[css exclusions] fast/css/variables/var-inside-shape.html is failing
+https://bugs.webkit.org/show_bug.cgi?id=116059
+
+Reviewed by Alexandru Chiculita.
+
+Some shapes were incorrectly defined, there was a "rectange"
+instead of a "rectangle" and also the number of parameters and
+their types was wrong. Apart from that, both the CSS exclusions
+and CSS variables settings were not enabled at runtime.
+
+Some extra text was also added to the divs in order to verify that
+the CSS exclusions are working properly.
+
+* fast/css/variables/var-inside-shape-expected.html:
+* fast/css/variables/var-inside-shape.html:
+* platform/efl/TestExpectations: Removed var-inside-shape.html.
+* platform/gtk/TestExpectations: Ditto.
+
 2013-06-12  Daniel Bates  
 
 window.find() case-insensitive search doesn't match diacritical marks


Modified: trunk/LayoutTests/fast/css/variables/var-inside-shape-expected.html (151505 => 151506)

--- trunk/LayoutTests/fast/css/variables/var-inside-shape-expected.html	2013-06-12 16:46:15 UTC (rev 151505)
+++ trunk/LayoutTests/fast/css/variables/var-inside-shape-expected.html	2013-06-12 17:01:00 UTC (rev 151506)
@@ -1,5 +1,9 @@
 
 
+
+if (window.internals)
+internals.settings.setCSSExclusionsEnabled(true);
+
 
</span><span class="cx"> .a {
</span><span class="cx"> -webkit-shape-inside: ellipse(100px, 100px, 100px, 100px);
</span><span class="lines">@@ -8,22 +12,23 @@
</span><span class="cx"> -webkit-shape-inside: circle(100px, 100px, 100px);
</span><span class="cx"> }
</span><span class="cx"> .c {
</span><del>--webkit-shape-inside: rectange(100px);
</del><ins>+-webkit-shape-inside: rectangle(100px, 100px, 100px, 100px);
</ins><span class="cx"> }
</span><span class="cx"> .d {
</span><del>--webkit-shape-inside: polygon(100px, 100px, 100px, 100px, 100px);
</del><ins>+height: 100px;
+-webkit-shape-inside: polygon(10% 100%, 100% 50%, 50% 10%);
</ins><span class="cx"> }
</span><span class="cx"> 
 
-Some text.
+Some text inside an area inside which inline content can flow.
 
 
-Some text.
+Some text inside an area inside which inline content can flow.
 
 
-Some text.
+Some text inside an area inside which inline content can flow.
 
 
-Some text.
+Some text inside an area inside which inline content can flow.
 
 


Modified: trunk/LayoutTests/fast/css/variables/var-inside-shape.html (151505 => 151506)

--- trunk/LayoutTests/fast/css/variables/var-inside-shape.html	2013-06-12 16:46:15 UTC (rev 151505)
+++ trunk/LayoutTests/fast/css/variables/var-inside-shape.html	2013-06-12 17:01:00 UTC (rev 151506)
@@ -1,36 +1,42 @@
 
 
 
</span><del>-if (window.internals)
</del><ins>+if (window.internals) {
</ins><span class="cx"> internals.settings.setCSSVariablesEnabled(true);
</span><ins>+internals.settings.setCSSExclusionsEnabled(true);
+}
</ins><span class="cx"> 
 
</span><span class="cx"> :root {
</span><span class="cx"> -webkit-var-a: 100px;
</span><ins>+-webkit-var-b: 100%;
+-webkit-var-c: 50%;
+-webkit-var-d: 10%;
</ins><span c

[webkit-changes] [151493] trunk/Source/WebCore

[sergio]

Title: [151493] trunk/Source/WebCore








Revision 151493
Author ser...@webkit.org
Date 2013-06-12 04:34:01 -0700 (Wed, 12 Jun 2013)


Log Message
[Soup] Use ResourceLoadPriority
https://bugs.webkit.org/show_bug.cgi?id=112902

Reviewed by Carlos Garcia Campos.

Use the ResourceLoadPriority from the ResourceRequest to set the
correnpondent priority to each SoupMessage.

No new tests required as there is no change in functionality,
we're just enabling a new feature in the underlying network stack.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::createSoupMessageForHandleAndRequest):
* platform/network/soup/ResourceRequest.h:
(WebCore):
(WebCore::toSoupMessagePriority): Translates ResourceLoadPriority
to SoupMessagePriority.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp
trunk/Source/WebCore/platform/network/soup/ResourceRequest.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (151492 => 151493)

--- trunk/Source/WebCore/ChangeLog	2013-06-12 08:51:48 UTC (rev 151492)
+++ trunk/Source/WebCore/ChangeLog	2013-06-12 11:34:01 UTC (rev 151493)
@@ -1,3 +1,23 @@
+2013-06-12  Sergio Villar Senin  
+
+[Soup] Use ResourceLoadPriority
+https://bugs.webkit.org/show_bug.cgi?id=112902
+
+Reviewed by Carlos Garcia Campos.
+
+Use the ResourceLoadPriority from the ResourceRequest to set the
+correnpondent priority to each SoupMessage.
+
+No new tests required as there is no change in functionality,
+we're just enabling a new feature in the underlying network stack.
+
+* platform/network/soup/ResourceHandleSoup.cpp:
+(WebCore::createSoupMessageForHandleAndRequest):
+* platform/network/soup/ResourceRequest.h:
+(WebCore):
+(WebCore::toSoupMessagePriority): Translates ResourceLoadPriority
+to SoupMessagePriority.
+
 2013-06-12  Zan Dobersek  
 
 Remove memoryInfoEnabled, quantizedMemoryInfoEnabled settings


Modified: trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (151492 => 151493)

--- trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp	2013-06-12 08:51:48 UTC (rev 151492)
+++ trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp	2013-06-12 11:34:01 UTC (rev 151493)
@@ -985,6 +985,10 @@
 g_signal_connect(d->m_soupMessage.get(), "wrote-body", G_CALLBACK(wroteBodyCallback), handle);
 #endif
 
+#if SOUP_CHECK_VERSION(2, 43, 1)
+soup_message_set_priority(d->m_soupMessage.get(), toSoupMessagePriority(request.priority()));
+#endif
+
 return true;
 }
 


Modified: trunk/Source/WebCore/platform/network/soup/ResourceRequest.h (151492 => 151493)

--- trunk/Source/WebCore/platform/network/soup/ResourceRequest.h	2013-06-12 08:51:48 UTC (rev 151492)
+++ trunk/Source/WebCore/platform/network/soup/ResourceRequest.h	2013-06-12 11:34:01 UTC (rev 151493)
@@ -97,6 +97,29 @@
 struct CrossThreadResourceRequestData : public CrossThreadResourceRequestDataBase {
 };
 
+#if SOUP_CHECK_VERSION(2, 43, 1)
+inline SoupMessagePriority toSoupMessagePriority(ResourceLoadPriority priority)
+{
+switch (priority) {
+case ResourceLoadPriorityUnresolved:
+return SOUP_MESSAGE_PRIORITY_NORMAL;
+case ResourceLoadPriorityVeryLow:
+return SOUP_MESSAGE_PRIORITY_VERY_LOW;
+case ResourceLoadPriorityLow:
+return SOUP_MESSAGE_PRIORITY_LOW;
+case ResourceLoadPriorityMedium:
+return SOUP_MESSAGE_PRIORITY_NORMAL;
+case ResourceLoadPriorityHigh:
+return SOUP_MESSAGE_PRIORITY_HIGH;
+case ResourceLoadPriorityVeryHigh:
+return SOUP_MESSAGE_PRIORITY_VERY_HIGH;
+}
+
+ASSERT_NOT_REACHED();
+return SOUP_MESSAGE_PRIORITY_VERY_LOW;
+}
+#endif
+
 } // namespace WebCore
 
 #endif // ResourceRequest_h






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151488] trunk

[sergio]

Title: [151488] trunk








Revision 151488
Author ser...@webkit.org
Date 2013-06-12 00:20:20 -0700 (Wed, 12 Jun 2013)


Log Message
Add CSS parsing recovery to functions
https://bugs.webkit.org/show_bug.cgi?id=117500

Reviewed by Andreas Kling.

>From Blink r150205 by 

Source/WebCore:

Add parsing recovery capabilities to functions. Errors were
correctly detected without this change but then the whole
declaration was invalidated. By using expr_recovery to handle them
we can recover from those errors and go on with the parsing.

* css/CSSGrammar.y.in:

LayoutTests:

* fast/css/parsing-error-recovery.html: added some test cases for
parsing recovery inside functions.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/parsing-error-recovery.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSGrammar.y.in




Diff

Modified: trunk/LayoutTests/ChangeLog (151487 => 151488)

--- trunk/LayoutTests/ChangeLog	2013-06-12 06:05:58 UTC (rev 151487)
+++ trunk/LayoutTests/ChangeLog	2013-06-12 07:20:20 UTC (rev 151488)
@@ -1,3 +1,15 @@
+2013-06-12  Sergio Villar Senin  
+
+Add CSS parsing recovery to functions
+https://bugs.webkit.org/show_bug.cgi?id=117500
+
+Reviewed by Andreas Kling.
+
+From Blink r150205 by 
+
+* fast/css/parsing-error-recovery.html: added some test cases for
+parsing recovery inside functions.
+
 2013-06-11  Gyuyoung Kim  
 
 Unreviewed, EFL Gardening. Unskip fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html


Modified: trunk/LayoutTests/fast/css/parsing-error-recovery.html (151487 => 151488)

--- trunk/LayoutTests/fast/css/parsing-error-recovery.html	2013-06-12 06:05:58 UTC (rev 151487)
+++ trunk/LayoutTests/fast/css/parsing-error-recovery.html	2013-06-12 07:20:20 UTC (rev 151488)
@@ -60,6 +60,36 @@
 display: block !important {invalid_block}
 }
 
+#test8 {
+color: rgb(1,});
+display: none;
+}
+
+#test9 {
+color: rgb(});
+display: none;
+}
+
+#test10 {
+width: calc(1,});
+display: none;
+}
+
+#test11 {
+width: calc(});
+display: none;
+}
+
+#test12 {
+width: -webkit-min(1,});
+display: none;
+}
+
+#test13 {
+width: -webkit-min(});
+display: none;
+}
+
 /* Successfully parsed */
 #last {
 display:block;
@@ -74,6 +104,12 @@
   FAIL: Test 5
   FAIL: Test 6
   FAIL: Test 7
+  FAIL: Test 8
+  FAIL: Test 9
+  FAIL: Test 10
+  FAIL: Test 11
+  FAIL: Test 12
+  FAIL: Test 13
   PASS
 
 


Modified: trunk/Source/WebCore/ChangeLog (151487 => 151488)

--- trunk/Source/WebCore/ChangeLog	2013-06-12 06:05:58 UTC (rev 151487)
+++ trunk/Source/WebCore/ChangeLog	2013-06-12 07:20:20 UTC (rev 151488)
@@ -1,3 +1,19 @@
+2013-06-12  Sergio Villar Senin  
+
+Add CSS parsing recovery to functions
+https://bugs.webkit.org/show_bug.cgi?id=117500
+
+Reviewed by Andreas Kling.
+
+From Blink r150205 by 
+
+Add parsing recovery capabilities to functions. Errors were
+correctly detected without this change but then the whole
+declaration was invalidated. By using expr_recovery to handle them
+we can recover from those errors and go on with the parsing.
+
+* css/CSSGrammar.y.in:
+
 2013-06-11  Christophe Dumez  
 
 Unreviewed, rolling out r151378.


Modified: trunk/Source/WebCore/css/CSSGrammar.y.in (151487 => 151488)

--- trunk/Source/WebCore/css/CSSGrammar.y.in	2013-06-12 06:05:58 UTC (rev 151487)
+++ trunk/Source/WebCore/css/CSSGrammar.y.in	2013-06-12 07:20:20 UTC (rev 151488)
@@ -88,9 +88,9 @@
 %}
 
 #if ENABLE_SHADOW_DOM
-%expect 33
+%expect 32
 #else
-%expect 32
+%expect 31
 #endif
 
 %nonassoc LOWEST_PREC
@@ -1700,13 +1700,13 @@
 #endif
   }
   /* FIXME: according to the specs a function can have a unary_operator in front. I know no case where this makes sense */
-  | function {
+  | function maybe_space {
   $$ = $1;
   }
-  | calc_function {
+  | calc_function maybe_space {
   $$ = $1;
   }
-  | min_or_max_function {
+  | min_or_max_function maybe_space {
   $$ = $1;
   }
   | '%' maybe_space { /* Handle width: %; */
@@ -1753,7 +1753,7 @@
   ;
 
 function:
-FUNCTION maybe_space expr closing_parenthesis maybe_space {
+FUNCTION maybe_space expr closing_parenthesis {
 CSSParserFunction* f = parser->createFloatingFunction();
 f->name = $1;
 f->args = parser->sinkFloatingValueList($3);
@@ -1761,7 +1761,7 @@
 $$.unit = CSSParserValue::Function;
 $$.function = f;
 } |
-FUNCTION maybe_space closing_parenthesis maybe_space {
+FUNCTION maybe_space closing_parenthesis {
 CSSParserFunction* f = parser->createFloatingFunction();
 f

[webkit-changes] [151424] trunk

[sergio]

Title: [151424] trunk








Revision 151424
Author ser...@webkit.org
Date 2013-06-11 00:10:00 -0700 (Tue, 11 Jun 2013)


Log Message
Autoclose braces and parentheses at the end of style sheet
https://bugs.webkit.org/show_bug.cgi?id=117414

Reviewed by Andreas Kling.

>From Blink r150202 by 

Source/WebCore:

Use closing_parenthesis and closing_brace instead of the literals
'}' and ')'. This allows the parser to treat expressions with
unmatched closing braces/parenthesis as if all of them were
actually closed.

Tests: animations/keyframe-autoclose-brace.html
   css3/autoclose-braces-and-parentheses.html

* css/CSSGrammar.y.in:

LayoutTests:

* animations/keyframe-autoclose-brace-expected.txt: Added.
* animations/keyframe-autoclose-brace.html: Added.
* css3/autoclose-braces-and-parentheses-expected.txt: Added.
* css3/autoclose-braces-and-parentheses.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSGrammar.y.in


Added Paths

trunk/LayoutTests/animations/keyframe-autoclose-brace-expected.txt
trunk/LayoutTests/animations/keyframe-autoclose-brace.html
trunk/LayoutTests/css3/autoclose-braces-and-parentheses-expected.txt
trunk/LayoutTests/css3/autoclose-braces-and-parentheses.html




Diff

Modified: trunk/LayoutTests/ChangeLog (151423 => 151424)

--- trunk/LayoutTests/ChangeLog	2013-06-11 05:47:40 UTC (rev 151423)
+++ trunk/LayoutTests/ChangeLog	2013-06-11 07:10:00 UTC (rev 151424)
@@ -1,3 +1,17 @@
+2013-06-11  Sergio Villar Senin  
+
+Autoclose braces and parentheses at the end of style sheet
+https://bugs.webkit.org/show_bug.cgi?id=117414
+
+Reviewed by Andreas Kling.
+
+From Blink r150202 by 
+
+* animations/keyframe-autoclose-brace-expected.txt: Added.
+* animations/keyframe-autoclose-brace.html: Added.
+* css3/autoclose-braces-and-parentheses-expected.txt: Added.
+* css3/autoclose-braces-and-parentheses.html: Added.
+
 2013-06-10  Ryosuke Niwa  
 
 Use shouldBeType in animations/keyframes-rule.html


Added: trunk/LayoutTests/animations/keyframe-autoclose-brace-expected.txt (0 => 151424)

--- trunk/LayoutTests/animations/keyframe-autoclose-brace-expected.txt	(rev 0)
+++ trunk/LayoutTests/animations/keyframe-autoclose-brace-expected.txt	2013-06-11 07:10:00 UTC (rev 151424)
@@ -0,0 +1,2 @@
+Tests parsing the @-webkit-keyframes rule without closing brace. "User agents must close all open constructs ... at the end of the style sheet." (http://www.w3.org/TR/CSS21/syndata.html#parsing-errors). So it must be parsed as if all braces are closed.
+Test passed


Added: trunk/LayoutTests/animations/keyframe-autoclose-brace.html (0 => 151424)

--- trunk/LayoutTests/animations/keyframe-autoclose-brace.html	(rev 0)
+++ trunk/LayoutTests/animations/keyframe-autoclose-brace.html	2013-06-11 07:10:00 UTC (rev 151424)
@@ -0,0 +1,46 @@
+
+
+
+
+  
+  Tests CSS parser autocloses braces.
+  
+@-webkit-keyframes "foo" {
+from { left: 100px; }
+40%  { left: 200px; }
+60%  { left: 200px; }
+to   { left: 300px;
+  
+  
+function findKeyframesRule(rule)
+{
+var ss = document.styleSheets;
+for (var i = 0; i < ss.length; ++i) {
+for (var j = 0; j < ss[i].cssRules.length; ++j) {
+if (ss[i].cssRules[j].type == window.CSSRule.WEBKIT_KEYFRAMES_RULE && ss[i].cssRules[j].name == rule)
+return ss[i].cssRules[j];
+}
+}
+
+return null;
+}
+
+function test()
+{
+if (window.testRunner)
+testRunner.dumpAsText();
+
+var keyframes = findKeyframesRule("foo");
+document.getElementById("console").textContent = keyframes && keyframes.cssRules.length == 4 ? "Test passed" : "Test failed";
+}
+
+  
+
+
+Tests parsing the @-webkit-keyframes rule without closing brace. "User agents must close all open constructs ... at the end of the style sheet."
+(
+
+
+


Added: trunk/LayoutTests/css3/autoclose-braces-and-parentheses-expected.txt (0 => 151424)

--- trunk/LayoutTests/css3/autoclose-braces-and-parentheses-expected.txt	(rev 0)
+++ trunk/LayoutTests/css3/autoclose-braces-and-parentheses-expected.txt	2013-06-11 07:10:00 UTC (rev 151424)
@@ -0,0 +1,3 @@
+Tests parsing style declarations without closing braces and parentheses. "User agents must close all open constructs ... at the end of the style sheet." (http://www.w3.org/TR/CSS21/syndata.html#parsing-errors). So it must be parsed as if all braces and parentheses are closed.
+All tests passed
+


Added: trunk/LayoutTests/css3/autoclose-braces-and-parentheses.html (0 => 151424)

--- trunk/LayoutTests/css3/autoclose-braces-and-parentheses.html	  

[webkit-changes] [151395] trunk/Source/WebCore

[sergio]

Title: [151395] trunk/Source/WebCore








Revision 151395
Author ser...@webkit.org
Date 2013-06-10 08:26:02 -0700 (Mon, 10 Jun 2013)


Log Message
Refactor CALCFUNCTION rules in the CSS grammar
https://bugs.webkit.org/show_bug.cgi?id=117401

Reviewed by Andreas Kling.

>From Blink r149862 by .

Reduce the number of CALCFUNCTION rules by refactoring the closing
parenthesis handling code.

No new tests required as this is a refactoring, no new functionality
added.

* css/CSSGrammar.y.in:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSGrammar.y.in




Diff

Modified: trunk/Source/WebCore/ChangeLog (151394 => 151395)

--- trunk/Source/WebCore/ChangeLog	2013-06-10 14:19:13 UTC (rev 151394)
+++ trunk/Source/WebCore/ChangeLog	2013-06-10 15:26:02 UTC (rev 151395)
@@ -1,3 +1,20 @@
+2013-06-10  Sergio Villar Senin  
+
+Refactor CALCFUNCTION rules in the CSS grammar
+https://bugs.webkit.org/show_bug.cgi?id=117401
+
+Reviewed by Andreas Kling.
+
+From Blink r149862 by .
+
+Reduce the number of CALCFUNCTION rules by refactoring the closing
+parenthesis handling code.
+
+No new tests required as this is a refactoring, no new functionality
+added.
+
+* css/CSSGrammar.y.in:
+
 2013-06-10  Radu Stavila  
 
 [CSS Regions] Rename region-overflow to region-fragment


Modified: trunk/Source/WebCore/css/CSSGrammar.y.in (151394 => 151395)

--- trunk/Source/WebCore/css/CSSGrammar.y.in	2013-06-10 14:19:13 UTC (rev 151394)
+++ trunk/Source/WebCore/css/CSSGrammar.y.in	2013-06-10 15:26:02 UTC (rev 151395)
@@ -1799,22 +1799,21 @@
 | WHITESPACE '-' WHITESPACE {
 $$ = '-';
 }
-| WHITESPACE '*' maybe_space {
+| calc_maybe_space '*' maybe_space {
 $$ = '*';
 }
-| WHITESPACE '/' maybe_space {
+| calc_maybe_space '/' maybe_space {
 $$ = '/';
 }
-| '*' maybe_space {
-$$ = '*';
-}
-| '/' maybe_space {
-$$ = '/';
-}
   ;
 
+calc_maybe_space:
+/* empty */
+| WHITESPACE
+  ;
+
 calc_func_paren_expr:
-'(' maybe_space calc_func_expr calc_closing_paren {
+'(' maybe_space calc_func_expr calc_maybe_space ')' {
 if ($3) {
 $$ = $3;
 CSSParserValue v;
@@ -1827,11 +1826,8 @@
 } else
 $$ = 0;
 }
+  ;
 
-calc_closing_paren:
-WHITESPACE ')'
-| ')'
-
 calc_func_expr:
 calc_func_term {
 $$ = parser->createFloatingValueList();
@@ -1869,13 +1865,10 @@
   ;
 
 calc_func_expr_list:
-calc_func_expr WHITESPACE {
+calc_func_expr calc_maybe_space {
 $$ = $1;
-}
-| calc_func_expr {
-$$ = $1;
 }
-| calc_func_expr_list ',' maybe_space calc_func_expr WHITESPACE {
+| calc_func_expr_list ',' maybe_space calc_func_expr calc_maybe_space {
 if ($1 && $4) {
 $$ = $1;
 CSSParserValue v;
@@ -1887,22 +1880,10 @@
 } else
 $$ = 0;
 }
-| calc_func_expr_list ',' maybe_space calc_func_expr {
-if ($1 && $4) {
-$$ = $1;
-CSSParserValue v;
-v.id = 0;
-v.unit = CSSParserValue::Operator;
-v.iValue = ',';
-$$->addValue(v);
-$$->extend(*($4));
-} else
-$$ = 0;
-}
-
+  ;
 
 calc_function:
-CALCFUNCTION maybe_space calc_func_expr calc_closing_paren maybe_space {
+CALCFUNCTION maybe_space calc_func_expr calc_maybe_space ')' maybe_space {
 CSSParserFunction* f = parser->createFloatingFunction();
 f->name = $1;
 f->args = parser->sinkFloatingValueList($3);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [151016] trunk/Source/WebCore

[sergio]

Title: [151016] trunk/Source/WebCore








Revision 151016
Author ser...@webkit.org
Date 2013-05-31 08:52:08 -0700 (Fri, 31 May 2013)


Log Message
Build fix when CSSParser debugging is enabled
https://bugs.webkit.org/show_bug.cgi?id=117075

Reviewed by Andreas Kling.

Build fails when enabling parser debugging by setting YYDEBUG to
1 because of a missing include.

* css/CSSGrammar.y.includes:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSGrammar.y.includes




Diff

Modified: trunk/Source/WebCore/ChangeLog (151015 => 151016)

--- trunk/Source/WebCore/ChangeLog	2013-05-31 15:21:40 UTC (rev 151015)
+++ trunk/Source/WebCore/ChangeLog	2013-05-31 15:52:08 UTC (rev 151016)
@@ -1,3 +1,15 @@
+2013-05-31  Sergio Villar Senin  
+
+Build fix when CSSParser debugging is enabled
+https://bugs.webkit.org/show_bug.cgi?id=117075
+
+Reviewed by Andreas Kling.
+
+Build fails when enabling parser debugging by setting YYDEBUG to
+1 because of a missing include.
+
+* css/CSSGrammar.y.includes:
+
 2013-05-31  Alberto Garcia  
 
 [Soup] [Gstreamer] ASSERT in StreamingClient::getOrCreateReadBuffer


Modified: trunk/Source/WebCore/css/CSSGrammar.y.includes (151015 => 151016)

--- trunk/Source/WebCore/css/CSSGrammar.y.includes	2013-05-31 15:21:40 UTC (rev 151015)
+++ trunk/Source/WebCore/css/CSSGrammar.y.includes	2013-05-31 15:52:08 UTC (rev 151016)
@@ -54,6 +54,7 @@
 #define YYDEBUG 0
 
 #if YYDEBUG > 0
+#include 
 #define YYPRINT(File,Type,Value) if (isCSSTokenAString(Type)) YYFPRINTF(File, "%s", String((Value).string).utf8().data())
 #endif
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150972] trunk

[sergio]

Title: [150972] trunk








Revision 150972
Author ser...@webkit.org
Date 2013-05-30 11:20:32 -0700 (Thu, 30 May 2013)


Log Message
Allow no space between "background-position:" dimensions
https://bugs.webkit.org/show_bug.cgi?id=116870

Reviewed by Darin Adler.

>From Blink r149314 by 

Source/WebCore:

Specs allow no spaces between the dimensions of a
"background-position:" like "1px+1px", we should support
that.

Whitespaces are no longer early consumed, dramatically dropping
the shift/reduce conflicts to half. The productions unary_term,
calc_func_term, calc_func_expr and calc_func_paren_expr no longer
consume whitespaces.

* css/CSSGrammar.y.in:
* css/CSSParser.cpp:
(WebCore::CSSParser::realLex):

LayoutTests:

* fast/backgrounds/background-position-parsing-2-expected.txt:
* fast/backgrounds/background-position-parsing-2.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/backgrounds/background-position-parsing-2-expected.txt
trunk/LayoutTests/fast/backgrounds/background-position-parsing-2.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSGrammar.y.in
trunk/Source/WebCore/css/CSSParser.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (150971 => 150972)

--- trunk/LayoutTests/ChangeLog	2013-05-30 18:19:00 UTC (rev 150971)
+++ trunk/LayoutTests/ChangeLog	2013-05-30 18:20:32 UTC (rev 150972)
@@ -1,3 +1,15 @@
+2013-05-30  Sergio Villar Senin  
+
+Allow no space between "background-position:" dimensions
+https://bugs.webkit.org/show_bug.cgi?id=116870
+
+Reviewed by Darin Adler.
+
+From Blink r149314 by 
+
+* fast/backgrounds/background-position-parsing-2-expected.txt:
+* fast/backgrounds/background-position-parsing-2.html:
+
 2013-05-30  Zoltan Arvai  
 
 [Qt] Unreviewed gardening.


Modified: trunk/LayoutTests/fast/backgrounds/background-position-parsing-2-expected.txt (150971 => 150972)

--- trunk/LayoutTests/fast/backgrounds/background-position-parsing-2-expected.txt	2013-05-30 18:19:00 UTC (rev 150971)
+++ trunk/LayoutTests/fast/backgrounds/background-position-parsing-2-expected.txt	2013-05-30 18:20:32 UTC (rev 150972)
@@ -81,6 +81,8 @@
 PASS computedStyle.backgroundPosition is '50% 50%'
 PASS style.backgroundPosition is '50% 50%'
 PASS computedStyle.backgroundPosition is '50% 50%'
+PASS style.backgroundPosition is '1px 1px'
+PASS computedStyle.backgroundPosition is '1px 1px'
 background-position with CSS3 comma separator, one or two values
 PASS style.backgroundPosition is '50% 50%, 100% 50%'
 PASS computedStyle.backgroundPosition is '50% 50%, 100% 50%'


Modified: trunk/LayoutTests/fast/backgrounds/background-position-parsing-2.html (150971 => 150972)

--- trunk/LayoutTests/fast/backgrounds/background-position-parsing-2.html	2013-05-30 18:19:00 UTC (rev 150971)
+++ trunk/LayoutTests/fast/backgrounds/background-position-parsing-2.html	2013-05-30 18:20:32 UTC (rev 150972)
@@ -174,6 +174,10 @@
 shouldBe("style.backgroundPosition", "'50% 50%'");
 shouldBe("computedStyle.backgroundPosition", "'50% 50%'");
 
+style.backgroundPosition = "1px+1px";
+shouldBe("style.backgroundPosition", "'1px 1px'");
+shouldBe("computedStyle.backgroundPosition", "'1px 1px'");
+
 debug("background-position with CSS3 comma separator, one or two values");
 style.backgroundImage = "url(resources/diamond.png), url(resources/ring.png)";
 style.backgroundRepeat = "no-repeat";


Modified: trunk/Source/WebCore/ChangeLog (150971 => 150972)

--- trunk/Source/WebCore/ChangeLog	2013-05-30 18:19:00 UTC (rev 150971)
+++ trunk/Source/WebCore/ChangeLog	2013-05-30 18:20:32 UTC (rev 150972)
@@ -1,3 +1,25 @@
+2013-05-30  Sergio Villar Senin  
+
+Allow no space between "background-position:" dimensions
+https://bugs.webkit.org/show_bug.cgi?id=116870
+
+Reviewed by Darin Adler.
+
+From Blink r149314 by 
+
+Specs allow no spaces between the dimensions of a
+"background-position:" like "1px+1px", we should support
+that.
+
+Whitespaces are no longer early consumed, dramatically dropping
+the shift/reduce conflicts to half. The productions unary_term,
+calc_func_term, calc_func_expr and calc_func_paren_expr no longer
+consume whitespaces.
+
+* css/CSSGrammar.y.in:
+* css/CSSParser.cpp:
+(WebCore::CSSParser::realLex):
+
 2013-05-30  Jer Noble  
 
 HTMLMediaElement will not unthrottle page when playback stops for nreasons other than user-initiated pause.


Modified: trunk/Source/WebCore/css/CSSGrammar.y.in (150971 => 150972)

--- trunk/Source/WebCore/css/CSSGrammar.y.in	2013-05-30 18:19:00 UTC (rev 150971)
+++ trunk/Source/We

[webkit-changes] [150804] trunk/Source/WebCore

[sergio]

Title: [150804] trunk/Source/WebCore








Revision 150804
Author ser...@webkit.org
Date 2013-05-28 07:37:34 -0700 (Tue, 28 May 2013)


Log Message
Refactoring CSS grammar
https://bugs.webkit.org/show_bug.cgi?id=116679

Reviewed by Andreas Kling.

>From Blink r149948 by 

Added "closing_parenthesis:" and "error_recovery:" to avoid code
duplication in a couple of error recovery rules. Some other rules
were also refactored which allows to reduce the the number of
shift/reduce conflicts by 2.

No new tests required as this is just a refactoring, no new
functionality added.

* css/CSSGrammar.y.in:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSGrammar.y.in




Diff

Modified: trunk/Source/WebCore/ChangeLog (150803 => 150804)

--- trunk/Source/WebCore/ChangeLog	2013-05-28 14:31:11 UTC (rev 150803)
+++ trunk/Source/WebCore/ChangeLog	2013-05-28 14:37:34 UTC (rev 150804)
@@ -1,5 +1,24 @@
 2013-05-28  Sergio Villar Senin  
 
+Refactoring CSS grammar
+https://bugs.webkit.org/show_bug.cgi?id=116679
+
+Reviewed by Andreas Kling.
+
+From Blink r149948 by 
+
+Added "closing_parenthesis:" and "error_recovery:" to avoid code
+duplication in a couple of error recovery rules. Some other rules
+were also refactored which allows to reduce the the number of
+shift/reduce conflicts by 2.
+
+No new tests required as this is just a refactoring, no new
+functionality added.
+
+    * css/CSSGrammar.y.in:
+
+2013-05-28  Sergio Villar Senin  
+
 Invalid block doesn't make declaration invalid
 https://bugs.webkit.org/show_bug.cgi?id=115709
 


Modified: trunk/Source/WebCore/css/CSSGrammar.y.in (150803 => 150804)

--- trunk/Source/WebCore/css/CSSGrammar.y.in	2013-05-28 14:31:11 UTC (rev 150803)
+++ trunk/Source/WebCore/css/CSSGrammar.y.in	2013-05-28 14:37:34 UTC (rev 150804)
@@ -88,9 +88,9 @@
 %}
 
 #if ENABLE_SHADOW_DOM
-%expect 65
+%expect 63
 #else
-%expect 64
+%expect 62
 #endif
 
 %nonassoc LOWEST_PREC
@@ -428,6 +428,11 @@
   | %prec LOWEST_PREC TOKEN_EOF
   ;
 
+closing_parenthesis:
+')'
+  | %prec LOWEST_PREC TOKEN_EOF
+  ;
+
 charset:
   CHARSET_SYM maybe_space STRING maybe_space ';' {
  if (parser->m_styleSheet)
@@ -1561,11 +1566,9 @@
 ;
 
 decl_list_recovery:
-error error_location {
+error error_location error_recovery {
 parser->syntaxError($2, CSSParser::PropertyDeclarationError);
 }
-| decl_list_recovery invalid_block
-| decl_list_recovery error
 ;
 
 declaration:
@@ -1618,11 +1621,9 @@
   ;
 
 declaration_recovery:
-error error_location {
+error error_location error_recovery {
 parser->syntaxError($2);
 }
-| declaration_recovery invalid_block
-| declaration_recovery error
   ;
 
 property:
@@ -1654,17 +1655,15 @@
 $$->addValue(parser->sinkFloatingValue($3));
 }
 }
-| expr invalid_block_list {
+| expr expr_recovery {
 $$ = 0;
 }
-| expr invalid_block_list error {
-$$ = 0;
-}
-| expr error {
-$$ = 0;
-}
   ;
 
+expr_recovery:
+error error_location error_recovery
+  ;
+
 operator:
 '/' maybe_space {
 $$ = '/';
@@ -1754,7 +1753,7 @@
   ;
 
 function:
-FUNCTION maybe_space expr ')' maybe_space {
+FUNCTION maybe_space expr closing_parenthesis maybe_space {
 CSSParserFunction* f = parser->createFloatingFunction();
 f->name = $1;
 f->args = parser->sinkFloatingValueList($3);
@@ -1762,17 +1761,9 @@
 $$.unit = CSSParserValue::Function;
 $$.function = f;
 } |
-FUNCTION maybe_space expr TOKEN_EOF {
+FUNCTION maybe_space closing_parenthesis maybe_space {
 CSSParserFunction* f = parser->createFloatingFunction();
 f->name = $1;
-f->args = parser->sinkFloatingValueList($3);
-$$.id = 0;
-$$.unit = CSSParserValue::Function;
-$$.function = f;
-} |
-FUNCTION maybe_space ')' maybe_space {
-CSSParserFunction* f = parser->createFloatingFunction();
-f->name = $1;
 CSSParserValueList* valueList = parser->createFloatingValueList();
 f->args = parser->sinkFloatingValueList(valueList);
 $$.id = 0;
@@ -1788,7 +1779,7 @@
 $$.function = f;
   }
   ;
- 
+
 calc_func_term:
   unary_term { $$ = $1; }
   | VARFUNCTION maybe_space IDENT ')' maybe_space {
@@ -1980,5 +1971,11 @@
 }
 ;
 
+error_recovery:
+/* empty */
+  | error_recovery invalid_block
+  | error_recovery error
+;
+
 %%
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150803] trunk

[sergio]

Title: [150803] trunk








Revision 150803
Author ser...@webkit.org
Date 2013-05-28 07:31:11 -0700 (Tue, 28 May 2013)


Log Message
Invalid block doesn't make declaration invalid
https://bugs.webkit.org/show_bug.cgi?id=115709

Reviewed by Andreas Kling.

>From Blink r149446 by 

Source/WebCore:

Added a new rule "declaration_recovery:" which covers any kind of
"invalid_block_list maybe_space" sequence. By appending this new
rule to every rule reductable to "declaration:" we can remove some
redundant rules and improve error recovery of some others that
were only accepting exactly one error.

One of the rules being removed was preventing invalid blocks in a
declaration to invalidate the whole declaration. The rule was
reporting the syntax error but at the same time accepting the
invalid block as part of a valid declaration.

* css/CSSGrammar.y.in:

LayoutTests:

* fast/css/parsing-error-recovery.html: Added 2 new test cases.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/fast/css/parsing-error-recovery.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSGrammar.y.in




Diff

Modified: trunk/LayoutTests/ChangeLog (150802 => 150803)

--- trunk/LayoutTests/ChangeLog	2013-05-28 14:08:55 UTC (rev 150802)
+++ trunk/LayoutTests/ChangeLog	2013-05-28 14:31:11 UTC (rev 150803)
@@ -1,3 +1,14 @@
+2013-05-28  Sergio Villar Senin  
+
+Invalid block doesn't make declaration invalid
+https://bugs.webkit.org/show_bug.cgi?id=115709
+
+Reviewed by Andreas Kling.
+
+From Blink r149446 by 
+
+* fast/css/parsing-error-recovery.html: Added 2 new test cases.
+
 2013-05-28  Ádám Kallai  
 
 [Qt] Unreviewed gardening. Unskip now passing tests.


Modified: trunk/LayoutTests/fast/css/parsing-error-recovery.html (150802 => 150803)

--- trunk/LayoutTests/fast/css/parsing-error-recovery.html	2013-05-28 14:08:55 UTC (rev 150802)
+++ trunk/LayoutTests/fast/css/parsing-error-recovery.html	2013-05-28 14:31:11 UTC (rev 150803)
@@ -48,6 +48,18 @@
 display:none;
 }
 
+#test6 {
+display: none !important;
+display: block !important {invalid_block};
+}
+
+#test7 {
+display: none !important;
+}
+#test7 {
+display: block !important {invalid_block}
+}
+
 /* Successfully parsed */
 #last {
 display:block;
@@ -60,6 +72,8 @@
   FAIL: Test 3
   FAIL: Test 4
   FAIL: Test 5
+  FAIL: Test 6
+  FAIL: Test 7
   PASS
 
 


Modified: trunk/Source/WebCore/ChangeLog (150802 => 150803)

--- trunk/Source/WebCore/ChangeLog	2013-05-28 14:08:55 UTC (rev 150802)
+++ trunk/Source/WebCore/ChangeLog	2013-05-28 14:31:11 UTC (rev 150803)
@@ -1,3 +1,25 @@
+2013-05-28  Sergio Villar Senin  
+
+Invalid block doesn't make declaration invalid
+https://bugs.webkit.org/show_bug.cgi?id=115709
+
+Reviewed by Andreas Kling.
+
+From Blink r149446 by 
+
+Added a new rule "declaration_recovery:" which covers any kind of
+"invalid_block_list maybe_space" sequence. By appending this new
+rule to every rule reductable to "declaration:" we can remove some
+redundant rules and improve error recovery of some others that
+were only accepting exactly one error.
+
+One of the rules being removed was preventing invalid blocks in a
+declaration to invalidate the whole declaration. The rule was
+reporting the syntax error but at the same time accepting the
+invalid block as part of a valid declaration.
+
+* css/CSSGrammar.y.in:
+
 2013-05-28  Andreas Kling  
 
 Move dispatching of focus-related events from Node to Element.


Modified: trunk/Source/WebCore/css/CSSGrammar.y.in (150802 => 150803)

--- trunk/Source/WebCore/css/CSSGrammar.y.in	2013-05-28 14:08:55 UTC (rev 150802)
+++ trunk/Source/WebCore/css/CSSGrammar.y.in	2013-05-28 14:31:11 UTC (rev 150803)
@@ -88,9 +88,9 @@
 %}
 
 #if ENABLE_SHADOW_DOM
-%expect 68
+%expect 65
 #else
-%expect 67
+%expect 64
 #endif
 
 %nonassoc LOWEST_PREC
@@ -336,7 +336,6 @@
 %type  element_name
 %type  attr_name
 
-%type  errors
 %type  error_location
 
 %%
@@ -1545,14 +1544,6 @@
 parser->markPropertyStart();
 $$ = $1;
 }
-| declaration error_location invalid_block_list maybe_space {
-parser->syntaxError($2);
-$$ = false;
-}
-| declaration error_location invalid_block_list ';' maybe_space {
-parser->syntaxError($2);
-$$ = false;
-}
 | decl_list_recovery ';' maybe_space {
 parser->markPropertyStart();
 $$ = false;
@@ -1604,51 +1595,34 @@
 parser->markPropertyEnd($5, isPropertyParsed);
 }
 |
-property errors {
-parser->syntaxError($2);
+property declaration_recovery {
 $$ 

[webkit-changes] [150791] trunk

[sergio]

Title: [150791] trunk








Revision 150791
Author ser...@webkit.org
Date 2013-05-28 00:21:02 -0700 (Tue, 28 May 2013)


Log Message
Web Inspector: Enable CSS logging
https://bugs.webkit.org/show_bug.cgi?id=113401

Reviewed by Benjamin Poulain.

>From Blink r149265 by 

Source/WebCore:

CSS logging was disabled in r147028 to prevent message overflow in
the inspector console. This change restores it by modifying the
CSS grammar in order to reduce as much consecutive errors as
possible in 'declaration_list' and 'decl_list' rules.

This way, for rules like 'x { color: ### }' only the first '#'
will be reported as error (instead of 3 identical errors).

The rule 'declaration' still produces multiple errors, because it
does not eat as much errors as possible. So in order not to create
a complex risky patch we just disable logging in the parser for
that rule.

* css/CSSGrammar.y.in:
* css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseSheet):
(WebCore::CSSParser::syntaxError):
(WebCore::CSSParser::isLoggingErrors):
(WebCore::CSSParser::rewriteSpecifiers):
* css/CSSParser.h:
(CSSParser):

LayoutTests:

Unskipped console-css-warnings.html now that it's working.

* TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSGrammar.y.in
trunk/Source/WebCore/css/CSSParser.cpp
trunk/Source/WebCore/css/CSSParser.h




Diff

Modified: trunk/LayoutTests/ChangeLog (150790 => 150791)

--- trunk/LayoutTests/ChangeLog	2013-05-28 07:18:16 UTC (rev 150790)
+++ trunk/LayoutTests/ChangeLog	2013-05-28 07:21:02 UTC (rev 150791)
@@ -1,3 +1,16 @@
+2013-05-28  Sergio Villar Senin  
+
+Web Inspector: Enable CSS logging
+https://bugs.webkit.org/show_bug.cgi?id=113401
+
+Reviewed by Benjamin Poulain.
+
+From Blink r149265 by 
+
+Unskipped console-css-warnings.html now that it's working.
+
+* TestExpectations:
+
 2013-05-27  Claudio Saavedra  
 
 [CSS] -webkit-var prefix is case-sensitive


Modified: trunk/LayoutTests/TestExpectations (150790 => 150791)

--- trunk/LayoutTests/TestExpectations	2013-05-28 07:18:16 UTC (rev 150790)
+++ trunk/LayoutTests/TestExpectations	2013-05-28 07:21:02 UTC (rev 150791)
@@ -8,9 +8,6 @@
 # pending implementation completion and feature enabling
 webkit.org/b/109570 media/track/regions-webvtt [ Skip ]
 
-# pending CSS grammar refactoring
-webkit.org/b/113401 inspector/console/console-css-warnings.html [ Skip ]
-
 # media/video-seek-after-end.html is flaky
 webkit.org/b/116293 media/video-seek-after-end.html [ Pass Failure ]
 


Modified: trunk/Source/WebCore/ChangeLog (150790 => 150791)

--- trunk/Source/WebCore/ChangeLog	2013-05-28 07:18:16 UTC (rev 150790)
+++ trunk/Source/WebCore/ChangeLog	2013-05-28 07:21:02 UTC (rev 150791)
@@ -1,3 +1,35 @@
+2013-05-28  Sergio Villar Senin  
+
+Web Inspector: Enable CSS logging
+https://bugs.webkit.org/show_bug.cgi?id=113401
+
+Reviewed by Benjamin Poulain.
+
+From Blink r149265 by 
+
+CSS logging was disabled in r147028 to prevent message overflow in
+the inspector console. This change restores it by modifying the
+CSS grammar in order to reduce as much consecutive errors as
+possible in 'declaration_list' and 'decl_list' rules.
+
+This way, for rules like 'x { color: ### }' only the first '#'
+will be reported as error (instead of 3 identical errors).
+
+The rule 'declaration' still produces multiple errors, because it
+does not eat as much errors as possible. So in order not to create
+a complex risky patch we just disable logging in the parser for
+that rule.
+
+* css/CSSGrammar.y.in:
+* css/CSSParser.cpp:
+(WebCore::CSSParser::CSSParser):
+(WebCore::CSSParser::parseSheet):
+(WebCore::CSSParser::syntaxError):
+(WebCore::CSSParser::isLoggingErrors):
+(WebCore::CSSParser::rewriteSpecifiers):
+* css/CSSParser.h:
+(CSSParser):
+
 2013-05-27  Patrick Gansterer  
 
 Build fix for WinCE after r150730.


Modified: trunk/Source/WebCore/css/CSSGrammar.y.in (150790 => 150791)

--- trunk/Source/WebCore/css/CSSGrammar.y.in	2013-05-28 07:18:16 UTC (rev 150790)
+++ trunk/Source/WebCore/css/CSSGrammar.y.in	2013-05-28 07:21:02 UTC (rev 150791)
@@ -1532,12 +1532,10 @@
 | decl_list {
 $$ = $1;
 }
-| errors decl_list_recovery {
-parser->syntaxError($1, CSSParser::PropertyDeclarationError);
+| decl_list_recovery {
 $$ = false;
 }
-| decl_list errors decl_list_recovery {
-parser->syntaxError($2, CSSParser::PropertyDeclarationError);
+| decl_list decl_list_recovery {
 $$ = $1;
 }
 ;
@@ -1555,8 +1553,7 @@
 p

[webkit-changes] [150682] trunk/Source/WebCore

[sergio]

Title: [150682] trunk/Source/WebCore








Revision 150682
Author ser...@webkit.org
Date 2013-05-25 01:29:42 -0700 (Sat, 25 May 2013)


Log Message
Reducing CSS code duplication in declaration list error recovery
https://bugs.webkit.org/show_bug.cgi?id=115157

Reviewed by Andreas Kling.

>From Blink r148974 by 

Refactor "invalid_block_list error | /* empty */" in a new
decl_list_recovery rule that allows to remove 4 redundant rules.

No new test required as we're just refactoring code, no new behaviour.

* css/CSSGrammar.y.in:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSGrammar.y.in




Diff

Modified: trunk/Source/WebCore/ChangeLog (150681 => 150682)

--- trunk/Source/WebCore/ChangeLog	2013-05-25 04:20:37 UTC (rev 150681)
+++ trunk/Source/WebCore/ChangeLog	2013-05-25 08:29:42 UTC (rev 150682)
@@ -1,3 +1,19 @@
+2013-05-25  Sergio Villar Senin  
+
+Reducing CSS code duplication in declaration list error recovery
+https://bugs.webkit.org/show_bug.cgi?id=115157
+
+Reviewed by Andreas Kling.
+
+From Blink r148974 by 
+
+Refactor "invalid_block_list error | /* empty */" in a new
+decl_list_recovery rule that allows to remove 4 redundant rules.
+
+No new test required as we're just refactoring code, no new behaviour.
+
+* css/CSSGrammar.y.in:
+
 2013-05-24  Ryosuke Niwa  
 
 Build fix after r150664.


Modified: trunk/Source/WebCore/css/CSSGrammar.y.in (150681 => 150682)

--- trunk/Source/WebCore/css/CSSGrammar.y.in	2013-05-25 04:20:37 UTC (rev 150681)
+++ trunk/Source/WebCore/css/CSSGrammar.y.in	2013-05-25 08:29:42 UTC (rev 150682)
@@ -1532,22 +1532,14 @@
 | decl_list {
 $$ = $1;
 }
-| errors invalid_block_list error {
+| errors decl_list_recovery {
 parser->syntaxError($1, CSSParser::PropertyDeclarationError);
 $$ = false;
 }
-| errors {
-parser->syntaxError($1, CSSParser::PropertyDeclarationError);
-$$ = false;
-}
-| decl_list errors {
+| decl_list errors decl_list_recovery {
 parser->syntaxError($2, CSSParser::PropertyDeclarationError);
 $$ = $1;
 }
-| decl_list errors invalid_block_list error {
-parser->syntaxError($2, CSSParser::PropertyDeclarationError);
-$$ = $1;
-}
 ;
 
 decl_list:
@@ -1563,33 +1555,29 @@
 parser->syntaxError($2);
 $$ = false;
 }
-| errors ';' maybe_space {
+| errors decl_list_recovery ';' maybe_space {
 parser->syntaxError($1, CSSParser::PropertyDeclarationError);
 parser->markPropertyStart();
 $$ = false;
 }
-| errors invalid_block_list error ';' maybe_space {
-parser->syntaxError($1, CSSParser::PropertyDeclarationError);
-$$ = false;
-}
 | decl_list declaration ';' maybe_space {
 parser->markPropertyStart();
 $$ = $1;
 if ($2)
 $$ = $2;
 }
-| decl_list errors ';' maybe_space {
+| decl_list errors decl_list_recovery ';' maybe_space {
 parser->syntaxError($2, CSSParser::PropertyDeclarationError);
 parser->markPropertyStart();
 $$ = $1;
 }
-| decl_list errors invalid_block_list error ';' maybe_space {
-parser->syntaxError($2, CSSParser::PropertyDeclarationError);
-parser->markPropertyStart();
-$$ = $1;
-}
 ;
 
+decl_list_recovery:
+invalid_block_list error
+| /* empty */
+;
+
 declaration:
 VAR_DEFINITION maybe_space ':' maybe_space expr prio {
 #if ENABLE_CSS_VARIABLES






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150655] trunk/LayoutTests

[sergio]

Title: [150655] trunk/LayoutTests








Revision 150655
Author ser...@webkit.org
Date 2013-05-24 13:07:02 -0700 (Fri, 24 May 2013)


Log Message
REGRESSION (r150215): broke a test case in inspector/console/console-css-warnings.html
https://bugs.webkit.org/show_bug.cgi?id=116731

Reviewed by Ryosuke Niwa.

The mentioned revision removed a layering violation added just to
support some IE7 hack. That was removed but the test case
supporting it was left untouched, remove it.

* inspector/console/console-css-warnings-expected.txt:
* inspector/console/console-css-warnings.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/inspector/console/console-css-warnings-expected.txt
trunk/LayoutTests/inspector/console/console-css-warnings.html




Diff

Modified: trunk/LayoutTests/ChangeLog (150654 => 150655)

--- trunk/LayoutTests/ChangeLog	2013-05-24 19:43:41 UTC (rev 150654)
+++ trunk/LayoutTests/ChangeLog	2013-05-24 20:07:02 UTC (rev 150655)
@@ -1,3 +1,17 @@
+2013-05-24  Sergio Villar Senin  
+
+REGRESSION (r150215): broke a test case in inspector/console/console-css-warnings.html
+https://bugs.webkit.org/show_bug.cgi?id=116731
+
+Reviewed by Ryosuke Niwa.
+
+The mentioned revision removed a layering violation added just to
+support some IE7 hack. That was removed but the test case
+supporting it was left untouched, remove it.
+
+* inspector/console/console-css-warnings-expected.txt:
+* inspector/console/console-css-warnings.html:
+
 2013-05-24  Grzegorz Czajkowski  
 
 [WK2] Spelling tests gardening


Modified: trunk/LayoutTests/inspector/console/console-css-warnings-expected.txt (150654 => 150655)

--- trunk/LayoutTests/inspector/console/console-css-warnings-expected.txt	2013-05-24 19:43:41 UTC (rev 150654)
+++ trunk/LayoutTests/inspector/console/console-css-warnings-expected.txt	2013-05-24 20:07:02 UTC (rev 150655)
@@ -10,6 +10,5 @@
 Unexpected CSS token: { console-css-warnings.html:38
 Unexpected CSS token: { console-css-warnings.html:39
 Unexpected CSS token: { console-css-warnings.html:40
-Unexpected CSS token: @ console-css-warnings.html:45
-Unexpected CSS token: @ console-css-warnings.html:49
+Unexpected CSS token: @ console-css-warnings.html:44
 


Modified: trunk/LayoutTests/inspector/console/console-css-warnings.html (150654 => 150655)

--- trunk/LayoutTests/inspector/console/console-css-warnings.html	2013-05-24 19:43:41 UTC (rev 150654)
+++ trunk/LayoutTests/inspector/console/console-css-warnings.html	2013-05-24 20:07:02 UTC (rev 150655)
@@ -41,11 +41,6 @@
 }
 
 x {
-*zoom: @1;  /* IE hack. Ignored */
-color: @;
-}
-
-x {
 color: @;  /* Test simple error to ensure parsing recovered. */
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [150184] trunk/LayoutTests

[sergio]

Title: [150184] trunk/LayoutTests








Revision 150184
Author ser...@webkit.org
Date 2013-05-16 10:06:58 -0700 (Thu, 16 May 2013)


Log Message
Enable the CSSVariables setting in css-variable-definition.html test
https://bugs.webkit.org/show_bug.cgi?id=116231

Reviewed by Andreas Kling.

CSSVariablesEnabled setting must be set to true to allow
CSSVariables at runtime.

Modified also the indent size to 4 spaces.

* css3/css-variable-definition-expected.html:
* css3/css-variable-definition.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/css3/css-variable-definition-expected.html
trunk/LayoutTests/css3/css-variable-definition.html




Diff

Modified: trunk/LayoutTests/ChangeLog (150183 => 150184)

--- trunk/LayoutTests/ChangeLog	2013-05-16 15:44:09 UTC (rev 150183)
+++ trunk/LayoutTests/ChangeLog	2013-05-16 17:06:58 UTC (rev 150184)
@@ -1,3 +1,18 @@
+2013-05-16  Sergio Villar Senin  
+
+Enable the CSSVariables setting in css-variable-definition.html test
+https://bugs.webkit.org/show_bug.cgi?id=116231
+
+Reviewed by Andreas Kling.
+
+CSSVariablesEnabled setting must be set to true to allow
+CSSVariables at runtime.
+
+Modified also the indent size to 4 spaces.
+
+* css3/css-variable-definition-expected.html:
+* css3/css-variable-definition.html:
+
 2013-05-15  Andy Estes  
 
 Resources from non-HTTP schemes should not be cached indefinitely


Modified: trunk/LayoutTests/css3/css-variable-definition-expected.html (150183 => 150184)

--- trunk/LayoutTests/css3/css-variable-definition-expected.html	2013-05-16 15:44:09 UTC (rev 150183)
+++ trunk/LayoutTests/css3/css-variable-definition-expected.html	2013-05-16 17:06:58 UTC (rev 150184)
@@ -1,14 +1,17 @@
 
+
+internals.settings.setCSSVariablesEnabled(true);
+
 
</span><del>-  :root {
-  -webkit-var-mycolor: red;
-  }
-  div {
-  color: -webkit-var(mycolor);
-  }
</del><ins>+:root {
+-webkit-var-mycolor: red;
+}
+div {
+color: -webkit-var(mycolor);
+}
</ins><span class="cx"> 
 
-  Check that a CSS variable definition accepts spaces before the ':'
-  This text should be red
+Check that a CSS variable definition accepts spaces before the ':'
+This text should be red
 
 


Modified: trunk/LayoutTests/css3/css-variable-definition.html (150183 => 150184)

--- trunk/LayoutTests/css3/css-variable-definition.html	2013-05-16 15:44:09 UTC (rev 150183)
+++ trunk/LayoutTests/css3/css-variable-definition.html	2013-05-16 17:06:58 UTC (rev 150184)
@@ -1,14 +1,17 @@
 
+
+internals.settings.setCSSVariablesEnabled(true);
+
 
</span><del>-  :root {
-  -webkit-var-mycolor : red;
-  }
-  div {
-  color: -webkit-var(mycolor);
-  }
</del><ins>+:root {
+-webkit-var-mycolor : red;
+}
+div {
+color: -webkit-var(mycolor);
+}
</ins><span class="cx"> 
 
-  Check that a CSS variable definition accepts spaces before the ':'
-  This text should be red
+Check that a CSS variable definition accepts spaces before the ':'
+This text should be red
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [149740] trunk

[sergio]

Title: [149740] trunk








Revision 149740
Author ser...@webkit.org
Date 2013-05-08 08:19:15 -0700 (Wed, 08 May 2013)


Log Message
Allow blank spaces before colon (:) on CSS variable definition
https://bugs.webkit.org/show_bug.cgi?id=115802

Reviewed by Darin Adler.

Source/WebCore:

Test: css3/css-variable-definition.html

Modified the grammar to allow blank spaces before the colon on CSS
variable definitions.

* css/CSSGrammar.y.in:

LayoutTests:

New test to check that spaces are allowed before the color on CSS
variable definitions.

* css3/css-variable-definition-expected.html: Added.
* css3/css-variable-definition.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/css/CSSGrammar.y.in


Added Paths

trunk/LayoutTests/css3/css-variable-definition-expected.html
trunk/LayoutTests/css3/css-variable-definition.html




Diff

Modified: trunk/LayoutTests/ChangeLog (149739 => 149740)

--- trunk/LayoutTests/ChangeLog	2013-05-08 15:08:55 UTC (rev 149739)
+++ trunk/LayoutTests/ChangeLog	2013-05-08 15:19:15 UTC (rev 149740)
@@ -1,3 +1,16 @@
+2013-05-08  Sergio Villar Senin  
+
+Allow blank spaces before colon (:) on CSS variable definition
+https://bugs.webkit.org/show_bug.cgi?id=115802
+
+Reviewed by Darin Adler.
+
+New test to check that spaces are allowed before the color on CSS
+variable definitions.
+
+* css3/css-variable-definition-expected.html: Added.
+* css3/css-variable-definition.html: Added.
+
 2013-05-08  Zoltan Arvai  
 
 [Qt] Unreviewed gardening after r149292.


Added: trunk/LayoutTests/css3/css-variable-definition-expected.html (0 => 149740)

--- trunk/LayoutTests/css3/css-variable-definition-expected.html	(rev 0)
+++ trunk/LayoutTests/css3/css-variable-definition-expected.html	2013-05-08 15:19:15 UTC (rev 149740)
@@ -0,0 +1,14 @@
+
+
+  :root {
+  -webkit-var-mycolor: red;
+  }
+  div {
+  color: -webkit-var(mycolor);
+  }
+
+
+  Check that a CSS variable definition accepts spaces before the ':'
+  This text should be red
+
+


Added: trunk/LayoutTests/css3/css-variable-definition.html (0 => 149740)

--- trunk/LayoutTests/css3/css-variable-definition.html	(rev 0)
+++ trunk/LayoutTests/css3/css-variable-definition.html	2013-05-08 15:19:15 UTC (rev 149740)
@@ -0,0 +1,14 @@
+
+
+  :root {
+  -webkit-var-mycolor : red;
+  }
+  div {
+  color: -webkit-var(mycolor);
+  }
+
+
+  Check that a CSS variable definition accepts spaces before the ':'
+  This text should be red
+
+


Modified: trunk/Source/WebCore/ChangeLog (149739 => 149740)

--- trunk/Source/WebCore/ChangeLog	2013-05-08 15:08:55 UTC (rev 149739)
+++ trunk/Source/WebCore/ChangeLog	2013-05-08 15:19:15 UTC (rev 149740)
@@ -1,3 +1,17 @@
+2013-05-08  Sergio Villar Senin  
+
+Allow blank spaces before colon (:) on CSS variable definition
+https://bugs.webkit.org/show_bug.cgi?id=115802
+
+Reviewed by Darin Adler.
+
+Test: css3/css-variable-definition.html
+
+Modified the grammar to allow blank spaces before the colon on CSS
+variable definitions.
+
+* css/CSSGrammar.y.in:
+
 2013-05-08  Gustavo Noronha Silva  
 
 [GStreamer] Does memory buffering even with preload set to none


Modified: trunk/Source/WebCore/css/CSSGrammar.y.in (149739 => 149740)

--- trunk/Source/WebCore/css/CSSGrammar.y.in	2013-05-08 15:08:55 UTC (rev 149739)
+++ trunk/Source/WebCore/css/CSSGrammar.y.in	2013-05-08 15:19:15 UTC (rev 149740)
@@ -1615,11 +1615,11 @@
 ;
 
 declaration:
-VAR_DEFINITION ':' maybe_space expr prio {
+VAR_DEFINITION maybe_space ':' maybe_space expr prio {
 #if ENABLE_CSS_VARIABLES
-parser->storeVariableDeclaration($1, parser->sinkFloatingValueList($4), $5);
+parser->storeVariableDeclaration($1, parser->sinkFloatingValueList($5), $6);
 $$ = true;
-parser->markPropertyEnd($5, true);
+parser->markPropertyEnd($6, true);
 #else
 $$ = false;
 #endif






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [149432] trunk

[sergio]

Title: [149432] trunk








Revision 149432
Author ser...@webkit.org
Date 2013-05-01 07:17:12 -0700 (Wed, 01 May 2013)


Log Message
Show a block cursor in overtype mode
https://bugs.webkit.org/show_bug.cgi?id=114819

Reviewed by Ryosuke Niwa.

.:

* Source/autotools/symbols.filter: export some extra symbols for
testing purposes.

Source/WebCore:

Test: editing/selection/block-cursor-overtype-mode.html

Overtype mode will use block cursor instead of a caret to
highlight the next character to be replaced. It will fully cover
the next character to be replaced (except at the end of a line
where the usual blinking caret will be shown).

This new block cursor is internally implemented as a selection
(not exposed to _javascript_) because the selection code knows how
to deal with bidi text.

* WebCore.exp.in: Export symbols for testing purposes.
* WebCore.order: Ditto.
* editing/Editor.cpp:
(WebCore::Editor::toggleOverwriteModeEnabled): Added a call to
FrameLoader::setShouldShowBlockCursor.
(WebCore):
* editing/Editor.h:
(Editor):
* editing/FrameSelection.cpp:
(WebCore::FrameSelection::FrameSelection):
(WebCore::FrameSelection::updateAppearance): Use a 1-character
long selection to paint the cursor in overtype mode.
(WebCore::FrameSelection::setShouldShowBlockCursor):
(WebCore):
* editing/FrameSelection.h:
(WebCore::FrameSelection::shouldShowBlockCursor):
(FrameSelection):
* testing/Internals.cpp:
(WebCore):
(WebCore::Internals::selectionBounds): Added a new method which
returns the IntRect issued by FrameSelection::bounds().
* testing/Internals.h: Ditto.
* testing/Internals.idl: Ditto.

Source/WebKit:

Export three more WebCore symbols.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

Export three more WebCore symbols.

* WebKit.vcproj/WebKitExports.def.in:

LayoutTests:

New test case for the new block cursor to be used in overtype
mode. The test verifies that the 1-pixel long caret is replaced by
a selection like 1-character long block cursor when in overtype
mode. This test covers LTR and RTL text in LTR and RTL blocks and
bidi text.

* editing/selection/block-cursor-overtype-mode-expected.txt: Added.
* editing/selection/block-cursor-overtype-mode.html: Added.

Modified Paths

trunk/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/WebCore.exp.in
trunk/Source/WebCore/WebCore.order
trunk/Source/WebCore/editing/Editor.cpp
trunk/Source/WebCore/editing/Editor.h
trunk/Source/WebCore/editing/FrameSelection.cpp
trunk/Source/WebCore/editing/FrameSelection.h
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebKit/ChangeLog
trunk/Source/WebKit/WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in
trunk/Source/WebKit/win/ChangeLog
trunk/Source/WebKit/win/WebKit.vcproj/WebKitExports.def.in
trunk/Source/autotools/symbols.filter


Added Paths

trunk/LayoutTests/editing/selection/block-cursor-overtype-mode-expected.txt
trunk/LayoutTests/editing/selection/block-cursor-overtype-mode.html




Diff

Modified: trunk/ChangeLog (149431 => 149432)

--- trunk/ChangeLog	2013-05-01 11:22:13 UTC (rev 149431)
+++ trunk/ChangeLog	2013-05-01 14:17:12 UTC (rev 149432)
@@ -1,3 +1,13 @@
+2013-05-01  Sergio Villar Senin  
+
+Show a block cursor in overtype mode
+https://bugs.webkit.org/show_bug.cgi?id=114819
+
+Reviewed by Ryosuke Niwa.
+
+* Source/autotools/symbols.filter: export some extra symbols for
+testing purposes.
+
 2013-04-30  Christophe Dumez  
 
 [EFL] Enable scaled cursors


Modified: trunk/LayoutTests/ChangeLog (149431 => 149432)

--- trunk/LayoutTests/ChangeLog	2013-05-01 11:22:13 UTC (rev 149431)
+++ trunk/LayoutTests/ChangeLog	2013-05-01 14:17:12 UTC (rev 149432)
@@ -1,3 +1,19 @@
+2013-05-01  Sergio Villar Senin  
+
+Show a block cursor in overtype mode
+https://bugs.webkit.org/show_bug.cgi?id=114819
+
+Reviewed by Ryosuke Niwa.
+
+New test case for the new block cursor to be used in overtype
+mode. The test verifies that the 1-pixel long caret is replaced by
+a selection like 1-character long block cursor when in overtype
+mode. This test covers LTR and RTL text in LTR and RTL blocks and
+bidi text.
+
+* editing/selection/block-cursor-overtype-mode-expected.txt: Added.
+* editing/selection/block-cursor-overtype-mode.html: Added.
+
 2013-04-30  David Hyatt  
 
  ignores margin-bottom.


Added: trunk/LayoutTests/editing/selection/block-cursor-overtype-mode-expected.txt (0 => 149432)

--- trunk/LayoutTests/editing/selection/block-cursor-overtype-mode-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/selection/block-cursor-overtype-mode-expected.txt	2013-05-01 14:17:12 UTC (rev 149432)
@@ -0,0 +1,156 @@
+This test checks that the cursor covers the next character to be overwritten in over

[webkit-changes] [149431] trunk/Source/WebKit2

[sergio]

Title: [149431] trunk/Source/WebKit2








Revision 149431
Author ser...@webkit.org
Date 2013-05-01 04:22:13 -0700 (Wed, 01 May 2013)


Log Message
Unreviewed GTK build fix after r149417.

* GNUmakefile.list.am: Added PageBanner.[cpp|h] to the list of
sources.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.list.am




Diff

Modified: trunk/Source/WebKit2/ChangeLog (149430 => 149431)

--- trunk/Source/WebKit2/ChangeLog	2013-05-01 10:14:33 UTC (rev 149430)
+++ trunk/Source/WebKit2/ChangeLog	2013-05-01 11:22:13 UTC (rev 149431)
@@ -1,3 +1,10 @@
+2013-05-01  Sergio Villar Senin  
+
+Unreviewed GTK build fix after r149417.
+
+* GNUmakefile.list.am: Added PageBanner.[cpp|h] to the list of
+sources.
+
 2013-05-01  Ryuan Choi  
 
 [EFL] Unreviewed buildfix after r149416 and r149417.


Modified: trunk/Source/WebKit2/GNUmakefile.list.am (149430 => 149431)

--- trunk/Source/WebKit2/GNUmakefile.list.am	2013-05-01 10:14:33 UTC (rev 149430)
+++ trunk/Source/WebKit2/GNUmakefile.list.am	2013-05-01 11:22:13 UTC (rev 149431)
@@ -1209,6 +1209,8 @@
 	Source/WebKit2/WebProcess/WebPage/gtk/WebPrintOperationGtk.h \
 	Source/WebKit2/WebProcess/WebPage/LayerTreeHost.cpp \
 	Source/WebKit2/WebProcess/WebPage/LayerTreeHost.h \
+	Source/WebKit2/WebProcess/WebPage/PageBanner.cpp \
+	Source/WebKit2/WebProcess/WebPage/PageBanner.h \
 	Source/WebKit2/WebProcess/WebPage/PageOverlay.cpp \
 	Source/WebKit2/WebProcess/WebPage/PageOverlay.h \
 	Source/WebKit2/WebProcess/WebPage/WebBackForwardListProxy.cpp \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [147916] trunk/Source/WebCore

[sergio]

Title: [147916] trunk/Source/WebCore








Revision 147916
Author ser...@webkit.org
Date 2013-04-08 09:05:52 -0700 (Mon, 08 Apr 2013)


Log Message
[GTK] Toggle OverWrite mode when pressing the Insert key
https://bugs.webkit.org/show_bug.cgi?id=113384

Reviewed by Martin Robinson.

Perform an OverWrite command as a response to the emission of the
toggle-overwrite signal. Due to the nature of the command it will
only do that when being on a richly editable web content.

* platform/gtk/KeyBindingTranslator.cpp:
(WebCore::toggleOverwriteCallback):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/KeyBindingTranslator.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (147915 => 147916)

--- trunk/Source/WebCore/ChangeLog	2013-04-08 15:30:04 UTC (rev 147915)
+++ trunk/Source/WebCore/ChangeLog	2013-04-08 16:05:52 UTC (rev 147916)
@@ -1,3 +1,17 @@
+2013-04-08  Sergio Villar Senin  
+
+[GTK] Toggle OverWrite mode when pressing the Insert key
+https://bugs.webkit.org/show_bug.cgi?id=113384
+
+Reviewed by Martin Robinson.
+
+Perform an OverWrite command as a response to the emission of the
+toggle-overwrite signal. Due to the nature of the command it will
+only do that when being on a richly editable web content.
+
+* platform/gtk/KeyBindingTranslator.cpp:
+(WebCore::toggleOverwriteCallback):
+
 2013-04-08  Seokju Kwon  
 
 [BlackBerry] Provide more specific error description for SocketStreamError


Modified: trunk/Source/WebCore/platform/gtk/KeyBindingTranslator.cpp (147915 => 147916)

--- trunk/Source/WebCore/platform/gtk/KeyBindingTranslator.cpp	2013-04-08 15:30:04 UTC (rev 147915)
+++ trunk/Source/WebCore/platform/gtk/KeyBindingTranslator.cpp	2013-04-08 16:05:52 UTC (rev 147916)
@@ -57,11 +57,10 @@
 translator->addPendingEditorCommand("Paste");
 }
 
-static void toggleOverwriteCallback(GtkWidget* widget, KeyBindingTranslator*)
+static void toggleOverwriteCallback(GtkWidget* widget, KeyBindingTranslator* translator)
 {
-// We don't support toggling the overwrite mode, but the default callback expects
-// the GtkTextView to have a layout, so we handle this signal just to stop it.
 g_signal_stop_emission_by_name(widget, "toggle-overwrite");
+translator->addPendingEditorCommand("OverWrite");
 }
 
 // GTK+ will still send these signals to the web view. So we can safely stop signal






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [146999] trunk

[sergio]

Title: [146999] trunk








Revision 146999
Author ser...@webkit.org
Date 2013-03-27 11:26:15 -0700 (Wed, 27 Mar 2013)


Log Message
Inserting a blank (" ") at the end of a line does not insert anything in Overtype mode
https://bugs.webkit.org/show_bug.cgi?id=113413

Reviewed by Ryosuke Niwa.

Source/WebCore:

Perform a "normal" insert instead of a replace when there is
nothing to replace (like at the end of a line) as this case is not
supported by the replacing code path. This will allow us to
properly rebalance whitespaces in those cases.

Updated the editing/execCommand/overtype.html test to check also
this use case.

* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::setEndingSelectionWithoutValidation):
(WebCore::InsertTextCommand::performTrivialReplace):
(WebCore::InsertTextCommand::performOverwrite):
(WebCore::InsertTextCommand::doApply): use the recently added
setEndingSelectionWithoutValidation() to avoid code duplication.
* editing/InsertTextCommand.h:
(InsertTextCommand):

LayoutTests:

Updated the test to include the case of inserting a whitespace
both in the middle or at the end of a line.

* editing/execCommand/overtype-expected.txt:
* editing/execCommand/overtype.html:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/execCommand/overtype-expected.txt
trunk/LayoutTests/editing/execCommand/overtype.html
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/InsertTextCommand.cpp
trunk/Source/WebCore/editing/InsertTextCommand.h




Diff

Modified: trunk/LayoutTests/ChangeLog (146998 => 146999)

--- trunk/LayoutTests/ChangeLog	2013-03-27 18:17:18 UTC (rev 146998)
+++ trunk/LayoutTests/ChangeLog	2013-03-27 18:26:15 UTC (rev 146999)
@@ -1,3 +1,16 @@
+2013-03-27  Sergio Villar Senin  
+
+Inserting a blank (" ") at the end of a line does not insert anything in Overtype mode
+https://bugs.webkit.org/show_bug.cgi?id=113413
+
+Reviewed by Ryosuke Niwa.
+
+Updated the test to include the case of inserting a whitespace
+both in the middle or at the end of a line.
+
+* editing/execCommand/overtype-expected.txt:
+* editing/execCommand/overtype.html:
+
 2013-03-27  Zan Dobersek  
 
 Unreviewed GTK gardening.


Modified: trunk/LayoutTests/editing/execCommand/overtype-expected.txt (146998 => 146999)

--- trunk/LayoutTests/editing/execCommand/overtype-expected.txt	2013-03-27 18:17:18 UTC (rev 146998)
+++ trunk/LayoutTests/editing/execCommand/overtype-expected.txt	2013-03-27 18:26:15 UTC (rev 146999)
@@ -13,11 +13,11 @@
 | "
 "
 
-After overwritting the first two characters:
+After overwritting the first character:
 | "
 "
 | 
-|   "FO<#selection-caret>o"
+|   "F<#selection-caret>oo"
 | 
 |   href=""
 |   
@@ -30,7 +30,7 @@
 | "
 "
 | 
-|   "FO<#selection-caret> "
+|   "F <#selection-caret>o"
 | 
 |   href=""
 |   
@@ -39,11 +39,24 @@
 | "
 "
 
+After inserting a blank at the line end:
+| "
+"
+| 
+|   "F o <#selection-caret>"
+| 
+|   href=""
+|   
+| id="linkText"
+| "bar"
+| "
+"
+
 Overwrite at the end of a line performs as a normal Insert:
 | "
 "
 | 
-|   "FOO SOME MORE<#selection-caret>"
+|   "F o SOME MORE<#selection-caret>"
 | 
 |   href=""
 |   
@@ -56,7 +69,7 @@
 | "
 "
 | 
-|   "FOO SOME MORE"
+|   "F o SOME MORE"
 | 
 |   href=""
 |   
@@ -69,7 +82,7 @@
 | "
 "
 | 
-|   "FOO SOME MORE"
+|   "F o SOME MORE"
 | 
 |   id="linkText"
 |   


Modified: trunk/LayoutTests/editing/execCommand/overtype.html (146998 => 146999)

--- trunk/LayoutTests/editing/execCommand/overtype.html	2013-03-27 18:17:18 UTC (rev 146998)
+++ trunk/LayoutTests/editing/execCommand/overtype.html	2013-03-27 18:26:15 UTC (rev 146999)
@@ -29,13 +29,17 @@
 selection.collapse(element, 0);
 internals.toggleOverwriteModeEnabled(document);
 
-document.execCommand("InsertText", false, 'FO');
-Markup.dump(element, 'After overwritting the first two characters');
+document.execCommand("InsertText", false, 'F');
+Markup.dump(element, 'After overwritting the first character');
 
 document.execCommand("InsertText", false, ' ');
 Markup.dump(element, 'After inserting a blank');
 
-document.execCommand("InsertText", false, 'O SOME MORE');
+moveSelectionForwardByCharacterCommand();
+document.execCommand("InsertText", false, ' ');
+Markup.dump(element, 'After inserting a blank at the line end');
+
+document.execCommand("InsertText", false, 'SOME MORE');
 M

[webkit-changes] [146907] trunk

[sergio]

Title: [146907] trunk








Revision 146907
Author ser...@webkit.org
Date 2013-03-26 10:58:11 -0700 (Tue, 26 Mar 2013)


Log Message
Implement overtype mode for editable content
https://bugs.webkit.org/show_bug.cgi?id=112126

Reviewed by Ryosuke Niwa.

Source/WebCore:

Tests: editing/execCommand/overtype-support.html
   editing/execCommand/overtype.html

Add a new Overwrite command to the editor. This command will
perform overtype operations when enabled instead of "normal" text
insertions. As IE does, we maintain a single toggle state in the
editor (enabled/disabled) for all the editable content in the
page.

This new command will be only available for richly editable
content via keybindings or the context menu. For testing purposes
it is also accessible via internals.

* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::replaceTextInNode): Use RefPtr for
local variables.
* editing/Editor.cpp:
(WebCore::Editor::Editor):
* editing/Editor.h:
(WebCore::Editor::isOverwriteModeEnabled):
(WebCore::Editor::toggleOverwriteModeEnabled):
(Editor): Added two new functions and a new attribute.
* editing/EditorCommand.cpp:
(WebCore::executeToggleOverwrite): Enables/disables overwrite mode.
(WebCore):
(WebCore::createCommandMap): New OverWrite command.
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::setEndingSelectionWithoutValidation):
Refactored from performTrivialReplace(), shared by
performOverwrite().
(WebCore):
(WebCore::InsertTextCommand::performTrivialReplace):
(WebCore::InsertTextCommand::performOverwrite):
(WebCore::InsertTextCommand::doApply): Perform overwrite if enabled.
* editing/InsertTextCommand.h:
(InsertTextCommand):
* testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState): Reset OverWrite mode
to false.
(WebCore::Internals::isOverwriteModeEnabled):
(WebCore):
(WebCore::Internals::toggleOverwriteModeEnabled): Provide access
to overwrite functionality in Editor for testing purposes.
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit/mac:

Added the OverWrite editing command to the WebCore editing
commands lists.

* WebView/WebHTMLView.mm:
* WebView/WebView.h:
* WebView/WebView.mm:

LayoutTests:

Two new layout tests for the new overtype mode. We use
overtype-support.html to check that the Overwrite command is not
exported to _javascript_ but accessible through Internals. The
overtype.html one is used to test the actual behaviour of the
command.

The new command was also added to enabling-and-selection-2.js to
check that it is only available for richly editable content.

* editing/execCommand/enabling-and-selection-2-expected.txt:
Updated expectations for OverWrite command.
* editing/execCommand/overtype-expected.txt: Added.
* editing/execCommand/overtype-support-expected.txt: Added.
* editing/execCommand/overtype-support.html: Added.
* editing/execCommand/overtype.html: Added.
* editing/execCommand/script-tests/enabling-and-selection-2.js:
Added a check for OverWrite command.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/execCommand/enabling-and-selection-2-expected.txt
trunk/LayoutTests/editing/execCommand/script-tests/enabling-and-selection-2.js
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/CompositeEditCommand.cpp
trunk/Source/WebCore/editing/Editor.cpp
trunk/Source/WebCore/editing/Editor.h
trunk/Source/WebCore/editing/EditorCommand.cpp
trunk/Source/WebCore/editing/InsertTextCommand.cpp
trunk/Source/WebCore/editing/InsertTextCommand.h
trunk/Source/WebCore/testing/Internals.cpp
trunk/Source/WebCore/testing/Internals.h
trunk/Source/WebCore/testing/Internals.idl
trunk/Source/WebKit/mac/ChangeLog
trunk/Source/WebKit/mac/WebView/WebHTMLView.mm
trunk/Source/WebKit/mac/WebView/WebView.h
trunk/Source/WebKit/mac/WebView/WebView.mm


Added Paths

trunk/LayoutTests/editing/execCommand/overtype-expected.txt
trunk/LayoutTests/editing/execCommand/overtype-support-expected.txt
trunk/LayoutTests/editing/execCommand/overtype-support.html
trunk/LayoutTests/editing/execCommand/overtype.html




Diff

Modified: trunk/LayoutTests/ChangeLog (146906 => 146907)

--- trunk/LayoutTests/ChangeLog	2013-03-26 17:44:19 UTC (rev 146906)
+++ trunk/LayoutTests/ChangeLog	2013-03-26 17:58:11 UTC (rev 146907)
@@ -1,3 +1,28 @@
+2013-03-26  Sergio Villar Senin  
+
+Implement overtype mode for editable content
+https://bugs.webkit.org/show_bug.cgi?id=112126
+
+Reviewed by Ryosuke Niwa.
+
+Two new layout tests for the new overtype mode. We use
+overtype-support.html to check that the Overwrite command is not
+exported to _javascript_ but accessible through Internals. The
+overtype.html one is used to test the actual behaviour of the
+command.
+
+The new command was also added to enabling-and-selection-2.js to
+check that it is only available for richly editable content.
+
+* editing/execCommand/enabling-and-selection-2

[webkit-changes] [145798] trunk

[sergio]

Title: [145798] trunk








Revision 145798
Author ser...@webkit.org
Date 2013-03-14 02:43:34 -0700 (Thu, 14 Mar 2013)


Log Message
Empty list items after drag&drop in contentEditable divs
https://bugs.webkit.org/show_bug.cgi?id=110610

Reviewed by Ryosuke Niwa.

Source/WebCore:

Perform a cleanup after moving operations. This will mainly prune
extra placeholders left by the editing algorithms. Also do not
leave empty  when moving them around inside a list element.

Tests: editing/pasteboard/cleanup-on-move.html
   editing/pasteboard/drag-list-item.html

* editing/MoveSelectionCommand.cpp:
(WebCore::MoveSelectionCommand::doApply): perform
cleanupAfterDeletion().
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::insertAsListItems): do not
insert an empty list item.
* editing/MoveSelectionCommand.cpp:
(WebCore::MoveSelectionCommand::doApply):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::insertAsListItems):

LayoutTests:

Some placeholders should not be left after performing a cleanup in
move operations, this includes the empty list items generated when
moving around list items inside a list.

I'm also moving drag-list-item.html to editing/pasteboard because
it fits much better there than under editing/selection.

* editing/pasteboard/cleanup-on-move-expected.txt: Added.
* editing/pasteboard/cleanup-on-move.html: Added.
* editing/pasteboard/drag-list-item-expected.txt: Renamed from LayoutTests/editing/selection/drag-list-item-expected.txt.
* editing/pasteboard/drag-list-item.html: Renamed from LayoutTests/editing/selection/drag-list-item.html.
* editing/pasteboard/resources/select-and-drag.js: Added.
(selectAndDragToTarget): Selects nodes and drops them after a target node.
* editing/pasteboard/drag-drop-list-expected.txt: Removed an empty .
* editing/pasteboard/paste-list-004-expected.txt: Removed 2 empty .
* editing/pasteboard/paste-list-004.html: Ditto.
* editing/selection/4895428-1-expected.txt: Removed a .
* editing/selection/4895428-4-expected.txt: Ditto.
* fast/events/ondragenter-expected.txt: Removed a blank line.
* platform/chromium/fast/events/ondragenter-expected.txt: Ditto.
* platform/efl/TestExpectations: Added cleanup-on-move.html to the skipped list.
* platform/mac-wk2/TestExpectations: Ditto.
* platform/qt/TestExpectations: Ditto.
* platform/win/fast/events/ondragenter-expected.txt: Removed a blank line.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/editing/pasteboard/drag-drop-list-expected.txt
trunk/LayoutTests/editing/pasteboard/paste-list-004-expected.txt
trunk/LayoutTests/editing/pasteboard/paste-list-004.html
trunk/LayoutTests/editing/selection/4895428-1-expected.txt
trunk/LayoutTests/editing/selection/4895428-4-expected.txt
trunk/LayoutTests/fast/events/ondragenter-expected.txt
trunk/LayoutTests/platform/chromium/fast/events/ondragenter-expected.txt
trunk/LayoutTests/platform/efl/TestExpectations
trunk/LayoutTests/platform/mac-wk2/TestExpectations
trunk/LayoutTests/platform/qt/TestExpectations
trunk/LayoutTests/platform/win/fast/events/ondragenter-expected.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/MoveSelectionCommand.cpp
trunk/Source/WebCore/editing/ReplaceSelectionCommand.cpp


Added Paths

trunk/LayoutTests/editing/pasteboard/cleanup-on-move-expected.txt
trunk/LayoutTests/editing/pasteboard/cleanup-on-move.html
trunk/LayoutTests/editing/pasteboard/drag-list-item-expected.txt
trunk/LayoutTests/editing/pasteboard/drag-list-item.html
trunk/LayoutTests/editing/pasteboard/resources/select-and-drag.js


Removed Paths

trunk/LayoutTests/editing/selection/drag-list-item-expected.txt
trunk/LayoutTests/editing/selection/drag-list-item.html




Diff

Modified: trunk/LayoutTests/ChangeLog (145797 => 145798)

--- trunk/LayoutTests/ChangeLog	2013-03-14 09:25:01 UTC (rev 145797)
+++ trunk/LayoutTests/ChangeLog	2013-03-14 09:43:34 UTC (rev 145798)
@@ -1,3 +1,35 @@
+2013-03-14  Sergio Villar Senin  
+
+Empty list items after drag&drop in contentEditable divs
+https://bugs.webkit.org/show_bug.cgi?id=110610
+
+Reviewed by Ryosuke Niwa.
+
+Some placeholders should not be left after performing a cleanup in
+move operations, this includes the empty list items generated when
+moving around list items inside a list.
+
+I'm also moving drag-list-item.html to editing/pasteboard because
+it fits much better there than under editing/selection.
+
+* editing/pasteboard/cleanup-on-move-expected.txt: Added.
+* editing/pasteboard/cleanup-on-move.html: Added.
+* editing/pasteboard/drag-list-item-expected.txt: Renamed from LayoutTests/editing/selection/drag-list-item-expected.txt.
+* editing/pasteboard/drag-list-item.html: Renamed from LayoutTests/editing/selection/drag-list-item.html.
+* editing/pasteboard/resources/select-and-drag.js: Added.
+(selectAndDragToTarget): Selects nodes a

[webkit-changes] [145195] trunk

[sergio]

Title: [145195] trunk








Revision 145195
Author ser...@webkit.org
Date 2013-03-08 01:58:28 -0800 (Fri, 08 Mar 2013)


Log Message
Improve drag&drop of list items in contentEditable divs
https://bugs.webkit.org/show_bug.cgi?id=111556

Reviewed by Ryosuke Niwa.

Source/WebCore:

A single fully selected  should generate the same markup as if
we were selecting some of them, i.e., we should preserve the list
structure and appearance.

Test: editing/selection/drag-list-item.html

* editing/htmlediting.cpp:
(WebCore::isListItem): modified constness.
* editing/htmlediting.h:
(WebCore): ditto.
* editing/markup.cpp:
(WebCore::highestAncestorToWrapMarkup):

LayoutTests:

Added a new test case. The test performs 2 drag&drops, first of
all a selection of a single list item, and secondly a selection of
two list items. It checks that both behave the same way, i.e, the
whole  is moved and not only the text.

* editing/selection/drag-list-item-expected.txt: Added.
* editing/selection/drag-list-item.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/editing/htmlediting.cpp
trunk/Source/WebCore/editing/htmlediting.h
trunk/Source/WebCore/editing/markup.cpp


Added Paths

trunk/LayoutTests/editing/selection/drag-list-item-expected.txt
trunk/LayoutTests/editing/selection/drag-list-item.html




Diff

Modified: trunk/LayoutTests/ChangeLog (145194 => 145195)

--- trunk/LayoutTests/ChangeLog	2013-03-08 09:27:38 UTC (rev 145194)
+++ trunk/LayoutTests/ChangeLog	2013-03-08 09:58:28 UTC (rev 145195)
@@ -1,3 +1,18 @@
+2013-03-08  Sergio Villar Senin  
+
+Improve drag&drop of list items in contentEditable divs
+https://bugs.webkit.org/show_bug.cgi?id=111556
+
+Reviewed by Ryosuke Niwa.
+
+Added a new test case. The test performs 2 drag&drops, first of
+all a selection of a single list item, and secondly a selection of
+two list items. It checks that both behave the same way, i.e, the
+whole  is moved and not only the text.
+
+* editing/selection/drag-list-item-expected.txt: Added.
+* editing/selection/drag-list-item.html: Added.
+
 2013-03-08  Zoltan Arvai  
 
 [Qt] Unreviewed gardening.


Added: trunk/LayoutTests/editing/selection/drag-list-item-expected.txt (0 => 145195)

--- trunk/LayoutTests/editing/selection/drag-list-item-expected.txt	(rev 0)
+++ trunk/LayoutTests/editing/selection/drag-list-item-expected.txt	2013-03-08 09:58:28 UTC (rev 145195)
@@ -0,0 +1,71 @@
+This test drags a selection of one  and drops them after another  in the first list. The same test is repeated in the second list but this time with two selected items instead of one. It verifies that the behavior is independent of how many fully selected items we move, i.e. fully selected  are moved as  and not just as plain text
+
+The original list looks like this. 'two' is going to be selected and pasted after 'four':
+| "
+"
+| 
+|   id="one"
+|   "one"
+| 
+|   id="two"
+|   "two"
+| 
+|   id="three"
+|   "three"
+| 
+|   id="four"
+|   "four"
+| "
+"
+
+'two' should appear as a new  after 'four':
+| "
+"
+| 
+|   id="one"
+|   "one"
+| 
+|   id="two"
+|   
+| 
+|   id="three"
+|   "three"
+| 
+|   id="four"
+|   "four"
+| 
+|   id="two"
+|   "two"
+| "
+"
+
+The original list looks like this. 'two' and 'three' are going to be selected and pasted after 'four':
+| 
+|   id="one"
+|   "one"
+| 
+|   id="two"
+|   "two"
+| 
+|   id="three"
+|   "three"
+| 
+|   id="four"
+|   "four"
+
+'two' and 'three' should appear as  after 'four':
+| 
+|   id="one"
+|   "one"
+| 
+|   id="two"
+|   
+| 
+|   id="four"
+|   "four"
+| 
+|   id="two"
+|   "two"
+| 
+|   id="three"
+|   "three"


Added: trunk/LayoutTests/editing/selection/drag-list-item.html (0 => 145195)

--- trunk/LayoutTests/editing/selection/drag-list-item.html	(rev 0)
+++ trunk/LayoutTests/editing/selection/drag-list-item.html	2013-03-08 09:58:28 UTC (rev 145195)
@@ -0,0 +1,54 @@
+
+
+
+
+<ol id="test">
+<li id="one">one</li><li id="two">two</li><li id="three">three</li><li id="four">four</li>
+</ol>
+</div>
+
+<script>
+Markup.description('This test drags a selection of one <li> and drops them after another <li> in the first list. The same test is repeated in the second list but thi

[webkit-changes] [143931] trunk

[sergio]

Title: [143931] trunk








Revision 143931
Author ser...@webkit.org
Date 2013-02-25 08:56:14 -0800 (Mon, 25 Feb 2013)


Log Message
[soup] "Too many redirects" error loading chat in plus.google.com
https://bugs.webkit.org/show_bug.cgi?id=64575

Reviewed by Martin Robinson.

Source/WebCore:

Set the firstPartyForCookies for the new request on redirects to
the URL used for redirection.

Test: http/tests/cookies/set-cookie-on-redirect.html

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::doRedirect):

LayoutTests:

This new test checks firstPartyForCookies is properly set to the
new URL on redirects.

* http/tests/cookies/resources/set-cookie-on-redirect.php: Added.
* http/tests/cookies/set-cookie-on-redirect-expected.txt: Added.
* http/tests/cookies/set-cookie-on-redirect.html: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp


Added Paths

trunk/LayoutTests/http/tests/cookies/resources/set-cookie-on-redirect.php
trunk/LayoutTests/http/tests/cookies/set-cookie-on-redirect-expected.txt
trunk/LayoutTests/http/tests/cookies/set-cookie-on-redirect.html




Diff

Modified: trunk/LayoutTests/ChangeLog (143930 => 143931)

--- trunk/LayoutTests/ChangeLog	2013-02-25 16:52:38 UTC (rev 143930)
+++ trunk/LayoutTests/ChangeLog	2013-02-25 16:56:14 UTC (rev 143931)
@@ -1,3 +1,17 @@
+2013-02-25  Sergio Villar Senin  
+
+[soup] "Too many redirects" error loading chat in plus.google.com
+https://bugs.webkit.org/show_bug.cgi?id=64575
+
+Reviewed by Martin Robinson.
+
+This new test checks firstPartyForCookies is properly set to the
+new URL on redirects.
+
+* http/tests/cookies/resources/set-cookie-on-redirect.php: Added.
+* http/tests/cookies/set-cookie-on-redirect-expected.txt: Added.
+* http/tests/cookies/set-cookie-on-redirect.html: Added.
+
 2013-02-25  Zoltan Arvai  
 
 [Qt] Unreviewed gardening. Skip asserting tests.


Added: trunk/LayoutTests/http/tests/cookies/resources/set-cookie-on-redirect.php (0 => 143931)

--- trunk/LayoutTests/http/tests/cookies/resources/set-cookie-on-redirect.php	(rev 0)
+++ trunk/LayoutTests/http/tests/cookies/resources/set-cookie-on-redirect.php	2013-02-25 16:56:14 UTC (rev 143931)
@@ -0,0 +1,18 @@
+ if (window.testRunner) testRunner.notifyDone();\n";
+}
+?>


Added: trunk/LayoutTests/http/tests/cookies/set-cookie-on-redirect-expected.txt (0 => 143931)

--- trunk/LayoutTests/http/tests/cookies/set-cookie-on-redirect-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/cookies/set-cookie-on-redirect-expected.txt	2013-02-25 16:56:14 UTC (rev 143931)
@@ -0,0 +1 @@
+PASSED: Cookie successfully set


Added: trunk/LayoutTests/http/tests/cookies/set-cookie-on-redirect.html (0 => 143931)

--- trunk/LayoutTests/http/tests/cookies/set-cookie-on-redirect.html	(rev 0)
+++ trunk/LayoutTests/http/tests/cookies/set-cookie-on-redirect.html	2013-02-25 16:56:14 UTC (rev 143931)
@@ -0,0 +1,20 @@
+
+
+
+
+if (window.testRunner) {
+testRunner.dumpAsText();
+testRunner.waitUntilDone();
+}
+
+function doRedirect()
+{
+  window.location = "http://127.0.0.1:8000/cookies/resources/set-cookie-on-redirect.php?step=1";
+}
+
+
+
+
+
+
+


Modified: trunk/Source/WebCore/ChangeLog (143930 => 143931)

--- trunk/Source/WebCore/ChangeLog	2013-02-25 16:52:38 UTC (rev 143930)
+++ trunk/Source/WebCore/ChangeLog	2013-02-25 16:56:14 UTC (rev 143931)
@@ -1,3 +1,18 @@
+2013-02-25  Sergio Villar Senin  
+
+[soup] "Too many redirects" error loading chat in plus.google.com
+https://bugs.webkit.org/show_bug.cgi?id=64575
+
+Reviewed by Martin Robinson.
+
+Set the firstPartyForCookies for the new request on redirects to
+the URL used for redirection.
+
+Test: http/tests/cookies/set-cookie-on-redirect.html
+
+* platform/network/soup/ResourceHandleSoup.cpp:
+(WebCore::doRedirect):
+
 2013-02-25  Andreas Kling  
 
 Reduce amount of code that includes StylePropertySet.h


Modified: trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (143930 => 143931)

--- trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp	2013-02-25 16:52:38 UTC (rev 143930)
+++ trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp	2013-02-25 16:56:14 UTC (rev 143931)
@@ -459,6 +459,7 @@
 KURL newURL = KURL(soupURIToKURL(soup_message_get_uri(message)), location);
 bool crossOrigin = !protocolHostAndPortAreEqual(handle->firstRequest().url(), newURL);
 newRequest.setURL(newURL);
+newRequest.setFirstPartyForCookies(newURL);
 
 if (newRequest.httpMethod() != "GET") {
 // Change newRequest method to GET if change was made during a previous redirection






__

[webkit-changes] [143329] trunk/Source/WebCore

[sergio]

Title: [143329] trunk/Source/WebCore








Revision 143329
Author ser...@webkit.org
Date 2013-02-19 07:16:07 -0800 (Tue, 19 Feb 2013)


Log Message
[Soup] Use synchronous calls to close completely processed streams
https://bugs.webkit.org/show_bug.cgi?id=107432

Reviewed by Martin Robinson.

There is no need to close already processed streams in asynchronous
calls since they won't block. Using the synchronous call will save
us some code and unnecessary asynchronous burden. This is kind of
a code refactor so no new tests needed.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore):
(WebCore::redirectSkipCallback):
(WebCore::readCallback):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (143328 => 143329)

--- trunk/Source/WebCore/ChangeLog	2013-02-19 15:13:42 UTC (rev 143328)
+++ trunk/Source/WebCore/ChangeLog	2013-02-19 15:16:07 UTC (rev 143329)
@@ -1,3 +1,20 @@
+2013-02-19  Sergio Villar Senin  
+
+[Soup] Use synchronous calls to close completely processed streams
+https://bugs.webkit.org/show_bug.cgi?id=107432
+
+Reviewed by Martin Robinson.
+
+There is no need to close already processed streams in asynchronous
+calls since they won't block. Using the synchronous call will save
+us some code and unnecessary asynchronous burden. This is kind of
+a code refactor so no new tests needed.
+
+* platform/network/soup/ResourceHandleSoup.cpp:
+(WebCore):
+(WebCore::redirectSkipCallback):
+(WebCore::readCallback):
+
 2013-02-19  Andrey Adaikin  
 
 Web Inspector: [Canvas] use timeline's didBeginFrame for marking frame end calls


Modified: trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (143328 => 143329)

--- trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp	2013-02-19 15:13:42 UTC (rev 143328)
+++ trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp	2013-02-19 15:16:07 UTC (rev 143329)
@@ -231,7 +231,6 @@
 static void cleanupSoupRequestOperation(ResourceHandle*, bool isDestroying = false);
 static void sendRequestCallback(GObject*, GAsyncResult*, gpointer);
 static void readCallback(GObject*, GAsyncResult*, gpointer);
-static void closeCallback(GObject*, GAsyncResult*, gpointer);
 static gboolean requestTimeoutCallback(void*);
 #if ENABLE(WEB_TIMING)
 static int  milisecondsSinceRequest(double requestTime);
@@ -499,20 +498,6 @@
 handle->sendPendingRequest();
 }
 
-static void redirectCloseCallback(GObject*, GAsyncResult* result, gpointer data)
-{
-RefPtr handle = static_cast(data);
-
-if (handle->cancelledOrClientless()) {
-cleanupSoupRequestOperation(handle.get());
-return;
-}
-
-ResourceHandleInternal* d = handle->getInternal();
-g_input_stream_close_finish(d->m_inputStream.get(), result, 0);
-doRedirect(handle.get());
-}
-
 static void redirectSkipCallback(GObject*, GAsyncResult* asyncResult, gpointer data)
 {
 RefPtr handle = static_cast(data);
@@ -538,7 +523,8 @@
 return;
 }
 
-g_input_stream_close_async(d->m_inputStream.get(), G_PRIORITY_DEFAULT, 0, redirectCloseCallback, handle.get());
+g_input_stream_close(d->m_inputStream.get(), 0, 0);
+doRedirect(handle.get());
 }
 
 static void wroteBodyDataCallback(SoupMessage*, SoupBuffer* buffer, gpointer data)
@@ -1305,19 +1291,6 @@
 syncLoader.run();
 }
 
-static void closeCallback(GObject*, GAsyncResult* res, gpointer data)
-{
-RefPtr handle = static_cast(data);
-ResourceHandleInternal* d = handle->getInternal();
-
-g_input_stream_close_finish(d->m_inputStream.get(), res, 0);
-
-if (handle->client() && loadingSynchronousRequest)
-handle->client()->didFinishLoading(handle.get(), 0);
-
-cleanupSoupRequestOperation(handle.get());
-}
-
 static void readCallback(GObject*, GAsyncResult* asyncResult, gpointer data)
 {
 RefPtr handle = static_cast(data);
@@ -1351,16 +1324,10 @@
 return;
 }
 
-// We inform WebCore of load completion now instead of waiting for the input
-// stream to close because the input stream is closed asynchronously. If this
-// is a synchronous request, we wait until the closeCallback, because we don't
-// want to halt the internal main loop before the input stream closes.
-if (handle->client() && !loadingSynchronousRequest) {
-handle->client()->didFinishLoading(handle.get(), 0);
-handle->setClient(0); // Unset the client so that we do not try to access th
-  // client in the closeCallback.
-}
-g_input_stream_close_async(d->m_inputStream.get(), G_PRIORITY_DEFAULT, 0, closeCallback, handle.get());
+g_input_stream_close(d-

[webkit-changes] [143234] trunk/LayoutTests

[sergio]

Title: [143234] trunk/LayoutTests








Revision 143234
Author ser...@webkit.org
Date 2013-02-18 09:19:56 -0800 (Mon, 18 Feb 2013)


Log Message
Unreviewed GTK gardening.

Moved WK1 specific failures from the shared TestExpectations file
to the wk1 one. Also removed some tests from the WK2
TestExpectations file as they have been consistently passing on
bots.

* platform/gtk-wk1/TestExpectations:
* platform/gtk-wk2/TestExpectations:
* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/LayoutTests/platform/gtk-wk1/TestExpectations
trunk/LayoutTests/platform/gtk-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (143233 => 143234)

--- trunk/LayoutTests/ChangeLog	2013-02-18 17:19:31 UTC (rev 143233)
+++ trunk/LayoutTests/ChangeLog	2013-02-18 17:19:56 UTC (rev 143234)
@@ -1,3 +1,16 @@
+2013-02-18  Sergio Villar Senin  
+
+Unreviewed GTK gardening.
+
+Moved WK1 specific failures from the shared TestExpectations file
+to the wk1 one. Also removed some tests from the WK2
+TestExpectations file as they have been consistently passing on
+bots.
+
+* platform/gtk-wk1/TestExpectations:
+* platform/gtk-wk2/TestExpectations:
+* platform/gtk/TestExpectations:
+
 2013-02-18  Bear Travis  
 
 [CSS Exclusions] Support outside-shape layout for shape-inside property


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (143233 => 143234)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2013-02-18 17:19:31 UTC (rev 143233)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2013-02-18 17:19:56 UTC (rev 143234)
@@ -349,7 +349,6 @@
 webkit.org/b/71849 http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html [ Skip ]
 webkit.org/b/71849 http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html [ Skip ]
 webkit.org/b/71849 inspector/profiler/webgl [ Skip ]
-webkit.org/b/71849 inspector-protocol/layer-tree.html [ Failure ]
 webkit.org/b/71849 transforms/3d [ Skip ]
 webkit.org/b/71849 webgl [ Skip ]
 
@@ -771,11 +770,6 @@
 
 webkit.org/b/102257 fast/dom/Window/open-window-min-size.html [ Timeout ]
 
-webkit.org/b/104648 fast/images/webgl-teximage2d.html [ Timeout ]
-
-# Misses setMediaType() implementation
-Bug(GTK) fast/media/print-restores-previous-mediatype.html [ Timeout ]
-
 # GTK still has the CC toggle button, not the menu of tracks.
 webkit.org/b/101670 media/video-controls-captions-trackmenu.html [ Skip ]
 webkit.org/b/101670 media/video-controls-captions-trackmenu-sorted.html [ Skip ]
@@ -788,9 +782,6 @@
 webkit.org/b/107194 storage/indexeddb/pending-version-change-on-exit.html [ Timeout ]
 webkit.org/b/107194 storage/indexeddb/transaction-complete-workers.html [ Timeout ]
 
-webkit.org/b/107534 fast/js/regress/object-closure-call.html [ Timeout ]
-webkit.org/b/107534 fast/js/regress/cell-argument.html [ Timeout ]
-
 webkit.org/b/108925 http/tests/media/video-play-stall.html [ Timeout Failure ]
 
 #
@@ -863,12 +854,8 @@
 Bug(GTK) fast/loader/policy-delegate-action-hit-test-zoomed.html [ Failure ]
 Bug(GTK) fast/loader/reload-policy-delegate.html [ Failure ]
 Bug(GTK) fast/loader/stop-provisional-loads.html [ Failure ]
-Bug(GTK) fast/loader/subframe-removes-itself.html [ Failure ]
 Bug(GTK) http/tests/security/feed-urls-from-remote.html [ Timeout ]
 
-# This policy delegate is implemented, but it needs the DOM node path in the output.
-Bug(GTK) fast/encoding/mailto-always-utf-8.html [ Failure ]
-
 # Looks like a bug in the LayoutTestController global history support due to missing API.
 Bug(GTK) fast/history/window-open.html [ Failure ]
 
@@ -904,7 +891,6 @@
 webkit.org/b/57127 http/tests/appcache/origin-usage.html [ Failure ]
 
 Bug(GTK) http/tests/loading/bad-scheme-subframe.html [ Failure ]
-Bug(GTK) http/tests/loading/bad-server-subframe.html [ Failure ]
 
 # Needed to cover the fix for 
 Bug(rdar6727495) http/tests/loading/text-content-type-with-binary-extension.html [ Failure ]
@@ -934,9 +920,6 @@
 
 Bug(GTK) media/video-size-intrinsic-scale.html [ Failure ]
 
-# This test is for clients that choose to make the missing plugin indicator a button
-Bug(GTK) plugins/clicking-missing-plugin-fires-delegate.html [ Failure ]
-
 # Need to implement getFormValue().
 Bug(GTK) plugins/form-value.html [ Failure ]
 
@@ -964,9 +947,6 @@
 Bug(GTK) editing/selection/5825350-1.html [ Failure ]
 Bug(GTK) editing/selection/5825350-2.html [ Failure ]
 
-# Requires willSendRequestReturnsNullOnRedirect + willSendRequest + didFinishLoading
-Bug(GTK) http/tests/misc/will-send-request-returns-null-on-redirect.html [ Failure ]
-
 # Needs platform specific API implemented in DRT, maybe not relevant for non-Mac and non-Windows ports
 Bug(GTK) fast/loader/api-test-new-window-data-load-base-url.html [ Failure ]
 Bug(GTK) fast/load

[webkit-changes] [142868] trunk/Source/WebCore

[sergio]

Title: [142868] trunk/Source/WebCore








Revision 142868
Author ser...@webkit.org
Date 2013-02-14 04:35:09 -0800 (Thu, 14 Feb 2013)


Log Message
Add logging support to IndexedDB for non-Chromium platforms
https://bugs.webkit.org/show_bug.cgi?id=109809

Reviewed by Kentaro Hara.

Enable logging of IndexedDB through the StorageAPI log channel for
non-Chromium architectures.

No new tests required, we're just enabling logging for IndexedDB
using the currently available logging framework.

* Modules/indexeddb/IDBTracing.h:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Modules/indexeddb/IDBTracing.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (142867 => 142868)

--- trunk/Source/WebCore/ChangeLog	2013-02-14 12:27:16 UTC (rev 142867)
+++ trunk/Source/WebCore/ChangeLog	2013-02-14 12:35:09 UTC (rev 142868)
@@ -1,3 +1,18 @@
+2013-02-14  Sergio Villar Senin  
+
+Add logging support to IndexedDB for non-Chromium platforms
+https://bugs.webkit.org/show_bug.cgi?id=109809
+
+Reviewed by Kentaro Hara.
+
+Enable logging of IndexedDB through the StorageAPI log channel for
+non-Chromium architectures.
+
+No new tests required, we're just enabling logging for IndexedDB
+using the currently available logging framework.
+
+* Modules/indexeddb/IDBTracing.h:
+
 2013-02-14  Vsevolod Vlasov  
 
 Web Inspector: Remove uriForFile and fileForURI methods from FileSystemMapping.


Modified: trunk/Source/WebCore/Modules/indexeddb/IDBTracing.h (142867 => 142868)

--- trunk/Source/WebCore/Modules/indexeddb/IDBTracing.h	2013-02-14 12:27:16 UTC (rev 142867)
+++ trunk/Source/WebCore/Modules/indexeddb/IDBTracing.h	2013-02-14 12:35:09 UTC (rev 142868)
@@ -38,7 +38,8 @@
 
 #else
 
-#define IDB_TRACE(a) ((void)0)
+#include "Logging.h"
+#define IDB_TRACE(a) LOG(StorageAPI, a)
 
 #endif //  PLATFORM(CHROMIUM)
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [142753] trunk/LayoutTests

[sergio]

Title: [142753] trunk/LayoutTests








Revision 142753
Author ser...@webkit.org
Date 2013-02-13 08:47:11 -0800 (Wed, 13 Feb 2013)


Log Message
Unreviewed GTK gardening.

Provide the same custom expectations as all the other
platforms. This likely means that there is a bug in the code or
that the expected result is incorrect.

* platform/gtk/TestExpectations:
* platform/gtk/editing/pasteboard/5761530-1-expected.txt: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations


Added Paths

trunk/LayoutTests/platform/gtk/editing/pasteboard/5761530-1-expected.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (142752 => 142753)

--- trunk/LayoutTests/ChangeLog	2013-02-13 16:25:05 UTC (rev 142752)
+++ trunk/LayoutTests/ChangeLog	2013-02-13 16:47:11 UTC (rev 142753)
@@ -1,3 +1,14 @@
+2013-02-13  Sergio Villar Senin  
+
+Unreviewed GTK gardening.
+
+Provide the same custom expectations as all the other
+platforms. This likely means that there is a bug in the code or
+that the expected result is incorrect.
+
+* platform/gtk/TestExpectations:
+* platform/gtk/editing/pasteboard/5761530-1-expected.txt: Added.
+
 2013-02-13  Andrew Wilson  
 
 Unreviewed chromium expectation changes resulting from r142719.


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (142752 => 142753)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2013-02-13 16:25:05 UTC (rev 142752)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2013-02-13 16:47:11 UTC (rev 142753)
@@ -1069,9 +1069,6 @@
 Bug(GTK) canvas/philip/tests/2d.text.measure.width.space.html [ Failure ]
 Bug(GTK) canvas/philip/tests/type.prototype.html [ Failure ]
 
-# pastes a space instead of a tab
-webkit.org/b/38437 editing/pasteboard/5761530-1.html [ Failure ]
-
 # Missing DRT API.
 Bug(GTK) http/tests/loading/preload-slow-loading.php [ Failure ]
 


Added: trunk/LayoutTests/platform/gtk/editing/pasteboard/5761530-1-expected.txt (0 => 142753)

--- trunk/LayoutTests/platform/gtk/editing/pasteboard/5761530-1-expected.txt	(rev 0)
+++ trunk/LayoutTests/platform/gtk/editing/pasteboard/5761530-1-expected.txt	2013-02-13 16:47:11 UTC (rev 142753)
@@ -0,0 +1,3 @@
+This tests to see that tabs are put into tab spans when they are copied individually. The pasted tab should be inside of a tab span, not a style span. To run the test manually, paste and then inspect the editable region, and ensure that there is a tab span at the beginning of the editable div.
+
+	 xxx






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [140672] trunk/Source/WebCore

[sergio]

Title: [140672] trunk/Source/WebCore








Revision 140672
Author ser...@webkit.org
Date 2013-01-24 03:47:01 -0800 (Thu, 24 Jan 2013)


Log Message
[GTK] Unreviewed build fix.

Do not include the header file WebKitDOMPerformanceEntryList.h in
the build sources because we do not want the DOM bindings
generator to include it in webkitdomdefes.h twice.

* bindings/gobject/GNUmakefile.am:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/gobject/GNUmakefile.am




Diff

Modified: trunk/Source/WebCore/ChangeLog (140671 => 140672)

--- trunk/Source/WebCore/ChangeLog	2013-01-24 11:25:52 UTC (rev 140671)
+++ trunk/Source/WebCore/ChangeLog	2013-01-24 11:47:01 UTC (rev 140672)
@@ -1,3 +1,13 @@
+2013-01-24  Sergio Villar Senin  
+
+[GTK] Unreviewed build fix.
+
+Do not include the header file WebKitDOMPerformanceEntryList.h in
+the build sources because we do not want the DOM bindings
+generator to include it in webkitdomdefes.h twice.
+
+* bindings/gobject/GNUmakefile.am:
+
 2013-01-24  Julien BRIANCEAU   
 
 Fix Qt build (KO since r140610), typo error for QString::fromUtf16 function.


Modified: trunk/Source/WebCore/bindings/gobject/GNUmakefile.am (140671 => 140672)

--- trunk/Source/WebCore/bindings/gobject/GNUmakefile.am	2013-01-24 11:25:52 UTC (rev 140671)
+++ trunk/Source/WebCore/bindings/gobject/GNUmakefile.am	2013-01-24 11:47:01 UTC (rev 140672)
@@ -232,7 +232,6 @@
 	DerivedSources/webkitdom/WebKitDOMPerformance.cpp \
 	DerivedSources/webkitdom/WebKitDOMPerformanceEntry.cpp \
 	DerivedSources/webkitdom/WebKitDOMPerformanceEntryList.cpp \
-	DerivedSources/webkitdom/WebKitDOMPerformanceEntryList.h \
 	DerivedSources/webkitdom/WebKitDOMPerformanceEntryPrivate.h \
 	DerivedSources/webkitdom/WebKitDOMPerformancePrivate.h \
 	DerivedSources/webkitdom/WebKitDOMPerformanceNavigation.cpp \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [140529] trunk/Source/WebCore

[sergio]

Title: [140529] trunk/Source/WebCore








Revision 140529
Author ser...@webkit.org
Date 2013-01-23 02:22:03 -0800 (Wed, 23 Jan 2013)


Log Message
[GTK] Unreviewed build fix after r140518.

* GNUmakefile.list.am: rename TextureMapperShaderManager to
TextureMapperShaderProgram.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am




Diff

Modified: trunk/Source/WebCore/ChangeLog (140528 => 140529)

--- trunk/Source/WebCore/ChangeLog	2013-01-23 10:06:57 UTC (rev 140528)
+++ trunk/Source/WebCore/ChangeLog	2013-01-23 10:22:03 UTC (rev 140529)
@@ -1,3 +1,10 @@
+2013-01-23  Sergio Villar Senin  
+
+[GTK] Unreviewed build fix after r140518.
+
+* GNUmakefile.list.am: rename TextureMapperShaderManager to
+TextureMapperShaderProgram.
+
 2013-01-23  Yoshifumi Inoue  
 
 REGRESSION(r139044): Pan icon remains on screen on Chromium-WinXP


Modified: trunk/Source/WebCore/GNUmakefile.list.am (140528 => 140529)

--- trunk/Source/WebCore/GNUmakefile.list.am	2013-01-23 10:06:57 UTC (rev 140528)
+++ trunk/Source/WebCore/GNUmakefile.list.am	2013-01-23 10:22:03 UTC (rev 140529)
@@ -6444,8 +6444,8 @@
 	Source/WebCore//platform/graphics/filters/texmap/TextureMapperPlatformCompiledProgram.h \
 	Source/WebCore/platform/graphics/texmap/TextureMapperGL.cpp \
 	Source/WebCore/platform/graphics/texmap/TextureMapperGL.h \
-	Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.cpp \
-	Source/WebCore/platform/graphics/texmap/TextureMapperShaderManager.h \
+	Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp \
+	Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.h \
 	Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp \
 	Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.h \
 	Source/WebCore/platform/graphics/GraphicsLayerTransform.cpp \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [140524] trunk/Source/WebCore

[sergio]

Title: [140524] trunk/Source/WebCore








Revision 140524
Author ser...@webkit.org
Date 2013-01-23 01:21:19 -0800 (Wed, 23 Jan 2013)


Log Message
REGRESSION(r140338): WebKitGtk+ trying to allocate a buffer too big
https://bugs.webkit.org/show_bug.cgi?id=107646

Reviewed by Carlos Garcia Campos.

g_input_stream_skip_async() was replaced in r140338 by
g_input_stream_read_async() to workaround a glib buffer. The former
was using G_MAXSSIZE to skip the whole redirect message but we
cannot use it for the latter because it will try to
allocate a buffer of that size. Replaced it by READ_BUFFER_SIZE. No
new tests required, functionality already covered by network tests..

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::redirectSkipCallback):
(WebCore::sendRequestCallback):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (140523 => 140524)

--- trunk/Source/WebCore/ChangeLog	2013-01-23 09:18:48 UTC (rev 140523)
+++ trunk/Source/WebCore/ChangeLog	2013-01-23 09:21:19 UTC (rev 140524)
@@ -1,3 +1,21 @@
+2013-01-23  Sergio Villar Senin  
+
+REGRESSION(r140338): WebKitGtk+ trying to allocate a buffer too big
+https://bugs.webkit.org/show_bug.cgi?id=107646
+
+Reviewed by Carlos Garcia Campos.
+
+g_input_stream_skip_async() was replaced in r140338 by
+g_input_stream_read_async() to workaround a glib buffer. The former
+was using G_MAXSSIZE to skip the whole redirect message but we
+cannot use it for the latter because it will try to
+allocate a buffer of that size. Replaced it by READ_BUFFER_SIZE. No
+new tests required, functionality already covered by network tests..
+
+* platform/network/soup/ResourceHandleSoup.cpp:
+(WebCore::redirectSkipCallback):
+(WebCore::sendRequestCallback):
+
 2013-01-23  Andrey Adaikin  
 
 Web Inspector: use inspectedWindow.document instead of document in InjectedScript


Modified: trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (140523 => 140524)

--- trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp	2013-01-23 09:18:48 UTC (rev 140523)
+++ trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp	2013-01-23 09:21:19 UTC (rev 140524)
@@ -526,7 +526,7 @@
 }
 
 if (bytesSkipped > 0) {
-g_input_stream_read_async(d->m_inputStream.get(), d->m_buffer, G_MAXSSIZE, G_PRIORITY_DEFAULT,
+g_input_stream_read_async(d->m_inputStream.get(), d->m_buffer, READ_BUFFER_SIZE, G_PRIORITY_DEFAULT,
 d->m_cancellable.get(), redirectSkipCallback, handle.get());
 return;
 }
@@ -681,7 +681,7 @@
 // We use read_async() rather than skip_async() to work around
 // https://bugzilla.gnome.org/show_bug.cgi?id=691489 until we can
 // depend on glib > 2.35.4
-g_input_stream_read_async(d->m_inputStream.get(), d->m_buffer, G_MAXSSIZE, G_PRIORITY_DEFAULT,
+g_input_stream_read_async(d->m_inputStream.get(), d->m_buffer, READ_BUFFER_SIZE, G_PRIORITY_DEFAULT,
 d->m_cancellable.get(), redirectSkipCallback, handle.get());
 return;
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [140445] trunk/Source/WebCore

[sergio]

Title: [140445] trunk/Source/WebCore








Revision 140445
Author ser...@webkit.org
Date 2013-01-22 11:24:58 -0800 (Tue, 22 Jan 2013)


Log Message
[Soup] Random thread crashes
https://bugs.webkit.org/show_bug.cgi?id=107439

Reviewed by Martin Robinson.

Process all pending requests in the inner GMainContext created to
perform synchronous requests before restoring the thread default. No
new tests required, already covered by network tests.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (140444 => 140445)

--- trunk/Source/WebCore/ChangeLog	2013-01-22 19:24:50 UTC (rev 140444)
+++ trunk/Source/WebCore/ChangeLog	2013-01-22 19:24:58 UTC (rev 140445)
@@ -1,3 +1,17 @@
+2013-01-22  Sergio Villar Senin  
+
+[Soup] Random thread crashes
+https://bugs.webkit.org/show_bug.cgi?id=107439
+
+Reviewed by Martin Robinson.
+
+Process all pending requests in the inner GMainContext created to
+perform synchronous requests before restoring the thread default. No
+new tests required, already covered by network tests.
+
+* platform/network/soup/ResourceHandleSoup.cpp:
+(WebCore::WebCoreSynchronousLoader::~WebCoreSynchronousLoader):
+
 2013-01-22  Christophe Dumez  
 
 [gstreamer] GstBus signal watch should be removed on clean up


Modified: trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (140444 => 140445)

--- trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp	2013-01-22 19:24:50 UTC (rev 140444)
+++ trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp	2013-01-22 19:24:58 UTC (rev 140445)
@@ -117,7 +117,12 @@
 ~WebCoreSynchronousLoader()
 {
 adjustMaxConnections(-1);
-g_main_context_pop_thread_default(g_main_context_get_thread_default());
+
+GMainContext* context = g_main_context_get_thread_default();
+while (g_main_context_pending(context))
+g_main_context_iteration(context, FALSE);
+
+g_main_context_pop_thread_default(context);
 loadingSynchronousRequest = false;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [140154] trunk/Source/WebCore

[sergio]

Title: [140154] trunk/Source/WebCore








Revision 140154
Author ser...@webkit.org
Date 2013-01-18 08:28:40 -0800 (Fri, 18 Jan 2013)


Log Message
[Soup] Frequent crashes on redirections
https://bugs.webkit.org/show_bug.cgi?id=107240

Reviewed by Martin Robinson.

We must ensure that the ResourceHandle has not being cancelled
before performing a redirect. This could happen while we close the
stream used to read the redirect response because it is done
asynchronously.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::redirectCloseCallback): also renamed res to result.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (140153 => 140154)

--- trunk/Source/WebCore/ChangeLog	2013-01-18 16:27:12 UTC (rev 140153)
+++ trunk/Source/WebCore/ChangeLog	2013-01-18 16:28:40 UTC (rev 140154)
@@ -1,3 +1,18 @@
+2013-01-18  Sergio Villar Senin  
+
+[Soup] Frequent crashes on redirections
+https://bugs.webkit.org/show_bug.cgi?id=107240
+
+Reviewed by Martin Robinson.
+
+We must ensure that the ResourceHandle has not being cancelled
+before performing a redirect. This could happen while we close the
+stream used to read the redirect response because it is done
+asynchronously.
+
+* platform/network/soup/ResourceHandleSoup.cpp:
+(WebCore::redirectCloseCallback): also renamed res to result.
+
 2013-01-18  Andrey Adaikin  
 
 Web Inspector: array grouping does not work big sparse arrays


Modified: trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (140153 => 140154)

--- trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp	2013-01-18 16:27:12 UTC (rev 140153)
+++ trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp	2013-01-18 16:28:40 UTC (rev 140154)
@@ -486,12 +486,17 @@
 handle->sendPendingRequest();
 }
 
-static void redirectCloseCallback(GObject*, GAsyncResult* res, gpointer data)
+static void redirectCloseCallback(GObject*, GAsyncResult* result, gpointer data)
 {
 RefPtr handle = static_cast(data);
 ResourceHandleInternal* d = handle->getInternal();
 
-g_input_stream_close_finish(d->m_inputStream.get(), res, 0);
+if (d->m_cancelled || !handle->client()) {
+cleanupSoupRequestOperation(handle.get());
+return;
+}
+
+g_input_stream_close_finish(d->m_inputStream.get(), result, 0);
 doRedirect(handle.get());
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139868] trunk/Tools

[sergio]

Title: [139868] trunk/Tools








Revision 139868
Author ser...@webkit.org
Date 2013-01-16 04:00:50 -0800 (Wed, 16 Jan 2013)


Log Message
[GTK] build-webkit fails if the jhbuild wrapper is not used
https://bugs.webkit.org/show_bug.cgi?id=106769

Reviewed by Martin Robinson.

Return an empty array instead of "" in
jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
will not be recognized as a valid command when the returned array
is directly passed to perl's system() call.

* Scripts/webkitdirs.pm:
(jhbuildWrapperPrefixIfNeeded):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitdirs.pm




Diff

Modified: trunk/Tools/ChangeLog (139867 => 139868)

--- trunk/Tools/ChangeLog	2013-01-16 11:51:32 UTC (rev 139867)
+++ trunk/Tools/ChangeLog	2013-01-16 12:00:50 UTC (rev 139868)
@@ -1,3 +1,18 @@
+2013-01-16  Sergio Villar Senin  
+
+[GTK] build-webkit fails if the jhbuild wrapper is not used
+https://bugs.webkit.org/show_bug.cgi?id=106769
+
+Reviewed by Martin Robinson.
+
+Return an empty array instead of "" in
+jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
+will not be recognized as a valid command when the returned array
+is directly passed to perl's system() call.
+
+* Scripts/webkitdirs.pm:
+(jhbuildWrapperPrefixIfNeeded):
+
 2013-01-16  Jochen Eisinger  
 
 [chromium] add title text direction attribute to TestRunner


Modified: trunk/Tools/Scripts/webkitdirs.pm (139867 => 139868)

--- trunk/Tools/Scripts/webkitdirs.pm	2013-01-16 11:51:32 UTC (rev 139867)
+++ trunk/Tools/Scripts/webkitdirs.pm	2013-01-16 12:00:50 UTC (rev 139868)
@@ -2130,7 +2130,7 @@
 return @prefix;
 }
 
-return "";
+return ();
 }
 
 sub removeCMakeCache()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139063] trunk/Source/WebCore

[sergio]

Title: [139063] trunk/Source/WebCore








Revision 139063
Author ser...@webkit.org
Date 2013-01-08 08:47:55 -0800 (Tue, 08 Jan 2013)


Log Message
[Qt] Fix build with --web-audio
https://bugs.webkit.org/show_bug.cgi?id=106328

Reviewed by Philippe Normand.

Build fix, no new tests required.

* Target.pri: addded missing OfflineAudioContext.[cpp|h].

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/Target.pri




Diff

Modified: trunk/Source/WebCore/ChangeLog (139062 => 139063)

--- trunk/Source/WebCore/ChangeLog	2013-01-08 16:45:55 UTC (rev 139062)
+++ trunk/Source/WebCore/ChangeLog	2013-01-08 16:47:55 UTC (rev 139063)
@@ -1,3 +1,14 @@
+2013-01-08  Sergio Villar Senin  
+
+[Qt] Fix build with --web-audio
+https://bugs.webkit.org/show_bug.cgi?id=106328
+
+Reviewed by Philippe Normand.
+
+Build fix, no new tests required.
+
+* Target.pri: addded missing OfflineAudioContext.[cpp|h].
+
 2013-01-08  Martin Robinson  
 
 [GTK] Login & password shown in browsers' URL entry after successful HTTP authentication


Modified: trunk/Source/WebCore/Target.pri (139062 => 139063)

--- trunk/Source/WebCore/Target.pri	2013-01-08 16:45:55 UTC (rev 139062)
+++ trunk/Source/WebCore/Target.pri	2013-01-08 16:47:55 UTC (rev 139063)
@@ -3375,6 +3375,7 @@
 Modules/webaudio/MediaElementAudioSourceNode.h \
 Modules/webaudio/MediaStreamAudioSourceNode.h \
 Modules/webaudio/OfflineAudioCompletionEvent.h \
+Modules/webaudio/OfflineAudioContext.h \
 Modules/webaudio/OfflineAudioDestinationNode.h \
 Modules/webaudio/OscillatorNode.h \
 Modules/webaudio/RealtimeAnalyser.h \
@@ -3466,6 +3467,7 @@
 Modules/webaudio/MediaElementAudioSourceNode.cpp \
 Modules/webaudio/MediaStreamAudioSourceNode.cpp \
 Modules/webaudio/OfflineAudioCompletionEvent.cpp \
+Modules/webaudio/OfflineAudioContext.cpp \
 Modules/webaudio/OfflineAudioDestinationNode.cpp \
 Modules/webaudio/OscillatorNode.cpp \
 Modules/webaudio/RealtimeAnalyser.cpp \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [139046] trunk

[sergio]

Title: [139046] trunk








Revision 139046
Author ser...@webkit.org
Date 2013-01-08 01:31:56 -0800 (Tue, 08 Jan 2013)


Log Message
[GTK] Add WebP image support
https://bugs.webkit.org/show_bug.cgi?id=105915

Reviewed by Martin Robinson.

.:

WebP is from now on a dependency for WebKitGtk+.

* configure.ac: added WebP library detection.

Source/WebCore:

* GNUmakefile.am: add WTF_USE_WEBP definition.
* GNUmakefile.list.am: properly sort image decoders in the sources list.

Source/WebKit/gtk:

* GNUmakefile.am: link against WebP library.

Source/WebKit2:

* GNUmakefile.am: link against WebP library.

LayoutTests:

* platform/gtk/TestExpectations: unskipped two tests passing now
that we have WebP support.

Modified Paths

trunk/ChangeLog
trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.am
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/GNUmakefile.am
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/GNUmakefile.am
trunk/configure.ac




Diff

Modified: trunk/ChangeLog (139045 => 139046)

--- trunk/ChangeLog	2013-01-08 09:27:08 UTC (rev 139045)
+++ trunk/ChangeLog	2013-01-08 09:31:56 UTC (rev 139046)
@@ -1,3 +1,14 @@
+2013-01-03  Sergio Villar Senin  
+
+[GTK] Add WebP image support
+https://bugs.webkit.org/show_bug.cgi?id=105915
+
+Reviewed by Martin Robinson.
+
+WebP is from now on a dependency for WebKitGtk+.
+
+* configure.ac: added WebP library detection.
+
 2013-01-07  Xianzhu Wang  
 
 Add window.internals.nonFastScrollableRects for testing scrollable areas in fast/slow paths


Modified: trunk/LayoutTests/ChangeLog (139045 => 139046)

--- trunk/LayoutTests/ChangeLog	2013-01-08 09:27:08 UTC (rev 139045)
+++ trunk/LayoutTests/ChangeLog	2013-01-08 09:31:56 UTC (rev 139046)
@@ -1,3 +1,13 @@
+2013-01-04  Sergio Villar Senin  
+
+[GTK] Add WebP image support
+https://bugs.webkit.org/show_bug.cgi?id=105915
+
+Reviewed by Martin Robinson.
+
+* platform/gtk/TestExpectations: unskipped two tests passing now
+that we have WebP support.
+
 2013-01-08  Yoshifumi Inoue  
 
 Dragging over an element with scrollbars should scroll the element when dragging near edges


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (139045 => 139046)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2013-01-08 09:27:08 UTC (rev 139045)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2013-01-08 09:31:56 UTC (rev 139046)
@@ -233,9 +233,8 @@
 
 # Requires WebP support.
 webkit.org/b/98939 fast/canvas/canvas-toDataURL-webp.html [ Skip ]
+# Requires WebP 0.2 support.
 webkit.org/b/98939 fast/images/webp-image-decoding.html [ Skip ]
-webkit.org/b/98939 http/tests/images/webp-partial-load.html [ Skip ]
-webkit.org/b/98939 http/tests/images/webp-progressive-load.html [ Skip ]
 
 # DataTransferItems is not yet implemented.
 webkit.org/b/98940 editing/pasteboard/data-transfer-items.html [ Skip ]


Modified: trunk/Source/WebCore/ChangeLog (139045 => 139046)

--- trunk/Source/WebCore/ChangeLog	2013-01-08 09:27:08 UTC (rev 139045)
+++ trunk/Source/WebCore/ChangeLog	2013-01-08 09:31:56 UTC (rev 139046)
@@ -1,3 +1,13 @@
+2013-01-03  Sergio Villar Senin  
+
+[GTK] Add WebP image support
+https://bugs.webkit.org/show_bug.cgi?id=105915
+
+Reviewed by Martin Robinson.
+
+* GNUmakefile.am: add WTF_USE_WEBP definition.
+* GNUmakefile.list.am: properly sort image decoders in the sources list.
+
 2013-01-08  Steve Block  
 
 Rename 'IntSize toSize(const IntPoint&)' to 'toIntSize'


Modified: trunk/Source/WebCore/GNUmakefile.am (139045 => 139046)

--- trunk/Source/WebCore/GNUmakefile.am	2013-01-08 09:27:08 UTC (rev 139045)
+++ trunk/Source/WebCore/GNUmakefile.am	2013-01-08 09:31:56 UTC (rev 139046)
@@ -7,6 +7,7 @@
 webcore_cppflags += \
 	-DWTF_USE_FREETYPE=1 \
 	-DWTF_USE_HARFBUZZ_NG=1 \
+	-DWTF_USE_WEBP=1 \
 	-I$(srcdir)/Source/ThirdParty/ANGLE/src \
 	-I$(srcdir)/Source/ThirdParty/ANGLE/include \
 	-I$(srcdir)/Source/ThirdParty/ANGLE/include/GLSLANG \
@@ -72,8 +73,8 @@
 	-I$(srcdir)/Source/WebCore/platform/image-decoders/gif \
 	-I$(srcdir)/Source/WebCore/platform/image-decoders/ico \
 	-I$(srcdir)/Source/WebCore/platform/image-decoders/jpeg \
+	-I$(srcdir)/Source/WebCore/platform/image-decoders/png \
 	-I$(srcdir)/Source/WebCore/platform/image-decoders/webp \
-	-I$(srcdir)/Source/WebCore/platform/image-decoders/png \
 	-I$(srcdir)/Source/WebCore/platform/leveldb \
 	-I$(srcdir)/Source/WebCore/platform/linux \
 	-I$(srcdir)/Source/WebCore/platform/mediastream \


Modified: trunk/Source/WebCore/GNUmakefile.list.am (139045 => 139046)

--- trunk/Source/WebCore/GNUmakefile.list.am	2013-01-08 09:27:08 UTC (rev 139045)
+++ trunk/Source/WebCore/GNUmakefile.list.am	2013-01-08 09:31:56 UTC (rev 139046)
@@ -5702,10 +

[webkit-changes] [136476] trunk/Source/WebCore

[sergio]

Title: [136476] trunk/Source/WebCore








Revision 136476
Author ser...@webkit.org
Date 2012-12-03 23:35:33 -0800 (Mon, 03 Dec 2012)


Log Message
[GTK] Add WebKitDOMShadowRoot.h to the list of public API headers after r135693
https://bugs.webkit.org/show_bug.cgi?id=103909

Reviewed by Martin Robinson.

WebKitDOMShadowRoot was added in r135693. As it is added to
webkitdom.h we have to export the include file, otherwise clients
will fail to build due to the missing file.

* bindings/gobject/GNUmakefile.am:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/bindings/gobject/GNUmakefile.am




Diff

Modified: trunk/Source/WebCore/ChangeLog (136475 => 136476)

--- trunk/Source/WebCore/ChangeLog	2012-12-04 07:17:04 UTC (rev 136475)
+++ trunk/Source/WebCore/ChangeLog	2012-12-04 07:35:33 UTC (rev 136476)
@@ -1,3 +1,16 @@
+2012-12-03  Sergio Villar Senin  
+
+[GTK] Add WebKitDOMShadowRoot.h to the list of public API headers after r135693
+https://bugs.webkit.org/show_bug.cgi?id=103909
+
+Reviewed by Martin Robinson.
+
+WebKitDOMShadowRoot was added in r135693. As it is added to
+webkitdom.h we have to export the include file, otherwise clients
+will fail to build due to the missing file.
+
+* bindings/gobject/GNUmakefile.am:
+
 2012-12-03  Joshua Bell  
 
 IndexedDB: Correct database version after aborted upgrade


Modified: trunk/Source/WebCore/bindings/gobject/GNUmakefile.am (136475 => 136476)

--- trunk/Source/WebCore/bindings/gobject/GNUmakefile.am	2012-12-04 07:17:04 UTC (rev 136475)
+++ trunk/Source/WebCore/bindings/gobject/GNUmakefile.am	2012-12-04 07:35:33 UTC (rev 136476)
@@ -397,6 +397,7 @@
 	DerivedSources/webkit/WebKitDOMNavigator.h \
 	DerivedSources/webkit/WebKitDOMPropertyNodeList.h \
 	DerivedSources/webkit/WebKitDOMScreen.h \
+	DerivedSources/webkit/WebKitDOMShadowRoot.h \
 	DerivedSources/webkit/WebKitDOMWebKitAnimation.h \
 	DerivedSources/webkit/WebKitDOMWebKitAnimationList.h \
 	DerivedSources/webkit/WebKitDOMWebKitPoint.h \






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [136083] trunk/Source/WebKit2

[sergio]

Title: [136083] trunk/Source/WebKit2








Revision 136083
Author ser...@webkit.org
Date 2012-11-28 18:24:31 -0800 (Wed, 28 Nov 2012)


Log Message
[WK2][Qt] Add drag&drop support to Flickable webView
https://bugs.webkit.org/show_bug.cgi?id=100778

Reviewed by Jocelyn Turcotte.

Enable the ItemAcceptsDrops flag in the flickable WebView. This
will allow the WebView to receive drag&drop events.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (136082 => 136083)

--- trunk/Source/WebKit2/ChangeLog	2012-11-29 02:21:57 UTC (rev 136082)
+++ trunk/Source/WebKit2/ChangeLog	2012-11-29 02:24:31 UTC (rev 136083)
@@ -1,3 +1,16 @@
+2012-11-28  Sergio Villar Senin  
+
+[WK2][Qt] Add drag&drop support to Flickable webView
+https://bugs.webkit.org/show_bug.cgi?id=100778
+
+Reviewed by Jocelyn Turcotte.
+
+Enable the ItemAcceptsDrops flag in the flickable WebView. This
+will allow the WebView to receive drag&drop events.
+
+* UIProcess/API/qt/qquickwebview.cpp:
+(QQuickWebViewPrivate::initialize):
+
 2012-11-28  Shinya Kawanaka  
 
 [Shadow] Move Distribution stuffs from ShadowRoot


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (136082 => 136083)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2012-11-29 02:21:57 UTC (rev 136082)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2012-11-29 02:24:31 UTC (rev 136083)
@@ -325,6 +325,7 @@
 
 q_ptr->setAcceptedMouseButtons(Qt::MouseButtonMask);
 q_ptr->setAcceptHoverEvents(true);
+q_ptr->setFlags(QQuickItem::ItemAcceptsDrops);
 }
 
 void QQuickWebViewPrivate::loadDidStop()






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [134620] trunk/Source/WebCore

[sergio]

Title: [134620] trunk/Source/WebCore








Revision 134620
Author ser...@webkit.org
Date 2012-11-14 09:46:26 -0800 (Wed, 14 Nov 2012)


Log Message
[Qt] Use a node image if there is no drag image set for Drag&Drop
https://bugs.webkit.org/show_bug.cgi?id=102124

Reviewed by Simon Hausmann.

Use the nodeImage provided by the frame if there is no dragImage in
the clipboard for the current drag&drop operation.

* platform/qt/ClipboardQt.cpp:
(WebCore::ClipboardQt::createDragImage):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/qt/ClipboardQt.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (134619 => 134620)

--- trunk/Source/WebCore/ChangeLog	2012-11-14 17:37:48 UTC (rev 134619)
+++ trunk/Source/WebCore/ChangeLog	2012-11-14 17:46:26 UTC (rev 134620)
@@ -1,3 +1,16 @@
+2012-11-14  Sergio Villar Senin  
+
+[Qt] Use a node image if there is no drag image set for Drag&Drop
+https://bugs.webkit.org/show_bug.cgi?id=102124
+
+Reviewed by Simon Hausmann.
+
+Use the nodeImage provided by the frame if there is no dragImage in
+the clipboard for the current drag&drop operation.
+
+* platform/qt/ClipboardQt.cpp:
+(WebCore::ClipboardQt::createDragImage):
+
 2012-11-14  Max Vujovic  
 
 Call to enclosingFilterLayer() in RenderObject::containerForRepaint() is expensive


Modified: trunk/Source/WebCore/platform/qt/ClipboardQt.cpp (134619 => 134620)

--- trunk/Source/WebCore/platform/qt/ClipboardQt.cpp	2012-11-14 17:37:48 UTC (rev 134619)
+++ trunk/Source/WebCore/platform/qt/ClipboardQt.cpp	2012-11-14 17:46:26 UTC (rev 134620)
@@ -240,10 +240,14 @@
 
 DragImageRef ClipboardQt::createDragImage(IntPoint& dragLoc) const
 {
-if (!m_dragImage)
-return 0;
 dragLoc = m_dragLoc;
-return m_dragImage->image()->nativeImageForCurrentFrame();
+
+if (m_dragImage)
+return m_dragImage->image()->nativeImageForCurrentFrame();
+if (m_dragImageElement && m_frame)
+return m_frame->nodeImage(m_dragImageElement.get());
+
+return 0;
 }
 
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [133770] trunk/Source/WebCore

[sergio]

Title: [133770] trunk/Source/WebCore








Revision 133770
Author ser...@webkit.org
Date 2012-11-07 09:39:26 -0800 (Wed, 07 Nov 2012)


Log Message
[Qt] Implement deleteCookie() for persistent storage
https://bugs.webkit.org/show_bug.cgi?id=101272

Reviewed by Jocelyn Turcotte.

Individual cookies were never persistently cleared as the
deleteCookie() virtual method was not implemented for persistent
storage. That's why cookies were only deleted for the current
session.

* platform/qt/CookieJarQt.cpp:
(WebCore::SharedCookieJarQt::deleteCookie):
(WebCore): added deleteCookie() implementation for persistent
storage.
* platform/qt/CookieJarQt.h:
(SharedCookieJarQt):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/qt/CookieJarQt.cpp
trunk/Source/WebCore/platform/qt/CookieJarQt.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (133769 => 133770)

--- trunk/Source/WebCore/ChangeLog	2012-11-07 17:35:22 UTC (rev 133769)
+++ trunk/Source/WebCore/ChangeLog	2012-11-07 17:39:26 UTC (rev 133770)
@@ -1,3 +1,22 @@
+2012-11-07  Sergio Villar Senin  
+
+[Qt] Implement deleteCookie() for persistent storage
+https://bugs.webkit.org/show_bug.cgi?id=101272
+
+Reviewed by Jocelyn Turcotte.
+
+Individual cookies were never persistently cleared as the
+deleteCookie() virtual method was not implemented for persistent
+storage. That's why cookies were only deleted for the current
+session.
+
+* platform/qt/CookieJarQt.cpp:
+(WebCore::SharedCookieJarQt::deleteCookie):
+(WebCore): added deleteCookie() implementation for persistent
+storage.
+* platform/qt/CookieJarQt.h:
+(SharedCookieJarQt):
+
 2012-11-07  Shinya Kawanaka  
 
 [Shadow] Style should update when 'pseudo' attribute is dynamically updated


Modified: trunk/Source/WebCore/platform/qt/CookieJarQt.cpp (133769 => 133770)

--- trunk/Source/WebCore/platform/qt/CookieJarQt.cpp	2012-11-07 17:35:22 UTC (rev 133769)
+++ trunk/Source/WebCore/platform/qt/CookieJarQt.cpp	2012-11-07 17:39:26 UTC (rev 133770)
@@ -199,6 +199,22 @@
 hostnames.add(networkCookie.domain());
 }
 
+bool SharedCookieJarQt::deleteCookie(const QNetworkCookie& cookie)
+{
+if (!QNetworkCookieJar::deleteCookie(cookie))
+return false;
+
+if (!m_database.isOpen())
+return false;
+
+QSqlQuery sqlQuery(m_database);
+sqlQuery.prepare(QLatin1String("DELETE FROM cookies WHERE cookieId=:cookieIdvalue"));
+sqlQuery.bindValue(QLatin1String(":cookieIdvalue"), cookie.domain().append(QLatin1String(cookie.name(;
+sqlQuery.exec();
+
+return true;
+}
+
 void SharedCookieJarQt::deleteCookiesForHostname(const String& hostname)
 {
 if (!m_database.isOpen())


Modified: trunk/Source/WebCore/platform/qt/CookieJarQt.h (133769 => 133770)

--- trunk/Source/WebCore/platform/qt/CookieJarQt.h	2012-11-07 17:35:22 UTC (rev 133769)
+++ trunk/Source/WebCore/platform/qt/CookieJarQt.h	2012-11-07 17:39:26 UTC (rev 133770)
@@ -38,6 +38,7 @@
 void destroy();
 
 void getHostnamesWithCookies(HashSet&);
+bool deleteCookie(const QNetworkCookie&);
 void deleteCookiesForHostname(const String&);
 void deleteAllCookies();
 bool setCookiesFromUrl(const QList&, const QUrl&);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [132919] trunk/Source/WebKit2

[sergio]

Title: [132919] trunk/Source/WebKit2








Revision 132919
Author ser...@webkit.org
Date 2012-10-30 10:08:02 -0700 (Tue, 30 Oct 2012)


Log Message
[WK2][Qt] Enable hover and mouse events in flickable WebView
https://bugs.webkit.org/show_bug.cgi?id=100296

Reviewed by Kenneth Rohde Christiansen.

Flickable WebView is now allowed to handle both hover and mouse
events. Flickable was initially meant to be the mobile interface and
was only handling touch events, but now the idea is that it will be
the WebView for both mobile and desktop environments.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize): refactored hover and mouse
event handling from children classes.
(QQuickWebViewLegacyPrivate::initialize):
(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (132918 => 132919)

--- trunk/Source/WebKit2/ChangeLog	2012-10-30 16:49:31 UTC (rev 132918)
+++ trunk/Source/WebKit2/ChangeLog	2012-10-30 17:08:02 UTC (rev 132919)
@@ -1,3 +1,21 @@
+2012-10-30  Sergio Villar Senin  
+
+[WK2][Qt] Enable hover and mouse events in flickable WebView
+https://bugs.webkit.org/show_bug.cgi?id=100296
+
+Reviewed by Kenneth Rohde Christiansen.
+
+Flickable WebView is now allowed to handle both hover and mouse
+events. Flickable was initially meant to be the mobile interface and
+was only handling touch events, but now the idea is that it will be
+the WebView for both mobile and desktop environments.
+
+* UIProcess/API/qt/qquickwebview.cpp:
+(QQuickWebViewPrivate::initialize): refactored hover and mouse
+event handling from children classes.
+(QQuickWebViewLegacyPrivate::initialize):
+(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):
+
 2012-10-29  Anders Carlsson  
 
 String::createCFString should return a RetainPtr


Modified: trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp (132918 => 132919)

--- trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2012-10-30 16:49:31 UTC (rev 132918)
+++ trunk/Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp	2012-10-30 17:08:02 UTC (rev 132919)
@@ -322,6 +322,9 @@
 
 pageClient.initialize(q_ptr, pageViewPrivate->eventHandler.data(), &undoController);
 webPageProxy->initializeWebPage();
+
+q_ptr->setAcceptedMouseButtons(Qt::MouseButtonMask);
+q_ptr->setAcceptHoverEvents(true);
 }
 
 void QQuickWebViewPrivate::loadDidStop()
@@ -806,12 +809,8 @@
 
 void QQuickWebViewLegacyPrivate::initialize(WKContextRef contextRef, WKPageGroupRef pageGroupRef)
 {
-Q_Q(QQuickWebView);
 QQuickWebViewPrivate::initialize(contextRef, pageGroupRef);
 
-q->setAcceptedMouseButtons(Qt::MouseButtonMask);
-q->setAcceptHoverEvents(true);
-
 // Trigger setting of correct visibility flags after everything was allocated and initialized.
 _q_onVisibleChanged();
 }
@@ -848,7 +847,6 @@
 QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate(QQuickWebView* viewport)
 : QQuickWebViewPrivate(viewport)
 {
-viewport->setAcceptHoverEvents(false);
 }
 
 void QQuickWebViewFlickablePrivate::initialize(WKContextRef contextRef, WKPageGroupRef pageGroupRef)






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [132870] trunk/Source/WebKit2

[sergio]

Title: [132870] trunk/Source/WebKit2








Revision 132870
Author ser...@webkit.org
Date 2012-10-29 20:42:28 -0700 (Mon, 29 Oct 2012)


Log Message
REGRESSION(r130755): All WebKit2 unit tests are failing in WebKit2 bot
https://bugs.webkit.org/show_bug.cgi?id=98864

Reviewed by Martin Robinson.

Use a dedicated directory to store WebKit2 generated resources.

* UIProcess/API/gtk/tests/GNUmakefile.am:
* UIProcess/API/gtk/tests/TestMain.cpp:
(registerGResource): load the resource from the new directory.

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/tests/GNUmakefile.am
trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (132869 => 132870)

--- trunk/Source/WebKit2/ChangeLog	2012-10-30 03:34:12 UTC (rev 132869)
+++ trunk/Source/WebKit2/ChangeLog	2012-10-30 03:42:28 UTC (rev 132870)
@@ -1,3 +1,16 @@
+2012-10-29  Sergio Villar Senin  
+
+REGRESSION(r130755): All WebKit2 unit tests are failing in WebKit2 bot
+https://bugs.webkit.org/show_bug.cgi?id=98864
+
+Reviewed by Martin Robinson.
+
+Use a dedicated directory to store WebKit2 generated resources.
+
+* UIProcess/API/gtk/tests/GNUmakefile.am:
+* UIProcess/API/gtk/tests/TestMain.cpp:
+(registerGResource): load the resource from the new directory.
+
 2012-10-29  Huang Dongsung  
 
 Coordinated Graphics: Delete cached ShareableSurfaces when purging backingStores.


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/tests/GNUmakefile.am (132869 => 132870)

--- trunk/Source/WebKit2/UIProcess/API/gtk/tests/GNUmakefile.am	2012-10-30 03:34:12 UTC (rev 132869)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/tests/GNUmakefile.am	2012-10-30 03:42:28 UTC (rev 132870)
@@ -58,11 +58,11 @@
 	-no-install \
 	-no-fast-install
 
-DerivedSources/WebKit2/webkit2gtk-tests-resources.gresource: Source/WebKit2/UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml $(shell $(GLIB_COMPILE_RESOURCES) --sourcedir=$(srcdir) --generate-dependencies $(srcdir)/Source/WebKit2/UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml)
+Programs/resources/webkit2gtk-tests-resources.gresource: Source/WebKit2/UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml $(shell $(GLIB_COMPILE_RESOURCES) --sourcedir=$(srcdir) --generate-dependencies $(srcdir)/Source/WebKit2/UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml)
 	$(AM_V_GEN) $(GLIB_COMPILE_RESOURCES) --target=$@ --sourcedir=$(srcdir) $<
 
-DISTCLEANFILES += DerivedSources/WebKit2/webkit2gtk-tests-resources.gresource
-noinst_DATA += DerivedSources/WebKit2/webkit2gtk-tests-resources.gresource
+DISTCLEANFILES += Programs/resources/webkit2gtk-tests-resources.gresource
+noinst_DATA += Programs/resources/webkit2gtk-tests-resources.gresource
 
 noinst_LTLIBRARIES += Libraries/libWebKit2APITestCore.la
 Libraries_libWebKit2APITestCore_la_SOURCES = \


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp (132869 => 132870)

--- trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp	2012-10-30 03:34:12 UTC (rev 132869)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp	2012-10-30 03:42:28 UTC (rev 132870)
@@ -27,7 +27,7 @@
 
 static void registerGResource(void)
 {
-GOwnPtr resourcesPath(g_build_filename(WEBKIT_DERIVED_SRC_DIR, "WebKit2", "webkit2gtk-tests-resources.gresource", NULL));
+GOwnPtr resourcesPath(g_build_filename(WEBKIT_EXEC_PATH, "resources", "webkit2gtk-tests-resources.gresource", NULL));
 GResource* resource = g_resource_load(resourcesPath.get(), 0);
 g_assert(resource);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128986] trunk/LayoutTests

[sergio]

Title: [128986] trunk/LayoutTests








Revision 128986
Author ser...@webkit.org
Date 2012-09-19 03:55:28 -0700 (Wed, 19 Sep 2012)


Log Message
Unreviewed GTK gardening.

Updated expectations for the WK2 GTK bot.

* platform/gtk-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128985 => 128986)

--- trunk/LayoutTests/ChangeLog	2012-09-19 10:52:59 UTC (rev 128985)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 10:55:28 UTC (rev 128986)
@@ -1,3 +1,11 @@
+2012-09-19  Sergio Villar Senin  
+
+Unreviewed GTK gardening.
+
+Updated expectations for the WK2 GTK bot.
+
+* platform/gtk-wk2/TestExpectations:
+
 2012-09-19  Christophe Dumez  
 
 [EFL] tables/mozilla tests need rebaseline (Part 3)


Modified: trunk/LayoutTests/platform/gtk-wk2/TestExpectations (128985 => 128986)

--- trunk/LayoutTests/platform/gtk-wk2/TestExpectations	2012-09-19 10:52:59 UTC (rev 128985)
+++ trunk/LayoutTests/platform/gtk-wk2/TestExpectations	2012-09-19 10:55:28 UTC (rev 128986)
@@ -248,11 +248,6 @@
 // Crashing tests
 //
 
-// accessibility tests failing in WK1 but crashing in WK2
-BUGWKGTK : accessibility/aria-hidden-with-elements.html = CRASH
-BUGWKGTK : accessibility/inline-continuations.html = CRASH
-BUGWKGTK : accessibility/loading-iframe-sends-notification.html = CRASH
-
 BUGWKGTK : plugins/document-open.html = CRASH
 
 //
@@ -272,6 +267,8 @@
 BUGWK72698 : media/audio-garbage-collect.html = TEXT PASS
 
 // Tests showing flakiness in the bot
+BUGWKGTK : editing/pasteboard/smart-paste-004.html = TEXT PASS
+BUGWKGTK : editing/selection/5057506.html = TEXT PASS
 BUGWKGTK : editing/selection/click-in-margins-inside-editable-div.html = TEXT PASS
 BUGWKGTK : fast/events/dispatch-message-string-data.html = TEXT PASS
 BUGWKGTK : fast/events/domactivate-sets-underlying-click-event-as-handled.html = TEXT PASS
@@ -305,11 +302,30 @@
 BUGWKGTK : fast/writing-mode/japanese-ruby-horizontal-bt.html = TEXT PASS
 BUGWKGTK : fast/writing-mode/japanese-ruby-vertical-lr.html = TEXT PASS
 BUGWKGTK : fast/writing-mode/japanese-ruby-vertical-rl.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/change-version-handle-reuse-worker.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/change-version-sync.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/empty-statement-sync.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/execute-sql-args-sync.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/execute-sql-args-worker.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/multiple-transactions.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/multiple-transactions-on-different-handles.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/multiple-transactions-on-different-handles-sync.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/open-database-empty-version-sync.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/open-database-set-empty-version-sync.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/open-database-while-transaction-in-progress.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/open-database-while-transaction-in-progress-sync.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/read-and-write-transactions-dont-run-together.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/sql-data-types-sync.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/test-authorizer.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/test-authorizer-sync.html = TEXT PASS
+BUGWKGTK : fast/workers/storage/transaction-in-transaction-sync.html = TEXT PASS
+BUGWKGTK : http/tests/security/cross-origin-plugin-allowed.html = TEXT PASS
 BUGWKGTK : http/tests/w3c/webperf/approved/navigation-timing/html/test_performance_attributes_exist_in_object.html = TEXT PASS
 BUGWKGTK : media/video-transformed.html = TEXT PASS
 BUGWKGTK : media/W3C/audio/networkState/networkState_during_loadstart.html = TEXT PASS
 BUGWKGTK : svg/custom/gradient-attr-update.svg = TEXT PASS
 BUGWKGTK : svg/custom/pointer-events-on-svg-with-pointer.xhtml = TEXT PASS
+BUGWKGTK : svg/custom/pointer-events-on-svg-without-pointer.xhtml = TEXT PASS
 BUGWKGTK : svg/stroke/non-scaling-stroke-pattern.svg = IMAGE PASS
 
 //
@@ -425,6 +441,7 @@
 BUGWKGTK : accessibility/ignore-spacer-elements.html = TEXT
 BUGWKGTK : accessibility/img-fallsback-to-title.html = TEXT
 BUGWKGTK : accessibility/inline-continuations.html = TEXT
+BUGWKGTK : accessibility/legend.html = TEXT
 BUGWKGTK : accessibility/loading-iframe-sends-notification.html = TEXT
 BUGWKGTK : accessibility/media-element.html = TEXT
 BUGWKGTK : editing/deleting/delete-ligature-003.html = TEXT
@@ -460,7 +477,7 @@
 BUGWKGTK : fast/forms/mailto/formenctype-attribute-

[webkit-changes] [128977] trunk/LayoutTests

[sergio]

Title: [128977] trunk/LayoutTests








Revision 128977
Author ser...@webkit.org
Date 2012-09-19 01:30:50 -0700 (Wed, 19 Sep 2012)


Log Message
Unreviewed GTK gardening.

Updated the recently added TestExpectations file for WK2 with the
actual failures from the bot.

* platform/gtk-wk2/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk-wk2/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (128976 => 128977)

--- trunk/LayoutTests/ChangeLog	2012-09-19 08:08:22 UTC (rev 128976)
+++ trunk/LayoutTests/ChangeLog	2012-09-19 08:30:50 UTC (rev 128977)
@@ -1,3 +1,12 @@
+2012-09-19  Sergio Villar Senin  
+
+Unreviewed GTK gardening.
+
+Updated the recently added TestExpectations file for WK2 with the
+actual failures from the bot.
+
+* platform/gtk-wk2/TestExpectations:
+
 2012-09-19  Andrey Adaikin  
 
 Web Inspector: [WebGL] -> [Canvas] Rename WebGLAgent to CanvasAgent


Modified: trunk/LayoutTests/platform/gtk-wk2/TestExpectations (128976 => 128977)

--- trunk/LayoutTests/platform/gtk-wk2/TestExpectations	2012-09-19 08:08:22 UTC (rev 128976)
+++ trunk/LayoutTests/platform/gtk-wk2/TestExpectations	2012-09-19 08:30:50 UTC (rev 128977)
@@ -37,6 +37,7 @@
 // Tests that require new results.
 //
 
+BUGWKGTK SKIP : fast/regions/autoheight-regions-mark.html = TEXT
 BUGWKGTK SKIP : http/tests/security/resources/drag-drop-allowed.html = TEXT
 
 //
@@ -56,7 +57,6 @@
 BUGWK63706 : editing/pasteboard/drag-and-drop-image-contenteditable.html = TEXT TIMEOUT
 BUGWK63706 : editing/pasteboard/drag-and-drop-inputimage-contenteditable.html = TEXT TIMEOUT
 BUGWK63706 : editing/pasteboard/drag-and-drop-objectimage-contenteditable.html = TEXT TIMEOUT
-BUGWK63706 : editing/pasteboard/drag-drop-dead-frame.html = TEXT
 BUGWK63706 : editing/pasteboard/drag-drop-input-textarea.html = TEXT
 BUGWK63706 : editing/pasteboard/drag-drop-modifies-page.html = TEXT
 BUGWK63706 : editing/pasteboard/drag-drop-url-text.html = TEXT
@@ -76,7 +76,6 @@
 BUGWK63706 : editing/selection/drag-text-delay.html = TEXT
 BUGWK63706 : editing/undo/undo-smart-delete-word.html = TEXT
 BUGWK63706 : fast/block/float/float-in-float-hit-testing.html = TEXT
-BUGWK63706 : fast/events/autoscroll.html = TEXT
 BUGWK63706 : fast/events/bogus-dropEffect-effectAllowed.html = TEXT
 BUGWK63706 : fast/events/content-changed-during-drop.html = TEXT
 BUGWK63706 : fast/events/crash-on-mutate-during-drop.html = TEXT
@@ -96,24 +95,13 @@
 BUGWK63706 : fast/forms/drag-into-textarea.html = TEXT
 BUGWK63706 : fast/forms/drag-out-of-textarea.html = TEXT
 BUGWK63706 : fast/forms/file/input-file-write-files.html = TEXT TIMEOUT
-BUGWK63706 : fast/forms/input-readonly-autoscroll.html = TEXT
-BUGWK63706 : fast/forms/input-text-drag-down.html = TEXT
 BUGWK63706 : fast/forms/range/slider-delete-while-dragging-thumb.html = TEXT
-BUGWK63706 : fast/forms/select-listbox-multiple-no-focusring.html = TEXT
 BUGWK63706 : fast/lists/drag-into-marker.html = TEXT
-BUGWK63706 : fast/repaint/repaint-across-writing-mode-boundary.html = TEXT
-BUGWK63706 : fast/repaint/selection-rl.html = TEXT
-BUGWK63706 : fast/text/atsui-rtl-override-selection.html = TEXT
-BUGWK63706 : fast/writing-mode/horizontal-bt-replaced-selection.html = TEXT
-BUGWK63706 : fast/writing-mode/vertical-lr-replaced-selection.html = TEXT
-BUGWK63706 : fast/writing-mode/vertical-rl-replaced-selection.html = TEXT
 BUGWK63706 : http/tests/misc/bubble-drag-events.html = TEXT
 BUGWK63706 : http/tests/security/drag-over-remote-content-iframe.html = TEXT
 BUGWK63706 : plugins/mouse-events-fixedpos.html = TEXT
 BUGWK63706 : plugins/mouse-events.html = TEXT
-BUGWK63706 : svg/custom/mouse-move-on-svg-container-standalone.svg = TEXT
 BUGWK63706 : svg/custom/mouse-move-on-svg-container.xhtml = TEXT TIMEOUT
-BUGWK63706 : svg/custom/mouse-move-on-svg-root-standalone.svg = TEXT
 BUGWK63706 : svg/custom/mouse-move-on-svg-root.xhtml = TEXT TIMEOUT
 
 // WebKit2 needs layoutTestController.setSmartInsertDeleteEnabled
@@ -122,9 +110,6 @@
 BUGWKGTK : editing/selection/doubleclick-whitespace-crash.html = TEXT
 BUGWKGTK : editing/selection/doubleclick-whitespace-img-crash.html = TEXT
 
-// WebKit2 needs layoutTestController.setSpatialNavigationEnabled
-BUGWKGTK : fast/spatial-navigation/snav-multiple-select-focusring.html = TEXT
-
 // WebKit2 needs layoutTestController.addMockSpeechInputResult
 BUGWKGTK : fast/speech/input-onspeechchange-event.html = TEXT
 BUGWKGTK : fast/speech/input-ontextinput-event.html = TEXT
@@ -147,21 +132,12 @@
 // WebKit2 needs textInputController.selectedRange
 BUGWKGTK : editing/selection/mixed-editability-10.html = TEXT
 
-// WebKit2 needs layoutTestController.overridePreference
-// https://bugs.webkit.org/show_bug.cgi?id=42197
-BUGWKGTK : fast/repaint

[webkit-changes] [128874] trunk/Tools

[sergio]

Title: [128874] trunk/Tools








Revision 128874
Author ser...@webkit.org
Date 2012-09-18 04:33:03 -0700 (Tue, 18 Sep 2012)


Log Message
[GTK] run-webkit-tests unable to find TestExpectations for WK2
https://bugs.webkit.org/show_bug.cgi?id=96998

Reviewed by Philippe Normand.

We should look for TestExpectations files in all the locations where
we currently look for Skipped files. This will allow
run-webkit-tests to look for TestExpectations files in
platform/gtk-wk2 and platform/wk2 if the "-2" flag is used.

* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.expectations_files):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py




Diff

Modified: trunk/Tools/ChangeLog (128873 => 128874)

--- trunk/Tools/ChangeLog	2012-09-18 11:14:03 UTC (rev 128873)
+++ trunk/Tools/ChangeLog	2012-09-18 11:33:03 UTC (rev 128874)
@@ -1,3 +1,18 @@
+2012-09-18  Sergio Villar Senin  
+
+[GTK] run-webkit-tests unable to find TestExpectations for WK2
+https://bugs.webkit.org/show_bug.cgi?id=96998
+
+Reviewed by Philippe Normand.
+
+We should look for TestExpectations files in all the locations where
+we currently look for Skipped files. This will allow
+run-webkit-tests to look for TestExpectations files in
+platform/gtk-wk2 and platform/wk2 if the "-2" flag is used.
+
+* Scripts/webkitpy/layout_tests/port/gtk.py:
+(GtkPort.expectations_files):
+
 2012-09-18  Tor Arne Vestbø  
 
 [Qt] Fix build without the QtQuick module


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py (128873 => 128874)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py	2012-09-18 11:14:03 UTC (rev 128873)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py	2012-09-18 11:33:03 UTC (rev 128874)
@@ -38,6 +38,9 @@
 class GtkPort(Port, PulseAudioSanitizer):
 port_name = "gtk"
 
+def expectations_files(self):
+return [self._filesystem.join(self._webkit_baseline_path(d), 'TestExpectations') for d in self._skipped_file_search_paths()]
+
 def _port_flag_for_scripts(self):
 return "--gtk"
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128620] trunk/LayoutTests

[sergio]

Title: [128620] trunk/LayoutTests








Revision 128620
Author ser...@webkit.org
Date 2012-09-14 09:30:27 -0700 (Fri, 14 Sep 2012)


Log Message
[GTK] [WK2] Unreviewed gardening.

Added a bunch of tests failing in the WK2 tests bot to the Skipped
list with the proper links to each bug.

* platform/gtk-wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk-wk2/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (128619 => 128620)

--- trunk/LayoutTests/ChangeLog	2012-09-14 16:27:59 UTC (rev 128619)
+++ trunk/LayoutTests/ChangeLog	2012-09-14 16:30:27 UTC (rev 128620)
@@ -1,3 +1,12 @@
+2012-09-14  Sergio Villar Senin  
+
+[GTK] [WK2] Unreviewed gardening.
+
+Added a bunch of tests failing in the WK2 tests bot to the Skipped
+list with the proper links to each bug.
+
+* platform/gtk-wk2/Skipped:
+
 2012-09-14  Rick Byers  
 
 Gesture events sent to wrong node when page is scrolled


Modified: trunk/LayoutTests/platform/gtk-wk2/Skipped (128619 => 128620)

--- trunk/LayoutTests/platform/gtk-wk2/Skipped	2012-09-14 16:27:59 UTC (rev 128619)
+++ trunk/LayoutTests/platform/gtk-wk2/Skipped	2012-09-14 16:30:27 UTC (rev 128620)
@@ -70,6 +70,11 @@
 fullscreen/full-screen-twice.html
 fullscreen/full-screen-remove.html
 fullscreen/full-screen-zIndex-after.html
+fullscreen/full-screen-element-stack.html
+fullscreen/full-screen-fixed-pos-parent.html
+fullscreen/full-screen-keyboard-enabled.html
+fullscreen/full-screen-restrictions.html
+fullscreen/non-ancestor-iframe.html
 
 animations/fill-mode-forwards.html
 editing/deleting/delete-by-word-001.html
@@ -83,6 +88,7 @@
 fast/forms/select-type-ahead-non-latin.html
 fast/forms/listbox-typeahead-cyrillic.html
 fast/forms/listbox-typeahead-greek.html
+fast/forms/legend-access-key.html
 http/tests/xmlhttprequest/workers/abort-exception-assert.html
 platform/gtk/fast/forms/menulist-typeahead-find.html
 plugins/document-open.html
@@ -405,11 +411,91 @@
 transitions/extra-transition.html
 transitions/interrupted-accelerated-transition.html
 
+# [Navigation Timing] Remove old-style LayoutTests
+# https://bugs.webkit.org/show_bug.cgi?id=91158
+fast/dom/navigation-type-back-forward.html
+fast/dom/navigation-type-navigate.html
+fast/dom/navigation-type-reload.html
+
+# https://bugs.webkit.org/show_bug.cgi?id=94549
+fast/forms/file/selected-files-from-history-state.html
+
+# https://bugs.webkit.org/show_bug.cgi?id=95043
+http/tests/security/local-user-CSS-from-remote.html
+
+# EventSender::dumpFilenameBeingDragged not implemented.
+# https://bugs.webkit.org/show_bug.cgi?id=61827
+fast/events/drag-image-filename.html
+
+# Assertion failure in replaySavedEvents
+# http://webkit.org/b/21796
+fast/forms/select-multiple-elements-with-mouse-drag-with-options-less-than-size.html
+
+# WebKitTestRunner layoutTestController.pathToLocalResource needs to be updated to work with NRWT
+# https://bugs.webkit.org/show_bug.cgi?id=81299
+fast/loader/local-CSS-from-local.html
+fast/loader/local-_javascript_-from-local.html
+fast/loader/local-image-from-local.html
+
+# WebKitTestRunner needs a more-complete implementation of eventSender
+# https://bugs.webkit.org/show_bug.cgi?id=42194
+editing/undo/undo-smart-delete-reversed-selection.html
+fast/dom/vertical-scrollbar-in-rtl.html
+fast/events/5056619.html
+http/tests/security/drag-drop-same-unique-origin.html
+svg/custom/polyline-hittest.svg
+
+# [Qt][GTK][WK2] New http/tests/cache/xhr-vary-header.html fails
+# https://bugs.webkit.org/show_bug.cgi?id=89278
+http/tests/cache/xhr-vary-header.html
+
+# [Qt][GTK] REGRESSION(r126194): http/tests/security/contentSecurityPolicy/register-bypassing-scheme.html fails
+# https://bugs.webkit.org/show_bug.cgi?id=94677
+http/tests/security/contentSecurityPolicy/register-bypassing-scheme.html
+
+# [Qt][WK2] New http/tests/security/cross-origin-plugin* tests fail
+# https://bugs.webkit.org/show_bug.cgi?id=95935
+http/tests/security/cross-origin-plugin-private-browsing-toggled.html
+http/tests/security/cross-origin-plugin.html
+
+# REGRESSION (r127202): http/tests/security/inactive-document-with-empty-security-origin.html failing on JSC ports
+# https://bugs.webkit.org/show_bug.cgi?id=95530
+http/tests/security/inactive-document-with-empty-security-origin.html
+
+# https://bugs.webkit.org/show_bug.cgi?id=82672
+http/tests/xmlhttprequest/range-test.html
+
+# https://bugs.webkit.org/show_bug.cgi?id=39160
+security/block-test-no-port.html
+
+# Some tests rely on a /tmp/LayoutTests symlink pointing to the LayoutTests directory
+# https://bugs.webkit.org/show_bug.cgi?id=64135
+fast/dom/frame-loading-via-document-write.html
+
+# media/audio-garbage-collect.html is flaky
+# https://bugs.webkit.org/show_bug.cgi?id=72698
+media/audio-garbage-collect.html
+
 ###
 # TESTS FAILING
 ###
 
-# Unc

[webkit-changes] [128195] trunk

[sergio]

Title: [128195] trunk








Revision 128195
Author ser...@webkit.org
Date 2012-09-11 09:42:11 -0700 (Tue, 11 Sep 2012)


Log Message
[GTK] WebKitGtk+ crashes with non-UTF8 HTTP header names
https://bugs.webkit.org/show_bug.cgi?id=96284

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Non UTF-8 characters sent as part of a HTTP header name were
causing crashes as String::fromUTF8() was returning NULL for
them. Use String::fromUTF8WithLatin1Fallback() instead.

Test: http/tests/misc/non-utf8-header-name.php

* platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::updateFromSoupMessage):

LayoutTests:

Added a new test to make sure that WebKitGtk+ does not crash when
a non-UTF8 character is sent as part of a HTTP header name.

* http/tests/misc/non-utf8-header-name-expected.txt: Added.
* http/tests/misc/non-utf8-header-name.php: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp


Added Paths

trunk/LayoutTests/http/tests/misc/non-utf8-header-name-expected.txt
trunk/LayoutTests/http/tests/misc/non-utf8-header-name.php




Diff

Modified: trunk/LayoutTests/ChangeLog (128194 => 128195)

--- trunk/LayoutTests/ChangeLog	2012-09-11 16:40:47 UTC (rev 128194)
+++ trunk/LayoutTests/ChangeLog	2012-09-11 16:42:11 UTC (rev 128195)
@@ -1,3 +1,16 @@
+2012-09-11  Sergio Villar Senin  
+
+[GTK] WebKitGtk+ crashes with non-UTF8 HTTP header names
+https://bugs.webkit.org/show_bug.cgi?id=96284
+
+Reviewed by Gustavo Noronha Silva.
+
+Added a new test to make sure that WebKitGtk+ does not crash when
+a non-UTF8 character is sent as part of a HTTP header name.
+
+* http/tests/misc/non-utf8-header-name-expected.txt: Added.
+* http/tests/misc/non-utf8-header-name.php: Added.
+
 2012-09-11  Csaba Osztrogonác  
 
 [Qt][WK2] Unreviewed gardening, skip new failing tests to paint the bot green.


Added: trunk/LayoutTests/http/tests/misc/non-utf8-header-name-expected.txt (0 => 128195)

--- trunk/LayoutTests/http/tests/misc/non-utf8-header-name-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/misc/non-utf8-header-name-expected.txt	2012-09-11 16:42:11 UTC (rev 128195)
@@ -0,0 +1 @@
+Test for bug 96284: Non UTF-8 HTTP headers do not cause a crash.


Added: trunk/LayoutTests/http/tests/misc/non-utf8-header-name.php (0 => 128195)

--- trunk/LayoutTests/http/tests/misc/non-utf8-header-name.php	(rev 0)
+++ trunk/LayoutTests/http/tests/misc/non-utf8-header-name.php	2012-09-11 16:42:11 UTC (rev 128195)
@@ -0,0 +1,9 @@
+';
+echo '   if (window.testRunner)';
+echo '   testRunner.dumpAsText();';
+echo '';
+echo 'Test for : Non UTF-8 HTTP headers do not cause a crash.';
+?>


Modified: trunk/Source/WebCore/ChangeLog (128194 => 128195)

--- trunk/Source/WebCore/ChangeLog	2012-09-11 16:40:47 UTC (rev 128194)
+++ trunk/Source/WebCore/ChangeLog	2012-09-11 16:42:11 UTC (rev 128195)
@@ -1,3 +1,19 @@
+2012-09-11  Sergio Villar Senin  
+
+[GTK] WebKitGtk+ crashes with non-UTF8 HTTP header names
+https://bugs.webkit.org/show_bug.cgi?id=96284
+
+Reviewed by Gustavo Noronha Silva.
+
+Non UTF-8 characters sent as part of a HTTP header name were
+causing crashes as String::fromUTF8() was returning NULL for
+them. Use String::fromUTF8WithLatin1Fallback() instead.
+
+Test: http/tests/misc/non-utf8-header-name.php
+
+* platform/network/soup/ResourceResponseSoup.cpp:
+(WebCore::ResourceResponse::updateFromSoupMessage):
+
 2012-09-11  Sheriff Bot  
 
 Unreviewed, rolling out r128175.


Modified: trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp (128194 => 128195)

--- trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp	2012-09-11 16:40:47 UTC (rev 128194)
+++ trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp	2012-09-11 16:42:11 UTC (rev 128195)
@@ -69,7 +69,7 @@
 
 soup_message_headers_iter_init(&headersIter, soupMessage->response_headers);
 while (soup_message_headers_iter_next(&headersIter, &headerName, &headerValue))
-m_httpHeaderFields.set(String::fromUTF8(headerName),
+m_httpHeaderFields.set(String::fromUTF8WithLatin1Fallback(headerName, strlen(headerName)),
String::fromUTF8WithLatin1Fallback(headerValue, strlen(headerValue)));
 
 m_soupFlags = soup_message_get_flags(soupMessage);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [128175] trunk

[sergio]

Title: [128175] trunk








Revision 128175
Author ser...@webkit.org
Date 2012-09-11 06:11:22 -0700 (Tue, 11 Sep 2012)


Log Message
[GTK] WebKitGtk+ crashes with non-UTF8 HTTP header names
https://bugs.webkit.org/show_bug.cgi?id=96284

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Non UTF-8 characters sent as part of a HTTP header name were
causing crashes as String::fromUTF8() was returning NULL for
them. Use String::fromUTF8WithLatin1Fallback() instead.

Test: http/tests/misc/non-utf8-header-name.php

* platform/network/soup/ResourceResponseSoup.cpp:
(WebCore::ResourceResponse::updateFromSoupMessage):

LayoutTests:

Added a new test to make sure that WebKitGtk+ does not crash when
a non-UTF8 character is sent as part of a HTTP header name.

* http/tests/misc/non-utf8-header-name-expected.txt: Added.
* http/tests/misc/non-utf8-header-name.php: Added.

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp


Added Paths

trunk/LayoutTests/http/tests/misc/non-utf8-header-name-expected.txt
trunk/LayoutTests/http/tests/misc/non-utf8-header-name.php




Diff

Modified: trunk/LayoutTests/ChangeLog (128174 => 128175)

--- trunk/LayoutTests/ChangeLog	2012-09-11 13:06:39 UTC (rev 128174)
+++ trunk/LayoutTests/ChangeLog	2012-09-11 13:11:22 UTC (rev 128175)
@@ -1,3 +1,16 @@
+2012-09-11  Sergio Villar Senin  
+
+[GTK] WebKitGtk+ crashes with non-UTF8 HTTP header names
+https://bugs.webkit.org/show_bug.cgi?id=96284
+
+Reviewed by Gustavo Noronha Silva.
+
+Added a new test to make sure that WebKitGtk+ does not crash when
+a non-UTF8 character is sent as part of a HTTP header name.
+
+* http/tests/misc/non-utf8-header-name-expected.txt: Added.
+* http/tests/misc/non-utf8-header-name.php: Added.
+
 2012-09-11  Christophe Dumez  
 
 [WK2][WKTR] TestRunner needs to implement clearApplicationCacheForOrigin


Added: trunk/LayoutTests/http/tests/misc/non-utf8-header-name-expected.txt (0 => 128175)

--- trunk/LayoutTests/http/tests/misc/non-utf8-header-name-expected.txt	(rev 0)
+++ trunk/LayoutTests/http/tests/misc/non-utf8-header-name-expected.txt	2012-09-11 13:11:22 UTC (rev 128175)
@@ -0,0 +1 @@
+Test for bug 96284: Non UTF-8 HTTP headers do not cause a crash.


Added: trunk/LayoutTests/http/tests/misc/non-utf8-header-name.php (0 => 128175)

--- trunk/LayoutTests/http/tests/misc/non-utf8-header-name.php	(rev 0)
+++ trunk/LayoutTests/http/tests/misc/non-utf8-header-name.php	2012-09-11 13:11:22 UTC (rev 128175)
@@ -0,0 +1,9 @@
+';
+echo '   if (window.testRunner)';
+echo '   testRunner.dumpAsText();';
+echo '';
+echo 'Test for : Non UTF-8 HTTP headers do not cause a crash.';
+?>


Modified: trunk/Source/WebCore/ChangeLog (128174 => 128175)

--- trunk/Source/WebCore/ChangeLog	2012-09-11 13:06:39 UTC (rev 128174)
+++ trunk/Source/WebCore/ChangeLog	2012-09-11 13:11:22 UTC (rev 128175)
@@ -1,3 +1,19 @@
+2012-09-11  Sergio Villar Senin  
+
+[GTK] WebKitGtk+ crashes with non-UTF8 HTTP header names
+https://bugs.webkit.org/show_bug.cgi?id=96284
+
+Reviewed by Gustavo Noronha Silva.
+
+Non UTF-8 characters sent as part of a HTTP header name were
+causing crashes as String::fromUTF8() was returning NULL for
+them. Use String::fromUTF8WithLatin1Fallback() instead.
+
+Test: http/tests/misc/non-utf8-header-name.php
+
+* platform/network/soup/ResourceResponseSoup.cpp:
+(WebCore::ResourceResponse::updateFromSoupMessage):
+
 2012-09-11  Tor Arne Vestbø  
 
 [Qt] Add a configure step to the Qt build system


Modified: trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp (128174 => 128175)

--- trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp	2012-09-11 13:06:39 UTC (rev 128174)
+++ trunk/Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp	2012-09-11 13:11:22 UTC (rev 128175)
@@ -69,7 +69,7 @@
 
 soup_message_headers_iter_init(&headersIter, soupMessage->response_headers);
 while (soup_message_headers_iter_next(&headersIter, &headerName, &headerValue))
-m_httpHeaderFields.set(String::fromUTF8(headerName),
+m_httpHeaderFields.set(String::fromUTF8WithLatin1Fallback(headerName, strlen(headerValue)),
String::fromUTF8WithLatin1Fallback(headerValue, strlen(headerValue)));
 
 m_soupFlags = soup_message_get_flags(soupMessage);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [126551] trunk/Source/WebCore

[sergio]

Title: [126551] trunk/Source/WebCore








Revision 126551
Author ser...@webkit.org
Date 2012-08-24 00:45:50 -0700 (Fri, 24 Aug 2012)


Log Message
[GTK] Purge unused favicons from IconDatabase after 30 days
https://bugs.webkit.org/show_bug.cgi?id=82346

Reviewed by Gustavo Noronha Silva.

Favicons will be removed from the icon database after not being used
for more than 30 days. This will keep the database size under
control.

* loader/icon/IconDatabase.cpp:
(WebCore):
(WebCore::IconDatabase::performURLImport): filter icons older than
30 days.

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/icon/IconDatabase.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (126550 => 126551)

--- trunk/Source/WebCore/ChangeLog	2012-08-24 07:40:44 UTC (rev 126550)
+++ trunk/Source/WebCore/ChangeLog	2012-08-24 07:45:50 UTC (rev 126551)
@@ -1,3 +1,19 @@
+2012-08-24  Sergio Villar Senin  
+
+[GTK] Purge unused favicons from IconDatabase after 30 days
+https://bugs.webkit.org/show_bug.cgi?id=82346
+
+Reviewed by Gustavo Noronha Silva.
+
+Favicons will be removed from the icon database after not being used
+for more than 30 days. This will keep the database size under
+control.
+
+* loader/icon/IconDatabase.cpp:
+(WebCore):
+(WebCore::IconDatabase::performURLImport): filter icons older than
+30 days.
+
 2012-08-23  Sheriff Bot  
 
 Unreviewed, rolling out r126542.


Modified: trunk/Source/WebCore/loader/icon/IconDatabase.cpp (126550 => 126551)

--- trunk/Source/WebCore/loader/icon/IconDatabase.cpp	2012-08-24 07:40:44 UTC (rev 126550)
+++ trunk/Source/WebCore/loader/icon/IconDatabase.cpp	2012-08-24 07:45:50 UTC (rev 126551)
@@ -73,6 +73,12 @@
 
 static bool checkIntegrityOnOpen = false;
 
+#if PLATFORM(GTK)
+// We are not interested in icons that have been unused for more than
+// 30 days, delete them even if they have not been explicitly released.
+static const int notUsedIconExpirationTime = 60*60*24*30;
+#endif
+
 #if !LOG_DISABLED || !ERROR_DISABLED
 static String urlForLogging(const String& url)
 {
@@ -1257,7 +1263,17 @@
 {
 ASSERT_ICON_SYNC_THREAD();
 
-SQLiteStatement query(m_syncDB, "SELECT PageURL.url, IconInfo.url, IconInfo.stamp FROM PageURL INNER JOIN IconInfo ON PageURL.iconID=IconInfo.iconID;");
+# if PLATFORM(GTK)
+// Do not import icons not used in the last 30 days. They will be automatically pruned later if nobody retains them.
+// Note that IconInfo.stamp is only set when the icon data is retrieved from the server (and thus is not updated whether
+// we use it or not). This code works anyway because the IconDatabase downloads icons again if they are older than 4 days,
+// so if the timestamp goes back in time more than those 30 days we can be sure that the icon was not used at all.
+String importQuery = String::format("SELECT PageURL.url, IconInfo.url, IconInfo.stamp FROM PageURL INNER JOIN IconInfo ON PageURL.iconID=IconInfo.iconID WHERE IconInfo.stamp > %.0f;", floor(currentTime() - notUsedIconExpirationTime));
+#else
+String importQuery("SELECT PageURL.url, IconInfo.url, IconInfo.stamp FROM PageURL INNER JOIN IconInfo ON PageURL.iconID=IconInfo.iconID;");
+#endif
+
+SQLiteStatement query(m_syncDB, importQuery);
 
 if (query.prepare() != SQLResultOk) {
 LOG_ERROR("Unable to prepare icon url import query");






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [125571] trunk/LayoutTests

[sergio]

Title: [125571] trunk/LayoutTests








Revision 125571
Author ser...@webkit.org
Date 2012-08-14 09:47:27 -0700 (Tue, 14 Aug 2012)


Log Message
Unreviewed, updated the GTK WK2 Skipped file with well-known
failures in the WK2 bot.

* platform/gtk-wk2/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk-wk2/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (125570 => 125571)

--- trunk/LayoutTests/ChangeLog	2012-08-14 16:36:02 UTC (rev 125570)
+++ trunk/LayoutTests/ChangeLog	2012-08-14 16:47:27 UTC (rev 125571)
@@ -1,3 +1,10 @@
+2012-08-14  Sergio Villar Senin  
+
+Unreviewed, updated the GTK WK2 Skipped file with well-known
+failures in the WK2 bot.
+
+* platform/gtk-wk2/Skipped:
+
 2012-08-14  Thiago Marcos P. Santos  
 
 [EFL] Gardening of failing tests and new passes


Modified: trunk/LayoutTests/platform/gtk-wk2/Skipped (125570 => 125571)

--- trunk/LayoutTests/platform/gtk-wk2/Skipped	2012-08-14 16:36:02 UTC (rev 125570)
+++ trunk/LayoutTests/platform/gtk-wk2/Skipped	2012-08-14 16:47:27 UTC (rev 125571)
@@ -39,6 +39,14 @@
 # TESTS TIMING OUT
 ###
 
+# Fullscreen tests timing out
+# http://webkit.org/b/93973
+fullscreen/anonymous-block-merge-crash.html
+fullscreen/full-screen-crash-offsetLeft.html
+fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent.html
+fullscreen/full-screen-line-boxes-crash.html
+fullscreen/full-screen-render-inline.html
+fullscreen/parent-flow-inline-with-block-child.html
 fullscreen/full-screen-keyboard-disabled.html
 fullscreen/full-screen-request.html
 fullscreen/full-screen-cancel.html
@@ -54,12 +62,17 @@
 fullscreen/full-screen-zIndex.html
 fullscreen/full-screen-remove-ancestor.html
 fullscreen/video-controls-override.html
+fullscreen/video-controls-timeline.html
 fullscreen/full-screen-iframe-allowed.html
 fullscreen/full-screen-twice.html
 fullscreen/full-screen-remove.html
 fullscreen/full-screen-zIndex-after.html
-plugins/fullscreen-plugins-dont-reload.html
-plugins/keyboard-events.html
+
+animations/fill-mode-forwards.html
+editing/deleting/delete-by-word-001.html
+editing/undo/undo-deleteWord.html
+editing/pasteboard/emacs-ctrl-a-k-y.html
+editing/input/emacs-ctrl-o.html
 fast/dom/access-key-iframe.html
 fast/events/access-key-self-destruct.html
 fast/events/keydown-numpad-keys.html
@@ -69,11 +82,11 @@
 fast/forms/listbox-selection.html
 fast/forms/listbox-typeahead-greek.html
 fast/forms/legend-access-key.html
+http/tests/xmlhttprequest/workers/abort-exception-assert.html
 platform/gtk/fast/forms/menulist-typeahead-find.html
-editing/deleting/delete-by-word-001.html
-editing/undo/undo-deleteWord.html
-editing/pasteboard/emacs-ctrl-a-k-y.html
-editing/input/emacs-ctrl-o.html
+plugins/document-open.html
+plugins/fullscreen-plugins-dont-reload.html
+plugins/keyboard-events.html
 
 ###
 # TESTS CRASHING
@@ -132,6 +145,12 @@
 accessibility/editable-webarea-context-menu-point.html
 plugins/mouse-events-fixedpos.html
 plugins/mouse-events.html
+fast/events/content-changed-during-drop.html
+fast/events/drag-and-drop-subframe-dataTransfer.html
+fast/events/drag-link.html
+fast/events/dropzone-002.html
+fast/events/selectstart-by-drag.html
+fast/forms/file/input-file-write-files.html
 fast/text/reset-drag-on-mouse-down.html
 fast/text/atsui-rtl-override-selection.html
 fast/writing-mode/japanese-rl-selection.html
@@ -183,12 +202,16 @@
 editing/pasteboard/drag-drop-url-text.html
 editing/pasteboard/drag-drop-input-textarea.html
 editing/pasteboard/drag-and-drop-objectimage-contenteditable.html
+editing/pasteboard/drop-file-svg.html
+editing/pasteboard/drop-link.html
+editing/pasteboard/smart-drag-drop.html
 editing/pasteboard/4947130.html
 editing/selection/drag-text-delay.html
 editing/selection/4895428-4.html
 editing/selection/4895428-1.html
 editing/selection/contains-boundaries.html
 editing/pasteboard/drop-text-events.html
+http/tests/local/blob/send-hybrid-blob.html
 svg/custom/mouse-move-on-svg-container-standalone.svg
 svg/custom/mouse-move-on-svg-container.xhtml
 svg/custom/mouse-move-on-svg-root-standalone.svg
@@ -256,6 +279,7 @@
 editing/pasteboard/copy-standalone-image-crash.html
 editing/selection/empty-cell-right-click.html
 editing/selection/button-right-click.html
+editing/selection/context-menu-on-text.html
 editing/selection/empty-cell-right-click.html
 editing/selection/select-across-readonly-input-1.html
 editing/selection/select-across-readonly-input-2.html
@@ -265,6 +289,7 @@
 editing/selection/select-out-of-floated-contenteditable.html
 editing/selection/select-out-of-floated-input.html
 editing/selection/select-out-of-floated-textarea.html
+media/controls-right-click-on-timebar.html
 platform/gtk/editing/pasteboard/middle-click-onpaste.html
 
 # Implement PageClientImpl::registerEditCommand and handling co

[webkit-changes] [125546] trunk/Tools

[sergio]

Title: [125546] trunk/Tools








Revision 125546
Author ser...@webkit.org
Date 2012-08-14 04:46:56 -0700 (Tue, 14 Aug 2012)


Log Message
[WK2] [GTK] Plugin tests failing in WK2 bot
https://bugs.webkit.org/show_bug.cgi?id=93954

Reviewed by Carlos Garcia Campos.

Plugin tests are failing in the WK2 bot because we aren't exporting
the Netscape plugin when creating the product archive.

* BuildSlaveSupport/built-product-archive: added TestNetscapePlugin
to the list of directories to export.
(archiveBuiltProduct):

Modified Paths

trunk/Tools/BuildSlaveSupport/built-product-archive
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/built-product-archive (125545 => 125546)

--- trunk/Tools/BuildSlaveSupport/built-product-archive	2012-08-14 11:43:44 UTC (rev 125545)
+++ trunk/Tools/BuildSlaveSupport/built-product-archive	2012-08-14 11:46:56 UTC (rev 125546)
@@ -145,7 +145,7 @@
 if platform == 'qt' or platform == 'efl':
 neededDirectories = ["bin", "lib"]
 elif platform == 'gtk':
-neededDirectories = ["Programs", ".libs", "Libraries"]
+neededDirectories = ["Programs", ".libs", "Libraries", "TestNetscapePlugin"]
 
 for dirname in neededDirectories:
 fromDir = os.path.join(configurationBuildDirectory, dirname, ".")


Modified: trunk/Tools/ChangeLog (125545 => 125546)

--- trunk/Tools/ChangeLog	2012-08-14 11:43:44 UTC (rev 125545)
+++ trunk/Tools/ChangeLog	2012-08-14 11:46:56 UTC (rev 125546)
@@ -1,3 +1,17 @@
+2012-08-14  Sergio Villar Senin  
+
+[WK2] [GTK] Plugin tests failing in WK2 bot
+https://bugs.webkit.org/show_bug.cgi?id=93954
+
+Reviewed by Carlos Garcia Campos.
+
+Plugin tests are failing in the WK2 bot because we aren't exporting
+the Netscape plugin when creating the product archive.
+
+* BuildSlaveSupport/built-product-archive: added TestNetscapePlugin
+to the list of directories to export.
+(archiveBuiltProduct):
+
 2012-08-14  Peter Beverloo  
 
 [Chromium] Fix apk generation for the Android platform






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo/webkit-changes

[webkit-changes] [125533] trunk

[sergio]

Title: [125533] trunk








Revision 125533
Author ser...@webkit.org
Date 2012-08-14 02:28:20 -0700 (Tue, 14 Aug 2012)


Log Message
[GTK] REGRESSION (r122428) WebKit2APITests/TestWebKitFindController fails "next" test
https://bugs.webkit.org/show_bug.cgi?id=91083

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

After r122428 search_next()/search_prev() should return just 1 match
if the text is found.

* UIProcess/API/gtk/tests/TestWebKitFindController.cpp:
(testFindControllerNext):
(testFindControllerPrevious):

Tools:

Unskipped a couple of API tests that should work fine from now on.

* Scripts/run-gtk-tests:
(TestRunner):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp
trunk/Tools/ChangeLog
trunk/Tools/Scripts/run-gtk-tests




Diff

Modified: trunk/Source/WebKit2/ChangeLog (125532 => 125533)

--- trunk/Source/WebKit2/ChangeLog	2012-08-14 09:21:21 UTC (rev 125532)
+++ trunk/Source/WebKit2/ChangeLog	2012-08-14 09:28:20 UTC (rev 125533)
@@ -1,3 +1,17 @@
+2012-08-14  Sergio Villar Senin  
+
+[GTK] REGRESSION (r122428) WebKit2APITests/TestWebKitFindController fails "next" test
+https://bugs.webkit.org/show_bug.cgi?id=91083
+
+Reviewed by Carlos Garcia Campos.
+
+After r122428 search_next()/search_prev() should return just 1 match
+if the text is found.
+
+* UIProcess/API/gtk/tests/TestWebKitFindController.cpp:
+(testFindControllerNext):
+(testFindControllerPrevious):
+
 2012-08-13  Carlos Garcia Campos  
 
 [GTK] Implement smart separators for context menu in WebKit2 GTK+


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp (125532 => 125533)

--- trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp	2012-08-14 09:21:21 UTC (rev 125532)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp	2012-08-14 09:28:20 UTC (rev 125533)
@@ -165,14 +165,14 @@
 test->waitUntilFindFinished();
 
 g_assert(test->m_textFound);
-g_assert(test->m_matchCount == 2);
+g_assert(test->m_matchCount == 1);
 g_assert(!(webkit_find_controller_get_options(test->m_findController.get()) & WEBKIT_FIND_OPTIONS_BACKWARDS));
 
 webkit_find_controller_search_next(test->m_findController.get());
 test->waitUntilFindFinished();
 
 g_assert(!test->m_textFound);
-g_assert(test->m_matchCount == 2);
+g_assert(test->m_matchCount == 1);
 g_assert(!(webkit_find_controller_get_options(test->m_findController.get()) & WEBKIT_FIND_OPTIONS_BACKWARDS));
 }
 
@@ -191,14 +191,14 @@
 test->waitUntilFindFinished();
 
 g_assert(test->m_textFound);
-g_assert(test->m_matchCount == 2);
+g_assert(test->m_matchCount == 1);
 g_assert(!(webkit_find_controller_get_options(test->m_findController.get()) & WEBKIT_FIND_OPTIONS_BACKWARDS));
 
 webkit_find_controller_search_previous(test->m_findController.get());
 test->waitUntilFindFinished();
 
 g_assert(test->m_textFound);
-g_assert(test->m_matchCount == 2);
+g_assert(test->m_matchCount == 1);
 g_assert(webkit_find_controller_get_options(test->m_findController.get()) & WEBKIT_FIND_OPTIONS_BACKWARDS);
 }
 


Modified: trunk/Tools/ChangeLog (125532 => 125533)

--- trunk/Tools/ChangeLog	2012-08-14 09:21:21 UTC (rev 125532)
+++ trunk/Tools/ChangeLog	2012-08-14 09:28:20 UTC (rev 125533)
@@ -1,3 +1,15 @@
+2012-08-14  Sergio Villar Senin  
+
+[GTK] REGRESSION (r122428) WebKit2APITests/TestWebKitFindController fails "next" test
+https://bugs.webkit.org/show_bug.cgi?id=91083
+
+Reviewed by Carlos Garcia Campos.
+
+Unskipped a couple of API tests that should work fine from now on.
+
+* Scripts/run-gtk-tests:
+(TestRunner):
+
 2012-08-14  Kristóf Kosztyó  
 
 [NRWT] Compare results between different platforms


Modified: trunk/Tools/Scripts/run-gtk-tests (125532 => 125533)

--- trunk/Tools/Scripts/run-gtk-tests	2012-08-14 09:21:21 UTC (rev 125532)
+++ trunk/Tools/Scripts/run-gtk-tests	2012-08-14 09:28:20 UTC (rev 125533)
@@ -67,8 +67,6 @@
 SkippedTest("unittests/testwebinspector", "/webkit/webinspector/close-and-inspect", "Test is flaky in GTK Linux 32-bit Release bot", 82869),
 SkippedTest("WebKit2APITests/TestWebKitWebView", "/webkit2/WebKitWebView/mouse-target", "Test is flaky in GTK Linux 32-bit Release bot", 82866),
 SkippedTest("WebKit2APITests/TestResources", "/webkit2/WebKitWebView/resources", "Test is flaky in GTK Linux 32-bit Release bot", 82868),
-SkippedTest("WebKit2APITests/TestWebKitFindController", "/webkit2/WebKitFindController/next", "Test fails ", 91083),
-SkippedTest(&q

[webkit-changes] [121886] trunk/Tools

[sergio]

Title: [121886] trunk/Tools








Revision 121886
Author ser...@webkit.org
Date 2012-07-05 00:24:21 -0700 (Thu, 05 Jul 2012)


Log Message
Hidden dirs are not copied when creating the built product archive
https://bugs.webkit.org/show_bug.cgi?id=90559

Reviewed by Carlos Garcia Campos.

Hidden dirs are not copied inside the built product archive
because the recursive copy command was ignoring them. We need those
hidden directories for the GTK WebKit2 testing bot to work fine.

* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct): replaced "*" by "." to include hidden
dirs/files.

Modified Paths

trunk/Tools/BuildSlaveSupport/built-product-archive
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/built-product-archive (121885 => 121886)

--- trunk/Tools/BuildSlaveSupport/built-product-archive	2012-07-05 07:04:16 UTC (rev 121885)
+++ trunk/Tools/BuildSlaveSupport/built-product-archive	2012-07-05 07:24:21 UTC (rev 121886)
@@ -147,7 +147,7 @@
 neededDirectories = ["Programs", ".libs", "Libraries"]
 
 for dirname in neededDirectories:
-fromDir = os.path.join(configurationBuildDirectory, dirname, "*")
+fromDir = os.path.join(configurationBuildDirectory, dirname, ".")
 toDir = os.path.join(thinDirectory, dirname)
 os.makedirs(toDir)
 if subprocess.call('cp -R %s %s' % (fromDir, toDir), shell=True):


Modified: trunk/Tools/ChangeLog (121885 => 121886)

--- trunk/Tools/ChangeLog	2012-07-05 07:04:16 UTC (rev 121885)
+++ trunk/Tools/ChangeLog	2012-07-05 07:24:21 UTC (rev 121886)
@@ -1,3 +1,18 @@
+2012-07-05  Sergio Villar Senin  
+
+Hidden dirs are not copied when creating the built product archive
+https://bugs.webkit.org/show_bug.cgi?id=90559
+
+Reviewed by Carlos Garcia Campos.
+
+Hidden dirs are not copied inside the built product archive
+because the recursive copy command was ignoring them. We need those
+hidden directories for the GTK WebKit2 testing bot to work fine.
+
+* BuildSlaveSupport/built-product-archive:
+(archiveBuiltProduct): replaced "*" by "." to include hidden
+dirs/files.
+
 2012-07-04  Yoshifumi Inoue  
 
 Unreviewed Chromium gardening, Disable always failed python tests on Windows.






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121862] trunk/Tools

[sergio]

Title: [121862] trunk/Tools








Revision 121862
Author ser...@webkit.org
Date 2012-07-04 09:43:03 -0700 (Wed, 04 Jul 2012)


Log Message
Hidden dirs are not copied when creating the built product archive
https://bugs.webkit.org/show_bug.cgi?id=90559

Reviewed by Carlos Garcia Campos.

Hidden dirs are not copied inside the built product archive because
the recursive copy command was ignoring them. We need those hidden
directories for the GTK WebKit2 testing bot to work fine.

* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct): removed the trailing "*" from the copy
command.

Modified Paths

trunk/Tools/BuildSlaveSupport/built-product-archive
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/built-product-archive (121861 => 121862)

--- trunk/Tools/BuildSlaveSupport/built-product-archive	2012-07-04 16:16:01 UTC (rev 121861)
+++ trunk/Tools/BuildSlaveSupport/built-product-archive	2012-07-04 16:43:03 UTC (rev 121862)
@@ -147,7 +147,7 @@
 neededDirectories = ["Programs", ".libs", "Libraries"]
 
 for dirname in neededDirectories:
-fromDir = os.path.join(configurationBuildDirectory, dirname, "*")
+fromDir = os.path.join(configurationBuildDirectory, dirname)
 toDir = os.path.join(thinDirectory, dirname)
 os.makedirs(toDir)
 if subprocess.call('cp -R %s %s' % (fromDir, toDir), shell=True):


Modified: trunk/Tools/ChangeLog (121861 => 121862)

--- trunk/Tools/ChangeLog	2012-07-04 16:16:01 UTC (rev 121861)
+++ trunk/Tools/ChangeLog	2012-07-04 16:43:03 UTC (rev 121862)
@@ -1,3 +1,18 @@
+2012-07-04  Sergio Villar Senin  
+
+Hidden dirs are not copied when creating the built product archive
+https://bugs.webkit.org/show_bug.cgi?id=90559
+
+Reviewed by Carlos Garcia Campos.
+
+Hidden dirs are not copied inside the built product archive because
+the recursive copy command was ignoring them. We need those hidden
+directories for the GTK WebKit2 testing bot to work fine.
+
+* BuildSlaveSupport/built-product-archive:
+(archiveBuiltProduct): removed the trailing "*" from the copy
+command.
+
 2012-07-04  John Mellor  
 
 Text Autosizing: Add compile flag and runtime setting






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121840] trunk/Tools

[sergio]

Title: [121840] trunk/Tools








Revision 121840
Author ser...@webkit.org
Date 2012-07-04 04:06:47 -0700 (Wed, 04 Jul 2012)


Log Message
[WK2] [GTK] WK2 testing bot unable to find the InjectedBundle library
https://bugs.webkit.org/show_bug.cgi?id=90541

Reviewed by Carlos Garcia Campos.

We must add the contents of WebKitBuild/*/Libraries/ directory to
the file to be uploaded to b.w.o to successfully run WebKit2 tests
in the WebKit2 testing bot.

* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct): appended Libraries to the list of
neededDirectories.

Modified Paths

trunk/Tools/BuildSlaveSupport/built-product-archive
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/built-product-archive (121839 => 121840)

--- trunk/Tools/BuildSlaveSupport/built-product-archive	2012-07-04 09:02:41 UTC (rev 121839)
+++ trunk/Tools/BuildSlaveSupport/built-product-archive	2012-07-04 11:06:47 UTC (rev 121840)
@@ -144,7 +144,7 @@
 if platform == 'qt' or platform == 'efl':
 neededDirectories = ["bin", "lib"]
 elif platform == 'gtk':
-neededDirectories = ["Programs", ".libs"]
+neededDirectories = ["Programs", ".libs", "Libraries"]
 
 for dirname in neededDirectories:
 fromDir = os.path.join(configurationBuildDirectory, dirname, "*")


Modified: trunk/Tools/ChangeLog (121839 => 121840)

--- trunk/Tools/ChangeLog	2012-07-04 09:02:41 UTC (rev 121839)
+++ trunk/Tools/ChangeLog	2012-07-04 11:06:47 UTC (rev 121840)
@@ -1,5 +1,20 @@
 2012-07-04  Sergio Villar Senin  
 
+[WK2] [GTK] WK2 testing bot unable to find the InjectedBundle library
+https://bugs.webkit.org/show_bug.cgi?id=90541
+
+Reviewed by Carlos Garcia Campos.
+
+We must add the contents of WebKitBuild/*/Libraries/ directory to
+the file to be uploaded to b.w.o to successfully run WebKit2 tests
+in the WebKit2 testing bot.
+
+* BuildSlaveSupport/built-product-archive:
+(archiveBuiltProduct): appended Libraries to the list of
+neededDirectories.
+
+2012-07-04  Sergio Villar Senin  
+
 [GTK] WebKit2 testing bot unable to find the build directory
 https://bugs.webkit.org/show_bug.cgi?id=90523
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121838] trunk/LayoutTests

[sergio]

Title: [121838] trunk/LayoutTests








Revision 121838
Author ser...@webkit.org
Date 2012-07-04 01:31:23 -0700 (Wed, 04 Jul 2012)


Log Message
Unreviewed GTK gardening. Removed some tests from TestExpectations
as they were passing in the tree bots.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (121837 => 121838)

--- trunk/LayoutTests/ChangeLog	2012-07-04 08:05:18 UTC (rev 121837)
+++ trunk/LayoutTests/ChangeLog	2012-07-04 08:31:23 UTC (rev 121838)
@@ -1,3 +1,10 @@
+2012-07-04  Sergio Villar Senin  
+
+Unreviewed GTK gardening. Removed some tests from TestExpectations
+as they were passing in the tree bots.
+
+* platform/gtk/TestExpectations:
+
 2012-07-04  Sheriff Bot  
 
 Unreviewed, rolling out r121813.


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (121837 => 121838)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2012-07-04 08:05:18 UTC (rev 121837)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2012-07-04 08:31:23 UTC (rev 121838)
@@ -304,6 +304,7 @@
 // These tests require subpixel layout to be enabled
 BUGWK85532 : fast/sub-pixel = TEXT IMAGE
 BUGWK85532 : fast/sub-pixel/float-containing-block-with-margin.html = PASS
+BUGWK85532 : fast/sub-pixel/float-with-margin-in-container.html = PASS
 BUGWK85532 : fast/sub-pixel/float-with-right-margin-zoom.html = PASS
 BUGWK85532 : fast/sub-pixel/float-wrap-with-subpixel-top.html = PASS
 BUGWK85532 : fast/sub-pixel/inline-block-with-margin.html = PASS
@@ -953,8 +954,6 @@
 BUGWK50740 : editing/spelling/spellcheck-sequencenum.html = TEXT
 BUGWK50740 : editing/spelling/spellcheck-async-mutation.html = TEXT
 
-BUGWK82675 : http/tests/local/link-stylesheet-load-order.html = TEXT
-
 // DRT does not obey layoutTestController.addURLToRedirect()
 BUGWKGTK : http/tests/loading/cross-origin-XHR-willLoadRequest.html = TEXT
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121837] trunk/Tools

[sergio]

Title: [121837] trunk/Tools








Revision 121837
Author ser...@webkit.org
Date 2012-07-04 01:05:18 -0700 (Wed, 04 Jul 2012)


Log Message
[GTK] WebKit2 testing bot unable to find the build directory
https://bugs.webkit.org/show_bug.cgi?id=90523

Reviewed by Carlos Garcia Campos.

The presence of GNUmakefile was used to determine whether a given
directory was a valid build directory or not. That's not correct for
testing bots as we export only the minimum required stuff to run the
tests.

* gtk/common.py:
(get_build_path.is_valid_build_directory): added an extra check.:

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/gtk/common.py




Diff

Modified: trunk/Tools/ChangeLog (121836 => 121837)

--- trunk/Tools/ChangeLog	2012-07-04 07:53:20 UTC (rev 121836)
+++ trunk/Tools/ChangeLog	2012-07-04 08:05:18 UTC (rev 121837)
@@ -1,3 +1,18 @@
+2012-07-04  Sergio Villar Senin  
+
+[GTK] WebKit2 testing bot unable to find the build directory
+https://bugs.webkit.org/show_bug.cgi?id=90523
+
+Reviewed by Carlos Garcia Campos.
+
+The presence of GNUmakefile was used to determine whether a given
+directory was a valid build directory or not. That's not correct for
+testing bots as we export only the minimum required stuff to run the
+tests.
+
+* gtk/common.py:
+(get_build_path.is_valid_build_directory): added an extra check.:
+
 2012-07-04  Joe Thomas  
 
 Adding myself to committers list.


Modified: trunk/Tools/gtk/common.py (121836 => 121837)

--- trunk/Tools/gtk/common.py	2012-07-04 07:53:20 UTC (rev 121836)
+++ trunk/Tools/gtk/common.py	2012-07-04 08:05:18 UTC (rev 121837)
@@ -40,7 +40,8 @@
 return build_dir
 
 def is_valid_build_directory(path):
-return os.path.exists(os.path.join(path, 'GNUmakefile'))
+return os.path.exists(os.path.join(path, 'GNUmakefile')) or \
+os.path.exists(os.path.join(path, 'Programs', 'DumpRenderTree'))
 
 if len(sys.argv[1:]) > 1 and os.path.exists(sys.argv[-1]) and is_valid_build_directory(sys.argv[-1]):
 return sys.argv[-1]






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121345] trunk/Tools

[sergio]

Title: [121345] trunk/Tools








Revision 121345
Author ser...@webkit.org
Date 2012-06-27 08:52:00 -0700 (Wed, 27 Jun 2012)


Log Message
[WK2] [GTK] WebKit2 testing bot fails to run tests due to missing files
https://bugs.webkit.org/show_bug.cgi?id=90061

Reviewed by Gustavo Noronha Silva.

Add "-no-install -no-fast-install" to the LDFLAGS in bots. With
this flag libtool tells the linker to set the rpath for the output
file to the full path of the .libs directory, instead of using a
wrapper script to set up the LD_LIBRARY_PATH. This will allow us
to directly reuse builds in the pure testing bots.

* BuildSlaveSupport/gtk/daemontools-buildbot.conf:

Modified Paths

trunk/Tools/BuildSlaveSupport/gtk/daemontools-buildbot.conf
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/gtk/daemontools-buildbot.conf (121344 => 121345)

--- trunk/Tools/BuildSlaveSupport/gtk/daemontools-buildbot.conf	2012-06-27 15:18:07 UTC (rev 121344)
+++ trunk/Tools/BuildSlaveSupport/gtk/daemontools-buildbot.conf	2012-06-27 15:52:00 UTC (rev 121345)
@@ -40,5 +40,6 @@
 #
 env_CFLAGS="-pipe"
 env_CXXFLAGS="-pipe"
+env_LDFLAGS="-no-install -no-fast-install"
 env_WEBKIT_TESTFONTS="/home/${buildbot_user}/testfonts"
 


Modified: trunk/Tools/ChangeLog (121344 => 121345)

--- trunk/Tools/ChangeLog	2012-06-27 15:18:07 UTC (rev 121344)
+++ trunk/Tools/ChangeLog	2012-06-27 15:52:00 UTC (rev 121345)
@@ -1,3 +1,18 @@
+2012-06-27  Sergio Villar Senin  
+
+[WK2] [GTK] WebKit2 testing bot fails to run tests due to missing files
+https://bugs.webkit.org/show_bug.cgi?id=90061
+
+Reviewed by Gustavo Noronha Silva.
+
+Add "-no-install -no-fast-install" to the LDFLAGS in bots. With
+this flag libtool tells the linker to set the rpath for the output
+file to the full path of the .libs directory, instead of using a
+wrapper script to set up the LD_LIBRARY_PATH. This will allow us
+to directly reuse builds in the pure testing bots.
+
+* BuildSlaveSupport/gtk/daemontools-buildbot.conf:
+
 2012-06-27  Tor Arne Vestbø  
 
 [Qt] No need to save and restore TEMPLATE in a function






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [121089] trunk/Tools

[sergio]

Title: [121089] trunk/Tools








Revision 121089
Author ser...@webkit.org
Date 2012-06-23 00:49:49 -0700 (Sat, 23 Jun 2012)


Log Message
[GTK] Add a new webkit2 tests slave bot
https://bugs.webkit.org/show_bug.cgi?id=89336

Reviewed by Csaba Osztrogonác.

Slave configuration for a new GTK 64 bit release bot that will run
WebKit2 tests.

Also BuildAndTest now accepts the "triggers" parametter,
this means that apart from building and testing it can trigger
some other build/test sequences in other slaves.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(BuildAndTestFactory.__init__):

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (121088 => 121089)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2012-06-23 07:18:00 UTC (rev 121088)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2012-06-23 07:49:49 UTC (rev 121089)
@@ -29,6 +29,7 @@
 { "name": "gtk-linux-slave-1", "platform": "gtk"},
 { "name": "gtk-linux-slave-2", "platform": "gtk"},
 { "name": "gtk-linux-slave-3", "platform": "gtk"},
+{ "name": "gtk-linux-slave-4", "platform": "gtk"},
 
 { "name": "szeged-linux-1", "platform": "qt-4.8"},
 { "name": "szeged-linux-2", "platform": "qt-4.8"},
@@ -139,6 +140,7 @@
 {
   "name": "GTK Linux 64-bit Release", "type": "BuildAndTest", "builddir": "gtk-linux-64-release",
   "platform": "gtk", "configuration": "release", "architectures": ["x86_64"],
+  "triggers": ["gtk-linux-64-release-tests-wk2"],
   "slavenames": ["gtk-linux-slave-2"]
 },
 {
@@ -147,6 +149,11 @@
   "slavenames": ["gtk-linux-slave-3"]
 },
 {
+  "name": "GTK Linux 64-bit Release WK2 (Tests)", "type": "TestWebKit2", "builddir": "gtk-linux-64-release-tests-wk2",
+  "platform": "gtk", "configuration": "release", "architectures": ["x86_64"],
+  "slavenames": ["gtk-linux-slave-4"]
+},
+{
   "name": "Qt Linux Release", "type": "BuildAndTest", "builddir": "qt-linux-release",
   "platform": "qt-4.8", "configuration": "release", "architectures": ["i386"],
   "slavenames": ["szeged-linux-1"]
@@ -334,6 +341,9 @@
 },
 { "type": "Triggerable", "name": "chromium-linux-perf-tests",
   "builderNames": ["Chromium Linux Release (Perf)"]
+},
+{ "type": "Triggerable", "name": "gtk-linux-64-release-tests-wk2",
+  "builderNames": ["GTK Linux 64-bit Release WK2 (Tests)"]
 }
   ]
 }


Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg (121088 => 121089)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2012-06-23 07:18:00 UTC (rev 121088)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg	2012-06-23 07:49:49 UTC (rev 121089)
@@ -729,7 +729,7 @@
 class BuildAndTestFactory(Factory):
 TestClass = RunWebKitTests
 ExtractTestResultsClass = ExtractTestResults
-def __init__(self, platform, configuration, architectures, **kwargs):
+def __init__(self, platform, configuration, architectures, triggers=None, **kwargs):
 Factory.__init__(self, platform, configuration, architectures, False, **kwargs)
 if platform.startswith("chromium"):
 self.addStep(CleanupChromiumCrashLogs)
@@ -754,6 +754,10 @@
 self.addStep(RunGtkAPITests)
 if platform.startswith("qt"):
 self.addStep(Run

[webkit-changes] [121015] trunk/Source/WebKit2

[sergio]

Title: [121015] trunk/Source/WebKit2








Revision 121015
Author ser...@webkit.org
Date 2012-06-22 02:54:28 -0700 (Fri, 22 Jun 2012)


Log Message
[WK2] FindController::hideFindUI should unmark highlighted text matches
https://bugs.webkit.org/show_bug.cgi?id=77747

Reviewed by Carlos Garcia Campos.

Unmark all text matches whenever FindController::hideFindUI is
called to allow callers using the ShowHighlight find option to
remove highlighting.

This patch enables a unit test for the WebKitFindController
previously guarded by a #if(0) after r109222.

* UIProcess/API/gtk/tests/TestWebKitFindController.cpp:
(testFindControllerHide):
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::hideFindUI):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp
trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (121014 => 121015)

--- trunk/Source/WebKit2/ChangeLog	2012-06-22 09:39:54 UTC (rev 121014)
+++ trunk/Source/WebKit2/ChangeLog	2012-06-22 09:54:28 UTC (rev 121015)
@@ -1,3 +1,22 @@
+2012-06-22  Sergio Villar Senin  
+
+[WK2] FindController::hideFindUI should unmark highlighted text matches
+https://bugs.webkit.org/show_bug.cgi?id=77747
+
+Reviewed by Carlos Garcia Campos.
+
+Unmark all text matches whenever FindController::hideFindUI is
+called to allow callers using the ShowHighlight find option to
+remove highlighting.
+
+This patch enables a unit test for the WebKitFindController
+previously guarded by a #if(0) after r109222.
+
+* UIProcess/API/gtk/tests/TestWebKitFindController.cpp:
+(testFindControllerHide):
+* WebProcess/WebPage/FindController.cpp:
+(WebKit::FindController::hideFindUI):
+
 2012-06-21  Christophe Dumez  
 
 [WK2] Add C API to inspect a Web Intent


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp (121014 => 121015)

--- trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp	2012-06-22 09:39:54 UTC (rev 121014)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp	2012-06-22 09:54:28 UTC (rev 121015)
@@ -324,8 +324,6 @@
 g_assert(highlightPixbuf);
 g_assert(!gdkPixbufEqual(originalPixbuf.get(), highlightPixbuf.get()));
 
-#if (0)
-// Requires http://webkit.org/b/77747 to be fixed
 WebKitFindController* findController = webkit_web_view_get_find_controller(test->m_webView);
 webkit_find_controller_search_finish(findController);
 webkit_web_view_execute_editing_command(test->m_webView, "Unselect");
@@ -334,7 +332,6 @@
 GRefPtr unhighlightPixbuf = gdk_pixbuf_get_from_window(webViewGdkWindow, 0, 0, allocatedHeight, allocatedWidth);
 g_assert(unhighlightPixbuf);
 g_assert(gdkPixbufEqual(originalPixbuf.get(), unhighlightPixbuf.get()));
-#endif
 }
 
 static void testFindControllerInstance(FindControllerTest* test, gconstpointer)


Modified: trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp (121014 => 121015)

--- trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp	2012-06-22 09:39:54 UTC (rev 121014)
+++ trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp	2012-06-22 09:54:28 UTC (rev 121015)
@@ -164,6 +164,7 @@
 if (m_findPageOverlay)
 m_webPage->uninstallPageOverlay(m_findPageOverlay, false);
 
+m_webPage->corePage()->unmarkAllTextMatches();
 hideFindIndicator();
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [120937] trunk/Tools

[sergio]

Title: [120937] trunk/Tools








Revision 120937
Author ser...@webkit.org
Date 2012-06-21 10:25:59 -0700 (Thu, 21 Jun 2012)


Log Message
[GTK] Add a new webkit2 tests slave bot
https://bugs.webkit.org/show_bug.cgi?id=89336

Reviewed by Philippe Normand.

Slave configuration for a new GTK bot that will run WebKit2 tests.

* BuildSlaveSupport/build.webkit.org-config/config.json:

Modified Paths

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
trunk/Tools/ChangeLog




Diff

Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json (120936 => 120937)

--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2012-06-21 17:21:44 UTC (rev 120936)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json	2012-06-21 17:25:59 UTC (rev 120937)
@@ -29,6 +29,7 @@
 { "name": "gtk-linux-slave-1", "platform": "gtk"},
 { "name": "gtk-linux-slave-2", "platform": "gtk"},
 { "name": "gtk-linux-slave-3", "platform": "gtk"},
+{ "name": "gtk-linux-slave-4", "platform": "gtk"},
 
 { "name": "szeged-linux-1", "platform": "qt-4.8"},
 { "name": "szeged-linux-2", "platform": "qt-4.8"},
@@ -139,7 +140,7 @@
 {
   "name": "GTK Linux 64-bit Release", "type": "BuildAndTest", "builddir": "gtk-linux-64-release",
   "platform": "gtk", "configuration": "release", "architectures": ["x86_64"],
-  "slavenames": ["gtk-linux-slave-2"]
+  "slavenames": ["gtk-linux-slave-2"], "triggers": ["gtk-linux-64-release-tests-wk2"]
 },
 {
   "name": "GTK Linux 64-bit Debug", "type": "BuildAndTest", "builddir": "gtk-linux-64-debug",
@@ -147,6 +148,11 @@
   "slavenames": ["gtk-linux-slave-3"]
 },
 {
+  "name": "GTK Linux 64-bit Release WK2 (Tests)", "type": "TestWebKit2", "builddir": "gtk-linux-64-release-tests-wk2",
+  "platform": "gtk", "configuration": "release", "architectures": ["x86_64"],
+  "slavenames": ["gtk-linux-slave-4"]
+},
+{
   "name": "Qt Linux Release", "type": "BuildAndTest", "builddir": "qt-linux-release",
   "platform": "qt-4.8", "configuration": "release", "architectures": ["i386"],
   "slavenames": ["szeged-linux-1"]
@@ -334,6 +340,9 @@
 },
 { "type": "Triggerable", "name": "chromium-linux-perf-tests",
   "builderNames": ["Chromium Linux Release (Perf)"]
+},
+{ "type": "Triggerable", "name": "gtk-linux-64-release-tests-wk2",
+  "builderNames": ["GTK Linux 64-bit Release WK2 (Tests)"]
 }
   ]
 }


Modified: trunk/Tools/ChangeLog (120936 => 120937)

--- trunk/Tools/ChangeLog	2012-06-21 17:21:44 UTC (rev 120936)
+++ trunk/Tools/ChangeLog	2012-06-21 17:25:59 UTC (rev 120937)
@@ -1,3 +1,14 @@
+2012-06-21  Sergio Villar Senin  
+
+[GTK] Add a new webkit2 tests slave bot
+https://bugs.webkit.org/show_bug.cgi?id=89336
+
+Reviewed by Philippe Normand.
+
+Slave configuration for a new GTK bot that will run WebKit2 tests.
+
+* BuildSlaveSupport/build.webkit.org-config/config.json:
+
 2012-06-21  Thiago Marcos P. Santos  
 
 [Qt] Add a custom Color Chooser widget to MiniBrowser






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [120812] trunk/LayoutTests

[sergio]

Title: [120812] trunk/LayoutTests








Revision 120812
Author ser...@webkit.org
Date 2012-06-20 01:47:23 -0700 (Wed, 20 Jun 2012)


Log Message
Unreviewed GTK gardening. Removed some tests from TestExpectations
as they were passing in the tree bots.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (120811 => 120812)

--- trunk/LayoutTests/ChangeLog	2012-06-20 07:54:17 UTC (rev 120811)
+++ trunk/LayoutTests/ChangeLog	2012-06-20 08:47:23 UTC (rev 120812)
@@ -1,3 +1,10 @@
+2012-06-20  Sergio Villar Senin  
+
+Unreviewed GTK gardening. Removed some tests from TestExpectations
+as they were passing in the tree bots.
+
+* platform/gtk/TestExpectations:
+
 2012-06-20  Hajime Morrita  
 
 Unreviewed rebaselining.


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (120811 => 120812)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2012-06-20 07:54:17 UTC (rev 120811)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2012-06-20 08:47:23 UTC (rev 120812)
@@ -148,7 +148,6 @@
 
 // Web Timing issues.
 BUGWKGTK : fast/dom/Window/window-properties-performance.html = TEXT
-BUGWKGTK : http/tests/misc/webtiming-origins.html = TEXT
 
 // FileSystem API is not supported.
 BUGWKGTK SKIP : fast/filesystem = TEXT
@@ -309,6 +308,8 @@
 BUGWK85532 : fast/sub-pixel/inline-block-with-margin.html = PASS
 BUGWK85532 : fast/sub-pixel/file-upload-control-at-fractional-offset.html = PASS
 BUGWK85532 : fast/sub-pixel/column-clipping.html = PASS
+BUGWK85532 : fast/sub-pixel/table-cells-with-padding-do-not-wrap.html = PASS
+BUGWK85532 : fast/sub-pixel/table-rows-have-stable-height.html = PASS
 
 // Mediastream implementation is not complete yet.
 BUGWK79203 SKIP : fast/mediastream = TEXT
@@ -1099,7 +1100,6 @@
 BUGWK83912 : ietestcenter/css3/grid/grid-items-002.htm = IMAGE
 BUGWK83913 : ietestcenter/css3/grid/grid-items-003.htm = IMAGE
 
-BUGWK86971 : svg/hittest/svg-ellipse-non-scale-stroke.xhtml = TEXT
 BUGWK86971 : svg/custom/non-scaling-stroke.svg = TEXT
 
 BUGWK84678 : fast/spatial-navigation/snav-container-white-space.html = TEXT
@@ -1214,9 +1214,6 @@
 
 BUGWK89205 : editing/spelling/grammar-edit-word.html = TEXT
 
-BUGWK54637 : media/video-display-toggle.html = TEXT
-BUGWK54637 : media/controls-after-reload.html = TEXT
-
 BUGWK89084 : fast/forms/text-input-event.html = PASS TEXT
 
 BUGWK83683 : editing/pasteboard/pasting-empty-html-falls-back-to-text.html = PASS TEXT






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [120694] trunk/Source

[sergio]

Title: [120694] trunk/Source








Revision 120694
Author ser...@webkit.org
Date 2012-06-19 01:55:09 -0700 (Tue, 19 Jun 2012)


Log Message
Calling nativeImageForCurrentFrame() causes assertion failure: m_verifier.isSafeToUse()
https://bugs.webkit.org/show_bug.cgi?id=67582

Reviewed by David Levin.

Source/WebCore:

Added a new synchronous method to the IconDatabase that returns a
native image for the platform instead of a WebCore::Image*.

* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::synchronousNativeIconForPageURL):
(WebCore):
* loader/icon/IconDatabase.h:
(IconDatabase):
* loader/icon/IconDatabaseBase.h:
(WebCore::IconDatabaseBase::synchronousNativeIconForPageURL):
(IconDatabaseBase):

Source/WebKit/blackberry:

Use synchronousNativeIconForPageURL() to retrieve favicons.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):

Source/WebKit/cf:

Fixes windows build.

* WebCoreSupport/WebInspectorClientCF.cpp:

Source/WebKit/efl:

Use synchronousNativeIconForPageURL() to retrieve favicons.

* ewk/ewk_history.cpp:
(ewk_history_item_icon_surface_get):
(ewk_history_item_icon_object_add):
* ewk/ewk_settings.cpp:
(ewk_settings_icon_database_icon_surface_get):
(ewk_settings_icon_database_icon_object_add):

Source/WebKit/gtk:

Use synchronousNativeIconForPageURL() to retrieve favicons.

* webkit/webkitfavicondatabase.cpp:
(getIconPixbufSynchronously):

Source/WebKit/qt:

Use synchronousNativeIconForPageURL() to retrieve favicons.

* Api/qwebhistory.cpp:
(QWebHistoryItem::icon):
* Api/qwebsettings.cpp:
(QWebSettings::iconForUrl):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/loader/icon/IconDatabase.cpp
trunk/Source/WebCore/loader/icon/IconDatabase.h
trunk/Source/WebCore/loader/icon/IconDatabaseBase.h
trunk/Source/WebKit/blackberry/ChangeLog
trunk/Source/WebKit/blackberry/WebCoreSupport/FrameLoaderClientBlackBerry.cpp
trunk/Source/WebKit/cf/ChangeLog
trunk/Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp
trunk/Source/WebKit/efl/ChangeLog
trunk/Source/WebKit/efl/ewk/ewk_history.cpp
trunk/Source/WebKit/efl/ewk/ewk_settings.cpp
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/webkit/webkitfavicondatabase.cpp
trunk/Source/WebKit/qt/Api/qwebhistory.cpp
trunk/Source/WebKit/qt/Api/qwebsettings.cpp
trunk/Source/WebKit/qt/ChangeLog
trunk/Source/WebKit2/UIProcess/WebIconDatabase.cpp
trunk/Source/WebKit2/UIProcess/WebIconDatabase.h
trunk/Source/WebKit2/UIProcess/qt/QtWebIconDatabaseClient.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (120693 => 120694)

--- trunk/Source/WebCore/ChangeLog	2012-06-19 08:45:40 UTC (rev 120693)
+++ trunk/Source/WebCore/ChangeLog	2012-06-19 08:55:09 UTC (rev 120694)
@@ -1,3 +1,22 @@
+2012-06-19  Sergio Villar Senin  
+
+Calling nativeImageForCurrentFrame() causes assertion failure: m_verifier.isSafeToUse()
+https://bugs.webkit.org/show_bug.cgi?id=67582
+
+Reviewed by David Levin.
+
+Added a new synchronous method to the IconDatabase that returns a
+native image for the platform instead of a WebCore::Image*.
+
+* loader/icon/IconDatabase.cpp:
+(WebCore::IconDatabase::synchronousNativeIconForPageURL):
+(WebCore):
+* loader/icon/IconDatabase.h:
+(IconDatabase):
+* loader/icon/IconDatabaseBase.h:
+(WebCore::IconDatabaseBase::synchronousNativeIconForPageURL):
+(IconDatabaseBase):
+
 2012-06-19  Andy Estes  
 
 [Mac] Use AutodrainedPool instead of NSAutoreleasePool in AudioBus::loadPlatformResource()


Modified: trunk/Source/WebCore/loader/icon/IconDatabase.cpp (120693 => 120694)

--- trunk/Source/WebCore/loader/icon/IconDatabase.cpp	2012-06-19 08:45:40 UTC (rev 120693)
+++ trunk/Source/WebCore/loader/icon/IconDatabase.cpp	2012-06-19 08:55:09 UTC (rev 120694)
@@ -34,6 +34,7 @@
 #include "FileSystem.h"
 #include "IconDatabaseClient.h"
 #include "IconRecord.h"
+#include "Image.h"
 #include "IntSize.h"
 #include "Logging.h"
 #include "SQLiteStatement.h"
@@ -292,6 +293,16 @@
 return iconRecord->image(size);
 }
 
+NativeImagePtr IconDatabase::synchronousNativeIconForPageURL(const String& pageURLOriginal, const IntSize& size)
+{
+Image* icon = synchronousIconForPageURL(pageURLOriginal, size);
+if (!icon)
+return 0;
+
+MutexLocker locker(m_urlAndIconLock);
+return icon->nativeImageForCurrentFrame();
+}
+
 void IconDatabase::readIconForPageURLFromDisk(const String& pageURL)
 {
 // The effect of asking for an Icon for a pageURL automatically queues it to be read from disk


Modified: trunk/Source/WebCore/loader/icon/IconDatabase.h (120693 => 120694)

--- trunk/Source/WebCore/loader/icon/IconDatabase.h	2012-06-19 08:45:40 UTC (rev 120693)
+++ trunk/Source/WebCore/loader/icon/IconDatabase.h	2012-06-19 08:55:09 UTC (rev 120694)
@@ -97,6 +97,7 @@
 virt

[webkit-changes] [120577] trunk/Source/WebCore

[sergio]

Title: [120577] trunk/Source/WebCore








Revision 120577
Author ser...@webkit.org
Date 2012-06-18 01:12:50 -0700 (Mon, 18 Jun 2012)


Log Message
TextureMapperLayer: invisible layers do not let their children to be painted
https://bugs.webkit.org/show_bug.cgi?id=88786

Reviewed by Noam Rosenthal.

Do not early discard recursively painting children layers if the
current layer is not visible.

Changes already covered by compositing tests. This fixes both
compositing/backface-visibility/backface-visibility-3d.html and
compositing/backface-visibility/backface-visibility-non3d.html.

* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::computeTransformsRecursive):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::isVisible):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (120576 => 120577)

--- trunk/Source/WebCore/ChangeLog	2012-06-18 07:25:43 UTC (rev 120576)
+++ trunk/Source/WebCore/ChangeLog	2012-06-18 08:12:50 UTC (rev 120577)
@@ -1,3 +1,22 @@
+2012-06-18  Sergio Villar Senin  
+
+TextureMapperLayer: invisible layers do not let their children to be painted
+https://bugs.webkit.org/show_bug.cgi?id=88786
+
+Reviewed by Noam Rosenthal.
+
+Do not early discard recursively painting children layers if the
+current layer is not visible.
+
+Changes already covered by compositing tests. This fixes both
+compositing/backface-visibility/backface-visibility-3d.html and
+compositing/backface-visibility/backface-visibility-non3d.html.
+
+* platform/graphics/texmap/TextureMapperLayer.cpp:
+(WebCore::TextureMapperLayer::computeTransformsRecursive):
+(WebCore::TextureMapperLayer::paintSelf):
+(WebCore::TextureMapperLayer::isVisible):
+
 2012-06-15  Kinuko Yasuda  
 
 XHR_RESPONSE_BLOB is not enabled on some platforms


Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp (120576 => 120577)

--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp	2012-06-18 07:25:43 UTC (rev 120576)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp	2012-06-18 08:12:50 UTC (rev 120577)
@@ -77,7 +77,7 @@
 parentTransform = m_effectTarget->m_transform.combined();
 m_transform.combineTransforms(parentTransform);
 
-m_state.visible = m_state.backfaceVisibility || m_transform.combined().inverse().m33() >= 0;
+m_state.visible = m_state.backfaceVisibility || !m_transform.combined().isBackFaceVisible();
 
 if (m_parent && m_parent->m_state.preserves3D)
 m_centerZ = m_transform.combined().mapPoint(FloatPoint3D(m_size.width() / 2, m_size.height() / 2, 0)).z();
@@ -154,6 +154,9 @@
 
 void TextureMapperLayer::paintSelf(const TextureMapperPaintOptions& options)
 {
+if (!m_state.visible)
+return;
+
 // We apply the following transform to compensate for painting into a surface, and then apply the offset so that the painting fits in the target rect.
 TransformationMatrix transform;
 transform.translate(options.offset.width(), options.offset.height());
@@ -286,8 +289,10 @@
 {
 if (m_size.isEmpty() && (m_state.masksToBounds || m_state.maskLayer || m_children.isEmpty()))
 return false;
-if (!m_state.visible || m_opacity < 0.01)
+if (!m_state.visible && m_children.isEmpty())
 return false;
+if (m_opacity < 0.01)
+return false;
 return true;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [120187] trunk/LayoutTests

[sergio]

Title: [120187] trunk/LayoutTests








Revision 120187
Author ser...@webkit.org
Date 2012-06-13 05:04:50 -0700 (Wed, 13 Jun 2012)


Log Message
Unreviewed gardening. Removed some tests passing in all the GTK
bots from the test expectations file.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (120186 => 120187)

--- trunk/LayoutTests/ChangeLog	2012-06-13 11:51:16 UTC (rev 120186)
+++ trunk/LayoutTests/ChangeLog	2012-06-13 12:04:50 UTC (rev 120187)
@@ -1,3 +1,10 @@
+2012-06-13  Sergio Villar Senin  
+
+Unreviewed gardening. Removed some tests passing in all the GTK
+bots from the test expectations file.
+
+* platform/gtk/TestExpectations:
+
 2012-06-12  Hans Wennborg  
 
 Speech _javascript_ API: Add test for constructing SpeechRecognitionError events


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (120186 => 120187)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2012-06-13 11:51:16 UTC (rev 120186)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2012-06-13 12:04:50 UTC (rev 120187)
@@ -310,6 +310,7 @@
 BUGWK85532 : fast/sub-pixel/float-wrap-with-subpixel-top.html = PASS
 BUGWK85532 : fast/sub-pixel/inline-block-with-margin.html = PASS
 BUGWK85532 : fast/sub-pixel/file-upload-control-at-fractional-offset.html = PASS
+BUGWK85532 : fast/sub-pixel/column-clipping.html = PASS
 
 // Mediastream implementation is not complete yet.
 BUGWK79203 SKIP : fast/mediastream = TEXT
@@ -505,8 +506,6 @@
 
 BUGWKGTK : fast/css/user-drag-none.html = TIMEOUT
 
-BUGWK54119 : http/tests/misc/acid2.html = TIMEOUT
-
 BUGWK84676 SKIP : fast/files/workers/worker-read-blob-async.html = TIMEOUT
 BUGWK84676 SKIP : fast/files/workers/worker-read-blob-sync.html = TIMEOUT
 BUGWK84676 SKIP : fast/files/workers/worker-read-file-async.html = TIMEOUT
@@ -1146,7 +1145,6 @@
 BUGWK73409 : fast/forms/textarea/textarea-placeholder-paint-order.html = MISSING
 BUGWK73409 : fast/forms/input-placeholder-paint-order.html = MISSING
 
-BUGWK73653 : fast/forms/number/spin-in-multi-column.html = TEXT
 BUGWK73653 : fast/forms/range/slider-in-multi-column.html = TEXT
 
 BUGWK74276 : fast/events/dont-loose-last-event.html = TEXT
@@ -1307,8 +1305,6 @@
 
 BUGWK88138 : http/tests/media/video-buffered.html = TEXT
 
-BUGWK88643 RELEASE : jquery/core.html = TEXT
-
 //
 // End of Tests failing
 //






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [119577] trunk/LayoutTests

[sergio]

Title: [119577] trunk/LayoutTests








Revision 119577
Author ser...@webkit.org
Date 2012-06-06 03:04:20 -0700 (Wed, 06 Jun 2012)


Log Message
Unreviewed, updated TestExpectations after several tests have been
regularly passing in the 3 GTK bots for some time.

* platform/gtk/TestExpectations:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/TestExpectations




Diff

Modified: trunk/LayoutTests/ChangeLog (119576 => 119577)

--- trunk/LayoutTests/ChangeLog	2012-06-06 09:57:52 UTC (rev 119576)
+++ trunk/LayoutTests/ChangeLog	2012-06-06 10:04:20 UTC (rev 119577)
@@ -1,3 +1,10 @@
+2012-06-06  Sergio Villar Senin  
+
+Unreviewed, updated TestExpectations after several tests have been
+regularly passing in the 3 GTK bots for some time.
+
+* platform/gtk/TestExpectations:
+
 2012-06-06  Dominik Röttsches  
 
 [EFL] Turning the bot into a springtime green


Modified: trunk/LayoutTests/platform/gtk/TestExpectations (119576 => 119577)

--- trunk/LayoutTests/platform/gtk/TestExpectations	2012-06-06 09:57:52 UTC (rev 119576)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2012-06-06 10:04:20 UTC (rev 119577)
@@ -125,11 +125,14 @@
 
 // ENABLE_INPUT_TYPE_* are not enabled.
 BUGWK29359 : fast/forms/date = FAIL
+BUGWK29359 : fast/forms/date/date-stepup-stepdown-from-renderer.html = PASS
+BUGWK29359 : fast/forms/date/no-page-popup-controller.html = PASS
 BUGWK29359 : fast/css/pseudo-in-range.html = FAIL
 BUGWK29359 : fast/css/pseudo-out-of-range.html = FAIL
 BUGWK29359 : fast/css/pseudo-in-range-invalid-value.html = FAIL
 BUGWK29359 : fast/forms/datetime = FAIL
 BUGWK29359 : fast/forms/datetimelocal = FAIL
+BUGWK29359 : fast/forms/datetimelocal/input-valueasdate-datetimelocal.html = PASS
 BUGWK29359 : fast/forms/month = FAIL
 BUGWK29359 : fast/forms/time = FAIL
 BUGWK29359 : fast/forms/week = FAIL
@@ -229,6 +232,7 @@
 
 // CSS Grid Layout is not yet enabled.
 BUGWK60731 : fast/css-grid-layout = FAIL
+BUGWK60731 : fast/css-grid-layout/grid-disabled-by-default.html = PASS
 
 // 

[webkit-changes] [118930] trunk/LayoutTests

[sergio]

Title: [118930] trunk/LayoutTests








Revision 118930
Author ser...@webkit.org
Date 2012-05-30 09:14:18 -0700 (Wed, 30 May 2012)


Log Message
Unreviewed, removed some tests from the test_expectations file as
they have been regularly passing in the 3 GTK bots for some time.

* platform/gtk/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (118929 => 118930)

--- trunk/LayoutTests/ChangeLog	2012-05-30 16:07:41 UTC (rev 118929)
+++ trunk/LayoutTests/ChangeLog	2012-05-30 16:14:18 UTC (rev 118930)
@@ -1,3 +1,10 @@
+2012-05-30  Sergio Villar Senin  
+
+Unreviewed, removed some tests from the test_expectations file as
+they have been regularly passing in the 3 GTK bots for some time.
+
+* platform/gtk/test_expectations.txt:
+
 2012-05-30  Jessie Berlin  
 
 [Win] REGRESSION(r118018) fast/js/names.html failing due to _javascript_Experiments not being


Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (118929 => 118930)

--- trunk/LayoutTests/platform/gtk/test_expectations.txt	2012-05-30 16:07:41 UTC (rev 118929)
+++ trunk/LayoutTests/platform/gtk/test_expectations.txt	2012-05-30 16:14:18 UTC (rev 118930)
@@ -576,10 +576,6 @@
 BUGWK53964 : fast/forms/listbox-selection-2.html = FAIL
 BUGWK53964 : fast/forms/option-mouseevents.html = FAIL
 
-// The test below is not scrolled to the proper position. Perhaps because of
-// asynchronous scrollbar behavior.
-BUGWKGTK : fast/css/font-weight-1.html = FAIL
-
 // Probably failing because resizing is asynchronous.
 BUGWK53959 : fast/dom/Window/window-resize-and-move-arguments.html = FAIL
 BUGWK53959 : fast/dom/Window/window-resize.html = FAIL
@@ -705,8 +701,6 @@
 BUGWKGTK : editing/selection/5825350-1.html = FAIL
 BUGWKGTK : editing/selection/5825350-2.html = FAIL
 
-BUGWK55682 : fast/images/support-broken-image-delegate.html = FAIL
-
 // Requires willSendRequestReturnsNullOnRedirect + willSendRequest + didFinishLoading
 BUGWKGTK : http/tests/misc/will-send-request-returns-null-on-redirect.html = FAIL
 
@@ -828,7 +822,6 @@
 BUGWK40601 : fast/events/mouseup-from-button2.html = FAIL
 BUGWK40601 : fast/events/right-click-focus.html = FAIL
 BUGWK40601 : editing/selection/5354455-1.html = FAIL
-BUGWK40601 : media/controls-right-click-on-timebar.html = FAIL
 
 // Gtk doesn't implement dumpResourceResponseMIMETypes which is required for the preloader tests.
 BUGWK58222 : fast/preloader = FAIL
@@ -1142,9 +1135,6 @@
 
 BUGWK72363 : fast/dom/Window/window-postmessage-arrays.html = FAIL
 
-// failing after enabling reftests
-BUGWK72569 : fast/forms/checkbox-appearance-change-by-checked.html = FAIL
-
 BUGWK73003 : editing/spelling/spellcheck-async.html = FAIL
 
 // 1 pixel difference between 64-bits and 32-bits
@@ -1168,8 +1158,6 @@
 BUGWK73653 : fast/forms/number/spin-in-multi-column.html = FAIL
 BUGWK73653 : fast/forms/range/slider-in-multi-column.html = FAIL
 
-BUGWK73768 : fast/forms/file/file-input-reset.html = FAIL
-
 BUGWK74276 : fast/events/dont-loose-last-event.html = FAIL
 
 BUGWK74282 : editing/pasteboard/emacs-ctrl-k-with-move.html = FAIL
@@ -1187,7 +1175,6 @@
 BUGWK77413 : fast/parser/nested-fragment-parser-crash.html = FAIL
 
 BUGWK77631 : fast/multicol/span/span-as-immediate-child-property-removal.html = FAIL
-BUGWK77631 : fast/multicol/span/span-as-immediate-columns-child-removal.html = FAIL
 
 // These test -apple- and -khtml- prefixed CSS properties, which we don't support.
 BUGWKGTK SKIP : inspector/styles/vendor-prefixes.html = FAIL
@@ -1279,18 +1266,12 @@
 
 BUGWK86310 : media/media-continues-playing-after-replace-source.html = FAIL
 
-BUGWK86328 : media/video-controls-toggling.html = FAIL
-
 BUGWK86443 : plugins/npruntime/delete-plugin-within-hasProperty-return-false.html = FAIL
 BUGWK86443 : plugins/npruntime/delete-plugin-within-hasProperty-return-true.html = FAIL
 BUGWK86443 : plugins/npruntime/delete-plugin-within-setProperty.html = FAIL
 
 BUGWK86445 : fast/multicol/split-in-top-margin.html = IMAGE
 
-// Needs rebaseline after bug 86441
-BUGWK86441 : fast/borders/border-antialiasing.html = IMAGE
-BUGWK86441 : fast/multicol/shadow-breaking.html = IMAGE
-
 // Requires rebaseline after https://bugs.webkit.org/show_bug.cgi?id=85405
 BUGWK85405 : tables/mozilla/bugs/bug10296-1.html = TEXT
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [115176] trunk/LayoutTests

[sergio]

Title: [115176] trunk/LayoutTests








Revision 115176
Author ser...@webkit.org
Date 2012-04-25 01:09:40 -0700 (Wed, 25 Apr 2012)


Log Message
Unreviewed. Unskipped 28 http tests passing on all the GTK+ bots.

* platform/gtk/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/test_expectations.txt




Diff

Modified: trunk/LayoutTests/ChangeLog (115175 => 115176)

--- trunk/LayoutTests/ChangeLog	2012-04-25 07:56:24 UTC (rev 115175)
+++ trunk/LayoutTests/ChangeLog	2012-04-25 08:09:40 UTC (rev 115176)
@@ -1,3 +1,9 @@
+2012-04-25  Sergio Villar Senin  
+
+Unreviewed. Unskipped 28 http tests passing on all the GTK+ bots.
+
+* platform/gtk/test_expectations.txt:
+
 2012-04-25  Nikolas Zimmermann  
 
 Not reviewed. Update pixel test baseline on Lion. All color space changes when painting images.


Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (115175 => 115176)

--- trunk/LayoutTests/platform/gtk/test_expectations.txt	2012-04-25 07:56:24 UTC (rev 115175)
+++ trunk/LayoutTests/platform/gtk/test_expectations.txt	2012-04-25 08:09:40 UTC (rev 115176)
@@ -512,16 +512,6 @@
 //
 // Tests timing out
 //
-
-BUGWK33445 : http/tests/incremental/split-hex-entities.pl = TIMEOUT
-
-BUGWK33026 : http/tests/xmlhttprequest/simple-cross-origin-progress-events.html = TIMEOUT
-
-// Times out only on 32-Bits Release
-BUGWKGTK : http/tests/xmlhttprequest/redirect-cross-origin-post-sync.html = TIMEOUT
-BUGWKGTK : http/tests/xmlhttprequest/redirect-cross-origin-sync-double.html = TIMEOUT
-BUGWKGTK : http/tests/xmlhttprequest/redirect-cross-origin-sync.html = TIMEOUT
-
 BUGWK46644 : fast/text/large-text-composed-char-dos.html = TIMEOUT
 
 BUGWKGTK SKIP : http/tests/multipart/invalid-image-data-standalone.html = TIMEOUT
@@ -670,7 +660,6 @@
 // This port doesn't support v8 i18n extension.
 BUGWKGTK : fast/js/i18n-bindings-locale.html = FAIL
 
-BUGWKGTK : http/tests/appcache/crash-when-navigating-away-then-back.html = FAIL
 BUGWKGTK : http/tests/appcache/fallback.html = FAIL
 BUGWKGTK : http/tests/appcache/origin-quota.html = FAIL
 BUGWKGTK : http/tests/appcache/origin-quota-continued-download.html = FAIL
@@ -687,15 +676,11 @@
 // Needed to cover the fix for 
 BUGRDAR6727495 : http/tests/loading/deleted-host-in-resource-load-delegate-callback.html = FAIL
 BUGRDAR6727495 : http/tests/loading/gmail-assert-on-load.html = FAIL
-BUGRDAR6727495 : http/tests/loading/redirect-with-no-location-crash.html = FAIL
 BUGRDAR6727495 : http/tests/loading/text-content-type-with-binary-extension.html = FAIL
 
 BUGWKGTK : http/tests/media/video-play-stall-seek.html = FAIL
 BUGWKGTK : http/tests/media/video-play-stall.html = FAIL
 
-// QuickTime reference movie not supported.
-BUGWKGTK : http/tests/media/video-cross-site.html = FAIL
-
 BUGWKGTK : http/tests/misc/acid3.html = FAIL
 BUGWKGTK : http/tests/misc/link-rel-prefetch-and-subresource.html = FAIL
 BUGWKGTK : http/tests/misc/policy-delegate-called-twice.html = FAIL
@@ -722,10 +707,8 @@
 BUGWKGTK : http/tests/xmlhttprequest/abort-should-cancel-load.html = FAIL
 BUGWKGTK : http/tests/xmlhttprequest/access-control-basic-whitelist-request-headers.html = FAIL
 BUGWKGTK : http/tests/xmlhttprequest/logout.html = FAIL
-BUGWKGTK : http/tests/xmlhttprequest/xmlhttprequest-contenttype-empty.html = FAIL
 
 // We don't seem to support neither of these for now
-BUGWKGTK : http/tests/xmlhttprequest/cross-origin-authorization.html = FAIL
 BUGWKGTK : http/tests/xmlhttprequest/cross-origin-cookie-storage.html = FAIL
 BUGWKGTK : http/tests/xmlhttprequest/cross-origin-no-authorization.html = FAIL
 
@@ -745,10 +728,7 @@
 
 // Missing resource load callback ability in DRT
 BUGWK27905 : http/tests/loading/redirect-methods.html = FAIL
-BUGWK27905 : http/tests/misc/favicon-loads-with-images-disabled.html = FAIL
 
-BUGWK28668 : http/tests/appcache/auth.html = FAIL
-
 // New test infrastructure required -- need isolated worlds
 BUGWK31508 : http/tests/security/isolatedWorld = FAIL
 BUGWK31508 : storage/open-database-creation-callback-isolated-world.html = FAIL
@@ -772,7 +752,6 @@
 // No authentication challenge handling
 BUGWK51104 : http/tests/loading/basic-credentials-sent-automatically.html = FAIL
 BUGWK51104 : http/tests/loading/authentication-after-redirect-stores-wrong-credentials/authentication-after-redirect-stores-wrong-credentials.html = FAIL
-BUGWK51104 : http/tests/cache/subresource-fragment-identifier.html = FAIL
 BUGWK51104 : http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin.html = FAIL
 BUGWK51104 : http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin.html = FAIL
 BUGWK51104 : http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-orig

[webkit-changes] [114736] trunk

[sergio]

Title: [114736] trunk








Revision 114736
Author ser...@webkit.org
Date 2012-04-20 03:54:06 -0700 (Fri, 20 Apr 2012)


Log Message
[GTK] Enable Web Timing
https://bugs.webkit.org/show_bug.cgi?id=42432

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Added WebTiming support to the GTK+ port. WebTiming allows
developers to collect detailed network timing information per
resource. It requires the new SoupMessage's "network-event"
signal.

* GNUmakefile.am:
* bindings/gobject/GNUmakefile.am:
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore):
(WebCore::restartedCallback):
(WebCore::sendRequestCallback):
(WebCore::milisecondsSinceRequest):
(WebCore::wroteBodyCallback):
(WebCore::requestStartedCallback):
(WebCore::networkEventCallback):
(WebCore::startHTTPRequest):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::ResourceHandle::defaultSession):

Tools:

Build web timing by default whenever build-webkit is used.

* Scripts/build-webkit:

LayoutTests:

Removed some tests that are working fine now after adding Web
Timing support.

* platform/gtk/test_expectations.txt:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/test_expectations.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.am
trunk/Source/WebCore/bindings/gobject/GNUmakefile.am
trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp
trunk/Tools/ChangeLog
trunk/Tools/Scripts/build-webkit




Diff

Modified: trunk/LayoutTests/ChangeLog (114735 => 114736)

--- trunk/LayoutTests/ChangeLog	2012-04-20 10:28:14 UTC (rev 114735)
+++ trunk/LayoutTests/ChangeLog	2012-04-20 10:54:06 UTC (rev 114736)
@@ -1,3 +1,15 @@
+2012-04-20  Sergio Villar Senin  
+
+[GTK] Enable Web Timing
+https://bugs.webkit.org/show_bug.cgi?id=42432
+
+Reviewed by Gustavo Noronha Silva.
+
+Removed some tests that are working fine now after adding Web
+Timing support.
+
+* platform/gtk/test_expectations.txt:
+
 2012-04-20  Mikhail Naganov  
 
 [Chromium] Unreviewed test expectations update.


Modified: trunk/LayoutTests/platform/gtk/test_expectations.txt (114735 => 114736)

--- trunk/LayoutTests/platform/gtk/test_expectations.txt	2012-04-20 10:28:14 UTC (rev 114735)
+++ trunk/LayoutTests/platform/gtk/test_expectations.txt	2012-04-20 10:54:06 UTC (rev 114736)
@@ -141,19 +141,10 @@
 // Speech _javascript_ API is not yet enabled.
 BUGWKGTK SKIP : fast/events/constructors/speech-recognition-event-constructor.html = FAIL
 
-// Web Timing is not enabled.
-BUGWK42432 : fast/dom/Window/window-properties-performance.html = FAIL
-BUGWK42432 : fast/dom/navigation-type-back-forward.html = FAIL
-BUGWK42432 : fast/dom/navigation-type-navigate.html = FAIL
-BUGWK42432 : fast/dom/navigation-type-reload.html = FAIL
-BUGWK42432 : fast/dom/webtiming.html = FAIL
-BUGWK42432 : fast/dom/webtiming-navigate-within-document.html = FAIL
-BUGWK42432 : fast/dom/webtiming-document-open.html = FAIL
-BUGWK42432 : http/tests/misc/webtiming-origins.html = FAIL
-BUGWK42432 : http/tests/misc/webtiming-one-redirect.php = FAIL
-BUGWK42432 : http/tests/misc/webtiming-slow-load.php = FAIL
-BUGWK42432 : http/tests/misc/webtiming-ssl.php = FAIL
-BUGWK42432 : http/tests/misc/webtiming-two-redirects.php = FAIL
+// Web Timing issues.
+BUGWKGTK : fast/dom/Window/window-properties-performance.html = FAIL
+BUGWKGTK : http/tests/misc/webtiming-origins.html = FAIL
+BUGWKGTK : http/tests/misc/webtiming-ssl.php = FAIL
 
 // FileSystem API is not supported.
 BUGWKGTK SKIP : fast/filesystem = FAIL


Modified: trunk/Source/WebCore/ChangeLog (114735 => 114736)

--- trunk/Source/WebCore/ChangeLog	2012-04-20 10:28:14 UTC (rev 114735)
+++ trunk/Source/WebCore/ChangeLog	2012-04-20 10:54:06 UTC (rev 114736)
@@ -1,3 +1,29 @@
+2012-04-20  Sergio Villar Senin  
+
+[GTK] Enable Web Timing
+https://bugs.webkit.org/show_bug.cgi?id=42432
+
+Reviewed by Gustavo Noronha Silva.
+
+Added WebTiming support to the GTK+ port. WebTiming allows
+developers to collect detailed network timing information per
+resource. It requires the new SoupMessage's "network-event"
+signal.
+
+* GNUmakefile.am:
+* bindings/gobject/GNUmakefile.am:
+* platform/network/soup/ResourceHandleSoup.cpp:
+(WebCore):
+(WebCore::restartedCallback):
+(WebCore::sendRequestCallback):
+(WebCore::milisecondsSinceRequest):
+(WebCore::wroteBodyCallback):
+(WebCore::requestStartedCallback):
+(WebCore::networkEventCallback):
+(WebCore::startHTTPRequest):
+(WebCore::ResourceHandle::platformSetDefersLoading):
+(WebCore::ResourceHandle::defaultSession):
+
 2012-04-20  'Pavel Feldman'  
 
 Not reviewed: fixed chromium sanity tests for inspector via assigning last path component


Modified: trunk/Source/WebCore/GNUmakefile.am (114735 => 114736)

--- tru

[webkit-changes] [113189] trunk/Source/WebCore

[sergio]

Title: [113189] trunk/Source/WebCore








Revision 113189
Author ser...@webkit.org
Date 2012-04-04 08:15:25 -0700 (Wed, 04 Apr 2012)


Log Message
[GTK] ASSERT in SocketStreamHandleSoup.cpp
https://bugs.webkit.org/show_bug.cgi?id=83123

Reviewed by Martin Robinson.

Do not try to reuse a GOwnPtr as calling outPtr() causes an
assertion if the pointer is already valid. Also do not try to
close the IOStream if it was not created.

This patch fixes
http/tests/websocket/tests/hybi/workers/worker-reload.html but I
am leaving it skipped until webkit.org/b/83124 is fixed.

* platform/network/soup/SocketStreamHandleSoup.cpp:
(WebCore::connectedCallback):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (113188 => 113189)

--- trunk/Source/WebCore/ChangeLog	2012-04-04 15:05:14 UTC (rev 113188)
+++ trunk/Source/WebCore/ChangeLog	2012-04-04 15:15:25 UTC (rev 113189)
@@ -1,3 +1,21 @@
+2012-04-04  Sergio Villar Senin  
+
+[GTK] ASSERT in SocketStreamHandleSoup.cpp
+https://bugs.webkit.org/show_bug.cgi?id=83123
+
+Reviewed by Martin Robinson.
+
+Do not try to reuse a GOwnPtr as calling outPtr() causes an
+assertion if the pointer is already valid. Also do not try to
+close the IOStream if it was not created.
+
+This patch fixes
+http/tests/websocket/tests/hybi/workers/worker-reload.html but I
+am leaving it skipped until webkit.org/b/83124 is fixed.
+
+* platform/network/soup/SocketStreamHandleSoup.cpp:
+(WebCore::connectedCallback):
+
 2012-04-04  Alexis Menard  
 
 Re-add variable names in CSS related headers to help understanding the meaning of them.


Modified: trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp (113188 => 113189)

--- trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp	2012-04-04 15:05:14 UTC (rev 113188)
+++ trunk/Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp	2012-04-04 15:15:25 UTC (rev 113189)
@@ -244,7 +244,8 @@
 // The SocketStreamHandle has been deactivated, so just close the connection, ignoring errors.
 SocketStreamHandle* handle = getHandleFromId(id);
 if (!handle) {
-g_io_stream_close(G_IO_STREAM(socketConnection), 0, &error.outPtr());
+if (socketConnection)
+g_io_stream_close(G_IO_STREAM(socketConnection), 0, 0);
 return;
 }
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112412] trunk/LayoutTests

[sergio]

Title: [112412] trunk/LayoutTests








Revision 112412
Author ser...@webkit.org
Date 2012-03-28 11:00:57 -0700 (Wed, 28 Mar 2012)


Log Message
Unreviewed, skipping 3 tests timing out after the libsoup upgrade
to 2.37.92.

* platform/gtk/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (112411 => 112412)

--- trunk/LayoutTests/ChangeLog	2012-03-28 17:55:04 UTC (rev 112411)
+++ trunk/LayoutTests/ChangeLog	2012-03-28 18:00:57 UTC (rev 112412)
@@ -1,3 +1,10 @@
+2012-03-28  Sergio Villar Senin  
+
+Unreviewed, skipping 3 tests timing out after the libsoup upgrade
+to 2.37.92.
+
+* platform/gtk/Skipped:
+
 2012-03-28  Pavel Feldman  
 
 Not reviewed: updated chromium test expectations.


Modified: trunk/LayoutTests/platform/gtk/Skipped (112411 => 112412)

--- trunk/LayoutTests/platform/gtk/Skipped	2012-03-28 17:55:04 UTC (rev 112411)
+++ trunk/LayoutTests/platform/gtk/Skipped	2012-03-28 18:00:57 UTC (rev 112412)
@@ -64,6 +64,12 @@
 # https://bugs.webkit.org/show_bug.cgi?id=58972
 media/adopt-node-crash.html
 
+# https://bugs.webkit.org/show_bug.cgi?id=82484
+# Started to fail after upgrading libsoup to 2.37.92
+fast/encoding/percent-escaping.html
+fast/loader/file-URL-with-port-number.html
+fast/loader/location-port.html
+
 ###
 # TESTS CRASHING
 ###






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [112396] trunk

[sergio]

Title: [112396] trunk








Revision 112396
Author ser...@webkit.org
Date 2012-03-28 07:45:45 -0700 (Wed, 28 Mar 2012)


Log Message
[Soup] DNS prefetching spams resolver, shoots self in the foot
https://bugs.webkit.org/show_bug.cgi?id=41630

Reviewed by Martin Robinson.

.:

Bump libsoup and glib dependencies.

* Source/cmake/OptionsEfl.cmake:
* configure.ac:

Source/WebCore:

Added generic DNSResolveQueue class to throttle DNS
prefetches. It's an abstract refactoring of CFNET's
DNSResolveQueue. Platform specific methods implemented for soup
and CFNET backends.

No new tests required as we're just refactoring existing code to
be used by two different ports.

* CMakeLists.txt: added new file.
* GNUmakefile.list.am: ditto.
* WebCore.vcproj/WebCore.vcproj: ditto.
* WebCore.xcodeproj/project.pbxproj: ditto.
* platform/network/DNSResolveQueue.cpp: Added.
(WebCore):
(WebCore::DNSResolveQueue::add): adds a new host to be prefetched.
(WebCore::DNSResolveQueue::fired): by using a delay we coalesce
several prefetch requests and try to resolve them all here.
* platform/network/DNSResolveQueue.h: Added.
(WebCore):
(DNSResolveQueue): class that implements DNS prefetch
throttling using a template pattern.
(WebCore::DNSResolveQueue::shared):
(WebCore::DNSResolveQueue::decrementRequestCount):
* platform/network/cf/DNSCFNet.cpp:
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
(WebCore::DNSResolveQueue::platformResolve):
* platform/network/soup/DNSSoup.cpp:
(WebCore):
(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):
(WebCore::resolvedCallback):
(WebCore::DNSResolveQueue::platformResolve):
(WebCore::prefetchDNS):

Tools:

Bump libsoup and glib dependencies.

* efl/jhbuild.modules:
* gtk/jhbuild.modules:

Modified Paths

trunk/ChangeLog
trunk/Source/WebCore/CMakeLists.txt
trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/WebCore.vcproj/WebCore.vcproj
trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj
trunk/Source/WebCore/platform/network/cf/DNSCFNet.cpp
trunk/Source/WebCore/platform/network/soup/DNSSoup.cpp
trunk/Source/cmake/OptionsEfl.cmake
trunk/Tools/ChangeLog
trunk/Tools/efl/jhbuild.modules
trunk/Tools/gtk/jhbuild.modules
trunk/configure.ac


Added Paths

trunk/Source/WebCore/platform/network/DNSResolveQueue.cpp
trunk/Source/WebCore/platform/network/DNSResolveQueue.h




Diff

Modified: trunk/ChangeLog (112395 => 112396)

--- trunk/ChangeLog	2012-03-28 14:37:56 UTC (rev 112395)
+++ trunk/ChangeLog	2012-03-28 14:45:45 UTC (rev 112396)
@@ -1,3 +1,15 @@
+2012-03-28  Sergio Villar Senin  
+
+[Soup] DNS prefetching spams resolver, shoots self in the foot
+https://bugs.webkit.org/show_bug.cgi?id=41630
+
+Reviewed by Martin Robinson.
+
+Bump libsoup and glib dependencies.
+
+* Source/cmake/OptionsEfl.cmake:
+* configure.ac:
+
 2012-03-28  Xan Lopez  
 
 [GTK] Respect NOCONFIGURE option in autogen.sh


Modified: trunk/Source/WebCore/CMakeLists.txt (112395 => 112396)

--- trunk/Source/WebCore/CMakeLists.txt	2012-03-28 14:37:56 UTC (rev 112395)
+++ trunk/Source/WebCore/CMakeLists.txt	2012-03-28 14:45:45 UTC (rev 112396)
@@ -1221,6 +1221,7 @@
 platform/network/CredentialStorage.cpp
 platform/network/ContentTypeParser.cpp
 platform/network/DataURL.cpp
+platform/network/DNSResolveQueue.cpp
 platform/network/FormDataBuilder.cpp
 platform/network/FormData.cpp
 platform/network/HTTPHeaderMap.cpp


Modified: trunk/Source/WebCore/ChangeLog (112395 => 112396)

--- trunk/Source/WebCore/ChangeLog	2012-03-28 14:37:56 UTC (rev 112395)
+++ trunk/Source/WebCore/ChangeLog	2012-03-28 14:45:45 UTC (rev 112396)
@@ -1,3 +1,43 @@
+2012-03-28  Sergio Villar Senin  
+
+[Soup] DNS prefetching spams resolver, shoots self in the foot
+https://bugs.webkit.org/show_bug.cgi?id=41630
+
+Reviewed by Martin Robinson.
+
+Added generic DNSResolveQueue class to throttle DNS
+prefetches. It's an abstract refactoring of CFNET's
+DNSResolveQueue. Platform specific methods implemented for soup
+and CFNET backends.
+
+No new tests required as we're just refactoring existing code to
+be used by two different ports.
+
+* CMakeLists.txt: added new file.
+* GNUmakefile.list.am: ditto.
+* WebCore.vcproj/WebCore.vcproj: ditto.
+* WebCore.xcodeproj/project.pbxproj: ditto.
+* platform/network/DNSResolveQueue.cpp: Added.
+(WebCore):
+(WebCore::DNSResolveQueue::add): adds a new host to be prefetched.
+(WebCore::DNSResolveQueue::fired): by using a delay we coalesce
+several prefetch requests and try to resolve them all here.
+* platform/network/DNSResolveQueue.h: Added.
+(WebCore):
+(DNSResolveQueue): class that implements DNS prefetch
+throttling using a template pattern.
+  

[webkit-changes] [111698] trunk/Source/WebKit/gtk

[sergio]

Title: [111698] trunk/Source/WebKit/gtk








Revision 111698
Author ser...@webkit.org
Date 2012-03-22 08:05:41 -0700 (Thu, 22 Mar 2012)


Log Message
[GTK] icon database requests not dispatched until new data arrives
https://bugs.webkit.org/show_bug.cgi?id=81665

Reviewed by Martin Robinson.

Wait for the import to finish before reporting that the favicon
cache does not have a pixbuf for an URL.

Changes already covered by the favicon database unit tests.

* webkit/webkitfavicondatabase.cpp:
(webkit_favicon_database_get_favicon_pixbuf):

Modified Paths

trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/webkit/webkitfavicondatabase.cpp




Diff

Modified: trunk/Source/WebKit/gtk/ChangeLog (111697 => 111698)

--- trunk/Source/WebKit/gtk/ChangeLog	2012-03-22 15:04:38 UTC (rev 111697)
+++ trunk/Source/WebKit/gtk/ChangeLog	2012-03-22 15:05:41 UTC (rev 111698)
@@ -1,3 +1,18 @@
+2012-03-22  Sergio Villar Senin  
+
+[GTK] icon database requests not dispatched until new data arrives
+https://bugs.webkit.org/show_bug.cgi?id=81665
+
+Reviewed by Martin Robinson.
+
+Wait for the import to finish before reporting that the favicon
+cache does not have a pixbuf for an URL.
+
+Changes already covered by the favicon database unit tests.
+
+* webkit/webkitfavicondatabase.cpp:
+(webkit_favicon_database_get_favicon_pixbuf):
+
 2012-03-22  Carlos Garcia Campos  
 
 [GTK] Use the angle-bracket form to include wtf headers


Modified: trunk/Source/WebKit/gtk/webkit/webkitfavicondatabase.cpp (111697 => 111698)

--- trunk/Source/WebKit/gtk/webkit/webkitfavicondatabase.cpp	2012-03-22 15:04:38 UTC (rev 111697)
+++ trunk/Source/WebKit/gtk/webkit/webkitfavicondatabase.cpp	2012-03-22 15:05:41 UTC (rev 111698)
@@ -521,8 +521,10 @@
 GRefPtr result = adoptGRef(g_simple_async_result_new(G_OBJECT(database), callback, userData,
  reinterpret_cast(webkit_favicon_database_get_favicon_pixbuf)));
 
-// If we don't have an icon for the given URI return ASAP.
-if (database->priv->importFinished && iconDatabase().synchronousIconURLForPageURL(String::fromUTF8(pageURI)).isEmpty()) {
+// If we don't have an icon for the given URI or the database is not opened then return ASAP. We have to check that
+// because if the database is not opened it will skip (and not notify about) every single icon load request
+if ((database->priv->importFinished && iconDatabase().synchronousIconURLForPageURL(String::fromUTF8(pageURI)).isEmpty())
+|| !iconDatabase().isOpen()) {
 g_simple_async_result_set_op_res_gpointer(result.get(), 0, 0);
 g_simple_async_result_complete_in_idle(result.get());
 return;
@@ -536,11 +538,11 @@
 ASSERT(icons);
 icons->append(adoptPtr(request));
 
+// We ask for the icon directly. If we don't get the icon data now,
+// we'll be notified later (even if the database is still importing icons).
 GdkPixbuf* pixbuf = getIconPixbufSynchronously(database, pageURL, IntSize(width, height));
-if (!pixbuf && !database->priv->importFinished) {
-// Initial import is ongoing, the icon data will be available later.
+if (!pixbuf)
 return;
-}
 
 request->asyncResultCompleteInIdle(pixbuf);
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [110671] trunk/Source/WebCore

[sergio]

Title: [110671] trunk/Source/WebCore








Revision 110671
Author ser...@webkit.org
Date 2012-03-14 00:32:07 -0700 (Wed, 14 Mar 2012)


Log Message
Unreviewed. Build fix for EFL after r110669.

* PlatformEfl.cmake: added DNSSoup.cpp

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/PlatformEfl.cmake




Diff

Modified: trunk/Source/WebCore/ChangeLog (110670 => 110671)

--- trunk/Source/WebCore/ChangeLog	2012-03-14 07:31:33 UTC (rev 110670)
+++ trunk/Source/WebCore/ChangeLog	2012-03-14 07:32:07 UTC (rev 110671)
@@ -1,3 +1,9 @@
+2012-03-14  Sergio Villar Senin  
+
+Unreviewed. Build fix for EFL after r110669.
+
+* PlatformEfl.cmake: added DNSSoup.cpp
+
 2012-03-13  Sergio Villar Senin  
 
 [GTK] Use the same DNS prefetching path than the other ports.


Modified: trunk/Source/WebCore/PlatformEfl.cmake (110670 => 110671)

--- trunk/Source/WebCore/PlatformEfl.cmake	2012-03-14 07:31:33 UTC (rev 110670)
+++ trunk/Source/WebCore/PlatformEfl.cmake	2012-03-14 07:32:07 UTC (rev 110671)
@@ -75,6 +75,7 @@
   platform/image-decoders/webp/WEBPImageDecoder.cpp
   platform/network/soup/CookieJarSoup.cpp
   platform/network/soup/CredentialStorageSoup.cpp
+  platform/network/soup/DNSSoup.cpp
   platform/network/soup/GOwnPtrSoup.cpp
   platform/network/soup/ProxyServerSoup.cpp
   platform/network/soup/ResourceHandleSoup.cpp






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [110669] trunk/Source/WebCore

[sergio]

Title: [110669] trunk/Source/WebCore








Revision 110669
Author ser...@webkit.org
Date 2012-03-14 00:23:49 -0700 (Wed, 14 Mar 2012)


Log Message
[GTK] Use the same DNS prefetching path than the other ports.
https://bugs.webkit.org/show_bug.cgi?id=80997

Reviewed by Martin Robinson.

This patch basically reverts r56128. There is no need to add an
special code path for GTK+ DNS pre-fetching because the main
reason to do that (some potential changes in libsoup) is not
going to happen. It also reduces the amount of DNS queries by
adding a NULL hostname check.

No need for new tests as this just moves code around.

* GNUmakefile.list.am:
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::parseAttribute):
* html/HTMLLinkElement.cpp:
* loader/LinkLoader.cpp:
(WebCore::LinkLoader::loadLink):
* page/Chrome.cpp:
(WebCore::Chrome::mouseDidMoveOverElement):
* platform/network/DNS.h:
(WebCore):
* platform/network/ResourceHandle.cpp:
* platform/network/ResourceHandle.h:
(ResourceHandle):
* platform/network/chromium/DNSChromium.cpp:
* platform/network/soup/DNSSoup.cpp: restored.
(WebCore):
(WebCore::prefetchDNS):
* platform/network/soup/ResourceHandleSoup.cpp:

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/GNUmakefile.list.am
trunk/Source/WebCore/html/HTMLAnchorElement.cpp
trunk/Source/WebCore/html/HTMLLinkElement.cpp
trunk/Source/WebCore/loader/LinkLoader.cpp
trunk/Source/WebCore/page/Chrome.cpp
trunk/Source/WebCore/platform/network/DNS.h
trunk/Source/WebCore/platform/network/ResourceHandle.cpp
trunk/Source/WebCore/platform/network/ResourceHandle.h
trunk/Source/WebCore/platform/network/chromium/DNSChromium.cpp
trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp


Added Paths

trunk/Source/WebCore/platform/network/soup/DNSSoup.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (110668 => 110669)

--- trunk/Source/WebCore/ChangeLog	2012-03-14 07:11:22 UTC (rev 110668)
+++ trunk/Source/WebCore/ChangeLog	2012-03-14 07:23:49 UTC (rev 110669)
@@ -1,3 +1,37 @@
+2012-03-13  Sergio Villar Senin  
+
+[GTK] Use the same DNS prefetching path than the other ports.
+https://bugs.webkit.org/show_bug.cgi?id=80997
+
+Reviewed by Martin Robinson.
+
+This patch basically reverts r56128. There is no need to add an
+special code path for GTK+ DNS pre-fetching because the main
+reason to do that (some potential changes in libsoup) is not
+going to happen. It also reduces the amount of DNS queries by
+adding a NULL hostname check.
+
+No need for new tests as this just moves code around.
+
+* GNUmakefile.list.am:
+* html/HTMLAnchorElement.cpp:
+(WebCore::HTMLAnchorElement::parseAttribute):
+* html/HTMLLinkElement.cpp:
+* loader/LinkLoader.cpp:
+(WebCore::LinkLoader::loadLink):
+* page/Chrome.cpp:
+(WebCore::Chrome::mouseDidMoveOverElement):
+* platform/network/DNS.h:
+(WebCore):
+* platform/network/ResourceHandle.cpp:
+* platform/network/ResourceHandle.h:
+(ResourceHandle):
+* platform/network/chromium/DNSChromium.cpp:
+* platform/network/soup/DNSSoup.cpp: restored.
+(WebCore):
+(WebCore::prefetchDNS):
+* platform/network/soup/ResourceHandleSoup.cpp:
+
 2012-03-14  Kentaro Hara  
 
 Return null when shouldAllowAccessToNode() fails


Modified: trunk/Source/WebCore/GNUmakefile.list.am (110668 => 110669)

--- trunk/Source/WebCore/GNUmakefile.list.am	2012-03-14 07:11:22 UTC (rev 110668)
+++ trunk/Source/WebCore/GNUmakefile.list.am	2012-03-14 07:23:49 UTC (rev 110669)
@@ -3396,6 +3396,7 @@
 	Source/WebCore/platform/network/soup/CookieJarSoup.cpp \
 	Source/WebCore/platform/network/soup/CookieJarSoup.h \
 	Source/WebCore/platform/network/soup/CredentialStorageSoup.cpp \
+	Source/WebCore/platform/network/soup/DNSSoup.cpp \
 	Source/WebCore/platform/network/soup/GOwnPtrSoup.cpp \
 	Source/WebCore/platform/network/soup/GOwnPtrSoup.h \
 	Source/WebCore/platform/network/soup/ProxyServerSoup.cpp \


Modified: trunk/Source/WebCore/html/HTMLAnchorElement.cpp (110668 => 110669)

--- trunk/Source/WebCore/html/HTMLAnchorElement.cpp	2012-03-14 07:11:22 UTC (rev 110668)
+++ trunk/Source/WebCore/html/HTMLAnchorElement.cpp	2012-03-14 07:23:49 UTC (rev 110669)
@@ -25,6 +25,7 @@
 #include "HTMLAnchorElement.h"
 
 #include "Attribute.h"
+#include "DNS.h"
 #include "EventNames.h"
 #include "Frame.h"
 #include "FrameLoaderClient.h"
@@ -37,7 +38,6 @@
 #include "Page.h"
 #include "PingLoader.h"
 #include "RenderImage.h"
-#include "ResourceHandle.h"
 #include "SecurityOrigin.h"
 #include "SecurityPolicy.h"
 #include "Settings.h"
@@ -221,7 +221,7 @@
 String parsedURL = stripLeadingAndTrailingHTMLSpaces(attr->value());
 if (docu

[webkit-changes] [109338] trunk/Source/WebKit2

[sergio]

Title: [109338] trunk/Source/WebKit2








Revision 109338
Author ser...@webkit.org
Date 2012-03-01 04:51:43 -0800 (Thu, 01 Mar 2012)


Log Message
[WK2] [GTK] [libsoup] SoupSession should use system CA
https://bugs.webkit.org/show_bug.cgi?id=79657

Reviewed by Martin Robinson.

SoupSession sould use system CA list to validate SSL
certificates. Do not use strict certificate validation though as
we want clients to decide whether or not accept/decline invalid
certificates (API to be added later).

No new tests required as current behaviour does not change at all
as we continue to accept invalid certificates by default.

* WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (109337 => 109338)

--- trunk/Source/WebKit2/ChangeLog	2012-03-01 12:40:24 UTC (rev 109337)
+++ trunk/Source/WebKit2/ChangeLog	2012-03-01 12:51:43 UTC (rev 109338)
@@ -1,3 +1,21 @@
+2012-03-01  Sergio Villar Senin  
+
+[WK2] [GTK] [libsoup] SoupSession should use system CA
+https://bugs.webkit.org/show_bug.cgi?id=79657
+
+Reviewed by Martin Robinson.
+
+SoupSession sould use system CA list to validate SSL
+certificates. Do not use strict certificate validation though as
+we want clients to decide whether or not accept/decline invalid
+certificates (API to be added later).
+
+No new tests required as current behaviour does not change at all
+as we continue to accept invalid certificates by default.
+
+* WebProcess/gtk/WebProcessMainGtk.cpp:
+(WebKit::WebProcessMainGtk):
+
 2012-03-01  Carlos Garcia Campos  
 
 Unreviewed. Fix WebKit2 GTK+ build.


Modified: trunk/Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp (109337 => 109338)

--- trunk/Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp	2012-03-01 12:40:24 UTC (rev 109337)
+++ trunk/Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp	2012-03-01 12:51:43 UTC (rev 109338)
@@ -64,6 +64,12 @@
 SoupSession* session = WebCore::ResourceHandle::defaultSession();
 soup_session_add_feature_by_type(session, WEB_TYPE_AUTH_DIALOG);
 
+// Despite using system CAs to validate certificates we're
+// accepting invalid certificates by default. New API will be
+// added later to let client accept/discard invalid certificates.
+g_object_set(session, SOUP_SESSION_SSL_USE_SYSTEM_CA_FILE, TRUE,
+ SOUP_SESSION_SSL_STRICT, FALSE, NULL);
+
 RunLoop::run();
 
 return 0;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [109228] trunk/Source/WebKit2

[sergio]

Title: [109228] trunk/Source/WebKit2








Revision 109228
Author ser...@webkit.org
Date 2012-02-29 10:15:32 -0800 (Wed, 29 Feb 2012)


Log Message
DidFindString should be emitted even if FindOptionsShowOverlay is not enabled
https://bugs.webkit.org/show_bug.cgi?id=76522

Reviewed by Darin Adler.

DidFindString message should be issued always even if neither
FindOptionsShowOverlay or FindOptionsShowHighlight are
provided. The difference is that if any of those flags are present
the find operation will look for all the appearances of the text
in the web view, otherwise it will just look and report the next
occurrence.

This patch removes the temporary workaround added in r109222 to
the WebKitFindController unit tests.

* UIProcess/API/gtk/tests/TestWebKitFindController.cpp:
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::findString):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp
trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (109227 => 109228)

--- trunk/Source/WebKit2/ChangeLog	2012-02-29 18:08:27 UTC (rev 109227)
+++ trunk/Source/WebKit2/ChangeLog	2012-02-29 18:15:32 UTC (rev 109228)
@@ -1,3 +1,24 @@
+2012-02-29  Sergio Villar Senin  
+
+DidFindString should be emitted even if FindOptionsShowOverlay is not enabled
+https://bugs.webkit.org/show_bug.cgi?id=76522
+
+Reviewed by Darin Adler.
+
+DidFindString message should be issued always even if neither
+FindOptionsShowOverlay or FindOptionsShowHighlight are
+provided. The difference is that if any of those flags are present
+the find operation will look for all the appearances of the text
+in the web view, otherwise it will just look and report the next
+occurrence.
+
+This patch removes the temporary workaround added in r109222 to
+the WebKitFindController unit tests.
+
+* UIProcess/API/gtk/tests/TestWebKitFindController.cpp:
+* WebProcess/WebPage/FindController.cpp:
+(WebKit::FindController::findString):
+
 2012-01-19  Sergio Villar Senin  
 
 [GTK] [WK2] Add Find API


Modified: trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp (109227 => 109228)

--- trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp	2012-02-29 18:08:27 UTC (rev 109227)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp	2012-02-29 18:15:32 UTC (rev 109228)
@@ -45,12 +45,6 @@
 
 void find(const char* searchText, guint32 findOptions, guint maxMatchCount)
 {
-// Due to http://weakit.org/b/76522 we have to artificially
-// add here the show overlay option (that we do not even
-// expose in the API) to get the DidFindString messsage
-// issued. Remove this once 76522 is fixed.
-findOptions = findOptions | 1 << 5;
-
 g_signal_connect(m_findController.get(), "found-text", G_CALLBACK(foundTextCallback), this);
 g_signal_connect(m_findController.get(), "failed-to-find-text", G_CALLBACK(failedToFindTextCallback), this);
 webkit_find_controller_search(m_findController.get(), searchText, findOptions, maxMatchCount);


Modified: trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp (109227 => 109228)

--- trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp	2012-02-29 18:08:27 UTC (rev 109227)
+++ trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp	2012-02-29 18:15:32 UTC (rev 109228)
@@ -109,24 +109,25 @@
 m_webPage->send(Messages::WebPageProxy::DidFailToFindString(string));
 } else {
 shouldShowOverlay = options & FindOptionsShowOverlay;
+bool shouldShowHighlight = options & FindOptionsShowHighlight;
+unsigned matchCount = 1;
 
-if (shouldShowOverlay) {
-bool shouldShowHighlight = options & FindOptionsShowHighlight;
+if (shouldShowOverlay || shouldShowHighlight) {
 
 if (maxMatchCount == numeric_limits::max())
 --maxMatchCount;
-
-unsigned matchCount = m_webPage->corePage()->markAllMatchesForText(string, core(options), shouldShowHighlight, maxMatchCount + 1);
 
+matchCount = m_webPage->corePage()->markAllMatchesForText(string, core(options), shouldShowHighlight, maxMatchCount + 1);
+
 // Check if we have more matches than allowed.
 if (matchCount > maxMatchCount) {
 shouldShowOverlay = false;
 matchCount = static_cast(kWKMoreThanMaximumMatchCount);
 }
-
-m_webPage->send(Messages::WebPageProxy::DidFindString(string, matchCount));
 }
 
+m_webPage->send(Messages::WebPageProxy::DidFindString(string, matchCount));
+
 if (!(options & FindOptions

[webkit-changes] [108760] trunk/Source/WebKit2

[sergio]

Title: [108760] trunk/Source/WebKit2








Revision 108760
Author ser...@webkit.org
Date 2012-02-24 02:19:42 -0800 (Fri, 24 Feb 2012)


Log Message
[WK2] [GTK] Destructor not invoked in EditorClientFrameDestructionObserver
https://bugs.webkit.org/show_bug.cgi?id=79466

Reviewed by Philippe Normand.

Explicitly cast the observer before deleting it instead of just
deleting a generic pointer. We must to that in order to get the
destructor of the object properly called.

* WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
(WebKit::EditorClientFrameDestructionObserver::destroyOnClosureFinalization):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (108759 => 108760)

--- trunk/Source/WebKit2/ChangeLog	2012-02-24 10:12:46 UTC (rev 108759)
+++ trunk/Source/WebKit2/ChangeLog	2012-02-24 10:19:42 UTC (rev 108760)
@@ -1,3 +1,17 @@
+2012-02-24  Sergio Villar Senin  
+
+[WK2] [GTK] Destructor not invoked in EditorClientFrameDestructionObserver
+https://bugs.webkit.org/show_bug.cgi?id=79466
+
+Reviewed by Philippe Normand.
+
+Explicitly cast the observer before deleting it instead of just
+deleting a generic pointer. We must to that in order to get the
+destructor of the object properly called.
+
+* WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
+(WebKit::EditorClientFrameDestructionObserver::destroyOnClosureFinalization):
+
 2012-02-23  Andy Estes  
 
 Rename [setS|s]uppressIncrementalRendering to [setS|s]uppressesIncrementalRendering and make it WebPreferences API.


Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp (108759 => 108760)

--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp	2012-02-24 10:12:46 UTC (rev 108759)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp	2012-02-24 10:19:42 UTC (rev 108760)
@@ -148,7 +148,13 @@
 private:
 GClosure* m_closure;
 
-static void destroyOnClosureFinalization(gpointer data, GClosure* closure) { delete data; }
+static void destroyOnClosureFinalization(gpointer data, GClosure* closure)
+{
+// Calling delete void* will free the memory but won't invoke
+// the destructor, something that is a must for us.
+EditorClientFrameDestructionObserver* observer = static_cast(data);
+delete observer;
+}
 };
 
 static Frame* frameSettingClipboard;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [108631] trunk/Source/WebKit2

[sergio]

Title: [108631] trunk/Source/WebKit2








Revision 108631
Author ser...@webkit.org
Date 2012-02-23 08:38:02 -0800 (Thu, 23 Feb 2012)


Log Message
[WK2][GTK] WebProcess SIGSEVs due to incorrect clipboard handling
https://bugs.webkit.org/show_bug.cgi?id=79252

Do not execute clipboard callbacks after the Frame associated with
it is destroyed.

This change is already covered by the TestWebViewEditor unit tests
(among others), they hang (because WebProcess dies) without this
patch in Debug builds.

* WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
(EditorClientFrameDestructionObserver):
(WebKit::EditorClientFrameDestructionObserver::EditorClientFrameDestructionObserver):
(WebKit::EditorClientFrameDestructionObserver::frameDestroyed):
(WebKit::EditorClientFrameDestructionObserver::destroyOnClosureFinalization):
(WebKit):
(WebKit::WebEditorClient::setSelectionPrimaryClipboardIfNeeded):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (108630 => 108631)

--- trunk/Source/WebKit2/ChangeLog	2012-02-23 16:19:21 UTC (rev 108630)
+++ trunk/Source/WebKit2/ChangeLog	2012-02-23 16:38:02 UTC (rev 108631)
@@ -1,3 +1,23 @@
+2012-02-23  Sergio Villar Senin  
+
+[WK2][GTK] WebProcess SIGSEVs due to incorrect clipboard handling
+https://bugs.webkit.org/show_bug.cgi?id=79252
+
+Do not execute clipboard callbacks after the Frame associated with
+it is destroyed.
+
+This change is already covered by the TestWebViewEditor unit tests
+(among others), they hang (because WebProcess dies) without this
+patch in Debug builds.
+
+* WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
+(EditorClientFrameDestructionObserver):
+(WebKit::EditorClientFrameDestructionObserver::EditorClientFrameDestructionObserver):
+(WebKit::EditorClientFrameDestructionObserver::frameDestroyed):
+(WebKit::EditorClientFrameDestructionObserver::destroyOnClosureFinalization):
+(WebKit):
+(WebKit::WebEditorClient::setSelectionPrimaryClipboardIfNeeded):
+
 2012-02-23  Kenneth Rohde Christiansen  
 
 [Qt] Page doesn't get repainted while panning is in progress


Modified: trunk/Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp (108630 => 108631)

--- trunk/Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp	2012-02-23 16:19:21 UTC (rev 108630)
+++ trunk/Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp	2012-02-23 16:38:02 UTC (rev 108631)
@@ -21,6 +21,7 @@
 #include "WebEditorClient.h"
 
 #include "Frame.h"
+#include "FrameDestructionObserver.h"
 #include "PlatformKeyboardEvent.h"
 #include "WebPage.h"
 #include "WebPageProxyMessages.h"
@@ -130,7 +131,28 @@
 }
 
 #if PLATFORM(X11)
+class EditorClientFrameDestructionObserver : FrameDestructionObserver {
+public:
+EditorClientFrameDestructionObserver(Frame* frame, GClosure* closure)
+: FrameDestructionObserver(frame)
+, m_closure(closure)
+{
+g_closure_add_finalize_notifier(m_closure, this, destroyOnClosureFinalization);
+}
+
+void frameDestroyed()
+{
+g_closure_invalidate(m_closure);
+FrameDestructionObserver::frameDestroyed();
+}
+private:
+GClosure* m_closure;
+
+static void destroyOnClosureFinalization(gpointer data, GClosure* closure) { delete data; }
+};
+
 static Frame* frameSettingClipboard;
+
 static void collapseSelection(GtkClipboard* clipboard, Frame* frame)
 {
 if (frameSettingClipboard && frameSettingClipboard == frame)
@@ -156,6 +178,10 @@
 
 frameSettingClipboard = frame;
 GClosure* callback = g_cclosure_new(G_CALLBACK(collapseSelection), frame, 0);
+// This observer will be self-destroyed on closure finalization,
+// that will happen either after closure execution or after
+// closure invalidation.
+new EditorClientFrameDestructionObserver(frame, callback);
 g_closure_set_marshal(callback, g_cclosure_marshal_VOID__VOID);
 PasteboardHelper::defaultPasteboardHelper()->writeClipboardContents(clipboard, PasteboardHelper::DoNotIncludeSmartPaste, callback);
 frameSettingClipboard = 0;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [107973] trunk/Source

[sergio]

Title: [107973] trunk/Source








Revision 107973
Author ser...@webkit.org
Date 2012-02-16 12:56:02 -0800 (Thu, 16 Feb 2012)


Log Message
[soup] Move important SoupSession feature initialization to WebCore
https://bugs.webkit.org/show_bug.cgi?id=68602

Reviewed by Martin Robinson.

Source/WebCore:

Moved content sniffer and decoder initialization from WebKit to
WebCore because network stuff will not work as expected without
them. Added also out-of-the-box proxy support to WebCore.

No new tests required as we're just moving stuff from WebKit to
WebCore.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::defaultSession):

Source/WebKit/gtk:

Moved content sniffer and decoder initialization from WebKit to
WebCore because network stuff will not work as expected without
them.

No new tests required as we're just moving stuff from WebKit to
WebCore.

* webkit/webkitglobals.cpp:
(webkitInit):

Source/WebKit2:

Moved content sniffer and decoder initialization from the
WebProcess to WebCore because network stuff will not work as
expected without them.

No new tests required as we're just moving stuff from the
WebProcess to WebCore.

* WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/webkit/webkitglobals.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (107972 => 107973)

--- trunk/Source/WebCore/ChangeLog	2012-02-16 20:55:34 UTC (rev 107972)
+++ trunk/Source/WebCore/ChangeLog	2012-02-16 20:56:02 UTC (rev 107973)
@@ -1,3 +1,20 @@
+2012-02-16  Sergio Villar Senin  
+
+[soup] Move important SoupSession feature initialization to WebCore
+https://bugs.webkit.org/show_bug.cgi?id=68602
+
+Reviewed by Martin Robinson.
+
+Moved content sniffer and decoder initialization from WebKit to
+WebCore because network stuff will not work as expected without
+them. Added also out-of-the-box proxy support to WebCore.
+
+No new tests required as we're just moving stuff from WebKit to
+WebCore.
+
+* platform/network/soup/ResourceHandleSoup.cpp:
+(WebCore::ResourceHandle::defaultSession):
+
 2012-02-16  Julien Chaffraix  
 
 thead in table without tbody causes table height doubling


Modified: trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (107972 => 107973)

--- trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp	2012-02-16 20:55:34 UTC (rev 107972)
+++ trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp	2012-02-16 20:56:02 UTC (rev 107973)
@@ -735,7 +735,10 @@
 session = soup_session_async_new();
 g_object_set(session,
  SOUP_SESSION_MAX_CONNS, maxConnections,
- SOUP_SESSION_MAX_CONNS_PER_HOST, maxConnectionsPerHost, 
+ SOUP_SESSION_MAX_CONNS_PER_HOST, maxConnectionsPerHost,
+ SOUP_SESSION_ADD_FEATURE_BY_TYPE, SOUP_TYPE_CONTENT_DECODER,
+ SOUP_SESSION_ADD_FEATURE_BY_TYPE, SOUP_TYPE_CONTENT_SNIFFER,
+ SOUP_SESSION_ADD_FEATURE_BY_TYPE, SOUP_TYPE_PROXY_RESOLVER_DEFAULT,
  NULL);
 }
 


Modified: trunk/Source/WebKit/gtk/ChangeLog (107972 => 107973)

--- trunk/Source/WebKit/gtk/ChangeLog	2012-02-16 20:55:34 UTC (rev 107972)
+++ trunk/Source/WebKit/gtk/ChangeLog	2012-02-16 20:56:02 UTC (rev 107973)
@@ -1,3 +1,20 @@
+2012-02-16  Sergio Villar Senin  
+
+[soup] Move important SoupSession feature initialization to WebCore
+https://bugs.webkit.org/show_bug.cgi?id=68602
+
+Reviewed by Martin Robinson.
+
+Moved content sniffer and decoder initialization from WebKit to
+WebCore because network stuff will not work as expected without
+them.
+
+No new tests required as we're just moving stuff from WebKit to
+WebCore.
+
+* webkit/webkitglobals.cpp:
+(webkitInit):
+
 2012-02-16  Philippe Normand  
 
 Unreviewed, rolling out r107941.


Modified: trunk/Source/WebKit/gtk/webkit/webkitglobals.cpp (107972 => 107973)

--- trunk/Source/WebKit/gtk/webkit/webkitglobals.cpp	2012-02-16 20:55:34 UTC (rev 107972)
+++ trunk/Source/WebKit/gtk/webkit/webkitglobals.cpp	2012-02-16 20:56:02 UTC (rev 107973)
@@ -336,12 +336,6 @@
 soup_session_add_feature(session, authDialog);
 g_object_unref(authDialog);
 
-SoupSessionFeature* sniffer = static_cast(g_object_new(SOUP_TYPE_CONTENT_SNIFFER, NULL));
-soup_session_add_feature(session, sniffer);
-g_object_unref(sniffer);
-
-soup_session_add_feature_by_type(session, SOUP_TYPE_CONTENT_DECODER);
-
 #if USE(CLUTTER)
 gtk_clutter_init(0, 0);
 #endif


Modified: trunk/Source/WebKit2/Ch

[webkit-changes] [107941] trunk/Source

[sergio]

Title: [107941] trunk/Source








Revision 107941
Author ser...@webkit.org
Date 2012-02-16 08:41:38 -0800 (Thu, 16 Feb 2012)


Log Message
[soup] Move important SoupSession feature initialization to WebCore
https://bugs.webkit.org/show_bug.cgi?id=68602

Reviewed by Martin Robinson.

Source/WebCore:

Moved content sniffer and decoder initialization from WebKit to
WebCore because network stuff will not work as expected without
them. Added also out-of-the-box proxy support to WebCore.

No new tests required as we're just moving stuff from WebKit to
WebCore.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::defaultSession):

Source/WebKit/gtk:

Moved content sniffer and decoder initialization from WebKit to
WebCore because network stuff will not work as expected without
them.

No new tests required as we're just moving stuff from WebKit to
WebCore.

* webkit/webkitglobals.cpp:
(webkitInit):

Source/WebKit2:

Moved content sniffer and decoder initialization from the
WebProcess to WebCore because network stuff will not work as
expected without them.

No new tests required as we're just moving stuff from the
WebProcess to WebCore.

* WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp
trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/webkit/webkitglobals.cpp
trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp




Diff

Modified: trunk/Source/WebCore/ChangeLog (107940 => 107941)

--- trunk/Source/WebCore/ChangeLog	2012-02-16 16:37:54 UTC (rev 107940)
+++ trunk/Source/WebCore/ChangeLog	2012-02-16 16:41:38 UTC (rev 107941)
@@ -1,3 +1,20 @@
+2012-02-16  Sergio Villar Senin  
+
+[soup] Move important SoupSession feature initialization to WebCore
+https://bugs.webkit.org/show_bug.cgi?id=68602
+
+Reviewed by Martin Robinson.
+
+Moved content sniffer and decoder initialization from WebKit to
+WebCore because network stuff will not work as expected without
+them. Added also out-of-the-box proxy support to WebCore.
+
+No new tests required as we're just moving stuff from WebKit to
+WebCore.
+
+* platform/network/soup/ResourceHandleSoup.cpp:
+(WebCore::ResourceHandle::defaultSession):
+
 2012-02-16  Pavel Feldman  
 
 Web Inspector: remove free flow DOM editing experiment.


Modified: trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp (107940 => 107941)

--- trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp	2012-02-16 16:37:54 UTC (rev 107940)
+++ trunk/Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp	2012-02-16 16:41:38 UTC (rev 107941)
@@ -734,8 +734,12 @@
 if (!session) {
 session = soup_session_async_new();
 g_object_set(session,
+ SOUP_SESSION_ADD_FEATURE_BY_TYPE, SOUP_TYPE_CONTENT_DECODER,
+ SOUP_SESSION_ADD_FEATURE_BY_TYPE, SOUP_TYPE_CONTENT_SNIFFER,
+ SOUP_SESSION_ADD_FEATURE_BY_TYPE, SOUP_TYPE_PROXY_RESOLVER_DEFAULT,
  SOUP_SESSION_MAX_CONNS, maxConnections,
- SOUP_SESSION_MAX_CONNS_PER_HOST, maxConnectionsPerHost, 
+ SOUP_SESSION_MAX_CONNS_PER_HOST, maxConnectionsPerHost,
+ SOUP_SESSION_SSL_USE_SYSTEM_CA_FILE, TRUE,
  NULL);
 }
 


Modified: trunk/Source/WebKit/gtk/ChangeLog (107940 => 107941)

--- trunk/Source/WebKit/gtk/ChangeLog	2012-02-16 16:37:54 UTC (rev 107940)
+++ trunk/Source/WebKit/gtk/ChangeLog	2012-02-16 16:41:38 UTC (rev 107941)
@@ -1,3 +1,20 @@
+2012-02-16  Sergio Villar Senin  
+
+[soup] Move important SoupSession feature initialization to WebCore
+https://bugs.webkit.org/show_bug.cgi?id=68602
+
+Reviewed by Martin Robinson.
+
+Moved content sniffer and decoder initialization from WebKit to
+WebCore because network stuff will not work as expected without
+them.
+
+No new tests required as we're just moving stuff from WebKit to
+WebCore.
+
+* webkit/webkitglobals.cpp:
+(webkitInit):
+
 2012-01-31  Raphael Kubo da Costa  
 
 [soup] Add support for multiple SoupSessions.


Modified: trunk/Source/WebKit/gtk/webkit/webkitglobals.cpp (107940 => 107941)

--- trunk/Source/WebKit/gtk/webkit/webkitglobals.cpp	2012-02-16 16:37:54 UTC (rev 107940)
+++ trunk/Source/WebKit/gtk/webkit/webkitglobals.cpp	2012-02-16 16:41:38 UTC (rev 107941)
@@ -336,12 +336,6 @@
 soup_session_add_feature(session, authDialog);
 g_object_unref(authDialog);
 
-SoupSessionFeature* sniffer = static_cast(g_object_new(SOUP_TYPE_CONTENT_SNIFFER, NULL));
-soup_session_add_feature(session, sniffer);
-g_object_unref(sniffer);
-
-soup_session_add_feature_by_type(session, SOUP_TYPE

[webkit-changes] [106784] trunk/Tools

[sergio]

Title: [106784] trunk/Tools








Revision 106784
Author ser...@webkit.org
Date 2012-02-06 01:07:20 -0800 (Mon, 06 Feb 2012)


Log Message
Incorrect statistics shown when running run-webkit-tests with --repeat-each or --iterations
https://bugs.webkit.org/show_bug.cgi?id=77672

Reviewed by Dirk Pranke.

Test repetitions must be taken into account when working out
the statistics shown by run-webkit-tests.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.prepare_lists_and_print_output):
(Manager._print_result_summary):
* Scripts/webkitpy/layout_tests/models/result_summary.py:
(ResultSummary.__init__):
(ResultSummary.add):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_repeat_each_iterations_num_tests):

Modified Paths

trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py
trunk/Tools/Scripts/webkitpy/layout_tests/models/result_summary.py
trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py




Diff

Modified: trunk/Tools/ChangeLog (106783 => 106784)

--- trunk/Tools/ChangeLog	2012-02-06 08:56:02 UTC (rev 106783)
+++ trunk/Tools/ChangeLog	2012-02-06 09:07:20 UTC (rev 106784)
@@ -1,3 +1,22 @@
+2012-02-06  Sergio Villar Senin  
+
+Incorrect statistics shown when running run-webkit-tests with --repeat-each or --iterations
+https://bugs.webkit.org/show_bug.cgi?id=77672
+
+Reviewed by Dirk Pranke.
+
+Test repetitions must be taken into account when working out
+the statistics shown by run-webkit-tests.
+
+* Scripts/webkitpy/layout_tests/controllers/manager.py:
+(Manager.prepare_lists_and_print_output):
+(Manager._print_result_summary):
+* Scripts/webkitpy/layout_tests/models/result_summary.py:
+(ResultSummary.__init__):
+(ResultSummary.add):
+* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
+(MainTest.test_repeat_each_iterations_num_tests):
+
 2012-02-05  Dan Bernstein  
 
  WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage() always returns true


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py (106783 => 106784)

--- trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py	2012-02-06 08:56:02 UTC (rev 106783)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py	2012-02-06 09:07:20 UTC (rev 106784)
@@ -503,7 +503,10 @@
 if self._options.iterations:
 self._test_files_list = self._test_files_list * self._options.iterations
 
-result_summary = ResultSummary(self._expectations, self._test_files | skipped)
+iterations =  \
+(self._options.repeat_each if self._options.repeat_each else 1) * \
+(self._options.iterations if self._options.iterations else 1)
+result_summary = ResultSummary(self._expectations, self._test_files | skipped, iterations)
 self._print_expected_results_of_type(result_summary, test_expectations.PASS, "passes")
 self._print_expected_results_of_type(result_summary, test_expectations.FAIL, "failures")
 self._print_expected_results_of_type(result_summary, test_expectations.FLAKY, "flaky")
@@ -518,7 +521,11 @@
 for test in skipped:
 result = test_results.TestResult(test)
 result.type = test_expectations.SKIP
-result_summary.add(result, expected=True)
+iterations =  \
+(self._options.repeat_each if self._options.repeat_each else 1) * \
+(self._options.iterations if self._options.iterations else 1)
+for iteration in range(iterations):
+result_summary.add(result, expected=True)
 self._printer.print_expected('')
 
 # Check to make sure we didn't filter out all of the tests.
@@ -1320,9 +1327,8 @@
 Args:
   result_summary: information to log
 """
-failed = len(result_summary.failures)
-skipped = len(
-result_summary.tests_by_expectation[test_expectations.SKIP])
+failed = result_summary.total_failures
+skipped = result_summary.total_tests_by_expectation[test_expectations.SKIP]
 total = result_summary.total
 passed = total - failed - skipped
 pct_passed = 0.0


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/models/result_summary.py (106783 => 106784)

--- trunk/Tools/Scripts/webkitpy/layout_tests/models/result_summary.py	2012-02-06 08:56:02 UTC (rev 106783)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/models/result_summary.py	2012-02-06 09:07:20 UTC (rev 106784)
@@ -31,8 +31,8 @@
 
 
 class ResultSummary(object):
-def __init__(self, expectations, test_files):
-self.total = len(test_files)
+def __init__(self, expectations, test_files, iterations=1):
+self.tota

[webkit-changes] [105855] trunk/Source/WebKit2

[sergio]

Title: [105855] trunk/Source/WebKit2








Revision 105855
Author ser...@webkit.org
Date 2012-01-25 00:54:19 -0800 (Wed, 25 Jan 2012)


Log Message
[WK2] FindController should not assume that ports do not want to highlight text matches
https://bugs.webkit.org/show_bug.cgi?id=76921

Reviewed by Darin Adler.

FindController must obey the FindOptionsShowHighlight flag instead
of assuming that ports do not want to highlight search matches.

* Shared/API/c/WKFindOptions.h: added kWKFindOptionsShowHighlight.
* Shared/API/c/WKSharedAPICast.h:
(WebKit::toFindOptions): Ditto.
* Shared/WebFindOptions.h: added FindOptionsShowHighlight.
* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::findString):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/Shared/API/c/WKFindOptions.h
trunk/Source/WebKit2/Shared/API/c/WKSharedAPICast.h
trunk/Source/WebKit2/Shared/WebFindOptions.h
trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (105854 => 105855)

--- trunk/Source/WebKit2/ChangeLog	2012-01-25 08:37:01 UTC (rev 105854)
+++ trunk/Source/WebKit2/ChangeLog	2012-01-25 08:54:19 UTC (rev 105855)
@@ -1,3 +1,20 @@
+2012-01-24  Sergio Villar Senin  
+
+[WK2] FindController should not assume that ports do not want to highlight text matches
+https://bugs.webkit.org/show_bug.cgi?id=76921
+
+Reviewed by Darin Adler.
+
+FindController must obey the FindOptionsShowHighlight flag instead
+of assuming that ports do not want to highlight search matches.
+
+* Shared/API/c/WKFindOptions.h: added kWKFindOptionsShowHighlight.
+* Shared/API/c/WKSharedAPICast.h:
+(WebKit::toFindOptions): Ditto.
+* Shared/WebFindOptions.h: added FindOptionsShowHighlight.
+* WebProcess/WebPage/FindController.cpp:
+(WebKit::FindController::findString):
+
 2012-01-25  Carlos Garcia Campos  
 
 [GTK] Page clients don't need to be GObjects anymore in WebKit2 GTK+ API


Modified: trunk/Source/WebKit2/Shared/API/c/WKFindOptions.h (105854 => 105855)

--- trunk/Source/WebKit2/Shared/API/c/WKFindOptions.h	2012-01-25 08:37:01 UTC (rev 105854)
+++ trunk/Source/WebKit2/Shared/API/c/WKFindOptions.h	2012-01-25 08:54:19 UTC (rev 105855)
@@ -37,7 +37,8 @@
 kWKFindOptionsBackwards = 1 << 3,
 kWKFindOptionsWrapAround = 1 << 4,
 kWKFindOptionsShowOverlay = 1 << 5,
-kWKFindOptionsShowFindIndicator = 1 << 6
+kWKFindOptionsShowFindIndicator = 1 << 6,
+kWKFindOptionsShowHighlight = 1 << 7
 };
 typedef uint32_t WKFindOptions;
 


Modified: trunk/Source/WebKit2/Shared/API/c/WKSharedAPICast.h (105854 => 105855)

--- trunk/Source/WebKit2/Shared/API/c/WKSharedAPICast.h	2012-01-25 08:37:01 UTC (rev 105854)
+++ trunk/Source/WebKit2/Shared/API/c/WKSharedAPICast.h	2012-01-25 08:54:19 UTC (rev 105855)
@@ -688,6 +688,8 @@
 findOptions |= FindOptionsShowOverlay;
 if (wkFindOptions & kWKFindOptionsShowFindIndicator)
 findOptions |= FindOptionsShowFindIndicator;
+if (wkFindOptions & kWKFindOptionsShowHighlight)
+findOptions |= FindOptionsShowHighlight;
 
 return static_cast(findOptions);
 }


Modified: trunk/Source/WebKit2/Shared/WebFindOptions.h (105854 => 105855)

--- trunk/Source/WebKit2/Shared/WebFindOptions.h	2012-01-25 08:37:01 UTC (rev 105854)
+++ trunk/Source/WebKit2/Shared/WebFindOptions.h	2012-01-25 08:54:19 UTC (rev 105855)
@@ -35,7 +35,8 @@
 FindOptionsBackwards = 1 << 3,
 FindOptionsWrapAround = 1 << 4,
 FindOptionsShowOverlay = 1 << 5,
-FindOptionsShowFindIndicator = 1 << 6
+FindOptionsShowFindIndicator = 1 << 6,
+FindOptionsShowHighlight = 1 << 7
 };
 
 } // namespace WebKit


Modified: trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp (105854 => 105855)

--- trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp	2012-01-25 08:37:01 UTC (rev 105854)
+++ trunk/Source/WebKit2/WebProcess/WebPage/FindController.cpp	2012-01-25 08:54:19 UTC (rev 105855)
@@ -111,10 +111,12 @@
 shouldShowOverlay = options & FindOptionsShowOverlay;
 
 if (shouldShowOverlay) {
+bool shouldShowHighlight = options & FindOptionsShowHighlight;
+
 if (maxMatchCount == numeric_limits::max())
 --maxMatchCount;
 
-unsigned matchCount = m_webPage->corePage()->markAllMatchesForText(string, core(options), false, maxMatchCount + 1);
+unsigned matchCount = m_webPage->corePage()->markAllMatchesForText(string, core(options), shouldShowHighlight, maxMatchCount + 1);
 
 // Check if we have more matches than allowed.
 if (matchCount > maxMatchCount) {






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [105746] trunk/Source/WebKit2

[sergio]

Title: [105746] trunk/Source/WebKit2








Revision 105746
Author ser...@webkit.org
Date 2012-01-24 10:03:06 -0800 (Tue, 24 Jan 2012)


Log Message
[WK2] [GTK] TestDownloads hitting an assertion in Debug builds
https://bugs.webkit.org/show_bug.cgi?id=76915

Reviewed by Martin Robinson.

No new tests required as it fixes some assertions in a unit test.

* WebProcess/Downloads/soup/DownloadSoup.cpp:
(WebKit::Download::start):
(WebKit::Download::startWithHandle):

Modified Paths

trunk/Source/WebKit2/ChangeLog
trunk/Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp




Diff

Modified: trunk/Source/WebKit2/ChangeLog (105745 => 105746)

--- trunk/Source/WebKit2/ChangeLog	2012-01-24 18:02:08 UTC (rev 105745)
+++ trunk/Source/WebKit2/ChangeLog	2012-01-24 18:03:06 UTC (rev 105746)
@@ -1,3 +1,16 @@
+2012-01-24  Sergio Villar Senin  
+
+[WK2] [GTK] TestDownloads hitting an assertion in Debug builds
+https://bugs.webkit.org/show_bug.cgi?id=76915
+
+Reviewed by Martin Robinson.
+
+No new tests required as it fixes some assertions in a unit test.
+
+* WebProcess/Downloads/soup/DownloadSoup.cpp:
+(WebKit::Download::start):
+(WebKit::Download::startWithHandle):
+
 2012-01-24  No'am Rosenthal  
 
 [Qt][WK2] Qt's cross-process AC copies images excessively when updating tiles.


Modified: trunk/Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp (105745 => 105746)

--- trunk/Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp	2012-01-24 18:02:08 UTC (rev 105745)
+++ trunk/Source/WebKit2/WebProcess/Downloads/soup/DownloadSoup.cpp	2012-01-24 18:03:06 UTC (rev 105746)
@@ -132,8 +132,8 @@
 
 void Download::start(WebPage* initiatingWebPage)
 {
-ASSERT(m_downloadClient);
-ASSERT(m_resourceHandle);
+ASSERT(!m_downloadClient);
+ASSERT(!m_resourceHandle);
 m_downloadClient = adoptPtr(new DownloadClient(this));
 m_resourceHandle = ResourceHandle::create(0, m_request, m_downloadClient.get(), false, false);
 didStart();
@@ -141,8 +141,8 @@
 
 void Download::startWithHandle(WebPage* initiatingPage, ResourceHandle* resourceHandle, const ResourceResponse&)
 {
-ASSERT(m_downloadClient);
-ASSERT(m_resourceHandle);
+ASSERT(!m_downloadClient);
+ASSERT(!m_resourceHandle);
 m_downloadClient = adoptPtr(new DownloadClient(this));
 resourceHandle->setClient(m_downloadClient.get());
 m_resourceHandle = resourceHandle;






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [105589] trunk/LayoutTests

[sergio]

Title: [105589] trunk/LayoutTests








Revision 105589
Author ser...@webkit.org
Date 2012-01-22 04:50:52 -0800 (Sun, 22 Jan 2012)


Log Message
[GTK] Unreviewed, unskipping passing test.

* platform/gtk/Skipped: unskipped
http/tests/security/mixedContent/empty-url-plugin-in-frame.html

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (105588 => 105589)

--- trunk/LayoutTests/ChangeLog	2012-01-22 11:52:22 UTC (rev 105588)
+++ trunk/LayoutTests/ChangeLog	2012-01-22 12:50:52 UTC (rev 105589)
@@ -1,5 +1,12 @@
 2012-01-22  Sergio Villar Senin  
 
+[GTK] Unreviewed, unskipping passing test.
+
+* platform/gtk/Skipped: unskipped
+http/tests/security/mixedContent/empty-url-plugin-in-frame.html
+
+2012-01-22  Sergio Villar Senin  
+
 [GTK] Unreviewed, unskipping test passing after r79655.
 
 * platform/gtk/Skipped: unskipped http/tests/incremental/slow-utf8-html.pl


Modified: trunk/LayoutTests/platform/gtk/Skipped (105588 => 105589)

--- trunk/LayoutTests/platform/gtk/Skipped	2012-01-22 11:52:22 UTC (rev 105588)
+++ trunk/LayoutTests/platform/gtk/Skipped	2012-01-22 12:50:52 UTC (rev 105589)
@@ -463,7 +463,6 @@
 # Missing delegates:
 # Need proper frame loader callbacks reporting
 # See https://bugs.webkit.org/show_bug.cgi?id=32170
-http/tests/security/mixedContent/empty-url-plugin-in-frame.html
 fast/loader/file-protocol-fragment.html
 # Tests failing because of missing resource load delegate callbacks.
 fast/loader/main-document-url-for-non-http-loads.html






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [105588] trunk/LayoutTests

[sergio]

Title: [105588] trunk/LayoutTests








Revision 105588
Author ser...@webkit.org
Date 2012-01-22 03:52:22 -0800 (Sun, 22 Jan 2012)


Log Message
[GTK] Unreviewed, unskipping test passing after r79655.

* platform/gtk/Skipped: unskipped http/tests/incremental/slow-utf8-html.pl

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/Skipped




Diff

Modified: trunk/LayoutTests/ChangeLog (105587 => 105588)

--- trunk/LayoutTests/ChangeLog	2012-01-22 10:12:03 UTC (rev 105587)
+++ trunk/LayoutTests/ChangeLog	2012-01-22 11:52:22 UTC (rev 105588)
@@ -1,5 +1,11 @@
 2012-01-22  Sergio Villar Senin  
 
+[GTK] Unreviewed, unskipping test passing after r79655.
+
+* platform/gtk/Skipped: unskipped http/tests/incremental/slow-utf8-html.pl
+
+2012-01-22  Sergio Villar Senin  
+
 [GTK] DumpRenderTree converts "file:///" to a path differently
 https://bugs.webkit.org/show_bug.cgi?id=76631
 


Modified: trunk/LayoutTests/platform/gtk/Skipped (105587 => 105588)

--- trunk/LayoutTests/platform/gtk/Skipped	2012-01-22 10:12:03 UTC (rev 105587)
+++ trunk/LayoutTests/platform/gtk/Skipped	2012-01-22 11:52:22 UTC (rev 105588)
@@ -104,9 +104,6 @@
 # https://bugs.webkit.org/show_bug.cgi?id=50744
 inspector/debugger/open-close-open.html
 
-# https://bugs.webkit.org/show_bug.cgi?id=55135
-http/tests/incremental/slow-utf8-html.pl
-
 # [GTK] fast/workers/storage/use-same-database-in-page-and-workers.html fails an ASSERT
 # https://bugs.webkit.org/show_bug.cgi?id=56147 
 # Fails assertion: ASSERT(m_workerContext->hasOneRef());






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [105587] trunk

[sergio]

Title: [105587] trunk








Revision 105587
Author ser...@webkit.org
Date 2012-01-22 02:12:03 -0800 (Sun, 22 Jan 2012)


Log Message
[GTK] DumpRenderTree converts "file:///" to a path differently
https://bugs.webkit.org/show_bug.cgi?id=76631

Reviewed by Martin Robinson.

Tools:

DumpRenderTree should print "/" as the last path component if the
path is a lone slash instead of empty output.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(webViewConsoleMessage):

LayoutTests:

Unskipped a couple of tests after fix.

* platform/gtk/Skipped:

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk/Skipped
trunk/Tools/ChangeLog
trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp




Diff

Modified: trunk/LayoutTests/ChangeLog (105586 => 105587)

--- trunk/LayoutTests/ChangeLog	2012-01-22 09:11:49 UTC (rev 105586)
+++ trunk/LayoutTests/ChangeLog	2012-01-22 10:12:03 UTC (rev 105587)
@@ -1,3 +1,14 @@
+2012-01-22  Sergio Villar Senin  
+
+[GTK] DumpRenderTree converts "file:///" to a path differently
+https://bugs.webkit.org/show_bug.cgi?id=76631
+
+Reviewed by Martin Robinson.
+
+Unskipped a couple of tests after fix.
+
+* platform/gtk/Skipped:
+
 2012-01-21  Adam Barth  
 
 Add baselines for test after http://trac.webkit.org/changeset/105575.


Modified: trunk/LayoutTests/platform/gtk/Skipped (105586 => 105587)

--- trunk/LayoutTests/platform/gtk/Skipped	2012-01-22 09:11:49 UTC (rev 105586)
+++ trunk/LayoutTests/platform/gtk/Skipped	2012-01-22 10:12:03 UTC (rev 105587)
@@ -1633,10 +1633,5 @@
 # Needs custom policy delegate enhancement to log downloads
 http/tests/download
 
-# [GTK] DumpRenderTree converts "file:///" to a path differently
-# https://bugs.webkit.org/show_bug.cgi?id=76631
-http/tests/misc/drag-over-iframe-invalid-source-crash.html
-http/tests/misc/iframe-invalid-source-crash.html
-
 # https://bugs.webkit.org/show_bug.cgi?id=76632
 fast/forms/implicit-submission.html


Modified: trunk/Tools/ChangeLog (105586 => 105587)

--- trunk/Tools/ChangeLog	2012-01-22 09:11:49 UTC (rev 105586)
+++ trunk/Tools/ChangeLog	2012-01-22 10:12:03 UTC (rev 105587)
@@ -1,3 +1,16 @@
+2012-01-22  Sergio Villar Senin  
+
+[GTK] DumpRenderTree converts "file:///" to a path differently
+https://bugs.webkit.org/show_bug.cgi?id=76631
+
+Reviewed by Martin Robinson.
+
+DumpRenderTree should print "/" as the last path component if the
+path is a lone slash instead of empty output.
+
+* DumpRenderTree/gtk/DumpRenderTree.cpp:
+(webViewConsoleMessage):
+
 2012-01-20  David Levin  
 
 The leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less false positives.


Modified: trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp (105586 => 105587)

--- trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp	2012-01-22 09:11:49 UTC (rev 105586)
+++ trunk/Tools/DumpRenderTree/gtk/DumpRenderTree.cpp	2012-01-22 10:12:03 UTC (rev 105587)
@@ -842,7 +842,9 @@
 gchar* filename = g_strrstr(uriScheme, G_DIR_SEPARATOR_S);
 
 if (filename) {
-filename += strlen(G_DIR_SEPARATOR_S);
+// If the path is a lone slash, keep it to avoid empty output.
+if (strlen(filename) > 1)
+filename += strlen(G_DIR_SEPARATOR_S);
 tempString = g_string_append_len(tempString, message, (uriScheme - message));
 tempString = g_string_append_len(tempString, filename, strlen(filename));
 testMessage = g_string_free(tempString, FALSE);






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [105286] trunk/Source/WebCore

[sergio]

Title: [105286] trunk/Source/WebCore








Revision 105286
Author ser...@webkit.org
Date 2012-01-18 09:40:46 -0800 (Wed, 18 Jan 2012)


Log Message
[GTK] [regression] A couple of tests failing after r105253
https://bugs.webkit.org/show_bug.cgi?id=76549

Reviewed by Gustavo Noronha Silva.

Fixes a regression added by r105253. The method that
RenderThemeGtk needs to overwrite is popsMenuBySpaceOrReturn()
instead of popsMenuByArrowKeys().

No new tests as it's already covered by
fast/forms/select-popup-pagekeys.html and
fast/forms/select/menulist-onchange-fired-with-key-up-down.html
that started to fail after the revision mentioned above.

* platform/gtk/RenderThemeGtk.h:
(WebCore::RenderThemeGtk::popsMenuBySpaceOrReturn):

Modified Paths

trunk/Source/WebCore/ChangeLog
trunk/Source/WebCore/platform/gtk/RenderThemeGtk.h




Diff

Modified: trunk/Source/WebCore/ChangeLog (105285 => 105286)

--- trunk/Source/WebCore/ChangeLog	2012-01-18 17:35:27 UTC (rev 105285)
+++ trunk/Source/WebCore/ChangeLog	2012-01-18 17:40:46 UTC (rev 105286)
@@ -1,3 +1,22 @@
+2012-01-18  Sergio Villar Senin  
+
+[GTK] [regression] A couple of tests failing after r105253
+https://bugs.webkit.org/show_bug.cgi?id=76549
+
+Reviewed by Gustavo Noronha Silva.
+
+Fixes a regression added by r105253. The method that
+RenderThemeGtk needs to overwrite is popsMenuBySpaceOrReturn()
+instead of popsMenuByArrowKeys().
+
+No new tests as it's already covered by
+fast/forms/select-popup-pagekeys.html and
+fast/forms/select/menulist-onchange-fired-with-key-up-down.html
+that started to fail after the revision mentioned above.
+
+* platform/gtk/RenderThemeGtk.h:
+(WebCore::RenderThemeGtk::popsMenuBySpaceOrReturn):
+
 2012-01-18  Andrey Kosyakov  
 
 Web Inspector: omit compression field in HAR entries for resources coming from cache


Modified: trunk/Source/WebCore/platform/gtk/RenderThemeGtk.h (105285 => 105286)

--- trunk/Source/WebCore/platform/gtk/RenderThemeGtk.h	2012-01-18 17:35:27 UTC (rev 105285)
+++ trunk/Source/WebCore/platform/gtk/RenderThemeGtk.h	2012-01-18 17:40:46 UTC (rev 105286)
@@ -82,7 +82,7 @@
 virtual void systemFont(int propId, FontDescription&) const;
 virtual Color systemColor(int cssValueId) const;
 
-virtual bool popsMenuByArrowKeys() const OVERRIDE { return true; }
+virtual bool popsMenuBySpaceOrReturn() const OVERRIDE { return true; }
 
 #if ENABLE(VIDEO)
 virtual String extraMediaControlsStyleSheet();






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [101393] trunk/Source/WebKit/gtk

[sergio]

Title: [101393] trunk/Source/WebKit/gtk








Revision 101393
Author ser...@webkit.org
Date 2011-11-29 09:36:35 -0800 (Tue, 29 Nov 2011)


Log Message
[GTK] SIGSEV when a WebKitDownload fails
https://bugs.webkit.org/show_bug.cgi?id=72883

Reviewed by Xan Lopez.

After r100769 http status codes >= 400 trigger download
failures. We must ensure that the download is properly cancelled
before clearing the ResourceHandle client to avoid crashes.

* webkit/webkitdownload.cpp:
(DownloadClient::didReceiveResponse):

Modified Paths

trunk/Source/WebKit/gtk/ChangeLog
trunk/Source/WebKit/gtk/webkit/webkitdownload.cpp




Diff

Modified: trunk/Source/WebKit/gtk/ChangeLog (101392 => 101393)

--- trunk/Source/WebKit/gtk/ChangeLog	2011-11-29 17:34:50 UTC (rev 101392)
+++ trunk/Source/WebKit/gtk/ChangeLog	2011-11-29 17:36:35 UTC (rev 101393)
@@ -1,3 +1,17 @@
+2011-11-29  Sergio Villar Senin  
+
+[GTK] SIGSEV when a WebKitDownload fails
+https://bugs.webkit.org/show_bug.cgi?id=72883
+
+Reviewed by Xan Lopez.
+
+After r100769 http status codes >= 400 trigger download
+failures. We must ensure that the download is properly cancelled
+before clearing the ResourceHandle client to avoid crashes.
+
+* webkit/webkitdownload.cpp:
+(DownloadClient::didReceiveResponse):
+
 2011-11-29  Martin Robinson  
 
 [GTK] Custom fonts on surlybikes.com and boingboing.net do not load


Modified: trunk/Source/WebKit/gtk/webkit/webkitdownload.cpp (101392 => 101393)

--- trunk/Source/WebKit/gtk/webkit/webkitdownload.cpp	2011-11-29 17:34:50 UTC (rev 101392)
+++ trunk/Source/WebKit/gtk/webkit/webkitdownload.cpp	2011-11-29 17:36:35 UTC (rev 101393)
@@ -941,6 +941,7 @@
 {
 webkit_download_set_response(m_download, response);
 if (response.httpStatusCode() >= 400) {
+m_download->priv->resourceHandle->cancel();
 webkit_download_error(m_download, ResourceError(errorDomainDownload, response.httpStatusCode(),
 response.url().string(), response.httpStatusText()));
 }






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

[webkit-changes] [100755] trunk

[sergio]

Title: [100755] trunk








Revision 100755
Author ser...@webkit.org
Date 2011-11-18 05:28:21 -0800 (Fri, 18 Nov 2011)


Log Message
[GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=72707

Reviewed by Philippe Normand.

Tools:

Make new-run-webkit-tests use the right path to locate the test
plugin used by WebKitTestRunner.

* Scripts/webkitpy/layout_tests/port/gtk.py:

LayoutTests:

Unskipped a test that is passing now.

* platform/gtk-wk2/Skipped: unskipped plugins/get-url-notify-with-url-that-fails-to-load.html

Modified Paths

trunk/LayoutTests/ChangeLog
trunk/LayoutTests/platform/gtk-wk2/Skipped
trunk/Tools/ChangeLog
trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py




Diff

Modified: trunk/LayoutTests/ChangeLog (100754 => 100755)

--- trunk/LayoutTests/ChangeLog	2011-11-18 13:16:21 UTC (rev 100754)
+++ trunk/LayoutTests/ChangeLog	2011-11-18 13:28:21 UTC (rev 100755)
@@ -1,3 +1,14 @@
+2011-11-18  Sergio Villar Senin  
+
+[GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
+https://bugs.webkit.org/show_bug.cgi?id=72707
+
+Reviewed by Philippe Normand.
+
+Unskipped a test that is passing now.
+
+* platform/gtk-wk2/Skipped: unskipped plugins/get-url-notify-with-url-that-fails-to-load.html
+
 2011-11-18  Steve Block  
 
 Rebaseline svg/custom for Chromium Mac 10.5 CG after http://crrev.com/110543


Modified: trunk/LayoutTests/platform/gtk-wk2/Skipped (100754 => 100755)

--- trunk/LayoutTests/platform/gtk-wk2/Skipped	2011-11-18 13:16:21 UTC (rev 100754)
+++ trunk/LayoutTests/platform/gtk-wk2/Skipped	2011-11-18 13:28:21 UTC (rev 100755)
@@ -74,7 +74,6 @@
 editing/undo/undo-deleteWord.html
 editing/pasteboard/emacs-ctrl-a-k-y.html
 editing/input/emacs-ctrl-o.html
-plugins/get-url-notify-with-url-that-fails-to-load.html
 
 ###
 # TESTS CRASHING


Modified: trunk/Tools/ChangeLog (100754 => 100755)

--- trunk/Tools/ChangeLog	2011-11-18 13:16:21 UTC (rev 100754)
+++ trunk/Tools/ChangeLog	2011-11-18 13:28:21 UTC (rev 100755)
@@ -1,3 +1,15 @@
+2011-11-18  Sergio Villar Senin  
+
+[GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
+https://bugs.webkit.org/show_bug.cgi?id=72707
+
+Reviewed by Philippe Normand.
+
+Make new-run-webkit-tests use the right path to locate the test
+plugin used by WebKitTestRunner.
+
+* Scripts/webkitpy/layout_tests/port/gtk.py:
+
 2011-11-18  Simon Hausmann  
 
 [Qt] WTR and InjectedBundle should not link statically against JSC/WTF


Modified: trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py (100754 => 100755)

--- trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py	2011-11-18 13:16:21 UTC (rev 100754)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/port/gtk.py	2011-11-18 13:28:21 UTC (rev 100755)
@@ -87,7 +87,7 @@
 environment['GTK_MODULES'] = 'gail'
 environment['LIBOVERLAY_SCROLLBAR'] = '0'
 environment['TEST_RUNNER_INJECTED_BUNDLE_FILENAME'] = self._build_path('Libraries', 'libTestRunnerInjectedBundle.la')
-environment['TEST_RUNNER_TEST_PLUGIN_PATH'] = self._build_path('Libraries', 'TestNetscapePlugin')
+environment['TEST_RUNNER_TEST_PLUGIN_PATH'] = self._build_path('TestNetscapePlugin', '.libs')
 environment['WEBKIT_INSPECTOR_PATH'] = self._build_path('Programs', 'resources', 'inspector')
 return environment
 






___
webkit-changes mailing list
webkit-changes@lists.webkit.org
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes