[chromium-dev] Re: chrome browser control for linux/osx

Cool, it sounds like the embedded browser spaces on linux and osx are well accounted for. For the time being I'll continue with an os-agnostic approach because it's relatively painless to do so. Here, then, is the embedded browser framework that I envision, complete with C++ class definitions: h

[chromium-dev] Re: using scoped_refptr in standard library containers

Sorry, it is assignable. I misread the boost documentation -- I saw "swap(x, y)" and thought that meant: template void swap(scoped_ptr & a, scoped_ptr & b); On Tue, Nov 25, 2008 at 10:03 AM, Wan-Teh Chang <[EMAIL PROTECTED]> wrote: > > On Tue, Nov 25, 2008 a

[chromium-dev] Re: using scoped_refptr in standard library containers

Ok, never mind. We're using scoped_refptr in standard library containers already. On Tue, Nov 25, 2008 at 9:43 AM, Marshall Greenblatt <[EMAIL PROTECTED] > wrote: > Hi All, > > In order to use a class in standard library containers it needs to meet the > CopyConst

[chromium-dev] using scoped_refptr in standard library containers

Hi All, In order to use a class in standard library containers it needs to meet the CopyConstructible and Assignable requirements of the C++ Standard Library. These requirements are defined as follows: http://www.boost.org/doc/libs/1_37_0/doc/html/CopyConstructible.html http://www.boost.org/doc/l

[chromium-dev] Re: notifications about wiki document changes

ld be made world-readable? On Mon, Nov 24, 2008 at 4:44 PM, Adam Langley <[EMAIL PROTECTED]> wrote: > > On Mon, Nov 24, 2008 at 1:42 PM, Marshall Greenblatt > <[EMAIL PROTECTED]> wrote: > > Also, it would be nice if there was a simple "diff" tool for seeing

[chromium-dev] notifications about wiki document changes

Is there any way to have the chromium wiki automatically send a notification email to all authors of a particular document when that document is changed? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Chromium-dev"

[chromium-dev] Re: notifications about wiki document changes

Also, it would be nice if there was a simple "diff" tool for seeing what changes have been made with each revision of the document. On Mon, Nov 24, 2008 at 4:35 PM, Marshall Greenblatt <[EMAIL PROTECTED] > wrote: > Is there any way to have the chromium wiki automatically se

[chromium-dev] Re: chrome browser control for linux/osx

dea. Other wrappers of his concept >> besides the ActiveX could be one for MFC - which I could take advantage of. >> >> Daniel A. White >> >> >> >> On Mon, Nov 24, 2008 at 12:04 PM, Marshall Greenblatt < >> [EMAIL PROTECTED]> wrote: >> &g

[chromium-dev] Re: chrome browser control for linux/osx

I've begun the embedded browser framework document here: http://code.google.com/p/chromium/wiki/EmbeddedBrowserFramework --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group. To post to this group, se

[chromium-dev] Re: chrome browser control for linux/osx

dividual functions as callbacks--while this isn't a > common idiom in Windows, it does have some advantages if you're not > trying to create a drop-in replacement for Microsoft's WebBrowser > control. > > --Amanda > > On Mon, Nov 24, 2008 at 10:51 AM, Marshall Gr

[chromium-dev] Re: chrome browser control for linux/osx

r no real benefit. > > > > I can't speak for other platforms, but using COM on the Mac is not needed > > when you have ObjC and its introspection capabilities. I don't see why a > > framework wouldn't do. > > > > Avi > > > > On Sat, Nov

[chromium-dev] chrome browser control for linux/osx

Hi All, As many of you probably know there's been talk of developing a chrome-based ActiveX (COM) control for Windows. But what about other platforms? For OSX, Apple offers a COM-like framework called "Core Foundation Plug-ins": http://developer.apple.com/documentation/CoreFoundation/Conceptual/

[chromium-dev] Re: Quick and dirty chrome embedding test

Hi Brett, On Tue, Nov 18, 2008 at 2:27 PM, Brett Wilson <[EMAIL PROTECTED]> wrote: > > On Tue, Nov 18, 2008 at 11:19 AM, Marshall Greenblatt > <[EMAIL PROTECTED]> wrote: > > > Thanks for your input, I think I understand now. Both the Windows > message >

[chromium-dev] Re: Quick and dirty chrome embedding test

Hi Ben, On Tue, Nov 18, 2008 at 1:37 PM, Ben Goodger (Google) <[EMAIL PROTECTED]>wrote: > > Why are you creating a Browser object? What does that have to do with > embedding? > > -Ben Please review the reference implementation for a better understanding of how I'm currently using Browser object

[chromium-dev] Re: Quick and dirty chrome embedding test

Hi Brett, On Tue, Nov 18, 2008 at 11:12 AM, Brett Wilson <[EMAIL PROTECTED]> wrote: > > On Tue, Nov 18, 2008 at 7:14 AM, Marshall Greenblatt > <[EMAIL PROTECTED]> wrote: > > Hi Brett, > > > > On Tue, Nov 18, 2008 at 9:56 AM, Brett Wilson <[EMAIL PRO

[chromium-dev] Re: Quick and dirty chrome embedding test

Hi Brett, On Tue, Nov 18, 2008 at 9:56 AM, Brett Wilson <[EMAIL PROTECTED]> wrote: > > On Tue, Nov 18, 2008 at 6:50 AM, Marshall Greenblatt > <[EMAIL PROTECTED]> wrote: > > Hi All, > > > > Is it safe to create (via Browser::Create*()) and/or access Brows

[chromium-dev] Re: Quick and dirty chrome embedding test

Hi All, Is it safe to create (via Browser::Create*()) and/or access Browser object instances from multiple threads? In other words, I need to choose one of the following options: A) Synchronize all Browser object creation and access via the main process thread ("single thread model" in COM parla

[chromium-dev] Re: Quick and dirty chrome embedding test

Hi M-A, On Mon, Nov 17, 2008 at 3:04 PM, Marc-Antoine Ruel <[EMAIL PROTECTED]>wrote: > > To add to Amanda's email (I wrote it at the same time) > > You seem overly cautious of saying that you don't want to creating > anything that would compete with Chromium or Google Chrome. Keep in > mind that

[chromium-dev] Re: Quick and dirty chrome embedding test

Hi Amanda, On Mon, Nov 17, 2008 at 3:01 PM, Amanda Walker <[EMAIL PROTECTED]> wrote: > > > As has been mentioned by others, I could more easily fork chrome and > develop > > whatever I choose. However, I prefer an approach that will allow me to > > contribute my changes back to the chrome projec

[chromium-dev] Re: Quick and dirty chrome embedding test

Hi Amanda, On Mon, Nov 17, 2008 at 10:48 AM, Amanda Walker <[EMAIL PROTECTED]> wrote: > > On Mon, Nov 17, 2008 at 10:19 AM, Marshall Greenblatt > <[EMAIL PROTECTED]> wrote: > > Hi M-A, > > > > We all know that development issues can become emotional for

[chromium-dev] Re: Quick and dirty chrome embedding test

Hi M-A, On Mon, Nov 17, 2008 at 9:02 AM, Marc-Antoine Ruel <[EMAIL PROTECTED]>wrote: > > 2008/11/16 Marshall Greenblatt <[EMAIL PROTECTED]>: > > I agree with you on this point. I believe the best solution is to add > > "theme" support to chrome similar to

[chromium-dev] Re: Quick and dirty chrome embedding test

: > > 2008/11/16 Marshall Greenblatt <[EMAIL PROTECTED]>: > > I agree with you on this point. I believe the best solution is to add > > "theme" support to chrome similar to the visual styles support provided > by > > Ah I see, it took me a while to realiz

[chromium-dev] Re: Quick and dirty chrome embedding test

t; > What functionality do you require? What kind of app are you building? Please refer to this thread for additional background on what we're trying to achieve: http://groups.google.com/group/chromium-dev/browse_thread/thread/9d6f282f68c77528# > > > -Ben Regards,

[chromium-dev] Re: Quick and dirty chrome embedding test

Hi Ken, Thank you for your very concise analysis of the licensing question :-). Regards, Marshall On Sun, Nov 16, 2008 at 8:25 PM, Ken Berry <[EMAIL PROTECTED]> wrote: > > Marshall, > > You should ask your attorney if you need to change the language of > your licensing disclosures, but the answ

[chromium-dev] Re: Quick and dirty chrome embedding test

Hi Ben, On Sun, Nov 16, 2008 at 6:21 PM, Ben Goodger (Google) <[EMAIL PROTECTED]>wrote: > > Any embedding should _not_ touch the browser code (and changes to this > code to support it won't be accepted). WebContents/etc is probably the > highest level you want to get. I would probably suggest re-

[chromium-dev] Re: Quick and dirty chrome embedding test

On Sun, Nov 16, 2008 at 5:32 PM, Daniel A. White <[EMAIL PROTECTED]>wrote: > Well they are already using some MPL code. > http://code.google.com/chromium/terms.html :P Hmm. I think most of the code currently licensed under MPL is kept as separate libraries (npapi, npsr, etc). I'm not sure if u

[chromium-dev] Re: Quick and dirty chrome embedding test

On Sun, Nov 16, 2008 at 5:15 PM, Marshall Greenblatt <[EMAIL PROTECTED] > wrote: > > The advantages would be immediate access for people who use only the basic > IWebBrowser2 capabilities (which is probably most of the user base), and the > option to borrow COM code from XULR

[chromium-dev] Re: Quick and dirty chrome embedding test

On Sun, Nov 16, 2008 at 3:32 PM, thetrueaplus <[EMAIL PROTECTED]>wrote: > > I know Microsoft has this interface. IWebBrowser2. > > http://msdn.microsoft.com/en-us/library/aa752127(VS.85).aspx > > Gecko's ActiveX component implement

[chromium-dev] Re: Quick and dirty chrome embedding test

On Sat, Nov 15, 2008 at 1:37 AM, Marshall Greenblatt <[EMAIL PROTECTED] > wrote: > To test the feasibility of turning Chrome into a multi-process ActiveX > control I'm going to implement a simple experiment sans COM. The goal of > this experiment is to have a client applicati

[chromium-dev] Re: Quick and dirty chrome embedding test

Hi M-A, Thank you for your questions :-). On Sat, Nov 15, 2008 at 2:21 PM, Marc-Antoine Ruel <[EMAIL PROTECTED]>wrote: > > Have you thought about other possible implementations? We're still very much in the exploratory stage, and so all options are currently on the table. The final solution w

[chromium-dev] Quick and dirty chrome embedding test

Hi All, To test the feasibility of turning Chrome into a multi-process ActiveX control I'm going to implement a simple experiment sans COM. The goal of this experiment is to have a client application launch chrome.exe programatically as a separate process, and have the chrome process then create

[chromium-dev] Re: Embedding Chromium

Hi Daniel, On Fri, Nov 14, 2008 at 11:32 AM, Daniel A. White <[EMAIL PROTECTED]>wrote: > I just found this Chromium rendering engine called Awesomium. > > Daniel A. White > Alas, Awesomium does not support the "value-added" browser-like capabilities that we would want in our ActiveX control. Wh

[chromium-dev] Re: Embedding Chromium

Hi Amanda, On Fri, Nov 14, 2008 at 10:56 AM, Amanda Walker <[EMAIL PROTECTED]> wrote: > > It depends a little on what you want to do. Do you want to embed the > entire UI, tab strip and all, or do you want to embed web views? It > sounds a little from your description that you're reinventing th

[chromium-dev] Re: Embedding Chromium

On Fri, Nov 14, 2008 at 1:44 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > > Marshall Greenblatt <[EMAIL PROTECTED]> wrote: > > I think it would be nice to leverage chromium's multi-process > architecture > > in a COM context. The chromium browser process wou

[chromium-dev] Re: Embedding Chromium

On Thu, Nov 13, 2008 at 11:42 PM, Darin Fisher <[EMAIL PROTECTED]> wrote: > > > > I'm familiar with straight COM C++ and MIDL and can imagine how that might > look, but I don't know enough about the issues with ATL. I've heard some > objections to ATL in the past. > > At any rate, it'd be good to

[chromium-dev] Re: Embedding Chromium

Hi Darin, On Thu, Nov 13, 2008 at 7:14 PM, Darin Fisher <[EMAIL PROTECTED]> wrote: > There is no existing COM-style Chrome component that can be easily embedded > for web rendering. > -Darin > Do you (or Google, or Chromium) have a preference when it comes to COM frameworks? It would be nice to

[chromium-dev] Re: not using PLATFORM(GTK)

On Fri, Oct 17, 2008 at 1:58 PM, Adam Treat <[EMAIL PROTECTED]> wrote: > > On Thursday 16 October 2008 8:04:19 pm Evan Martin wrote: > > What we discussed today is the leftover bits: those not covered by > > CHROMIUM but potentially by GTK (for example, font drawing). What I > > think we conclude

[chromium-dev] Re: Adding embedded NPAPI plug-in capability

Hi Amanda, On Thu, Oct 16, 2008 at 3:53 PM, Amanda Walker <[EMAIL PROTECTED]> wrote: > > On Thu, Oct 16, 2008 at 3:20 PM, Marshall Greenblatt > <[EMAIL PROTECTED]> wrote: > > I'm exploring the best way to embed a plug-in within the browser control > > wher

[chromium-dev] Adding embedded NPAPI plug-in capability

Hi All, The context for this conversation is the chromium-based embedded browser control described in a previous thread: http://groups.google.com/group/chromium-dev/browse_thread/thread/5b23e1a218811b3d I'm exploring the best way to embed a plug-in within the browser control where the plug-in is

[chromium-dev] Re: PSA: Review mail best practices

Hi Peter, On Wed, Oct 8, 2008 at 8:06 PM, Peter Kasting <[EMAIL PROTECTED]> wrote: > Two recommendations for folks participating in code reviews using Rietveld > (codereview.chromium.org): > (2) When reviewing a patch or responding to review comments, use the same > Publish+Mail Comments link to

[chromium-dev] Re: Wish list for printing support refactor

Sorry, forgot to CC the list. On Sun, Oct 5, 2008 at 7:38 PM, Marshall Greenblatt <[EMAIL PROTECTED]>wrote: > Hi M-A, > > On Sun, Oct 5, 2008 at 4:25 PM, Marc-Antoine Ruel <[EMAIL PROTECTED]>wrote: > >> 2008/10/5 Marshall Greenblatt <[EMAIL PROTECTED]>: >&g

[chromium-dev] Re: Wish list for printing support refactor

Hi Peter, On Sun, Oct 5, 2008 at 8:30 PM, Peter Kasting <[EMAIL PROTECTED]> wrote: > On Sun, Oct 5, 2008 at 4:46 PM, Marshall Greenblatt < > [EMAIL PROTECTED]> wrote: > >> At a minimum I think we should show print spool progress and provide the >> ability to c

[chromium-dev] Re: Wish list for printing support refactor

Hi Ben, On Sun, Oct 5, 2008 at 5:37 PM, Ben Goodger (Google) <[EMAIL PROTECTED]>wrote: > > Hi Marshall, > > If you reach a point where you need to start thinking about UI, please > send a followup email describing what needs to be conveyed and we can > produce mocks. In general, we try to avoid d

[chromium-dev] Re: Wish list for printing support refactor

ou have the code for the previous print preview implementation sitting around somewhere? At a particular revision, perhaps? It would be good for my understanding if I could take a look at it. > More below. > > 2008/10/5 Marshall Greenblatt <[EMAIL PROTECTED]>: > > Hi All, >

[chromium-dev] Wish list for printing support refactor

Hi All, What changes would we like to see in a refactoring of printing support? At a minimum, we need to... A) Move printing support into a separate module. B) Provide a proxy layer to support chrome IPC. C) Add printing support to test_shell. We might also want to... D) Simplify the printing

[chromium-dev] Re: V8 global context and V8 differences between chromium and gears

A patch set implementing the changes discussed in this thread is now available for review. http://codereview.chromium.org/6482 Regards, Marshall --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group.

[chromium-dev] Re: V8 global context and V8 differences between chromium and gears

Hi Mike, On Wed, Oct 1, 2008 at 1:02 PM, Mike Belshe <[EMAIL PROTECTED]> wrote: > > Generally, I don't think you should touch the bridge (btw - the bridge is > going away as we reconcile differences w/ webkit- it will be the > scriptController, I believe). > > I don't have source in front of me;

[chromium-dev] Re: V8 global context and V8 differences between chromium and gears

Hi Mike, On Wed, Oct 1, 2008 at 4:02 AM, Mike Belshe <[EMAIL PROTECTED]> wrote: > You should be able to use v8::Array for this; (see v8.h). > Create your array: > > v8::Local array = v8::Array::New(); > for (int index = 0; index < myStdStrings.length(); ++index) > array->Set(v8::Integer::

[chromium-dev] Re: V8 global context and V8 differences between chromium and gears

Hi Mike, On Tue, Sep 30, 2008 at 8:34 PM, Mike Belshe <[EMAIL PROTECTED]> wrote: > Hi, Marshall, > I'm not quite sure what you are trying to do; a frame-independent script > object is generally something we'd try not to do. I admit, I'm not up to > speed with what Gears may have needed to do to

[chromium-dev] Re: V8 global context and V8 differences between chromium and gears

On Tue, Sep 30, 2008 at 4:18 PM, Marshall Greenblatt <[EMAIL PROTECTED] > wrote: > (Cross-listed to chromium-dev and v8-dev. Please CC me on any response.) > > Hi All, > > In the gears version of V8, we have the following method for retrieving a > V8 context: > > v8

[chromium-dev] V8 global context and V8 differences between chromium and gears

(Cross-listed to chromium-dev and v8-dev. Please CC me on any response.) Hi All, In the gears version of V8, we have the following method for retrieving a V8 context: v8::Local GetV8Context(); It was therefore hypothetically possible to create a Frame-independent NPScriptObject instance using

[chromium-dev] Re: WebKit merge landing tomorrow afternoon

Hi Eric, Is there a document somewhere that describes the changes that we can expect? Regards, Marshall On Mon, Sep 29, 2008 at 6:00 PM, Eric Seidel <[EMAIL PROTECTED]> wrote: > > We plan to land the webkit_merge_branch onto trunk tomorrow afternoon. > http://src.chromium.org/svn/branches/chrom

[chromium-dev] Re: Pass the invoked JavaScript method name as an argument to the fallback callback

Hi Feng, If you wouldn't mind, please give us your opinion on this question. Evan Martin says you might have already responded, but if you did we've somehow managed to misplace it :-(... Thanks, Marshall On Wed, Sep 24, 2008 at 10:45 PM, Marshall Greenblatt < [EMAIL PROTECTED]&

[chromium-dev] Re: Correct way to create an NPObject for assignment to CppVariant

approach be more appropriate? Thanks for you time. Regards, Marshall On Mon, Sep 29, 2008 at 4:19 PM, Aaron Boodman <[EMAIL PROTECTED]> wrote: > > On Mon, Sep 29, 2008 at 1:06 PM, Marshall Greenblatt > <[EMAIL PROTECTED]> wrote: > > Perhaps these questions are a bit t

[chromium-dev] Re: Correct way to create an NPObject for assignment to CppVariant

On Sat, Sep 27, 2008 at 6:31 PM, Marshall Greenblatt <[EMAIL PROTECTED] > wrote: > Hi All, > > What is the correct way to create an NPObject for assignment to a > CppVariant instance? The CppVariant instance in this case represents the > return value from a CppBoundClass c

[chromium-dev] Correct way to create an NPObject for assignment to CppVariant

Hi All, What is the correct way to create an NPObject for assignment to a CppVariant instance? The CppVariant instance in this case represents the return value from a CppBoundClass callback. For example, is it necessary to create my own static class object, or can I use V8NPObjectClass (or some

[chromium-dev] Adding additional vector handling methods to CppVariant

Hi All, I'd like to add a full compliment of vector handling methods to the webkit/glue/CppVariant class. The methods I'm proposing are as follows: // Methods for retrieving vectors of different data types std::vector ToStringVector() const; // this method already exists std::vector ToInt32Vecto

[chromium-dev] Re: Embedded Browser Control Synopsis

Hi M-A, On Sat, Sep 20, 2008 at 1:50 PM, Marc-Antoine Ruel <[EMAIL PROTECTED]>wrote: > > Ok fine, I can't give you any guidance if your changes would be > accepted, sorry. That seems interesting though and I'd be interested > in adding printing support to test_shell. > > M-A > No worries, your q

[chromium-dev] Re: Embedded Browser Control Synopsis

Hi M-A, On Sat, Sep 20, 2008 at 9:39 AM, Marc-Antoine Ruel <[EMAIL PROTECTED]>wrote: > > It's a fair amount of work, you have enough time to implement that? I > can't tell about whether we'd accept the patches or not. I'd accept > the move of printing classes to base though. I've already implem

[chromium-dev] Embedded Browser Control Synopsis

Hi All, As I've mentioned a few times on this list, I'm developing an embedded browser control based on the test_shell project. Below is a synopsis of the design that I've implemented. If there is interest in seeing this included as part of the chromium code base then I'll make an effort to re-f

[chromium-dev] Re: Accessing the invoked method name from the JavaScript callback

Hi Evan, On Fri, Sep 19, 2008 at 2:13 PM, Evan Martin <[EMAIL PROTECTED]> wrote: > > > I believe within a given execution context it's synchronous, but for > cleanliness anyway I'd prefer 2 or 3. 2 sounds more sane to me; the > only reason we have a fallback callback (I believe) is for one test.

[chromium-dev] Accessing the invoked method name from the JavaScript callback

Hi All, It would be helpful if CppBoundClass provided a means to discover the method name that was used to invoke a JavaScript callback. This is particularly true for the fallback callback. There are a number of ways in which we could support this functionality: 1. Set a member variable to the

[chromium-dev] Re: code style verification/formatting tool

Hi Mark/Pam, On Thu, Sep 18, 2008 at 2:48 PM, Mark Mentovai <[EMAIL PROTECTED]> wrote: > > Great question. We've been talking about open-sourcing something for > this, but so far, we don't have anything yet. We do have something we > use internally, but someone needs to go through it and clean u

[chromium-dev] code style verification/formatting tool

Hi All, Does a tool currently exist for verifying and/or formatting source code based on the Google style guide? If not, has any thought been given to developing such a tool? Something like lint, but perhaps more modular, would be a great help to people who don't live and breathe Google style ev

[chromium-dev] Re: Add DumpDocumentString() function to webkit_glue

Hi Darin, On Wed, Sep 17, 2008 at 10:48 PM, Darin Fisher <[EMAIL PROTECTED]> wrote: > > Why not use the view source rendering mode? There's an API for that > on WebFrame. It seems that the view source rendering mode is only for rendering the source HTML in the web browser? That's good for a b

[chromium-dev] Re: Add DumpDocumentString() function to webkit_glue

Hi Evan, On Wed, Sep 17, 2008 at 1:23 PM, Evan Martin <[EMAIL PROTECTED]> wrote: > > On Wed, Sep 17, 2008 at 8:43 AM, Marshall Greenblatt > <[EMAIL PROTECTED]> wrote: > > This function is like DumpDocumentText() but returns the complete > document > > string

[chromium-dev] Add DumpDocumentString() function to webkit_glue

Hl All, The following patch adds a DumpDocumentString() function to webkit_glue: http://www.magpcss.net/patches/chromium_webkitglue_newfunc_rev2305.diff This function is like DumpDocumentText() but returns the complete document string (HTML, for instance) instead of just the text representation.

[chromium-dev] Re: Retrieving pending request data before the request is submitted

Hi Brett, The below patch adds GetHttpHeaders(), HasRequestPostData() and GetRequestPostData() methods to the WebRequest class. http://www.magpcss.net/patches/chromium_weburlrequest_newfields_rev2228.diff Are you the right person to review this, or is there someone else I should contact? Thanks

[chromium-dev] Re: Retrieving pending request data before the request is submitted

Hi Brett, I'm creating an embedded browser control based on the test_shell project. My intent is for the DispositionForNavigationAction() method to have all of the request information available for inspection, similar to the BeforeNavigate2() method of Microsoft's web browser control. If there's

[chromium-dev] Re: Text rendering problem when printing from test_shell

Hi Marc-Antoine, I've managed to fix the printing scale problem by using the routines provided in SkCanvas. Below is the updated (working) code for TestShell::PrintPage(). I'll look into developing a commit-able patch based on your feedback, but that will likely take some time -- feel free not

[chromium-dev] Re: Text rendering problem when printing from test_shell

On Sep 11, 12:20 pm, "Marc-Antoine Ruel" <[EMAIL PROTECTED]> wrote: > I disagree with the debug flag. The main issue right now is that you > include chrome/* from webkit/*. That violates the current hierarchy. > The PrintingContext class will need to be moved. > Also, you'll have to turn off tab g

[chromium-dev] Re: Text rendering problem when printing from test_shell

Hi Marc-Antoine, Thank you for your fast response! I've made my work-in-progress patches available here: http://www.magpcss.net/patches/chromium_test_shell_printing_rev2056.diff Most of the changes are in the webkit/tools/test_shell/ folder, but one small change was required to the PrintingCont

<    1   2